date:20150903

[Koha-bugs] [Bug 11371] Add a new report : Orders by budget

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371

jmbroust  changed:

   What|Removed |Added

 CC||jean-manuel.broust@univ-lyo
   ||n2.fr
 Status|Needs Signoff   |Failed QA

--- Comment #23 from jmbroust  ---
Everything seems ok except the csv file where some columns don't have the right
datas : 
column "basket by" contains the name of the basket
column "biblionumber" contains librarian id
column title contains biblionumber
currency contains Title
Vendor price contains Currency
etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #42194|0   |1
is obsolete||

--- Comment #16 from Marcel de Rooy  ---
Created attachment 42325
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42325=edit
Bug 14509: (follow-up) Reject invalid passwords

The members.js was not included in member-password.tt
And it cannot, there are specific code which cannot be used outside of
memberentry.tt

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

--- Comment #15 from Marcel de Rooy  ---
Created attachment 42324
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42324=edit
Bug 14509: Reject invalid passwords

Bug 10177 rejects password with leading or trailing whitespaces, but
only on the member-password page.
It's not consistent to only do this check on 1 place.
This patch adds the check for the 2 other places: memberentry and at the
OPAC.

Test plan:
1/ Edit a patron and set a password with leading and/or trailing
whitespaces. You should not be allowed to do it (no server side check).
2/ Same at the OPAC ("Change you password" tab). Here there is a server
side check.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #41295|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14419] Expanding facets (Show more) performs a new search

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14419

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||neng...@gmail.com

--- Comment #4 from Nicole C. Engard  ---
After I apply this patch I can't click 'Show More' at all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #2 from Marc Véron  ---
Created attachment 42330
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42330=edit
[Signed-off] Bug 14699: Fix intranet search history issues due to pagination

DataTables removes hidden rows from the DOM. Because of that, "Select
all", "Clear all" and the form submission don't work correctly
(basically they act only on the currently displayed page).

This patch fixes just that.

Test plan:
1/ Go to your search history page
2/ Make you sure you have at least 21 entries in your search history. If
not, do some searches and come back here.
3/ Click "Select all" and change page. The checkboxes on the new page
should be checked.
4/ Check some checkboxes on this new page and click "Clear all". Go back
to the previous page, checkboxes shouldn't be checked.
5/ Check some checkboxes on at least 2 different pages and click
"Delete". All selected search history entries should be deleted.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #41734|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14779] reviewswaiting.pl paging is not working

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

--- Comment #1 from Blou  ---
Created attachment 42335
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42335=edit
Bug 14779 - Cannot paginate reviews

When having more than 20 (or numSearchResults) reviews waiting to be approved
in /cgi-bin/koha/reviews/reviewswaiting.pl?status=1,
the paging at the bottom only offset by 1 entry, instead of moving a full page
(20 entries) ahead.

The simple fix uses 'page' instead of 'offset'.

TEST:
1) Modify numSearchResult preference to a low (5?) value.
2) create X comments, where X is greater than the value above.
3) approve them all (although this step is probably unnecessary)
4) Go to tools >> comments (approved comments tab)
5) You see X entries.  Click on page 2 at bottom.  Link should show "offset=2")
6) You get same results, except the first one which "slided out".

Apply patch, redo step 4-5.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

--- Comment #13 from Kyle M Hall  ---
Created attachment 42341
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42341=edit
Bug 14297 [QA Followup] - Remove unnecessary line

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #2 from Marc Véron  ---
Created attachment 42346
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42346=edit
[Signed-off] Bug 12426: Allow resending of messages from the notices tab in the
patron account

This patch adds a link 'Resend' under a notice in 'failed' status
in the Patron's Notices tab.

By clicking the link, we will request notices.pl with parameter
"resendnotice=X" where X is message_id. In notices.pl,
we then check whether the given message is actually in 'failed'
status. If so, we use the C4::Letters::_set_message_status() to
change the status of the message into 'pending'. This way it
will be processed again by the cronjob process_message_queue.pl.

To test, find/create a Patron that has failed notices in message_queue:
1. Enable EnchancedMessagingPreferences system preference
2. Go to Patrons -> Notices
3. In the Notice column, click the title of the failed message
4. Observe that there is nothing for resending the failed message
5. Apply patch.
6. Reload Notices page and repeat step 3
7. Observe that there is now a link "Resend" in the Status-column
8. Click Resend
9. Observe that the message gets into 'pending' status

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14774] Task Scheduler not working on Ubuntu/Apache2.4

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14774

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Assignee|gmcha...@gmail.com  |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] Get rid of DBIx::Connector

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Jonathan Druart  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz,
   ||fridolin.som...@biblibre.co
   ||m,
   ||olli-antti.kivila...@jns.fi
   ||, pianohac...@gmail.com,
   ||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] Get rid of DBIx::Connector

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #2 from Jonathan Druart  
---
What about this patch guys?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14760] Disabled courses display in the course reserves list for items

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14354] Only superlibrarian should see edit links for other branches' items in staff detail

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14779] New: reviewswaiting.pl paging is not working

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

Bug ID: 14779
   Summary: reviewswaiting.pl paging is not working
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

When having more than 20 (or numSearchResults) reviews waiting to be approved
in /cgi-bin/koha/reviews/reviewswaiting.pl?status=1, the paging at the
bottom only offset by 1 entry, instead of moving a full page (20 entries)
ahead.

TEST:
1) Modify numSearchResult preference to a low (5?) value.
2) create X comments, where X is greater than the value above.
3) approve them all (although this step is probably unnecessary)
4) Go to tools >> comments (approved comments tab)
5) You see X entries.  Click on page 2 at bottom.  Link should show "offset=2")
6) You get same results, except the first one which "slided out".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14734] Enhance 264 display in OPAC and Staff XSLT

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14734

--- Comment #1 from Winona Salesky  ---
Reading through the LOC page on this field I see that the latest 264 fields can
be indicated by ind1=3. I would like to add ind1=3 as a filter to suppress
obsolete 264 fields. This is certainly up for discussion if users feel the
ind1=3 is not widely utilized. 

Thanks, 
-Winona

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14780] New: Datetime format seems

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14780

Bug ID: 14780
   Summary: Datetime format seems
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: eugen...@yahoo.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 42345
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42345=edit
01

In Circulation module, when using the datetime picker in Checkout, I am getting
the following error:

Software error:

The 'month' parameter ("29") to DateTime::new did not pass the 'an integer
between 1 and 12' callback
 at /usr/lib/perl5/DateTime.pm line 199
DateTime::new(undef, 'hour', 09, 'minute', 00, 'second', 0, 'month',
29, ...) called at /home/koha/src/Koha/DateUtils.pm line 164
Koha::DateUtils::dt_from_string('09/29/2015 09:00') called at
/home/koha/src/circ/circulation.pl line 170

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14760] Disabled courses display in the course reserves list for items

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14760] Disabled courses display in the course reserves list for items

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42328|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 42347
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42347=edit
Bug 14760 - Disabled courses display in the course reserves list for items

If an item is on reserve for two courses but one of those courses is
disabled, both courses are still listed on opac-detail.pl!

Test Plan:
1) Enable course reserves
2) Create two courses
3) Place one item on reserve for both courses
4) Disable one of the two courses
5) View the record details for that record/item
6) You should see both courses listed in the course reserves column
7) Apply this patch
8) Reload the page
9) You should now only see the active course in the course reseves column

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Jerwyn  changed:

   What|Removed |Added

 CC||os.jerwynfernan...@gmail.co
   ||m

--- Comment #32 from Jerwyn  ---
If were not mistaken, nothing happen with the patch.

Kind regards,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #241 from Jonathan Druart  
---
Created attachment 42333
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42333=edit
Bug 10855: (follow-up) Bug 10855: Remove additional field values when
subscription is removed

The subscriptionid should not be escaped and placeholders used.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #242 from Jonathan Druart  
---
Back in the RM queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

Kyle M Hall  changed:

   What|Removed |Added

Version|3.18|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14779] reviewswaiting.pl paging is not working

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14779

Blou  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |philippe.blo...@inlibro.com
 CC||eric.be...@inlibro.com,
   ||francois.charbonnier@inlibr
   ||o.com
   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14771] allow patrons to pick a username

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14771

Nicole C. Engard  changed:

   What|Removed |Added

Summary|all patrons to pick a   |allow patrons to pick a
   |username|username

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42331|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 42342
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42342=edit
Bug 14717: Invalid dates in debarred column

To test
1/ Import a patron using the patron import tool, make sure they have
no debarred column in the file
2/ Check the database, notice the debarred column is -00-00
3/ For bonus points, checkout an item to that borrower, then check it in
notice Koha errors
4/ Apply patch
5/ Import a new patron
6/ Notice column is now NULL and that checkins work

Signed-off-by: Eugene Espinoza 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14354] Only superlibrarian should see edit links for other branches' items in staff detail

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354

--- Comment #2 from Marc Véron  ---
Created attachment 42334
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42334=edit
[Signed-off] Bug 14354: Prevent edition of items from other branches if
IndependentBranches is on

If IdependentBranches is ON, to edit/delete items from other branches
you need to be superlibrarian.
Currently a "simple" staff user cannot edit them from the edit item page
but from the catalogue detail page.

The edit links should not be displayed on this table.

Test plan:
O/ Set IndependentBranches to "Prevent".
Create a record and add 2 items:
   Set homebranch to L1 for item I1.
   Set homebranch to L2 for item I2.
1/ With a superlibrarian user, you should be able to edit both items.
2/ With a "simple" user attached to L1, you should only be able to edit
I1. The edit links should not be displayed for I2.

Note that the checkbox is displayed on the catalogue detail page (item
list), but on the batch tools, it won't be possible to select non-modifiable
items.

TODO: Add a server-side check. Indeed it is still possible to edit an
item if the user know the url.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #42295|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
What you describe is the expected behavior, I think.
With your patch if you filter the table and click "select all", it will select
all row, even the filtered ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14760] Disabled courses display in the course reserves list for items

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
Note that this already works at the intranet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14778

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #41871|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 42331
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42331=edit
[SIGNED-OFF] Bug 14717: Invalid dates in debarred column

To test
1/ Import a patron using the patron import tool, make sure they have
no debarred column in the file
2/ Check the database, notice the debarred column is -00-00
3/ For bonus points, checkout an item to that borrower, then check it in
notice Koha errors
4/ Apply patch
5/ Import a new patron
6/ Notice column is now NULL and that checkins work

Signed-off-by: Eugene Espinoza 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #64 from Genevieve  ---
Created attachment 42323
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42323=edit
Bug 10937 - Fix Seach Type in Advanced Search

In order to see the checkboxes of the Collection and Shelving location of the
advanced search, the if changed so that only the Itemtypes will go through the
previous if

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Eugene Espinoza  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||eugen...@yahoo.com

--- Comment #3 from Eugene Espinoza  ---
I tested this during GBSD together with Kyle. And the patch works!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42310|0   |1
is obsolete||

--- Comment #240 from Jonathan Druart  
---
Created attachment 42332
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42332=edit
Bug 10855: Remove additional field values when subscription is removed

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #42288|0   |1
is obsolete||

--- Comment #57 from Alex Arnaud  ---
Created attachment 42337
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42337=edit
Bug 9223: Add SupportsAuthorizedValues syspref (followup 1)

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #42287|0   |1
is obsolete||

--- Comment #56 from Alex Arnaud  ---
Created attachment 42336
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42336=edit
Bug 9223: Multiple values of AdvancedSearchTypes in suggestions

Suggestion form uses C4::Koha::GetSupportList to get a list of supports that
can come from itemtypes or authoritized values LOC or CCODE.
C4::Koha::GetSupportList uses AdvancedSearchTypes syspref like it has only one
value. But this syspref can contain several values separated by a pipe.

This patch introduces a new syspref SupportsAuthorizedValues to select wich
authorized values category that represents the physical support (itemtypes by
default, loc or ccode). These authorized values will be used in suggestion
management, known as 'document type'.
(Note that database field is still 'itemtype').

Test plan :
---
- Set SupportsAuthorizedValues with itemtypes or loc or ccode
- Get to suggestion form (OPAC or intranet)
- Look at "Document type" combobox, it must contains descriptions of selected
authorized values
- Save the suggestion
- Get to intranet suggestions management
- Organize suggestions by document type
=> your suggestion must appear in a tab with its document type description

Signed-off-by: Olli-Antti Kivilahti 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #42290|0   |1
is obsolete||

--- Comment #59 from Alex Arnaud  ---
Created attachment 42339
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42339=edit
Bug 9223 [Follow-up] change the way syspref SuggestionsUseValues is added: Use
the new worflow (atomic update)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #42289|0   |1
is obsolete||

--- Comment #58 from Alex Arnaud  ---
Created attachment 42338
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42338=edit
Bug 9223 [Follow-up] Multiple values of AdvancedSearchTypes in suggestions

This follow-up implements some things I think will improve on the
previous patches:

- Change the system preference name to "SuggestionsUseValues"
- Change the description of the preference to "Suggestions can be
  submitted using the following authorized values:"
- Move the new preference to the OPAC tab so that it is grouped with
  other suggestions-related preferences.
- Add the option offer no itemtype/collection code chooser on the
  submission form.
- Display the correct label on the submission form depending on the
  value of the SuggestionsUseValues preference.

To test, apply this patch on top of the previous ones. Test submission
of purchase suggestions through the OPAC and staff client with the
SuggestionsUseValues preference set to all the various choices: item
type, collection code, shelving location, and 'none.' The suggestion
forms should look correct and work correctly.

HOWEVER, neither the previous patches nor mine address the problem of
the suggestions management page's "organize by" option, which is
hard-coded to work with item types. Whether or not my patch is
acceptable this issue will need to be addressed.

Signed-off-by: Olli-Antti Kivilahti 

  Tested the TEST PLAN. With ccode, itype, none, loc.
  On both OPAC and SC.
  Making a code review, but it is hard during the hackfest.
  Morbid lack of any kind of unit test!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

--- Comment #7 from Jonathan Druart  
---
Created attachment 42344
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42344=edit
Bug 14171: Update borrowers date fields

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

--- Comment #6 from Jonathan Druart  
---
Created attachment 42343
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42343=edit
Bug 14717: Prevent -00-00 on updating a patron

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315

Colin Campbell  changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #25 from Colin Campbell  ---
Change in return causes sipserver instances to crash on renewals : see bug 
14673 for description and workaround

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] Get rid of DBIx::Connector

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14375

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] New: Get rid of DBIx::Connector

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Bug ID: 14778
   Summary: Get rid of DBIx::Connector
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

We should get rid of DBI::Connector and use the DB connection created by
DBIx::Class.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] Get rid of DBIx::Connector

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

--- Comment #1 from Jonathan Druart  
---
Created attachment 42326
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42326=edit
Bug 14778: Get rid of DBIx::Connector

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673

Colin Campbell  changed:

   What|Removed |Added

   Priority|P5 - low|P3

--- Comment #2 from Colin Campbell  ---
Upping priority as this needs applying to releases from 3.18.7 to stop
communication errors on renew. The change causing the error was bug 13315

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375

--- Comment #17 from Jonathan Druart  
---
Fridolin, Could you have a look at the patch I have just submitted on bug
14778?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14656] Delete Bibliographic Records REST API route & permission

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14656

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #42115|0   |1
is obsolete||

--- Comment #3 from Olli-Antti Kivilahti  ---
Created attachment 42329
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42329=edit
Bug 14656 - Delete Bibliographic Records REST API route & permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14458] Add SwaggerUI documentation for RESTful API

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14458

Olli-Antti Kivilahti  changed:

   What|Removed |Added

  Attachment #41544|0   |1
is obsolete||

--- Comment #9 from Olli-Antti Kivilahti  ---
Created attachment 42327
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42327=edit
Bug 14458: 5. Add SwaggerUI documentation for RESTful API

Changed API endpoint to /api/v1/...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14760] Disabled courses display in the course reserves list for items

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #42121|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14760] Disabled courses display in the course reserves list for items

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

--- Comment #2 from Marc Véron  ---
Created attachment 42328
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42328=edit
[Signed-off] Bug 14760 - Disabled courses display in the course reserves list
for items

If an item is on reserve for two courses but one of those courses is
disabled, both courses are still listed on opac-detail.pl!

Test Plan:
1) Enable course reserves
2) Create two courses
3) Place one item on reserve for both courses
4) Disable one of the two courses
5) View the record details for that record/item
6) You should see both courses listed in the course reserves column
7) Apply this patch
8) Reload the page
9) You should now only see the active course in the course reseves column

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #42291|0   |1
is obsolete||

--- Comment #60 from Alex Arnaud  ---
Created attachment 42340
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42340=edit
Bug 9223 [Follow-up] add unit tests for GetSupportList and GetSupportName
subroutine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Adding a new patron can end up with 0000-00-00 as the debarred date

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |ch...@bigballofwax.co.nz
   |ity.org |

--- Comment #8 from Jonathan Druart  
---
I think we should go further here.
Can I get a QA on the new patches?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] Get rid of DBIx::Connector

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14354] Only superlibrarian should see edit links for other branches' items in staff detail

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14354

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #41003|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42341|0   |1
is obsolete||

--- Comment #16 from Jonathan Druart  
---
Created attachment 42350
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42350=edit
Bug 14297 [QA Followup] - Remove unnecessary line

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42028|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart  
---
Created attachment 42348
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42348=edit
Bug 14297 - Unit Tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

Marc Véron  changed:

   What|Removed |Added

  Component|Tools   |Label/patron card printing
   Assignee|gmcha...@gmail.com  |cnighswon...@foundations.ed
   ||u
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #15 from Kyle M Hall  ---
Created attachment 42351
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42351=edit
Bug 11622 [QA Followup] - Add new module dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Kyle M Hall  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #17 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #14)
> (In reply to Galen Charlton from comment #5)
> > Comment on attachment 24754 [details] [review] [review]
> > Bug 11622 - Add ability to pay fees and fines from OPAC via PayPal
> > 
> > Review of attachment 24754 [details] [review] [review]:
> > -
> > 
> > ::: opac/opac-account-pay-paypal-return.pl
> > @@ +20,5 @@
> > > +
> > > +use strict;
> > > +use warnings;
> > > +use utf8;
> > > +
> 
> > Modern::Perl
> > I see no non-ASCII characters in the source.
> 
> Still exists.
> 

I'm not sure what this means. Can you explain?


> > ::: opac/opac-account-pay.pl
> > @@ +19,5 @@
> > > +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> > > +
> > > +use strict;
> > > +use warnings;
> > > +use utf8;
> 
> > Modern::Perl
> > I see no non-ASCII characters in the source.
> 
> Still exists.

Same as above


> > @@ +94,5 @@
> > > +'PAYMENTREQUEST_0_PAYMENTACTION'=> 'Sale',
> > > +'PAYMENTREQUEST_0_ALLOWEDPAYMENTMETHOD' => 'InstantPaymentOnly',
> > > +'PAYMENTREQUEST_0_DESC' =>
> > > +  C4::Context->preference('PayPalChargeDescription'),
> > > +};
> > 
> > It seems like using Business::PayPal::API might offer some protection
> > against API changes.
> 
> Answer needed.

That's what I tried first when I began writing this feature. It did not go
well. PayPal doesn't change existing APIs anyway. They have an API versioning
system so that applications don't break with changes to the API.

> 
> +use CGI;
> 
> Should be replaced by CGI qw( -utf8 ) unless you have a good reason.
> 

Fixed!

> 
> > 3) Create a paypal developer account
> 
> How? Should I need a paypal account to do so?

I don't think you need a regular paypal account, but you do need an account on
https://developer.paypal.com/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14781] New: Creation of barcode types 2of5 not functional

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

Bug ID: 14781
   Summary: Creation of barcode types 2of5 not functional
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: m...@adminkuhn.ch
QA Contact: testo...@bugs.koha-community.org

Koha menu "Tools > Labels home > Manage label

After setting up a new label layout using barcode type "COOP2of5" or
"Industrial2of5", when trying to create some labels the layout won't render at
all for both barcode types. Thus the resulting page will be completely empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13909] Suspension days calculation doesn't honour finesCalendar

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13909

MetaBiblioteca Colombia  changed:

   What|Removed |Added

 CC||felipe.gom...@gmail.com

--- Comment #7 from MetaBiblioteca Colombia  ---
Hello in Koha 3.20 Suspentions fails when loan by hours

See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

The solution:

Remove line 2157 in the /usr/share/koha/lib/C4/Circulation.pm

$finedays = $finedays * 24 if ( $unit eq 'hours' );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14783] New: Allow patrons to change pickup location for non-waiting holds

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14783

Bug ID: 14783
   Summary: Allow patrons to change pickup location for
non-waiting holds
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: kyle.m.h...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

This enhancement would allow patrons to change the pickup location for any hold
that is not already waiting ( e.g. it would be allowable for in transit holds
).

For non-found holds the feature will not change much behavior. For in-transit
holds the feature would trigger a completion of the current transfer and
generate a new transfer from the previous target library to the new target
library.

The feature would be controlled via a system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14304] RDA: Display link in XSLT for 264 field to reflect Zebra indexing

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14304

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14782] can't search by username anymore

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14780] Datetime format picker error in Circulation

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14780

Eugene Espinoza  changed:

   What|Removed |Added

Summary|Datetime format seems   |Datetime format picker
   ||error in Circulation

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

--- Comment #16 from Kyle M Hall  ---
Created attachment 42352
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42352=edit
Bug 11622 [QA Followup] - Add utf8 flag for CGI

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293

MetaBiblioteca Colombia  changed:

   What|Removed |Added

Version|3.18|3.20

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Lari,
I really would prefer to see a new subroutine added to C4::Letters covered by
tests.
Something like C4::Letters::ResendMessage($message_id).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #33 from Marcel de Rooy  ---
CHECK: No results while files have been uploaded permanently? Test by drojf.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42029|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  
---
Created attachment 42349
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42349=edit
Bug 14297 - Holds Queue building ignoring holds where pickup & home branch
don't match and item is not from least cost branch

If a record has a hold on it where the pickup and home branch do not
match, the holds queue builder will only look at items from the least
cost branch ( as defined by the transport cost matrix or the sys pref
StaticHoldsQueueWeight.

Test Plan:
1) Create a record with two items, one for library A and one for library B
2) Set your circulation rules such that the book from library A is
   holdable by all and the book from library B is holdable only by library
   B patrons
3) Create a hold for a Library C patron for pickup at library C
4) Set the syspref StaticHoldsQueueWeight to by Library B, Library A,
   Library C in that order
5) Rebuild the holds queue
6) Note the hold wasn't picked up even though the item from library A
   could have filled the hold
7) Apply this patch
8) Rebuild the holds queue
9) View the holds queue again
10) Note the hold now displays

Signed-off-by: Nora Blake 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14782] New: can't search by username anymore

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Bug ID: 14782
   Summary: can't search by username anymore
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

We used to be able to search by username when doing patron searching and that
availability is gone.  I think this happened with the new patron search form in
ajax.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9223] Multiple values of AdvancedSearchTypes in suggestions

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9223

Koha Team Lyon 3  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #61 from Koha Team Lyon 3  ---
I have tested the different values of the new syspref "suggestionsUseValues".
In each case, in pro interface or in OPAC, the authorized values match with the
choice in the syspref. And it's the description that is displayed in the
dropdown.
I tried to modify the suggestions in the pro interface and it's Ok too.

If, "hide this option" is selected, none are in the form (tested in pro and
opac too).

There's just one thing that could be much better : code are displayed in the
list of suggestions (OPAC and PRO) and it would be more useful to have the
description instead.
cf. cgi-bin/koha/suggestion/suggestion.pl and cgi-bin/koha/opac-suggestions.pl

But I don't want to block this patch for that.

Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Genevieve Plantin  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |genevieve.plantin@inlibro.c
   |ity.org |om
 CC||charles.far...@inlibro.com,
   ||eric.be...@inlibro.com,
   ||francois.charbonnier@inlibr
   ||o.com,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

--- Comment #1 from Genevieve Plantin  ---
Created attachment 42354
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42354=edit
CAM 2267 - Bug 14784 : Fix checkin message for debarred patrons

If there is an overdue but finedays equals 0, then we have to see if the patron
is debarred and if he was forever debarred. So we have to go through the same
code a if it was a debarred patron with no overdue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||ch...@bigballofwax.co.nz

--- Comment #18 from Chris Cormack  ---
Please see 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

The Author of DBIx::Class recommends we shouldn't use DBIx::Connector and I
tend to agree

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14717] Prevent 0000-00-00 dates in patron data

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com

--- Comment #9 from Héctor Eduardo Castro Avalos  ---
Hi Marcel you're right, the three perl scripts/templates do nothing or do the
same thing, but the magic of having too many plugins perhaps is for filling
different data in the frameworks. i.e., books only uses "06 - Type of record: a
- Language material" but computer files uses "m - Computer file" and videos
uses "g - Projected medium"

With this you save time for experimented catalogers. The data in the leader is
predefined and she or he doesn't need to fill at all. Just by the fact to
choose the proper framework is enough.

Maybe you can do a trick in your plugin to catch the framework code and
redefine the leader for the type of resource/material.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #11 from Héctor Eduardo Castro Avalos  
---
Created attachment 42360
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42360=edit
[SIGNED-OFF]Bug 14201: We can do without plugin marc21_leader_computerfile

A closer look at this plugin revealed the same things as the previous
patch for leader_book.
[1] Template leader_computerfile is not used.
[2] The unused template is not up-to-date either.
[3] Leader_computerfile does not use Focus while leader does.

This patch removes all traces of leader_computerfile.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_computerfile. Ignore PO files.

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #12 from Héctor Eduardo Castro Avalos  
---
Created attachment 42361
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42361=edit
[SIGNED-OFF]Bug 14201: Yes, goodbye to the third plugin marc21_leader_video too

A closer look at this plugin revealed the same things as earlier:
[1] Since the click redirects to leader, the launcher is not used.
In this case no template file existed.
[2] Leader_video does not use Focus while leader does.

This patch removes 'all' traces of leader_video.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_video. Ignore atomicupdate. No PO files :)

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0'

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Genevieve Plantin  changed:

   What|Removed |Added

Summary|Missing checkin message for |Missing checkin message for
   |debarred patrons when   |debarred patrons when
   |issuing rules' fine days =  |issuing rules 'fine days =
   |0   |0'

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673

Chris Cormack  changed:

   What|Removed |Added

  Attachment #41452|0   |1
is obsolete||

--- Comment #3 from Chris Cormack  ---
Created attachment 42355
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42355=edit
Bug 14673 Work around change to AddIssue return

Return from AddIssue used to be due date or undef.
Now it is less straightforward returning am issue object
if an issue row is created or undef. If the issue is a renewal
undef is returned. As that case was not handled properly it
caused the server site to crash the listener causing a
communications error on the client.

Signed-off-by: Chris Cormack 

We have this patch in production, it does solve the issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14778] Get rid of DBIx::Connector

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14778

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #10 from Héctor Eduardo Castro Avalos  
---
Created attachment 42359
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42359=edit
[SIGNED-OFF]Bug 14201: Plugin marc21_leader_book is useless

A closer look at this plugin revealed the following:
[1] The leader_book builder redirects to leader.pl; the launcher code with
leader_book.tt is dead.
[2] A diff of the two templates showed that most changes are minimal and
irrelevant. Some updates to leader have not been incorporated into
the unused leader_book.
[3] Leader_book does not use Focus while leader does.

This patch removes all traces of leader_book :)
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.
Another small change: we do not need Search.pm in marc21_leader.

Test plan:
[1] Run the db revision. If you had some field attached to leader_book,
it should be gone.
[2] Check if the leader plugin still works as expected.
[3] Run the FrameworkPlugin unit test. Ignore warnings from field_007.
[4] Git grep on marc21_leader_book. You will only find references to
PO files in misc/translator.

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14510] Allow column visibility in additem.pl to be customized

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14510

--- Comment #15 from Jesse Weaver  ---
Created attachment 42353
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42353=edit
Bug 14510: (QA followup) Fix bug with unmapped columns

Fall back more smoothly when items subfields are not mapped to a
kohafield. Note, however, that this development does not allow applying
default settings to subfields that aren't mapped. A note has been added
to the columns settings page, as there is no known workaround for this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not be required

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #42278|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 42363
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42363=edit
[PASSED QA] Bug 14775: Plack::Middleware::ReverseProxy should not be required

But optional.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not be required

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14784] New: Missing checkin message for debarred patrons when issuing rules' fine days = 0

2015-09-03 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784

Bug ID: 14784
   Summary: Missing checkin message for debarred patrons when
issuing rules' fine days = 0
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: genevieve.plan...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Context : a patron was previously debarred and has returned a overdue book.

There should be a message saying : "Check in message - Reminder: Patron was
earlier restricted until ..."

However, when the column finedays in the table issuingrules equals 0, no
message is shown.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 3 4 5 >

1 - 100 of 415 matches

Mail list logo