date:20150922

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

--- Comment #36 from Eivin Giske Skaaren  ---
Changed as suggested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14878] New: Tests - Create the branchcodes if needed

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878

Bug ID: 14878
   Summary: Tests - Create the branchcodes if needed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Blocks: 10273

Tests assume that the branchcodes CPL/MPL/etc. already exist in the DB.
If they need them, they should create them.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273
[Bug 10273] Unit tests should not be dependent on the Jenkins database
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||14878


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878
[Bug 14878] Tests - Create the branchcodes if needed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #17 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12311] Batch modification of checked out and lost items checks them in

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #42554|0   |1
is obsolete||

--- Comment #7 from Héctor Eduardo Castro Avalos  ---
Created attachment 42796
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42796=edit
[SIGNED-OFF]Bug 12311: Do not return a lost item if modified in a batch

If a item is lost and issued, and you modify it in a batch, the item
will be marked as returned. It should only be returned if the item is
marked as lost.

Test plan:
1/ Check an item out and mark it as lost
2/ Edit it in a batch (tools/batchMod.pl) and edit a field (notes for
instance)
3/ The item should still be issued to the patron
4/ Edit it in a batch and edit the lost value, marked it as not lost
5/ The item should still be issued to the patron
6/ Edit it in a batch and edit the lost value, marked it as lost
7/ The item should have been returned.

Signed-off-by: Hector Castro 
Works as advertised. Just one comment, lost status can be changed only if you
change default framework to another framework then edit the item. If you change
it in Item menu at left side of screen this will remove the item from patron’s
checkouts and patron charged for lost item.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8723] holds don't transfer when moving items

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #23 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out.

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #42750|0   |1
is obsolete||

--- Comment #33 from Eivin Giske Skaaren  ---
Created attachment 42791
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42791=edit
Bug 10067 - decreaseLoanHighHolds messes with specify due date

To test:

1. On a branch up to date with master: apply the patch.

2. Try to check out items both with and without holds.
(The decreaseLoanHighHolds function should be configured and kick in when
testing an item.

3. Expected results are:
The due date date field should be cleared after checkout if "Remember for
session"
is not selected. If it is selected then the chosen date should stay in the
field even
if the warning about reduced loan time for an item with too many holds is
displayed.
Also the correct due dates are shown in the table after a checkout.

Known limitation: Does not work too well when jumping between different parts
of the system as it relies on the values sent to the circulation.pl script.

Sponsored-by: Halland County Library

Refactored to both fix specific issue where date is changed
and still have the old behaviour with date kept intact.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #42750|0   |1
is obsolete||

--- Comment #34 from Eivin Giske Skaaren  ---
Created attachment 42793
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42793=edit
Bug 10067 - decreaseLoanHighHolds messes with specify due date

To test:

1. On a branch up to date with master: apply the patch.

2. Try to check out items both with and without holds.
(The decreaseLoanHighHolds function should be configured and kick in when
testing an item.

3. Expected results are:
The due date date field should be cleared after checkout if "Remember for
session"
is not selected. If it is selected then the chosen date should stay in the
field even
if the warning about reduced loan time for an item with too many holds is
displayed.
Also the correct due dates are shown in the table after a checkout.

Known limitation: Does not work too well when jumping between different parts
of the system as it relies on the values sent to the circulation.pl script.

Sponsored-by: Halland County Library

Refactored to both fix specific issue where date is changed
and still have the old behaviour with date kept intact.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

--- Comment #35 from Eivin Giske Skaaren  ---
Created attachment 42794
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42794=edit
Bug 10067 - decreaseLoanHighHolds messes with specify due date

To test:

1. On a branch up to date with master: apply the patch.

2. Try to check out items both with and without holds.
(The decreaseLoanHighHolds function should be configured and kick in when
testing an item.

3. Expected results are:
The due date date field should be cleared after checkout if "Remember for
session"
is not selected. If it is selected then the chosen date should stay in the
field even
if the warning about reduced loan time for an item with too many holds is
displayed.
Also the correct due dates are shown in the table after a checkout.

Known limitation: Does not work too well when jumping between different parts
of the system as it relies on the values sent to the circulation.pl script.

Sponsored-by: Halland County Library

Refactored to both fix specific issue where date is changed
and still have the old behaviour with date kept intact.

Rebase
Remove code whitespace cleanup

Remove one more code whitespace cleanup

Removed duplicate tag

Refactored stickyduedate session parameter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #23 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Marc Véron  changed:

   What|Removed |Added

 Depends on||14879


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14879
[Bug 14879] Remove C4::Dates from catalogue/detail.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #29 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14879] Remove C4::Dates from catalogue/detail.pl

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14879

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 Blocks||14870
   Assignee|gmcha...@gmail.com  |ve...@veron.ch
   Patch complexity|--- |Trivial patch


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870
[Bug 14870] Delete C4/Dates.pm from System
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13781] Relative's checkouts table is missing one column heading

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #12 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #37 from Jonathan Druart  
---
Unfortunately, it does not work.
warn $response->decoded_content logs

opac-account-pay-paypal-return.pl:
TIMESTAMP=2015%2d09%2d22T16%3a57%3a10Z=e76fcad1465da=Failure=82%2e0=00_ERRORCODE0=10444_SHORTMESSAGE0=Transaction%20refused%20because%20of%20an%20invalid%20argument%2e%20See%20additional%20error%20messages%20for%20details%2e_LONGMESSAGE0=The%20transaction%20currency%20specified%20must%20be%20the%20same%20as%20previously%20specified%2e_SEVERITYCODE0=Error
at /home/koha/src/opac/opac-account-pay-paypal-return.pl line 84.

I also think that the Payment block should not be displayed if there is nothing
to pay.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14683] Unable to clear SMS number

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #12 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14879] Remove C4::Dates from catalogue/detail.pl

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14879

--- Comment #1 from Marc Véron  ---
Created attachment 42797
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42797=edit
Bug 14879 - Remove C4::Dates from catalogue/detail.pl

This bug removes deprecated C4::Dates from catalogue/detail.pl

To test:
Apply patch
Go to Home > Catalog > Details for [some biblio with items and holdings]
Make sure that biblio and Holdings and Acquisition details display as
appropriate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12311] Batch modification of checked out and lost items checks them in

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

--- Comment #5 from Heather Braum  ---
As a multi-library consortia, this feature would be unusable for us, especially
using a single email field in the syspref -- it would be much better to use the
email address in the branches table and email the holdingbranch email address
of the item when a hold awaiting pickup is canceled. 

Additionally, I agree with Christopher's suggested workflow, having seen
patrons come in for holds awaiting pickup before the items even make it to the
circ desk.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14879] Remove C4::Dates from catalogue/detail.pl

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14879

--- Comment #2 from Marc Véron  ---
Created attachment 42798
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42798=edit
[Follow-up] Bug 14879 - Remove C4::Dates from catalogue/detail.pl

Remove forbidden patterns (tab) to pass QA tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10005] inventory checks items in without warning

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10005

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #9 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14760] Disabled courses display in the course reserves list for items

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14760

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #6 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14361] koha-restart-zebra fails and probably breaks upgrade

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14361

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC|a...@hanover.ca  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14879] New: Remove C4::Dates from catalogue/detail.pl

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14879

Bug ID: 14879
   Summary: Remove C4::Dates from catalogue/detail.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

Patch to remove C4::Dates from catalogue/detail.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14782] can't search by username anymore

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #42786|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14813] Encoding issues when editing the help

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #6 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success in anonymous patron not defined

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable
Summary|Patron anonymizing tool |Patron anonymizing tool
   |reports false success   |reports false success in
   ||anonymous patron not
   ||defined

--- Comment #12 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14585] Fixing up the online help on main page

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14585

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #8 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14878] Tests - Create the branchcodes if needed

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14878

--- Comment #1 from Jonathan Druart  
---
Created attachment 42795
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42795=edit
Bug 14878: Tests - Create the branchcodes when needed

Tests assume that the branchcodes CPL/MPL/etc. already exist in the DB.
If they need them, they should create them.

Test plan:
Execute the differente test files on a DB without any branchcode or
at least without CPL/MPL branches.
Confirm that the tests pass.

Note for QA:
- Not to conflict the list rewrite, this patch don't update
VirtualShelves* files.
- I am not sure about the changes in t/db_dependent/HoldsQueue.t:
+is( $holds_queue->[0]->{cardnumber}, $borrower2->{cardnumber}, "Holds
queue filling 1st correct hold for default holds policy 'from home
library'");
+is( $holds_queue->[1]->{cardnumber}, $borrower1->{cardnumber}, "Holds
queue filling 2nd correct hold for default holds policy 'from home
library'");
I have swapped borrower1/borrower2 to make the tests pass, but I
didn't understand why...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14343] Links to results pages don't work in Receive Shipment list

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14343

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #11 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871

--- Comment #2 from Marc Véron  ---
Created attachment 42799
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42799=edit
[Signed-off] Bug 14871: Extend the patrons search to search like %$term%
(checkout tab)

The patrons search used by the checkout tab and the autocomplete is not
the same as the "search patrons" tab.
The main difference is the "contain" vs "start with".
So that if you have a patron with a patron with a surname "foo bar" and
you search for "foo bar", the autocomplete and the result of a search by
the checkout tab will search for "foo%" or "bar%" which won't return the
patron you are search for.

This patch replaces both autocomplete and checkout tab searches with a
"contain" search. The search will be "%foo%" or "%bar%".
Note that on big DB, this can cause unexpected results.

Test plan:
Create a patron with a surname "foo bar"
Search for "bar" using the checkout tab.
You should see the patron in the autocomplete result and the result page
after submitting the search form.

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7634] Permanent Location (shelving location) is NULL when Import MARC records tool is used

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #15 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out.

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #8 from Chris Cormack  ---
Pushed to 3.20.x will be in 3.20.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14880] New: Keyboard shortcuts don't work after setting CircAutocompl to "Don't try"

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880

Bug ID: 14880
   Summary: Keyboard shortcuts don't work after setting
CircAutocompl to "Don't try"
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tmcma...@wlpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Setting CircAutocompl to "Don't try" will cause the keyboard shortcuts in the
staff interface to select incorrect tabs on the search form.

Examples are:

On the start page (mainpage.pl):
Alt+u = Search the catalog
Alt+r = Check out
Alt+q = Search patrons

On circulation-home.pl:
Alt+q = Check in and the other two keys are the same.

This is the behavior reported in bug 14860.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13781] Relative's checkouts table is missing one column heading

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13781

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #13 from Liz Rea  ---
Pushed to 3.18.x will be in 3.18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7634] Permanent Location (shelving location) is NULL when Import MARC records tool is used

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7634

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #16 from Liz Rea  ---
pushed to 3.18.x will be in 3.18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14245] RIS in unimarc flavour is still deficient

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14245

Liz Rea  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||l...@catalyst.net.nz

--- Comment #8 from Liz Rea  ---
pushed to 3.18.x, will be in 3.18.11.

Also looks like it was pushed to 3.20.x, and included in 3.20.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14640] 'Cancel Hold' check box on check-out confirmation does not cancel the hold when item is checked out.

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14640

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #10 from Liz Rea  ---
Pushed to 3.18.x will be in 3.18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14585] Fixing up the online help on main page

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14585

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #9 from Liz Rea  ---
Pushed to 3.18.x will be in 3.18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14860] Keyboard shortcuts not functioning correctly after loading database.

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14860

tmcma...@wlpl.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from tmcma...@wlpl.org ---


*** This bug has been marked as a duplicate of bug 14880 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14880] Keyboard shortcuts don't work after setting CircAutocompl to "Don't try"

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880

--- Comment #1 from tmcma...@wlpl.org ---
*** Bug 14860 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #152 from Tomás Cohen Arazi  ---
I tested the patches successfully on a dev install. I didn't manage to have it
working on a packages+Plack environment. Once I have the needed followups I'll
sign this successfull implementation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14813] Encoding issues when editing the help

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14813

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #7 from Liz Rea  ---
Pushed to 3.18.x will be in 3.18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6756] Patron anonymizing tool reports false success in anonymous patron not defined

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6756

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #13 from Liz Rea  ---
pushed to 3.18.x will be in 3.18.11

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12525] Patron Lists aren't added to list pulldown when created from Patron search

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12525

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #18 from Liz Rea  ---
Pushed to 3.18 will be in 3.18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8723] holds don't transfer when moving items

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8723

--- Comment #24 from Liz Rea  ---
Pushed to 3.18.x will be in 3.18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #24 from Liz Rea  ---
Pushed to 3.18.x will be in 3.18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14683] Unable to clear SMS number

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14683

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #13 from Liz Rea  ---
Pushed to 3.18.x will be in 3.18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14782] can't search by username anymore

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14782

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #10 from Liz Rea  ---
Pushed to 3.18.x will be in 3.18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #30 from Liz Rea  ---
Pushed to 3.18.x will be in 3.18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #42530|0   |1
is obsolete||

--- Comment #29 from Nicole C. Engard  ---
Created attachment 42792
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42792=edit
Bug 5144 - Duplicate holds allowed if patron clicks back button after placing
hold

Koha is currently not engineered to handle multiple holds per record.
Until such time that is does, we should not allow them to be created.

Test Plan:
1) Apply this patch
2) Log in to the opac
3) Place a hold
4) Hit the back button on your browser
5) Place the hold again
6) Note the new message

Signed-off-by: David Kuhn 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144

Nicole C. Engard  changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #42791|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #42750|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #42793|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #42706|0   |1
is obsolete||

--- Comment #96 from Joonas Kylmälä  ---
Created attachment 42754
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42754=edit
Bug 8367 - How long is a hold waiting for pickup at a more granular level

You can now specify a pickup delay for an hold function of a patron
category and/or a item type and/or a library.
The lastpickupdate-column is set based on the given instruction and lands only
on an
open library day.
Also cancel_expired_reserves.pl now cancels only on open library days after the
last pickup
date has expired.
And waitingreserves.pl respects the new DB column.

If ReservesMaxPickUpDelay is not set prior to the databaseupdate, the
holdspickupwait-directive
is never defined, thus disabling this feature until the holdspickupwait is set.
If the issuingrules holdspickupwait is 0 or less, this feature is disabled. So
each issuingrule can disable
this feature for the material it matches, while being fully functional with
other rules.

This patch adds:
- a new column in the issuing rules, including help topics.
- a new column reserves.lastpickupdate (+old_reserves)
  It contains the waitingdate + the corresponding "holds pickup wait".
  Each time the waitingdate is modified, this value will be modified too.
- a new field issuingrules.holdspickupwait
- a new function C4::Reserves::MoveWaitingdate() to help in testing this
feature.
- a new function C4::Reserves::GetLastPickupDate() to calculate the proper date
from Calendar.

This patch removes:
- the ReservesMaxPickUpDelay syspref.
- the ExpireReservesOnHolidays syspref, because it became obsolete due to the
changes in
  handling the last pickup date with Koha Calendar.
- Also removes a code section from C4::Letters::_parseLetter() which worked
blatantly
  disrespectfully towards Koha Calendar.
- TODO figure out how to rename existing letter placeholders <>
with <>

Unit tests included.

$
$ TEST PLAN $
$

0. BEFORE UPDATING THE DATABASE! MAKE SURE THAT THE SYSPREF
'ReservesMaxPickUpDelay' is bigger than 0.
   Otherwise existing reserves won't get UPDATEd with the new
lastpickupdate-values.

  ** **
*** *** *** TEST: BASIC WORKFLOW *
  ** **
1. Check there is no regression with a normal reserve workflow.
2. Add one or more issuingrules.
3. Update the new column 'Holds pickup wait' in your issuing rules.
4. In the 3 templates of staff client, you can see the 'Last pickup date' for
an hold
   (circ/circulation.pl, circ/waitingreserves.pl, members/moremember.pl)
5. In opac-user.pl the last pickup date is displayed in the status-column if
available.
5. According to a library and an item type, the lastpickupdate value will be
   equal to the waiting date + the "holds pickup wait" defined moved to the
   next open library day.

  ** **
*** *** *** TEST: LETTER PLACEHOLDER (no code modifications here, just
regression)*
  ** **
1. Modify the RESERVESLIP->email Letter. Add "Last pickup
date<>"
   somewhere.
2. Make a hold for a borrower.
3. Catch the hold and print the reserve slip. Verify that the lastpickupdate is
actually
   the (current date + the 'Holds pickup wait' in your issuing rules) in days.

  ** ** ** ** ** **
*** *** *** TEST: RESPECTING CALENDAR HOLIDAYS *
  ** ** ** ** ** **
1) Note your ReservesMaxPickUpDelay setting.
2) Create and trap a hold
3) View waitingreserves.pl, note the last pickup date, and the pickup
   location
4) Cancel this hold
5) Edit the calendar for the given location, and make the pickup date a
   single, unrepeated, holiday. Then make the next day a weekly repeating
holiday.
   Then make the next two days an annual holiday repeatable every year.
6) Repeat step 2
7) View waitingreserves.pl, the last pickup date for this new hold
   should now be increased by four days.

  ** ** ** ** ** **
*** *** *** TEST: LETTER lastpickupdate PLACEHOLDER AND REGRESSION *
  ** ** ** ** ** **
1. Modify the HOLD-letter, add <> and
<>
   somewhere.
2. Catch a hold for a borrower.
3. See the members/notices.pl for the message queued and verify that the
   lastpickupdate-placeholder is set in your desired datetime format and
   that it is not on a holiday. Verify that the waitingdate is today.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14867] userid not generated when defined in BorrowerUnwantedField

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867

Fridolin SOMERS  changed:

   What|Removed |Added

  Attachment #42753|0   |1
is obsolete||

--- Comment #2 from Fridolin SOMERS  ---
Created attachment 42755
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42755=edit
Bug 14867 - userid not generated when defined in BorrowerUnwantedField

When userid is not provided when creating a new patron, it is generated using
surname and firstname.
The bug is when userid is defined in syspref BorrowerUnwantedField, the input
text is missing in patron creation form. When saving you always get an alert
message : "Username/password already exists". No patron can be created.

This patch corrects by adding this case to userid generation conditions.

Test plan :
- add 'userid' in syspref BorrowerUnwantedField
- try to create a new patron : /cgi-bin/koha/members/memberentry.pl
- there is not input text for userid
- choose non-existing surname and firstname
- click on save
=> Without patch : patron is not created, you see the alert message
"Username/password already exists"
=> With patch : patron is created, userid is generated with surname and
firstname
- remove 'userid' in syspref BorrowerUnwantedField and check it can be defined
in patron creation form

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14867] userid not generated when defined in BorrowerUnwantedField

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

--- Comment #14 from Jonathan Druart  
---
Created attachment 42764
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42764=edit
Bug 14805: (follow-up) fix a bug in previous code and change msg string

Previously the code didn't work if there was only one batch available for
selection.
This fixes that now. Also there was a bug with wrong string showing now it's
changed to a general one, "items". I choosed the string "items" because there
was
difficulties adding the plural part of the word. One cannot add just s to the
end
of the word batch like you can in the case of profile.

Sponsored-by: Vaara-kirjastot

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

--- Comment #15 from Jonathan Druart  
---
Created attachment 42765
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42765=edit
Bug 14805: Replace generic 'items' with the specific ones

Signed-off-by: Joonas Kylmälä 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14867] userid not generated when defined in BorrowerUnwantedField

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867

Fridolin SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

--- Comment #32 from Jonathan Druart  
---
(In reply to Eivin Giske Skaaren from comment #31)
> Hi Jonathan,
> 
> Yes there is a reason for that bit of code being outside of that block. 
> 
> It needs to be executed before the $template->param() that comes directly
> after on line 530.

Yes but you can move the existing block before the $template->param :)
So that the stickyduedate value is set to the session at only 1 place in the
script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14867] New: userid not generated when defined in BorrowerUnwantedField

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867

Bug ID: 14867
   Summary: userid not generated when defined in
BorrowerUnwantedField
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolin.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When userid is not provided when creating a new patron, it is generated using
surname and firstname.
The bug is when userid is defined in syspref BorrowerUnwantedField, the input
text is missing in patron creation form. When saving you always get an alert
message : "Username/password already exists". No patron can be created.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14868] New: REST API: Swagger2-driven permission checking

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Bug ID: 14868
   Summary: REST API: Swagger2-driven permission checking
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: olli-antti.kivila...@jns.fi
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 13799


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799
[Bug 13799] Add base for building RESTful API
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice  changed:

   What|Removed |Added

 Blocks||14868


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868
[Bug 14868] REST API: Swagger2-driven permission checking
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission checking

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #42725|0   |1
is obsolete||

--- Comment #11 from Joonas Kylmälä  ---
Created attachment 42752
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42752=edit
Bug 14805: Replace generic 'items' with the specific ones

The case mechanism works, and it is okay for me.

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

--- Comment #97 from Joonas Kylmälä  ---
After this patch gets to master, the system preference
ExpireReservesMaxPickUpDelay could to be changed to something like
ExpireReservesAfterLastPickupDay. I guess it is then more descriptive. There
was about 15-20 files depending on ExpireReservesMaxPickUpDelay preference, so
it would be better to do maybe a new bug report for it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #35776|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart  
---
Created attachment 42756
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42756=edit
[DO NOT PUSH] Script to generate the permissions include file

perl build_permissions_file.pl >
koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

--- Comment #26 from Jonathan Druart  
---
Created attachment 42759
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42759=edit
Bug 13632: Populate user_flags and permissions tables in the web installer

Move the 2 specific 'en' files outside of the language directory.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

--- Comment #24 from Jonathan Druart  
---
Created attachment 42757
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42757=edit
Bug 13632: Use an include file to display permissions

This patch set moves the permissions' descriptions to the po files
instead of having them in the DB.

Test plan:
0/ Apply all patches
1/ Create a new installation
2/ Confirm the userflags and permissions tables are correctly populated
3/ Update the po file for a translated language
4/ Confirm you are able to translate the permissions descriptions
5/ Install the template files for this language
6/ Switch the interface to use this language and confirm the string are
correctly translated.

QA Note: At this point we could remove the userflags.flagdesc and
permissions.description DB fields, but I would prefer to keep them:
developers will know what the permission do without the need to go and
see the include file (we have it in the sql files and so, in the DB).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14867] userid not generated when defined in BorrowerUnwantedField

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14867

--- Comment #1 from Fridolin SOMERS  ---
Created attachment 42753
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42753=edit
Bug 14867 - userid not generated when defined in BorrowerUnwantedField

When userid is not provided when creating a new patron, it is generated using
surname and firstname.
The bug is when userid is defined in syspref BorrowerUnwantedField, the input
text is missing in patron creation form. When saving you always get an alert
message : "Username/password already exists". No patron can be created.

This patch corrects by adding this case to userid generation conditions.

Test plan :
- add 'userid' in syspref BorrowerUnwantedField
- try to create a new patron : /cgi-bin/koha/members/memberentry.pl
- there is not input text for userid
- choose non-existing surname and firstname
- click on save
=> Without patch : patron is not created, you see the alert message
"Username/password already exists"
=> With patch : patron is created, userid is generated with surname and
firstname
- remove 'userid' in syspref BorrowerUnwantedField and check it can be defined
in patron creation form

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Julian Maurice  changed:

   What|Removed |Added

  Attachment #42518|0   |1
is obsolete||

--- Comment #149 from Julian Maurice  ---
Comment on attachment 42518
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42518
Bug 13799 - Swagger2-driven Permission checking

Patch moved to its own bug (bug 14868)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42592|0   |1
is obsolete||
  Attachment #42639|0   |1
is obsolete||
  Attachment #42647|0   |1
is obsolete||
  Attachment #42752|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  
---
Created attachment 42762
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42762=edit
Bug 14805: Allow the user to delete multiple batches

Allows the user to delete multiple patron card batches.

Test plan:

1. Add first some 20 batches
2. Go to the edit page of some X batch by first selecting from the
   batch list the batch you want to edit and then after that by clicking
   edit.
3. Delete one batch by selecting one batch and then clicking delete.
4. Select 0 batches and click delete, notice you cannot delete.
5. Select 0 batches and click edit, notice you cannot edit.
6. Select 2 batches and click edit, notice you cannot edit.
7. Apply patch
8. Check that steps from 2-6 work like they worked before.
   (and add more batches so that you have ~20 of them)
9. Select 2 batches and click delete. Make sure they are deleted.
10. Try to figure out some anomalies this patch might have caused.

Sponsored-by: Vaara-kirjastot

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

--- Comment #13 from Jonathan Druart  
---
Created attachment 42763
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42763=edit
Bug 14805: QA follow-up

This patches remove a trailing whitespace and simplify 2 parts of code.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14805] Allow the deletion of multiple patron card batches

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14805

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission checking

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868

--- Comment #1 from Julian Maurice  ---
Created attachment 42761
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42761=edit
Bug 14868: Swagger2-driven Permission checking

A hasty downgrade from 13920, utilizing new features implemented by the
Mojolicious::Plugin::Swagger2-author, to make it possible to implement more
complex authentication/authorization scenarios with the Plugin.

Define 'x-koha-permission' for the Swagger2 Operation Object, to automatically
authorize against the required permissions.

This way we immediately tell the API consumer in the Swagger2-definition, which
permissions are needed to access defined resources.
Also we don't need to maintain permissions in multiple locations and we can
build
a smart testing framework to help a lot in creating tests for the new REST API.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #36 from Jonathan Druart  
---
Kyle,
They now apply but I think you forgot to apply 13517 before rebasing the
patches.
For instance, the first patch redefines the is_in_transit method.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

--- Comment #25 from Jonathan Druart  
---
Created attachment 42758
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42758=edit
Bug 13632: Do not use userflags.flagdesc and permissions.description

These 2 fields are not used anymore, but we want to keep them anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

--- Comment #27 from Jonathan Druart  
---
Created attachment 42760
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42760=edit
Bug 13632: Remove specific files

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13633] Change C4::Auth::get_all_subpermissions() to not use description

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13633

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Jonathan Druart  
---
Done in bug 13632.

*** This bug has been marked as a duplicate of bug 13632 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #148 from Julian Maurice  ---
No movement for a week, I'll move the last patch into its own bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13632] Use a translateable file instead of the database for managing permission descriptions

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

--- Comment #28 from Jonathan Druart  
---
*** Bug 13633 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

--- Comment #150 from Julian Maurice  ---
Created attachment 42766
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42766=edit
Bug 13799: Add missing license notices

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395

Holger Meißner  changed:

   What|Removed |Added

  Attachment #41197|0   |1
is obsolete||

--- Comment #26 from Holger Meißner  ---
Created attachment 42785
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42785=edit
Bug 14395: Unit tests

This patch adds new test cases to cover the changes introduced by
bug 14395.

To test:

1) prove t/db_dependent/Circulation.t

Sponsored-by: Hochschule für Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395

Holger Meißner  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #27 from Holger Meißner  ---
Sry it took so long, bondiurbano!

Now bug 14101 and 14395 have their own unit tests. Setting back to signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6178] tag cloud diff depends on where you click

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6178

--- Comment #21 from Jonathan Druart  
---
Anybody around?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13799] Add base for building RESTful API

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #42766|0   |1
is obsolete||

--- Comment #151 from Joonas Kylmälä  ---
Created attachment 42768
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42768=edit
Bug 13799: Add missing license notices

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12555] The DelItem subroutine should be called on canceling a receipt

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12555

--- Comment #20 from Jonathan Druart  
---
What can I do to unblock this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8991] Add a script to delete old orders

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8991

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11622] Add ability to pay fees and fines from OPAC via PayPal

2015-09-22 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11622

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #31 from Jonathan Druart  
---
There are 2 major issues:

1/ The amount is not updated and the "Make payment" button is always disabled
if javascript is disabled.
I think we should not allow to pay via Paypal (ie. not display "Pay selected
fines and charges" block) in this case.

2/ The currency is never displayed and the user does not know how much he is
going to pay.
>From my testing, the currency used seems to be USD, even if my Paypal balance
is in EUR. I did not find where we could change that, but this behavior is not
acceptable for users outside the USD zone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 182 matches

Mail list logo