[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

Mason James  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #18 from David Cook  ---
(In reply to Jonathan Druart from comment #17)
> (In reply to David Cook from comment #16)
> > Ultimately... I've changed my mind and I'm now in favour of this feature...
> > but I think is needs to be validate the attributes that the user is
> > providing.
> 
> So could we get your signoff, 2 is better than 1! :)

Well, I'd prefer a validation follow-up be added, but I'll look at testing this
next week in any case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

--- Comment #23 from David Cook  ---
Sounds good to me. I'm pretty much in favour of whatever solution at this point
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7045] Default-value substitution inconsistent

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

--- Comment #24 from Nicole C. Engard  ---
Created attachment 42940
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42940=edit
Bug 8483 - Add record and item related classes

Signed-off-by: Heather Braum 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #42787|0   |1
is obsolete||
  Attachment #42788|0   |1
is obsolete||
  Attachment #42935|0   |1
is obsolete||

--- Comment #23 from Nicole C. Engard  ---
Created attachment 42939
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42939=edit
Bug 8483 - Add checkout classes

Signed-off-by: Heather Braum 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

--- Comment #25 from Nicole C. Engard  ---
Created attachment 42941
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42941=edit
Bug 8483 - Borrower reading history should include deleted items

When showing a borrower's reading history, it'd be good to be able to
include the deleted items also, as we have that information available.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Members/GetAllIssues.t
3) Check out and return an item for a patron
4) Delete that item
5) Verify the record still shows in the patron's reading history
6) Delete the record entirely
7) Verify the record still shows in the patron's reading history,
   but that the title is now just text instead of a hyperlink.

Signed-off-by: Heather Braum 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting items cannot be reserved

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #42799|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 42938
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42938=edit
[SIGNED OFF] Bug 14871: Extend the patrons search to search like %$term%
(checkout tab)

The patrons search used by the checkout tab and the autocomplete is not
the same as the "search patrons" tab.
The main difference is the "contain" vs "start with".
So that if you have a patron with a patron with a surname "foo bar" and
you search for "foo bar", the autocomplete and the result of a search by
the checkout tab will search for "foo%" or "bar%" which won't return the
patron you are search for.

This patch replaces both autocomplete and checkout tab searches with a
"contain" search. The search will be "%foo%" or "%bar%".
Note that on big DB, this can cause unexpected results.

Test plan:
Create a patron with a surname "foo bar"
Search for "bar" using the checkout tab.
You should see the patron in the autocomplete result and the result page
after submitting the search form.

Followed test plan, works as expected.
Signed-off-by: Marc Véron 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917

Winona Salesky  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does not prevent librarian from placing the hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42873|0   |1
is obsolete||

--- Comment #19 from Kyle M Hall  ---
Created attachment 42936
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42936=edit
Bug 12197: enforce the maxreserves preference when staff members place hold
requests

This patch ensures that the global maxreserves preference is enforced
when staff members place hold requests.

For example:

Create 3 items to place holds on. Set the circulation rule to allow 50
holds for all items. Set maxreserves to 2. Place a hold on 3 different
items. On the third item, it will give a warning, but you can still
place the hold. Despite what the circulation rule is set for (which is
only a specific case rule), maxreserves is a global rule and
should stop this from happening, not just give a warning.

Test Plan:
1) Reproduce the bug by following the steps above
2) Verify the bug exists
3) Apply this patch
4) Verify the librarian cannot place the hold now
5) Enable AllowHoldPolicyOverride
6) Verify the librarian can forcefully place the hold

Signed-off-by: Galen Charlton 

Bug 12197: (follow-up) rename variable for greater clarity

"maxreserves" was referring both to the system preference and to the
condition of having exceeded the number of hold requests allowed.

This patch renames a variable to remove the ambguity.

Test plan:

* Same as the main patch.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||12197


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197
[Bug 12197] Exceeding the maxreserves preference does not prevent librarian
from placing the hold
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910

--- Comment #2 from Marc Véron  ---
Created attachment 42937
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42937=edit
[Signed-off] Bug 14910: Redirect to the circulation module after a renew

iIf a patron is renewed from the circulation module, the librarian
should be redirected to the circulation module.
This works correctly if the renew is done from the patron module
(members).

This is caused by a typo in the template: desintation vs destination.

This patch also removes the cardnumber parameter to the setstatus.pl
script, it is not needed given that borrowernumber is always passed.

This has a good side-effect, it will fix bug 14691. The cardnumber does
not exist anymore, so no need to escape it :)

Test plan:
0/ Do not apply this patch
1/ Create a patron with a cardnumber with a quote (rm'me) and another
one without a quote (rmme)
2/ Go on the checkouts page (circ/circulation.pl)
3/ Renew the 2 patrons
=> With rm'me you are redirected to the circ module - ok
=> With rmme you are redirected to the member module - nok
4/ Go on the patron detail page (members/moremember.pl)
5/ Renew the 2 patrons
=> you are redirected to the member module - ok
6/ Delete the patrons
=> Nothing happend with rm'me, there is a JS error on the page - nok
=> rmme is deleted - ok

7/ Apply the patch and recreate rmme
8/ Repeat 2, 3, 4, 5
=> You are redirected to the correct module
9/ Delete the patrons
=> They are successfully deleted

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #42906|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does not prevent librarian from placing the hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||11250


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250
[Bug 11250] "too many holds" message appears inappropriately
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14597] Reverting a batch where a record overlaid is now deleted record will fail

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14597

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #29 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #20 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42932|0   |1
is obsolete||

--- Comment #22 from Kyle M Hall  ---
Created attachment 42935
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42935=edit
Bug 8483 - Borrower reading history should include deleted items

When showing a borrower's reading history, it'd be good to be able to
include the deleted items also, as we have that information available.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Members/GetAllIssues.t
3) Check out and return an item for a patron
4) Delete that item
5) Verify the record still shows in the patron's reading history
6) Delete the record entirely
7) Verify the record still shows in the patron's reading history,
   but that the title is now just text instead of a hyperlink.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

--- Comment #21 from Heather Braum  ---
If the patch for bug 14910 fixes this issue, too, then great -- I'll mark this
as a duplicate. Thanks Jonathan, Liz, and David for looking into and working on
this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

Heather Braum  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #22 from Heather Braum  ---


*** This bug has been marked as a duplicate of bug 14910 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910

--- Comment #3 from Heather Braum  ---
*** Bug 14691 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

--- Comment #20 from Liz Rea  ---
Awesome, getting rid of the cardnumber altogether here is probably best. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14317] Apache 2.4 Directory config needs Require all granted

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14317

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 CC||tomasco...@gmail.com
 Status|NEW |RESOLVED

--- Comment #4 from Tomás Cohen Arazi  ---
I'm closing this for now. If we encounter this problem again, a new bug should
be fixed, with reproducible steps.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #36683|0   |1
is obsolete||

--- Comment #66 from Matthias Meusburger  ---
Created attachment 42923
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42923=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

 - Various fixes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #17 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14054] 246 XSLT Improvements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #13 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Winona!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42789|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall  ---
Created attachment 42932
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42932=edit
Bug 8483 - Borrower reading history should include deleted items

When showing a borrower's reading history, it'd be good to be able to
include the deleted items also, as we have that information available.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Members/GetAllIssues.t
3) Verify old checkouts for deleted items show in reading history

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42916|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371

--- Comment #20 from Marc Véron  ---
Sorry, I saved the changes to early.

Further testing:

- your lists: Display after hitting "Back"

- ask for a discharche: OK behalve of case explained under 'your summary' in
comment #19

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14916] New: Remove C4::Dates from circ/overdue.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916

Bug ID: 14916
   Summary: Remove C4::Dates from circ/overdue.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

Patch to remove deprectated C4::Dates from circ/overdue.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42917|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14359] RDA: 700/710/711 display in XSLT Bug fix for Contributors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359

--- Comment #4 from Winona Salesky  ---
Hi Jonathan, 
Can you clarify please? Would you like me to submit a new bug for just the icon
path?
Thanks,
-Winona


(In reply to Jonathan Druart from comment #3)
> Winona,
> The display issue has already been fixed.
> Could you resubmit a patch for the icon path please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

--- Comment #24 from Jonathan Druart  
---
IMO this should be pushed with bug 14915, or we should comment the change in
  koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc
and
  koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc

for the next release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does not prevent librarian from placing the hold

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197

--- Comment #18 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #17)
> > So bug 11250 and this one should be pushed together, that's it?
> 
> Yes, I would agree with that.

They are in conflict, could you provide dependent patches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #20 from Kyle M Hall  ---
> > I set up about 350 holidays and tried
> > checkout periods of 180 and  days. Both were about the same speed with
> > and without the patches respectively. 
> 
> your circ speed will only be slow if you test against a patron who has a
> branch with many holidays *and* an item with a matching long loan period rule

Confirmed! I think the issue was my rule was selecting a library other than the
one my holidays were set for!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42925|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 42929
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42929=edit
Bug 14915 - Use Font Awesome instead of Glyphicons for the staff intranet

We should be using Font Awesome for our icons instead of Glyphicons, for
the reasons discussed on bug 13696.

Test Plan:
1) Apply this patch
2) Note all Glyphicons have been replaced with FA icons in the staff intranet
3) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/modules/
   should give no results
4) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/includes/
   should give no results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14905] search_utf8.t fails to upload a file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

--- Comment #21 from Kyle M Hall  ---
Created attachment 42931
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42931=edit
Bug 13696 [QA Followup] - Add Font Awesome license to the about page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #24 from Kyle M Hall  ---
Created attachment 42922
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42922=edit
[PASSED QA] Bug 14522 [QA Followup] - Remove $single_holidays global

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42851|0   |1
is obsolete||
  Attachment #42887|0   |1
is obsolete||
  Attachment #42888|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall  ---
Created attachment 42919
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42919=edit
[PASSED QA] Bug 14522 - Use Koha::Cache for accessing single_holidays()

this patch adds Koha::Cache functionality to the 'single_holidays' table
it is a performance patch for the problem described in BZ14315, only

 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14315

it replaces slooow DateTime holiday objects with simple Ymd strings (19991230),
then stores the strings in an @array using Koha::Cache
it does not attempt to add caching to all holiday tables - just the
single_holidays table (at this stage

 on my test (master-cd9a827); nytprof showed a time reduction of the
single_holidays() sub - from 61.7s to 587ms

here are some before/after nytprof runs, (really on master-cd9a827, not 3.20)


http://x1.kohaaloha.com/i/nyt-bz14522-before/home-mason-g-k-3-20-x-Koha-Calendar-pm-1485-line.html#237

http://x1.kohaaloha.com/i/nyt-bz14522-after/home-mason-g-k-3-20-x-Koha-Calendar-pm-1485-line.html#280

to test...

1/ add a bunch of single_holidays to your test koha, (my table has 400 holiday
rows)
2/ add a loong circ rule for an itemtype (my rule has 140 days)
3/ checkout an item to a user (took me 67 secs)

apply patch...
4/ return item
5/ repeats steps 1..3, (took me 6 secs)

6/ add/change/delete some various single_holidays, via Home->Tools->Calendar
ensure that your various changes have indeed saved correctly

for extra points...

7/ run tests t/Calendar.t and t/db_dependent/Holidays.t, with all tests pass OK

 sudo  koha-shell -c '  export PERL5LIB=/home/mason/g/k/master ; \
 cd /home/mason/g/k/master ;  perl  t/Calendar.t ; perl 
t/db_dependent/Holidays.t  '   testkoha

8/ run QA tool, with all tests pass OK

 sudo  koha-shell -c ' \
export KOHA_CONF=/etc/koha/sites/mayo2/koha-conf.xml \
 export PERL5LIB=/home/mason/g/k/master:/home/mason/qa-test-tools/ ; \
 cd /home/mason/g/k/master ;   perl /home/mason/qa-test-tools/koha-qa.pl  -c 1
' testkoha

Signed-off-by: Nick Clemens 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #22 from Kyle M Hall  ---
Created attachment 42920
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42920=edit
[PASSED QA] Bug 14522 [Followup] - fix =cut typo

http://bugs.koha-community.org/show_bug.cgi?id=14522

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #67 from Matthias Meusburger  ---
This last patch fixes the issues you've raised when testing, Katrin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #25 from Jonathan Druart  
---
Comment on attachment 42919
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42919
[PASSED QA] Bug 14522 - Use Koha::Cache for accessing single_holidays()

Review of attachment 42919:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14522=42919)
-

It seems we were here at the same time :)

I have also tried to reproduce the time reduction, without success.
A script I have used is coming...

::: Koha/Calendar.pm
@@ +94,5 @@
>  my $branchcode = $self->{branchcode};
> +my $cache   = Koha::Cache->get_instance();
> +my $single_holidays = $cache->get_from_cache('single_holidays');
> +
> +=c

Should be a simple comment, no need to put it in the pod.

@@ +395,5 @@
> +$single_holidays->{'MPL'} = [$ymd];
> +$cache->set_in_cache( 'single_holidays', $single_holidays, 76800 );
> +
> +# ...but *dont* reset the cache, as this holiday was not really written 
> to the db
> +# its only used to mock a holiday insert for 1 test in 
> t/db_dependent/Holidays.t

Should not be a method here, but moved to the test file or a test module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #26 from Jonathan Druart  
---
Created attachment 42926
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42926=edit
Script to try and reproduce the problem

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14368] Add discharges history

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14368

--- Comment #29 from Tomás Cohen Arazi  ---
Created attachment 42930
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42930=edit
Bug 14368: (RM followup) DBIx update

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

--- Comment #23 from Jonathan Druart  
---
Created attachment 42934
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42934=edit
Bug 13696 [QA Followup] - Add Font Awesome license to the about page

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14781] Creation of barcode types 2of5 not functional

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14781

--- Comment #13 from Marc Véron  ---
Ping for Signoff  :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #36434|0   |1
is obsolete||
  Attachment #42931|0   |1
is obsolete||

--- Comment #22 from Jonathan Druart  
---
Created attachment 42933
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42933=edit
Bug 13696 - Add support for Font Awesome icons in Koha

Font Awesome is similar to Glyphicons included in Twitter Bootstrap,
except better in every way and more Free.

Test Plan:
1) Apply this patch
2) Edit the template for a page, and add a Font Awesome tag to it,
   examples can be found here:
   http://fortawesome.github.io/Font-Awesome/examples/
3) Reload the page and verify the icon displays.

Signed-off-by: Mirko Tietgen 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14916] Remove C4::Dates from circ/overdue.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916

Marc Véron  changed:

   What|Removed |Added

  Attachment #42927|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 42928
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42928=edit
Bug 14916 - Remove C4::Dates from circ/overdue.pl

Patch to remove deprectated C4::Dates from circ/overdue.pl

To test:

- Tests without patch:
- Make sure that you have patron(s) with overdues.
- Go to Home > Circulation > Overdues
- Apply date filter, perform CSV download

Apply patch, then
- Reload page
- Check that everything behaves as before

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14909] Warnings from search_utf8.t when empty idx= misses in returned base

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14909

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14904] Resolve warning from tt_valid.t

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14904

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861

--- Comment #2 from Barton Chittenden  ---
(In reply to David Cook from comment #1)
> Hey Barton, I can explain the cause (and solution).
> 
> Check out "ccl.properties":
> 
> Date-of-publication 1=31 r=r
> yr Date-of-publication
> pubdate Date-of-publication
> 
> Date-of-acquisition 1=32
> acqdate Date-of-acquisition
> 
> st-numeric  4=109 r=o
> st-name-normalized  4=101
> 
> If you look at the Zebra docs, you'll see that r=o and r=r are special
> attributes for doing range searches
> (http://www.indexdata.com/yaz/doc/tools.html). 
> 
> I wrote about this last year on
> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12897 but I didn't
> go any further with it as it would be nice to make some more logical changes
> across the board... but feel free to make a patch to fix this particular
> case.
> 
> --
> 
> Locally, I've done the following to solve this problem:
> 
> Date-of-acquisition 1=Date-of-acquisition r=o
> acqdate Date-of-acquisition

Ok, this is from my ccl.properties:

Date-of-acquisition 1=32
Date-of-acquisition 1=Date-of-acquisition r=o
acqdate Date-of-acquisition

Given an item where acqdate is 2011-09-07,

  search.pl?idx=acqdate%2Cst-date-normalized=2011-09-07

works, but querying the entire month from 2011-09-01 to 2011-09-30 does not:

  search.pl?idx=acqdate%2Cst-date-normalized="2011-09-01+-+2011-09-30"

Returns no results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371

--- Comment #19 from Marc Véron  ---
With Firefox 40.0.3 (Win), I tested all left tabs by doing the following:

- Log in to OPAC
- Go to a tab at the left side
- Logout
- Hit browser's back button

Tabs tested:

- your summary: OK, however if you log in from the home page, then immediately
log out and then hit the back button, the browser asks says 'Document expired
(...) try again'. If you do so ('Send data again'), you are logged in. You can
get the same after changing to other tabs by clicking the 'Back' button until
you get 'Document expired...'

- your fines: OK *)

- your personal details: After hitting back button, I get Home > Register a new
account. I would expect a login page or the home page

- your tags: After hitting back, I see the list of personal tags, patron seems
to be logged in again (Name appears in Header). However if e.g. I try to delete
a tag, I'm redirected to the Log in page

- change your password: OK*)

- your search history: 'Back' leads me back to Home > Search history with
message 'Your catalog search history is empty'. I would expect a login page or
the home page.

- your reading history: "Back" displays the Checkout history

- your privacy: OK*)

- your purchase suggestion: After 'Back', patron seems to be logged in (Name in
header), but the page says: "You are not authorized to see pending purchase
suggestions. If I then hit the link 'New purchase suggestion' I'm redirected to
the page for anonymous suggestions (patron's name disappears from header).

- your messaging: After "Back", patron's messaging settings are displayed. If I
change them ans submit changes, I get the log in screen




*) behalve of case explained under 'your summary'

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

--- Comment #23 from Kyle M Hall  ---
Created attachment 42921
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42921=edit
[PASSED QA] Bug 14522 [QA Followup] - Koha complains about missing C4::Dates on
master

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

--- Comment #20 from Kyle M Hall  ---
I think this can go back to signed off now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

--- Comment #18 from Jonathan Druart  
---
So why don't we replace them?
I don't see the point to integrate them into Koha if we don't use it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Matthias Meusburger  changed:

   What|Removed |Added

  Attachment #42923|0   |1
is obsolete||

--- Comment #68 from Matthias Meusburger  ---
Created attachment 42924
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42924=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Various fixes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14054] 246 XSLT Improvements

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054

--- Comment #14 from Winona Salesky  ---
Great! 
Thank you, 
-Winona

(In reply to Tomás Cohen Arazi from comment #13)
> Patch pushed to master.
> 
> Thanks Winona!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14368] Add discharges history

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14368

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #30 from Tomás Cohen Arazi  ---
Patches pushed to master.

Good job, Matthias!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14917] New: RDA: 700/710/711 fix path for icon in XSLT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917

Bug ID: 14917
   Summary: RDA: 700/710/711 fix path for icon in XSLT
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: wsale...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Fix broken path to icon in 7xx fields. Bug introduced in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382#c45

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||13696


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696
[Bug 13696] Add support for Font Awesome icons in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||14915


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915
[Bug 14915] Use Font Awesome instead of Glyphicons
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] New: Use Font Awesome instead of Glyphicons

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Bug ID: 14915
   Summary: Use Font Awesome instead of Glyphicons
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: kyle.m.h...@gmail.com
QA Contact: testo...@bugs.koha-community.org

We should be using Font Awesome for our icons instead of Glyphicons, for the
reasons discussed on bug 13696.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #1 from Kyle M Hall  ---
Created attachment 42925
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42925=edit
Bug 14915 - Use Font Awesome instead of Glyphicons for the staff intranet

We should be using Font Awesome for our icons instead of Glyphicons, for
the reasons discussed on bug 13696.

Test Plan:
1) Apply this patch
2) Note all Glyphicons have been replaced with FA icons in the staff intranet
3) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/modules/
   should give no results
4) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/includes/
   should give no results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14916] Remove C4::Dates from circ/overdue.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Blocks||14870
   Assignee|gmcha...@gmail.com  |ve...@veron.ch
 Status|NEW |Needs Signoff


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870
[Bug 14870] Delete C4/Dates.pm from System
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Marc Véron  changed:

   What|Removed |Added

 Depends on||14916


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916
[Bug 14916] Remove C4::Dates from circ/overdue.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Kyle M Hall  changed:

   What|Removed |Added

Summary|Use Font Awesome instead of |Use Font Awesome instead of
   |Glyphicons  |Glyphicons for the staff
   ||intranet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14916] Remove C4::Dates from circ/overdue.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14916

--- Comment #1 from Marc Véron  ---
Created attachment 42927
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42927=edit
Bug 14916 - Remove C4::Dates from circ/overdue.pl

Patch to remove deprectated C4::Dates from circ/overdue.pl

To test:

- Tests without patch:
- Make sure that you have patron(s) with overdues.
- Go to Home > Circulation > Overdues
- Apply date filter, perform CSV download

Apply patch, then
- Reload page
- Check that everything behaves as before

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

--- Comment #19 from Kyle M Hall  ---
I agree we should replace them! (In reply to Jonathan Druart from comment #18)
> So why don't we replace them?
> I don't see the point to integrate them into Koha if we don't use it.

Ok! Let's do it! Bug 14915 switches the staff side to Font Awesome icons. I
will file another patch for the opac side!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14359] RDA: 700/710/711 display in XSLT Bug fix for Contributors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359

--- Comment #5 from Jonathan Druart  
---
Yes please.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14904] New: Resolve warning from tt_valid.t

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14904

Bug ID: 14904
   Summary: Resolve warning from tt_valid.t
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14321] Merge UploadedFile and UploadedFiles into Koha::Upload

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14321

--- Comment #87 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #86)
> This patches broke the search_utf8.t tests. Please take a look.

I fixed the warning from tt_valid.t. See bug 14904.
search_utf8.t is not on jenkins.
Which tests exactly fail?
If I am running this test now without the patches pushed yet, I also have some
errors. But this may be a configuration thing..
Still looking into this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14904] Resolve warning from tt_valid.t

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14904

--- Comment #1 from Marcel de Rooy  ---
Created attachment 42898
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42898=edit
Bug 14904: Resolve warning from tt_valid.t

Test tt_valid.t warns that opac-retrieve-file.tt has no id and class
attribute on the body tag.
This patch adds them to clear the warning.

Test plan:
Apply patch and run xt/tt_valid.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14904] Resolve warning from tt_valid.t

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14904

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292

--- Comment #6 from Jonathan Druart  
---
(In reply to Barton Chittenden from comment #5)
> Created attachment 42892 [details] [review]
> Bug 14292: QA Follow-up

In this case it is always good to explain what does the follow-up. Either in a
comment or, better, in the commit message.
Should I suppose all my comments have been taken into account in it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14904] Resolve warning from tt_valid.t

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14904

--- Comment #2 from Marc Véron  ---
Created attachment 42899
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42899=edit
[Signed-off] Bug 14904: Resolve warning from tt_valid.t

Test tt_valid.t warns that opac-retrieve-file.tt has no id and class
attribute on the body tag.
This patch adds them to clear the warning.

Test plan:
Apply patch and run xt/tt_valid.t.

Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14904] Resolve warning from tt_valid.t

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14904

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #42898|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14904] Resolve warning from tt_valid.t

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14904

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899

--- Comment #8 from Jonathan Druart  
---
(In reply to Peter Zhao from comment #7)
> http://127.0.0.1:8080/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.
> pl
> 
> 
> An error has occurred!
> Error 500
> 
> In Koha this typically means that the Koha team is working on new
> features
> Wait while system maintenance is being done or email the Koha
> administrator.
> Use top menu bar to navigate to another part of Koha.

What is the error in the log file?
How did you test?

To test:
$ git remote -v
# should at least return
catalystgit://git.catalyst.net.nz/koha.git (fetch)
catalystgit://git.catalyst.net.nz/koha.git (push)
$ git fetch catalyst
$ git checkout -b bug_14899 catalyst/elastic_search
$ git bz apply 14899
$ perl installer/data/mysql/updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14905] New: search_utf8.t fails to upload a file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905

Bug ID: 14905
   Summary: search_utf8.t fails to upload a file
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: gmcha...@gmail.com

Follow-up from error reported on bug 14321

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14905] search_utf8.t fails to upload a file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14905] search_utf8.t fails to upload a file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14905

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42903|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 42909
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42909=edit
Bug 14905: Search_utf8.t fails to upload a file

Running the test fails on test 7:
not ok 7 - upload succeeded

The changes on bug 14321 included a temp flag for script upload-file.pl.
Since this upload for stage-marc-import should be temporary, adding this
flag to line 131 resolves the problem.

Test plan:
Run the adjusted test.
NOTE: I still had some problems with this test. And will still be looking
to these errors (perhaps open a new report). But this fix should at least
fix the above-mentioned test.

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11425] Search form for items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14908


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14908
[Bug 14908] Item search: Item search results not properly sorted by Date. Date
filter also not working
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14908] Item search: Item search results not properly sorted by Date. Date filter also not working

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14908

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||11425
Version|3.20|master


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425
[Bug 11425] Search form for items
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

--- Comment #33 from Theodoros Theodoropoulos  ---
Sure thing Katrin!

(In case anyone in the future needs the link, the new enhancement request is
found here: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42648|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  
---
Created attachment 42911
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42911=edit
Bug 5371: Force no caching for private pages at the OPAC

In order no to slow too much the browsing, it is certainly not a good
idea to add this cache-control value for all pages at the OPAC.

This patch just adds where the author found it could be useful.

Test plan:
1/ Login at the OPAC
2/ Go on the account page (opac/opac-account.pl)
3/ Click log out
4/ Use the back button of your browser
Without this patch you will see the previous page.
With this patch, the previous page will be reloaded and you will be
redirected to the login form.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #17 from Jonathan Druart  
---
(In reply to David Cook from comment #16)
> Ultimately... I've changed my mind and I'm now in favour of this feature...
> but I think is needs to be validate the attributes that the user is
> providing.

So could we get your signoff, 2 is better than 1! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14884] [3.20.X] Test failure from Bug 14470

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14884

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14884] [3.20.X] Test failure from Bug 14470

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14884

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #42849|0   |1
is obsolete||
  Attachment #42850|0   |1
is obsolete||

--- Comment #6 from Marcel de Rooy  ---
Created attachment 42912
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42912=edit
Bug 14884: remove spurious conflict markers

To test:
* Run t/00-merge-conflict-markers.t, ensure it passes

Signed-off-by: Jonathan Druart 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912

Lari Taskula  changed:

   What|Removed |Added

  Attachment #42914|0   |1
is obsolete||

--- Comment #2 from Lari Taskula  ---
Created attachment 42915
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42915=edit
Bug 14912: Sort Advanced Search Languages by priority

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292

--- Comment #7 from Barton Chittenden  ---
(In reply to Jonathan Druart from comment #4)
> Comment on attachment 42614 [details] [review]
> [SIGNED-OFF] Bug 14292: Add patron category restrictions to longoverdue.pl
> 
> Review of attachment 42614 [details] [review]:
> -
> 
> ::: misc/cronjobs/longoverdue.pl
> @@ +52,5 @@
> > +GetOptions(
> > +'lost=s%' => \$lost,
> > +'c|charge=s'  => \$charge,
> > +'confirm' => \$confirm,
> > +'verbose' => \$verbose,
> 
> Doc says v|verbose
> 
> @@ +56,5 @@
> > +'verbose' => \$verbose,
> > +'quiet'   => \$quiet,
> > +'maxdays=s'   => \$endrange,
> > +'mark-returned'   => \$mark_returned,
> > +'help'=> \$help,
> 
> Doc says h|help
> 
> @@ +77,5 @@
> > +
> > +   longoverdue.pl [ --help | -h | --man ]
> > +   longoverdue.pl --lost | -l DAYS=LOST_CODE [ --charge | -c CHARGE_CODE ] 
> > [ --verbose | -v ] [ --quiet ]
> > +  [ --maxdays MAX_DAYS ] [ --mark-returned ] [ --category 
> > BORROWER_CATEGOERY ] ...
> > +  [ --skip-category BORROWER_CATEGOERY ] ... [ --commit ]
> 
> Typo 'CATEGOERY'
> 

Fixed v|verbose and h|help options, as well as 'BORROWER_CATEGOERY' typo.

I left the --category and --skip-category options as-is. I don't have a good
reason to keep them, but they're not hurting anything either; we can re-visit
if they cause confusion.

Changed 'die' to

> pod2usage({
> -exitval => 1,
> -msg => q|ERROR: No --lost (-l) option defined|,
> });


Removed borrower_categories_sth in favor of

my $dbh = C4::Context->dbh;
my @categories = map { uc $_->[0] } @{ $dbh->selectall_arrayref(q|SELECT
categorycode FROM categories|) };


> @@ +273,4 @@
> >  #FIXME - Should add a 'system' user and get suitable userenv for it for 
> > logging, etc.
> >  
> >  my $count;
> > +# my @ranges = map {
> 
> I would simply remove it :)

I wasn't clear about this comment, but I removed the #FIXME comment and the

# my @ranges = map {

statement, both of which seemed useless.

> 
> @@ +294,5 @@
> >  $sth_items->execute($startrange, $endrange, $lostvalue);
> >  $count=0;
> > +ITEM: while (my $row=$sth_items->fetchrow_hashref) {
> > +if( $filter_borrower_categories ) {
> > +my $category = uc 
> > Koha::Database->new()->schema->resultset('Borrower')->find( 
> > $row->{borrowernumber} )->get_column('categorycode');
> 
> Why don't you use Koha::Borrowers?

Done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

--- Comment #16 from Jonathan Druart  
---
Trying to unblock this bug report:
I have submitted 2 new patches, they insert a new pref 'IconTheme' which can be
changed from Glyphicons to Font-Awasome.
All the icons used should be impacted by this change.

Was it the idea behind this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/