[Koha-bugs] [Bug 11039] SIP Server responds with valid CHECKIN to SC but fails to checkin item on Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039 Katrin Fischerchanged: What|Removed |Added Version|3.12|3.18 CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- We are seeing this behaviour as well it seems in a 3.18.8 installation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc Véronchanged: What|Removed |Added Attachment #42895|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 42989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42989=edit Bug 14903 - Remove C4::Dates from circ/circulation.pl Patch to remove deprectated C4::Dates from circ/circulation.pl To test: - Apply patch - Go to the checkout site (Home > Circulation > Checkouts) - Verify that data displays properly (including for users with a card that expires in the near future, see syspref 'NotifyBorrowerDeparture') - Verify that due date works as before (with syspref 'SpecifyDueDate' on and off (Amended following comment #3) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc Véronchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #19 from Jonathan Druart --- I am not familiar with ccl.properties, but there is a st-numeric 4=109 r=o Does - st-date-normalized 4=5 + st-date-normalized 4=5 r=o could do the trick for all date indexes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Magnus Engerchanged: What|Removed |Added CC||mag...@libriotech.no --- Comment #5 from Magnus Enger --- Colin: What do you think of the proposal from Jonathan? Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like a good idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||ulrich.klei...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- Marc, What about using Koha::DateUtils to replace ->today? Something like my $today = dt_from_string; my $month = $today->month; my $day = $today->day; do what you want. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #21 from Jonathan Druart--- Created attachment 43002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43002=edit Bug 5371: (follow-up) Force no caching for private pages at the OPAC Same as previous patch for opac-messaging.pl and opac-readingrecord.pl -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14842] Wrong call to GetBranchItemRule in circ/returns.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 --- Comment #4 from Jonathan Druart--- If I remember correctly you must use an itemtype with a return policy. Whatever the value of the policy, the return branch will always be the homebranch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #25 from Josef Moravec--- I tried it on non-empty table, but have the same issue... I am not able to figure out where is the problem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #29 from Jonathan Druart --- To test bug 13918 I need to apply this patch set before but it does not apply anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101 --- Comment #24 from Jonathan Druart--- Comment on attachment 39800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39800 Bug 14101: Automatic renewals exactly on due date Review of attachment 39800: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14101=39800) - ::: C4/Circulation.pm @@ +2737,4 @@ > return ( 0, "too_many" ) >if $issuingrule->{renewalsallowed} <= $itemissue->{renewals}; > > +if ( defined $issuingrule->{norenewalbefore} ) { What about the empty string? I am not sure it's relevant, but I would like to be sure. @@ +2751,5 @@ > return ( 0, "too_soon" ); > } > +else { > +return ( 0, "auto_renew" ) if $itemissue->{auto_renew}; > +return ( 1, undef ); This last return is not needed, the process should continue I think. Imagine someone else adds a new check in the futur. @@ +2759,5 @@ > +# Fallback for automatic renewals: > +# If norenewalbefore is undef, don't renew before due date. > +elsif ( $itemissue->{auto_renew} ) { > +return ( 0, "auto_renew" ) > + if DateTime->now( time_zone => C4::Context->tz() ) >= Prefer dt_from_string to get a DateTime object. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marc Véronchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #23 from Marc Véron--- Created attachment 43004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43004=edit [Signed-off] Bug 5371: Force no caching for private pages at the OPAC In order no to slow too much the browsing, it is certainly not a good idea to add this cache-control value for all pages at the OPAC. This patch just adds where the author found it could be useful. Test plan: 1/ Login at the OPAC 2/ Go on the account page (opac/opac-account.pl) 3/ Click log out 4/ Use the back button of your browser Without this patch you will see the previous page. With this patch, the previous page will be reloaded and you will be redirected to the login form. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 --- Comment #9 from Magnus Enger--- (In reply to Jonathan Druart from comment #8) > Magnus, could you confirm you have correctly cleared your browser cache? Ah, not necessarily. I'll have another go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #24 from Marc Véron--- Created attachment 43005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43005=edit [Signed-off] Bug 5371: (follow-up) Force no caching for private pages at the OPAC Same as previous patch for opac-messaging.pl and opac-readingrecord.pl Signed-off-by: Marc Véron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Marc Véronchanged: What|Removed |Added Attachment #42911|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #22 from Jonathan Druart--- (In reply to Josef Moravec from comment #21) > I have VM with Debian Jessie, but with MariaDB instead of MySQL... I'll try > it on another machine with MySQL tomorow... Using MariaDB I don't get the issue you have described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 --- Comment #5 from Marc Véron--- Created attachment 43003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43003=edit [Signed-off] Bug 14918: Remove C4::Dates from circ/pendingreserves.pl This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It also sent DateTime objects to the template, which use the TT plugin to display them. If an invalid dates is entered, the default date is picked. Test plan: 1/ Go to Home > Circulation > Holds to pull 2/ Verify that the the filter and the list behave as before 3/ Enter invalid dates and confirm that you do not get a software error Counter patch works as expected and is a much cleaner solution. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Marc Véronchanged: What|Removed |Added Attachment #43002|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Marc Véronchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Olli-Antti Kivilahtichanged: What|Removed |Added CC||olli-antti.kivila...@jns.fi Assignee|koha-b...@lists.koha-commun |j.kylm...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14932] serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Olli-Antti Kivilahtichanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 --- Comment #6 from Jonathan Druart--- (In reply to Magnus Enger from comment #5) > Colin: What do you think of the proposal from Jonathan? > Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like > a good idea. No, I would like to keep my QA token. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14932] New: serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Bug ID: 14932 Summary: serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: olli-antti.kivila...@jns.fi QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Currently we have subscriptions with 300+ serials received. It takes a lot of time to show serials-collection.pl (~20s). This is especially troublesome when receiving serials, since after receival we get redirected to that page. We no longer can receive daily serials in the allotted timeframe. This quick and dirty fix prevents checking the subscription editing for each serial, but instead checks it for the first serial only. This reduced page load time by ~18s TEST PLAN: 1. Receive ~300 serials (or just a bunch :) ) 2. Observe the gradual slowing of the receival action. AFTER THIS PATCH: 1. Receive ~300 serials more (or just a bunch) 2. Observe a significant performance improvement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14932] serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 --- Comment #1 from Olli-Antti Kivilahti--- Created attachment 43007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43007=edit Bug 14932 - serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Currently we have subscriptions with 300+ serials received. It takes a lot of time to show serials-collection.pl (~20s). This is especially troublesome when receiving serials, since after receival we get redirected to that page. We no longer can receive daily serials in the allotted timeframe. This quick and dirty fix prevents checking the subscription editing for each serial, but instead checks it for the first serial only. This reduced page load time by ~18s TEST PLAN: 1. Receive ~300 serials (or just a bunch :) ) 2. Observe the gradual slowing of the receival action. AFTER THIS PATCH: 1. Receive ~300 serials more (or just a bunch) 2. Observe a significant performance improvement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #23 from Josef Moravec--- Hm, on another machine everything works perfect... So probably some problem with my specific data, or something on that one VM. So please, ignore me ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #29 from Jonathan Druart--- Comment on attachment 41054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41054 Bug 14395: Code changes Review of attachment 41054: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14395=41054) - Please provide a better commit description. ::: C4/Circulation.pm @@ +2772,5 @@ > +{ > +$soonestrenewal->truncate( to => 'day' ); > +} > + > +if ( $soonestrenewal > DateTime->now( time_zone => C4::Context->tz() > ) ) Prefer dt_from_string to get a DateTime object (yes this already existed before your patch, but it's worth to make things consistent). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- I think this needs small tweaks. For instance, compare the "+" icon on /cgi-bin/koha/serials/serials-home.pl Before this patch, it was correctly aligned, now it's not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756 --- Comment #3 from Katrin Fischer--- Hm, there is also the other way around - if we make Koha-to-MARC-Mappings 1:n, we also need to change the procedures that are used for creating a record from a non-marc format, for example in acquisitions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Magnus Engerchanged: What|Removed |Added Status|Needs Signoff |Failed QA CC||mag...@libriotech.no --- Comment #7 from Magnus Enger --- (In reply to Jonathan Druart from comment #5) > Test plan: > 0/ Do not apply this patch > 1/ Create a patron with a cardnumber with a quote (rm'me) and another > one without a quote (rmme) > 2/ Go on the checkouts page (circ/circulation.pl) > 3/ Renew the 2 patrons > => With rm'me you are redirected to the circ module - ok > => With rmme you are redirected to the member module - nok I can reproduce this without the patch. But after I apply the patch, I get this: rm'me: No JS popup confirmation, but redirected to the circ module rmme: JS popup confirmation, but redirected to the member module For rmme I get this error in the Firebug Console: SyntaxError: expected expression, got ',' firstDay: , For rm'me I get two errors: SyntaxError: expected expression, got ',' firstDay: , SyntaxError: missing ; before statement ...owernumber=6450cardnumber=rm'medesintation=circreregistration=y' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #22 from Jonathan Druart--- Marc, Thanks for testing. I have added the trick on the messaging and circulation history page. I have not changed the lists/shelves page, the module and script are going to be rewritten on another bug (bug 14544) and I don't want to introduce conflicts. I am not sure we should add the no-store value for the cache policy on other pages. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #24 from Jonathan Druart--- Josef, if you are still able to reproduce the issue, with the last patches against master, I think we should try to understand what is the problem :) Could you confirm you got the issue even with a non-empty creator_batches table? I have not tried with en empty table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #26 from Jonathan Druart --- I was afraid of the complexity in the call stack, so did some tests: $ more bug_8483.pl use Modern::Perl; use C4::Members; my $borrowernumber=42; my $issues = GetAllIssues( $borrowernumber, 'date_due desc' ); > select count(*) from old_issues where borrowernumber=42; 43 > select count(*) from issues where borrowernumber=42; 7 $ git checkout master; git reset --hard origin/master $ git checkout -b bug_8483; git bz apply 8483 $ git checkout master; time perl bug_8483.pl perl bug_8483.pl 1.23s user 0.04s system 99% cpu 1.270 total $ git checkout bug_8483; time perl bug_8483.pl perl bug_8483.pl 1.50s user 0.05s system 99% cpu 1.560 total # => Ok we get the old_issues in addition of # Adding some issues to the patron > select count(*) from issues where borrowernumber=42; 49 # master perl bug_8483.pl 1.21s user 0.08s system 99% cpu 1.280 total # bug_8483 perl bug_8483.pl 1.82s user 0.07s system 97% cpu 1.933 total 210 # master perl bug_8483.pl 1.21s user 0.07s system 98% cpu 1.293 total # bug_8483 perl bug_8483.pl 2.73s user 0.09s system 95% cpu 2.959 total 600 # master perl bug_8483.pl 1.28s user 0.03s system 97% cpu 1.340 total # bug_8483 perl bug_8483.pl 4.78s user 0.10s system 94% cpu 5.154 total -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756 Zeno Tajolichanged: What|Removed |Added Patch complexity|--- |Medium patch Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marc Véronchanged: What|Removed |Added Attachment #42992|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Christophe Brocquetchanged: What|Removed |Added CC||christophe.brocquet@obspm.f ||r -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14933] New: SIPserver should not use warn or die to log errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14933 Bug ID: 14933 Summary: SIPserver should not use warn or die to log errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com warn and die are used in various places in the SIPServer but the messages are lost as STDERR is closed by Net::Server in these cases the error message should be logged to syslog as with other error and debug messages and exit should be used -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 --- Comment #8 from Jonathan Druart--- Magnus, could you confirm you have correctly cleared your browser cache? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Magnus Engerchanged: What|Removed |Added Attachment #42999|0 |1 is obsolete|| --- Comment #10 from Magnus Enger --- Created attachment 43006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43006=edit Bug 14910: Redirect to the circulation module after a renew iIf a patron is renewed from the circulation module, the librarian should be redirected to the circulation module. This works correctly if the renew is done from the patron module (members). This is caused by a typo in the template: desintation vs destination. This patch also removes the cardnumber parameter to the setstatus.pl script, it is not needed given that borrowernumber is always passed. This has a good side-effect, it will fix bug 14691. The cardnumber does not exist anymore, so no need to escape it :) Test plan: 0/ Do not apply this patch 1/ Create a patron with a cardnumber with a quote (rm'me) and another one without a quote (rmme) 2/ Go on the checkouts page (circ/circulation.pl) 3/ Renew the 2 patrons => With rm'me you are redirected to the circ module - ok => With rmme you are redirected to the member module - nok 4/ Go on the patron detail page (members/moremember.pl) 5/ Renew the 2 patrons => you are redirected to the member module - ok 6/ Delete the patrons => Nothing happend with rm'me, there is a JS error on the page - nok => rmme is deleted - ok 7/ Apply the patch and recreate rmme 8/ Repeat 2, 3, 4, 5 => You are redirected to the correct module 9/ Delete the patrons => They are successfully deleted Signed-off-by: Magnus Enger Followed the test plan, works as advertised. (I did have some problems initially, but that was caused by me not using the interface in English...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druartchanged: What|Removed |Added Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Magnus Engerchanged: What|Removed |Added Patch complexity|--- |Small patch Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 --- Comment #7 from Colin Campbell--- (In reply to Magnus Enger from comment #5) > Colin: What do you think of the proposal from Jonathan? > Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like > a good idea. (In reply to Jonathan Druart from comment #6) > (In reply to Magnus Enger from comment #5) > > Colin: What do you think of the proposal from Jonathan? > > Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like > > a good idea. > > No, I would like to keep my QA token. Its not really a transaction method but a utility but will attempt to test that solution -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Barton, to be consistent we should display the biblioitems fields when creating/editing a letter from the "reserves" module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14935] waiting and in transit items cannot be reserved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935 Koha Team Lyon 3changed: What|Removed |Added CC||nahuel.angelinetti@biblibre ||.com --- Comment #1 from Koha Team Lyon 3 --- *** Bug 4319 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14935] waiting and in transit items cannot be reserved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935 Koha Team Lyon 3changed: What|Removed |Added CC||anthony.laque...@ccsr.qc.ca ||, ch...@bigballofwax.co.nz, ||fridolin.som...@biblibre.co ||m, ||je...@bywatersolutions.com, ||katrin.fisc...@bsz-bw.de, ||koha-b...@lists.koha-commun ||ity.org, ||k...@univ-lyon3.fr, ||marjorie.barry-v...@ccsr.qc ||.ca, neng...@gmail.com, ||susanne.jer...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Colin Campbellchanged: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #9 from Colin Campbell --- Revised patch to inherit method from base class - works for me with Checkin and Renewal requests - please test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14929] Fix missing display of help page in contract management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14900] Add ability to pay all fees at once from circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14900] Add ability to pay all fees at once from circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900 Jonathan Druartchanged: What|Removed |Added Attachment #42893|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 43011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43011=edit Bug 14900: Add ability to pay all fees at once from circulation screen Test plan: 1) Go to circulation screen for patron which has some not-payed charges (or make same if needed) 2) You should see infromation about fees and charges with ability to pay it. Note there is new link for paying all charges at once 3) Try the new link, you should be redirected to members/paycollect.pl, check if there is right amount and try to pay charges 4) try the old link to make sure it works still well after this patch Works as expected. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard coded record length limit of 99999 bytes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11399 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #6 from Marc Véron--- Ok, I can make it explode if I enter -00-00 for date of birth: --- Can't locate object method "ymd" via package "dateformat" (perhaps you forgot to load "dateformat"?) at /usr/share/kohaclone/Koha/DateUtils.pm line 206. --- I think we need a generic function in Koha::DateUtils to test a date string against the 'dateformat' syspref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 --- Comment #6 from Jonathan Druart--- Last patch just removes +use C4::Members::Messaging; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Jonathan Druartchanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |frede...@tamil.fr |ity.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14900] Add ability to pay all fees at once from circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14898] After adding manual invoice redirect to pay tab instead of account tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14898 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |ASSIGNED --- Comment #7 from Jonathan Druart --- Marc's suggestion sounds like a good compromise :) Josef, do you agree? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11399] batch rebuild items tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399 Jonathan Druartchanged: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14858 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard coded record length limit of 99999 bytes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858 --- Comment #6 from Jonathan Druart--- Thanks for the test plan Nick! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14935] New: waiting and in transit items cannot be reserved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935 Bug ID: 14935 Summary: waiting and in transit items cannot be reserved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: k...@univ-lyon3.fr QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com There's an issue with the possibility to place a hold on items waiting to be pick-up or in transit when you choose that on shelf holds are not allowed. In this case, items are not checked-out so there are considered to be available. But, they aren't, they are not on a shelf ready to be chosen by a patron but stored aside. So, other patrons should place a hold on it as they couldn't go on shelves to take it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4319] waiting items cannot be reserved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Koha Team Lyon 3changed: What|Removed |Added Resolution|--- |DUPLICATE Status|REOPENED|RESOLVED --- Comment #25 from Koha Team Lyon 3 --- *** This bug has been marked as a duplicate of bug 14935 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14929] Fix missing display of help page in contract management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Jonathan Druartchanged: What|Removed |Added Attachment #42998|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 43010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43010=edit Bug 14929 - Fix missing display of help page in contract management This patch renames / moves the file koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/acqcontract.tt to koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqcontract.tt To test: - Go to Home > Acquisition > [Vendor] > Contracts (/cgi-bin/koha/admin/aqcontract.pl?booksellerid=) - Verify that Help displays as appropriate. Signed-off-by: Magnus Enger Works as advertised. All the tabs similar to "Contracts" have working help pages. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard coded record length limit of 99999 bytes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14858] misc/batchRebuildItemsTables.pl has hard coded record length limit of 99999 bytes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14858 Jonathan Druartchanged: What|Removed |Added Attachment #42942|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 43013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43013=edit Bug 14858: removed record length limit test Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Zeno Tajolichanged: What|Removed |Added CC|z.taj...@cineca.it | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 --- Comment #5 from Jonathan Druart--- Comment on attachment 42978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42978 [SIGNED-OFF] Bug 14504: Add delete_items.pl: a command line batch deletion tool Review of attachment 42978: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14504=42978) - FAIL misc/cronjobs/delete_items.pl FAIL pod *** WARNING: Verbatim paragraph in NAME section in file misc/cronjobs/delete_items.pl ::: misc/cronjobs/delete_items.pl @@ +1,4 @@ > +#! /usr/bin/perl > + > +use warnings; > +use strict; warnings and strict are useless when Modern::Perl is already used. @@ +8,5 @@ > +use C4::Circulation; > +use Modern::Perl; > +use Pod::Usage; > + > +my $VERSION='1.0'; How this is useful? We usually don't use it in scripts. @@ +30,5 @@ > + , help => '' > + , manual=> '' > + , version => '' > + } > +}; I am not really in favor of these 2 variables. IMO it is preferable to stick to the structure of the already existing scripts in misc/* @@ +39,5 @@ > +, 'V|version' => sub { $OPTIONS->{flags}->{version} = 1 } > +, 'h|help' => sub { $OPTIONS->{flags}->{help} = 1 } > +, 'm|manual' => sub { $OPTIONS->{flags}->{manual}= 1 } > +, 'c|commit' => sub { $OPTIONS->{flags}->{commit}= 1 } # aka > DO-EET! > +, 'dry-run'=> sub { $OPTIONS->{flags}->{commit}= 0; I don't think dry-run is useful, it's in dry-run mode if commit is not given. @@ +51,5 @@ > +exit; > +} > + > +pod2usage( -verbose => 2 ) if $OPTIONS->{flags}->{manual}; > +pod2usage(1) if ( $OPTIONS->{flags}->{help} || scalar @criteria == 0 ); The script should not return 1 if help is specified. It would be good to display on error for the @criteria==0 case (see msg option of pod2usage). @@ +65,5 @@ > +my $where_clause = ' where ' . join ( " and ", @criteria ); > + > +verbose "Where statement: $where_clause"; > + > +$GLOBAL->{sth}->{target_tiems} = $dbh->prepare( $query->{target_items} . > $where_clause ); typo tiems vs items, I suppose. @@ +71,5 @@ > + > +DELITEM: while ( my $item = > $GLOBAL->{sth}->{target_tiems}->fetchrow_hashref() ) { > +my $issue = GetOpenIssue( $item->{itemnumber} ); > +if( defined $issue ) { > +verbose "Cannot delete '$item->{itemnumber}' -- item is checked out." Shouldn't we also search for holds? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14934] Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934 --- Comment #1 from bondiurbano--- Created attachment 43012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43012=edit Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. Fines view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Colin Campbellchanged: What|Removed |Added Attachment #42355|0 |1 is obsolete|| --- Comment #8 from Colin Campbell --- Created attachment 43014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43014=edit Revised patch Revised to remove duplication of method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Jonathan Druartchanged: What|Removed |Added Attachment #42974|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 43009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43009=edit Bug 14927 Returns item info when resumptionToken is used To test: - activate OAI-PMH with the inclusion of items as explained on bug 12252 - set the OAI-PMH:MaxCount to a low number, 50 for instance - go to the OAI-PMH page to get the records : [your koha catalogue]/cgi-bin/koha/oai.pl?verb=ListRecords=marcxml - check that item data is included - get the resumptionToken at the end of the xml - got to the next page of records [your koha catalogue]/cgi-bin/koha/oai.pl?verb=ListRecords=[your resumption token] - check that item data is now missing Apply the patch, and repeat previous steps: item data is back. Signed-off-by: Gaetan Boisson Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Mauricechanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Mauricechanged: What|Removed |Added Blocks||11139 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 [Bug 11139] opac-topissues does not work with CCODE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Mauricechanged: What|Removed |Added Depends on||14788 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 [Bug 14788] Move opac-topissues.pl code into C4::Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Mauricechanged: What|Removed |Added Attachment #25956|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Mauricechanged: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #11 from Julian Maurice --- Bug 14788 fixes the ccode problem, but not the "multiple values" problem. So here is a patch that try to fix it (depends on 14788): -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #12 from Julian Maurice--- Created attachment 43008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43008=edit Bug 11139: Add support for multiple values in AdvancedSearchTypes AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl have to support that. AdvancedSearchTypes can have one or more of the following values: 'itemtypes', 'ccode', 'loc'. But this patch adds support only for itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it will change nothing to the behaviour of opac-topissues.pl. This patch also removes duplicate code in template (the "Refine your search" form was written in two different places) This introduces a small behaviour change: when there is no results, instead of having the form in the center of the page, it remains in the left sidebar and we have a "No results" message in the main area. Depends on bug 14788 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14934] New: Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934 Bug ID: 14934 Summary: Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cost...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com It would be very helpful to add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. Thus, it will be possible to print the barcode in the fine invoice. Please see PDF attached -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14888] Move the cities related code to Koha::Cities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14888 Jonathan Druartchanged: What|Removed |Added Attachment #42853|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 43015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43015=edit Bug 14888: Add Koha::Cit[y|ies] classes Tested both patches together, works as expected Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 Zeno Tajolichanged: What|Removed |Added CC|z.taj...@cineca.it | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaverchanged: What|Removed |Added Attachment #42253|0 |1 is obsolete|| --- Comment #8 from Jesse Weaver --- Created attachment 43018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43018=edit Bug 14607: (QA followup) Fix typo in shelfbrowser.inc Signed-off-by: Alexis Rodegerdts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc Véronchanged: What|Removed |Added Blocks||14924 Patch complexity|--- |Small patch Assignee|gmcha...@gmail.com |ve...@veron.ch Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 [Bug 14924] Remove C4::Dates from members/memberentry.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Kyle M Hallchanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14934] Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934 bondiurbanochanged: What|Removed |Added Attachment #43012|0 |1 is obsolete|| --- Comment #2 from bondiurbano --- Created attachment 43016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43016=edit Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab. Fines view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #125 from Charles Farmer--- Created attachment 43017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43017=edit Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t This is a collection of changes taken from different comments (but mostly comment 21 and comment 122). Passes qa and prove, on my machine at least. There's also a new test file, Passwordrecovery.t, which covers every method of C4::Passwordrecovery. To test: All normal checks plus : 1/ Receive the email 2/ Click on the link 3/ Change the pwd 4/ Click again on the link 5/ You should immediately get an error message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmerchanged: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 --- Comment #1 from Marc Véron--- Created attachment 43020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43020=edit Bug 14936 - Add validation for date strings to Koha::DateUtils To test: - Apply patch - prove t/DateUtils.t Bonus test: Apply patch(es) from Bug(s) that are blocked by this Bug and test as appropriate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 Héctor Eduardo Castro Avaloschanged: What|Removed |Added CC||hector.hecax...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11039] SIP Server responds with valid CHECKIN to SC but fails to checkin item on Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039 Katrin Fischerchanged: What|Removed |Added CC||ulrich.klei...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14937] Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Kyle M Hallchanged: What|Removed |Added Severity|enhancement |minor Assignee|koha-b...@lists.koha-commun |kyle.m.h...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144 --- Comment #33 from Jonathan Druart--- Kyle, I don't understand how the changes you introduced in the tests for AddReserve highlight your changes in the subroutine. It would be better to first submit a patch to fix the issue then to clean some stuffs (indentation, replacement with Koha::Objects, etc.) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14936] New: Add validation for date strings to Koha::DateUtils
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Bug ID: 14936 Summary: Add validation for date strings to Koha::DateUtils Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: ve...@veron.ch QA Contact: testo...@bugs.koha-community.org Patch to add a generic function in Koha::DateUtils to test a date string against the 'dateformat' syspref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Attachment #42968|0 |1 is obsolete|| --- Comment #4 from Héctor Eduardo Castro Avalos --- Created attachment 43022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43022=edit [SIGNED-OFF]Bug 14917 - RDA: 700/710/711 fix path for icon in XSLT. Added theme and materialTypeLabel parameters back into showAuthor template call for 7xx display in OPAC display. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 5) Click title to review record details. 6) Link to icon following contributor names should appear. Signed-off-by: Hector Castro Works as expected. Magnifying glass icon corrected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Kyle M Hallchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14937] New: Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14937 Bug ID: 14937 Summary: Expiration date for holds based onReservesMaxPickUpDelay should not require ExpireReservesMaxPickUpDelay Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kyle.m.h...@gmail.com QA Contact: testo...@bugs.koha-community.org C4::Letters::_parseletter will replace reserves.expirationdate with the date a hold will be marked as problematic ( holds over ) if both ReservesMaxPickUpDelay and ExpireReservesMaxPickUpDelay are enabled. There is no reason this feature needs to rely on ExpireReservesMaxPickUpDelay as there are many libraries that would like to send the last day to pick up a hold in notices, but would rather deal with the expired waiting holds manually rather than have Koha cancel them automatically. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Attachment #43022|0 |1 is obsolete|| --- Comment #5 from Héctor Eduardo Castro Avalos --- Created attachment 43023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43023=edit [SIGNED-OFF]Bug 14917 - RDA: 700/710/711 fix path for icon in XSLT. Added theme and materialTypeLabel parameters back into showAuthor template call for 7xx display in OPAC display. Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 5) Click title to review record details. 6) Link to icon following contributor names should appear. Signed-off-by: Hector Castro Works as expected. Magnifying glass icon corrected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #7 from Jonathan Druart--- You can try with: 32/01/1970 Actually it will explode if the date is not correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Marc Véronchanged: What|Removed |Added Depends on||14936 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 [Bug 14936] Add validation for date strings to Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaverchanged: What|Removed |Added Attachment #42547|0 |1 is obsolete|| --- Comment #9 from Jesse Weaver --- Created attachment 43019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43019=edit Bug 14607: (QA followup) Fix one missing occurence, incorrect calls to GetNormalizedUPC Signed-off-by: Alexis Rodegerdts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaverchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/