[Koha-bugs] [Bug 15018] Plack testing -- Adding Items Display - Home Library/Current Location columns missing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018

--- Comment #3 from Heather Braum  ---
I just relooked at this particular one and either when I first tested, I didn't
realize that future releases change homelibrary to permanent location and/or
the items I originally added didn't have current location/permanent locations
yet. It works me now, too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

--- Comment #12 from Olli-Antti Kivilahti  ---
(In reply to Kyle M Hall from comment #6)
> Thanks Olli! I do like your version ( except for the odd default value ; ).
Heh, you should see the odd default values in acquisitions.module.
(if don't know what to do order, order one piece of this Biblio)

> However it does break from the standard way of doing things in
> cleanup_database.
Erm... The cleanup_database is from the 1990's based on the programming
patterns. Why do you need to follow such a standard? Is it too much to ask to
expose business logic inside the core API rather than access DB directly from
the Controller/script?
This is the root of many issues in Koha and we need to break that crappy cycle
of untestable/automatable features.

> That being said, if you *were* to add a unit test I'd say
> that would be a worthwhile improvement and I'd be more than happy to
> deprecate my version and sign off on yours!

Well now nobody can test it, unless they refactor the feature by moving the
business logic inside the API.
This modification would need to pass yet another community process.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43694|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #30217|0   |1
is obsolete||
  Attachment #40702|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 43697
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43697=edit
Bug 12194 - add more tests for pdf creation

When run with KEEP_PDF enviroment variable it will keep
test.pdf for manual inspection. This can be used to verify
that ttf font configuration is complete like:

KEEP_PDF=1 KOHA_CONF=/etc/koha/sites/srvgit/koha-conf.xml prove t/Creators.t

sample of utf-8 text, font name and type will be on bottom of second page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

--- Comment #9 from Jonathan Druart  
---
Created attachment 43698
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43698=edit
Bug 12194: Add option 'Oblique title' in labels

This patch adds a checkbox on Label creator
to use or not an oblique variant of main font
for title

Also fix font selection for title in case an
oblique variant is used.

To test:
Before patch
1) Go to Tools > Label creator
2) Create a new layout, default values but select
any 'Oblique' variant for main font and
'Biblio/Barcode' for layout type
3) Go to Manage batches, create a batch, add items,
export PDF, download
4) Check logs, you must find a line with
'ERROR in koha-conf.xml -- missing '
for example if main font Courier-Oblique

5) Open PDF, title could be right but not using selected font

After patch
6) Apply the patch
7) Run updatedatabase.pl
8) Repeat 1-2, note new checkbox 'Oblique title',
default checked
9) Repeat export, no new warnings on log
10) Create a new layout or edit an existent one,
uncheck 'Oblique title', save, export again
Check PDF has non slanted title

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #10 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #9)
> (In reply to Tomás Cohen Arazi from comment #8)
> > Jonathan, you are so lazy :-P
> 
> Indeed, I am a developer, I have to be lazy!

Feature, not a bug!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12769] Notice fee management

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12769

--- Comment #35 from Gaetan Boisson  ---
---Short Version---
 Do we want to be able to charge users on arbitrary notifications, and if we
do, are we willing to provide users with a design that will require maintaining
all the different variants of the notifications?

---Long Prose---
 I went and read the RFC mentioned at the top of this thread first, which seems
to be where the initial requirement was expressed. Bug 14666 is obviously
trying to achieve something quite similar.

I see two possibilities:

- The requirement is to charge on notifications for late documents, something
that indeed cannot be done in Koha right now. That is my understanding of the
RFC actually, but I didn't write it, and I don't know the sponsor;). I have had
libraries asking me how to have a one time charge when patrons have late
documents. Koha makes some complicated calculations regarding each document and
the number of days late, according to the circulation matrix, which definitely
doesn't fit everyone's needs, and which will generate odd amounts for fines. My
point is that there clearly is a need to be able to charge a simple one time
amount to patrons with late documents.
 If this is the only scenario for the requirement, then I think adding this
possibility at the notification level is a bad idea. It makes it difficult to
charge different amounts for different patron categories or different libraries
since you will have to edit different notifications for these, I find the
"notices and slips" tool quite complicated already, while the "overdue status
trigger" tool is very clear. It also makes it possible to charge for
notifications for which I cannot see the need, like PREDUE. There are other
notifications for which I think "fair enough, why not", like "hold available
for pick up", but frankly none of them make as much sense to me as the overdue
notices (and I don't see myself needing this anytime soon).


- But maybe that is precisely the requirement, to be able to charge users on
arbitrary notifications and not just for late items.
 If this is the case then in the current design libraries who want to manage
different fine amounts for different patron categories / libraries combinations
for overdue notices will have to deal with having a really long list of
notifications to maintain, since they will have one for each combination of
patron category / library for which the amount is different. If the wording has
to change in the notification, all of them will need to be edited. This adds up
with the different notifications for each stage (1st reminder, 2nd reminder,
etc.), so it will be a lot of lines in the tool.

 So I would say the question is: do we want to be able to charge users on
arbitrary notifications, and if we do, are we willing to provide users with a
design that will require maintaining all the different variants of the
notifications?

 The BibLibre development (bug 14666) is not about charging for arbitrary
notifications. You have my opinion on the above question ;) InLibro and the
Halland County Library should give their input and we'll see how to move
forward!

(Although I work for BibLibre, I am not in charge of the development on bug
14666. So if the answer is that the need is to send notifications for arbitrary
notifications, I will not block the proposed functionality: it is possible to
achieve our needs with it. I just think the interface is going to make it
painful. I will ask Stéphane Delaye to give his opinion here though.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43693|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43608|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15045] New: URLs should be built using PATH_INFO and SCRIPT_NAME

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15045

Bug ID: 15045
   Summary: URLs should be built using PATH_INFO and SCRIPT_NAME
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Currently, Koha has different ways of building the URI path when rendering
links. Some of them are hardcoded, some rely on $cgi->url.

We need to calculate them correctly to support arbitrary places to put Koha's
intefaces in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14134] Make "Holds over" show holds expiring tomorrow if ExpireReservesMaxPickUpDelay is set

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14134

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039

--- Comment #4 from Marc Véron  ---
(In reply to Jonathan Druart from comment #3)
> Marc, why didn't you use the include into includes/opac-bottom.inc? (I
> didn't check line by line if it was the same piece of code)

Jonathan, because the language switcher in the bottomline is different to the
language switcher in the header.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10363] There is no package for authorised values.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

--- Comment #100 from Jonathan Druart  
---
Created attachment 43696
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43696=edit
Bug 10363: Fix tests

The delete op is now "delete" and the confirmation is a JS dialog box.

Note that now this patch removes the categories the tests will add (to
avoid error on inserting duplicate).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15018] Plack testing -- Adding Items Display - Home Library/Current Location columns missing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018

Josef Moravec  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME
 CC||josef.mora...@gmail.com

--- Comment #2 from Josef Moravec  ---
I can't reproduce it on the test server as well, so I'm closing with WORKSFORME
status. 

Heather, if you have more information on it, please reopen. Maybe i just
misunderstood the problem...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15019] Plack testing - Umbrella

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019
Bug 15019 depends on bug 15018, which changed state.

Bug 15018 Summary: Plack testing -- Adding Items Display - Home Library/Current 
Location columns missing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15046] New: Possibility to see last borrower when an item lost is returned

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15046

Bug ID: 15046
   Summary: Possibility to see last borrower when an item lost is
returned
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Hi,

When an item is marked lost, it is returned in the same time. 
If item is finaly checked in, we see a checkin message "Item was lost, now
found.". It will be great to see in this message a link to the last borrower.


Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43609|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15044] New: add suggestion's date on Your purchase suggestions tab in OPAC

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15044

Bug ID: 15044
   Summary: add suggestion's date on Your purchase suggestions tab
in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org

Hi,

In OPAC, it would be nice to see the date on which the suggestion was sent, as
it appears in intranet in column Suggested by - on and in column Managed by -
on.

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #12 from Jonathan Druart  
---
I think an even better solution would be to do the job in a transaction and
rollback if the commit flag is not there.

So it would be something like:

start transaction
foreach items:
  is_deleted = DelItemCheck
  display error unless is_deleted
if commit flag:
  commit
else:
  rollback

What do you think about that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15043] Bottom table header row for circulation rules missing a column

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15043

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from Jonathan Druart  
---
commit e8232522a92b47090d651ea8cf6a92aa463454fb
Bug 14045: Add missing th in tfoot

fixes the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

--- Comment #13 from Olli-Antti Kivilahti  ---
I could still fail QA due to missing tests.
But back then nobody wrote test, so according to the spirit of
cleanup_database.pl this behaviour is acceptable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

--- Comment #30 from Jonathan Druart  
---
tested again, without plack, and got exactly the same difference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13589] add --mark-returned as a longoverdue sys pref

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14248] Optionally display authorship for news items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #15 from Katrin Fischer  ---
Mark, thx for clearing this up - I see now how the 3 patches go together. I
think all we are missing is the tests asked for on this bug report.

Martin - small steps are great - this just went a little too far :) It would
have been ok to do the database changes and the feature in one go in this case,
as this is a nice contained feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14154] 608$9 defined twice in UNIMARC biblio-koha-indexdefs.xml

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14154

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Frido!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15045] URLs should be built using PATH_INFO and SCRIPT_NAME

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15045

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15005

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

Tomás Cohen Arazi  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15045

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14900] Add ability to pay all fees at once from circulation screen

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Josef!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039

Chris Kirby  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039

Chris Kirby  changed:

   What|Removed |Added

 CC||christopherlawrencekirby@gm
   ||ail.com

--- Comment #5 from Chris Kirby  ---
Comment on attachment 43653
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43653
Bug 15039 - Move top language menu to include and streamline logic

Signed off on patch.

Applied patch 

- Verified, that the language menu displays / does not display with
combinations of:
  - opaclanguagedisplay (Allow)
  - opaclanguages ( > 1 language selected)
  - OpacLangSelectorMode (top or both)
- Verified that sysprefs opacuserlogin and EnableOpacSearchHistory did not
interfere: 
  with the lenguage menu (before, at least one of them had to be on to display
the menu)
- Verified that language switching works as before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871

--- Comment #9 from Tomás Cohen Arazi  ---
This is only restoring previous behaviour actually. I'm not sure why we
reverted it. But assuming that matching the first firstname/surname is a good
relevance algorithm falls short I think.

We should definitely consider moving this into fulltext search engines, because
after all, using LIKEs is so inefficient... and those tools take care of this
things so well...

I'm not saying Zebra, we can put it on hold until ES is here, but we should
thing ASAP of a better way of doing this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #34 from Jonathan Druart  
---
Kyle, comment 28 is not fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #14 from Jonathan Druart  
---
Ok, removing my signoff, obsoleting patches.
Please (someone) move the sql to a pm and write tests.

Marked as Failed QA.

(Everybody's happy?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15041] Plack testing -- Batch Item Modification Issues

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15041

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Josef Moravec  ---


*** This bug has been marked as a duplicate of bug 15021 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15019] Plack testing - Umbrella

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019
Bug 15019 depends on bug 15041, which changed state.

Bug 15041 Summary: Plack testing -- Batch Item Modification Issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15041

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

--- Comment #10 from Jonathan Druart  
---
Patches rebased, conflicts with bug 14602 fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

--- Comment #11 from Marc Véron  ---
To make it work, I had to

- update the database (obvious, but not in test plan)

- copy the font definitions from etc/koha-conf.xml to my own koha-conf.xml

- then I had a lot of warnings like "ERROR in koha-conf.xml -- missing /path/to/font.ttf", they vanished after applying Bug 14468 -
Remove warnings when creating Labels

Idea for a separate bug: On the About page > System warnings we have a section
about errors in koha-conf.xml, we could add there a sanity check for font
definitions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

Marc Véron  changed:

   What|Removed |Added

  Attachment #43697|0   |1
is obsolete||

--- Comment #12 from Marc Véron  ---
Created attachment 43699
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43699=edit
Bug 12194 - add more tests for pdf creation

When run with KEEP_PDF enviroment variable it will keep
test.pdf for manual inspection. This can be used to verify
that ttf font configuration is complete like:

KEEP_PDF=1 KOHA_CONF=/etc/koha/sites/srvgit/koha-conf.xml prove t/Creators.t

sample of utf-8 text, font name and type will be on bottom of second page

Followed test plan, works as expected. (See comment#11)
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

Marc Véron  changed:

   What|Removed |Added

  Attachment #43698|0   |1
is obsolete||

--- Comment #13 from Marc Véron  ---
Created attachment 43700
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43700=edit
Bug 12194: Add option 'Oblique title' in labels

This patch adds a checkbox on Label creator
to use or not an oblique variant of main font
for title

Also fix font selection for title in case an
oblique variant is used.

To test:
Before patch
1) Go to Tools > Label creator
2) Create a new layout, default values but select
any 'Oblique' variant for main font and
'Biblio/Barcode' for layout type
3) Go to Manage batches, create a batch, add items,
export PDF, download
4) Check logs, you must find a line with
'ERROR in koha-conf.xml -- missing '
for example if main font Courier-Oblique

5) Open PDF, title could be right but not using selected font

After patch
6) Apply the patch
7) Run updatedatabase.pl
8) Repeat 1-2, note new checkbox 'Oblique title',
default checked
9) Repeat export, no new warnings on log
10) Create a new layout or edit an existent one,
uncheck 'Oblique title', save, export again
Check PDF has non slanted title

Followed test plan, works as expected. (See comment #11).
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

--- Comment #2 from Blou  ---
Created attachment 43701
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43701=edit
Bug 15030 - Fixes the serials fields associated with a plugin, to not overwrite
the previously saved value

This fixes the remaining fields from serials-edit.pl that were seeing their
previously entered values
be oblitarated with each new edit.  The fields associated to a plugin
(dateaccessioned and barcode) were
always displaying  with each new edit, losing the previous effort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14486] C4/Accountlines.pm needs better documentation and removal of stale code

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14486

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12194

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14486

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15045] URLs should be built using PATH_INFO and SCRIPT_NAME

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15045

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15037] Batch checkout tab should be hidden for patrons not satisfying policy

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15037

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #43692|0   |1
is obsolete||

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 43702
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43702=edit
Bug 15037: Correctly check the patron categories on displaying the Batch
checkout tab

When checking for the patron categories allowed to use the batch
checkout, the comparison should be strict (eq).

Test plan:
0/ Do not apply this patch
1/ Create 2 patron categories ST and S
2/ Enable BatchCheckouts and define BatchCheckoutsValidCategories = S
3/ Create 2 patrons, 1 in the ST category and the other one in S
4/ On the patron detail page, you should see the "batch checkout" tab
for both patron
5/ Apply this patch
6/ The tab should only be displayed for the patron S

Signed-off-by: Tomas Cohen Arazi 
Tested using an 'S' patron and allowing 'ST' patrons only, worked as expected.
Also tried setting =1 to force it to show the batch page, and it says
I'm not allowed to do batch checkouts for that patron. Great!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

--- Comment #50 from Katrin Fischer  ---
Is this something to worry about?

$ perl t/db_dependent/Circulation/CalcFine.t
1..2
DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489.
# Subtest: Test basic functionality
1..1
ok 1 - Amount is calculated correctly
ok 1 - Test basic functionality
# Subtest: Test cap_fine_to_replacement_price
1..1
ok 1 - Amount is calculated correctly
ok 2 - Test cap_fine_to_replacement_price
DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not
match false AutoCommit of DBI::db=HASH(0x432c8c0), attempting ROLLBACK anyway
at /home/katrin/kohaclone/t/lib/TestBuilder.pm line 363

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43620|0   |1
is obsolete||

--- Comment #162 from Nick Clemens  ---
Created attachment 43709
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43709=edit
Bug 11559: (followup) Fix error when all servers are deselected

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43616|0   |1
is obsolete||

--- Comment #158 from Nick Clemens  ---
Created attachment 43705
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43705=edit
Bug 11559: Rancor: advanced cataloging interface

Full test plan is posted on bug. Test plan for system preference:

  1. Apply patch, clear cookies.
  2. Go to "Cataloging."
  3. Add new record, verify that basic editor is used.
  4. Navigate to existing record, click on "Edit record", verify that
 basic editor is used.
  5. Inside basic editor, verify that no button appears to switch to the
 advanced editor.
  6. Enable the "EnableAdvancedCatalogingEditor" syspref.
  7. Repeat above steps, should still go to basic editor, but button
 should appear to switch to the advanced editor; click it.
  8. Now, adding new records and editing existing records should go to
 the advanced editor.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43618|0   |1
is obsolete||

--- Comment #160 from Nick Clemens  ---
Created attachment 43707
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43707=edit
Bug 11559: (followup) Fill in default values, fix redirect and UNIMARC

This fixes the following issues:
* Help for UNIMARC tags broken
* MARC21 resources loaded when in UNIMARC
* Clicking on "advanced editor" in basic editor fails
* Shift-Tab goes to the beginning of a fixed-field widget rather
  than the end

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43617|0   |1
is obsolete||

--- Comment #159 from Nick Clemens  ---
Created attachment 43706
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43706=edit
Bug 11559: (followup) Fix keyboard control bugs, make labels clickable

This fixes the following issues:
* Labels of search server checkboxes cannot be clicked
* Quick search fields cannot be focused
* Search results cannot be scrolled with a keyboard

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43621|0   |1
is obsolete||

--- Comment #163 from Nick Clemens  ---
Created attachment 43710
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43710=edit
Bug 11559: (followup) Prevent saving item tags, fix other issues

This fixes the following issues:
  * Spaces are now allowed in indicators
  * Shift-Enter is available to insert a newline if needed
  * Item tags, if present, will prevent saving (as they are not correctly
processed by the backend)
  * biblionumber tags (999 in MARC21) will be stripped before the record
is saved to Koha, to prevent their modification

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43615|0   |1
is obsolete||

--- Comment #157 from Nick Clemens  ---
Created attachment 43704
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43704=edit
Bug 11559: New libraries for Rancor

Adds the following JS libraries:

  * CodeMirror - extensible text editor
  * FileSaver - shim for saving files
  * require - dependency resolver and module loader

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43619|0   |1
is obsolete||

--- Comment #161 from Nick Clemens  ---
Created attachment 43708
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43708=edit
Bug 11559: (followup) Fix import bugs, display/parsing issues

This fixes the following issues:
  * ISO2709 import fails for Unicode
  * Import only works with .mrc/.xml extensions
  * MARC21 widgets not translatable
  * Macro UI broken
  * Uppercase subfield codes forbidden
  * Tag with no valid subfields shows as error but tries to save

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #45 from Katrin Fischer  ---
I retested, this still has issues for me :(

Trying again with a test plan, hoping someone can find out what's going on:
- Created a patron list "Delete" with 2 borrowers from the sample data:
  Nicole Schneider - has 1 checkout
  Keith Hendrix
- Chose Delete and checked the checkbox, no other changes
- Chose "mose to trash"
- Tool reports: 2 patrons have been successfully moved to trash
- Nicole Schneider now exists in both borrowers and deletedborrowers

The logs show:
[Thu Oct 22 00:47:50.410257 2015] [cgi:error] [pid 11589] [client
127.0.0.1:36610] AH01215: [Thu Oct 22 00:47:50 2015] cleanborrowers.pl:
DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign
key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY
(`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE)
at /home/katrin/kohaclone/C4/Members.pm line 1813., referer:
http://localhost:8080/cgi-bin/koha/tools/cleanborrowers.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #18 from Katrin Fischer  ---
This patch is needed to continue with 14247. Please sign-off asap!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43614|0   |1
is obsolete||

--- Comment #156 from Nick Clemens  ---
Created attachment 43703
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43703=edit
Bug 11559: Supporting changes for Rancor

* Extends login screen to pass along #hash
  * Adds JSONP support to C4::Service
  * Extends humanmsg to allow per-message classes
  * Adds proper charset to results of svc/bib

Test plan:

  1. C4/Auth.pm and .../intranet/.../auth.tt: verify that login/usage
 works as expected, despite the change to pass on the fragment (...#blah)
 from the URL.
  2. C4/Service.pm and humanmsg.js: verify that editing system
 preferences (the main user of these modules) works correctly despite
 updates.
  3. svc/bib: verify that records can be correctly downloaded with the
 change of character set. This can be done in a Firebug/Chrome Devtools
 console by running `$.get('/cgi-bin/koha/svc/bib/1')` and inspecting the
 results (possibly replacing 1 with a different valid biblionumber).

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43622|0   |1
is obsolete||

--- Comment #164 from Nick Clemens  ---
Created attachment 43711
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43711=edit
Bug 11559: (QA followup) switch to new delimiter, fix minor issues

This followup introduces a major change; instead of subfields starting
with '$', they now start with '‡'. The double-cross
character can be typed with Ctrl-D.

It also fixes the following:
  * Add UUID.pm dependency
  * Remove debugging call
  * Fix toLocaleFormat error reported by Nick Clemens
  * Ignore subfields that are marked as unrepeatable/mandatory AND
ignored (tab is -1)
  * Mention lack of support for UNIMARC/NORMARC fixed fields in system
preferences screen
  * Confirm when user creates new record and current record is modified
  * Perform better when importing gigantic record dump
  * Show "Edit" instead of "Import" and allow direct editing for local
catalog records in search screen
  * Add "Keyboard shortcuts" help button to toolbar

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nick Clemens  changed:

   What|Removed |Added

  Attachment #43623|0   |1
is obsolete||

--- Comment #165 from Nick Clemens  ---
Created attachment 43712
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43712=edit
Bug 11559: (followup) fix first-character deletion, small usability issues

This should fix the first-character deletion bug reported by Nick, and also:

  * Fix subfield deletion
  * Attempted fix for special keys on dropdowns
  * Allow deleting empty fields
  * Fix bug with composed characters

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #167 from Nick Clemens  ---
Created attachment 43713
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43713=edit
Record with composed character that breaks import into rancor

When importing all fields after 518 containing {uml} have mangled indicators
Could be another issue causing it, but that seemed to be the case

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #166 from Nick Clemens  ---
Have been testing this as much as possible, only small notes this pass:
-Composed characters behavior is better, but they still mess up indicators on
import
-Empty field at end doesn't delete with Ctrl+x, however, it does anywhere else
and backspace does delete it
-Ctrl+D doesn't add delimiter in macros (must use alt+0135)

Attaching a sample record to show breaking of indicators.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

--- Comment #19 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #18)
> This patch is needed to continue with 14247. Please sign-off asap!

Koha Dev folks... can we sign off without Koha::Schema::Result::Opacnews being
updated?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14512] Add support for AV field to Koha's SIP2 Server

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14512

Chris Rohde  changed:

   What|Removed |Added

 CC||cro...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

--- Comment #20 from Katrin Fischer  ---
Including a Schema changes is still optional I'd say, see:
http://wiki.koha-community.org/wiki/Database_updates
...if you _want_ to...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #51 from Katrin Fischer  ---
I thought it was problems with the Schema first and tried to regenerate, but
this shows a problem:

Dumping manual schema for Koha::Schema to directory ./ ...
DBIx::Class::Schema::Loader::make_schema_at(): Checksum mismatch in
'.//Koha/Schema/Result/Issuingrule.pm', the auto-generated part of the file has
been modified outside of this loader.  Aborting.
If you want to overwrite these modifications, set the 'overwrite_modifications'
loader option.

Can you please put the Schema changes into a separate patch? I think it didn't
like the merging when fixing the conflicts with the other bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
  Attachment #43539|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #23 from Katrin Fischer  ---
There is something wrong here - the 3 patches, even with the one I put back
lack the logic in the template/pl files for the display. 

bumblebee:~/kohaclone (14247-newsauthor) $ git diff --stat HEAD~3
 installer/data/mysql/atomicupdate/bug_14247-add_news_prefs.sql   |  2 ++
 installer/data/mysql/sysprefs.sql|  1 +
 koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/tools.pref | 10
++
 t/db_dependent/NewsChannels.t| 45
-
 4 files changed, 57 insertions(+), 1 deletion(-)

Also, the tests are not passing - I think because we are missing a dependency -
"newsauthor" or bug 14246. We need this to be signed off please asap and this
to be put in order.

bumblebee:~/kohaclone (14247-newsauthor) $ perl t/db_dependent/NewsChannels.t
1..11
ok 1 - use C4::NewsChannels;
# Category CAT1 not found, inserting
# Borrower BRWR1 not found, inserting
ok 2
ok 3 - Correctly failed on no parameter!
ok 4 - Successfully added the first dummy news item!
DBD::mysql::st execute failed: Unknown column 'borrowernumber' in 'field list'
at /home/katrin/kohaclone/C4/NewsChannels.pm line 69.
DBD::mysql::st execute failed: Unknown column 'borrowernumber' in 'field list'
at /home/katrin/kohaclone/C4/NewsChannels.pm line 69.
# Looks like you planned 11 tests but ran 4.
# Looks like your test exited with 255 just after 4.

Please check asap - feature slush is close!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217

Mason James  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216

Mason James  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217

Mason James  changed:

   What|Removed |Added

   See Also|http://bugs.koha-community. |
   |org/bugzilla3/show_bug.cgi? |
   |id=15012|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12120] Add --tempdir arg to rebuild_zebra.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12120

Mason James  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012

Mason James  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13217
 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217

Mason James  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15012

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15012] koha-shell raises " no job control in shell" error

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15012

Mason James  changed:

   What|Removed |Added

   See Also|http://bugs.koha-community. |
   |org/bugzilla3/show_bug.cgi? |
   |id=13217|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14248] Optionally display authorship for news items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248

M. Tompsett  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

--- Comment #10 from Jonathan Druart  
---
Created attachment 43694
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43694=edit
Bug 13409 [QA Followup] - Remove MySQLism

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43608|0   |1
is obsolete||
  Attachment #43609|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  
---
Created attachment 43693
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43693=edit
Bug 13409 - Add ability to purge old special holidays using cleanup_database.pl

Some libraries have expressed interested in being able to purge old
holidays from the database.

Test Plan:
1) Create some special holidays in the past
2) Use the new --holidays DAYS option to test deleting special holidays
3) Verify only special holidays past the given amount of days were deleted

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13409] Add ability to purge old special holidays using cleanup_database.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13409

--- Comment #11 from Jonathan Druart  
---
Created attachment 43695
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43695=edit
Bug 13409: Remove MySQLism - Replace DATE with CAST AS DATE

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15021] Batch item modification does not work correctly on plack

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15021

Josef Moravec  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

--- Comment #3 from Josef Moravec  ---
*** Bug 15041 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039

--- Comment #3 from Jonathan Druart  
---
Marc, why didn't you use the include into includes/opac-bottom.inc? (I didn't
check line by line if it was the same piece of code)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12363] Marking an item as lost in koha always returns it, but longoverdue.pl may not

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12363

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

--- Comment #21 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #20)
> Including a Schema changes is still optional I'd say, see:
> http://wiki.koha-community.org/wiki/Database_updates
> ...if you _want_ to...

I asked, because I discovered issues with AuthorisedValuesBranch and
MarcModificationTemplateAction and isnullable, when I tried the koha schema
building thing. Totally unrelated to this. Back to testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

Nick Clemens  changed:

   What|Removed |Added

  Attachment #39747|0   |1
is obsolete||

--- Comment #24 from Nick Clemens  ---
Created attachment 43716
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43716=edit
Bug 14246: Update NewsChannel tests

This commit adds the new 'borrowernumber' field to the existing
test framework to make it pass. It does not include new tests.

Sponsored-by: Halland County Library

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

Nick Clemens  changed:

   What|Removed |Added

  Attachment #40125|0   |1
is obsolete||

--- Comment #25 from Nick Clemens  ---
Created attachment 43717
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43717=edit
(fix) correct ALTER TABLE mysql syntax

Address bug 14246 comment 13 remark - correcting MySQL ALTER TABLE
syntax.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

Nick Clemens  changed:

   What|Removed |Added

  Attachment #39745|0   |1
is obsolete||

--- Comment #23 from Nick Clemens  ---
Created attachment 43715
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43715=edit
Bug 14246: Add borrowernumber, altered SQL

As suggested by kind reviewers, an AFTER statement was added to the atomic
upgrade script to ensure that the final field order is consistent is both
fresh and upgraded databases.

Also:
* UPDATE action changed to CASCADE to improve robustness.

Test plan:
* Apply first patch in this set.
* Apply this patch.
* Perform a database upgrade.
* Use mysql client to inspect field order.
  It should be identical to the kohastructure.sql order.

Sponsored-by: Halland County Library

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

Nick Clemens  changed:

   What|Removed |Added

  Attachment #39521|0   |1
is obsolete||

--- Comment #22 from Nick Clemens  ---
Created attachment 43714
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43714=edit
Bug 14246: Add borrowernumber to koha_news

This patch adds a new column to koha_news that links a
borrowernumber to each item. This allows Koha to display the
author for each entry which makes it suitable as a simple CMS.

Changes (from rejected patch):
* Added missing kohastructure.sql changes.
* Turned the atomic update file into a SQL file and changed name
  in accordance with wiki guidelines.
* Changed SQL syntax and naming to be consistent with existing code.
* Attached test plan to commit message.

Test plan:

* You need at least one news item, log in and add one from
  'Administration' -> 'Tools' -> 'News'.
* Apply the patch.
* Apply database upgrade (directly or indirectly).
* Go back to Staff interface and post a new news item.
* Use the mysql command line client to connect to the Koha installation's
database:
  mysql -u kohaadmin -p -D koha (change username and database to values
  appropiate for your system).
* Execute the following query: SELECT title, borrowernumber FROM opac_news;
* Inspect the results, the 'borrowernumber' column should be NULL for all news
items
  created before the patch was applied, and non-NULL for the new item created
AFTER
  the patch was applied.

Optional: Remove database changes via:
  ALTER TABLE opac_news DROP FOREIGN KEY borrowernumber_fk;
  ALTER TABLE opac_news DROP COLUMN borrowernumber;

Sponsored-By: Halland County Library

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

M. Tompsett  changed:

   What|Removed |Added

  Attachment #43715|0   |1
is obsolete||

--- Comment #28 from M. Tompsett  ---
Created attachment 43720
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43720=edit
Bug 14246: Add borrowernumber, altered SQL

As suggested by kind reviewers, an AFTER statement was added to the atomic
upgrade script to ensure that the final field order is consistent is both
fresh and upgraded databases.

Also:
* UPDATE action changed to CASCADE to improve robustness.

Test plan:
* Apply first patch in this set.
* Apply this patch.
* Perform a database upgrade.
* Use mysql client to inspect field order.
  It should be identical to the kohastructure.sql order.

Sponsored-by: Halland County Library

Signed-off-by: Nick Clemens 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

M. Tompsett  changed:

   What|Removed |Added

  Attachment #43717|0   |1
is obsolete||

--- Comment #30 from M. Tompsett  ---
Created attachment 43722
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43722=edit
(fix) correct ALTER TABLE mysql syntax

Address bug 14246 comment 13 remark - correcting MySQL ALTER TABLE
syntax.

Signed-off-by: Nick Clemens 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

--- Comment #25 from M. Tompsett  ---
Created attachment 43724
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43724=edit
Bug 14247: Add system preference for news display

Test plan:

* Apply dependant patch 14246 (if not done already).
* Apply current patch.
* Log into the Staff client, go to 'Administration' -> 'Global Preferences' ->
'Tools', a new section titled 'News' should appear with a single option named
'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only',
'Staff client only' and 'Both OPAC and staff client'. By default the value
should be 'Not at all' (to mimic existing behaviour, important!).
* Change the value to something different and save the changes.
* Use the mysql command line client to connect to the Koha database:
  $ mysql -u kohaadmin -p -D koha
* Enter the following query:
  SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay';
* Check to make sure that the 'value' column has changed to reflect the choice
you made in the above step.

Separate SQL testing (clean installation of Koha):
* Koha$ mysql -u root < create_koha_test_db.sql
* Koha$ mysql -u koha_test -D koha_test <
installer/data/mysql/kohastructure.sql
* Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql

Testing the update script works the same way:
* Koha$ echo "DELETE FROM systempreferences WHERE variable =
'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test
* Koha$ mysql -u koha_test -D koha_test <
installer/data/mysql/atomicupdate/add_news_prefs.sql

NOTE: Adds and allows changes, but no apparent change in OPAC.

Signed-off-by: Marc Véron 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

M. Tompsett  changed:

   What|Removed |Added

  Attachment #43543|0   |1
is obsolete||

--- Comment #26 from M. Tompsett  ---
Created attachment 43725
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43725=edit
Bug 14247: Rename sysprefs atomic update file

This trivial patch changes the name of the SQL update
file to match the guidelines on the wiki.

Sponsored-by: Halland County Library
Signed-off-by: Marc Véron 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

--- Comment #26 from M. Tompsett  ---
Created attachment 43718
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43718=edit
Bug 14246: Adding Koha::Schema::Result differences

Ran misc/devel/update_dbix_class_files.pl as shown on
wiki/Database_updates#updatedatabase.pl
However, only git added Borrower and Opacnews, since
those were the two affected by this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

M. Tompsett  changed:

   What|Removed |Added

  Attachment #43714|0   |1
is obsolete||

--- Comment #27 from M. Tompsett  ---
Created attachment 43719
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43719=edit
Bug 14246: Add borrowernumber to koha_news

This patch adds a new column to koha_news that links a
borrowernumber to each item. This allows Koha to display the
author for each entry which makes it suitable as a simple CMS.

Changes (from rejected patch):
* Added missing kohastructure.sql changes.
* Turned the atomic update file into a SQL file and changed name
  in accordance with wiki guidelines.
* Changed SQL syntax and naming to be consistent with existing code.
* Attached test plan to commit message.

Test plan:

* You need at least one news item, log in and add one from
  'Administration' -> 'Tools' -> 'News'.
* Apply the patch.
* Apply database upgrade (directly or indirectly).
* Go back to Staff interface and post a new news item.
* Use the mysql command line client to connect to the Koha installation's
database:
  mysql -u kohaadmin -p -D koha (change username and database to values
  appropiate for your system).
* Execute the following query: SELECT title, borrowernumber FROM opac_news;
* Inspect the results, the 'borrowernumber' column should be NULL for all news
items
  created before the patch was applied, and non-NULL for the new item created
AFTER
  the patch was applied.

Optional: Remove database changes via:
  ALTER TABLE opac_news DROP FOREIGN KEY borrowernumber_fk;
  ALTER TABLE opac_news DROP COLUMN borrowernumber;

Sponsored-By: Halland County Library

Signed-off-by: Nick Clemens 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246

M. Tompsett  changed:

   What|Removed |Added

  Attachment #43716|0   |1
is obsolete||

--- Comment #29 from M. Tompsett  ---
Created attachment 43721
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43721=edit
Bug 14246: Update NewsChannel tests

This commit adds the new 'borrowernumber' field to the existing
test framework to make it pass. It does not include new tests.

Sponsored-by: Halland County Library

Signed-off-by: Nick Clemens 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/