[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 --- Comment #14 from Marcel de Rooy --- Great, Hector. Marc: if you can your signoff again, I can QA again.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 --- Comment #63 from Martin Renvoize --- Nice work Nick! I will be eagerly looking at this, hopefully this afternoon. Thanks for putting in all the hard work, so glad you followed through. :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Frédéric Demians changed: What|Removed |Added Attachment #45971|0 |1 is obsolete|| --- Comment #154 from Frédéric Demians --- Created attachment 46514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46514&action=edit Bug 13642: (followup) OAI-DC checked by default in OPAC modal -Fixing default option checked for OAI-DC in OPAC modal -Move OPAC modal to opac-detail-sidebar.inc to display in MARC view and ISBD view This follow-up fix the QA comment in comment 149 Signed-off-by: Frédéric Demians Above issue fixed & usable also in MARC/ISBD view -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Frédéric Demians changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15541] Create additional normalizers for Record Matching Rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #2 from David Cook --- Of course, what I've said isn't 100% true. There's one more obstacle between C4::Matcher::get_matches and Zebra's normalized indexes. And that's C4::Search::SimpleSearch(), which uses the s/:/=/g regex before sending the query. While that's trivial for Zebra's CHR and ICU indexing for words and phrases, since they just strip out punctuation anyway, it's a problem for Zebra's URL Charmap, which doesn't normalize URLs. So you'll get a failed match in that case. So I think a pure match would have to be done without any normalization before the query gets to Zebra. That should be easy enough to implement in C4::Matcher when it uses C4::Search::SimpleSearch(). Because it's a simple search, it shouldn't be normalizing the query anyway. I'll just add a flag so that you can do an unnormalized search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15541] Create additional normalizers for Record Matching Rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 --- Comment #1 from David Cook --- Here's my latest findings: Input: "http://libris.kb.se/resource/bib/219553"; C4::Matcher::_normalize() = "HTTPLIBRISKBSERESOURCEBIB219553" Zebra CHR = "http libris kb se resource bib 219553" Zebra ICU = "http libriskbse resource bib 219553" It seems to me that the smartest thing to do is NOT to normalize with C4::Matcher::_normalize(), because we're probably going to get it wrong as we have above. Zebra indexes "http://libris.kb.se/resource/bib/219553"; as "http libris kb se resource bib 219553" (CHR Phrase) or as "http libriskbse resource bib 219553" (ICU Phrase) or as "http://libris.kb.se/resource/bib/219553"; (URL, which is a Charmap when using either CHR or ICU). If we query Zebra with "http://libris.kb.se/resource/bib/219553";, it will normalize the query the same way that it normalized "http://libris.kb.se/resource/bib/219553"; when it was originally indexing it, and we'll get a match. Of course, we can't necessarily stop using C4::Matcher::_normalize() as it's the default behaviour. Many people may count on that _normalize() without even knowing it... even if it's potentially working badly. I think what I want to do is create a new normalizer which does nothing, and call it "none" or "raw". That way, I'm passing to Zebra the same thing that it's seen before, and it will normalize it exactly the same way and the likelihood of an accurate match increases considerably. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15541] Create additional normalizers for Record Matching Rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What|Removed |Added Assignee|gmcha...@gmail.com |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 --- Comment #4 from David Cook --- Note that the above pertains to "phrases-icu.xml" specifically. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 --- Comment #3 from David Cook --- NOTE: The output I've provided in the above comments has come from a Koha using CHR indexing. ICU indexing has different output, but the same behaviour. Here's what I see with "format xml" and "elements zebra::index": http://libris.kb.se/resource/bib/219553 Here's what I see with "format xml" and "elements index": http://libris.kb.se/resource/bib/219553 http://libris.kb.se/resource/bib/219553 However, this output is misleading. That's basically just the output of "xsltproc biblio-zebra-indexdefs.xsl ". It's pre-normalization and thus essentially meaningless. --- Only advanced users will look at yaz-client though. That being said, there are functional differences between ICU and CHR. For instance, the following query will work in CHR but NOT in ICU: id-other,phr=http libris kb se resource bib 219553 Conversely, the following query will work in ICU but not in CHR: id-other,phr=http libriskbse resource bib 219553 That's because we've configured tokenization and normalization to work differently between the two schemes. Fun, right? ICU uses the "l" tokenize rule from http://www.indexdata.com/yaz/doc/yaz-icu.html. That means it tokenizes based on slashes, spaces, and maybe some other characters I haven't discovered yet. You can verify that with the following commands: echo "THIS IS A TEST" | yaz-icu -x -c ./etc/zebradb/etc/phrases-icu.xml echo "THIS/IS/A/TEST" | yaz-icu -x -c ./etc/zebradb/etc/phrases-icu.xml Indeed, check out the following yaz-client output when using ICU: Z> f id-other,phr=http://libris.kb.se/resource/bib/219553 Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 12, setno 17 SearchResult-1: term=http cnt=12, term=libriskbse cnt=12, term=resource cnt=12, term=bib cnt=12, term=219553 cnt=12 records returned: 0 Elapsed: 0.001458 You can see the URL has been broken into 5 terms/tokens with ICU, while CHR does the following: Z> f id-other,phr=http://libris.kb.se/resource/bib/219553 Sent searchRequest. Received SearchResponse. Search was a success. Number of hits: 12, setno 13 SearchResult-1: term=http cnt=12, term=libris cnt=12, term=kb cnt=12, term=se cnt=12, term=resource cnt=12, term=bib cnt=12, term=219553 cnt=12 records returned: 0 Elapsed: 0.001119 We actually have 7 terms/tokens in the case of CHR! And that means that we don't want to try to outsmart Zebra by pre-normalizing our queries. We want to query Zebra with the exact same data that it indexed, because that way the normalization will be the same! Science! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #8 from David Cook --- ADDITIONAL TESTING NOTE: Here's the steps you need to do to upgrade your Koha's Zebra config, if you're using a git dev install: cd /home/dcook/git INSTALL_LOG="/home/dcook/koha-dev/misc/koha-install-log" cp $INSTALL_LOG backup-koha-install-log perl Makefile.PL --prev-install-log "$INSTALL_LOG" make make upgrade -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 --- Comment #2 from David Cook --- Advanced testers: Here's the steps you need to do to upgrade your Koha's Zebra config, if you're using a git dev install: cd /home/dcook/git INSTALL_LOG="/home/dcook/koha-dev/misc/koha-install-log" cp $INSTALL_LOG backup-koha-install-log perl Makefile.PL --prev-install-log "$INSTALL_LOG" make make upgrade -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #45432|0 |1 is obsolete|| --- Comment #13 from Héctor Eduardo Castro Avalos --- Created attachment 46513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46513&action=edit Bug 15190: Bad utf8 decode to unapi and fixing status code 200 Fix bad utf8 decoding, also fix status code 200 for no parameters passed to script To reproduce the issue in OPAC 1) Copy from LOC (Z39.50) ISBN 8467020113 or test it with whichever record with special characters 2) Open URL in OPAC cgi-bin/koha/unapi?id=koha:biblionumber:4&format=oai_dc play with oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, rdfdc. Note: marcxml does not fail 3) Enter the new biblionumber for ISBN 8467020113 or the record of your choise 4) An oai_dc record will display, notice about the bad utf8 decoding characters 5) Search the record in OPAC 6) To reproduce code 200 Ok and 300 Multiple choices play with: cgi-bin/koha/unapi cgi-bin/koha/unapi?id=koha:biblionumber:4 7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162) Test plan -Apply patch -Follow steps 2 to 6 -You will see no errors in utf8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing code status 200
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Héctor Eduardo Castro Avalos changed: What|Removed |Added Summary|Bad utf8 decode to unapi|Bad utf8 decode to unapi |and fixing error status 200 |and fixing code status 200 |for unapi with no | |parameters | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15541] Create additional normalizers for Record Matching Rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541 David Cook changed: What|Removed |Added Summary|Prevent normalization |Create additional |during matching/import |normalizers for Record |process |Matching Rules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing error status 200 for unapi with no parameters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190 Héctor Eduardo Castro Avalos changed: What|Removed |Added Summary|Bad utf8 decode to unapi|Bad utf8 decode to unapi |and fixing blank screen |and fixing error status 200 |error status|for unapi with no ||parameters --- Comment #12 from Héctor Eduardo Castro Avalos --- Thank you very much, Marcel. I've changed the name of the bug according with the info you sent me. I make the changes that you recommend it. I only changed the 200 Ok status if no parameters passed to script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 David Cook changed: What|Removed |Added Blocks||1 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 [Bug 1] Index 024$a into Identifier-other:u url register when source $2 is uri -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff Depends on||14217 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 [Bug 14217] Add a DOM syntax for specifying conditions on indexes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 --- Comment #1 from David Cook --- Created attachment 46512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46512&action=edit Bug 1 - Index 024$a into Identifier-other:u url register when source $2 is uri This patch indexes 024$a into the "phrase" index type, and the "url" index type, if the 024$2 equals "uri". TEST PLAN 1) Apply the patch. 1b) If you're using a gitified Koha or a git install, you'll need to upgrade your instance or copy your zebradb files over to /etc/koha/zebradb or your "kohadev" directory. 2) Add a 024$a with a URL like http://libris.kb.se/resource/bib/219553 to a bibliographic record 3) Re-index Zebra 4) Type "id-other,st-urx,fuzzy=http://libris.kb.se/resource/bib/219553"; into the "Search the catalog" box in the Staff Client and search 5) Note that you retrieve your record NOTE: The fuzzy is required because Koha's query "parsing" functions change http:// to http=// which won't correctly match the value in the "Identifier-other:u" index. NOTE: Alternatively, you could do the following search instead: "id-other,phr=http libris kb se resource bib 219553". It would work as well by using the "Identifier-other:p" index. Advanced tester version: 4) In a terminal window, find the "koha-conf.xml" file in your "etc" directory. 5) Open "koha-conf.xml" and find . Copy the URI you find there. (e.g. unix:/home/dcook/koha-dev/var/run/zebradb/bibliosocket). 6) Type "yaz-client unix:/home/dcook/koha-dev/var/run/zebradb/bibliosocket" 7) After it connects, type "base biblios" and press enter 8) Type "format xml" and press enter 9) Type "elements zebra::index" and press enter 10) Type "f id-other,st-urx=http://libris.kb.se/resource/bib/219553"; and press enter 11) Note that you should have at least one result 12) Type "show 1" 13) If you scroll through the results, you should find something like the following: @^ http libris kb se resource bib 219553 http libris kb se resource bib 219553 http://libris.kb.se/resource/bib/219553 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15555] Index 024$a into Identifier-other:u url register when source $2 is uri
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 David Cook changed: What|Removed |Added Assignee|gmcha...@gmail.com |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15555] New: Index 024$a into Identifier-other:u url register when source $2 is uri
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1 Bug ID: 1 Summary: Index 024$a into Identifier-other:u url register when source $2 is uri Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcha...@gmail.com Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Currently, 024$a is indexed into Identifier-other:w, even when it is a URI (e.g. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217) This causes problems because the "w" index type replaces punctuation with spaces, and tokenizes on spaces, so that the URI is decomposed into a series of values which are indexed separately. This is definitely not what you want when indexing a 024$a when it is a URI. For example: The url "http://libris.kb.se/resource/bib/219553"; becomes the following: @^ http libris kb se resource bib 219553 Fortunately, the 024$2 subfield value tells us the source of the identifier, and "uri" is one of the valid options. So, when we have a 024$2=uri, we can index the 024$a using the "url" index type. (I'm also planning to index into the "phrase" index type for all 024$a as it performs the normalization but it doesn't tokenize based on the spaces, so this normal form may still be of use for urls and other identifiers that rely on punctuation for meaning.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Nicholas van Oudtshoorn changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15162] Add for Unimarc transformation to new metadata formats
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15162 Héctor Eduardo Castro Avalos changed: What|Removed |Added Assignee|hector.hecax...@gmail.com |frede...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Héctor Eduardo Castro Avalos changed: What|Removed |Added CC||hector.hecax...@gmail.com --- Comment #3 from Héctor Eduardo Castro Avalos --- Hi Marc and Jonathan For me all involved tests works successfully t/Patron.t t/db_dependent/Accounts.t t/db_dependent/BiblioObject.t t/db_dependent/Circulation/AnonymiseIssueHistory.t t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t t/db_dependent/Creators/Lib.t t/db_dependent/Hold.t t/db_dependent/Koha_borrower_modifications.t t/db_dependent/Patron.t t/db_dependent/Patron/Borrower_Debarments.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_Files.t t/db_dependent/Patrons.t t/db_dependent/Review.t t/db_dependent/api/v1/patrons.t The next was renamed/removed Renamed t/Borrower.t Renamed t/db_dependent/Borrower.t Renamed t/db_dependent/Borrowers.t git grep Koha::Borrower showed entries in release notes for 3.18 only. I will start to test the modules implied. It seems to be that you only replaced "borrower" to "patron" but IMHO I think this needs a rigorous test plan since you changed a lot in this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084
--- Comment #39 from David Cook ---
Comment on attachment 46021
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46021
Bug 11084 - Delete biblios on Leader 05 == d
Review of attachment 46021:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11084&attachment=46021)
-
::: misc/cronjobs/delete_records_via_leader.pl
@@ +67,5 @@
> +}
> +
> +my $schema = Koha::Database->new()->schema();
> +my @biblioitems =
> + $schema->resultset('Biblioitem')->search( { marc => { LIKE => '_d%' }
> } );
Once Bug 15537 (http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537)
is pushed, this could be replaced with the following query with
C4::Search::SimpleSearch():
"Record-status=d"
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #7 from David Cook --- ADDITIONAL TESTING NOTE: You'll need to re-index Zebra before this feature works... otherwise the Record-status index won't be populated... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #6 from David Cook --- NOTE: I have not tested this in UNIMARC or NORMARC, although I've provided Zebra changes for both. They should be OK, but I haven't confirmed that to be the case. I have only tested MARC21. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What|Removed |Added Assignee|gmcha...@gmail.com |dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #4 from David Cook --- Created attachment 46510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46510&action=edit Bug 15537 - Hide records on Leader 05 = d in OPAC Currently, if a bibliographic record has a record status of "deleted" (ie LDR05=d), it shows up in the catalogue. This patch indexes the LDR05 character into the Record-status index (already defined in bib1.att). It creates a CCL qualifier for that index, and it adds a condition to OPAC queries where it only returns records that do not have a LDR05 of "d". Test Conditions: 1) With QueryParser 2) Without QueryParser 3) With OpacSuppression 4) Without OpacSuppression Test Plan: Before applying patch: 1) Choose a bibliographic record and change the LDR05 to "d" 2) Try searching for that record in the OPAC 3) Note that it appears in the search results (or takes you directly to the record) Apply patch. After applying patch: 4) Try searching for that record in the OPAC 5) Note that the record doesn't appear in the search results 6) Re-try steps 4 & 5 with each of the 4 test conditions outlined above. It should work the same regardless of using the QueryParser or OpacSuppression. NOTE: When using the QueryParser, you might need to vary your syntax. For instance, w/ QP you'd need "local-number:492 || local-number:495" whereas w/o QP you'd need "local-number:492 or local-number:495". NOTE: For extra points, double-check the staff client to make sure that you can still find records that have a LDR05 of "d". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #5 from David Cook --- Created attachment 46511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46511&action=edit Bug 15537 - Hide records on Leader 05 = d in OPAC (follow-up) This follow-up adds a warning message on the detail page in the staff client, which says that the record will not appear in the OPAC. It also includes some logic in opac-detail.pl which prevents an OPAC user from visiting it directly. Test Plan: Apply the patch. 1) Visit a staff client page for a bib record with LDR05=d. 2) Note that there is a warning message saying that it will not be visible in the OPAC 3) Visit the corresponding OPAC page for the bib record 4) Note that you get a redirect to a 404. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What|Removed |Added Attachment #46508|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook changed: What|Removed |Added Attachment #46509|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #3 from David Cook --- Created attachment 46509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46509&action=edit Bug 15537 - Hide records on Leader 05 = d in OPAC Currently, if a bibliographic record has a record status of "deleted" (ie LDR05=d), it shows up in the catalogue. This patch indexes the LDR05 character into the Record-status index (already defined in bib1.att). It creates a CCL qualifier for that index, and it adds a condition to OPAC queries where it only returns records that do not have a LDR05 of "d". Test Conditions: 1) With QueryParser 2) Without QueryParser 3) With OpacSuppression 4) Without OpacSuppression Test Plan: Before applying patch: 1) Choose a bibliographic record and change the LDR05 to "d" 2) Try searching for that record in the OPAC 3) Note that it appears in the search results (or takes you directly to the record) Apply patch. After applying patch: 4) Try searching for that record in the OPAC 5) Note that the record doesn't appear in the search results 6) Re-try steps 4 & 5 with each of the 4 test conditions outlined above. It should work the same regardless of using the QueryParser or OpacSuppression. NOTE: When using the QueryParser, you might need to vary your syntax. For instance, w/ QP you'd need "local-number:492 || local-number:495" whereas w/o QP you'd need "local-number:492 or local-number:495". NOTE: For extra points, double-check the staff client to make sure that you can still find records that have a LDR05 of "d". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15537] Hide records on Leader 05 = d in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 --- Comment #2 from David Cook --- Created attachment 46508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46508&action=edit Bug 15537 - Hide records on Leader 05 = d in OPAC (follow-up) This follow-up adds a warning message on the detail page in the staff client, which says that the record will not appear in the OPAC. It also includes some logic in opac-detail.pl which prevents an OPAC user from visiting it directly. Test Plan: Apply the patch. 1) Visit a staff client page for a bib record with LDR05=d. 2) Note that there is a warning message saying that it will not be visible in the OPAC 3) Visit the corresponding OPAC page for the bib record 4) Note that you get a redirect to a 404. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Héctor Eduardo Castro Avalos changed: What|Removed |Added CC||hector.hecax...@gmail.com Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #46502|0 |1 is obsolete|| --- Comment #2 from Héctor Eduardo Castro Avalos --- Created attachment 46507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46507&action=edit Bug 15552: Better wording of intranetreadinghistory To test: 1) Find intranetreadinghistory system preference in Administration 2) Confirm new description gives more information and makes sense Signed-off-by: Hector Castro Better wording and much better for translatability purposes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Jesse Weaver changed: What|Removed |Added CC||jwea...@bywatersolutions.co ||m --- Comment #15 from Jesse Weaver --- Kyle, Heather, does this changed script yield the same results? It passes my QA, as it just moves the date comparison into MySQL and preserves the --date functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 JD@TeTakere changed: What|Removed |Added CC|joan...@tetakere.org.nz | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 --- Comment #9 from Aleisha Amohia --- I want to sign off on the alternative patch but the 'New from Z39.50' button now doesn't fit along the same line as the other buttons and would look much better if it did. Will sign off once that's fixed up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Aleisha Amohia --- Oops sorry, I realise now these patches are meant to be alternatives and tested separately. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #107 from Katrin Fischer --- One more thing - I had to install 2 dependencies to get it to work. - Should both go into the PerlDependencies.pm file? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #172 from Tim Hannah --- As a librarian I can confirm that the lack of this feature frustrates me, my colleagues and our users. We've been waiting for this for a while and would dearly love to have it sooner rather than later. I can't pretend to understand the ramifications of an imperfect namespace choice, but I know we currently lose users due to them being locked out and going elsewhere rather than approaching us for resets or reminders. If it can be released as is and fixed later, as Liz suggests, I for one would be very grateful. (And thanks for everyone's work on it. Looking forward to it, whenever we get it). Cheers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15360] Incorrect or mislabeled behavior on Authorities "New from Z39.50" Button
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Aleisha Amohia --- Patch doesn't apply: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/authorities-toolbar.inc Failed to merge in the changes. Patch failed at 0001 Bug 15360: Add a "Replace with Z39.50" button when editing an authority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15526] Drop nozebra database table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 Aleisha Amohia changed: What|Removed |Added Attachment #46476|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 46506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46506&action=edit Bug 15526: drop table nozebra This table is not used anymore and can be removed. Test plan: In your sql cli: SHOW TABLES; should return nozebra if your DB has been created before bug 7440. Apply this patch and execute the update DB entry. Now the table should have been dropped. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15526] Drop nozebra database table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15526 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2669] Radio Buttons where there should be checkboxes on Dictionary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2669 Aleisha Amohia changed: What|Removed |Added Attachment #46482|0 |1 is obsolete|| --- Comment #5 from Aleisha Amohia --- Created attachment 46505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46505&action=edit Bug 2669: Change checkboxes to radio buttons on dictionary On creating new dictionary for report, the choice between "All dates" and "Date range" should be a real radio button, not 2 radio buttons with different names (which means they could be selected altogether...) Note that I don't understand what means 'All dates', there is no condition generated for the dictionary. We should not have to select a field if we don't want to add a condition on it :) Test plan: Create a new dictionary for the Patron module, then a date field (dateenrolled or birthdate, etc.) Confirm that the radio buttons now behave as radio buttons... Signed-off-by: Aleisha Looks so much nicer too! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15554] Organize entries in ccl.properties
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15554 David Cook changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15554] Organize entries in ccl.properties
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15554 --- Comment #1 from David Cook --- In any case, it might also be good to have a test in "xt" which checks to make sure that no entries have been added or lost during the re-organization process... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15554] New: Organize entries in ccl.properties
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15554 Bug ID: 15554 Summary: Organize entries in ccl.properties Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcha...@gmail.com Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl At the moment, ccl.properties is fairly disorganized. Once upon a time, it may have been organized numerically or alphabetically, but that seems to have gone out the window a bit. It would be nicer if it followed a similar scheme to https://www.loc.gov/z3950/agency/defns/bib1.html That is, qualifiers and aliases would be grouped into Bib-1 attribute categories: 1. Use Attributes 2. Relation Attributes 3. Position Attributes 4. Structure Attributes 5. Truncation Attributes 6. Completeness Attributes -- Indexdata Extensions: 7. Sort 9. Ranking In other words, all entries that roughly follow the pattern "Qualifier 1=[A-Za-z0-9]+" would be grouped in "1. Use Attributes". Examples: Abstract 1=62 ab Abstract Any 1=1016 kw Any Likewise, entries following the pattern "Qualifier 2=[A-Za-z0-9]+" would be grouped in "2. Relation Attributes". Examples: lt 2=1 le 2=2 eq 2=3 ge 2=4 gt 2=5 ne 2=6 --- That said... maybe it makes sense to group together qualifiers that are functionally similar. Like everything found around the comment "# Koha Local-Use Authority Indexes" or "# Subdivisions". I'm not 100% sure how we should order qualifier (and alias) entries within their respective Bib-1 attribute categories. We could do it alphabetically or numerically (although some entries use index string names rather than numerical values. Example: Geographic-subdivision 1=Geographic-subdivision). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Aleisha Amohia changed: What|Removed |Added Attachment #46436|0 |1 is obsolete|| --- Comment #3 from Aleisha Amohia --- Created attachment 46504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46504&action=edit Bug 14816: Fix multiple selection in item search Send each selected value as a separate parameter. Otherwise DataTables (or jQuery ?) joins all values with a comma Tested / compared with several combinations, e.g. "All libraries" vs all libraries checked. With patch result is the same (without, all libraries checked had zero result). Works as expected. Signed-off-by: Marc Véron Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14816] Item search returns no results with multiple values selected for one field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14816 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #171 from David Cook --- As the local pedant in the Koha community, I'm with Liz on this one. While we shouldn't be adding anything to the C4 namespace, I think perhaps an exception should be made for this particular patch set, as the feature is rather important in modernizing Koha. Out in the world, there's pretty much no service where you can't reset your own password. Yet, you can't do it in Koha. Surely this frustrates users and puts a burden on librarians. It's an aspect of the modern web experience which Koha fails at. This patch set has been a long time coming. While it should be fairly easy to do a search and replace through the patches, mistakes do happen, and we'd probably need to re-test all the patches again to make sure that nothing was missed. It seems like it's already been tested to the Nth degree, so perhaps a pass should be made this one time. I suppose it would qualify as technical debt, and I hate technical debt. But this does seem to be an extraordinary case. If it were anything but a password reset, I'd say change the namespace. But this is such a missing piece of functionality in Koha, that I think the faster we get it in the better. Of course, I defer to the QA team and the RM. But just adding that perspective to the comments. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #170 from Liz Rea --- May we have this heavily tested version in, and move it to the new namespace in a follow up? This is an egregiously missing feature, and one that we have been waiting a long, long time for. It's for the users, let's get it in. Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15385] News archive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15385 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Aleisha Amohia --- Patch doesn't apply: Applying: Bug 15385: News archive fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 15385: News archive -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15400] display patron age in useful places
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com --- Comment #4 from Aleisha Amohia --- Is this similar to Bug 14763, but in more places? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694 --- Comment #23 from Christopher Brannon --- Would LOVE it if this could get a QA. :) Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com --- Comment #46 from Aleisha Amohia --- There is a GetAge function already in C4::Members which I used to write a patch for Bug 14763. I am not saying this is a duplicate of that bug, because I feel this is slightly different to what my patch does, but is it possible to use that function for this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 --- Comment #38 from Aleisha Amohia --- *** Bug 14573 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14573] Correcting messages on OPAC error pages so they make more sense
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14573 Aleisha Amohia changed: What|Removed |Added Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #3 from Aleisha Amohia --- *** This bug has been marked as a duplicate of bug 15288 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Karl Holten changed: What|Removed |Added CC||jschm...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Blou changed: What|Removed |Added CC||eric.be...@inlibro.com, ||francois.charbonnier@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #21 from Katrin Fischer --- ... I should add that switching back to master and repeating the process with a third due date C closer to today, the new fine added is FU. So there seems to be a difference from this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Blou changed: What|Removed |Added Assignee|gmcha...@gmail.com |philippe.blo...@inlibro.com Status|NEW |Needs Signoff --- Comment #2 from Blou --- My initial plan was to have some value specific to each library (when multiple libraries on a server), but I didn't want to add a syspref, nor could I find an easy, meaningful value to reuse. Deleting the dir poses no problem, since CGI:Session creates the directory when needed, owned by www-data (or equivalent). I only tested on Ubuntu & Debian. No Windows. I added that for our benefit, thought it might be useful to others. No biggie if no one's interested :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer --- Hm, I might have found a case where this doesn't work quite right: Apply patch. Follow test plan: - Make sure there is an overdue item with a fine. - Renew overdue item with due date A. - Observe that fine type changes from FU to F. - Check out the item again - with a different due date B. - Run fines again. - Observe that fine is now F - although it should still be accrueing and FU. Kyle, can you please check? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15553] cgisess_ files polluting the /tmp directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 --- Comment #1 from Blou --- Created attachment 46503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46503&action=edit Bug 15553 - cgisess_ files polluting the /tmp directory When some users want to improve performance, one suggestion is to switch the syspref "sessionstorage" to 'tmp', which store the session info in the /tmp directory instead of the database. Depending on the frequency of the cleaning process (or lack thereof), this can be heavy pollution into the /tmp directory, making it unusable. "rm cgi*" would not even work since cgi* extends to over 8000 items... A simple fix is to modify the target directory in C4/Auth.pm to /tmp/cgisess. Testing scenario: 1) change the syspref SessionStorage to 'tmp' 2) Log into the OPAC, validate that a file named /tmp/cgisess_(something) got created 3) Apply the patch 4) Log into the OPAC, validate that a file /tmp/cgisess/cgisess_(something) got created -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15553] New: cgisess_ files polluting the /tmp directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15553 Bug ID: 15553 Summary: cgisess_ files polluting the /tmp directory Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: gmcha...@gmail.com Reporter: philippe.blo...@inlibro.com QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org When some users want to improve performance, they get the recommandation to switch the syspref "sessionstorage" to 'tmp', which store the session info in the /tmp directory instead of the database. Depending on the frequency of the cleaning process (or lack thereof), this can be heavy pollution into the /tmp directory, making it unusable. "rm cgi*" would not even work since cgi* extends to over 8000 items... A simple fix is to modify the target directory in C4/Auth.pm to /tmp/cgisess. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 --- Comment #1 from Aleisha Amohia --- Created attachment 46502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46502&action=edit Bug 15552: Better wording of intranetreadinghistory To test: 1) Find intranetreadinghistory system preference in Administration 2) Confirm new description gives more information and makes sense -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15552] Better wording of intranetreadinghistory syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Karl Holten changed: What|Removed |Added CC||khol...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096
--- Comment #8 from Aleisha Amohia ---
(In reply to Marc Véron from comment #6)
> However, the explanation is not precise ('it is stored regardless'), I think
> it should be something like ('it is stored regardless if the patron has
> allowed to keep the reading history'). - That would be something for a
> separate bug.
See Bug 15552.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15552] New: Better wording of intranetreadinghistory syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15552 Bug ID: 15552 Summary: Better wording of intranetreadinghistory syspref Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamo...@hotmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currently says: "(Allow/Don't allow) staff to access a patron's checkout history (it is stored regardless)." It has been suggested that this could be worded better. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15096] Export today's checked in barcodes: Display warning if reading history is set to "never"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15096 Aleisha Amohia changed: What|Removed |Added Attachment #45508|0 |1 is obsolete|| --- Comment #7 from Aleisha Amohia --- Created attachment 46501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46501&action=edit Bug 15096: Export today's checked in barcodes: Display warning if reading history is set to "never" If a patron's privacy settings are set to "Never" for keeping a reading history, "Export today's checked in barcodes" returns an empty file. This patch skips the export if such privacy rule is set and dsiplays a message. To test: - Apply patch - Search for a user who has privacy rules set to never keeping a circulation history - Check out / check in in some items - On users detail page, go to More->Export today's checked in barcodes - Verify that a message appears about user's privacy settings (in same window) - Click left tab "Circulation history" - Verify that the same message appearsar - Verify the same with the other conditions that prevent the display of the user's circulation history: - Syspref 'intranetreadinghistory' is 'Don't allow' - Patron is 'Anonymous patron' (syspref 'Anonymous patron') - Search for a user who allows circulation history - repeat steps above, verify that circulation history appears (if allowed by syspref 'intranetreadinghistory' and that today's checkouts are exported. (Amended for comment #3) Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15551] checked out items not showing on returns.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hm, I am not sure about this - the new change should only avoid showing items which actually haven't been checked in - like items not checked out when performing the check in. Also - I don't think it ever showed other items checked out by the patron? Maybe they just followed the link from the checked in item? That should still work, if the patch you are referring didn't cause a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14641] Warns in subscription-add.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Aleisha Amohia changed: What|Removed |Added Attachment #45623|0 |1 is obsolete|| --- Comment #8 from Aleisha Amohia --- Created attachment 46500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46500&action=edit Bug 14641: Warns in subscription-add.pl Removes warn using Jonathan's suggestion! To test: 1) Reproduce warns by clicking New Subscription 2) Apply patch 3) Click New Subscription again 4) Confirm warns are gone -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14641] Warns in subscription-add.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15551] New: checked out items not showing on returns.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15551 Bug ID: 15551 Summary: checked out items not showing on returns.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Bug 14821: Dont show item in checked in list, when it wasnt checked in. This is seen as a regression by some of our libraries -- checking an item in previously showed other items checked out by the same borrower, which was useful for renewing items and/or telling patrons what items they still had checked out. I would suggest a separate "Checked out by same borrower" list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 --- Comment #17 from Aleisha Amohia --- Thank you for this patch!! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #106 from Katrin Fischer ---
Hi Jonathan,
I (re)testd some more:
NOW OK:
- Patron account in staff > notices tab > HTML notices
- System preferences containing HTML tags display them
To test: search for 'note' in system preferences
- Staff > detail page > MARC view > Items tab > displays in URL column
To test: Add a 952$u to one of multiple items
- HTML tags in messages in the patron account ('new message' link)
NOT OK:
- HTML printer slips are broken
To test: Patron account > print quick slip
This shows still the same problem for and I don't see a patch with a
matching description on the branch?
- HTML tags in restriction/debarment comments
Works partially - the restriction message on top of the patron account is
ok.
The entries in the little restrictions table inside the tab still appear
broken - on the details and checkout tabs and also when editing a patron.
Other test results:
- OPAC is looking good, nothing found
- Staff is looking good as well - no new findings. :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15550] Authority type pull down in OPAC authority search is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Katrin Fischer changed: What|Removed |Added Severity|normal |major --- Comment #1 from Katrin Fischer --- Search dies with Can't call method "authtypetext" on an undefined value at /home/katrin/kohaclone/opac/opac-authorities-home.pl line 155. Updating severity a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15550] New: Authority type pull down in OPAC authority search is empty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15550 Bug ID: 15550 Summary: Authority type pull down in OPAC authority search is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: jonathan.dru...@bugs.koha-community.org In the authority search form in the OPAC the pull down for choosing the authority type appears empty. Maybe similar to the bug report for the staff authority search? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #46265|0 |1 is obsolete|| --- Comment #3 from Héctor Eduardo Castro Avalos --- Created attachment 46499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46499&action=edit [SIGNED-OFF]Bug 15472: Do not display links to circulation.pl if remaining_permissions is not set If permission 'circulate_remaining_permissions' is not set, links to 'Circulation' (/circ/circulation-home.pl) on the intranet home page lead to an error message: "Error: You do not have permission to access this page." This patch hides the links if the permission is not set. To test: - Apply patch - Log in to the intranet (staff client) with a patron who has the permission 'circulate_remaining_pernissions' not set - Verify that no links to Circulation appear on the intranet start page (menu top left and menu in main page area) - Log in as a user who has the permission set. - Verify that te links appear as appropriate. Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #13 from Katrin Fischer --- Created attachment 46498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46498&action=edit [PASSED QA] Bug 15337: Make itemtypes retrieved with GetItemTypes ordered by descriptions Prior to this patch, the itemtypes were displayed ordered by the code (itemtypes.itemtype DB column). This patch will make them displayed by the description displayed (the translated description). Test plan: 0/ Do not apply this patch set 1/ Confirm that the itemtypes are displayed ordered by code (when adding an item, cataloguing/additem.pl) 2/ Confirm that t/db_dependent/Koha.t does not pass 3/ Apply the test patch 4/ Confirm that t/db_dependent/Koha.t pass 5/ Confirm that the itemtypes are not displayed by description (on additem.pl) See comment #3 Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15472] Do not display links to circulation.pl if remaining_permissions is not set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15472 Héctor Eduardo Castro Avalos changed: What|Removed |Added CC||hector.hecax...@gmail.com --- Comment #2 from Héctor Eduardo Castro Avalos --- Good catch, Marc. If I want a staff patron has only access to one or two granular permissions, e.g., self_checkout, the System displays the circulation links. If patron clicks in one of the links, the program logs out the user and is presented with the error message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Katrin Fischer changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 Katrin Fischer changed: What|Removed |Added Attachment #46274|0 |1 is obsolete|| Attachment #46275|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 46497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46497&action=edit [PASSED QA] Bug 15337: Add tests to ensure that GetItemTypes will return element ordered by desc See comment #3 Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15337] Koha Item Type sorted by Codes instead of Descriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15337 --- Comment #11 from Katrin Fischer --- I think it must have been some hidden whitespace. I reentered all descriptions, didn't notice an additional space, but after that - it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15548] New patron related code should have been put to Patron instead of Borrower
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15548 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #2 from Marc Véron --- Testing with patch: t/db_dependent/Circulation.t OK t/db_dependent/Members.t OK t/db_dependent/Hold.t OK t/db_dependent/Item OK t/db_dependent/Koha_Misc_Files.t (OK) t/db_dependent/Patron.t OK t/db_dependent/Patrons.t OK t/db_dependent/Virtualshelves.t OK t/Patron.t OK t/db_dependent/Accounts.t OK t/db_dependent/BiblioObject.t OK t/db_dependent/Circulation/AnonymiseIssueHistory.t (Fails with and without patch, could be related to my test server) t/db_dependent/Creators/Lib.t (OK) t/db_dependent/Hold.t (OK) t/db_dependent/Koha_borrower_modifications.t (OK) t/db_dependent/Borrower_Debarments.t OK t/db_dependent/Borrower_Discharge.t OK t/db_dependent/Borrower_Files.t OK t/db_dependent/Review.t t/db_dependent/api/v1/patrons.t (Fails with and without patch) I think somebody else should run all the tests as well (especially the two failing without and with patches). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15508] Select which library a staff user can login as
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15508 --- Comment #1 from Christopher Brannon --- This permission would need to exclude superlibrarian. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15549] New: Forgive fines when checking out a currently checked out item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15549 Bug ID: 15549 Summary: Forgive fines when checking out a currently checked out item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 46496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46496&action=edit Current yellow box When checking out to a patron you sometimes discover an item that was on the shelf was never checked in. In a fines library it would be nice to have the option to forgive fines when checking in/checkout out the item using the yellow box. It would eb nice to have a checkbox on the yellow box to allow for this -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Marc Véron changed: What|Removed |Added Attachment #46493|0 |1 is obsolete|| --- Comment #16 from Marc Véron --- Created attachment 46495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46495&action=edit Bug 15542: Change for the German style address format Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Marc Véron changed: What|Removed |Added Attachment #46492|0 |1 is obsolete|| --- Comment #15 from Marc Véron --- Created attachment 46494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46494&action=edit Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere. Followed test plan, works as expected. (Tested both patches together.) Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Jonathan Druart changed: What|Removed |Added Attachment #46490|0 |1 is obsolete|| --- Comment #13 from Jonathan Druart --- Created attachment 46492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46492&action=edit Bug 15542: Always display the patron's info the same way. The patron's information displayed in the member module (includes/circ-menu.inc and includes/member-display-address-style-*.inc) are not always displayed the same way. Sometimes the streetnumber is missing, sometimes it's the streettype. Sometimes the streettype is after the address, sometimes before... Test plan: Go on a patron detail page, and open all the tabs on the left (Check out, Fines, Notices, etc.) Without this patch, the patron's info displayed will differ from one page to another. With this patch, they will be displayed the same everywhere. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15542] Patron's information are not always displayed the same way
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15542 Jonathan Druart changed: What|Removed |Added Attachment #46491|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 46493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46493&action=edit Bug 15542: Change for the German style address format -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
