[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883
--- Comment #18 from Julian Maurice ---
Note that there is still a call to .attr('checked', false) in
jquery.dataTables.columnFilter.js
I am not sure how we should handle that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883
--- Comment #17 from Julian Maurice ---
Created attachment 50098
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50098&action=edit
Bug 15883: Use .prop() instead of .attr() for 'checked'
According to https://jquery.com/upgrade-guide/1.9/#attr-versus-prop-
.attr() is no longer correct to access the checked state of a checkbox.
This patch do the following replacements:
.attr('checked') => .prop('checked')
.attr('checked, '')=> .prop('checked', false)
.attr('checked, 'checked') => .prop('checked', true)
.attr('checked', boolValue)=> .prop('checked', boolValue)
.removeAttr('checked') => .prop('checked', false)
.attr('checked') == 'checked' => .is(':checked')
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #16 from Julian Maurice --- Okay, when using development version of jQuery Migrate I can see some warnings. Maybe we should use that by default, it's only 4K more than the production version, and will force us to fix errors as we see them -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15566] Update API to allow to reserve first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15566 Benjamin Rokseth changed: What|Removed |Added CC||benjamin.roks...@kul.oslo.k ||ommune.no --- Comment #3 from Benjamin Rokseth --- Rebased against master. Any reason this is blocked? Tests pass and API seems fine, although its certainly gonna conflict with Bug 15567 - Update API to allow multiple holds for the same record, at least the code in Koha/REST/V1/Reserve.pm and the definition files -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15566] Update API to allow to reserve first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15566
Benjamin Rokseth changed:
What|Removed |Added
Attachment #48447|0 |1
is obsolete||
--- Comment #2 from Benjamin Rokseth ---
Created attachment 50097
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50097&action=edit
Bug 15566: API - allow to reserve first available from a group of titles
Test plan:
0. Find 1 borrower and 2 biblios they can place a hold on. Let's call
them $borrowernumber, $biblionumber1 and $biblionumber2
1. Make a POST request to http://your.library.org/api/v1/reserves with
the following body:
{
"onlyfirst": true,
"reserves": [
{
"borrowernumber": $borrowernumber,
"biblionumber": $biblionumber1
},
{
"borrowernumber": $borrowernumber,
"biblionumber": $biblionumber2
},
]
}
2. Check that you get a 201 response with the reserves informations
3. Check in staff interface that the reserves were correctly made
Signed-off-by: Benjamin Rokseth
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What|Removed |Added Attachment #48449|0 |1 is obsolete|| --- Comment #19 from Benjamin Rokseth --- Created attachment 50096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50096&action=edit Bug 15516: Update old_reserves (reserve_group_id) Without it, deletion of reserves will fail Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What|Removed |Added Attachment #48098|0 |1 is obsolete|| --- Comment #18 from Benjamin Rokseth --- Created attachment 50095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50095&action=edit Bug 15516 - Holding first available item from x biblios only count 1 reserve Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15516] Allow to reserve first available item from a group of titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Benjamin Rokseth changed: What|Removed |Added Attachment #48097|0 |1 is obsolete|| --- Comment #17 from Benjamin Rokseth --- Created attachment 50094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50094&action=edit Bug 15516: Allow to reserve first available item from a group of titles It can be useful, for instance, if a library have the same title from different publishers (so 1 title but several biblio records) but the user only wants a copy of the book, regardless of the publisher. This patch is only for staff interface. Test plan: 0. Run updatedatabase.pl and misc/devel/update_dbix_class_files.pl 1. Go to intranet search, display some results, click on some checkboxes and click on 'Place hold' button at the top of the results. 2. Enter a patron cardnumber and click Search 3. Check the box for 'Place a hold on the next available item' (it's usually hidden when placing a hold on multiple biblios) 4. Click on 'Place hold' 5. In the next screen you should see all the holds you placed with the additional text '(part of a reserve group)' in Details column. 6. Click on the "reserve group" link. A modal window should appear with the content of the reserve group (a list of holds) 7. Check in an item of one of the reserved biblios and confirm the hold 8. The hold status is changed to Waiting, and all other holds are deleted. Note: the "reserve group" link is displayed in the following pages: - reserve/request.pl - circ/circulation.pl - members/moremember.pl - circ/pendingreserves.pl Signed-off-by: Josef Moravec Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16182] Make phone number clickable to call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 --- Comment #6 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #5) > Should not we make these links visible/clickable only for mobile devices? I can click them from my macbook, it opens up FaceTime I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16083] Accept CLI params for the Makefile.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16083 Mirko Tietgen changed: What|Removed |Added Severity|minor |enhancement CC||mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3534] Patron quick add form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3534] Patron quick add form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #50092|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 50093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50093&action=edit Bug 3534 - Patron quick add form This patch adds two new system preferences: PatronQuickAdd PatronQuickAddFields When enabled the pref will add a new form to memberentrygen composed of the fields in PatronQuickAddFields and BorrowerMandatoryField. There will be a button allowing a user to switch from the quickadd to the full form. The Quick add will only be displayed on add of a new patron, future edits should display the full form. Test plan: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add a new patron and ensure nothing has changed 4 - Enable quick add (do not add any fields) 5 - Only required fields should be displayed 6 - Ensure you can save patron 7 - Verify that subsequent edits use only full form 8 - Verify that data on form submitted is the data saved to patron 9 - Add fields to PatronQuickAddFields 10 - check that fields are present in quick add form 11 - Ensure that you can save patron 12 - Test with various values in both MandatoryBorrowerFields and PatronQuickAddFields Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3534] Patron quick add form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3534] Patron quick add form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3534] Patron quick add form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #50091|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 50092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50092&action=edit Bug 3534 - Patron quick add form This patch adds two new system preferences: PatronQuickAdd PatronQuickAddFields When enabled the pref will add a new form to memberentrygen composed of the fields in PatronQuickAddFields and BorrowerMandatoryField. There will be a button allowing a user to switch from the quickadd to the full form. The Quick add will only be displayed on add of a new patron, future edits should display the full form. Test plan: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add a new patron and ensure nothing has changed 4 - Enable quick add (do not add any fields) 5 - Only required fields should be displayed 6 - Ensure you can save patron 7 - Verify that subsequent edits use only full form 8 - Verify that data on form submitted is the data saved to patron 9 - Add fields to PatronQuickAddFields 10 - check that fields are present in quick add form 11 - Ensure that you can save patron 12 - Test with various values in both MandatoryBorrowerFields and PatronQuickAddFields Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3534] Patron quick add form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Nick Clemens changed: What|Removed |Added Attachment #50090|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 50091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50091&action=edit Bug 3534 - Patron quick add form This patch adds two new system preferences: PatronQuickAdd PatronQuickAddFields When enabled the pref will add a new form to memberentrygen composed of the fields in PatronQuickAddFields and BorrowerMandatoryField. There will be a button allowing a user to switch from the quickadd to the full form. The Quick add will only be displayed on add of a new patron, future edits should display the full form. Test plan: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add a new patron and ensure nothing has changed 4 - Enable quick add (do not add any fields) 5 - Only required fields should be displayed 6 - Ensure you can save patron 7 - Verify that subsequent edits use only full form 8 - Verify that data on form submitted is the data saved to patron 9 - Add fields to PatronQuickAddFields 10 - check that fields are present in quick add form 11 - Ensure that you can save patron 12 - Test with various values in both MandatoryBorrowerFields and PatronQuickAddFields Sponsored by: VOKAL (Vermont Organization of Koha Automated Libraries) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3534] Patron quick add form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 --- Comment #5 from Nick Clemens --- Created attachment 50090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50090&action=edit Bug 3534 - Patron quick add form This patch adds two new system preferences: PatronQuickAdd PatronQuickAddFields When enabled the pref will add a new form to memberentrygen composed of the fields in PatronQuickAddFields and BorrowerMandatoryField. There will be a button allowing a user to switch from the quickadd to the full form. The Quick add will only be displayed on add of a new patron, future edits should display the full form. Test plan: 1 - Apply patch 2 - run updatedatabase.pl 3 - Add a new patron and ensure nothing has changed 4 - Enable quick add (do not add any fields) 5 - Only required fields should be displayed 6 - Ensure that values are populated when swtiching forms 7 - Ensure you can save patron 8 - Verify that subsequent edits use only full form 9 - Add fields to PatronQuickAddFields 10 - check that fields are present in quick add form 11 - Ensure that you can save patron 12 - Test with various values in both MandatoryBorrowerFields and PatronQuickAddFields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16231] Correct permission handling in subscription edit menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16231] Correct permission handling in subscription edit menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 --- Comment #1 from Owen Leonard --- Created attachment 50089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50089&action=edit Bug 16231 - Correct permission handling in subscription edit menu This patch corrects the way subscription edit menu items are displayed according to the user's permissions settings. The edit menu has been updated to use the menu item terms "Edit," "Duplicate," and "Delete" instead of "Edit subscription," "Edit as new (duplicate)", and "Delete subscription. The change makes the terms less redundant and more consistent with other similar menus in Koha. Font Awesome icons have been added to each menu item. This patch also removes a non-standard "fa-lg" class from some Font Awesome icons in the toolbar. To test, apply the patch and log in to the staff client as a user who has permission to create, edit, and delete subscriptions. - Locate an subscription and view the details for it. - The "Edit" menu should show three options: "Edit," "Duplicate," and "Delete." - Confirm that each menu item works correctly. - Repeat the process when logged in as a user with varying combinations of create, edit, and delete permissions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16232] New: Edit as new (duplicate) doesn't work correctly with Rancor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16232 Bug ID: 16232 Summary: Edit as new (duplicate) doesn't work correctly with Rancor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: jwea...@bywatersolutions.com Reporter: jwea...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Marked as bug because the behavior is confusing (shows empty record but saves over old record). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16231] New: Correct permission handling in subscription edit menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16231 Bug ID: 16231 Summary: Correct permission handling in subscription edit menu Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/serials/subscription-detail.pl?subscript ionid=X OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Serials Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com The "Edit" toolbar menu for serials contains three items, "Edit subscription," "Edit as new (duplicate)" and "Delete subscription." Each item should be wrapped in its own check for the "CAN_user_serials_*" permission. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #15 from Owen Leonard --- (In reply to Julian Maurice from comment #14) > No issues so far, not even a warning from jQuery Migrate. Thanks for testing. I would expect you to get console log warnings from jQuery Migrate on every page if only from Bootstrap's js. Did you switch from using the production (minified) to the development (unminified) version? I'd love to be able to build in an easy switch for doing that but I don't know how. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #14 from Julian Maurice --- I applied the patch and went to several places in the staff client (search, circulation, patrons, serials, admin, reports, tools, ...). No issues so far, not even a warning from jQuery Migrate. I'll try to do more testing when I have time -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16230] Show tooltip with menu item when fund cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 --- Comment #1 from Owen Leonard --- Created attachment 50088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50088&action=edit Bug 16230 - Show tooltip with menu item when fund cannot be deleted This patch enables Bootstrap to generate a tooltip for the fund deletion menu item when a fund cannot be deleted because it has children. Also changed: Enable translation of the associated error message. To test you must have at least one fund which has a child fund. Apply the patch and go to Administration -> Funds. - In the list of funds, find a fund which has children. - Click the "Actions" menu. The "Delete" item should be disabled. - Hovering over the "Delete" item should display a Bootstrap-style tooltip with the explanation "This fund has children." - Clicking the "Delete" item should trigger an alert, "This fund has children. It cannot be deleted." - Clicking "Delete" on funds without children should work correctly. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16230] Show tooltip with menu item when fund cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #13 from Julian Maurice --- (In reply to Owen Leonard from comment #12) > Note that jQuery 2.2.3 does not support Internet Explorer 6, 7, or 8. As well as Microsoft: https://www.microsoft.com/en-us/WindowsForBusiness/End-of-IE-support, so not a big issue I think. In fact, only IE 11 is supported by Microsoft -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15471] Add column settings and filters to Holds queue table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 Benjamin Rokseth changed: What|Removed |Added CC||benjamin.roks...@kul.oslo.k ||ommune.no --- Comment #15 from Benjamin Rokseth --- Eh, this is already committed to master, no? https://github.com/Koha-Community/Koha/commit/fdc06dec2a6e827a5c04c048a0478a2f80d2cd76 https://github.com/Koha-Community/Koha/commit/8e997fbafcc635b275c6ca1211e47a4cd38c8140 https://github.com/Koha-Community/Koha/commit/5f5a7ffaf81a0eaa9240f0790f91b04503484552 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16230] New: Show tooltip with menu item when fund cannot be deleted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 Bug ID: 16230 Summary: Show tooltip with menu item when fund cannot be deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P3 Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: fridolin.som...@biblibre.com, gmcha...@gmail.com, josef.mora...@gmail.com, katrin.fisc...@bsz-bw.de, koha-bugs@lists.koha-community.org, mag...@libriotech.no, neng...@gmail.com, tomasco...@gmail.com Blocks: 2310 In Acquisitions -> Funds, if you cannot delete a fund (for instance, because it has children), the "Delete" menu item is grayed out. The menu has the correct markup to trigger a Bootstrap tooltip, but there isn't the correct JavaScript to trigger its display. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310 [Bug 2310] Omnibus: Delete grayed out w/out explanation -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2310] Omnibus: Delete grayed out w/out explanation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2310 Owen Leonard changed: What|Removed |Added Depends on||16230 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16230 [Bug 16230] Show tooltip with menu item when fund cannot be deleted -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #12 from Owen Leonard --- Note that jQuery 2.2.3 does not support Internet Explorer 6, 7, or 8. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard changed: What|Removed |Added Attachment #48457|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #11 from Owen Leonard --- Created attachment 50087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50087&action=edit Bug 15883 - Upgrade jQuery from v1.7.2 in the staff client This patch updates the staff client version of jQuery to 2.2.3. In order to maintain compatibility with existing scripts, the jQuery migrate plugin has also been added. Included is the development version of the jQuery migrate plugin. Developers could modify doc-head-close.inc to use this version if they wanted to take advantage of its upgrade warning log. To test, apply the patch and test JavaScript interactions everywhere in the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15883] Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #71 from Mirko Tietgen --- (In reply to Mirko Tietgen from comment #70) > - Dequeue does not work for me. Several auth errors, then a working auth. A > record is created, but it only contains a (broken) leader. I had metadataPrefix set to oai_dc. I successfully imported a record in Koha after switching to marcxml. Very nice! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Nick Clemens changed: What|Removed |Added Attachment #50085|0 |1 is obsolete|| --- Comment #23 from Nick Clemens --- Created attachment 50086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50086&action=edit Bug 9004: Use Koha::Calendar instead of C4::Calendar This patch tries to make the code more readable using Koha::Calendar instead of deprecated C4::Calendar and Date::Calc Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 --- Comment #22 from Jonathan Druart --- Hi Nick, Any chances to get a signoff on this one? I have never used this script before so I may have missed something! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 --- Comment #21 from Jonathan Druart --- Created attachment 50085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50085&action=edit Bug 9004: Use Koha::Calendar instead of C4::Calendar This patch tries to make the code more readable using Koha::Calendar instead of deprecated C4::Calendar and Date::Calc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11088] Patron entry page should use floating toolbar like cataloging interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11088 --- Comment #2 from Owen Leonard --- After way too much time trying to figure this out, I was finally able to identify the problem: The additional patron search fields which are hidden when the page loads (). Because the filter is shown initially, the toolbar misidentifies where its starting location is on the page. My initial thought was to make the filter hidden by default, but it's not that simple. I think if we want a floating toolbar on this page we have to re-think how the additional patron search fields are displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 --- Comment #13 from Marjorie Barry-Vila --- Hi, Still valid in 3.22. Anyone to fix it? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #96 from M. Tompsett --- See the test plan in comment #93. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #70 from Mirko Tietgen --- Hi David, nice to see this move forward! I gave it a first ride and here are a few comments/questions: - Would it make sense for you to use Catmandu::OAI instead of IO::*? We will use Catmandu for Elasticsearch, it would probably make sense here too? - Task type is set on separate page for add and edit of tasks. Should be on the same page as the rest of the config. - I can add a task, I can start a task -- but I can't stop a task, just remove. - Task numbering always starts at 2. There is no task 1? - Tasks should be sorted by task number - I can send a single task to Icarus multiple times. Is that intended? - "Send to Icarus" leads to empty page if Icarus is not running - Permissions for the OAI user? Even with superlibrarian I get several auth errors, and I would not want to give it superlibrarian permissions anyway. - Log should display something more useful than [server 1], like name or IP - Log shows lots of "Connection n started.1" and "Connection n failed or ended" but there is no hint what that actually means. It does not seem to be relevant for fulfilling the task - Enqueue needs an identifier to work. What if I want to get more than one record? Using just the prefix does not work. - Enqueue seems to work so far, I downloaded a record. - Dequeue does not work for me. Several auth errors, then a working auth. A record is created, but it only contains a (broken) leader. - Have not tested matching yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What|Removed |Added Attachment #49615|0 |1 is obsolete|| --- Comment #95 from M. Tompsett --- Comment on attachment 49615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49615 Tweak C4/XSLT to delete field when no subfields left. Can only be triggered by bad data, as far as I can tell. This change is not required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #94 from M. Tompsett --- Okay, that last patch requires bad data to trigger it as far as I can tell. I did, however, notice another problem in C4/XSLT, that I'll make a separate bug for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 --- Comment #2 from Lari Taskula --- Created attachment 50084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50084&action=edit Bug 16223: Enable regex match for rules of debarment removals This patch adds possibility to use regex to match debarments with dynamic comment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15567] Update API to allow multiple holds for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 Benjamin Rokseth changed: What|Removed |Added CC||benjamin.roks...@kul.oslo.k ||ommune.no --- Comment #3 from Benjamin Rokseth --- Rebased against master. Tested OK, but should avait dependent bugs 14695 and 15565 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16182] Make phone number clickable to call
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16182 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Should not we make these links visible/clickable only for mobile devices? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15567] Update API to allow multiple holds for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15567 Benjamin Rokseth changed: What|Removed |Added Attachment #47860|0 |1 is obsolete|| --- Comment #2 from Benjamin Rokseth --- Created attachment 50083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50083&action=edit Bug 15567 - Allow to place multiple at once via RESTFUL Test plan: Same tests than Bug 15565 but via RESTFUL Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669
--- Comment #17 from Jonathan Druart
---
Comment on attachment 50047
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50047
Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron
toolbar
Review of attachment 50047:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=3669&attachment=50047)
-
Your patch adds a swp file
koha-tmpl/intranet-tmpl/prog/en/includes/.member-add-message.inc.swp
::: members/boraccount.pl
@@ +106,4 @@
> );
> }
>
> +my $branch = C4::Context->userenv->{'branch'};
This value can be retrieved from the templates using LoginBranchcode, it will
avoid to pass it from all the scripts.
Keep in mind: if you are duplicating code, you are doing something wrong ;)
@@ +108,5 @@
>
> +my $branch = C4::Context->userenv->{'branch'};
> +
> +# get authorised values with type of BOR_NOTES
> +my $canned_notes = GetAuthorisedValues("BOR_NOTES");
Same here, the AuthorisedValues template plugin will help you.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5670] Housebound Readers Module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Alex Sassmannshausen changed: What|Removed |Added Assignee|colin.campbell@ptfs-europe. |alex.sassmannshausen@ptfs-e |com |urope.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 --- Comment #20 from Nick Clemens --- No iTiva account is required for testing, this simply alters the data in the file generated by the script. Note:the output to screen option for this script doesn't appear to function, results must be saved to a file to view. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 --- Comment #19 from Nick Clemens --- Created attachment 50082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50082&action=edit Bug 9004: (QA followup) Fix pod -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9004] Talking Tech doesn't account for holidays when calculating a holds last pickup date.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9004 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #18 from Jonathan Druart --- FAIL misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl FAIL pod in file misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl *** ERROR: =item without previous =over I cannot test this patch, but I think we can trust ByWater for the signoff. It would have been better to use DateTime and Koha::Calendar to do the date calculation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16220] The view tabs on opac-detail.pl are not responsive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16220 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16220] The view tabs on opac-detail.pl are not responsive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16220 Jonathan Druart changed: What|Removed |Added Attachment #50054|0 |1 is obsolete|| Attachment #50055|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 50080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50080&action=edit Bug 16220 - The view tabs on opac-detail.pl are not responsive When looking at the detail page for a bibliographic record, there are tabs linking to the "Normal," "MARC," and "ISBD" views. These tabs need to be styled responsively so that they work well at all browser widths. This patch makes some slight markup changes to the templates and updates the LESS files to add responsive styling. This patch does not include the compiled CSS file, so the follow-up is required to test the visual changes. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16220] The view tabs on opac-detail.pl are not responsive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16220 --- Comment #6 from Jonathan Druart --- Created attachment 50081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50081&action=edit Bug 16220 [Compiled CSS] The view tabs on opac-detail.pl are not responsive This patch updates the compiled CSS file with changes made in the previous patch to the LESS files. To test, apply both patches and clear your browser cache if necessary. - View the bibliographic detail page for any record in the OPAC - Confirm that the style of the "Normal," "MARC," and "ISBD" links looks correct. - Resize your browser to various widths, including very narrow widths. Confirm that the links work well at all sizes. - Repeat the test for each view, normal, MARC, and ISBD. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16228] Move some patron entry form JavaScript into members.js again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16228 --- Comment #1 from Owen Leonard --- Created attachment 50079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50079&action=edit Bug 16228 - Move some patron entry form JavaScript into members.js again Bug 15206 undid the changes Bug 15692 made to memberentrygen.tt. This patch re-removes the JS from the template and moves the additions made by Bug 15206 into members.js. Two other minor edits: Changes to quiet JSHint errors. To test, apply the patch and repeat the test plan for Bug 15692. Confirm that the following interactions still work on the patron entry form: 1. clear_entry(): With ExtendedPatronAttributes enabled, the "Clear" link next to any attribute form field should work to clear the field. 2. clone_entry(): With ExtendedPatronAttributes enabled and a repeatable attribute defined, it should be possible to click the "New" link to add another instance of that attribute's entry field. 3. update_category_code(): With ExtendedPatronAttributes enabled and an attribute defined which is limited to a single patron category, changing the patron category selection should correctly show or hide the attribute entry form. 4. select_user(): When adding or editing a patron with a "Child" category it should be possible to search for and select a guarantor to add to the record by clicking the "Set to patron" button. Selecting a new guarantor should change the text of the button from "Set to patron" to "Change." 5. noEnterSubmit(): This function should be correctly preventing you from hitting "ENTER" in any form field to submit the form. 6. guarantordelete(): When adding or editing a patron with a "Child" category, it should be possible to clear existing guarantor information by clicking the "Delete" button. Clicking the "Delete" button should change the text of the adjacent button to "Set to patron." 7. select_city(): With one or more cities defined it should be possible to use the drop-down menu of cities to populate the city, state, zip, and country fields. 8. Date of birth entry should have a maximum date limit of yesterday. The drop-down menu of years should go back 100 years. 9. Selecting a date of birth should replace the date format hint with a message showing the user's age in years or months. Test with values which will show an age of 1 month, between 2 and 11 months, 1 year, and more than one year. 10. Client-side validation rules should be in effect, requiring that a valid email address be entered in the primary email, secondary email, and alternate address email fields. 11.When editing a patron, the "Add manual restriction" link should display the form for adding a manual restriction, and clicking the "Cancel" link should hide it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16228] Move some patron entry form JavaScript into members.js again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16228 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14974] Use the REST API for cities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 --- Comment #10 from Olli-Antti Kivilahti --- Facebook uses Flux. That is interesting and very lightweight. AngularJS is big and needs non-standard html element attributes. I would prefer to not have non-standard html attributes or even data-* attributes unless necessary. Also worried about AngularJS being too one-minded in how to do things. That can be a good thing as well. Especially for a project like Koha where we have a lot of developers from around the world doing things their way. Having a good formal development pattern helps a lot. I am 40% for AngularJS, maybe even 50% if I look really hard :) I think most of the guys feeling for REST API and javascript frameworks are here, so I think it s safe to ask how do you feel about AngularJS? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Lari Taskula changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |la...@student.uef.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 Lari Taskula changed: What|Removed |Added Blocks||16223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 [Bug 16223] Automatically remove any borrower debarments after a payment -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 --- Comment #1 from Lari Taskula --- Created attachment 50078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50078&action=edit Bug 16223: Automatically remove any borrower debarments after a payment Some libraries debar Patrons at the end of the year for having unpaid fines, like in Bug 15157. Currently librarians have to manually remove this type of debarments after Patron has paid his/her fines. Add a system preference to define debarments that should be automatically removed after a payment is made, and add functionality to actually remove the defined debarments from Patron. Also let libraries to define the amount of outstanding fines after payment after which the debarment will be removed. This patch introduces a system preference DebarmentsToLiftAfterPayment, which allows libraries to define rules for removing debarments after paying fines. The system preference uses YAML and is defined as follows: Debarment with this comments will be removed: outstanding: 5 Which means that if a Patron has a debarment "Debarment with this comment will be removed", and he pays his fines and charges until his outstanding fees are equal or less than 5.00, this debarment will be lifted. The parameter outstanding is optional - if not given, the debarment will be lifted until Patron has paid all of his outstanding fees (in other words, equal to "outstanding: 0"). To test: 1. Set a debarment to a Patron 2. Set a fine for Patron 3. Define rule(s) for removing debarment(s) in system preference DebarmentsToLiftAfterPayment 4. Pay the fine you set in step 2 5. Note that the debarment is now lifted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Lari Taskula changed: What|Removed |Added Depends on||14698 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698 [Bug 14698] AtomicUpdater - Keeps track of which updates have been applied to a database -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16229] Koha::Cache should be on the safe side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229 Jonathan Druart changed: What|Removed |Added Summary|Koha::Cache should be on|Koha::Cache should be on |the safer side |the safe side -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221 --- Comment #6 from Jonathan Druart --- Created attachment 50077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50077&action=edit Bug 16221: follow-up for changes made by bug 16229 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16229] Koha::Cache should be on the safer side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229 Jonathan Druart changed: What|Removed |Added Attachment #50074|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 50076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50076&action=edit Bug 16229: Add the unsafe flag to set_in_cache Could be useful later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #8 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What|Removed |Added Attachment #48107|0 |1 is obsolete|| --- Comment #7 from Julian Maurice --- Created attachment 50075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50075&action=edit Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16229] Koha::Cache should be on the safer side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16229] Koha::Cache should be on the safer side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229 --- Comment #2 from Jonathan Druart --- Created attachment 50073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50073&action=edit Bug 16229: Deep copy on setting in cache Koha::Cache->set_in_cache should deep copy (if needed) to avoid the value which has been set in cache to be unintentionally modified later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16229] Koha::Cache should be on the safer side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229 --- Comment #3 from Jonathan Druart --- Created attachment 50074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50074&action=edit Bug 16229: Add the unsafe flag to set_in_cache Could be useful later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16229] Koha::Cache should be on the safer side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229 --- Comment #1 from Jonathan Druart --- Created attachment 50072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50072&action=edit Bug 16229: Deep copy on first L2 fetch When a value exists in L2 cache but not in L1 cache, it should be deep copied if needed (i.e. not a scalar). Otherwise the calling code is able to modify the value in cache. Note that is theoretical, it's possible that no code does that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221 Jonathan Druart changed: What|Removed |Added Depends on||16229 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229 [Bug 16229] Koha::Cache should be on the safer side -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Benjamin Rokseth changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from Benjamin Rokseth --- Fails in intra on placing any number of holds with: /cgi-bin/koha/reserve/placerequest.pl DBIx::Class::Storage::DBI::_dbh_execute(): Column 'biblionumber' cannot be null at /kohadev/kohaclone/Koha/Object.pm line 109 I notice that in the request, param multi_holds is not present -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16229] New: Koha::Cache should be on the safer side
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229 Bug ID: 16229 Summary: Koha::Cache should be on the safer side Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 16044 Blocks: 16221 Theoretically our Koha::Cache is not as safe as possible, the set_in_cache and get_from_cache subroutines should always clone the structure to avoid uncontrollable behaviors. There are, at least, 2 issues to cover: - get_from_cache does not deep copy on first call - set_in_cache does not deep copy Note that bug 16221 plans to replace Clone::clone with Storable::dclone, it should be built on top of this patch. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 [Bug 16044] Define a L1 cache for all objects set in cache https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221 [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16044] Define a L1 cache for all objects set in cache
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16044 Jonathan Druart changed: What|Removed |Added Blocks||16229 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16229 [Bug 16229] Koha::Cache should be on the safer side -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906 Alex Sassmannshausen changed: What|Removed |Added Attachment #30681|0 |1 is obsolete|| --- Comment #20 from Alex Sassmannshausen --- Created attachment 50071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50071&action=edit Revised, reworked implementation (Koha::Objects, better granularity) This is a pretty comprehensive rewrite including all feedback previously passed to it. It also makes use of Koha::Objects (which is why it depends on the above objects patches. Let me know if you spot any problems! Alex -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16195] Add Koha::Categories objects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16195 Alex Sassmannshausen changed: What|Removed |Added Attachment #49861|0 |1 is obsolete|| CC||alex.sassmannshausen@ptfs-e ||urope.com --- Comment #3 from Alex Sassmannshausen --- Created attachment 50070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50070&action=edit Revised patch with unit tests. Unit tests included as requested — let me know if that is not what you meant; I took inspiration from t/Patron.t. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Benjamin Rokseth changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #93 from Benjamin Rokseth --- Seems checkout breaks after: Bug 14695 [QA Followup] - Fix clearing of all holds by patron at checkout trying to update/insert duplicate reserve_ids DBD::mysql::st execute failed: Duplicate entry '21' for key 'PRIMARY [for Statement "INSERT INTO `reserves` checking out only until: Bug 14695 [QA Followup] - Make existing unit tests pass makes tests pass and checkout work again -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16228 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15692] Move some patron entry form JavaScript into members.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15692 Owen Leonard changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16228 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16228] New: Move some patron entry form JavaScript into members.js again
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16228 Bug ID: 16228 Summary: Move some patron entry form JavaScript into members.js again Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: bren...@bywatersolutions.com, julian.maur...@biblibre.com, testo...@bugs.koha-community.org, ve...@veron.ch Bug 15206 undid the changes Bug 15692 made to memberentrygen.tt. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221 --- Comment #5 from Jonathan Druart --- (In reply to Jacek Ablewicz from comment #4) > (In reply to Jacek Ablewicz from comment #3) > > > after Bug 16044, cache fetches are NOT safe in the current master - > > even if there are no "unsafe => 1" parameters used anywhere in the code > > currently, because issue 1) mentioned in Bug 16044 comment #20 wasn't > > resolved before 16044 got to master (unless I'm very much mistaken ?). > > And, after a closer look at the code from Bug 16044: this may be even a > bigger issue, it doesn't affect just set_in_cache() calls. First > get_from_cache(given_key) call in the script run is also implicitly unsafe > in the current master, never mind if the 'unsafe => 1' parameter was given > or not. I am on it, I will submit a patch soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221 --- Comment #4 from Jacek Ablewicz --- (In reply to Jacek Ablewicz from comment #3) > after Bug 16044, cache fetches are NOT safe in the current master - > even if there are no "unsafe => 1" parameters used anywhere in the code > currently, because issue 1) mentioned in Bug 16044 comment #20 wasn't > resolved before 16044 got to master (unless I'm very much mistaken ?). And, after a closer look at the code from Bug 16044: this may be even a bigger issue, it doesn't affect just set_in_cache() calls. First get_from_cache(given_key) call in the script run is also implicitly unsafe in the current master, never mind if the 'unsafe => 1' parameter was given or not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Benjamin Rokseth changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||benjamin.roks...@kul.oslo.k ||ommune.no --- Comment #8 from Benjamin Rokseth --- Rebased against master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Benjamin Rokseth changed: What|Removed |Added Attachment #47551|0 |1 is obsolete|| --- Comment #6 from Benjamin Rokseth --- Created attachment 50068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50068&action=edit Bz 15565 - Place multiple holds at once for the same record on staff and OPAC. >From staff interface, place several item-level holds for the same user on the same record at once: - check that you are warned if you exceed "Holds per record (count)" (circulation rules) for this record, - check also maxReserves system preference. >From opac, place several item-level and record level holds for the same user on the same record at once: - check that can't exceed "Holds per record (count)" for this record, - check also maxReserves system preference. Do the same in OPAC and staff by selecting several record (multi-hold). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Benjamin Rokseth changed: What|Removed |Added Attachment #47552|0 |1 is obsolete|| --- Comment #7 from Benjamin Rokseth --- Created attachment 50069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50069&action=edit Bz 15565 - CSS changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16221] Use Storable::dclone() instead of Clone::clone() for L1 cache deep-copying mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16221 --- Comment #3 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #2) > Jacek, > Bug 16166 looks fine by me. Are you suggesting to drop it? No, not necessarily anyway. I just thought that it would be interesting to find out what are the exact causes of the speed improvements Bug 16166 provides: 1) different cloning method or 2) cache architectural changes. Turns out, both 1) and 2) are beneficial performance-wise, but 1) is much bigger factor. I still think Bug 16166 may be a better solution, especially in the long term. When applied on top of Bug 16221, it would improve cache speed somehow further, and it provides one additional important feature (separating "safe" and "unsafe" cache fetches, so they don't interfere with each other). Note that after Bug 16044, cache fetches are NOT safe in the current master - even if there are no "unsafe => 1" parameters used anywhere in the code currently, because issue 1) mentioned in Bug 16044 comment #20 wasn't resolved before 16044 got to master (unless I'm very much mistaken ?). Trouble with Bug 16166 is that it's one of those architectural changes which are pretty much untestable in any conventional way, and it's not easy to predict what kinds of regressions it may introduce (if any) just by looking at that code. Also, Bug 16166 is a bit of a mess right now, I guess I shoud at least squash patches #1 - #3 to make it more readable. Bug 16221, OTOH, is a trivial follow-up of Bug 16044, it does improve caching performance substantially, and risks that it may cause some regressions are close to nil. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16227] The currencies of vendor and order do not display correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16227 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16227] The currencies of vendor and order do not display correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16227 --- Comment #1 from Jonathan Druart --- Created attachment 50067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50067&action=edit Bug 16227: Fix regression from bug 15084 - select currencies correctly This patch fixes a regression introduced by bug 15084: The currency dropdown lists are not correctly built. The selected currencies are wrong. Test plan: Create a vendor, the selected currencies should be the default one Edit the vendor, the selected currencies should be the ones defined for this vendor Create an order, the selected currency should be the 'List prices' of the vendor Edit an order, the selected currency should be the one defined for this order -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 Jonathan Druart changed: What|Removed |Added Blocks||16227 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16227 [Bug 16227] The currencies of vendor and order do not display correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16227] New: The currencies of vendor and order do not display correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16227 Bug ID: 16227 Summary: The currencies of vendor and order do not display correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Acquisitions Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 15084 >From commit 1538e9ecf47642c4974693ff499c3e95e4d71977 Bug 15084: Replace C4::Budgets::GetCurrencies with Koha::Acquisition::Currencies->search """ Most part of the code here is unnecessary complex. We should selected the currency if it is selected, that's all :) """ Well, it's not hard to change, but the commit was wrong. The expected behaviors are: Create a vendor, the selected currencies should be the default one Edit the vendor, the selected currencies should be the ones defined for this vendor Create an order, the selected currency should be the 'List prices' of the vendor Edit an order, the selected currency should be the one defined for this order Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084 [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Marcel de Rooy changed: What|Removed |Added Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 --- Comment #2 from Marcel de Rooy --- Created attachment 50066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50066&action=edit Bug 16203: Convert item plugins to new style (see bug 10480) Converts item plugins to new style (with builder and launcher). See also bugs 10480 and 13437. The following plugins have been adjusted: barcode_manual.pl barcode.pl callnumber-KU.pl callnumber.pl cn_browser.pl (Added license statement too) dateaccessioned.pl macles.pl stocknumberam123.pl stocknumberAV.pl stocknumber.pl Test plan: Connect the plugin to an item field. Verify that the plugin still works. Signed-off-by: Marcel de Rooy Tested if all plugins compile okay. Ran most of them thru FrameworkPlugin.t. Tested them in the item editor. Note: the form for macles.pl comes up, further hard to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16203] Convert item plugins to new style (see bug 10480)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16203 Marcel de Rooy changed: What|Removed |Added Summary|item plugins|Convert item plugins to new ||style (see bug 10480) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Benjamin Rokseth changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||benjamin.roks...@kul.oslo.k ||ommune.no --- Comment #92 from Benjamin Rokseth --- Rebased to fix t::lib::Mocks::mock_preference conflict Getting failed test though: ok 65 - Bug 14464 - Fine applied after cancelling reserve with charge desired and configured DBD::mysql::st execute failed: Duplicate entry '21' for key 'PRIMARY' [for Statement "INSERT INTO `reserves` ( `biblionumber`, `borrowernumber`, `branchcode`, `cancellationdate`, `expirationdate`, `found`, `itemnumber`, `lowestPriority`, `notificationdate`, `priority`, `reminderdate`, `reserve_id`, `reservedate`, `reservenotes`, `suspend`, `suspend_until`, `timestamp`, `waitingdate`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='1', 1='1', 2='CPL', 3=undef, 4=undef, 5='F', 6=undef, 7='0', 8=undef, 9=0, 10=undef, 11='21', 12='2016-04-08', 13='', 14='0', 15=undef, 16='2016-04-08 10:12:53', 17=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. DBIx::Class::Storage::DBI::_execute(): DBD::mysql::st execute failed: Duplicate entry '21' for key 'PRIMARY' [for Statement "INSERT INTO `reserves` ( `biblionumber`, `borrowernumber`, `branchcode`, `cancellationdate`, `expirationdate`, `found`, `itemnumber`, `lowestPriority`, `notificationdate`, `priority`, `reminderdate`, `reserve_id`, `reservedate`, `reservenotes`, `suspend`, `suspend_until`, `timestamp`, `waitingdate`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0='1', 1='1', 2='CPL', 3=undef, 4=undef, 5='F', 6=undef, 7='0', 8=undef, 9=0, 10=undef, 11='21', 12='2016-04-08', 13='', 14='0', 15=undef, 16='2016-04-08 10:12:53', 17=undef] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1832. at Koha/Object.pm line 109 # Looks like you planned 71 tests but ran 65. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
