[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 --- Comment #19 from Mason James --- > > Same for me, it's not conceivable to call this subroutine for each get of > > the opac main page. > > with a warmed cache table, the GetRecentBibs() sub takes around 10ms on my > old slow VM. 10ms seems acceptable? a small missed point.. the GetRecentBibs() sub is only executed if the Caro syspref is manually enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 --- Comment #18 from Mason James --- (In reply to Jonathan Druart from comment #17) > (In reply to Marcel de Rooy from comment #13) > > On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 2010? > > If there is no further development(?), this might be a risk. > > I can see that as blocker, Mason, would it be easy to update the plugin you > used? hi, yes - its very easy to swap the carousel plugin to anything else i'm happy to change the carousel plugin to whatever people desire > (In reply to Frédéric Demians from comment #14) > > I don't see the advantage of this implementation against Bywater plugin. afaik, the big advantage is that the Bywater plugin can't display an *automated* selection of verified cover-images for recently added items i think for the Bywater plugin, a manual list (report?) would need to be created daily, then each item manually verified for a matching amazon image? > > rather see disadvantages, including ContentFlow.js obsolescence (not updated > > since 2010, when jQuery Flipster used by ByWater plugin is actively > > maintained). Reading the code, I don't understand how GetRecentBibs > > generates > > the list of 'recent' bibs. Why a new table (carousel)? Is it necessary to > > read/re-read this table each time the OPAC main page is loaded? > > Same for me, it's not conceivable to call this subroutine for each get of > the opac main page. with a warmed cache table, the GetRecentBibs() sub takes around 10ms on my old slow VM. 10ms seems acceptable? > Could you please detail what is the purpose of this subroutine? the subroutine returns a list of recently added bibs with verified matching amazon cover images > Why do you need a new table, cache of the image url that's it? yes, thats all - a method of caching the urls is needed for the feature to work at an acceptable speed fyi: i did experiment with memcache - but the speed difference was small/negligible, so i decided upon the convenience of a mysql table instead > Additional comments: > - kohastructure.sql changes are missing thanks, i can do this - no problem > - Amazon lookup should be optional amazon lookups effectively cease (ie: become 0) as the cache table becomes populated so this is probably not needed? (unless i misunderstand your point) > - We have several subroutines in C4::Koha to deal with ISBNs, I am sure you > could reuse thanks for the suggestion, i could use NormalizedISBN() instead > - What are the 150 and 300 hardcoded limits? they are limits to reduce the item list, the values were chosen to give a happy balance of acceptable performance and a good selection of randomised items > - It would be better to use Koha::Object sure, i can do this - no problem > - It would be great to remove all the debug variables, it will ease the > readability i would really prefer to leave the debug/profiling code (should any future problems occur?), i'm happy to tidy/improve the readability of the profiling code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16444] C4::Tags is not plack safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444 Srdjan Jankovic changed: What|Removed |Added Attachment #51244|0 |1 is obsolete|| --- Comment #3 from Srdjan Jankovic --- Created attachment 51373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51373&action=edit [SIGNED-OFF] Bug 16444: Make C4::Tags plack safe C4::Tags use a package variable to cache the pref TagsExternalDictionary, it's not needed and not safe. There is not test plan, just make sure the changes are consistent. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16444] C4::Tags is not plack safe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16444 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #102 from Florent Mara --- This patch has been rebased today. Bug 16426 was backported and fixed. Test plan: 1) Apply this patch. 2) Set dateformat to mm/dd/. (Koha home->Administration->search for dateformat -> select and save) 3) run 'prove t/db_dependent/Koha/Patrons/Import.t' which should result in 2 file handle warnings and 122 tests passing. 4) Run the online importer ( Koha home->tools->Import patrons) Load PatronDataCSV1.csv sample file with default import parameters. It should result in 165 imported records and 835 not imported because they are not in the expected format. 5) Set dateformat to dd/mm/. 6) Run the new command line importer 'perl misc/import_patrons.pl -f ~/Downloads/PatronDataCSV1.csv -c -m 'cardnumber' -v' It should load the remaining 835 entries from the sample file. Import complete: Imported:835 Overwritten: 0 Skipped: 0 Invalid: 165 Total: 1000 7) Optional. Run 'perl misc/import_patrons.pl --help' because you can. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #101 from Florent Mara --- Created attachment 51372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51372&action=edit Patrons sample data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #100 from Florent Mara --- Created attachment 51371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51371&action=edit Bug 12598 - Rebase + backport of 16426 plus fixing 16426 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #51122|0 |1 is obsolete|| --- Comment #99 from Florent Mara --- Created attachment 51370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51370&action=edit Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical date types and header column parsing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #50700|0 |1 is obsolete|| --- Comment #97 from Florent Mara --- Created attachment 51368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51368&action=edit Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #50704|0 |1 is obsolete|| --- Comment #98 from Florent Mara --- Created attachment 51369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51369&action=edit Bug 12598 - Creating objects in misc/import_patrons.pl and tools/import_borrowers.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #50699|0 |1 is obsolete|| --- Comment #96 from Florent Mara --- Created attachment 51367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51367&action=edit Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes package -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #50698|0 |1 is obsolete|| --- Comment #95 from Florent Mara --- Created attachment 51366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51366&action=edit Bug 12598 - Fix merge to master. Backport 3 updates from latest import_borrowers.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #94 from Florent Mara --- Created attachment 51365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51365&action=edit Bug 12598 [QA Followup] * Fix copyright on import_borrowers.pl * Changes -c --csv to -f --file * Adds -c --confirm option * Renames misc/import_borrowers.pl to misc/import_patrons.pl * Restore userid matchpoint option -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #50697|0 |1 is obsolete|| --- Comment #93 from Florent Mara --- Created attachment 51364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51364&action=edit Bug 12598 - Update command line script to use patron import subroutine Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #50696|0 |1 is obsolete|| --- Comment #92 from Florent Mara --- Created attachment 51363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51363&action=edit Bug 12598 - Move importing code to a subroutine Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #50695|0 |1 is obsolete|| --- Comment #91 from Florent Mara --- Created attachment 51362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51362&action=edit Bug 12598 - Tidy import_borrowers.pl Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #51360|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #50694|0 |1 is obsolete|| --- Comment #90 from Florent Mara --- Created attachment 51361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51361&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #50693|0 |1 is obsolete|| --- Comment #89 from Florent Mara --- Created attachment 51360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51360&action=edit Attachment to Bug 12598 - New misc/import_borrowers.pl command line tool Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #51359|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #88 from Florent Mara --- Created attachment 51359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51359&action=edit Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #87 from Florent Mara --- Created attachment 51358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51358&action=edit Attachment to Bug 12598 - New misc/import_borrowers.pl command line tool Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #51358|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 Florent Mara changed: What|Removed |Added Attachment #51357|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #86 from Florent Mara --- Created attachment 51357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51357&action=edit Attachment to Bug 12598 - New misc/import_borrowers.pl command line tool Bug 12598: New misc/import_borrowers.pl command line tool Test Plan: 1) Apply this patch 2) Test importing patrons from command line, options are availble with --help. Signed-off-by: Bernardo Gonzalez Kriegel Tested with minimal csv (cardnumber,surname,firstname,categorycode,branchcode,password,userid) Overwrite does not change category or branch. Patrons are loaded, userid & password works Updated license to GPLv3 No other koha-qa errors. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16426] Import borrowers tool warns for blank and/or existing userids
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16426
Florent Mara changed:
What|Removed |Added
CC||florent.m...@gmail.com
--- Comment #14 from Florent Mara ---
While rebasing bug 12598, I backported this patch and it broke my tests.
(unless I missed something) With this patch, either overwrite_cardnumber is set
to 0 and the duplicate borrower number will be caught as an 'already_in_db'
feedback - before reaching the new code and get to the next input line.
OR overwrite_cardnumber is set to 1 and duplicates are overwritten anyway.
In other words, there does not appear to be any duplicate userid check anymore
with the current code.
In bug 12598, I relocated the new code block above 'if ($borrowernumber) {' to
restore functionality.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #16 from Chris Kirby --- Thanks, Nick. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15801] Move the framework related code to Koha::BiblioFramework[s] - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15801 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Bernardo Gonzalez Kriegel --- Sorry, does not apply again. I promise to test and sign. Applying: Bug 15801: Koha::BiblioFrameworks - Remove C4::Koha::getframeworks fatal: sha1 information is lacking or useless (C4/Koha.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15900] Remove use of recordpayment in ProcessOfflinePayment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15900 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel --- On top of 15895, test fails prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 1/83 Can't locate object method "find" via package "Koha::Borrowers" (perhaps you forgot to load "Koha::Borrowers"?) at /home/bgkriegel/kohaclone/C4/Circulation.pm line 3912. Am I missing something? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Nick Clemens changed: What|Removed |Added Attachment #49940|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #15 from Nick Clemens --- (In reply to Chris Kirby from comment #14) Hi Chris, It looks like maybe you did: git bz attach 9543 HEAD~2 Commits are counted from head, so the last patches are: HEAD HEAD~1 (HEAD~2) (HEAD~3) Two attach the two latest you want to do: git bz attach 9543 HEAD~1^.. I un-obsoleted the original patches and obsoleted the extraneous one. I am leaving as signed off for now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22 (April 2016)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #51350|0 |1 is obsolete|| --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 51356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51356&action=edit [SIGNED-OFF] Bug 16472: Update MARC21 de-DE frameworks to update 22 (April 2016) To test: 1) Start with a fresh database 2) Check mandatory bibliographic and authority files load without problem using the German web installer 3) Check new fields/subfields are ok Signed-off-by: Bernardo Gonzalez Kriegel Not a german speaker but seems right :) File loads without problem. No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Nick Clemens changed: What|Removed |Added Attachment #51346|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22 (April 2016)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Nick Clemens changed: What|Removed |Added Attachment #49939|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16480] Unclosed tag in shelves line 332 on intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480 Bernardo Gonzalez Kriegel changed: What|Removed |Added Severity|enhancement |trivial Patch complexity|--- |Trivial patch CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16480] Unclosed tag in shelves line 332 on intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #51339|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 51355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51355&action=edit [SIGNED-OFF] Bug 16480: Unclosed tag in shelves line 332 on intranet Unclosed tag in shelves line 332 on intranet when translating An error occurred when creating this list./span> This error was introduced by bug 15403 To test: Verify the template in line 332 to see the unclosed tag fixed or follow test plan for bug 15403 Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16480] Unclosed tag in shelves line 332 on intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 --- Comment #1 from Nick Clemens --- Created attachment 51354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51354&action=edit Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet To test: 1 - Create a list in staff client 2 - Set XSLTResultsDisplay to blank 3 - View list, titles don't display 4 - Apply patch 5 - View list, titles display 6 - Set XSLTResultsDisplay to default 7 - View list, titles display as before patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Nick Clemens changed: What|Removed |Added Assignee|gmcha...@gmail.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #14 from Chris Kirby --- Hi Marc and Nick, After signing off on the two patches (and obsoleting yours) I tried to attach my commit, but obviously I screwed up the commit. I'll try to straighten this out, but if you have suggestions let me know. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16484] New: Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Bug ID: 16484 Summary: Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcha...@gmail.com Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Similar to bug 16296 but on the staff side -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16296] Virtualshelves: Using no OPACXSLTResultsDisplay breaks content display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16296 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16484 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16484] Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16296 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Aleisha Amohia changed: What|Removed |Added Attachment #50976|0 |1 is obsolete|| --- Comment #25 from Aleisha Amohia --- Created attachment 51353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51353&action=edit Bug 3669: Moving 'Add a new message' into a pop up box and adding to patron toolbar This patch moves all the code into an include which can be accessed from the 'Add a new message' link or the patron toolbar. EDIT: Ensuring modal opens on all pages EDIT2: Once the form has been submitted the page will redirect to where you submitted the form from. EDIT3: Fixing indentation of member-add-message.inc Ensuring messages save on every page Fill branch Ensure predefined notes appear Form redirects to where it was submitted from, or just the circulation page. EDIT4: Removing the new include file and moving it all into the modal in the toolbar EDIT5: Removing swp file and unnecessary code duplication by utilising plugins EDIT6: Batch checkout fixes EDIT7: Ensure you do not get JS error from Comment 24 (Batch checkout syspref must be turned on) To test: 1) Go to a patron circ page (circ/circulation.pl?borrowernumber=X) 2) Click 'Add a new message' under Messages 3) Confirm this brings up the modal to add a message. Confirm clicking Save saves your message. If it is an OPAC message (for the user), confirm it shows as expected on the OPAC. 4) Click Cancel. Confirm this closes the modal. 5) Click 'Add message' button in toolbar. Complete steps 3 and 4. 6) Confirm the modal opens from all other pages with the members toolbar. Confirm predefined notes shows. circ/circulation.pl members/moremember.pl members/routing-lists.pl members/statistics.pl members/boraccount.pl members/pay.pl members/maninvoice.pl members/mancredit.pl members/readingrec.pl members/notices.pl members/member-flags.pl members/member-password.pl members/paycollect.pl members/files.pl turn on BatchCheckouts syspref and put in appropriate patron category circ/circulation.pl?borrowernumber=X&batch=1 7) Confirm that the page redirects to where you submitted the form from once you have submitted it. 8) Go to Check Out tab and confirm your message saved (or OPAC, wherever you saved it) Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3669] Create a template for circ/add_message.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3669 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16481] Report menu has unexpected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481 Aleisha Amohia changed: What|Removed |Added Attachment #51343|0 |1 is obsolete|| --- Comment #4 from Aleisha Amohia --- Created attachment 51352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51352&action=edit [SIGNED-OFF] Bug 16481 - Report menu has unexpected issues This patch corrects a problem with the reports toolbar include file which can cause a problem with the "duplicate" button. The duplicate button passes the entire report SQL as a URL parameter, but the template variable was not escaped as a URL variable. This patch also adds the "uri" filter to the report name and notes fields just to be safe. To reproduce the bug, create a new SQL report using the SQL in the bug report. When you run the report you should see a broken "Duplicate" button. Apply the patch and run the report again. The duplicate button should look correct and work correctly. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16481] Report menu has unexpected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474 Héctor Eduardo Castro Avalos changed: What|Removed |Added CC||hector.hecax...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16474] Standardize spelling of EDIFACT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16474 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #51312|0 |1 is obsolete|| --- Comment #2 from Héctor Eduardo Castro Avalos --- Created attachment 51351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51351&action=edit [SIGNED-OFF]Bug 16474: Standardize spelling of EDIFACT Some templates use Edifact and edifact. As EDIFACT is an abbreviation, we should spell it like one. To test: - Check templates for occurrences of EDIFACT - acquisitions navigation menu - basket page - basketgroup page - EDIFACT messages page - Verify changes are correct Signed-off-by: Hector Castro Changes are correct -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22 (April 2016)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472 Héctor Eduardo Castro Avalos changed: What|Removed |Added CC||hector.hecax...@gmail.com, ||ve...@veron.ch --- Comment #3 from Héctor Eduardo Castro Avalos --- Add here Marc since he is the most appropriate person to sign-of -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421 --- Comment #2 from Owen Leonard --- > first option being the most flexible, as you can do all 4 with less clicks. I don't think the dropdown menu with the numbers is necessarily the most convenient if you have a lot of holds. For instance, moving hold number 50 up one space would required a lot of scrolling through numbers. I think it could be argued that by moving the arrows into a menu I have taken away the convenience they offer by being visible all the time. At my library we don't monkey with holds priorities much, so I don't use the options in a real-life situation very often. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22 (April 2016)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472 --- Comment #2 from Katrin Fischer --- Created attachment 51350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51350&action=edit Bug 16472: Update MARC21 de-DE frameworks to update 22 (April 2016) To test: 1) Start with a fresh database 2) Check mandatory bibliographic and authority files load without problem using the German web installer 3) Check new fields/subfields are ok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22 (April 2016)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22 (April 2016)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16460] Update MARC21 frameworks to Update No. 22 (April 2016)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460 Katrin Fischer changed: What|Removed |Added Blocks||16472 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472 [Bug 16472] Update MARC21 de-DE frameworks to Update 22 (April 2016) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16472] Update MARC21 de-DE frameworks to Update 22 (April 2016)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16472 Katrin Fischer changed: What|Removed |Added Depends on||16460 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16460 [Bug 16460] Update MARC21 frameworks to Update No. 22 (April 2016) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Chris Cormack changed: What|Removed |Added Attachment #44283|0 |1 is obsolete|| --- Comment #24 from Chris Cormack --- Created attachment 51348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51348&action=edit Bug 11144: Fix sequence of cronjobs: automatic renewal - fines - overdue notices The patch changes the sequence of cronjobs in the crontab example file and in the cron.daily file of the packages. This is why: 1) Renew automatically ... only when we can't renew, we want to 2) Calculate fines ... once the fine are calculated and charged we can print the amount into the 3) Overdue notices Before the change it could happen that you'd charge for an item, that would then be renewed. Or that you'd try to print fine amounts into the overdue notices, when they would only be charged moments later. To test: - configure your system so you have items that should - be charged with fines - renew automatically - configure your crontabs according to the example file or switch the cron.daily in your package installation with the new one - configure your overdue notices so that one should be generated <> - Wait for the cronjobs or schedule them to run earlier - Verify all is well and as it should be Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11144] Fix sequence of cronjobs: automatic renewal - fines - overdue notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11144 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 --- Comment #13 from Chris Kirby --- Created attachment 51346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51346&action=edit Bug 16390: Accounts.t does not need MPL This test fails if you do not have a MPL branch, but a closer look shows that we only need to replace one occurrence. Test plan: Run Accounts.t Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13153] Waiting hold checked in at different library doesn't re-route item to correct library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13153 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Chris Kirby changed: What|Removed |Added Attachment #49939|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Chris Kirby changed: What|Removed |Added Attachment #49940|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16483] New: Ampersand breaks search for analytics
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16483 Bug ID: 16483 Summary: Ampersand breaks search for analytics Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: mag...@libriotech.no QA Contact: testo...@bugs.koha-community.org A customer has reported the following problem: A journal is catalogued with separate records for each issue. The journal has an ampersand in the title, let's call it "This & that". Each issue has 245$a like "This & that 2011-1", "This & that 2011-2" and so on. For each issue, there are analytical records. Now, when you are on the detail view of one of the issues in the staff client (/cgi-bin/koha/catalogue/detail.pl?biblionumber=12657) and click on "Show analytics", you get results from all issues of the journal, not just the one you wanted. The URL you are taken to looks like this: /cgi-bin/koha/catalogue/search.pl?q=Host-item:This & that 2011-3. Above the search results it says: 14 result(s) found for 'Host-item:This ' in MyLibrary Catalog. Note that the title has been cut before the ampersand. It is possible to tweak the search URL (remove the ampersand) and get the expected results. Changing the URL to this: /cgi-bin/koha/catalogue/search.pl?q=Host-item:This that 2011-3. gives this: 8 result(s) found for 'Host-item:This that 2011-3.' in MyLibrary Catalog. The same thing happens in the OPAC. I guess a workaround will be to enable UseControlNumber and follow the descriptions here: https://wiki.koha-community.org/wiki/Analytics -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9543] Show patrons messaging subscription on holds notification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9543 Chris Kirby changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #12 from Chris Kirby --- -Applied patches - Made sure that SMS driver and TalkingTech sysprefs are defined to enable SMS and Phone preferences for users (SMS driver can be a dummy value). - Placed a hold for a patron - Set patron's messaging preferences to different choices (including none) - Check in the item that is on hold (it has not to be checked out for the test - Verified that below the message "Hold found (item is already waiting") an information appears about the patron's messaging preferences. --Message (notification preference) only appears where a transfer is not required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16482] Check-in page: Display can be broken in translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16482 Marc Véron changed: What|Removed |Added Attachment #51345|Screenshot English and |Screenshot English and description|GErman with broken display |German with broken display -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16479] SIP should send separate AF message for send_patron_home_library_in_af
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16479 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Summary|SIP shoudl send separate AF |SIP should send separate AF |message for |message for |send_patron_home_library_in |send_patron_home_library_in |_af |_af -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16464] If a patron has been discharged, show a message in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Marc Véron changed: What|Removed |Added Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16482] New: Check-in page: Display can be broken in translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16482 Bug ID: 16482 Summary: Check-in page: Display can be broken in translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: ve...@veron.ch QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 51345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51345&action=edit Screenshot English and GErman with broken display On the check-in page, if the translated strings are longer than the English strings, the form controls display is broken. See screenshot. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16477] Improve staff client cart JavaScript and template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477 --- Comment #1 from Owen Leonard --- Created attachment 51344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51344&action=edit Bug 16477 - Improve staff client cart JavaScript and template This patch makes several changes to the cart JavaScript and template. In the template: - Remove "onclick" attributes in favor of defining events in the JavaScript. - Add a [% BLOCK %] section for some repeated markup. - Add some Font Awesome icons (I didn't add icons to all controls because I thought it looked cluttered). - Move the batch modification control out of the toolbar and into the group of controls which affects selected records. I think this is a logical grouping, and makes more sense than having a drop-down menu in the toolbar with a single menu item. JavaScript: - Created separate "cart.js" file so that JS could be moved out of the template without loading up basket.js with event functions which are not needed on every page in the staff client. - Fix JSHint errors. To test, apply the patch and clear your browser cache if necessary. - Add multiple items to the cart in the staff client and open the cart. - Confirm correct functionality of these toolbar buttons: - "More details" (and the corresponding "Show less") - "Send" - "Print" - "Empty and close" - Confirm the correct functionality of all the selection controls: Select all, clear all, Remove, Add to a list, Place hold, Batch modify, and Batch delete. - Confirm that clicking any title in the cart opens the correct detail page in the parent window. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16477] Improve staff client cart JavaScript and template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16477 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16440] Update report parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #1 from Magnus Enger --- Sounds like a really good idea! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16466] Patron discharge page should show pending requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16466 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16464] If a patron has been discharged, show a message in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16463] OPAC discharge page should warn the user about checkouts before they request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14250] can generate discharge for patron with fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16481] Report menu has unexpected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481 --- Comment #3 from Owen Leonard --- Created attachment 51343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51343&action=edit Bug 16481 - Report menu has unexpected issues This patch corrects a problem with the reports toolbar include file which can cause a problem with the "duplicate" button. The duplicate button passes the entire report SQL as a URL parameter, but the template variable was not escaped as a URL variable. This patch also adds the "uri" filter to the report name and notes fields just to be safe. To reproduce the bug, create a new SQL report using the SQL in the bug report. When you run the report you should see a broken "Duplicate" button. Apply the patch and run the report again. The duplicate button should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16481] Report menu has unexpected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16481] Report menu has unexpected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |oleon...@myacpl.org Version|3.22|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16478] Translation breaks display of Checkout history in tab Checkouts / On-site-checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16478] Translation breaks display of Checkout history in tab Checkouts / On-site-checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Marc Véron changed: What|Removed |Added Attachment #51338|0 |1 is obsolete|| --- Comment #5 from Marc Véron --- Created attachment 51342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51342&action=edit Bug 16478: Fix checkout history tabs - intranet Test plan: Same as before for the intranet. And please retest the OPAC => I have changed the filter's values to match OPAC/intranet Signed-off-by: Jonathan Druart Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16481] Report menu has unexpected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481 --- Comment #2 from Christopher Brannon --- Created attachment 51341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51341&action=edit Snapshot of good menu (how it should look) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16481] Report menu has unexpected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481 --- Comment #1 from Christopher Brannon --- Created attachment 51340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51340&action=edit Snapshot of menu failure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16480] Unclosed tag in shelves line 332 on intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480 Héctor Eduardo Castro Avalos changed: What|Removed |Added Depends on||15403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403 [Bug 15403] Confirm messages in intranet lists interface strangely worded -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15403] Confirm messages in intranet lists interface strangely worded
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15403 Héctor Eduardo Castro Avalos changed: What|Removed |Added Blocks||16480 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480 [Bug 16480] Unclosed tag in shelves line 332 on intranet -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15421] Show all available actions in reports toolbar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421 Christopher Brannon changed: What|Removed |Added Blocks||16481 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481 [Bug 16481] Report menu has unexpected issues -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16481] Report menu has unexpected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481 Christopher Brannon changed: What|Removed |Added Depends on||15421 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421 [Bug 15421] Show all available actions in reports toolbar -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16480] Unclosed tag in shelves line 332 on intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480 Héctor Eduardo Castro Avalos changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16480] Unclosed tag in shelves line 332 on intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480 --- Comment #1 from Héctor Eduardo Castro Avalos --- Created attachment 51339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51339&action=edit Bug 16480: Unclosed tag in shelves line 332 on intranet Unclosed tag in shelves line 332 on intranet when translating An error occurred when creating this list./span> This error was introduced by bug 15403 To test: Verify the template in line 332 to see the unclosed tag fixed or follow test plan for bug 15403 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16481] New: Report menu has unexpected issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16481
Bug ID: 16481
Summary: Report menu has unexpected issues
Change sponsored?: ---
Product: Koha
Version: 3.22
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Reports
Assignee: gmcha...@gmail.com
Reporter: cbran...@cdalibrary.org
QA Contact: testo...@bugs.koha-community.org
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421 introduced a
feature that is a little buggy. The menu is altered by some reports. I will
attach some examples shortly.
Basically, the new menu in Koha 3.22.6 added the ability to duplicate the
report from within the report, not just on the report listing table. However,
some of our reports are causing the menu to be altered. Here is one of our
reports that causes the failure:
SELECT CONCAT_WS(' ',authorised_values.lib,av2.lib) AS
'Status',reserves.reservenotes AS Notes,concat(biblio.title, '
',ExtractValue(bi.marcxml, '//datafield[@tag="245"]/subfield[@code="b"]')) AS
'Title',biblio.author AS 'Author',items.location AS
'Location',items.itemcallnumber AS 'Call Number',items.barcode AS
'Barcode',CONCAT_WS(', ',borrowers.surname,borrowers.firstname) AS
'Patron',reserves.branchcode AS 'Send To',reserves.reservedate AS
'Date',if(reserves.itemnumber IS NULL,'Next Available','Item Level') AS
'Type',Date(Now()) AS 'Report Date'
FROM (reserves INNER JOIN biblio ON reserves.biblionumber =
biblio.biblionumber)
INNER JOIN borrowers ON reserves.borrowernumber =
borrowers.borrowernumber)
INNER JOIN items ON biblio.biblionumber = items.biblionumber)
LEFT JOIN biblioitems bi ON (biblio.biblionumber=bi.biblionumber)
LEFT JOIN hold_fill_targets ON (reserves.biblionumber =
hold_fill_targets.biblionumber)
AND (reserves.borrowernumber = hold_fill_targets.borrowernumber))
LEFT JOIN branchtransfers ON items.itemnumber =
branchtransfers.itemnumber)
LEFT JOIN authorised_values ON items.itemlost =
authorised_values.authorised_value
LEFT JOIN authorised_values av2 ON items.damaged =
av2.authorised_value
WHERE (((authorised_values.category)="LOST") AND reserves.suspend=0
And ((av2.category="DAMAGED"))
And ((reserves.reservedate)<=now())
And ((reserves.waitingdate) Is Null)
And ((reserves.priority)=1)
And ((items.itemnumber NOT IN (SELECT itemnumber FROM reserves WHERE
itemnumber=items.itemnumber AND found IS NOT NULL)))
And ((items.notforloan)=0)
And ((items.damaged)=0)
And ((items.itemlost)=0)
And ((items.withdrawn)=0)
And ((items.onloan) Is Null)
And ((reserves.itemnumber) Is Not Null
And (reserves.itemnumber)=items.itemnumber)
And ((items.itype)<>"REF")
And ((hold_fill_targets.itemnumber) Is Null))
Or (((authorised_values.category)="LOST")
And ((av2.category="DAMAGED"))
And ((hold_fill_targets.itemnumber)=items.itemnumber))
And ((reserves.found) IS NULL) AND reserves.suspend=0
GROUP BY items.holdingbranch, items.itemcallnumber, items.enumchron,
biblio.author, biblio.title, items.barcode, reserves.branchcode
HAVING items.holdingbranch=<>
And Count(branchtransfers.datesent)=Count(branchtransfers.datearrived)
ORDER BY items.location, items.itemcallnumber, items.enumchron,
biblio.author, biblio.title ASC
Christopher
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16480] New: Unclosed tag in shelves line 332 on intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16480 Bug ID: 16480 Summary: Unclosed tag in shelves line 332 on intranet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: hector.hecax...@gmail.com Reporter: hector.hecax...@gmail.com QA Contact: testo...@bugs.koha-community.org Unclosed tag in shelves line 332 on intranet when translating >An error occurred when creating this list./span> -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16479 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16479] SIP shoudl send separate AF message for send_patron_home_library_in_af
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16479 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=13871 Priority|P5 - low|P3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16479] New: SIP shoudl send separate AF message for send_patron_home_library_in_af
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16479 Bug ID: 16479 Summary: SIP shoudl send separate AF message for send_patron_home_library_in_af Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Bug 13871 changed the way patron branchcode is sent in the SIP message. Instead of a separate AF the branchcode is now sent concatenated to the message by " -- " This is causing issues for libraries who use the separate field to track statistics. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871 --- Comment #53 from Katrin Fischer --- Hi Nick, can you please open a new bug linked to this one? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15816] Timeout login redirects to home page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15816
--- Comment #12 from Jesse Weaver ---
(In reply to Jonathan Druart from comment #10)
> Comment on attachment 51323 [details] [review]
> Bug 15816: Redirect back to correct page after login
>
> Review of attachment 51323 [details] [review]:
> -
>
> ::: C4/Auth.pm
> @@ +2055,5 @@
> > +
> > +sub _get_script_name {
> > +# This is the method about.pl uses to detect Plack; now that two
> > places use it, it MUST be
> > +# right.
> > +if ( ( any { /(^psgi\.|^plack\.)/i } keys %ENV ) && $ENV{SCRIPT_NAME}
> > =~ m,^/(intranet|opac)(.*), ) {
>
> Jesse, why do we need to parse SCRIPT_NAME?
This is to make sure that we're not needlessly applying the fix; a local
testing setup with plackup and (I think) the multi-host work on bug 15562 don't
need this fix.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16478] Translation breaks display of Checkout history in tab Checkouts / On-site-checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Jonathan Druart changed: What|Removed |Added Attachment #51336|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 51337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51337&action=edit Bug 16478: Translation breaks display of Checkout history in tab Checks / On-site-checkouts To test: - Make sure that syspref OnsiteCheckouts is enabled - Log in to OPAC as a patron who has checkouts, online checkouts and checkout history enabled - Go to 'your reading history' (in English) - Display all three tabs - Apply patch - Reload page, display oll three tabs again, there should be no difference - Examine source code changes to verify that the words 'checkout' and 'onsite' no longer will be exposed to translation. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16478] Translation breaks display of Checkout history in tab Checkouts / On-site-checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 --- Comment #4 from Jonathan Druart --- Created attachment 51338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51338&action=edit Bug 16478: Fix checkout history tabs - intranet Test plan: Same as before for the intranet. And please retest the OPAC => I have changed the filter's values to match OPAC/intranet Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16478] Translation breaks display of Checkout history in tab Checkouts / On-site-checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16478 Marc Véron changed: What|Removed |Added Summary|Translation breaks display |Translation breaks display |of Checkout history in tab |of Checkout history in tab |Checks / On-site-checkouts |Checkouts / ||On-site-checkouts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
