[Koha-bugs] [Bug 16540] New: Translatability in opac-auth.tt (tag-isolated word 'Logout')

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16540

Bug ID: 16540
   Summary: Translatability in opac-auth.tt (tag-isolated word
'Logout')
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

In opac-auth.tt, the sentence 'Logout and try with a different user' is
splitted by a-tags. It is difficult to determine the translation of the
isolated word 'Logout' (e.g. in German: 'Abmeldung' or 'Abmelden' or 'Melden
Sie sich ab')

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10517] kohe-restore fails to create mysqluser@mysql_hostname so zebra update fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10517

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #4 from Mason James  ---
any chance a new patch could be added in a diff/patch format?

 https://en.wikipedia.org/wiki/Diff_utility

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16291] koha-remove --purge should also delete '/etc/koha/sites/$instance' dir

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16291

--- Comment #1 from Mason James  ---
*** Bug 13902 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13902] Add --force option to koha-create and koha-remove commands

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13902

Mason James  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #3 from Mason James  ---


*** This bug has been marked as a duplicate of bug 16291 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13902] Add --force option to koha-create and koha-remove commands

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13902

--- Comment #2 from Mason James  ---
(In reply to Mason James from comment #1)
> (In reply to Mason James from comment #0)
> > Add --force option to koha-create and koha-remove commands
> 
> hmm, i had an interesting experience related to this BZ...
> 
> 
> a koha-remove failed to delete a /etc/koha/sites/aaa1 dir, as the dir
> contained an unexpected foo.backup file
> 
> on a reboot, the /etc/init.d/koha-common script then failed to run
> koha-create-dirs on all other koha instances alphabetically after 'aaa1'
> 
> this caused zebrasrv to fail on all following instances?!

this BZ is basically a dupe of bug 16291

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16410] koha-remove should optionally remove an instance's database and db-user

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16410

Mason James  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|NEW |RESOLVED

--- Comment #1 from Mason James  ---
(In reply to Mason James from comment #0)
> It would be useful if koha-remove optionally removed an instance's database
> and db-user
> 
> more info to come...

well, koha-remove already does this :0)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15538] Use Koha::Logger in longoverdue.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15538

Florent Mara  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #6 from Florent Mara  ---
Applied the following SQL to create a long overdue item and got the expected
log print out in stdout.

INSERT INTO biblio(frameworkcode, datecreated) values ('allo', '2016-05-17');
INSERT INTO biblioitems(biblionumber, volume) value ((SELECT biblionumber FROM
biblio WHERE frameworkcode = 'allo'), 'blah');
INSERT INTO items(biblionumber, biblioitemnumber, barcode) values (1, (SELECT
biblioitemnumber FROM biblioitems WHERE volume = 'blah'), 'barcode');
INSERT INTO items(biblionumber, biblioitemnumber, barcode) values (1, (SELECT
biblioitemnumber FROM biblioitems WHERE volume = 'blah'), 'latecode');
INSERT INTO borrowers(surname, address, city, branchcode, categorycode) values
('surname', 'address', 'city', 'CPL', 'B');


INSERT INTO issues (borrowernumber, itemnumber, date_due) values (
(SELECT borrowernumber FROM borrowers WHERE surname = 'surname'), 
(SELECT itemnumber FROM items WHERE barcode = 'barcode'), '2016-05-17'); 

INSERT INTO issues (borrowernumber, itemnumber, date_due) values (
(SELECT borrowernumber FROM borrowers WHERE surname = 'surname'), 
(SELECT itemnumber FROM items WHERE barcode = 'latecode'), '2015-07-17');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #23 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #22)
> bug 13669 doesn't mention the error - was this the one you were thinking
> about?

The first comment explains the failure.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #22 from Katrin Fischer  ---
bug 13669 doesn't mention the error - was this the one you were thinking about?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #7 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #6)
> (In reply to Tomás Cohen Arazi from comment #5)
> > Hey, where's the patch?
> 
> I've been too busy working on other projects :/. 
> 
> While I might have time to write a patch, I don't have anywhere near the
> time to test it or write a comprehensive test plan for others to use... :/.

If you write a patch, I write regression tests for it :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13669] Webinstaller fails on MySQL 5.6

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13669

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16402

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=13669

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #21 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #20)
> I am trying to install Koha on Ubuntu 16.05 and I can't finish the web
> installer. After the tables are created (and they are), the web installer is
> stuck with this error:
> 
> [Warning] Using a password on the command line interface can be insecure.
> 
> You can't continue to choose the sample data, install the mandatory data
> etc. 
> 
> Leaving this here for now - if needed I can file a new bug report tomorrow.

There's a bug filled for that already, it mentions mysql 5.6

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16402] DB structure cannot be loaded in MySQL 5.7

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16402

--- Comment #20 from Katrin Fischer  ---
I am trying to install Koha on Ubuntu 16.05 and I can't finish the web
installer. After the tables are created (and they are), the web installer is
stuck with this error:

[Warning] Using a password on the command line interface can be insecure.

You can't continue to choose the sample data, install the mandatory data etc. 

Leaving this here for now - if needed I can file a new bug report tomorrow.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

--- Comment #6 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #5)
> Hey, where's the patch?

I've been too busy working on other projects :/. 

While I might have time to write a patch, I don't have anywhere near the time
to test it or write a comprehensive test plan for others to use... :/.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Chris Cormack  changed:

   What|Removed |Added

  Attachment #51587|0   |1
is obsolete||

--- Comment #3 from Chris Cormack  ---
Created attachment 51588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51588=edit
Bug 16539 - Koha::Cache is incorrectly caching single holidays

This makes the loop add holidays for each bracnh instead of the calling
branch

To test:
I used memcached-tools to view the cache, clear the cache, and wait for
holidays to regnerate

Have a branches with different holidays
Clear the cache
Do a checkout
View the cache - one libraries holidays are repeated for all branches
Apply patch
Clear the cache
Do a checkout
Library holidays are correctly cached

Signed-off-by: Kyle M Hall 
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16336] UX of holds patron search with long lists of results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

--- Comment #2 from Owen Leonard  ---
Created attachment 51586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51586=edit
Bug 16336 [Revised] UX of holds patron search with long lists of results

Bug 15793 made a change to an interface which is also found in the place
hold template. This patch creates a new include file to be used by both
circulation.tt and request.tt so that these pages do not diverge.

In the process, this patch removes some markup and JavaScript which was
made obsolete by Bug 15793 and should have been removed.

This patch also revises the sorting of the results table so that the
patron name is sortable (Bug 16334) and the default sort is on card
number (matching 3.20.x and 3.22.x).

To test:

In Circulation:
- Perform a search by name for a patron which will
  return multiple search results.
- The table of results which displays should look correct and work
  correctly, including DataTables sorting.
- Clicking any table row should forward you to the checkout page for
  that patron.

In the catalog:
- Locate and place a hold on a title.
- When prompted to select a patron to place the hold for, perform a
  search by name which will return multiple results.
- Confirm that the table of patron results looks correct and works
  correctly.
- Clicking any table row should forward you to the place hold page for
  that patron and the title you selected.

Revision: Although the table row was clickable, you couldn't
middle-click it to open the link in a new tab. The patron name is now a
real link you can middle-click or right-click. The row is still
clickable as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16336] UX of holds patron search with long lists of results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #51585|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 51587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51587=edit
Bug 16539 - Koha::Cache is incorrectly caching single holidays

This makes the loop add holidays for each bracnh instead of the calling
branch

To test:
I used memcached-tools to view the cache, clear the cache, and wait for
holidays to regnerate

Have a branches with different holidays
Clear the cache
Do a checkout
View the cache - one libraries holidays are repeated for all branches
Apply patch
Clear the cache
Do a checkout
Library holidays are correctly cached

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16539] New: Koha::Cache is incorrectly caching single holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Bug ID: 16539
   Summary: Koha::Cache is incorrectly caching single holidays
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Bug 14522 introduced caching for single_holidays, however, when rebuilding the
cache it is using self->branchcode to populate all of the holidays for the
cache.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Nick Clemens  changed:

   What|Removed |Added

 Blocks||14522
   Priority|P5 - low|P3
   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com
   Severity|enhancement |blocker


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522
[Bug 14522] Use Koha::Cache for accessing single_holidays()
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522

Nick Clemens  changed:

   What|Removed |Added

 Depends on||16539


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539
[Bug 16539] Koha::Cache is incorrectly caching single holidays
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16001] Use standard message dialog when there are no cities to list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16336] UX of holds patron search with long lists of results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

--- Comment #1 from Nick Clemens  ---
Created attachment 51585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51585=edit
Bug 16539 - Koha::Cache is incorrectly caching single holidays

This makes the loop add holidays for each bracnh instead of the calling
branch

To test:
I used memcached-tools to view the cache, clear the cache, and wait for
holidays to regnerate

Have a branches with different holidays
Clear the cache
Do a checkout
View the cache - one libraries holidays are repeated for all branches
Apply patch
Clear the cache
Do a checkout
Library holidays are correctly cached

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16001] Use standard message dialog when there are no cities to list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16001

Owen Leonard  changed:

   What|Removed |Added

  Attachment #48760|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 51584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51584=edit
Bug 16001 - Use standard message dialog when there are no cities to list

If there are no existing cities in Administration -> Cities and Towns,
the message saying so should be in the standard message dialog.

Another minor change: Edit the message to say "There are no cities
defined," which I think reads better in English.

To test you must have no cities and towns defined.

Apply this patch and go to Administration -> Cities and Towns. You
should see a message displayed in a standard "message" style dialog.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16336] UX of holds patron search with long lists of results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51292|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16539] Koha::Cache is incorrectly caching single holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16539

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16538] Improve the style of progress bars

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

--- Comment #2 from Owen Leonard  ---
Created attachment 51583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51583=edit
Bug 16538 - Improve the style of progress bars

This patch updates the style of progress bars to make them a little
nicer. Progress bars in the staff client are not built in a consisten
way. Some have been updated to use the  element and some have
not. This patch improves some styling common to both kinds.

Other changes:

- Redundant in-page CSS has been removed from many pages.
- An invalid "min" attribute has been removed from several instances of
  .
- Corrected capitalization.
- Fixed incorrectly quoted attributes.
- Added missing form "action" attributes.

To test, clear your browser cache if necessary. Apply the patch and
test uploads on the following pages:

- Circulation -> Offline circulation file upload
- Tools -> Batch item modification
- Tools -> Batch record modification
- Tools -> Stage MARC records for import
- Tools -> Manage staged MARC records
- Tools -> Upload local cover image
- Tools -> Upload

In all cases, progress bars should look improved and work correctly.

Test Tools -> Batch item deletion. Unused background job handling markup
has been removed. Deletion processing should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16538] Improve the style of progress bars

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16538] Improve the style of progress bars

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Owen Leonard  changed:

   What|Removed |Added

 Depends on||16529


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529
[Bug 16529] Clean up and improve upload template
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16529] Clean up and improve upload template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16529

Owen Leonard  changed:

   What|Removed |Added

 Blocks||16538


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538
[Bug 16538] Improve the style of progress bars
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16538] Improve the style of progress bars

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

--- Comment #1 from Owen Leonard  ---
Created attachment 51582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51582=edit
Screenshot of a progress bar after the patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16538] New: Improve the style of progress bars

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16538

Bug ID: 16538
   Summary: Improve the style of progress bars
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

Created attachment 51581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51581=edit
Screenshot of a progress bar before the patch

I would like to add some style to progress bars on various pages to make them 
look a little nicer. See attached for before and after screenshots.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #9 from Theodoros Theodoropoulos  ---
The culprit /seems/ to be AllowReturnToBranch.

(Setting it to "Any library" prevents you from getting the error. Setting it to
"Allow materials to be returned to only the library the item is from" produces
the error)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #8 from Theodoros Theodoropoulos  ---
I've tested changing sysprefs in my v3.22.06.005 sandbox and it seems that one
of the following parameters is related to the error!

AutomaticItemReturn: Don't
UseBranchTransferLimits: Enforce library transfer limits based on Item type
IndependentBranches: Don't prevent
AllowReturnToBranch: Allow materials to be returned to only the library the
item is from
AutomaticItemReturn: Don't automatically transfer items to their home library
when they are returned.

@Jonathan, can you please set them in your test installation and verify if you
get the duplicate key error?

...we're getting close...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #10 from Tomás Cohen Arazi  ---
I tested this patches and I verified they correctly make the ENV variables
reach the plack backend. Thus, the OVERRIVE_SYS* work again, and the memcached
variables are correctly set.
To verify the latter, I wrote a small patch that would go to another bug to
display memcached configuration/status in about.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #51496|0   |1
is obsolete||

--- Comment #8 from Tomás Cohen Arazi  ---
Created attachment 51579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51579=edit
Bug 16520: Fix the Apache Plack config to load the main page through Plack

Previously, the ProxyPass would not pass the OPAC/staff homepage to
Plack. This fixes this problem (which is necessary for the other changes
on this bug to show on the main page).

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #51493|0   |1
is obsolete||

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 51576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51576=edit
Bug 16520: Allow per-VirtualHost environment variables with Plack

This allows MEMCACHED_*, OVERRIDE_SYSPREF_* and others to work properly.

Test plan:

  1) Add the following line to your plack.psgi (near the bottom, just
 above "mount ..."):
   enable "+Koha::Middleware::Plack";
  2) Load the OPAC advanced search page (under Plack). The title should
read "Koha online catalog" (or whatever your LibraryName syspref
contains).
  3) Add the following to your Apache configuration:
   RequestHeader add X-Koha-SetEnv "OVERRIDE_SYSPREF_LibraryName Potato\,
Potato"
  4) Restart Apache.
  5) Refresh. The title should now read "Potato, Potato online catalog".

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 51580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51580=edit
Bug 16520: (followup) use __MEMCACHED_NAMESPACE__ where appropriate

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #51495|0   |1
is obsolete||

--- Comment #7 from Tomás Cohen Arazi  ---
Created attachment 51578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51578=edit
Bug 16520: Add new Plack-SetEnv syntax to Apache configuration files

This was not added to the old etc/koha-httpd.conf because that file has
no infrastructure for Plack anyway.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #51494|0   |1
is obsolete||

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 51577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51577=edit
Bug 16520: Initialize the sysprefs Koha::Cache on demand

This is needed so that the cache singleton doesn't get created before
the MEMCACHED_* environment variables are set.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16533] Prep koha-preferences script for /usr/sbin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16533

--- Comment #1 from Jesse Weaver  ---
Given how the instances configuration currently works, I think we'll have to
put a small wrapper around this. That may be as easy as: koha-shell $1 -c
"/usr/share/koha/bin/admin/koha-preferences $@"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16520] Per-virtualhost SetEnvs don't work with Plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16520

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #7 from Theodoros Theodoropoulos  ---
I couldn't reproduce it in a testing environment running v3.22.06.005

But I reproduced it several times in our production/test systems running
v3.20.10
Maybe(?) it's also related to a system preference that we have and/or
patron/item specific value.

(I also created MT18564, I'll give you login details for our test server and
example patron/items for you to play with)

Thank you for your time. Oh, and I forgot to mention that credits also go to
Fridolin Somers for pointing out that we still had items in this status and
identifying them to us. When we first encountered the issue, we fixed it from
Koha GUI. Thinking that it was a one-of issue, we didn't pay much attention to
it until it happened another 2 times in a short period of time.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16536] Warn about Template Toolkit directives inside HTML tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

--- Comment #5 from Jonathan Druart  
---
(In reply to Owen Leonard from comment #4)
> So our coding guideline, "HTML1: Template Toolkit markup inside HTML" is too
> broad?

To avoid translatability  issues, yes.
But if you look at the different places where it is used, it does not ease the
readability. So I think it's good to keep it like that (unless specific cases
where it could be useful) even if we do not have a check to catch them.

Or we could fix all the occurrences and add a new check :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16376] Koha::Calendar->is_holiday date truncation creates fatal errors for TZ America/Santiago

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16376

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #3)
> Ahh, I bet it's truncating it to compare it to "single_holidays" and
> "exception_holidays"... right... that makes sense.
> 
> In that case, before truncating it, I think you have to turn it into a
> "floating" DateTime. 
> 
> Except that we're using the Timezone in single_holidays() and
> exception_holidays()... that's great...
> 
> I think we might need to re-think Koha::Calendar in light of
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

Hey, where's the patch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16536] Warn about Template Toolkit directives inside HTML tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

--- Comment #3 from Jonathan Druart  
---
The "quick hack" is

diff --git a/xt/tt_valid.t b/xt/tt_valid.t
index 7285019..c335bb9 100755
--- a/xt/tt_valid.t
+++ b/xt/tt_valid.t
@@ -46,9 +46,12 @@ my $checkers = [
 description => 'TT syntax: not using TT directive within HTML tag',
 check => sub {
 my ($self, $name, $token) = @_;
+push @{$self->{errors}->{$name}}, $token->{_lc} if exists
$token->{_string} and $token->{_string} =~ m|\[%\s*IF|;
 my $attr = $token->{_attr};
 next unless $attr;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16536] Warn about Template Toolkit directives inside HTML tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

--- Comment #4 from Owen Leonard  ---
So our coding guideline, "HTML1: Template Toolkit markup inside HTML" is too
broad?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148

Owen Leonard  changed:

   What|Removed |Added

  Attachment #49603|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 51575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51575=edit
Bug 16148 - Revised layout and behavior of marc modification template
management

This patch makes changes to the layout and behavior of the marc
modification template management page to make it adhere better to common
interaction patterns in Koha.

- The initial view shows a list of templates rather than pre-selecting
  the first available template for editing.

- A toolbar has been added with a "New template" button.

- The initial view of existing templates has an actions menu containing
  menu items for 'Edit actions,' 'Duplicate,' and 'Delete.' It doesn't
  appear to be possible to edit an existing template's name.

- The "Create template" form is no longer shown all the time.
  - Clicking the "New template" toolbar button triggers a modal with the
form for creating a template. An existing template can be chosen to
duplicate.
  - Choosing "Duplicate" from one of the template menus triggers the
"New template" modal and preselects the corresponding template in
the "duplicate" .

- When editing actions for a template:
  - The breadcrumbs menu now reflects that a template is being modified.
  - The template name has been added as a heading.
  - A "New action" button appears in the toolbar
  - The "Edit" and "Delete" links now have a Bootstrap button style.
  - The add/edit form is now hidden by default.
  - Clicking "New action" or "edit" shows the add or edit form.
  - Clicking "Cancel" in the add/edit form hides the form.

To test, apply the patch and clear your cache if necessary.

- Got to Tools ->  MARC modification templates
- Test the "New template" button.
  - Confirm that new template creation works.
  - Confirm that duplicating a template works.
- Test the menu items in the "Actions" menu:
  - "Duplicate" should trigger the new template modal and preselect the
template you chose to duplicate. Confirm that the template is
successfully duplicated.
  - "Delete" should prompt you to confirm the deletion. Test both
cancelling and confirming this operation.
  - "Edit actions" should load the page for adding or editing actions to
a template. Test the operations on this page: New action, edit,
delete, changing action order.

Note that this patch does not fix Bug 15814, so action descriptions
must still not contain single quotes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16536] Warn about Template Toolkit directives inside HTML tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

--- Comment #2 from Jonathan Druart  
---
Owen, note that the changes made by bug 16525 do not introduce translatable
issues.

With a quick hack to xt/tt_valid.t, I get:
# intranet-tmpl/prog/en/includes/doc-head-close-receipt.inc: 2
# intranet-tmpl/prog/en/includes/doc-head-close.inc: 19
# intranet-tmpl/prog/en/includes/facets.inc: 6, 6, 45
# intranet-tmpl/prog/en/includes/help-top.inc: 4
# intranet-tmpl/prog/en/includes/page-numbers.inc: 3, 4, 6
# intranet-tmpl/prog/en/modules/acqui/basket.tt: 554, 555, 556, 557, 558, 559,
560, 562
# intranet-tmpl/prog/en/modules/acqui/parcels.tt: 132, 138, 142
# intranet-tmpl/prog/en/modules/acqui/transferorder.tt: 125
# intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt: 383
# intranet-tmpl/prog/en/modules/admin/categories.tt: 92
# intranet-tmpl/prog/en/modules/admin/preferences.tt: 121
# intranet-tmpl/prog/en/modules/authorities/authorities.tt: 321
# intranet-tmpl/prog/en/modules/basket/basket.tt: 6
# intranet-tmpl/prog/en/modules/catalogue/subject.tt: 31
# intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt: 437, 629
# intranet-tmpl/prog/en/modules/circ/printslip.tt: 14
# intranet-tmpl/prog/en/modules/circ/waitingreserves.tt: 139
# intranet-tmpl/prog/en/modules/members/moremember-print.tt: 8
# intranet-tmpl/prog/en/modules/members/moremember-receipt.tt: 6
# intranet-tmpl/prog/en/modules/members/printfeercpt.tt: 7
# intranet-tmpl/prog/en/modules/members/printinvoice.tt: 5
# intranet-tmpl/prog/en/modules/reports/stats_screen.tt: 23, 25
# intranet-tmpl/prog/en/modules/reserve/request.tt: 847
# intranet-tmpl/prog/en/modules/suggestion/suggestion.tt: 458, 459
# intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt: 415, 423, 432
# opac-tmpl/bootstrap/en/includes/doc-head-close.inc: 4
# opac-tmpl/bootstrap/en/includes/opac-facets.inc: 9, 11, 54
# opac-tmpl/bootstrap/en/includes/page-numbers.inc: 5, 11, 15
# opac-tmpl/bootstrap/en/includes/shelfbrowser.inc: 39, 41
# opac-tmpl/bootstrap/en/modules/opac-advsearch.tt: 138
# opac-tmpl/bootstrap/en/modules/opac-detail.tt: 427, 429, 437, 439, 448, 450,
459, 461, 965, 967, 1072, 1081
# opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt: 48, 52
# opac-tmpl/bootstrap/en/modules/opac-review.tt: 41
# opac-tmpl/bootstrap/en/modules/opac-showreviews.tt: 8, 82
# opac-tmpl/bootstrap/en/modules/sco/help.tt: 6
# opac-tmpl/bootstrap/en/modules/sco/printslip.tt: 4
# opac-tmpl/bootstrap/en/modules/sco/sco-main.tt: 7

I had a quick look at them and have not seen any problems with them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a translation problem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Lari Taskula  changed:

   What|Removed |Added

  Attachment #51572|0   |1
is obsolete||

--- Comment #5 from Lari Taskula  ---
Created attachment 51574
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51574=edit
Bug 16200: Convert all existing expired holds accounttype to HE

Before Bug 16200 expired holds have used accounttype F which is also used by
other type of fines. This patch updates all existing expired holds to new
accounttype HE (Hold Expired).

To test:
-1. Make sure you translated the string in previous patch of this bug
1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab
2. Change Koha's language to some other than English
3. Observe that "Hold waiting too long" is still in English
4. Apply patch and run database update
5. Go back to Patron's Fines tab
6. Observe that "Hold waiting too long" is now translated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16536] Warn about Template Toolkit directives inside HTML tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

--- Comment #1 from Jonathan Druart  
---
xt/tt_valid.t and the QA tools do not caught this invalid syntax because the TT
tags ([% %]) are inside the value of the attribute (surrounded by quotes).
It could be possible to add a test for the 'selected' attributes, but it would
not be exhaustive.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #6 from Jonathan Druart  
---
Are you able to reproduce the error on a sandbox or using the master branch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16532] Libraries and groups showing empty tables if nothing defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

--- Comment #4 from Owen Leonard  ---
> Even with no libraries defined, "[% IF libraries.size %]" always evaluates
> as true. Why?

Jonathan explained to me in IRC that because "libraries" is an object (from
Koha::Libraries) we should use "count" instead:

[% IF libraries.count %]...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #5 from Jonathan Druart  
---
(In reply to Theodoros Theodoropoulos from comment #4)
> @Jonathan:
> 
> Can you please run:
> SELECT itemnumber,COUNT(*) AS nb FROM issues GROUP BY itemnumber HAVING nb >
> 1;
> 
> If you get any lines, then you DO have the problem. You simple don't get the
> error because you currently don't have the Unique Key constraint in the DB

I have the unique key constraint.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #4 from Theodoros Theodoropoulos  ---
@Jonathan:

Can you please run:
SELECT itemnumber,COUNT(*) AS nb FROM issues GROUP BY itemnumber HAVING nb > 1;

If you get any lines, then you DO have the problem. You simple don't get the
error because you currently don't have the Unique Key constraint in the DB

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a translation problem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Lari Taskula  changed:

   What|Removed |Added

 CC||pasi.kalli...@pttk.fi

--- Comment #4 from Lari Taskula  ---
*** Bug 11387 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11387] "Hold waiting too long" is untranslatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11387

Lari Taskula  changed:

   What|Removed |Added

 CC||la...@student.uef.fi
 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Lari Taskula  ---


*** This bug has been marked as a duplicate of bug 16200 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16508] User permission "parameters_remaining_permissions Remaining system parameters permissions" does not allow saving systempreferences.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
Version|3.22|unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16508] User permission "parameters_remaining_permissions Remaining system parameters permissions" does not allow saving systempreferences.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508

--- Comment #1 from Jonathan Druart  
---
Created attachment 51573
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51573=edit
Bug 16508: Updating a syspref requires parameters_remaining_permissions

And not all of parameters flags.

Test plan:
1/ Create a staff user.
2/ Go to details, select more->set permissions.
3/ Set catalogue, Manage Koha system settings (Administration panel),
manage circulation rules, and Remaining system parameters permissions.
4/ Log in as the new staff user, go to administration > system
preferences. Change a syspref and save it... it will save correctly.
5/ Log back in as superlibrarian
6/ On the 'set permissions' screen, un-check 'manage circulation rules'
and save.
7/ Log back in to the new staff user, and try to change the same
systemprefrence and save.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16508] User permission "parameters_remaining_permissions Remaining system parameters permissions" does not allow saving systempreferences.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16508

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8007] Discharge management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16464


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464
[Bug 16464] If a patron has been discharged, show a message in the OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a translation problem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

--- Comment #3 from Katrin Fischer  ---
Thx Lari!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a translation problem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

--- Comment #2 from Lari Taskula  ---
Created attachment 51572
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51572=edit
Bug 16200: Convert all existing expired holds accounttype to HE

Before Bug 16200 expired holds have used accounttype F which is also used by
other type of fines. This patch updates all existing expired holds to new
accounttype HE (Hold Expired).

To test:
-1. Make sure you translated the string in previous patch of this bug
1. Find a Patron with "Hold waiting too long" fines and go to his Fines tab
2. Change Koha's language to some other than English
3. Observe that "Hold waiting too long" is still in English
4. Apply patch and run database update
5. Go back to Patron's Fines tab
6. Observe that "Hold waiting too long" is now translated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16537] New: Overdue and Status triggers grammar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16537

Bug ID: 16537
   Summary: Overdue and Status triggers grammar
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Documentation
  Assignee: neng...@gmail.com
  Reporter: jza...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

In the Overdue and Status triggers, there is a grammar error. Delay is the
number of days after an checkout is due before an action is triggered.

It should be "a" checkout rather than "an" checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a translation problem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

Lari Taskula  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Owen Leonard  ---
> 4 - Search combined with other terms, results should be returned as
> expected

This step didn't work for me. I found a date of birth which should have
returned two results, "2006-08-09" and searched using the circulation quick
search for that date of birth plus the first name of one of the results,
"2006-08-09 john." No results were found.

Is that how it's supposed to work or do I misunderstand this step?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16200] 'Hold waiting too long' fee has a translation problem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16200

--- Comment #1 from Lari Taskula  ---
Created attachment 51571
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51571=edit
Bug 16200: Make 'Hold waiting too long' translatable and give it an unique
accounttype

Holds that have expired have been untranslatable in Patron's Fines-tab. Also,
they are
mixed with other type of fines with accounttype "F". This patch gives expired
holds an
own accounttype "HE" (Hold Expired) and modifies the boraccount to recognize
this new
accounttype in order to make it translatable.

To test:
1. Make a hold and let it expire
2. Go to Patron's Fines tab
3. Change Koha's language to some other than English
4. Observe that there is a "Hold waiting too long" fine described in English
5. Apply patch
6. Make another hold and let it expire
7. Update translations
8. Find "Hold waiting too long" from your .po file
9. Translate it and install translations
10. Go back to Fines tab and observe that the new expired hold is translated

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16464] If a patron has been discharged, show a message in the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16464

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||8007
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007
[Bug 8007] Discharge management
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8007] Discharge management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16463


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463
[Bug 16463] OPAC discharge page should warn the user about checkouts before
they request
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16463] OPAC discharge page should warn the user about checkouts before they request

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16463

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||8007


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007
[Bug 8007] Discharge management
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16527] Sticky due date calendar unexpected behaviour

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||10067
 CC||ei...@sysmystic.com,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
It seems that it is a regression introduced by bug 10067.

I'd say that the following diff will fix it:

diff --git a/circ/circulation.pl b/circ/circulation.pl
index 66b3dcf..d7fcfbb 100755
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -166,7 +166,7 @@ my $stickyduedate  = $query->param('stickyduedate') ||
$session->param('stickydu
 my $duedatespec= $query->param('duedatespec')   ||
$session->param('stickyduedate');
 $duedatespec = eval { output_pref( { dt => dt_from_string( $duedatespec ),
dateformat => 'iso' }); }
 if ( $duedatespec );
-my $restoreduedatespec  = $query->param('restoreduedatespec') ||
$session->param('stickyduedate') || $duedatespec;
+my $restoreduedatespec  = $query->param('restoreduedatespec') || $duedatespec
|| $session->param('stickyduedate');
 if ($restoreduedatespec eq "highholds_empty") {
 undef $restoreduedatespec;
 }

But I have no idea if it won't break bug 10067.

Eivin, could you have a look please?


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067
[Bug 10067] decreaseLoanHighHolds messes with specify due date
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16527


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527
[Bug 16527] Sticky due date calendar unexpected behaviour
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16536] New: Warn about Template Toolkit directives inside HTML tags

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16536

Bug ID: 16536
   Summary: Warn about Template Toolkit directives inside HTML
tags
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: QA tools
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: oleon...@myacpl.org

I was testing a patch (on Bug 16525) which contained this markup:

Cancel

I expected it to trigger a warning by the QA tools.

My system is a gitified package install, so it seems possible that this is a
problem with my configuration. Running "prove xt" doesn't catch it either.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #3 from Theodoros Theodoropoulos  ---
@Jonathan:

Unfortunately, I cannot reproduce anymore the error for Koha<3.20.06 because we
have upgraded both our test/production servers to 3.20.10.
All I know is that BEFORE the upgrade we had 3 cases where duplicate lines
(with the same itemnumber) were found in issues table. This means an item was
found to be checked out to two different borrowers (at the same time). (I have
a screenshot to prove it for one of them).

After discussing with the librarians, they explained that all they did was they
have checked out an already-checked out item to another patron. They DIDN'T get
any error and the item ended up to be checkout to BOTH patron. 

With 3.20.10 now, the new error that appears means that Circulation.pm TRIES to
create a duplicate line in issues (but fails), so the item is NOT checked out
to the new patron in the end (but it would have been if it wasn't for the new
unique key in the DB).

The correct behavior is the item to be checked in and then checked out to the
new patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16535] New: Add the date on which the suggestion was managed on Purchase suggestions tab

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16535

Bug ID: 16535
   Summary: Add the date on which the suggestion was managed on
Purchase suggestions tab
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Hi,

It would be helpful if the date on wich the suggestion was managed was added on
Purchase suggestions tab on borrower account.

There is just who managed the suggestion.

This can be as like date on table in suggestion.pl

Regards

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16524] Use floating toolbar on item search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Owen Leonard  changed:

   What|Removed |Added

  Attachment #51553|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 51570
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51570=edit
[SIGNED-OFF] Bug 16524: Use floating toolbar on item search

To test:
1) Go to item search
2) Confirm toolbar at top of page with Search button, goes down page as
   you scroll
3) Confirm search button has been removed from final output fieldset
4) Confirm everything works as expected

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16524] Use floating toolbar on item search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16524

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16531] Circ overdues report is showing an empty table if no overdues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16531

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
I think we can improve this page by giving the user more information about why
nothing is displaying. I can think of two cases to plan for:

1. Nothing displays because there are no overdues. By default the overdue
report show anything which is overdue, with no filters applied by default. If
we know we're showing the unfiltered view, we can show a message which says
"There are no overdues."

2. Nothing displays because the user has applied a filter to the results. ( "[%
IF ( isfiltered ) %]" ). In this case we display a message which says something
like, "There are no overdues matching your search." This would also allow us to
display a link to "Reset filter," which is shown without this patch but isn't
with the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #51551|0   |1
is obsolete||

--- Comment #23 from Jonathan Druart  
---
Created attachment 51569
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51569=edit
Bug 16400 [Follow-up] Proposal to uniform the placement of submit buttons

This follow-up makes some corrections to the markup of the cancel
button:

- Use  instead of  to eliminate the need for an "onclick"
  attribute.
- Remove the "cancel" class which adds unwanted padding.
- Correct the destination of the cancel button when cancelling during an
  edit (should redirect to the patron detail page).

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16400] Proposal to uniform the placement of submit buttons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16400

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

Jonathan Druart  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #21 from Jonathan Druart  
---
(In reply to Mason James from comment #20)
> (In reply to Jonathan Druart from comment #17)
> > (In reply to Marcel de Rooy from comment #13)
> > > On http://www.jacksasylum.eu/ContentFlow/ I only see changelogs until 
> > > 2010?
> > > If there is no further development(?), this might be a risk.
> > 
> > I can see that as blocker, Mason, would it be easy to update the plugin you
> > used?
> 
> Jonathan, can you please suggest a replacement for ContentFlow, so I may
> proceed

I have no idea, but reading the previous comment it seems that jcarousel or
jquery-flipster could be good candidates.
Kyle, any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart  
---
I do not reproduce the error with the following steps:
- Check an item (home library is L1) out to Patron P1 (from library L2)
- Check the same item out to patron P2 (from library L3)

Note that I do not use a fresh DB created from 3.20.06, it could make a
difference.

Could you please confirm you do not get any errors in the Koha log file about
the checkin? This error should not appear if the checkin has been correctly
done.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9474] filter overdues with fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9474

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8112] Overdues with Fines report, giving duplicates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8112

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16532] Libraries and groups showing empty tables if nothing defined

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532

--- Comment #3 from Owen Leonard  ---
Can we do the same for libraries?

Even with no libraries defined, "[% IF libraries.size %]" always evaluates as
true. Why?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16525] Have cancel button when adding new aq budget

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16525

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Owen Leonard  ---
This works fine, but the markup needs to be restructured:

Cancel

I thought that this would have triggered a warning by the QA tools because of
coding guideline 'HTML1:'

https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML1:_Template_Toolkit_markup_inside_HTML

It's more verbose, but you have to do it this way:

[% IF ( budget_period_id) %]
Cancel
[% ELSE %]
Cancel
[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978

Theodoros Theodoropoulos  changed:

   What|Removed |Added

 CC||th...@lib.auth.gr
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16534

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Theodoros Theodoropoulos  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14978

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51552|0   |1
is obsolete||

--- Comment #6 from Bernardo Gonzalez Kriegel  ---
Created attachment 51568
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51568=edit
[SIGNED-OFF] Bug 16506: (followup) Fix wrong option switch warning message

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51537|0   |1
is obsolete||

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
Created attachment 51566
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51566=edit
[SIGNED-OFF] Bug 16506: Make rebuild_zebra.pl use XML as default

This patch deprecates the -x switch, making XML the default serialization
format
used by rebuild_zebra.pl. It doesn't remove the option switch, but raises a
warning
for the end user about the deprecation so they fix their cronjobs. Later we
could remove it.

To test:
- Disable all indexing (daemon/cronjob)
- Create 2 records
- Edit one of them, delete the other one
- Verify they are queued for updates in zebraqueue
- sudo koha-mysql kohadev
  > SELECT * FROM zebraqueue WHERE done=0
...
| 265 |265 | specialUpdate | biblioserver |1 | 2016-05-13
14:23:45 |
| 266 |  1 | recordDelete  | biblioserver |1 | 2016-05-16
14:14:33 |
| 267 |  2 | specialUpdate | biblioserver |1 | 2016-05-16
14:15:06 |
+-++---+--+--+-+
- Now go to koha-shell
  $ sudo koha-shell kohadev ; cd kohaclone
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z

  You will get something similar to this:
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> FAIL: They contain the records you added/modified/deleted but they are in
 USMARC format
- Apply the patch
- Mark your records for indexing (in koha-mysql kohadev)
  > UPDATE zebraqueue SET done=0 WHERE id > 264
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z

  You will get something similar to this:
 [1]
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> SUCCESS: Data is correctly in XML format
- Run:
  $ misc/migration_tools/rebuild_zebra.pl -k -b -z -noxml

  You will get something similar to this:
 [1]
NOTHING cleaned : the export /tmp/jI0OeHy6Tn has been kept.
You can re-run this script with the -s  and -d /tmp/jI0OeHy6Tn parameters
if you just want to rebuild zebra after changing the record.abs
or another zebra config file
- Verify
  * less /tmp/jI0OeHy6Tn/del_biblio/exported_records
  * less /tmp/jI0OeHy6Tn/upd_biblio/exported_records
=> SUCCESS: Data is correctly in USMARC format
- Sign off :-D

[1] Warnings covered by a followup

Signed-off-by: Bernardo Gonzalez Kriegel 
On top of Bug 16505
Work as described following test plan, usmarc default pre patch,
post patch xml default and usmarc on request.
No errors (all patchset)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16506] rebuild_zebra.pl still using USMARC as default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16506

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #51538|0   |1
is obsolete||

--- Comment #5 from Bernardo Gonzalez Kriegel  ---
Created attachment 51567
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51567=edit
[SIGNED-OFF] Bug 16506: (Followup) remove warnings

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16528] Add ability to parallel process fines to fines.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16528

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #1 from Theodoros Theodoropoulos  ---
Steps to reproduce:

- Check out item X in patron A (item belonging to branch B1)
- Go to circulation, select patron B (from branch B2!=B1)
- Try to check-out the same item X to patron B
- You get a warning (Please confirm checkout Item X is checked out to A. Check
in and check out?). Click Yes
- You get either the Duplicate entry error / or the duplicate entry in issues
table


[update] Newer tests indicate that the only requirement to get the error is:
ITEM X must belong to a different branch than patron A/B (regardless of which
branch patron A and patron B belong to).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] New: Error when checking out already checked out item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Bug ID: 16534
   Summary: Error when checking out already checked out item
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: th...@lib.auth.gr
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Under very specific circumstances[1] when a librarian tries to check out an
item that is ALREADY checked out to another patron, one of these two nasty
things happen:

- If you're in Koha>=3.20.06
Software error:
DBIx::Class::Storage::DBI::_dbh_execute(): Duplicate entry '1204321' for key
'itemnumber' at /home/koha/src/C4/Circulation.pm line 1272

- if you're in Koha<3.20.06
A DUPLICATE entry is entered in issues table


[1] according to my tests, for the issue to appear, the item must belong to (or
must be originally check out to a patron of) a DIFFERENT branch than the one
currently trying to check it out!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/