[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16730

--- Comment #5 from Marc Véron  ---
(In reply to M. Tompsett from comment #4)
> Comment on attachment 52352 [details] [review]
> Bug 10760: Alternate Address: Display street number and street type
> 
> Review of attachment 52352 [details] [review]:
> -
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
> @@ +413,5 @@
> >   
> >  Alternate address
> > +
> > +[% IF Koha.Preference( 'AddressFormat' ) %]
> > +[% INCLUDE "member-display-alt-address-style-${ Koha.Preference( 
> > 'AddressFormat' ) }.inc" %]
> 
> What if the file doesn't exist?

It works the same as with Bug 4041 - Address Format as a I18N/L10N system
preference and Bug 16730 - Use member-display-address-style*-includes in
moremember-brief.tt 

Syspref 'AddressFormat' can have 2 values: us and de
snip---
- pref: addressformat
  default: us
  choices:
  us: US style ([Street number], [Address] - [City], [Zip/Postal
Code], [Country])
  de: German style ([Adress] [Street number] - [Zip/Postal Code]
[City] - [Country]
snip---
For each choice, a file exists:
member-display-alt-address-style-us.inc
member-display-alt-address-style-de.inc

Fallback is us if syspref 'AdressFormat' is not defined

If more formats are needed, you have to
- add an additional syspref value
- add inc files to folder koha-tmpl/intranet-tmpl/prog/en/includes as
appropriate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16730] Use member-display-address-style*-includes in moremember-brief.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16730

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10760

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don't show after placing a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

--- Comment #2 from Nick Clemens  ---
Needs to be unit tested

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don't show after placing a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767

--- Comment #1 from Nick Clemens  ---
Created attachment 52503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52503=edit
Bug 16767 - OPAC suggestions, existing suggestions don't show after placing a
suggestion

To test:
1 - Before applying this patch, place some suggestions
2 - Note that on success you see no suggestions
3 - Apply this patch
4 - Add a suggestion, note you see the new suggestion and all other
5 - Add a duplicate suggestion, note suggestions is rejected and you see
all existing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

--- Comment #5 from Nick Clemens  ---
(In reply to Marc Véron from comment #2)
> From OPAC, I add a suggestion 'AAA'. I get the following:
> 
> Your suggestion has been submitted.
> There are no pending purchase suggestions. (Hmm, should be one?)

> Clicking the link results in a new screen with the message:
> "You cannot place any more suggestions" etc.
> 
> Question: Couldn't the link be replaced by the message (like in the overview
> page)? That would be a nicer user experience.

The two above points are related and are related to existing functionality - I
filed a new bug for those bug 16767 and will work on that there

> Then a minor typo on the overview page: The second sentence has no ending
> punctuation:

Fixed
> Ah, and it would be nice to have the maximum number in the user message.

Fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15128] Add ability to limit the number of open purchase suggestions a patron can make

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15128

Nick Clemens  changed:

   What|Removed |Added

  Attachment #52452|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 52502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52502=edit
Bug 15128 - Add ability to limit patrons open purchase suggestions

To test:
1 - Define a number of MaxOpenSuggestions
2 - Add some suggestions for a patron
3 - Note they cannot add any more suggestions if limit is reached
4 - Delete a suggestion and note you can add another
5 - Add them to limit again
6 - Accept a suggestion in the staff client and note user can add more
7 - Repeat above with rejecting or deleting
8 - Sign off.

Sponsored by:
North Central Regional Library (http://ncrl.org/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16767] OPAC suggestions, existing suggestions don't show after placing a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||n...@bywatersolutions.com,
   ||ve...@veron.ch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16767] New: OPAC suggestions, existing suggestions don't show after placing a suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16767

Bug ID: 16767
   Summary: OPAC suggestions, existing suggestions don't show
after placing a suggestion
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

After placing a purchase suggestion on the opac the confirmation screen reads:

"Your suggestion has been submitted.

There are no pending purchase suggestions."

Place another, same result.

These lines in opac-suggestions.pl don't seem to be working as intended:

136 ^I^I$$suggestion{$_}='' foreach qw;
137 ^I^I$suggestions_loop =
138 ^I^I   ( $suggestion );

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10760] Use Street Number and Street type in Alternate Address section

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10760

--- Comment #4 from M. Tompsett  ---
Comment on attachment 52352
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52352
Bug 10760: Alternate Address: Display street number and street type

Review of attachment 52352:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=10760=52352)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ +413,5 @@
>   
>  Alternate address
> +
> +[% IF Koha.Preference( 'AddressFormat' ) %]
> +[% INCLUDE "member-display-alt-address-style-${ Koha.Preference( 
> 'AddressFormat' ) }.inc" %]

What if the file doesn't exist?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #38 from Nick Clemens  ---
Retesting, it looks like the itemlost check is done after the checkin, this
means the item holding branch has been updated to the checkin location, so in
the case of 'item holding branch' rule we aren't using the holding branch
before th eitem was checked in which is what I think is intended (i.e. we
should use where the was last held/checked out, not the current transaction
branch)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16766] Merging two records with title level holds for the same patron creates two holds on one record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16766

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16766] New: Merging two records with title level holds for the same patron creates two holds on one record

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16766

Bug ID: 16766
   Summary: Merging two records with title level holds for the
same patron creates two holds on one record
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

To recreate:
1 - Place a title level hold for a patron on a record
2 - Do it again on another record
3 - Merge these recrods
4 - See they now have two holds on one record

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16765] New: Subject links in XSLT detail display do not break into subdivisions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16765

Bug ID: 16765
   Summary: Subject links in XSLT detail display do not break into
subdivisions
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: boz...@nd.edu
QA Contact: testo...@bugs.koha-community.org

Created attachment 52501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52501=edit
Illustration of the difference between XSLT and non-XSLT subject links

Version: 3.22.04.000
Also tested on older versions and 16.05.00.000 (Catalyst demo site)

Using the non-XSLT detail display, subject links are broken up into
increasingly detailed subdivisions that can be clicked on. In the attached
image, you can see in the first three screen captures that each subject
subdivision is a separate link, and creates a search at that level of the
subject. It also conveniently provides a tooltip that shows which MARC subfield
the subdivision is coming from. 

The fourth screen capture shows what happens when the XSLT display is in
effect. The entire subject with all subfields are treated as a single search.
The subfields cannot be searched separately.

Note the the same behavior applies to the links for additional authors.

It would be great to have the XSLT option work the same way as the non-XSLT
option.

Settings for screen capture 4 (in attachment)
 OPACXSLTDetailsDisplay = default
 TraceSubjectSubdivisions = Include

Settings for screen capture 1-3 (in attachment)
 OPACXSLTDetailsDisplay = (empty, no XSLT)
 TraceSubjectSubdivisions = Include

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #102 from Christopher Brannon  ---
This is a great first step in setting up Koha for ILL request in the OPAC! 
Looking forward to this one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9259] batch delete marc batches

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259

--- Comment #5 from Owen Leonard  ---
What about the eraser icon instead?

http://fontawesome.io/icon/eraser/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16764] Update printers administration page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

--- Comment #2 from Owen Leonard  ---
In case it helps with testing:

INSERT INTO `printers` (`printername`, `printqueue`, `printtype`) VALUES
('Printer 01', 'print_queue_01', 'type01'),
('Printer 02', 'print_queue_02', 'type02'),
('Printer 03', 'print_queue_03', 'type03'),
('Printer 04', 'print_queue_04', 'type04'),
('Printer 05', 'print_queue_05', 'type05'),
('Printer 06', 'print_queue_06', 'type06'),
('Printer 07', 'print_queue_07', 'type07'),
('Printer 08', 'print_queue_08', 'type08'),
('Printer 09', 'print_queue_09', 'type09'),
('Printer 10', 'print_queue_10', 'type10'),
('Printer 11', 'print_queue_11', 'type11'),
('Printer 12', 'print_queue_12', 'type12'),
('Printer 13', 'print_queue_13', 'type13'),
('Printer 14', 'print_queue_14', 'type14'),
('Printer 15', 'print_queue_15', 'type15'),
('Printer 16', 'print_queue_16', 'type16'),
('Printer 17', 'print_queue_17', 'type17'),
('Printer 18', 'print_queue_18', 'type18'),
('Printer 19', 'print_queue_19', 'type19'),
('Printer 20', 'print_queue_20', 'type20'),
('Printer 21', 'print_queue_21', 'type21'),
('Printer 22', 'print_queue_22', 'type22'),
('Printer 23', 'print_queue_23', 'type23'),
('Printer 24', 'print_queue_24', 'type24'),
('Printer 25', 'print_queue_25', 'type25');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16764] Update printers administration page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

Owen Leonard  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16764] Update printers administration page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16764] Update printers administration page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

--- Comment #1 from Owen Leonard  ---
Created attachment 52500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52500=edit
Bug 16764 - Update printers administration page

This patch updates the template for printers administration according to
current interface guidelines.

- Custom JavaScript form validation is removed in favor of the built-in
  form validation plugin.
- Printer-specific header search form is removed, along with server-side
  pagination code. The functionality of both is now taken care of the
  adding DataTables sorting and pagination to the table.
- Edit and delete links are styled as Boostrap buttons with Font Awesome
  icons.
- Confirmation dialogs are updated to use Font Awesome icons.

To test properly you will need to add multiple printers.

- Apply the patch and open /cgi-bin/koha/admin/printers.pl (there is no
  menu link for the page).
- When no printers exist you should see a message dialog saying so.
- Add a new printer. Confirm that printer name and queue are required
  fields.
- After adding multiple printers, confirm that the table of printers is
  correctly sorted and searched by the DataTables plugin.
- Delete a printer and verify that the confirmation dialog is correctly
  styled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16713] Unknown Error Message from Item records

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16713

Laura  changed:

   What|Removed |Added

   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16764] New: Update printers administration page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16764

Bug ID: 16764
   Summary: Update printers administration page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/admin/printers.pl
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

I hear some libraries do use it, so why not bring the printers administration
page up to date? I have a patch to add DataTables, Font awesome icons, and
plugin-validated forms.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16761] I can not open a staff patron.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16761

--- Comment #2 from mahmud  ---
Dear Owen Leonard 

Thanks for your response. I have read the manual and seen nothing to solve this
problem. According to manuual whenever i am going to add a new patron. It can
not. 

At the first time when i was logged in following warning message shows and that
is

"You are logged in as the database administrative user. This is not recommended
because some parts of Koha will not function as expected when using this
account.

Please log in instead with a regular staff account. To create a staff account,
create a library, a patron category 'Staff' and add a new patron. Then give
this patron permissions from 'More' in the toolbar."


According to the message i went to the top of the site to set library from
there i chose the canterville. After that i clicked on create patron>new patron
and from drop down menu choose staff. There a message came that is "can not add
patron. please add a patron category." So i clicked on the patron category.
There i add a new patron category named College Staff. Again i continued but
again this message comes. At last i went to tools>patron list> new patron>
create a new patron list> Give name "Staff">save and following message comes. 


Software error:

Can't call method "patron_list_id" on an undefined value at
/usr/share/koha/intranet/cgi-bin/patron_lists/add-modify.pl line 55.

For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error. 


How can i fix it? I have no idea. Please help me. Even i can not open the list.
There also show same type message.   

By the way your queries are here.

Koha version-16.05.00.000 
server platform- ubuntu 16.04 LTS amd64
method of installation-marc21

Thanks in advance.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11405] Inventory tool enhancements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405

Jason Robb  changed:

   What|Removed |Added

 CC||jr...@sekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52000|0   |1
is obsolete||
  Attachment #52001|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall  ---
Created attachment 52496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52496=edit
Bug 11490: Add prefs MaxItemsToProcessForBatchMod and
MaxItemsToDisplayForBatchDel

Signed-off-by: Laurence Rault 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item (depending on AllowReturnToBranch)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #33 from Kyle M Hall  ---
Created attachment 52493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52493=edit
Bug 16534: (followup) - Tidy AddIssue

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item (depending on AllowReturnToBranch)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #31 from Kyle M Hall  ---
Created attachment 52491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52491=edit
Bug 16534: Block AddIssue from issuing if the return is not possible

To make sure the return can be done, AddIssue must not trust callers (they
should have done their job, but we are not sure) and check that the issue can
be returned before issuing to the patron.

There is no test plan here, this should not be possible from the Koha
interface.
However, looking at the code, it may be possible using SIP.

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11490] MaxItemsForBatch should be split into two new prefs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490

--- Comment #13 from Kyle M Hall  ---
Created attachment 52497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52497=edit
Bug 11490: Split MaxItemsForBatch into 2 prefs to clarify things

Prior to this patch, a single pref (MaxItemsForBatch) was used to
restrict the use of the batch item modification and deletion.

On the batch modification tool, the pref is used to limit the number of
items a librarian is allowed to modify in a batch, but on the batch
deletion tool the pref is used to limit the number of items to display.

To clarify things, this patch split the pref into 2 new prefs:
MaxItemsToDisplayForBatchDel and MaxItemsToProcessForBatchMod.

Later we could add a MaxItemsToProcessForBatchDel if needed.
Note that this patch should not introduce any changes in the current behaviors.

Test plan:
0/ Do not execute the update DB entry
1/ Set a value != 1000 for MaxItemsForBatch
2/ Execute the update DB entry and confirm that the 2 new prefs are
initially set with the value of MaxItemsForBatch and that
MaxItemsForBatch has been deleted
3/ Set different values for these 2 prefs (2 and 3 for instance to ease
the next steps)
4/ Try to delete less than MaxItemsToDisplayForBatchDel items
=> You must see the items details
5/ Try to delete more than MaxItemsToDisplayForBatchDel items
=> You must not see the items details but are allowed to delete them
6/ Try to modify less than MaxItemsToProcessForBatchMod items
=> You must see the items details
7/ Try to modify more than MaxItemsToProcessForBatchMod items
=> You must be restricted and not allowed to process

Signed-off-by: Laurence Rault 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52276|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 52495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52495=edit
Bug 16707: Fix software error in OPAC password recovery when leaving form
fields empty

The $search_results is considered as an arrayref but is not defined if
no patron matches the recovery infos.

Test plan:
- Set syspref OpacResetPassword to "Allow"
- Go to OPAC
- Click link "Forgot your password?
- On the following screen "Forgotten password recovery", do not fill in
  form fields, click "Submit"
=> Without this patch you got the software error
=> With this patch apply, you will get "No account was found with the
provided information."

Sign-off on counter patch.
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item (depending on AllowReturnToBranch)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #32 from Kyle M Hall  ---
Created attachment 52492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52492=edit
Bug 16534: (followup) Correct tiny typo

This patch corrects "...must be return..." to "must be returned..."

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

--- Comment #38 from Katrin Fischer  ---
include_items option ... is what I meant :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16707] Software Error in OPAC password recovery when leaving form fields empty

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16707

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item (depending on AllowReturnToBranch)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #30 from Kyle M Hall  ---
Created attachment 52490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52490=edit
Bug 16534: Add tests for AddIssue

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item (depending on AllowReturnToBranch)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item (depending on AllowReturnToBranch)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #51706|0   |1
is obsolete||
  Attachment #51707|0   |1
is obsolete||
  Attachment #51708|0   |1
is obsolete||
  Attachment #51709|0   |1
is obsolete||
  Attachment #51710|0   |1
is obsolete||

--- Comment #27 from Kyle M Hall  ---
Created attachment 52487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52487=edit
Bug 16534: Add tests for CanBookBeIssued & AllowReturnToBranch

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item (depending on AllowReturnToBranch)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

--- Comment #29 from Kyle M Hall  ---
Created attachment 52489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52489=edit
Bug 16534: Make CanBookBeIssued test if the issue can be returned

If an issue is already checked out, CanBookBeIssued must check if the
issue can be checked in before processing the return.
In such cases (depending of the AllowReturnToBranch pref), the issue
should not be allowed.

Prior to this patch, the checkin was not done and the checkout failed
with "Duplicate entry '1204321' for key 'itemnumber'". Indeed since bug
14978, there is an uniq key on issues.itemnumber. Before bug 14978 the
issue existed but was hidden (and some weird behaviors certainly
happened!).

To avoid Koha to crash, a check is added to CanBookBeIssued (call to
CanBookBeReturned) and the librarian is not able to process the
checkout.

Test plan:

- Set AllowReturnToBranch to anywhere
- Check an item (homebranch Library 1, holding branch Library 1) out from
Library 1
- Check the item out from Library 2
=> Confirm the checkout (should work with and without this patch)

- Set AllowReturnToBranch to holdinbranch ("only the library the item
  was checked out from").
- Check an item (homebranch Library 1, holding branch Library 1) out from
Library 1
- Check the item out from Library 2
=> Without this patch, Koha crashed
=> With this patch, you will be warned that the checkin is not possible.

Try other combinations of the AllowReturnToBranch syspref

Followed test plan, works as expected
Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16534] Error when checking out already checked out item (depending on AllowReturnToBranch)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16534

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52487|0   |1
is obsolete||

--- Comment #28 from Kyle M Hall  ---
Created attachment 52488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52488=edit
Bug 16534: Add tests for CanBookBeIssued & AllowReturnToBranch

Signed-off-by: Marc Véron 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #17 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Owen, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16761] I can not open a staff patron.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16761

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Owen Leonard  ---
This sounds more like a support request than a bug report.

The first place to go for help is the manual:

http://koha-community.org/documentation/

Support requests can also be made on the Koha mailing list, on IRC, or by
contracting with a support vendor. All these options are linked to here:
http://koha-community.org/support/

Please include details about your Koha version, server platform, and method of
installation with your question.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16577] Improve call number browser plugin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16577

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16729] Use member-display-address-style*-includes when printing user summary

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16729

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16761] I can not open a staff patron.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16761

mahmud  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16693] reserve/renewscript.pl is not used and should be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16693

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52485|0   |1
is obsolete||

--- Comment #16 from Owen Leonard  ---
Created attachment 52486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52486=edit
[SIGNED-OFF] Bug 16148 [Follow-up] - Use Font Awesome for arrows instead of
images

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16421] Move hold edit actions into dropdown menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16421

--- Comment #5 from Kyle M Hall  ---
 It does make moving a hold a number of places up or down a bit more
cumbersome, but it's also more self-explanitory. I'm torn. Even in it's current
state it's a bit cumbersome with the page reloading between each move. I think
this table would really benefit from the re-ordering being done via ajax in
some fashion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52484|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall  ---
Created attachment 52485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52485=edit
Bug 16148 [Follow-up] - Use Font Awesome for arrows instead of images

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16672] Add ability to remove expired holidays from special_holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16672

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #9 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks for the followup Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16543] Make edit and delete links styled buttons in patron attribute types administration

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16543

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16541] Make edit and delete links styled buttons in cities administration

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16541

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10472] Receipt by line or invoice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10472

Paul Poulain  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||paul.poul...@biblibre.com

--- Comment #5 from Paul Poulain  ---
probably a lost in limbo patch...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16456] Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #36 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Hector, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16760] Circulation Statistics wizard not populating itemtype correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16760

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16148] Revised layout and behavior of marc modification template management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148

--- Comment #14 from Kyle M Hall  ---
Created attachment 52484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52484=edit
Bug 16148 [Follow-up] - Use Font Awesome for arrows instead of images

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15296] MEMBER logging in action_logs does not give enough detail.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15296

--- Comment #1 from Barton Chittenden  ---
(In reply to Barton Chittenden from comment #0)

> 'action' fields -- I really needed to know which fields in the borrower
> record were changed.

... as well as what the field changed from and to. I *don't* want to see the
entire borrower record though.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16127] Add discharge menu item to patron toolbar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16127

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6906] show 'Borrower has previously issued $ITEM' alert on checkout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Failed QA

--- Comment #48 from Kyle M Hall  ---
I'm getting 8 failing subtests out of 59.

Also, please rename the method wantsCheckPrevCheckout to something like
should_check_for_previous_checkout and doCheckPrevCheckout to
check_for_previous_checkout. As per the Koha Objects pages linked from the
Coding Guidelines, all Koha::Object(s) derived classes should use snake case.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged, withdrawn, or not-for-loan items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
Summary|Search limit 'available'|Search limit 'available'
   |does not hide damaged or|does not hide damaged,
   |withdrawn items |withdrawn, or not-for-loan
   ||items

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16594] Orders by fund report has wrong link to css and other issues

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Hector, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16717] Remove hardcoded category from Holds.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16717

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16734] getLanguages() in opac-search.pl should be called only if needed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16734

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Jacek!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16607] Remove CPL/MPL from two unit tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16607

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #10 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16500] Catch two warns in TestBuilder.t with warning_like

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16500

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #14 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10459] borrowers should have a timestamp

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10459

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Stable

--- Comment #77 from Kyle M Hall  ---
I think we're all fixed up on this one!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

--- Comment #37 from Katrin Fischer  ---
Hm, reading through the use cases Frederic wrote I wonder if it wouldn't work
for a first step if we say that the item changes should only be taken into
account if you have the add_items flag set. And then we could open a separate
bug for an enhanced mode, where only some changes lead to 'republishing' the
record via OAI.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16720] DBIx ActionLogs.pm should be removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16720

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16692] Error "No method update!" when creating new serial issue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16692

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 16.11!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16670] CGI->param used in list context

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16670

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #11 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16502] Table koha_plugin_com_bywatersolutions_kitchensink_mytable not always dropped after running Plugin.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16502

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #22 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13074] C4::Items::_build_default_values_for_mod_marc should use Koha::Cache

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13074

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #16 from Kyle M Hall  ---
Pushed for 16.11, thanks Jonathan, Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #31 from Kyle M Hall  ---
Pushed to master for Koha 16.11, thanks Remi, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16527] Sticky due date calendar unexpected behaviour

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16527

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16747] Fix regression in patron card creator (patron image)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52481|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 52483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52483=edit
Bug 16747 - Patron card creator broken with version 16.05

To reproduce:
- Prepare a patron car layout with Image 1 using Patron Image
- Create a patron card for a patron without patron image
Result: OK, PDF can be opened wit PDF viewer
- Try to create a patron card with a patron who has a patron image
Result: The PDF file is corrupt (contains text only with error message)
intranet error log contains: create-pdf.pl: Illegal division
by zero at /usr/share/kohaclone/patroncards/create-pdf.pl line 200
To test:
- Apply patch
- Create a patron card with a patron who has a patron image
Result: PDF is OK and contains the image

Bonus test: Do the same with a card layout with an additional image
(Image 2: Image source: Other image)

Signed-off-by: Owen Leonard 

Test and bonus test pass: PDF generated without errors.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16747] Fix regression in patron card creator (patron image)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #37 from Tomás Cohen Arazi  ---
(In reply to Nick Clemens from comment #35)
> Tested well for syspref RefundLostOnReturnControl with values "homebranch"
> and "check-in library"
> 
> When using "item holding branch" I receive the error below:
> Software error: ItemHoldingbranch requires the  param

Nick, it was due to a typo. It should be fixed by the latest followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14048] Change RefundLostItemFeeOnReturn to be branch specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14048

--- Comment #36 from Tomás Cohen Arazi  ---
Created attachment 52482
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52482=edit
Bug 14048: (QA followup) Fix typo on syspref value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16686] Fix "Item in transit from since" in Holds tab

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16686

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from Marc Véron  ---
Re-tested. I can no longer log-in to the OPAC with a patron who has the hold on
an item in transit.

[Fri Jun 17 14:16:40 2016] [error] [client 192.168.1.35] [Fri Jun 17 14:16:40
2016] opac-user.pl: Use of inherited AUTOLOAD for non-method
Koha::Item::GetTransfers() is deprecated at /usr/share/kohaclone/Koha/Item.pm
line 123., referer: http://192.168.1.35/
[Fri Jun 17 14:16:40 2016] [error] [client 192.168.1.35] [Fri Jun 17 14:16:40
2016] opac-user.pl: Template process failed: undef error - Can't call method
"_columns" without a package or object reference at
/usr/share/kohaclone/Koha/Object.pm line 266., referer: http://192.168.1.35/

Without patch, I can log in with this patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16747] Fix regression in patron card creator (patron image)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747

Owen Leonard  changed:

   What|Removed |Added

  Attachment #52454|0   |1
is obsolete||

--- Comment #4 from Owen Leonard  ---
Created attachment 52481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52481=edit
[SIGNED-OFF] Bug 16747 - Patron card creator broken with version 16.05

To reproduce:
- Prepare a patron car layout with Image 1 using Patron Image
- Create a patron card for a patron without patron image
Result: OK, PDF can be opened wit PDF viewer
- Try to create a patron card with a patron who has a patron image
Result: The PDF file is corrupt (contains text only with error message)
intranet error log contains: create-pdf.pl: Illegal division
by zero at /usr/share/kohaclone/patroncards/create-pdf.pl line 200
To test:
- Apply patch
- Create a patron card with a patron who has a patron image
Result: PDF is OK and contains the image

Bonus test: Do the same with a card layout with an additional image
(Image 2: Image source: Other image)

Signed-off-by: Owen Leonard 

Test and bonus test pass: PDF generated without errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16747] Fix regression in patron card creator (patron image)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16747

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #23 from Marcel de Rooy  ---
I would appreciate feedback on the questions raised earlier.
The counterpatches can be applied on top of the first two.
See the restricted handling in the third patch of only logins.
And the policy/timeout use in the fourth patch.

We should remove some changes to the xml again and add a simple test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #33 from Owen Leonard  ---
Sorry, this doesn't apply again.

Any patch which touches memberentrygen.tt is really hard to keep up to date!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #22 from Marcel de Rooy  ---
Created attachment 52480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52480=edit
Bug 15006: [COUNTERPATCH] Timeout logic in sip_protocol_loop

Instead of adding yet another client timeout, I propose to use the
policy timeout that we also communicate in send_acs_status.
Although I agree that we perhaps better move it from institution to
account/login level, this c/should be done on another report. We
may have issues with existing configurations.

In order to find a compromise between bug 13432 and the originally
proposed 15006 patch, this patch allows you to put a zero in the
policy timeout entry in the SIPconfig.

The timeout logic is moved to a Sip.pm subroutine. Will add a test :)

Test plan:
[1] Check timeout after login with policy/timeout > 0.
[2] Check timeout after login with policy/timeout = 0. (No timeout!)
[3] Check timeout after login with no policy timeout. Fallback to service.
[4] Check timeout after login with no policy and service timeout.
Should fallback to 30 seconds for both login process and after login.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #21 from Marcel de Rooy  ---
Created attachment 52479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52479=edit
Bug 15006: [COUNTERPATCH] Add timeout and strikes to raw_transport

The code in raw_transport includes setting a $SIG{ALRM}, but did not
use it. For consistency, we add an alarm statement here.

Similarly, we add the "three strikes" to raw_transport just as
telnet_transport does. Note that raw_transport will no longer respond
to other requests than login.

Test plan:
[1] Start sip session with telnet on raw port 6001.
Wait until it times out (probably the default 60 seconds).
[2] Change SIPconfig.xml: set timeout=5 for service port 6001.
Restart SIP and start another telnet 6001 session.
Did it timeout within 5 seconds?
[3] Start another 6001 session. Give three wrong requests or false
login attempts. Does the connection close?

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #20 from Marcel de Rooy  ---
Please do not change status yet. Not finished..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #45594|0   |1
is obsolete||

--- Comment #19 from Marcel de Rooy  ---
Created attachment 52478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52478=edit
Bug 15006 Sip separate global from login timeouts

Timeout logic has been added to the main sip loop
However the timeout parameter was initially for the login process which
requires a short duration applying such a brief timeout to
the main sip loop causes instability in many selfcheck units

Most selfchecks have persistent connections and send a
periodic status request at intervals (approx every 5mins appears
the norm) The timeout was dropping connections by default every 30secs
which for the client appears as a very flakey network

This patch adds a separate parameter client_timeout that can be
used if you do want to force a disconnect if the client sends
no requests for a period. By not defining it you can switch off
the timeout in the main loop, I recommend this unless you
have a good reason not too. If you do want this behaviour you can
at least now set it to a more realistic value (see sample config
file)

Removed the commented out html entry in the config file, this was
dead code born of a misconception and was just a source
of confusion for users

Signed-off-by: Frederic Demians 
Signed-off-by: Jonathan Druart 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #18 from Marcel de Rooy  ---
Created attachment 52477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52477=edit
Bug 15006: [QA Follow-up] Indentation for two subroutines

Remove tabs from telnet_transport and sip_protocol_loop. Correct
indentation.

Test plan:
Compare files before and after without whitespace (diff -b).
Notice only two split lines.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

--- Comment #17 from Marcel de Rooy  ---
Colin or Kyle:

Well, I have some improvements coming hopefully :) Already wrote some patches.
Few questions are:

Is my impression correct that $config->{timeout} normally does not exist?
We do not have/want[?] such entries in SIPconfig.

Should we only allow login attempts in raw_transport? We do not now. Or should
we allow e.g. SC_STATUS messages too?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning, and contracts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

--- Comment #3 from Owen Leonard  ---
Created attachment 52476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52476=edit
Bug 16754 - Use validation plugin in budgets, planning, and contracts

This patch removes the custom javascript form validation from three
templates: Budgets, budget planning, and contracts. Validation via the
validation plugin is done instead.

This patch also removes use of event attributes like onclick and
onchange. Also changed: I added the "Required" text next to required
fields as necessary.

To test, apply the patch and go to Administration -> Budgets.

- Test the budget creation process for adding, editing, and duplicating
  budgets. In all cases:
  - The start date and end date should be required
  - You should be warned if you enter an end date which falls before the
start date.
  - The description should be required
  - The budget amount should be required to be a number

To test the budget planning page:

Note that much of the JS removed from this template was unused. It
looked for inputs by the name 'est_total' which don't exist.

- When viewing the table of funds for a budget, select a choice from the
  'planning' toolbar menu.
  - Verify that after entering a numeric value in any cell, the
'remaning' value at the end of the row is correctly updated.
  - Verify that after entering non-numeric data an error is displayed.
  - Verify that clicking the 'auto-fill' button at the end of the row

To test the vendor contracts page:

- Go to Acquisitions -> Vendor -> Contracts
- Add or edit a contract
  - Confirm that name, start date, and end date are required.
  - Confirm that you are warned if you enter an end date which falls
before the start date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning, and contracts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning, and contracts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Owen Leonard  changed:

   What|Removed |Added

Summary|Use validation plugin when  |Use validation plugin in
   |adding or editing budgets   |budgets, planning, and
   ||contracts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12599] IndependentBranches Holes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12599

--- Comment #7 from Owen Leonard  ---
(In reply to M. Tompsett from comment #6)
> (In reply to Kyle M Hall from comment #5)
> > Indeed, ... . It's on my todo list ; )
> 
> TODO lists get lost. How do we get that on a "Doing It Now" list? :)

Oh that's easy: You put up some time or money.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16744] new records not indexed if using a customize Koha Framework

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16744

--- Comment #2 from Hugo Agud  ---
I do not think so, I have exported the blob from biblioitems and 999c and c
seems to be ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15006] Need to distinguish client timeout from login timeout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15006

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #16 from Marcel de Rooy  ---
QA: Looking here now. Will probably ask some questions first :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16212] Swagger specification separation and minification

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212

--- Comment #6 from Lari Taskula  ---
The minification is problematic at the moment, because it has to be executed
manually. It could be assigned to execute automatically at
Koha::REST::V1->startup(), but since this is executed on each request to the
REST API, there will be a lot of useless computation. A dirty trick would be to
make a copy of swagger.json and compare it to the actual swagger.json in
startup(), and run swaggerMinifier.pl in case the two specification files are
different, and finally replacing the copy with actual swagger.json.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15108] OAI-PMH provider improvements

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15108

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/