[Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202

--- Comment #5 from M. Tompsett  ---
(In reply to Colin Campbell from comment #4)
[SNIP]
> The value after the point is the number of decimal places presented the 0 is
> meaningless in this context see the printf/sprintf documentation where it is
> not used. ( 0 can be used on its own to suppress the decimal part). Using
> the precision as documented is less ambiguous

Okay, then should they not be both the same?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16918] opacmain.pl is not running under plack

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16918

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

M. Tompsett  changed:

   What|Removed |Added

  Attachment #53639|0   |1
is obsolete||

--- Comment #13 from M. Tompsett  ---
Created attachment 53664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53664&action=edit
Bug 16573: Define virtualshelves.created_on as datetime for existing installs

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #12 from M. Tompsett  ---
Now the Elastic search upgrade stuff was bombing horribly. for 3.23.0.50.
commented it out... everything else fine.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16968] New: Remove the use of "onclick" from serial patron and vendor search templates

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16968

Bug ID: 16968
   Summary: Remove the use of "onclick" from serial patron and
vendor search templates
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com,
testo...@bugs.koha-community.org

There are a few instances of "onclick" in the templates for serial patron and
vendor search templates. These should be removed in favor of events defined in
the JavaScript.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

--- Comment #1 from Owen Leonard  ---
Created attachment 53663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53663&action=edit
Bug 16967 - Remove the use of "onclick" from serial frequency and numbering
management

This patch removes instance of "onclick" from the templates for serial
frequency and numbering management. Events are now defined in the
JavaScript.

To test, apply the patch and go to Serials -> Manage frequencies.

 - In the list of frequencies, click the "Delete" button for a frequency
   which is in use by at least one subscription. In the confirmation
   dialog, clicking the "Show subscriptions" link should display a list
   of titles.
 - Edit or create a frequency.
 - To test that the form submission validation is still working
   correctly, enter non-numeric data in the "issues per unit" field and
   submit the form. This should trigger an error.

In Serials -> Manage numbering patterns:

 - In the list of numbering patterns, click the "Delete" button for a
   pattern which is in use by at least one subscription. In the
   confirmation dialog, clicking the "Show subscriptions" link should
   display a list of titles.
 - Edit or create a numbering pattern.
 - Confirm that the "Test pattern" button works correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] New: Remove the use of "onclick" from serial frequency and numbering management

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Bug ID: 16967
   Summary: Remove the use of "onclick" from serial frequency and
numbering management
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com,
testo...@bugs.koha-community.org

There are several instances of "onclick" in the templates for managing serial
numbering patterns and serial frequencies. These should be removed in favor of
events defined in the JavaScript.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16963] Remove the use of "onclick" from subscription add template

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963

--- Comment #1 from Owen Leonard  ---
Created attachment 53662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53662&action=edit
Bug 16963 - Remove the use of "onclick" from subscription add template

This patch removes the use of event attributes from the subscription add
template and the template for testing prediction patterns. Events are
now defined in the JavaScript.

To test, go to Serials -> New subscription.

- Test that the "Search for vendor," "Search for record," and "Create
  record" links work correctly.
- Test the "Next" button without entering a vendor or a biblionumber.
  You should be warned about selecting a vendor and biblionumber.
- After selecting a bibliographic record to link to the subscription,
  click the "Next" button. The second section of the subscription add
  form should be displayed.
- Under frequency, choose "1/day."
- Confirm that the "Show advanced pattern" link correctly toggles
  display of the advanced pattern form.
- Under the advanced pattern form, test the "Modify pattern" button. It
  should enable editing in the form.
- Test the "Cancel modifications" and "Save as new pattern" buttons.
- Test the "Test prediction pattern" button.
  - In the "Prediction pattern" box, test that the checkboxes next to
each day of the week, when checked, trigger the corresponding issue
number to be marked as "not published."
- Finally, confirm that your subscription is saved correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16963] Remove the use of "onclick" from subscription add template

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14793] New cataloguing plugin unimarc_field_225a_bis

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14793

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16948] 'Return to batch item deletion' button should only show when there are items that could not be deleted

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16948

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16945] Syspref PatronSelfRegistration: Add note about setting PatronSelfRegistrationDefaultCategory

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16945

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #7 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16906] Add DataTables pagination and filter to top of saved SQL reports table

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16906

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16847] Remove C4::Members::GetTitles

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16847

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #12 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15451] Move the CSV related code to Koha::CsvProfile[s]

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15451

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #49 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16715] Koha::Cache - Use Sereal for serialization

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16715

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #15 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jesse!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16961] Add the Koha::Objects->update method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961

--- Comment #4 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #3)
> Time for an AUTOLOAD ?

Yes, it's in my todo list :) I have just needed it for bug 16966 and did not
want to add a 'big' blocker.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

--- Comment #3 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #2)
> Shouldn't you wrap them like search does ?

I don't think so:
"In list context, ->all() is called implicitly on the resultset, thus returning
a list of result objects instead."
https://metacpan.org/pod/DBIx::Class::ResultSet#search_related

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11606] Novelist Select in Staff Client

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11606

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #11 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Nick, Jesse!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |ASSIGNED

--- Comment #326 from Kyle M Hall  ---
3 patches pushed to master for 16.11. I reset the status to assigned. If this
isn't the correct status, can someone please update it? Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53660|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 53661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53661&action=edit
Bug 16966: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to
search_patrons_to_anonymise

The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed
to return the patrons with an issue history older than a given date.

It would make more sense to return a list of Koha::Patrons.

On the way, the code from AnonymiseIssueHistory will be moved as well to
anonymise_issue_history.

Note that these 2 subroutines are strongly linked: one is used to know the
number of patrons we will anonymise the history, the other one is used to
anonymise the issues history. The problem is that the first one is not used to
do the action, but only for displayed purpose.

In some cases, these 2 values can differ, which could be confusing.
Case 1:
The logged in librarian is not superlibrarian and IndependentBranches is set:
if 2+ patrons from different libraries match the date parameter, the interface
will display "Checkout history for 2 patrons will be anonymized", when actually
only 1 will be.
Case 2:
If 2+ patrons match the date parameter but one of them has his privacy set to
forever (privacy=0), the same issue will appear.

This patch moves the code from
C4::Members::GetBorrowersWithIssuesHistoryOlderThan
to Koha::Patrons->search_patrons_to_anonymise and from
C4::Circulation::AnonymiseIssueHistory to
Koha::Patrons->anonymise_issue_history

Test plan:
1/ Confirm the 2 issues and make sure they are fixed using the Batch
patron anonymization tool (tools/cleanborrowers.pl)
2/ At the OPAC, use the 'Immediate deletion' button to delete all your
reading history (regardless the setting of the privacy rule)
3/ Use the cronjob script (misc/cronjobs/batch_anonymise.pl) to
anonymise patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #53469|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #53468|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #53467|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16934] Cannot add notes to canceled and deleted order line

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16934

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #8 from Kyle M Hall  ---
Pushed to master for 16.11, thanks for the followup Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966

--- Comment #2 from Jonathan Druart  
---
Created attachment 53659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53659&action=edit
Bug 16966: Koha::Patrons - Move AnonymiseIssueHistory tests

The next patch will move C4::Circulation::AnonymiseIssueHistory and
C4::Members::GetBorrowersWithIssuesHistoryOlderThan to Koha::Patrons
This patch move the history anonymisation code to the Patrons.t test
file and the entire subtest related to StoreLastBorrower to
StoreLastBorrower.t

It just moves and add some minor adjustements.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16947] Can not modify patron messaging preferences

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16947

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16716] Invalid SQL GROUP BY clauses in GetborCatFromCatType and GetAuthorisedValues

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16716

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Srdjan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15974] Rancor - 942c is always displaying first in the list.

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15974

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Jesse!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16941] Can not add new patron in staff client

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16941

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966

--- Comment #1 from Jonathan Druart  
---
Created attachment 53658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53658&action=edit
Bug 16966: GetBorrowersWithIssuesHistoryOlderThan - Highlight the existing
issue in tests

If IndependentBranches is set, the code is buggy. This patch only
highlight the bug by providing a test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16966] Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966

--- Comment #3 from Jonathan Druart  
---
Created attachment 53660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53660&action=edit
Bug 16966: Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to
search_patrons_to_anonymise

The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed
to return the patrons with an issue history older than a given date.

It would make more sense to return a list of Koha::Patrons.

On the way, the code from AnonymiseIssueHistory will be moved as well to
anonymise_issue_history.

Note that these 2 subroutines are strongly linked: one is used to know the
number of patrons we will anonymise the history, the other one is used to
anonymise the issues history. The problem is that the first one is not used to
do the action, but only for displayed purpose.

In some cases, these 2 values can differ, which could be confusing.
Case 1:
The logged in librarian is not superlibrarian and IndependentBranches is set:
if 2+ patrons from different libraries match the date parameter, the interface
will display "Checkout history for 2 patrons will be anonymized", when actually
only 1 will be.
Case 2:
If 2+ patrons match the date parameter but one of them has his privacy set to
forever (privacy=0), the same issue will appear.

This patch moves the code from
C4::Members::GetBorrowersWithIssuesHistoryOlderThan
to Koha::Patrons->search_patrons_to_anonymise and from
C4::Circulation::AnonymiseIssueHistory to
Koha::Patrons->anonymise_issue_history

Test plan:
1/ Confirm the 2 issues and make sure they are fixed using the Batch
patron anonymization tool (tools/cleanborrowers.pl)
2/ At the OPAC, use the 'Immediate deletion' button to delete all your
reading history (regardless the setting of the privacy rule)
3/ Use the cronjob script (misc/cronjobs/batch_anonymise.pl) to
anonymise patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #3 from Kyle M Hall  ---
Created attachment 53657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53657&action=edit
Bug 16960 - Patron::Modifications should be fixed

The changes from opac-memberentry do not reach the table, since the
Patron::Modifications object does not work well.

Test Plan:
1) Apply this patch
2) Create some patron modification requests
3) Ensure you can approve and deny modifications
4) Ensure patron self registration works

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #2 from Marcel de Rooy  ---
Shouldn't you wrap them like search does ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16961] Add the Koha::Objects->update method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #3 from Marcel de Rooy  ---
Time for an AUTOLOAD ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846

--- Comment #16 from Jonathan Druart  
---
Bug 16966 - Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to
search_patrons_to_anonymise

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16961] Add the Koha::Objects->update method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16966


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966
[Bug 16966] Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to
search_patrons_to_anonymise
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||16966


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966
[Bug 16966] Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to
search_patrons_to_anonymise
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16966] New: Koha:: Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to search_patrons_to_anonymise

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966

Bug ID: 16966
   Summary: Koha::Patrons - Move
GetBorrowersWithIssuesHistoryOlderThan to
search_patrons_to_anonymise
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 16961, 16965
Blocks: 16846

The C4::Members::GetBorrowersWithIssuesHistoryOlderThan subroutine is supposed
to return the patrons with an issue history older than a given date.

It would make more sense to return a list of Koha::Patrons.

On the way, the code from AnonymiseIssueHistory will be moved as well to
anonymise_issue_history.

Note that these 2 subroutines are strongly linked: one is used to know the
number of patrons we will anonymise the history, the other one is used to
anonymise the issues history. The problem is that the first one is not used to
do the action, but only for displayed purpose.

In some cases, these 2 values can differ, which could be confusing.
Case 1:
The logged in librarian is not superlibrarian and IndependentBranches is set:
if 2+ patrons from different libraries match the date parameter, the interface
will display "Checkout history for 2 patrons will be anonymized", when actually
only 1 will be.
Case 2:
If 2+ patrons match the date parameter but one of them has his privacy set to
forever (privacy=0), the same issue will appear.

The patches provided will refactor the code and fix these 2 issues.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846
[Bug 16846] Move patron related code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961
[Bug 16961] Add the Koha::Objects->update method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965
[Bug 16965] Add the Koha::Objects->search_related method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16966


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16966
[Bug 16966] Koha::Patrons - Move GetBorrowersWithIssuesHistoryOlderThan to
search_patrons_to_anonymise
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16961] Add the Koha::Objects->update method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16965


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965
[Bug 16965] Add the Koha::Objects->search_related method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

--- Comment #1 from Jonathan Druart  
---
Created attachment 53656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53656&action=edit
Bug 16965: Add Koha::Objects->search_related

In order to search on relations, we need this new method.

Test plan:
Confirm that the changes in Objects.t make sense and that the tests
pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16965] Add the Koha::Objects->search_related method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||16961


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961
[Bug 16961] Add the Koha::Objects->update method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16961] Add the Koha::Objects->update method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #53645|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 53655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53655&action=edit
[SIGNED-OFF]Bug 16961: Add Koha::Objects->update

In order to update several rows in a single query, we need this new
method.

Test plan:
Confirm that the changes in Objects.t make sense and that the tests
pass.

Signed-off-by: Hector Castro 
Test passed successfully

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16961] Add the Koha::Objects->update method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16965] New: Add the Koha::Objects->search_related method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965

Bug ID: 16965
   Summary: Add the Koha::Objects->search_related method
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 13019


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
[Bug 13019] Add base classes on which to build Koha objects
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16965


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16965
[Bug 16965] Add the Koha::Objects->search_related method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in reports-home.tt

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964

--- Comment #1 from Héctor Eduardo Castro Avalos  ---
Created attachment 53654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53654&action=edit
Bug 16964: Fix capitalization for "Report Plugins" in reports-home.tt

Fix capitalization for "Report Plugins" in reports-home.tt according with
Coding Guidelines


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16964] Fix capitalization for "Report Plugins" in reports-home.tt

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16964] New: Fix capitalization for "Report Plugins" in reports-home.tt

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16964

Bug ID: 16964
   Summary: Fix capitalization for "Report Plugins" in
reports-home.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: hector.hecax...@gmail.com
  Reporter: hector.hecax...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Fix capitalization for "Report Plugins" in reports-home.tt according with
Coding Guidelines


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #53589|0   |1
is obsolete||

--- Comment #88 from Héctor Eduardo Castro Avalos  
---
Created attachment 53650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53650&action=edit
[SIGNED-OFF]Bug 6934: QA follow-up

- fixed tabs
- fixed capitalization on reports start page

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #92 from Héctor Eduardo Castro Avalos  
---
Hi Bouzid

For me this is Ok.

Just explain what does "Active transaction" mean? QA comment 59

Regards

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #53648|0   |1
is obsolete||

--- Comment #91 from Héctor Eduardo Castro Avalos  
---
Created attachment 53653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53653&action=edit
[SIGNED-OFF]Bug 6934: Fix the href for datables in link rel stylesheet

Fix the new path for 'datatables.css'

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #53591|0   |1
is obsolete||

--- Comment #90 from Héctor Eduardo Castro Avalos  
---
Created attachment 53652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53652&action=edit
[SIGNED-OFF]Bug 6934: Make CSV header column translatable and add total amounts
in csv file

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #53590|0   |1
is obsolete||

--- Comment #89 from Héctor Eduardo Castro Avalos  
---
Created attachment 53651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53651&action=edit
[SIGNED-OFF]Bug 6934: fix problem when export it open in LibreOffice - show
values of itype and use TT plugin

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #48645|0   |1
is obsolete||

--- Comment #30 from Mehdi Hamidi  ---
Created attachment 53649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53649&action=edit
Bug 12532 - Redirect guarantee email to guarantor

Fixed merge conflicts.
Both the guarantor and the guarantee will receive the email now.
Also fixed some log errors since the "save" button is the same one use for
editing the patron details.
Changed the save button "save" id whene editing only the Patron messaging
preferences so we can detect where the request is comming from.

Added unit tests.
Added an atomicupdate file.
Reordered the sysprefs in alphabetical order.
Refactored some code.

TEST PLAN:

I Apply the patch
II Run updatedatabase.pl
III Run db_dependent/Letters.t and db_dependant/Members.t

0) Enable EnhancedMessagingPreferences preference;
0) Enable EnableRedirectGuaranteeEmail preference;
1) Select a patron with child;
2) Enable Item checkout -> email in patron messaging preferences;
3) Select the patron's child;
4) Checkout an item;
5) Valide child checkout message in patron's inbox;

sponsored by the ville de victoriaville

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Mehdi Hamidi  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Mehdi Hamidi  changed:

   What|Removed |Added

 CC||mehdi.ham...@inlibro.com

--- Comment #29 from Mehdi Hamidi  ---
Hello Kyle,

this patch now sends email to both the guarantor and the guarantee. The 
generation of the notice is still based on the guarantee messaging settings.

Mehdi.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16963] New: Remove the use of "onclick" from subscription add template

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16963

Bug ID: 16963
   Summary: Remove the use of "onclick" from subscription add
template
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com,
testo...@bugs.koha-community.org

There are many uses of "onclick" and other event attributes in the subscription
add template. This bug will track changes to subscription-add.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6934] New report Cash Register Statistics

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6934

--- Comment #87 from Héctor Eduardo Castro Avalos  
---
Created attachment 53648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53648&action=edit
Bug 6934: Fix the href for datables in link rel stylesheet

Fix the new path for 'datatables.css'

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16202] Rental fees can be generated for fractions of a penny/cent

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16202

--- Comment #4 from Colin Campbell  ---
(In reply to M. Tompsett from comment #2)
> Comment on attachment 49907 [details] [review]
> Proposed Patch
> 
> Review of attachment 49907 [details] [review]:
> -
> 
> ::: C4/Circulation.pm
> @@ +3209,5 @@
> >  my $discount = _get_discount_from_rule($discount_rules, 
> > $branch, $item_type);
> >  $charge = ( $charge * ( 100 - $discount ) ) / 100;
> >  }
> > +if ($charge) {
> > +$charge = sprintf '%.2f', $charge; # ensure no fractions of a 
> > penny returned
> 
> This is not identical to the %.02f from line 984 before. Please add the 0
> back.

The value after the point is the number of decimal places presented the 0 is
meaningless in this context see the printf/sprintf documentation where it is
not used. ( 0 can be used on its own to suppress the decimal part). Using the
precision as documented is less ambiguous

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

--- Comment #1 from Owen Leonard  ---
Created attachment 53647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53647&action=edit
Bug 16962 - Remove the use of "onclick" from serial collection and serial edit
templates

This patch removes the use of event attributes like "onclick" from the
serial collection and serial edit templates. Events are now defined in
JavaScript.

Also changed: Converted "create routing list," "edit routing list," and
"Renew" links to Bootstrap buttons. The "select all" and "clear all"
links have Font Awesome icons added.

To test, apply the patch and go to Serials

- Locate or create a subscription for which an item record is NOT
  created when receiving.
  - On the serial collection page for this subscription, test that the
"Multi receiving" button works correctly.
- For any subscription, test that the "Generate next" button works
  correctly.
- In each tab, test that the "select all" and "clear all" links work
  correctly.
- On a subscription which has expired, test that the "Renew" button
  works correctly.
- On the serial collection page, select multiple issues and click the
  "Edit serials" button.
  - Testing with a subscription for which an item record is NOT created
when receiving:
- Changing the status to "Arrived" or "Claimed" should change the
  "Expected on" date to today's date. Selecting any other status
  should leave the "expected on" date as it was or return it to its
  original value.
- Test that the "Multi receiving" button works correctly.
  - Testing with a subscription for which an item record IS created when
receiving:
- Changing the status of an issue should work as above but should
  also trigger the appearance of the item add form when the status
  is "Arrived" or "Claimed," and hide the form otherwise.
- Cliking the "Item" link at the top of the item add form should
  hide it.
- Clicking the "Add item" link under any issue should display the
  item add form.
- In the item add form, test that repeatable fields are correctly
  duplicated when you click the "clone" button.
- On the "Supplemental issue" line, changing the status to "Arrived"
  should work as described above. Changing the status on this line
  to "Claimed" should only change the "Expected on" date.
- Adding regular and supplemental issues should work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16962] New: Remove the use of "onclick" from serial collection and serial edit templates

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Bug ID: 16962
   Summary: Remove the use of "onclick" from serial collection and
serial edit templates
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com,
testo...@bugs.koha-community.org

There are many uses of "onclick" and other event attributes in the Serials
module templates. This bug will track changes to serials-collection.tt and
serials-edit.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937

Owen Leonard  changed:

   What|Removed |Added

  Attachment #53529|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 53646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53646&action=edit
[SIGNED-OFF] Bug 16937 [Revised] Remove "onclick" from the manage staged MARC
records template

This patch revises the manage staged MARC records template, removing
"onclick" attributes from the markup and defining those events in the
script.

To test, apply the patch and go to Tools -> Manage staged MARC records.

- If necessary, stage a MARC file for import.
- Click the name of the staged file and then the "Import this batch into
  the catalog" button. The batch should be correctly imported.
- Return to the list of staged MARC files.
- Click the name of an imported file and then the "Undo import into
  catalog" button. The import should be reverted.
- Return to the list of staged MARC files.
- Click the "Clean" button for any record. Confirm that the batch is
  cleaned.
- For any cleaned record, click the "Delete" button. The batch should be
  deleted.

Signed-off-by: Hector Castro 
Works as advertised

QA revision: Corrected class name so that "delete" button triggers the
correct warning.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16937] Remove the use of "onclick" from the manage staged MARC records template

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16937

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14578] Allow merging of records upon import match

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578

Nicole C. Engard  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |k...@bywatersolutions.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13630] Angular-based circulation client

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630

Nicole C. Engard  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |k...@bywatersolutions.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

Nicole C. Engard  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |k...@bywatersolutions.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16961] Add the Koha::Objects->update method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16961] Add the Koha::Objects->update method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961

--- Comment #1 from Jonathan Druart  
---
Created attachment 53645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53645&action=edit
Bug 16961: Add Koha::Objects->update

In order to update several rows in a single query, we need this new
method.

Test plan:
Confirm that the changes in Objects.t make sense and that the tests
pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16961


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961
[Bug 16961] Add the Koha::Objects->update method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16961] Add the Koha::Objects->update method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||13019


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
[Bug 13019] Add base classes on which to build Koha objects
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16961] New: Add the Koha::Objects->update method

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16961

Bug ID: 16961
   Summary: Add the Koha::Objects->update method
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

In order to update several rows in a single query, we need this new method.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #58 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #57)
> Kyle, bug 16929 has been introduced by these patches.
> Actually it seems that the changes made to Koha::Patron::Modification[s]
> were not intended. Could you confirm?

Should be bug 16960.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16949] Batch record deletion says success when no records have been passed in

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16949

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Owen Leonard  ---
I think a client-side check is also in order: Don't submit the form if no
titles are checked. That's standard for similar interfaces in Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953

Claire Gravely  changed:

   What|Removed |Added

  Attachment #53643|0   |1
is obsolete||

--- Comment #6 from Claire Gravely  ---
Created attachment 53644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53644&action=edit
Bug 16953: Acquisitions home: Remove trailing › from breadcrumbs

The breadcrumb on the Acquisition's home page reads: Home > Acquisitions >
This tiny patch removes the trailing > (›)

Amended: Remove the link on 'Acquisitions' as well...
Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16953] Acquisitions home: Remove trailing › from breadcrumbs

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16953

Marc Véron  changed:

   What|Removed |Added

  Attachment #53559|0   |1
is obsolete||

--- Comment #5 from Marc Véron  ---
Created attachment 53643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53643&action=edit
Bug 16953: Acquisitions home: Remove trailing › from breadcrumbs

The breadcrumb on the Acquisition's home page reads: Home > Acquisitions >
This tiny patch removes the trailing > (›)

Amended: Remove the link on 'Acquisitions' as well...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16910] Authority search plugin in cataloguing stops at 15 pages

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16910

--- Comment #3 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #2)
> Maybe we could fix the display somehow if not the search? Or did you mean
> about keeping the complexity?

Please detail, I do not understand :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #57 from Jonathan Druart  
---
Kyle, bug 16929 has been introduced by these patches.
Actually it seems that the changes made to Koha::Patron::Modification[s] were
not intended. Could you confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #2 from Jonathan Druart  
---
Upgrading the severity.
I have completely missed that on QAing bug 14757, I focused on the notices code
and did not see this part!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||14757
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757
[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16960


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960
[Bug 16960] Patron::Modifications should be fixed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16910] Authority search plugin in cataloguing stops at 15 pages

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16910

--- Comment #2 from Katrin Fischer  ---
Maybe we could fix the display somehow if not the search? Or did you mean about
keeping the complexity?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16960

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16929

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #1 from Marcel de Rooy  ---
Not to mention the random stuff interfering here too :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] New: Patron::Modifications should be fixed

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Bug ID: 16960
   Summary: Patron::Modifications should be fixed
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The changes from opac-memberentry do not reach the table, since the
Patron::Modifications object does not work well.

Look at this from opac-memberentry:
Koha::Patron::Modifications->new( borrowernumber => $borrowernumber );
Passing borrowernumber here is useless, since it is an instance of
Koha::Objects.
On the contrary, the following call
$m->DelModifications;
should have the borrowernumber passed !

So what could we add a sub new to Patron::Modifications like:
+sub new {
+my ( $class, $params ) = @_;
+my $self = $class->SUPER::new();
+$self->{borrowernumber} = $params->{borrowernumber};
+return $self;
+}
And in opac-memberentry:
+my $patronmod = Koha::Patron::Modifications->new({ borrowernumber
=> $borrowernumber });
+$patronmod->DelModifications({ borrowernumber => $borrowernumber
});
+$patronmod->AddModifications(\%borrower_changes);


But this is a horrible hack. We should not use a Koha::Objects like that..
And what about its unit test:  t/db_dependent/Koha_borrower_modifications.t
Currently fails !

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

2016-07-22 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16878

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   >