[Koha-bugs] [Bug 17052] Patron category description not displayed in the sidebar of paycollect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Brendon Ford  changed:

   What|Removed |Added

 CC||brendon.f...@manhattan.edu

--- Comment #6 from Brendon Ford  ---
Very sorry about all the sign off's. I'm still learning git-bz.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17052] Patron category description not displayed in the sidebar of paycollect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Brendon Ford  changed:

   What|Removed |Added

  Attachment #54045|0   |1
is obsolete||
  Attachment #54060|0   |1
is obsolete||

--- Comment #5 from Brendon Ford  ---
Created attachment 54061
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54061=edit
[SIGNED-OFF] Bug 17052: Display patron category description in the sidebar of
paycollect

The patron category description is not passed to the template in
paycollect.pl

Note: The Categories TT plugin should be used here...

Test plan:
Go on paycollect.pl and confirm that the patron category description is
now displayed in the sidebar.

Signed-off-by: Owen Leonard 
Signed-off-by: Brendon Ford 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17052] Patron category description not displayed in the sidebar of paycollect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Brendon Ford  changed:

   What|Removed |Added

  Attachment #54059|0   |1
is obsolete||

--- Comment #4 from Brendon Ford  ---
Created attachment 54060
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54060=edit
Bug 17052: Display patron category description in the sidebar of paycollect

The patron category description is not passed to the template in
paycollect.pl

Note: The Categories TT plugin should be used here...

Test plan:
Go on paycollect.pl and confirm that the patron category description is
now displayed in the sidebar.

Signed-off-by: Owen Leonard 
Signed-off-by: Brendon Ford 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17052] Patron category description not displayed in the sidebar of paycollect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

--- Comment #3 from Brendon Ford  ---
Created attachment 54059
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54059=edit
Bug 17052: Display patron category description in the sidebar of paycollect

The patron category description is not passed to the template in
paycollect.pl

Note: The Categories TT plugin should be used here...

Test plan:
Go on paycollect.pl and confirm that the patron category description is
now displayed in the sidebar.

Signed-off-by: Owen Leonard 
Signed-off-by: Brendon Ford 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16556] KohaToMarcMapped columns sharing same field with biblio(item) number are removed.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16556

Christopher Davis  changed:

   What|Removed |Added

 CC||mr.catalo...@gmail.com

--- Comment #4 from Christopher Davis  ---
Olli-Antti Kivilahti,

I was taking a look at this bug and I could not find any patch or test plan.
Will you please add these to this bug report?

Thank you,

Christopher Davis

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17061] New: Toll Free-HP((( 1˜8˜44˜305˜55˜65))) printer support phone number Florida

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17061

Bug ID: 17061
   Summary: Toll Free-HP(((1˜8˜44˜305˜55˜65)))printer support
phone number Florida
 Change sponsored?: ---
   Product: Project Infrastructure
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Project website
  Assignee: wizzy...@gmail.com
  Reporter: dil...@yopmail.com

usaHow @@cow Hp printer support phone number ((1844))-305-5565Hp printer
support phone number usa How how ((1844))-305-5565Hp printer support phone
number@@@ Hp printer PrinTer call @ .1-844 305 5565.Support Phone
Number,Hp printer tech support number, Hp Printer Customer Care Phone Number
USA&&& Hp printer PrinTer call @ .1-844 305 5565.Support Phone
Number,Hp printer tech support number, Hp Printer Customer Care Phone Number
USA Testing ((1844))-305-5565Hp printer support phone number Hp printer phone
number status @PrinTer .1-844 305 5565 .Support Phone Number,Hp printer tech
support number, Hp Printer Customer Care Phone Number uSa 
CALL%Hp Printer tech Support Number @1-844 305 5565@ Hp Printer
Tech Support Phone Number Call wireless 1-844 305 5565 1-844-305-5565 Hp Tech
Support Phone Number Canada Hp printer customer service number1-844 305 5565 Hp
support number, Hp support, Hp printer support, Hp tech support, Hp technical
support, Hp customer service number, Hp customer service, Hp tech support
number, Hp support center, Hp printer support number, hewlett packard support,
Hp contact number, Hp phone number, Hp help and support, Hp customer support,
Hp printer help, Hp technical support number, Hp support phone number, hewlett
packard customer service, Hp printers support, Hp customer service phone
number, Hp number, Hp customer care, Hp contact, Hp tech support phone number,
Hp support chat, Hp customer support number, Hp customer care number, contact
Hp support, Hp help, Hp phone, Hp printer support phone number, Hp customer
support phone number, Hp printer tech support, Hp phone support, Hp technical
support phone number, Hp pRINTER support number, hewlett packard printer
support, Hp helpline, Hp telephone support, Hp online support, Hp support
contact, Hp chat support, hewlett packard phone number, Hp printer customer
service, Hp printer tech support number, Hp product support, hewlett packard
customer service phone number, Hp computer support number, Hp support contact
number, Hp support printer, Hp computer support, Hp tech support chat, Hp
helpline number, Hp pRINTER support, hewlett packard tech support, Hp online
chat, hewlett packard technical support, Hp printer help line, phone number for
Hp support, hewlett packard support phone number, Hp printer technical support,
hewlett packard customer service number, Hp service number, hewlett packard
helpline, Hp customer care no, Hp printer customer service number, Hp help
number, Hp printer customer service phone number, Hp 1305 number, Hp support
phone, Hp support line, hewlett packard contact number, Hp printer tech support
phone number, Hp printer customer support phone number, Hp printers help, call
Hp support, Hp printer support chat, hewlett packard support number, hewlett
packard tech support number, Hp support telephone number, hewlett packard tech
support phone number, call Hp, Hp contact support, hewlett packard technical
support phone number, Hp support centre, hewlett packard customer support, Hp
desktop support, Hp pRINTER customer service, contact Hp printer support, Hp pc
support, Hp pRINTER customer care number, Hp support for printers, Hp printer
customer care, Hp customer care phone number, hewlett packard help, phone
number for Hp, Hp online help, Hp pRINTER customer care, Hp helpline phone
number, Hp printer customer support, Hp technical support chat, Hp computer
help, Hp support numbers, Hp technical support contact number, Hp telephone
number, Hp printer technical support phone number, Hp printer helpline, Hp
support printers, Hp support online, Hp printer contact number, Hp help phone
number, Hp printer customer care number, contact hewlett packard by phone, Hp
printer phone support, hewlett packard printers support, Hp tech support phone,
Hp technical help, Hp pRINTER tech support number, contact Hp by phone, Hp
support call, Hp computers support, hewlett packard customer service telephone
number, phone number for hewlett packard, Hp online support chat, Hp pRINTER
customer service number, Hp online chat support, Hp printers customer service,
hewlett packard customer service phone, Hp pRINTER tech support, Hp service
phone number, hewlett packard printer help, phone number for Hp printers, Hp
troubleshooting phone number, Hp 305 number, hewlett packard technical support
number, contact Hp support phone, phone number for Hp printer support, Hp

[Koha-bugs] [Bug 17059] New: Toll Free-HP(((1~844~305~5565))) printer TECH support phone number Florida

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17059

Bug ID: 17059
   Summary: Toll Free-HP(((1~844~305~5565)))printer TECH support
phone number Florida
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: dil...@yopmail.com
QA Contact: testo...@bugs.koha-community.org

hp printer support number
hp printer support phone number
hp support
hp printer support chat
hp printers
koobface
canon printer support number
brother printer support number
hp printer troubleshooting
 hp printer support phone number
hp printer tech support phone number
hewlett packard printer support phone number
hp printer support telephone number
hp printer support center
dell printer support phone number
brother printer support phone number
hp printer support chat
canon printer support phone number
hp printer support telephone number
hp printer support center
canon printer support phone number
hp ink customer service number
hp printer support chat
dell printer support phone number
hewlett packard printer support phone number
epson printer support phone number
brother printer support phone number
hp ink customer service number
hp instant ink
hp instant ink customer service phone number
compaq warranty number
hp laptop customer service phone number
hp technical support number
hp support chat
hp printer support telephone number
hp customer support software and driver downloads
hp technical support number
hp technical support chat
hp customer service number
hp technical support number india
hp technical support number toll free
dell technical support number
compaq technical support number
sony technical support number
hp computer support number
hp customer service number
hp computer customer service number
hp support
hp laptop customer service number
hp printers
hewlett packard number
hp instant ink customer service number
hp customer service phone number get human
hp customer service number for printers
hp support
hp printer support
hp printers
hp support center
hp drivers
hp support chat
hp support parts
hp support forum
hp support assistant
 hp printer problems
hp wireless printer problems
hp inkjet printer problems
hp printer installation problems
hp printer driver problems
hp printers
hp printer problems with mac
hp laserjet printer problems
hp photo printer problems
 hp inkjet printer problems
hp laser printer problems
hp laserjet printer problems
hp mouse problems
hp inkjet printer problems and solutions
hp inkjet printer reviews
hp inkjet printer settlement
hp inkjet printer cartridge
hp large format inkjet printers
hp inkjet printer reviews
hp inkjet printers
hp inkjet printer reviews 2015
dell inkjet printer reviews
hp laser printer reviews
hp laserjet printer reviews
best inkjet printer
best color inkjet printer
best color inkjet printer 2015

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10102] don't show empty novelist tab if no data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10102

Patricia Brauer  changed:

   What|Removed |Added

 CC||tric...@roundrocktexas.gov

--- Comment #2 from Patricia Brauer  ---
Nick-
Sorry ignore my comment. Having browser problems. Tricia B.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15772] GetNormalizedISBN returns a 10 digit ISBN - should return 13

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15772

Patricia Brauer  changed:

   What|Removed |Added

 CC||tric...@roundrocktexas.gov

--- Comment #1 from Patricia Brauer  ---
Nick -- Is this still open? There's no work, no test plan.

Tricia Brauer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2532] Patron-requested holds limited to one item per bib.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2532

Eric Phetteplace  changed:

   What|Removed |Added

 CC||ephettepl...@cca.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

rkui...@roundrocktexas.gov changed:

   What|Removed |Added

 CC||rkui...@roundrocktexas.gov

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16568] Talking Tech generates phone notifications for all overdue actions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16568

Chris Rohde  changed:

   What|Removed |Added

 CC||cro...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16680] Library name are not displayed for holds in transit

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16680

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17058] Automatic renewals broken when BorrowerRenewalPeriodBase is set to current day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17058

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|Automatic renewals  |Automatic renewals broken
   ||when
   ||BorrowerRenewalPeriodBase
   ||is set to current day

--- Comment #1 from Katrin Fischer  ---
I changed the bug title a bit to have a bit more information - those are also
used for printing the release notes later :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7441] Search results showing wrong branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #83 from Frédéric Demians  ---
(In reply to Frédéric Demians from comment #81)
> When executing atomicupdate/bug_7441.sql, I get this error:
> 
> Bareword found where operator expected at
> ./installer/data/mysql/atomicupdate/bug_7441.sql line 1, near ") VALUES"
> (Missing operator before VALUES?)
> syntax error at ./installer/data/mysql/atomicupdate/bug_7441.sql line 2,
> near ") VALUES
> "

Forget this! The SQL statement works properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7441] Search results showing wrong branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #52811|0   |1
is obsolete||

--- Comment #82 from Frédéric Demians  ---
Created attachment 54058
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54058=edit
Bug 7441 - Followup search results showing wrong branch [UNIMARC]

Signed-off-by: Frédéric Demians 
  Playing with OPACResultsLibrary syspref, biblio with items having different
  home/holding library are displayed properly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7441] Search results showing wrong branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7441] Search results showing wrong branch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #81 from Frédéric Demians  ---
When executing atomicupdate/bug_7441.sql, I get this error:

Bareword found where operator expected at
./installer/data/mysql/atomicupdate/bug_7441.sql line 1, near ") VALUES"
(Missing operator before VALUES?)
syntax error at ./installer/data/mysql/atomicupdate/bug_7441.sql line 2, near
") VALUES
"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17058] Automatic renewals

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17058

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17058] New: Automatic renewals

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17058

Bug ID: 17058
   Summary: Automatic renewals
 Change sponsored?: ---
   Product: Koha
   Version: 3.22
  Hardware: PC
OS: Windows
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: victoria.k...@flower-mound.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Setting "BorrowerRenewalPeriodBase" to CURRENT DATE negates automatic renewal
for all items.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning, and contracts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #52476|0   |1
is obsolete||

--- Comment #6 from Frédéric Demians  ---
Created attachment 54057
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54057=edit
Bug 16754 - Use validation plugin in budgets, planning, and contracts

This patch removes the custom javascript form validation from three
templates: Budgets, budget planning, and contracts. Validation via the
validation plugin is done instead.

This patch also removes use of event attributes like onclick and
onchange. Also changed: I added the "Required" text next to required
fields as necessary.

To test, apply the patch and go to Administration -> Budgets.

- Test the budget creation process for adding, editing, and duplicating
  budgets. In all cases:
  - The start date and end date should be required
  - You should be warned if you enter an end date which falls before the
start date.
  - The description should be required
  - The budget amount should be required to be a number

To test the budget planning page:

Note that much of the JS removed from this template was unused. It
looked for inputs by the name 'est_total' which don't exist.

- When viewing the table of funds for a budget, select a choice from the
  'planning' toolbar menu.
  - Verify that after entering a numeric value in any cell, the
'remaning' value at the end of the row is correctly updated.
  - Verify that after entering non-numeric data an error is displayed.
  - Verify that clicking the 'auto-fill' button at the end of the row

To test the vendor contracts page:

- Go to Acquisitions -> Vendor -> Contracts
- Add or edit a contract
  - Confirm that name, start date, and end date are required.
  - Confirm that you are warned if you enter an end date which falls
before the start date.

Signed-off-by: Frédéric Demians 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning, and contracts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17014] Remove more event attributes from patron templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17014

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #2 from Frédéric Demians  ---
It works as described. Reading the code, and for the sake of discussion:

You have this:

$("#searchform").on("submit",function(){
return filter();
});

Why not directly:

$("#searchform").on("submit",filter);

Or, since filter() isn't used anywhere else, why not moving its code directly
above:

$("#searchform").on("submit",function(){
  // filter() code

And this old code:

var type_fees = new Array();
type_fees['L'] = '';
type_fees['F'] = '';
type_fees['A'] = '';
type_fees['N'] = '';
type_fees['M'] = '';

could be cleaned up:

var type_fees = {'L':'','F':'','A':'','N':'','M':''};

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17019] debian/changelog update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #53903|0   |1
is obsolete||

--- Comment #3 from Frédéric Demians  ---
Created attachment 54056
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54056=edit
Bug 17019 - debian/changelog update

This has not been updated for a while. I plan to add the stable
releases.

Signed-off-by: Frédéric Demians 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17019] debian/changelog update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17019

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17057] Remove event attributes from holds template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17057] Remove event attributes from holds template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057

--- Comment #1 from Owen Leonard  ---
Created attachment 54055
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54055=edit
Bug 17057 - Remove event attributes from holds template

This patch removes event attributes from the holds template. Events
are defined instead in the JavaScript.

Also changed: Move formatting of hold date to the template; Corrected a
non-functional 'cancel hold' link.

To test apply the patch and:

- Start the process of placing a hold on a single title for a
  patron.
  - Uncheck 'Place a hold on the next available item' and try to
submit the form without selecting an item. You should be prompted
to select an item.
- Place a hold on multiple titles at the same time. Confirm that your
  hold is saved correctly.
- View the holds for a title which has multiple holds.
  - Confirm that clicking the "X" image triggers a confirmation. Test
canceling and confirming.
  - With SuspendHoldsIntranet enabled, select a 'Suspend until' date for
any hold and confirm that the corresponding 'Clear date' link works
correctly.
  - Confirm that suspending a hold with and without an expiration date
works correctly.
- Place an item-level hold.
  - View the holds for that same title.
  - Submit another patron to place a new hold.
  - In the list of items which can be placed on hold, look for the item
you place on hold previously. There should be a "Cancel hold" link
in the information column. Confirm that this link correctly triggers
a confirmation dialog and deletes the hold.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17055] Add classes to different note types to allow for styling on checkins page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Jonathan Druart  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #4 from Jonathan Druart  
---
Amended test plan:
0/ Switch SessionRestrictionByIP on!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #3 from Jonathan Druart  
---
Created attachment 54054
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54054=edit
Bug 17050: Do not kicks the session out when accessing the REST API

Mojolicious does not set $ENV{REMOTE_ADDR} (and $ENV{HTTP_*} neither) as
it may share ENV between different requests.
Fortunately for us, Plack does not!

This is a dirty patch to fix this issue but it seems that there is not
lot of solutions. It adds a remote_addr parameter to
C4::Auth::check_cookie_authin order to send it from
Koha::Rest::V1::startup reading the headers sent by Mojolicious.

Test plan:
Hit /cgi-bin/koha/mainpage.pl
Hit /api/v1/patrons/42
Hit /cgi-bin/koha/mainpage.pl

With this patch applied, everything will be fine and you won't be
logged out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16826] Add API routes for getting item availability and holdability

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16826

Lari Taskula  changed:

   What|Removed |Added

  Attachment #53827|0   |1
is obsolete||

--- Comment #19 from Lari Taskula  ---
Created attachment 54053
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54053=edit
Bug 16826: Add API route for getting item availability

Signed-off-by: Jiri Kozlovsky 

Fixed small mistakes in documentation and removed itemnumberPathParam from
Swagger;
it belongs to Bug 16825.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] Add API route for getting an item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17032

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date with database

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Lari Taskula  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16825

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] Add API route for getting an item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #53923|0   |1
is obsolete||

--- Comment #14 from Lari Taskula  ---
Created attachment 54052
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54052=edit
Bug 16825: [QA Follow-up] Add 'new_status' to Swagger definition

Adds missing "new_status" to item's Swagger definition.

Signed-off-by: Jiri Kozlovsky 

Removed test for missing properties. It should be done in a separate context.
See Bug 17032.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17057] New: Remove event attributes from holds template

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057

Bug ID: 17057
   Summary: Remove event attributes from holds template
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org

reserve/request.tt contains several event attributes like "onclick" which
should be removed in favor of defining events in JavaScript.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005

--- Comment #9 from Lari Taskula  ---
Good work with the patch, Jiří!

I will sign-off, but first I would like to present some thoughts:
- Should we also allow user to access his own checkout history even if he does
not have circulate_remaining_permissions? I think this would need to consider
syspref 'opacreadinghistory'. Similar to Bug 13895.

- If GET /checkouts/history returns only issue_ids, should we come up with a
way to GET multiple issue_id's in one request? Say a client wants to display
all old checkouts for a patron on with detailed information for each checkout;
He makes a GET to /checkouts/history?borrowernumber=123. 1000 issue_ids are
returned. The question is, is it better to individually GET
/checkouts/history/1 ... /checkouts/history/1000 or do one request GET
/checkouts/history?issue_id=1+2+3+...+999+1000 ? Same like availability has in
Bug 16826.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17056] Remove event attributes from various templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17056] Remove event attributes from various templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056

--- Comment #1 from Owen Leonard  ---
Created attachment 54051
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54051=edit
Bug 17056 - Remove event attributes from various templates

This patch removes event attributes from several templates, moving event
definitions into the JavaScript instead.

To test, apply the patch and:

- View the MARC detail page for any bibliographic record. Changing the
  framework selection should reload the display using the selected
  framework.

- Perform the same test on the labeled MARC view. (Set the
  viewLabeledMARC system preference to "Allow" if necessary).

- To test the changes to Reports you should have at least one report
  group and at least one report subgroup.
  - Create a new saved SQL report.
  - Select a report group. Doing so should trigger the display of report
subgroups. Deselecting the report group should hide the subgroups.

- In Acquisitions -> Suggestions, create a new suggestion.
  - In the 'Acquisition information' section, changing values for
copies, currency, and price should change the value in the total
field.

- In Circulation -> Upload offline circulation file:
  - My patch for Bug 16602 added the required code but forgot to remove
the corresponding onclick attributes.
  - Browse for an offline circulation file.
  - Clicking the 'Upload file' button should work correctly.
- After uploading a file, both the 'Add to offline circulation
  queue' and 'Apply directly' buttons should work to trigger their
  corresponding processes (keeping Bug 16603 in mind).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17056] New: Remove event attributes from various templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17056

Bug ID: 17056
   Summary: Remove event attributes from various templates
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

I'm working on a patch which will remove event attributes from the following
templates:

catalogue/MARCdetail.tt
catalogue/labeledMARCdetail.tt
offline_circ/process_koc.tt
reports/guided_reports_start.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17030] Configure the REST api on packages install

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54012|0   |1
is obsolete||
  Attachment #54013|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 54049
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54049=edit
Bug 17030: Enable REST api on packages

This patch enables access to the REST API endpoint on packages setup.
It does so, by patching the shared apache-shared-intranet.conf and
apache-shared-opac.conf.

You can build your own master packages with this patch applied, or just:

- Grab
  debian/templates/apache-shared-intranet.conf
  debian/templates/apache-shared-opac.conf
and overwrite their counterparts in /etc/koha on a packages setup. For example
in kohadevbox.
- Have Koha loaded with all default data
- Create a superlibrarian user for you
- Login to the intranet and the OPAC
- Point your browser to:
  http://localhost:8080/api/v1/patrons/51
=> SUCCESS: You get JSON data, for the patron you requested
  http://localhost:8081/api/v1/patrons/51
=> SUCCESS: You get JSON data, for the patron you requested
- Sign off :-D

Note: I use the HTTPRequester addon for Firefox, re-using the CGISESSID value
from the
browser session cookie, in the headers.

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17044] Wrong destination for 'api' directory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53974|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 54048
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54048=edit
Bug 17044: Fix wrong destination for 'api' directory

The original Makefile.PL tweak missed to trim the directory name thus
repeating the 'api' directory like in 'api/api'.

To test:
- Make a standard install (for example in /usr/share/koha
=> FAIL: check /usr/share/koha/api/api exists
- Make a single install (for example in /home/tcohen/koha-single)
=> FAIL: check /home/tcohen/koha-single/api/api exists
- Apply the patch
- Make a standard install (for example in /usr/share/koha
=> SUCCESS: check /usr/share/koha/api exists and doesn't contain a nested 'api'
dir
- Make a single install (for example in /home/tcohen/koha-single)
=> SUCCESS: check /home/tcohen/koha-single/api exists and doesn't contain a
nested 'api' dir
- Sign off :-D

Note: this affects the packages too, as the standard install is used as a
basis.
Signed-off-by: Benjamin Rokseth 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17030] Configure the REST api on packages install

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

--- Comment #9 from Jonathan Druart  
---
Created attachment 54050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54050=edit
Bug 17030: Make REST api available on packages with plack enabled

This patch is the starting point for making the REST api available
on Plack.

What it does:
- It creates the /api/v1/app.pl mount point in plack.psgi
- It enables the ProxyPass and ProxyPassReverse directives so it
  is reached through Plack.
- It sets rewrite rules so we can use the 'pretty' urls (i.e.
  /api/v1/patrons instead of /api/v1/app.pl/api/v1/patrons).

To test:
- Grab the following files, and put them in /etc/koha (overwrite the existing
ones)
  debian/templates/apache-shared-intranet-plack.conf
  debian/templates/apache-shared-opac-plack.conf
- Tweak your /etc/koha/sites/kohadev/plack.psgi file so the API-related stuff
  is present on your file.
- Make sure Plack is enabled for the instance:
  $ sudo koha-plack --enable kohadev
  $ sudo koha-plack --restart kohadev
  $ sudo service apache2 restart
- Follow the previous patch test plan, but use this URLs (no pretty URL):

  http://localhost:8080/api/v1/app.pl/api/v1/patrons/50
  http://localhost:8081/api/v1/app.pl/api/v1/patrons/50
=> SUCCESS: You get a JSON response from the API [1]
- Not use this URLs:
  http://localhost:8080/api/v1/patrons/50
  http://localhost:8081/api/v1/patrons/50
=> SUCCESS: You get a JSON response from the API [1]
- Sign off :-D

[1] this patch made a bug visible (the session is lost when accessing the API
through
Plack) but it shouldn't prevent its inclusion because the API right now is not
even available
as default for developers to test or fix it.

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17030] Configure the REST api on packages install

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17030

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17044] Wrong destination for 'api' directory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17044

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17055] Add classes to different note types to allow for styling on checkins page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54046|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 54047
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54047=edit
[SIGNED-OFF] Bug 17055 - Add classes to different note types to allow for
styling on checkins page

Returned items may have 3 kinds of notes, patron, item public, and item
non-public. However, the html markup for them does not allow us to
distinguish which type we are seeing. It would be good to add classes
for each of these note types.

Test Plan:
1) Check out an item to a patron
2) Add a patron note, a public item note, and a non-public item note
   to the patron and item you used
3) Check in the item and instead the html, note the each note span
   now has a class to distinguish which type of note is being displayed.

Signed-off-by: Owen Leonard 



Current patch-complexity: Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17055] Add classes to different note types to allow for styling on checkins page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13414] Enable right truncation with search by relevance

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414

Barton Chittenden  changed:

   What|Removed |Added

   Severity|enhancement |normal
 CC||bar...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17055] Add classes to different note types to allow for styling on checkins page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Kyle M Hall  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17055] Add classes to different note types to allow for styling on checkins page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

--- Comment #1 from Kyle M Hall  ---
Created attachment 54046
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54046=edit
Bug 17055 - Add classes to different note types to allow for styling on
checkins page

Returned items may have 3 kinds of notes, patron, item public, and item
non-public. However, the html markup for them does not allow us to
distinguish which type we are seeing. It would be good to add classes
for each of these note types.

Test Plan:
1) Check out an item to a patron
2) Add a patron note, a public item note, and a non-public item note
   to the patron and item you used
3) Check in the item and instead the html, note the each note span
   now has a class to distinguish which type of note is being displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17055] Add classes to different note types to allow for styling on checkins page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17055] New: Add classes to different note types to allow for styling on checkins page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17055

Bug ID: 17055
   Summary: Add classes to different note types to allow for
styling on checkins page
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Returned items may have 3 kinds of notes, patron, item public, and item
non-public. However, the html markup for them does not allow us to distinguish
which type we are seeing. It would be good to add classes for each of these
note types.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16754] Use validation plugin in budgets, planning, and contracts

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16754

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #5 from Owen Leonard  ---
(In reply to Frédéric Demians from comment #4)

> - Pick a date. => The date is copied to the input box, but (1) it is red, and
>   (2) the message 'This field is required' is still displayed.

This is a problem not with this patch but with the way the validation plugin
works together with the datepicker widget. Now that I know of the problem I can
find it elsewhere too, for instance aqcontract.pl.

I can try to find a solution, but I would like to do so as a separate bug if
that's okay with everyone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17016] Button to clear all fields in budget planning

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17016

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard  ---
> After clicking on the auto-fill button the fields briefly populate, but then
> the page refreshes and they clear back to 0.00 again.

I get this too.

Could you please try to rework the patch so that it doesn't use an inline event
attribute? We shouldn't be adding new code which uses things attributes
"onclick."

The "edit_row" ID on the  is problematic because it is repeated for each
row in the table, thus it isn't unique. If you're looking for a hook to target
each individual row you could so something like 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #38 from Owen Leonard  ---
I find that it's not possible to make the "library" selection mandatory. Is
there a reason for that?

Note that there is a JS validation plugin available in the OPAC if you want to
use it. See opac-memberentry.tt for an example. The plugin can be set up to
validate a form based on the markup (requiring fields which are , so it's not
necessary to dynamically configure the fields in the JS if you don't want to.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17052] Patron category description not displayed in the sidebar of paycollect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54007|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 54045
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54045=edit
[SIGNED-OFF] Bug 17052: Display patron category description in the sidebar of
paycollect

The patron category description is not passed to the template in
paycollect.pl

Note: The Categories TT plugin should be used here...

Test plan:
Go on paycollect.pl and confirm that the patron category description is
now displayed in the sidebar.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17052] Patron category description not displayed in the sidebar of paycollect

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17052

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54036|0   |1
is obsolete||

--- Comment #81 from Owen Leonard  ---
Created attachment 54044
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54044=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Do not select an option if selected
is defined

This will certainly need a few more tweaks.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54034|0   |1
is obsolete||

--- Comment #79 from Owen Leonard  ---
Created attachment 54042
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54042=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54033|0   |1
is obsolete||

--- Comment #78 from Owen Leonard  ---
Created attachment 54041
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54041=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Move onlymine to
C4::Context::only_my_library

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54035|0   |1
is obsolete||

--- Comment #80 from Owen Leonard  ---
Created attachment 54043
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54043=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54032|0   |1
is obsolete||

--- Comment #77 from Owen Leonard  ---
Created attachment 54040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54040=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Remove GetBranches

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54029|0   |1
is obsolete||

--- Comment #74 from Owen Leonard  ---
Created attachment 54037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54037=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Remove GetBranchName

This is the fourth and last patch set to remove C4::Branch.
The real purpose of this patch is to standardise and refactor some code
which is related to the libraries selection/display.
Its unconfessed purpose is to remove the C4::Branch package.

Before this patch set, only 6 subroutines still existed in the C4::Branch
package:
- GetBranchName
- GetBranchesLoop
- mybranch
- onlymine
- GetBranches
- GetBranch

GetBranchName basically returns the branchname for a given branchcode.
The branchname is only used for a display purpose and we don't need to
retrieve it in package or pl scripts (unless for a few exceptions).
We have a `Branches` template plugin with a `GetName` method which does
exactly this job.
To achieve this removal, we will use this template plugin and delete the
GetBranchName from pl and pm files.
The `Branches.all()` will now select the library of the logged in user
if no `selected` parameter has been passed.
This new behavior could cause regressions, for instance there are some
places where we do not want an option preselected (batch item
modification for instance), keep that in mind when testing.

GetBranchesLoop took 3 parameters: $branch and $onlymine.
The first one was used to set a "selected" flag, for a display purpose:
select an option in the libraries dropdown lists.
The second one was useless: If not passed or set to 0, the
`C4::Branch::onlymine` subroutine was called.
This onlymine flag was use to know if the logged in user was able to see
other libraries infos.
A patron can see the infos from other libraries if IndependentBranches
is not set OR if he has the superlibrarian permission.
Prior to this patch set, the "onlymine test" was done on different
places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the
Branches TT plugin. In this patch set, this test is only done on one
place (C4::Context::only_my_library, code moved from
C4::Branch::onlymine).
To accomplish the same job as this subroutine, we just need to call the
`Branches.all()` method from the `Branches` TT plugin. It already
accepts a `selected` parameter to set a flag on the option to select.
To avoid the repetitive
  [% IF selected %][% ELSE %][% END %]
pattern, a new `html_helpers` TT include file has been created, it
defines an `options_for_libraries` block, which takes a `selected`
parameter. We could imagine to use this include file for other
selects.

The 'mybranch` and `onlymine` subroutines of the C4::Branch package have
been moved to C4::Context. onlymine has been renamed with
only_my_library. There are only 4 occurrences of it, against 11 before
this patch set.
There 2 subroutines are Context-centric and it makes sense to put them
in `C4::Context` (at least it's the least worst place!)

GetBranches is the tricky part of this patch set: It retrieves all the
libraries, independently of the value of IndependentBranches.
To keep the same way as the existing calls of `Branches.all()`, I have
added a `unfiltered` parameter. If set, the `Branches.all()` will call
a usual Koha::Libraries->search method, otherwise
Koha::Libraries->search_filtered will be called. This new method will
check if the logged in user is allowed to see other libraries or only
its library.
Note that this `GetBranches` subroutine also created a `category` key:
it allowed to get the list of groups (of libraries) where this library
existed. Thanks to a previous patch set (bug 15295), this value was
not used anymore (I may have missed something!).

Note that the only use of `GetBranch` was buggy (see bug 15746).

Test plan (for the whole patch set):
The best way to test this whole patch set is to test with 2 instances: 1
with the patch set applied, 1 using master, to be sure there is no
regression.
It would be good to test the same with `IndependentBranches` and the
without `IndependentBranches`.
No difference should be found.
The tester must focus on the library dropdowns on as many forms as
possible.
You will notice changes in the order of the options: the libraries will
now be ordered by branchname (instead of branchcode in some places).
A special attention will be given to the following page:
- acqui/neworderempty.pl
- catalogue/search.pl
- members/members-home.pl (header?)
- opac/opac-topissues.pl
- tools/holidays.pl
- admin/branch_transfer_limits.pl
- admin/item_circulation_alerts.pl
- rotating_collections/transferCollection.pl
- suggestion/suggestion.pl
- 

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54030|0   |1
is obsolete||

--- Comment #75 from Owen Leonard  ---
Created attachment 54038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54038=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Remove GetBranchesLoop

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54031|0   |1
is obsolete||

--- Comment #76 from Owen Leonard  ---
Created attachment 54039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54039=edit
[SIGNED-OFF] Bug 15758: Koha::Libraries - Move mybranch to C4::Context

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050

--- Comment #2 from Jonathan Druart  
---
(In reply to Benjamin Rokseth from comment #1)
> Just a sidenote: We experienced the same issue in our plack+REST setup, and
> found out it was due to a syspref: SessionRestrictionByIP
> 
> When we disabled this (enabled by default) the problem went away.
> Don't know if it is related, though.

Confirmed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54004|0   |1
is obsolete||

--- Comment #73 from Jonathan Druart  
---
Created attachment 54036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54036=edit
Bug 15758: Koha::Libraries - Do not select an option if selected is defined

This will certainly need a few more tweaks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54001|0   |1
is obsolete||

--- Comment #70 from Jonathan Druart  
---
Created attachment 54033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54033=edit
Bug 15758: Koha::Libraries - Move onlymine to C4::Context::only_my_library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54003|0   |1
is obsolete||

--- Comment #72 from Jonathan Druart  
---
Created attachment 54035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54035=edit
Bug 15758: Koha::Libraries - Add tests for the Branches TT plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54000|0   |1
is obsolete||

--- Comment #69 from Jonathan Druart  
---
Created attachment 54032
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54032=edit
Bug 15758: Koha::Libraries - Remove GetBranches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53999|0   |1
is obsolete||

--- Comment #68 from Jonathan Druart  
---
Created attachment 54031
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54031=edit
Bug 15758: Koha::Libraries - Move mybranch to C4::Context

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53998|0   |1
is obsolete||

--- Comment #67 from Jonathan Druart  
---
Created attachment 54030
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54030=edit
Bug 15758: Koha::Libraries - Remove GetBranchesLoop

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54002|0   |1
is obsolete||

--- Comment #71 from Jonathan Druart  
---
Created attachment 54034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54034=edit
Bug 15758: Koha::Libraries - Ultimate duel for C4::Branch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53997|0   |1
is obsolete||

--- Comment #66 from Jonathan Druart  
---
Created attachment 54029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54029=edit
Bug 15758: Koha::Libraries - Remove GetBranchName

This is the fourth and last patch set to remove C4::Branch.
The real purpose of this patch is to standardise and refactor some code
which is related to the libraries selection/display.
Its unconfessed purpose is to remove the C4::Branch package.

Before this patch set, only 6 subroutines still existed in the C4::Branch
package:
- GetBranchName
- GetBranchesLoop
- mybranch
- onlymine
- GetBranches
- GetBranch

GetBranchName basically returns the branchname for a given branchcode.
The branchname is only used for a display purpose and we don't need to
retrieve it in package or pl scripts (unless for a few exceptions).
We have a `Branches` template plugin with a `GetName` method which does
exactly this job.
To achieve this removal, we will use this template plugin and delete the
GetBranchName from pl and pm files.
The `Branches.all()` will now select the library of the logged in user
if no `selected` parameter has been passed.
This new behavior could cause regressions, for instance there are some
places where we do not want an option preselected (batch item
modification for instance), keep that in mind when testing.

GetBranchesLoop took 3 parameters: $branch and $onlymine.
The first one was used to set a "selected" flag, for a display purpose:
select an option in the libraries dropdown lists.
The second one was useless: If not passed or set to 0, the
`C4::Branch::onlymine` subroutine was called.
This onlymine flag was use to know if the logged in user was able to see
other libraries infos.
A patron can see the infos from other libraries if IndependentBranches
is not set OR if he has the superlibrarian permission.
Prior to this patch set, the "onlymine test" was done on different
places (neworderempty.pl, additem.pl, holidays.pl, etc.), including the
Branches TT plugin. In this patch set, this test is only done on one
place (C4::Context::only_my_library, code moved from
C4::Branch::onlymine).
To accomplish the same job as this subroutine, we just need to call the
`Branches.all()` method from the `Branches` TT plugin. It already
accepts a `selected` parameter to set a flag on the option to select.
To avoid the repetitive
  [% IF selected %][% ELSE %][% END %]
pattern, a new `html_helpers` TT include file has been created, it
defines an `options_for_libraries` block, which takes a `selected`
parameter. We could imagine to use this include file for other
selects.

The 'mybranch` and `onlymine` subroutines of the C4::Branch package have
been moved to C4::Context. onlymine has been renamed with
only_my_library. There are only 4 occurrences of it, against 11 before
this patch set.
There 2 subroutines are Context-centric and it makes sense to put them
in `C4::Context` (at least it's the least worst place!)

GetBranches is the tricky part of this patch set: It retrieves all the
libraries, independently of the value of IndependentBranches.
To keep the same way as the existing calls of `Branches.all()`, I have
added a `unfiltered` parameter. If set, the `Branches.all()` will call
a usual Koha::Libraries->search method, otherwise
Koha::Libraries->search_filtered will be called. This new method will
check if the logged in user is allowed to see other libraries or only
its library.
Note that this `GetBranches` subroutine also created a `category` key:
it allowed to get the list of groups (of libraries) where this library
existed. Thanks to a previous patch set (bug 15295), this value was
not used anymore (I may have missed something!).

Note that the only use of `GetBranch` was buggy (see bug 15746).

Test plan (for the whole patch set):
The best way to test this whole patch set is to test with 2 instances: 1
with the patch set applied, 1 using master, to be sure there is no
regression.
It would be good to test the same with `IndependentBranches` and the
without `IndependentBranches`.
No difference should be found.
The tester must focus on the library dropdowns on as many forms as
possible.
You will notice changes in the order of the options: the libraries will
now be ordered by branchname (instead of branchcode in some places).
A special attention will be given to the following page:
- acqui/neworderempty.pl
- catalogue/search.pl
- members/members-home.pl (header?)
- opac/opac-topissues.pl
- tools/holidays.pl
- admin/branch_transfer_limits.pl
- admin/item_circulation_alerts.pl
- rotating_collections/transferCollection.pl
- 

[Koha-bugs] [Bug 17004] REST API: add route to authenticate patron ( Single Sign On - SSO)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

--- Comment #4 from Lari Taskula  ---
(In reply to Jiri Kozlovsky from comment #2)
> (In reply to Lari Taskula from comment #1)
> > We have implemented userid/cardnumer & password CGISESSID-authentication. I
> > will rebase it on master and upload the patch here.
> 
> That's nice! So don't you mind me to put your solution here on bugzilla
> rebased on master with current REST API conventions?
> 
> I've found your implementation here:
> https://github.com/KohaSuomi/kohasuomi/blob/kohasuomi3.16/api/v1/swagger/
> paths/auth.json (the POST method)
> 
> I think it would go quiet quick if I omit your dependencies of the
> PageObject-tests.
Since our authentication is based on Authentication rewrite (Bug 13920 and its
dependencies), it's a bit too much work for me to rebase here now, so instead I
decided to write a simple patch from scratch using session, that you can use
for testing if you wish. You can mark that patch obsolete if you wish to work
on this Bug more!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17004] REST API: add route to authenticate patron ( Single Sign On - SSO)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

--- Comment #3 from Lari Taskula  ---
Created attachment 54028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54028=edit
Bug 17004: Add API route to authenticate patron (CGISESSID)

This patch adds a username/cardnumber and password authentication that returns
a session.

POST /auth/session (login)

Required form data:
- "password"
- either "userid" or "cardnumber".

To test:
1. Make sure you are logged out from Koha.
2. Make a POST request to http://yourlibrary/api/v1/auth/session with form data
   "userid" =>  and "password" => .
3. If your userid and password is correct, you should be returned with most
   basic patron data and your CGISESSID.
4. Also attempt with invalid login to get an error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17004] REST API: add route to authenticate patron ( Single Sign On - SSO)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004

Jiri Kozlovsky  changed:

   What|Removed |Added

 Status|NEW |In Discussion
Summary|REST API: add route to  |REST API: add route to
   |authenticate patron |authenticate patron (Single
   ||Sign On - SSO)

--- Comment #2 from Jiri Kozlovsky  ---
(In reply to Lari Taskula from comment #1)
> We have implemented userid/cardnumer & password CGISESSID-authentication. I
> will rebase it on master and upload the patch here.

That's nice! So don't you mind me to put your solution here on bugzilla rebased
on master with current REST API conventions?

I've found your implementation here:
https://github.com/KohaSuomi/kohasuomi/blob/kohasuomi3.16/api/v1/swagger/paths/auth.json
(the POST method)

I think it would go quiet quick if I omit your dependencies of the
PageObject-tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

--- Comment #10 from Jonathan Druart  
---
Created attachment 54027
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54027=edit
Bug 16960: Update 1 missing occurrence of GetModifications

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16960] Patron::Modifications should be fixed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x option switch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #10 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.03.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16946] Remove the use of "onclick" from several serials templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16946] Remove the use of "onclick" from several serials templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16946

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54009|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 54026
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54026=edit
Bug 16946 [Revised] Remove the use of "onclick" from several serials templates

This patch modifies several serials module templates to remove the use
of event attributes. Events will now be defined in JavaScript.

Also changed:

- In Serials -> Check expiration, custom form validation has been
  removed in favor of validation with the plugin.
- In Serials -> Claims, the "Clear filter" button has been replaced with
  a link. Error messages are now styled with the standard "alert" class.
- In Serials -> New subscription -> Search for record, the "choose" link
  is now a Bootstrap button. Pagination links are now styled like other
  similar links. The "Close" button is now styled as in other popup
  windows. The "no results found" messages is styled as an informational
  dialog.
- In Serials -> Subscription -> Edit routing list, the "add recipients"
  and "delete all" controls are now links with Font Awesome icons.

To test, apply the patch and:

- Go to Serials -> Check expiration.
  - Try to submit the form without filling in a date. The form
validation plugin should warn you that the date field is required.
  - Submit the form using data which will return results.
  - Click the "Renew" button for any result. The subscription renewal
popup should be triggered for the correct title.

- Go to Serials -> Claims.
  - Select a vendor with missing issues.
  - Confirm that the date filter works correctly, and that the "Clear
filter" link works.
  - Select one or more result and click the "Send notification" button.
The notification should be sent.

- Go to Serials -> New subscription.
  - Click the "Search for record" link to trigger the bibliographic
search popup.
  - Perform a search. Confirm that the "Choose" button selects the
correct record and populates the fields in the parent window.

- Go to Serials -> Subscription -> Edit routing list.
  - Confirm that the process of adding recipients to the list works
correctly.
  - Confirm that changing the rank of any recipient works correctly.
  - Save the routing list and click the "Save and preview routing slip"
button on the confirmation page. The slip preview should open.
  - In the slip preview window, test that the print button works
correctly.

Signed-off-by: Aleisha 

QA revision: Removed stray '// -->' and corrected clear filter function

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17041] Fix missing properties in Swagger definition for Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17042] Fix missing properties in Swagger definition for Hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date with database

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #9 from Jonathan Druart  
---
Thanks Lari!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17042] Fix missing properties in Swagger definition for Hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |la...@student.uef.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17041] Fix missing properties in Swagger definition for Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |la...@student.uef.fi
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date with database

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |la...@student.uef.fi
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17042] Fix missing properties in Swagger definition for Hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53982|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 54025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54025=edit
Bug 17042: Fix missing column in hold.json

Swagger definition for hold was missing a property.

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17042] Fix missing properties in Swagger definition for Hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17042

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17041] Fix missing properties in Swagger definition for Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17041] Fix missing properties in Swagger definition for Patron

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17041

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53981|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 54024
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54024=edit
Bug 17041: Fix missing properties in patron.json

Swagger definition for patron was missing two properties.

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date with database

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #53980|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 54022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54022=edit
Bug 17032: Make sure Swagger object definition is up-to-date with Koha-object

If a definition in api/v1/definitions/*.json has a corresponding Koha-object by
filename, compare properties of the definition and columns of the Koha-object
and ensure that all columns are defined inside properties of the definition.

To test:
1. Run t/db_dependent/api/v1/swagger/definitions.t
2. See that all of the tests pass. (If not, file a bug report to fix missing
   properties in the Swagger definition.)
3. Remove a property from api/v1/swagger/definitions/patron.json
4. Repeat step 1
5. See that test fails and lets you know that the property you just removed
   is missing from the definition.

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date with database

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

--- Comment #8 from Jonathan Druart  
---
Created attachment 54023
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54023=edit
Bug 17032: Remove warning "keys on reference is experimental"

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17032] REST API tests: Make sure Swagger object definition is up-to-date with database

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17032

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16830] koha-indexer still uses the deprecated -x option switch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16830

--- Comment #9 from Tomás Cohen Arazi  ---
(In reply to Frédéric Demians from comment #8)
> Does it apply to 16.05 branch?

Yes, as long as bug 16506 has been pushed already.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10848] Allow configuration of mandatory/ required fields on the suggestion form in OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10848

--- Comment #37 from Jacek Ablewicz  ---
In this revised version I dropped the old form validation handler entirely, in
favour of the "required" attributes as a sole method of enforcement. Not sure
if the special treatment for old / legacy / non-compliant browsers is still
needed? 

If deemed necessary, I may try to re-add such an event handler which will be
more on par with the current coding guidelines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/