[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #22 from Katrin Fischer--- Removing the ; would be an incomplete fix, but much easier to do as a workaround solution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #21 from Katrin Fischer--- I am not against url-encoding, but we need to find a way to do this with xslt or outside the xslt that works better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17080] Koha::Object-> new should handle default values for NOT NULL columns
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17080 Srdjan Jankovicchanged: What|Removed |Added CC||srd...@catalyst.net.nz --- Comment #6 from Srdjan Jankovic --- I believe this needs rebasing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Nightly Build Botchanged: What|Removed |Added Attachment #54316|0 |1 is obsolete|| --- Comment #3 from Nightly Build Bot --- Created attachment 54322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54322=edit Bug 17108 - Automatic debian/control updates (oldstable) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103 Indranil Das Guptachanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17103] Google API Loader jsapi called over http
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17103 --- Comment #1 from Indranil Das Gupta--- Created attachment 54321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54321=edit Bug 17103 - Google API Loader jsapi called over http This patch removes the hardcoded protocol ("http") from the URI, leaving the browser to negotiate the correct http/https context. Prevents MIXED CONTENT failure, allowing GoogleIndicTransliteration to function correctly when used in SSLized OPACs. Test plan - 1/ Make sure your OPAC is being served both over HTTP and HTTPS 2/ Set GoogleIndicTransliteration syspref to "Show" 3/ Access the OPAC over http, Google transliteration element will show up in masthead searchbox. 4/ Access the OPAC over https. The element will not show. Console will show MIXED CONTENT error and failure of google loader. 5/ Apply patch. Repeat steps #3 and #4 again. Now in both cases GoogleIndicTransliteration will work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3534] Patron quick add form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 Indranil Das Guptachanged: What|Removed |Added CC||indr...@l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16554] Web installer fails to load i18n sample data on MySQL 5.6+
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16554 --- Comment #30 from M. Tompsett--- (In reply to M. Tompsett from comment #29) > vi installer/.../subscription_numberpatterns.sql > -- notice the [converted] > :set fileencoding=utf-8 > :wq > > I believe that is all that is needed to fix it. While that fixes some, still issues with: installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/autorites_norme_unimarc.sql -- something about 'CO' duplicate primary key. installer/data/mysql/fr-FR/marcflavour/unimarc_lecture_pub/Obligatoire/framework_DEFAULT.sql -- something about '000' duplicate primary key. Also, ru-RU and uk-UA also seem to trigger on mandatory and repeatable fields now. They are rather floody. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgenchanged: What|Removed |Added Summary|Nightly build bot bug |Automatic debian/control ||updates (master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 rkui...@roundrocktexas.gov changed: What|Removed |Added CC||rkui...@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12342] Patron registration datepicker dropdown shows only 10 years
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12342 rkui...@roundrocktexas.gov changed: What|Removed |Added CC||rkui...@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15388] Show Syndetics covers by UPC in search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15388 rkui...@roundrocktexas.gov changed: What|Removed |Added CC||rkui...@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9557] Koha does not include EANs from MARC records in Syndetics links on OPAC pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9557 rkui...@roundrocktexas.gov changed: What|Removed |Added CC||rkui...@roundrocktexas.gov --- Comment #1 from rkui...@roundrocktexas.gov --- We are also experiencing this problem. The cover images are showing up on the details page but not the search results page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgenchanged: What|Removed |Added Attachment #54320|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgenchanged: What|Removed |Added Attachment #54293|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Nightly Build Botchanged: What|Removed |Added Attachment #54293|0 |1 is obsolete|| --- Comment #5 from Nightly Build Bot --- Created attachment 54320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54320=edit Bug 17084 - Automatic debian/control updates (master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 --- Comment #20 from Eric Phetteplace--- If anyone else runs into this, I'm using a small bit of OPAC JavaScript as a work-around since many of records are affected: // fix 830$a series links ending in semicolons, see bug #14716 $('.results_summary.series a').each(function(){ // URI-encoded semicolon var href = $(this).attr('href').replace(/;/g, '%3B') $(this).attr('href', href) }) Stuffing unencoded text inside URLs seems like a bad idea. If Japanese characters aren't working, maybe that's an issue with the url-encode function itself but not the approach taken to resolve this bug? I would think that almost anything being put in an href attribute would need to go through url-encode. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716 Eric Phetteplacechanged: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107 Christophe Brocquetchanged: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Christophe Brocquet --- It works as described -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16246] Return all reserves columns in ILS-DI GetRecords response
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16246 Andreas Hedström Macechanged: What|Removed |Added CC||andreas.hedstrom.mace@sub.s ||u.se --- Comment #4 from Andreas Hedström Mace --- Patch did not apply for me. Needs a rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17113] New: Unable to search multi-domain Active Directory forest due LDAP required base
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17113 Bug ID: 17113 Summary: Unable to search multi-domain Active Directory forest due LDAP required base Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcha...@gmail.com Reporter: helpd...@neci.edu QA Contact: testo...@bugs.koha-community.org CC: dpav...@rot13.org Auth_with_ldap currently prevents the use of an empty base due to the presence of my $base = $ldap->{base} or die ldapserver_error('base'); An AD Global Catalog search will automatically query all domains in a forest if a blank base is specified, but otherwise limits the search to the domain matching the base. Not being able to specify an empty base makes things difficult if the forest contains disjoint domains that cannot be combined into a single search base. (Uncertain how this interacts with the work on bug 8993, but being able to use the forest wide Global Catalog searches removes a lot of the contortions needed to direct requests to the correct host responsible for a domain.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17107] Add ident and Identifier-standard to known indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17107 Christophe Brocquetchanged: What|Removed |Added CC||christophe.brocquet@obspm.f ||r -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974 Mirko Tietgenchanged: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #3 from Mirko Tietgen --- It did not work from within koha-shell. Since I don't think it would be called from within koha-shell, I assume it is supposed to be like that. Just wanted to leave a note in case it isn't. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16974] koha-plack should check and fix log files permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16974 Mirko Tietgenchanged: What|Removed |Added Attachment #53714|0 |1 is obsolete|| --- Comment #2 from Mirko Tietgen --- Created attachment 54319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54319=edit Bug 16974: Make koha-plack should check and fix log files permissions This patch adds a function to the koha-plack script so it checks for log file existence and its permissions. This function is called from the start_plack function. If some of this conditions are not fulfilled, it solves the situation by either touching and/or changing the permissions accordingly for the instances' plack log files. To test: - Run (on kohadevbox): $ cd kohaclone $ debian/scripts/koha-plack --start kohadev $ debian/scripts/koha-plack --stop kohadev $ ls /var/log/koha/kohadev/plack* - Verify ownership of the created files (they might belong to the root user) - Apply the patch - Run: $ chown root:root /var/log/koha/kohadev/plack* $ debian/scripts/koha-plack --start kohadev $ ls /var/log/koha/kohadev/plack* => SUCCESS: Files belong to kohadev-koha:kohadev-koha - Run: $ debian/scripts/koha-plack --stop kohadev $ rm /var/log/koha/kohadev/plack* $ debian/scripts/koha-plack --start kohadev $ ls /var/log/koha/kohadev/plack* => SUCCESS: Files are created and belong to kohadev-koha:kohadev-koha - Sign off :-D Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17015] New Koha Calendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Mehdi Hamidichanged: What|Removed |Added Attachment #53859|0 |1 is obsolete|| --- Comment #4 from Mehdi Hamidi --- Created attachment 54318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54318=edit Bug 17015 - New koha calendar The new calendar has it's own UI now. Added some new features to the calendar: - Copying calendar from branch to branch - Copy holidays from date to date or from range to range - Added a column into discrete_calendar holidaytype. - Adding new days in futureChecks type of holiday: - If the date from a year ago was exeption ('E'), the new day won't be a holiday. - If the date from a year ago was fixed ('R') repeatable, the new day will be a holiday. - If the date from a year ago was float ('F') a holiday that's not fixed, the new day will on need validation. - If the date from a year ago was need validation ('N'), the new day will still be on need validation. - You can change the opening and closing hours from the calendar UI directly. - The discrete_calendar uses sql queries for now, the next patch will be to change that that it uses schema. - CSS and some client side calculation might be changed. - Please let us know what you think and if we should add/modify some features. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17112] Action buttons for course reserves detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17112 --- Comment #1 from Owen Leonard--- Created attachment 54317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54317=edit Bug 17112 - Action buttons for course reserves detail page This patch revises the edit and delete buttons on the course reserves detail page so that they are styled as Bootstrap buttons with Font Awesome icons. To test, apply the patch and choose or create a course reserve which has in it at least one lost item and at least one item which is checked out. - In the list of items on the course reserve detail page, confirm that the 'Edit' and 'Delete' buttons are correctly styled. - Confirm that for the checked out item the delete button is disabled. Hovering over the button should trigger a tooltip. Clicking the button should trigger an alert. - Confirm that for the lost item the same is true. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17112] Action buttons for course reserves detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17112 Owen Leonardchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17112] New: Action buttons for course reserves detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17112 Bug ID: 17112 Summary: Action buttons for course reserves detail page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The edit and delete links for titles on a course reserve should be styled according to new interface guidelines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 --- Comment #22 from M. Tompsett--- (In reply to M. Tompsett from comment #21) > (In reply to Kyle M Hall from comment #19) > > Pushed to master for Koha 16.11, thanks Bernardo! > > Are you sure you pushed all the patches? I just did a git bz apply, and it > only said the first one was already applied. > > I was trying to test bug 16554 (I think). Nevermind, I failed to git pull. Sorry. :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573 --- Comment #21 from M. Tompsett--- (In reply to Kyle M Hall from comment #19) > Pushed to master for Koha 16.11, thanks Bernardo! Are you sure you pushed all the patches? I just did a git bz apply, and it only said the first one was already applied. I was trying to test bug 16554 (I think). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #2 from Mirko Tietgen--- This is the result of debian/update-control on 3.22.x and should go in 3.22.10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgenchanged: What|Removed |Added CC||julian.maur...@biblibre.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 --- Comment #1 from Nightly Build Bot--- Created attachment 54316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54316=edit Bug 17108 - Automatic debian/control updates (oldstable) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgenchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17108 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgenchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17111 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] Automatic debian/control updates (oldstable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Mirko Tietgenchanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mi...@abunchofthings.net |ity.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17111] New: Automatic debian/control updates (oldstable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17111 Bug ID: 17111 Summary: Automatic debian/control updates (oldstable) Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mi...@abunchofthings.net QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn' t work with MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 Andreas Hedström Macechanged: What|Removed |Added CC||andreas.hedstrom.mace@sub.s ||u.se --- Comment #12 from Andreas Hedström Mace --- I added a sign-off since the patch works as intended. I'm unsure why it didn't already have this status since it appears that it has previously been signed-off by David Cook (see comment #6)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 --- Comment #17 from Nick Clemens--- (In reply to Jonathan Druart from comment #16) > (In reply to Nicole C. Engard from comment #11) > > Created attachment 51029 [details] [review] [review] > > Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN > > Should not we do that for GetVariationsOfISBN as well? If we do think this is the right way to go I will file a new bug for ISBN, I just wanted to see if there was any opposing opinion here before doing that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16991] Add subtitle to holds to pull report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Attachment #54215|0 |1 is obsolete|| --- Comment #2 from Héctor Eduardo Castro Avalos --- Created attachment 54315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54315=edit [SIGNED-OFF]Bug 16991: Add subtitle to holds to pull report This patch adds output of subtitle to the holds to pull report using keyword to MARC mapping information. To test, apply the patch and go to Circulation -> Holds to pull. The list of holds to pull should display subtitles. Signed-off-by: Hector Castro Subtitle added using keyword to MARC mapping with default framework. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16991] Add subtitle to holds to pull report
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16991 Héctor Eduardo Castro Avaloschanged: What|Removed |Added Status|Needs Signoff |Signed Off CC||hector.hecax...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885 Tomás Cohen Arazichanged: What|Removed |Added Attachment #53958|0 |1 is obsolete|| --- Comment #10 from Tomás Cohen Arazi --- Created attachment 54314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54314=edit Bug 16885: koha-stop-zebra should be more sure of stopping zebrasrv This patch follows Galen's suggestion in comment #7. TEST PLAN - 1) Back up your koha logs as desired. 2) add something to /var/log/koha/{instance name}/intranet-error.log 3) ps aux | grep zebra 4) logrotate -f /etc/logrotate.d/koha-common 5) ps aux | grep zebra -- the zebrasrv and daemon process for zebra indexing didn't restart. 6) apply this patch against /usr/sbin/koha-stop-zebra 7) sudo koha-start-zebra {instance name} 8) ps aux | grep zebra -- the processes should have started up again. 9) add different junk to /var/log/koha/{instance name}/intranet-error.log 10) ps aux | grep zebra 11) logrotate -f /etc/logrotate.d/koha-common 12) ps aux | grep zebra -- the process ids for the zebrasrv and daemon processes should be different, but the number of processes is the same as before. 13) sign off, because its less ugly than comment #3 Sponsored-by: Tulong Aklatan Signed-off-by: Tomas Cohen Arazi Works as expected, no regressions found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885 Tomás Cohen Arazichanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17001] filtering overdue report by due date can fail if TimeFormat is 12hr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17001 Galen Charltonchanged: What|Removed |Added Status|Failed QA |Passed QA --- Comment #7 from Galen Charlton --- (In reply to Kyle M Hall from comment #6) > Would it not be simpler to pass the parameter timeformat => '24hr' to > output_pref instead of using an external lib? I note that output_pref(), if we were to take its name literally, is for formatting date and time *output*. DateTime::Format::MySQL is already used in other places and its name makes it clear that a DateTime passed through is meant to be fed to an SQL query. I think it better that we keep the concerns of formatting timestamps for human display separate from formatting them for computer consumption. I am reseting the status of this bug back to "Passed QA". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 Marcel de Rooychanged: What|Removed |Added Blocks||17096 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooychanged: What|Removed |Added Blocks||17110 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 [Bug 17110] Lower CSRF expiry in Koha::Token -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 Marcel de Rooychanged: What|Removed |Added Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- Example patch and adjusted test still coming.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 Marcel de Rooychanged: What|Removed |Added Depends on||17109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 [Bug 17109] sendbasket: Remove second authentication, add CSRF token -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17110] Lower CSRF expiry in Koha::Token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 --- Comment #1 from Marcel de Rooy--- Created attachment 54313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54313=edit Bug 17110: Lower CSRF expiry in Koha::Token Default expiry in WWW:CSRF is one week. This patch sets it to 8 hours by default in Koha, and allows to change the expiry period individually by passing MaxAge. Test plan: [1] Put items in your cart. [2] Apply the example patch too. [3] Send the cart from opac within the allotted 10 seconds. [4] Send again, but wait some 10 seconds before submitting. Too late! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17110] New: Lower CSRF expiry in Koha::Token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17110 Bug ID: 17110 Summary: Lower CSRF expiry in Koha::Token Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #41 from Lari Taskula--- (In reply to Benjamin Rokseth from comment #39) > Rebased against 16271 which is now in master. > > Removed patched t/api/v1/minifier.t which should be moved to bug #17102 > > Please test and get this moved further, as it is a pain to rebase swagger > definitions as is today ... Thanks Benjamin! And I agree, it can be surprisingly time consuming! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17100] On summary print, "Account fines and payments" is displayed even if there is nothing to pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100 Owen Leonardchanged: What|Removed |Added Attachment #54270|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 54312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54312=edit [SIGNED-OFF] Bug 17100: [Alternative patch] Fix issues for on summary print This alternative patch moves logic and formatting to the template file. To test: - Follow test plan in comment #2 - Additionally, verify that formatting follows syspref 'CurrencyFormat' - Verify that amount column is right-aligned Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17100] On summary print, "Account fines and payments" is displayed even if there is nothing to pay
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17100 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328 --- Comment #3 from Marcel de Rooy--- I still hope to get some more light on this with bug 17109 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Lari Taskulachanged: What|Removed |Added Depends on||16212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 [Bug 16212] Swagger specification separation and minification -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Lari Taskulachanged: What|Removed |Added Blocks||16699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooychanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=14328 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #40 from Lari Taskula--- Created attachment 54311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54311=edit Bug 16699: Remove requirement from borrowernumberQueryParam borrowernumberQueryParam shouldn't be required as also changed in Bug 16271. To test: 1. Don't apply the patch yet, but first minify Swagger and run t/db_dependent/api/v1/holds.t 2. Observe that some tests fail with response code 400 when expecting 200. 3. Apply patch and minify Swagger 4. Run t/db_dependent/api/v1/holds.t 5. Observe that tests pass. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328 Marcel de Rooychanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17109 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16212] Swagger specification separation and minification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 Lari Taskulachanged: What|Removed |Added Blocks|16699 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15126] REST API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 Lari Taskulachanged: What|Removed |Added Blocks|16699 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Lari Taskulachanged: What|Removed |Added Status|Signed Off |Needs Signoff Depends on|15126, 16212|16271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126 [Bug 15126] REST API: Use newer version of Swagger2 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16212 [Bug 16212] Swagger specification separation and minification https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 [Bug 16271] Allow more filters on /api/v1/holds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16271] Allow more filters on /api/v1/holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16271 Lari Taskulachanged: What|Removed |Added Blocks||16699 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16929] Prevent opac-memberentry waiting for random chars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 Marcel de Rooychanged: What|Removed |Added Blocks||17109 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 [Bug 17109] sendbasket: Remove second authentication, add CSRF token -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooychanged: What|Removed |Added Depends on||16929 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16929 [Bug 16929] Prevent opac-memberentry waiting for random chars -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4030] Patron attribute types cannot be made mandatory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4030 Janet McGowanchanged: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 --- Comment #2 from Marcel de Rooy--- Created attachment 54310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54310=edit Bug 17109: Add CSRF token to [opac-]sendbasket If you have no (valid) token, you will not be able to send the message. Test plan: [1] Verify if you can still send the cart from opac and intranet. [2] While still being logged in, try to send the cart from opac by using the following URL: /cgi-bin/koha/opac-sendbasket.pl?email_add=y...@somedomain.com=csrf_test_list=doesnotmatter_token=justsomeguess12345 This should now result in a csrf error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 --- Comment #1 from Marcel de Rooy--- Created attachment 54309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54309=edit Bug 17109: Remove second authentication from (opac-)sendbasket Patch deals with opac and intranet variant. If we authenticated the first time, it is not necessary to do it a second time rightaway. Replaces a call to get_template_and_user (including checkauth) by gettemplate. Also removes duplicate use C4::Biblio statements. Test plan: [1] Put a few books in the cart. [2] Send the cart from OPAC. [3] Send the cart from intranet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooychanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket: Remove second authentication, add CSRF token
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooychanged: What|Removed |Added Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl Patch complexity|--- |Small patch Summary|sendbasket (working title) |sendbasket: Remove second ||authentication, add CSRF ||token -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328 Owen Leonardchanged: What|Removed |Added Version|3.14|3.22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17106] DataTables patron search defaulting to 'starts_with' - doc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17106] DataTables patron search defaulting to 'starts_with' - doc
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17106 Owen Leonardchanged: What|Removed |Added Attachment #54285|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 54308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54308=edit [SIGNED-OFF] Bug 17106 - DataTables patron search defaulting to 'starts_with' - doc Bug 15930 modified default value for DataTables patron search. The doc text should also be modified : "Can be 'contain' or 'start_with' (default value). Used for the searchmember parameter." Test plan : - install Koha with patch - look at man page man/man3/C4::Utils::DataTables::Members.3pm Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Owen Leonardchanged: What|Removed |Added Attachment #32642|0 |1 is obsolete|| --- Comment #8 from Owen Leonard --- Created attachment 54306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54306=edit [SIGNED-OFF] Bug 13134 - Add patron category to returns confirmation dialogs Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. This patch adds the patron category to the hold and transfer popups to the patron information already displayed. The li tags that contain the patron category have the class "patron-category" to allow this data to be easily hidden. Test Plan: 1) Apply this patch 2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Owen Leonardchanged: What|Removed |Added Attachment #54282|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 54307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54307=edit [SIGNED-OFF] Bug 13134: Fix template file to make category appear This is a followup to rescue the bug. To test: Follow test plan from comment #1 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] sendbasket (working title)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Marcel de Rooychanged: What|Removed |Added Blocks||17096 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 --- Comment #4 from Jonathan Druart--- We have already started to move the authorised values related code to the Koha namespace, but some are still missing. To continue and move C4::Koha::*AuthorisedValues* subroutines to Koha::AuthorisedValues, we will need to join on marc_subfield_structure(.authorised_value which is actually an authorised value category). To do so we need to define a relationship (fk) between the two tables. But we have "special AV" like Asort1 (and friends) , LOST, DAMAGED, etc.) Which could not be in the authorised_values table [yet]. And 3 other "special special AV) like itemtypes, branches and cn_source. Others (undetermined so far) are linked to a marc_subfield_structure from installer/**/marcflavour/**/*framework*.sql, like STACK. My idea would be to move all the AV categories to a new table authorised_value_categories. It will contain only 1 column category_name refered by 1. authorised_values.category, 2. additional_fields.authorised_value_category (others authorised_value field should be renamed like that when they refer AV categories) and 3. iitems_search_fields.authorised_value_category. And, maybe later, auth_subfield_structure, auth_tag_structure, borrower_attribute_types, marc_tag_structure (some are varchar(10) et 20 when they should be 32!) We could imagine more attributes to this table, but don't ask me to add a authorised_value_categories.id as pk please :) We will have to use temporary tables to deal with the DB constraints, to add more fun. Finally the .sql will have to be updated to reflect these changes. I have just started but before to enter in this tunnel I'd like to know if there are a couple of volunteers to test? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Marc Véronchanged: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Mirko Tietgenchanged: What|Removed |Added Attachment #54305|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17109] New: sendbasket (working title)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17109 Bug ID: 17109 Summary: sendbasket (working title) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17084] Nightly build bot bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #4 from Nightly Build Bot--- Created attachment 54305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54305=edit Bug 17108 - Automatic debian/control updates (stable) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17108] Automatic debian/control updates (stable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Mirko Tietgenchanged: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |mi...@abunchofthings.net |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17108] New: Automatic debian/control updates (stable)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17108 Bug ID: 17108 Summary: Automatic debian/control updates (stable) Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: mi...@abunchofthings.net QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 --- Comment #39 from Benjamin Rokseth--- Rebased against 16271 which is now in master. Removed patched t/api/v1/minifier.t which should be moved to bug #17102 Please test and get this moved further, as it is a pain to rebase swagger definitions as is today ... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Benjamin Roksethchanged: What|Removed |Added Attachment #52991|0 |1 is obsolete|| --- Comment #38 from Benjamin Rokseth --- Created attachment 54304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54304=edit [SIGNED-OFF] Bug 16699: Move Swagger-related files to api/v1/swagger This patch separates Swagger-specifications and the minifySwagger.pl from other api-files by moving specifications & minifier into api/v1/swagger. Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 We participated in the development of the Mojolicious::Plugin::Swagger and know it well. We have made an extension to the plugin to provide full CORS support and have been building all our in-house features on the new REST API. Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Benjamin Roksethchanged: What|Removed |Added Attachment #52989|0 |1 is obsolete|| --- Comment #36 from Benjamin Rokseth --- Created attachment 54302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54302=edit [SIGNED-OFF] Bug 16699: Support multiple types in primitive definitions Currently it is not possible to define multiple types for primitive definitions in /definitions/*. If you try to use the following "firstname": { "type": ["string", "null"], "description": "patron's first name" } in definitions.json, online.swagger.io validator will not validate it: {"messages":["attribute definitions.firstname.type is not of type `string`"]} One way to get around this issue is to extend definitions with custom "x-primitives" object, where we will define all reusable primitive definitions. To test: 1. Add the "firstname" example above to definitions.json 2. Run minifySwagger.pl 3. Validate your specification 4. Observe that error with description mentioned above is given 5. Apply patch 6. Repeat step 2 and 3 7. Observe that validation passes Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 We participated in the development of the Mojolicious::Plugin::Swagger and know it well. We have made an extension to the plugin to provide full CORS support and have been building all our in-house features on the new REST API. Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Benjamin Roksethchanged: What|Removed |Added Attachment #52990|0 |1 is obsolete|| --- Comment #37 from Benjamin Rokseth --- Created attachment 54303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54303=edit [SIGNED-OFF] Bug 16699: Reference new x-primitives in currently defined objects Since we have defined some basic x-primitives in x-primitives.json, we can now start to reuse them in our currently defined objects. To test: 1. Apply patch 2. Run minifySwagger.pl 3. Validate your Swagger specifications 4. Observe that validation passes Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 We participated in the development of the Mojolicious::Plugin::Swagger and know it well. We have made an extension to the plugin to provide full CORS support and have been building all our in-house features on the new REST API. Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Benjamin Roksethchanged: What|Removed |Added Attachment #52988|0 |1 is obsolete|| --- Comment #35 from Benjamin Rokseth --- Created attachment 54301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54301=edit [SIGNED-OFF] Bug 16699: Fix mixed-up indentation from 2-4 spaces to 2 spaces These definitions had indentation of 4 spaces, while rest of the specification uses 2 spaces. This patch simply maintains the consistency in indentations and provides no other modifications to code. Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 We participated in the development of the Mojolicious::Plugin::Swagger and know it well. We have made an extension to the plugin to provide full CORS support and have been building all our in-house features on the new REST API. Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Benjamin Roksethchanged: What|Removed |Added Attachment #52987|0 |1 is obsolete|| --- Comment #34 from Benjamin Rokseth --- Created attachment 54300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54300=edit [SIGNED-OFF] Bug 16699: Add borrowernumberQueryParam for reusability The borrowernumber as a query parameter should be defined in parameters.json in order to allow its reusability. To test: 1. Apply patch 2. Run minifySwagger.pl 3. Validate swagger.min.json in online.swagger.io/validator/debug?url=url_to+ _your_swagger_min_json or your local swagger-api/validator-badge validator 4. Observe that validation passes Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 We participated in the development of the Mojolicious::Plugin::Swagger and know it well. We have made an extension to the plugin to provide full CORS support and have been building all our in-house features on the new REST API. Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16699] Swagger: Split parameters and paths, and specify required permissions for resource
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16699 Benjamin Roksethchanged: What|Removed |Added Attachment #52986|0 |1 is obsolete|| --- Comment #33 from Benjamin Rokseth --- Created attachment 54299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54299=edit [SIGNED-OFF] Bug 16699: Split parameters and paths in Swagger Parameters and paths should be split in our Swagger specification, because otherwise swagger.json would become messy with all the paths and their further specification in the same file. Also parameters should be split for the same reason. Instead of using index.json for definitions, parameters and paths, we define new files "definitions.json", "parameters.json" and "paths.json" in order to simplify the references. If we kept using index.json and try to reference "/definitions/error.json" from "/paths/holds.json", reference would be "../definitions/index.json#/error" instead of now simplified version, "../definitions.json#/error". Here is the proposed structure: . ├── swagger.json ├── definitions.json ├── paths.json ├── parameters.json ├── definitions │ └── error.json │ └── patron.json ├── parameters │ └── patron.json ├── paths │ └── patrons.json ├── minifySwagger.pl └── swagger.min.js The swagger.json paths, definitions and parameters will look as follows: ... "paths": { "$ref": "paths.json" }, "definitions": { "$ref": "definitions.json" }, "parameters": { "$ref": "parameters.json" } ... A problem with splitting specification into multiple files directly from swagger.json (e.g. "paths": { "$ref": "paths.json" }) is that it is not following the Swagger specification and an error will be thrown by the Swagger-UI default validator (online.swagger.io/validator). To overcome this problem, we use the minifySwagger.pl script from Buug 16212. This allows the developers to work with the structure introduced in this patch thus allowing developers to split the specification nicely, and still have a valid Swagger specification in the minified swagger.min.json. To test: -2: Apply the minifier-patch in Buug 16212. -1: Make sure you can validate your specification with Swagger2 validator at online.swagger.io/validator/debug?url=url_to_swaggerjson, or install it locally from https://github.com/swagger-api/validator-badge. 1. Don't apply this patch yet, but first validate swagger.json with swagger.io-validator (or your local version, if you installed it) 2. Observe that validation errors are given 3. Run minifySwagger.pl 4. Validate swagger.min.json with the validator you used in step 1 5. Observe that validation passes and we overcame the invalid specification problem in swagger.min.json 6. Apply this patch 7. Run minifySwagger.pl 8. Repeat step 4 9. Observe that validation passes with new structure 10. Run REST tests at t/db_dependents/api/v1 (11. Study the new structure of our Swagger specifications :)) Signed-off-by: Olli-Antti Kivilahti My name is Olli-Antti Kivilahti and I approve this commit. We have been using the Swagger2.0-driven REST API on Mojolicious for 1 year now in production and I am certain we have a pretty good idea on how to work with the limitations of Swagger2.0 We participated in the development of the Mojolicious::Plugin::Swagger and know it well. We have made an extension to the plugin to provide full CORS support and have been building all our in-house features on the new REST API. Signed-off-by: Johanna Raisa My name is Johanna Räisä and I approve this commit. We have been using Swagger2.0-driven REST API in production successfully. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14328] sendbasket: Sent cart does not contain a name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14328 --- Comment #2 from Marcel de Rooy--- (In reply to Owen Leonard from comment #1) > I can't reproduce this problem in master. Can this report be closed? Not yet. I will still follow this under 3.22. It is quite hard to reproduce if you completely do not understand how it is possible at all.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druartchanged: What|Removed |Added Attachment #53202|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 54297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54297=edit Bug 16829: DBIx update Sponsored-by: NEKLS Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druartchanged: What|Removed |Added Attachment #53203|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart --- Created attachment 54298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54298=edit Bug 16829: Unit tests for logaction's 'interface parameter' This patch introduces tests for the new 'interface' parameter for the C4::Log::logaction and C4::Log::GetLogs functions. In logaction, it falls back to C4::Context->interface if ommited. To test: - Run $ prove t/db_dependent/Log.t => SUCCESS: Tests pass - Sign off Sponsored-by: NEKLS Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druartchanged: What|Removed |Added Attachment #53201|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 54296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54296=edit Bug 16829: Add 'interface' to the log viewer This patch introduces the 'interface' filter to the log viewer. To test: - Apply the patch - Open the log viewer => SUCCESS: As default, 'All' interfaces are chosen. OPAC, Intranet and SIP are presented - Do a lot of log searches, verify that the interface column shows what is expected. => SUCCESS: The chosen 'interfaces' are kept when rendering results. Sponsored-by: NEKLS Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druartchanged: What|Removed |Added Attachment #53200|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 54295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54295=edit Bug 16829: make logaction and GetLogs aware of the interface column This patch changes the logaction API so it accepts a new 'interface' param. Current code calling logaction is not changed, and this parameter can be ommited in most contexts, and it will correctly fall-back to C4::Context->interface. Unit tests are provided on a different patch. GetLogs gets patched as well, so it can be required to filter by 'interface' param. Sponsored-by: NEKLS Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16829] action_logs should have an 'interface' column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16829 Jonathan Druartchanged: What|Removed |Added Attachment #53199|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 54294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54294=edit Bug 16829: Add 'interface' column to action_logs This patch introduces a new column for the action_logs table. It is called 'interface' and it is intended to store the interface in which the action was performed. Sponsored-by: NEKLS Signed-off-by: Nicole C Engard Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 --- Comment #16 from Jonathan Druart--- (In reply to Nicole C. Engard from comment #11) > Created attachment 51029 [details] [review] > Bug 14629 - [QA Followup] Pass invalid ISSN through GetVariationsOfISSN Should not we do that for GetVariationsOfISBN as well? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14629] Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14629 Jonathan Druartchanged: What|Removed |Added Keywords|nowheezy| --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #14) > libbusiness-issn-perl is only packaged for jessie, adding keyword nowheezy. Forget that, it is also packaged for wheezy. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/