date:20160905

[Koha-bugs] [Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248

Claire Gravely  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com

--- Comment #3 from Claire Gravely  ---
could not apply bug 17216 (depends on)
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Claire Gravely  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com

--- Comment #38 from Claire Gravely  ---
could not apply patch to test bug 17248. 

CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

--- Comment #6 from Chris Cormack  ---
Awesome, thank you Mirko

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

--- Comment #5 from Mirko Tietgen  ---
I have attached newer versions of the ES dependencies that I plan to submit to
Debian.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

--- Comment #4 from Mirko Tietgen  ---
Created attachment 55206
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55206=edit
libcatmandu-store-elasticsearch-perl_0.0501-1_all.deb

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

--- Comment #3 from Mirko Tietgen  ---
Created attachment 55205
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55205=edit
libsearch-elasticsearch-perl_2.03-1_all.deb

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

--- Comment #2 from Chris Cormack  ---
That's what we will find out. I suspect so. But apparently 2.4 is more backward
compatible than earlier 2.x versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #1 from Mirko Tietgen  ---
It will also need newer Catmandu than 0.9x I guess?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17226] Improve AUTOLOAD of Koha::Object

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55038|0   |1
is obsolete||

--- Comment #4 from Claire Gravely  ---
Created attachment 55204
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55204=edit
Bug 17226: Make Koha::Object->get_column available

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17226] Improve AUTOLOAD of Koha::Object

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55037|0   |1
is obsolete||

--- Comment #3 from Claire Gravely  ---
Created attachment 55203
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55203=edit
Bug 17226: Improve Koha::Object's AUTOLOAD method

Following the path of bug 17091, Koha::Object needs to AUTOLOAD the
methods provided by DBIX::Class.
We already use in_storage, id and is_changed, but others are coming!

Test plan:
  prove t/db_dependent/Koha/Object.t
should return green

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17226] Improve AUTOLOAD of Koha::Object

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17226

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16708] ElasticSearch - Fix authority reindexing

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16708

Chris Cormack  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Stable|RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] Upgrade Elastic Search code to work with version 2.4+

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

Chris Cormack  changed:

   What|Removed |Added

 Depends on||12478


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
[Bug 12478] Elasticsearch support for Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17255] New: Upgrade Elastic Search code to work with version 2.4+

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255

Bug ID: 17255
   Summary: Upgrade Elastic Search code to work with version 2.4+
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: ch...@bigballofwax.co.nz
QA Contact: testo...@bugs.koha-community.org

Before building more things on Elastic (I have 3 things ready to go) We need to
upgrade to work with the latest stable (2.4)

This will involve getting a 2.4 cluster running, pointing Koha at it, and
fixing any errors that occur.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Chris Cormack  changed:

   What|Removed |Added

 Blocks||17255


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17255
[Bug 17255] Upgrade Elastic Search code to work with version 2.4+
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
(In reply to Aliki Pavlidou from comment #2)

Hi Aliki


I will answer your question


> - Regarding creating a new numbering pattern, I was trying to create one
> yearly subscription that has 11 issues per year. Do you have any idea how
> could I set this pattern? For example 2015 was the 18th year of this journal
> publication, and July and August was merged into one issue.
> 

Name: 11 volums per year
Description: 11 volums per year

X   Y
Label   YearNo
Add  1  1
Every11 1
Setback 1   1
When..  11

Test prediction pattern
Frequency: 1/month
First issue publication date: 01/01/2015
Subscription length: issues 11


Beggins 20151
with
Inner
couter  1   1

You will get:
Number  Publication date
Year 2015, No. 101/01/2015
Year 2015, No. 201/02/2015
Year 2015, No. 301/03/2015
Year 2015, No. 401/04/2015
Year 2015, No. 501/05/2015
Year 2015, No. 601/06/2015
Year 2015, No. 701/07/2015
Year 2015, No. 801/08/2015
Year 2015, No. 901/09/2015
Year 2015, No. 10   01/10/2015
Year 2016, No. 11   01/11/2015

If this does not always happen, i.e., just one year and the another year came
with 12 issues
You just delete the number not published when you add a new subscription in the
"Prediction pattern"
learn more about this here:


Maybe this isn't the best place to ask, please use the mailing list at
 or the IRC


I hope this helps

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #53508|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #54659|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #54712|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #24 from Katrin Fischer  ---
Created attachment 55201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55201=edit
[PASSED QA] Bug 8030 (QA Followup) - Use REST api and provide feedback

Use REST API
If cancelled return to previous selection
If fail return to previous selection
Use fa spinning icon while waiting
Disable select while waiting

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #25 from Katrin Fischer  ---
Created attachment 55202
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55202=edit
[PASSED QA] Bug 8030 - (QA followup) Remove svc file no longer user Use
animated gif for waiting as elsewhere Remove confirmation

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8030] Change pickup location of a hold from patron record

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8030

--- Comment #23 from Katrin Fischer  ---
Created attachment 55200
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55200=edit
[PASSED QA] Bug 8030 - Change pickup location of a hold from patron record

To test:
1 - Place some holds for a patron
2 - Load the patron into checkout module
3 - View thier holds tab, should have a dropdwon for location
4 - Alter the location
5 - You should recieve a confirmation box
6 - Confirm that pressing cancel does not update holds
7 - Confirm that pressing Yes does update the hold
8 - Confirm that waiting holds are not updateable

Signed-off-by: Jason M. Burds 

Signed-off-by: Katrin Fischer  

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16967] Remove the use of "onclick" from serial frequency and numbering management

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16967

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #53663|0   |1
is obsolete||

--- Comment #3 from Héctor Eduardo Castro Avalos  ---
Created attachment 55199
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55199=edit
[SIGNED-OFF]Bug 16967: Remove the use of "onclick" from serial frequency and
numbering management

This patch removes instance of "onclick" from the templates for serial
frequency and numbering management. Events are now defined in the
JavaScript.

To test, apply the patch and go to Serials -> Manage frequencies.

 - In the list of frequencies, click the "Delete" button for a frequency
   which is in use by at least one subscription. In the confirmation
   dialog, clicking the "Show subscriptions" link should display a list
   of titles.
 - Edit or create a frequency.
 - To test that the form submission validation is still working
   correctly, enter non-numeric data in the "issues per unit" field and
   submit the form. This should trigger an error.

In Serials -> Manage numbering patterns:

 - In the list of numbering patterns, click the "Delete" button for a
   pattern which is in use by at least one subscription. In the
   confirmation dialog, clicking the "Show subscriptions" link should
   display a list of titles.
 - Edit or create a numbering pattern.
 - Confirm that the "Test pattern" button works correctly.

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17254] Scan and Deliver-feature (mail selected digitized material)

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17254

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Maybe this could build on 14610 - a feature to order articles.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17254] New: Scan and Deliver-feature ( mail selected digitized material)

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17254

Bug ID: 17254
   Summary: Scan and Deliver-feature (mail selected digitized
material)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

Several special libraries, university libraries etc. offer a feature to scan
selected chapters of books, or articles of serials and mail a PDF within a few
days. Free or for a small contribution.

How could we implement such a feature in Koha ? Any thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #93 from Katrin Fischer  ---
Matthias, I am sorry, but there is still something odd about the test:
rollback ineffective with AutoCommit enabled at t/db_dependent/Serials_2.t line
257.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17072] 006 not filling in with existing values

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17072

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

--- Comment #9 from Marcel de Rooy  ---
We should probably remove all fork calls. Resolve it with an ajax call (like
the upload in one of these scripts) or via a queue serviced by some daemon.
In general, it seems better to prevent starting jobs directly by the web
interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17072] 006 not filling in with existing values

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17072

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #55095|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 55198
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55198=edit
[SIGNED-OFF]Bug 17072: 006 not filling in with existing values

When you use the 006 builder to view the existing values in the 006
tag, Koha is not pulling these existing values into the builder
window. Instead, Koha appears to be using defaults.

To reproduce:

1. Open a record in the editor
2. Switch from BKS to another material type.
3. Change as many settings as possible.
4. Close plugin.
5. Reopen plugin - notice your selections are not shown.

Trivial patch, heavilly inspired by Bug 9093.

To test:

1. Apply patch
2. Ensure that issue described above is no longer reproductible

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54794|0   |1
is obsolete||

--- Comment #33 from Tomás Cohen Arazi  ---
Created attachment 55196
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55196=edit
Bug 16911: ->get_expiry_date accepts strings

To make sure nothing else will be broken, it's certainly better to
handle date strings in a first phase.

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54792|0   |1
is obsolete||

--- Comment #31 from Tomás Cohen Arazi  ---
Created attachment 55194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55194=edit
Bug 16911: Koha::Patrons - Move ExtendMemberSubscriptionTo to
->extend_subscription

This patch moves the code from C4::Members::ExtendMemberSubscriptionTo
to Koha::Patron->extend_subscription.

The expected behavior is:
When a new patron is created, the enrolment period defined for the
patron category is used unless an enrolment period date is defined. In
that case, this date is used.
When an account is renewed, the pref BorrowerRenewalPeriodBase is used to
determine if the subscription is renewed from today or from the day when
his/her
account has expired.

Test plan:
Confirm that the behavior is correct before this patch and that it's
still the same after this patchset applied.

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

--- Comment #34 from Tomás Cohen Arazi  ---
Created attachment 55197
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55197=edit
Bug 16911: (QA followup) CGI->param should not be called in list context

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54793|0   |1
is obsolete||

--- Comment #32 from Tomás Cohen Arazi  ---
Created attachment 55195
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55195=edit
Bug 16911: Rename extend_subscription with renew_account

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54791|0   |1
is obsolete||

--- Comment #30 from Tomás Cohen Arazi  ---
Created attachment 55193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55193=edit
Bug 16911: Koha::Patrons - Add tests for ->extend_subscription

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54790|0   |1
is obsolete||

--- Comment #29 from Tomás Cohen Arazi  ---
Created attachment 55192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55192=edit
Bug 16911: Koha::Patron::Categories - Move GetExpiryDate to ->get_expiry_date

This patch moves the code from C4::Members::GetExpiryDate to
Koha::Patron::Categories.
Nothing much exiting, please follow test plan in next patches.

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16911] Koha::Patrons - Move ExtendMemberSubscriptionTo to -> renew_account

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16911

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #54789|0   |1
is obsolete||

--- Comment #28 from Tomás Cohen Arazi  ---
Created attachment 55191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55191=edit
Bug 16911: Koha::Patron::Categories - Add tests for ->get_expiry_date

Signed-off-by: Aleisha Amohia 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #6 from M. Tompsett  ---
(In reply to Tomás Cohen Arazi from comment #5)
> Is this the right solution? What happens if the DB structure is already
> changed?

It also doesn't make sense, because just a few lines above: DROP IF EXISTS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #53996|0   |1
is obsolete||

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 55190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55190=edit
Bug 16851: Move HasOverdues to Koha::Patron->has_overdues

This patch just move C4::Members::HasOverdues to
Koha::Patron->has_overdues and updated callers

Test plan:
No change in behavior is expected.
1/ If a patron is debarred and does not have overdues and
AutoRemoveOverduesRestrictions is on, the debarment will be removed on
checkin
2/ Add overdues and make sure the patron cannot renew

Signed-off-by: Owen Leonard 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16851] Move HasOverdues to Koha::Patron->has_overdues

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16851

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

--- Comment #1 from Jonathan Druart  
---
Created attachment 55189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55189=edit
Bug 17253: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

This patch replaces the call to C4::Koha::GetKohaAuthorisedValues with
Koha::AuthorisedValues->search_by_koha_field

Test plan:
AV descriptions should be displayed on the following pages:
- XSLT view - location and ccode
- Bibliographic detail, moredetail and OPAC pages - location, ccode, copynumber
- returns - location
- opac-basket - ccode, location
- The 3 reports: catalogue_stats.pl, issues_stats.pl and
  reserves_stats.pl - location, ccode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17252] Koha::AuthorisedValues - Remove GetAuthorisedValueByCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17253


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253
[Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17252


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252
[Bug 17252] Koha::AuthorisedValues - Remove GetAuthorisedValueByCode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17251] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17252


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252
[Bug 17252] Koha::AuthorisedValues - Remove GetAuthorisedValueByCode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17252] Koha::AuthorisedValues - Remove GetAuthorisedValueByCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17252] Koha::AuthorisedValues - Remove GetAuthorisedValueByCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17251


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251
[Bug 17251] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17252] Koha::AuthorisedValues - Remove GetAuthorisedValueByCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252

--- Comment #1 from Jonathan Druart  
---
Created attachment 55188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55188=edit
Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode

The subroutine C4::Koha::GetAuthorisedValueByCode returned the
description (staff or opac) for a given authorised value.

Note that we may need a unique key to ->find instead of ->search.

Test plan:
- Checkin an item that cannot be checked in because it's lost, the
  message should display the AV description
- Generate a letter with borrowers.streettype equals an ROADTYPE AV, the
  description should be displayed.
- Edit a patron attribute type, the AV dropdown list should be
  displayed
- Create the PA_CLASS AV category (see bug 7154) and make sure it
  behaves as before when editing a patron
- The checkout list should display descriptions for LOC, LOST and
  DAMAGED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17251] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251

--- Comment #1 from Jonathan Druart  
---
Created attachment 55187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55187=edit
Bug 17251: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping

This subroutine was only used once in GetItemsForInventory.
It can be replaced with a quite simple search on AV join on
authorised_value_categories and marc_subfield_structures tables.

Note that the "interface" parameter was always set to "staff" and was
useless.

Test plan:
Play with the inventory and confirm that the AV descriptions are
correctly displayed.

The tests in t/db_dependent/Items/GetItemsForInventory.t cover this
change and should still pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17251] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17251


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251
[Bug 17251] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17251] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17250


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250
[Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250

--- Comment #1 from Jonathan Druart  
---
Created attachment 55186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55186=edit
Bug 17250 - Koha::AuthorisedValues - Remove GetAuthValCode

The subroutine C4::Koha::GetAuthValCode returned the authorised value
category for a given kohafield.
This can be acchieve easily using a new
Koha::AuthorisedValues->search_by_koha_field
method which will mimic search_by_marc_field.

Test plan:
Confirm that the description is correctly displayed on the following
pages:
- detail and moredetail of a bibliographic page (itemlost, damaged, materials)
- Set AcqCreateItem=ordering and receiving items.
The description for notforloan, restricted, location, ccode, etc.
field should be displayed.
- Items search form
- On the checkout list from the circulation.pl and returns.pl
pages, the description for "materials" should be displayed

Note that GetKohaAuthorisedValuesMapping is going to be removed on bug
17251.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett  changed:

   What|Removed |Added

  Attachment #55046|0   |1
is obsolete||

--- Comment #146 from M. Tompsett  ---
Created attachment 55185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55185=edit
Bug 11592: (QA followup) Add missing framework code to ViewPolicy filter calls

This patch adds the frameworkcode option param, using each record's
frameworkcode
as expected by the filter. Otherwise the ViewPolicy filter falls back to the
default framework.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592

M. Tompsett  changed:

   What|Removed |Added

  Attachment #55045|0   |1
is obsolete||

--- Comment #145 from M. Tompsett  ---
Created attachment 55184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55184=edit
Bug 11592: (QA followup) Simplify code

Koha::RecordProcessor and the defined filters are supposed to bring us
joy and happiness. Let's keep the code compact, simple and clean.

This patch removes record cloning all over the place.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17249


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249
[Bug 17249] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesFromField
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17250


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250
[Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #55175|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 55183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55183=edit
Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

The subroutine C4::Koha::GetKohaAuthorisedValueLib just retrieves a description
(lib) for a given authorised value.

We can easily replace it using:
  Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av
})->lib
or
  Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av
})->opac_description

Test plan:
- On the detail page of a bibliographic record, the description for notforloan,
restricted and stack (?) should be correctly displayed
- View a shelf, the location (LOC) description should be displayed
- On the search result page, the location description should be displayed in
the
  facets
- Set AcqCreateItem=ordering and receiving items.
The description for notforloan, restricted, location, ccode, etc. field
should be displayed.
- When creating item in the acquisition module, the dropdown list for
  field linked to AV should display the AV' descriptions
- On the transfers page, the description of the location should be
  displayed.
- On the checkout list from the circulation.pl and returns.pl pages, the
  description for "materials" should be displayed
- Fill some OPAC_SUG AV and create a suggestion, the reason dropdown
  list should display the description of OPAC_SUG

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

--- Comment #7 from Jonathan Druart  
---
Created attachment 55182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55182=edit
Bug 17249: GetKohaAuthorisedValuesFromField - rm GetAuthValCodeFromField

The subroutine GetAuthValCodeFromField was only used from
GetKohaAuthorisedValuesFromField.

Test plan:
  git grep GetAuthValCodeFromField
should not return any occurrences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

--- Comment #6 from Jonathan Druart  
---
Created attachment 55181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55181=edit
Bug 17249: Remove GetKohaAuthorisedValuesFromField

Remove the subroutine, it's no longer in used.

Test plan:
  git grep GetKohaAuthorisedValuesFromField
should not return any occurrences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

--- Comment #3 from Jonathan Druart  
---
Created attachment 55178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55178=edit
Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add search_by_marc_field

This patch adds a new Koha::AuthorisedValues->search_by_marc_field
method.
It will permit to replace several subroutine from C4::Koha dealing with
authorised values.
It also uses this new methods to replace an occurrence of
GetKohaAuthorisedValuesFromField in C4::Record::marcrecord2csv

Test plan:
  prove t/db_dependent/AuthorisedValues.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

--- Comment #4 from Jonathan Druart  
---
Created attachment 55179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55179=edit
Bug 17249: Remove GetKohaAuthorisedValuesFromField - inventory

This patch deals with the inventory files calling
GetKohaAuthorisedValuesFromField.

Test plan:
  prove t/db_dependent/Items/GetItemsForInventory.t
should still return green

Use the inventory tool, on the result page the AV descriptions should
correctly replace the codes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

--- Comment #2 from Jonathan Druart  
---
Created attachment 55177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55177=edit
Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests

This patch adds a few tests to C4::Record::marcrecord2csv
The subroutine was not covered enough to validate that this patch set
won't add regressions.

Note that the patch set will fix an issue: If 2 subfields of a field are
linked to AVs and you want to display them in a CSV, they won't be
replaced with their descriptions.

Test plan:
Apply the patch, and make a copy of t/db_dependent/Record/marcrecord2csv.t
Checkout master and prove marcrecord2csv.t
Tests should fail
Checkout the branch with the whole patch set applied
The tests should pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

--- Comment #5 from Jonathan Druart  
---
Created attachment 55180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55180=edit
Bug 17249: Remove GetKohaAuthorisedValuesFromField - (follow-up) inventory

Before this patch set, the tests in
t/db_dependent/Items/GetItemsForInventory.t were executed in 4s. But
with the previous patch, it was in 45sec(!)
To make sure decrease this execution time to what it was before, this
patch introduces a local to avoid the same query to be executed several
times.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

--- Comment #1 from Jonathan Druart  
---
Created attachment 55176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55176=edit
Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add classes
MarcSubfieldStructure[s]

This patch adds the 2 Koha::Object based classes for the
marc_subfield_structure table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17216, 17248


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216
[Bug 17216] Add a new table to store authorized value categories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248
[Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17249


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249
[Bug 17249] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesFromField
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17249


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249
[Bug 17249] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesFromField
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #8 from Tomás Cohen Arazi  ---
I don't agree with the proposed solution (we should make it work). But I love
the first patch, it should have it's own bug, something like "Add
C4::Context->is_psgi" in the title :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #30 from Jonathan Druart  
---
(In reply to M. Tompsett from comment #29)
> (In reply to Jonathan Druart from comment #28)
> > ping!
> 
> bug 17234?

No, the schema files are not up-to-date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Is this the right solution? What happens if the DB structure is already
changed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17253

--- Comment #11 from Jonathan Druart  
---
Bug 17253 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValues


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253
[Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15799


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799
[Bug 15799] Move authorised values related code into Koha::AuthorisedValues -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17250

--- Comment #8 from Jonathan Druart  
---
Bug 17250 - Koha::AuthorisedValues - Remove GetAuthValCode


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250
[Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17252] Koha::AuthorisedValues - Remove GetAuthorisedValueByCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15799


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799
[Bug 15799] Move authorised values related code into Koha::AuthorisedValues -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17251

--- Comment #9 from Jonathan Druart  
---
Bug 17251 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251
[Bug 17251] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17252

--- Comment #10 from Jonathan Druart  
---
Bug 17252 - Koha::AuthorisedValues - Remove GetAuthorisedValueByCode


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252
[Bug 17252] Koha::AuthorisedValues - Remove GetAuthorisedValueByCode
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17251] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesMapping

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15799


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799
[Bug 15799] Move authorised values related code into Koha::AuthorisedValues -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15799


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799
[Bug 15799] Move authorised values related code into Koha::AuthorisedValues -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17253] New: Koha::AuthorisedValues - Remove GetKohaAuthorisedValues

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17253

Bug ID: 17253
   Summary: Koha::AuthorisedValues - Remove
GetKohaAuthorisedValues
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17249

--- Comment #7 from Jonathan Druart  
---
Bug 17249 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesFromField


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249
[Bug 17249] Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesFromField
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15799


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799
[Bug 15799] Move authorised values related code into Koha::AuthorisedValues -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17252] New: Koha::AuthorisedValues - Remove GetAuthorisedValueByCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17252

Bug ID: 17252
   Summary: Koha::AuthorisedValues - Remove
GetAuthorisedValueByCode
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17251] New: Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesMapping

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17251

Bug ID: 17251
   Summary: Koha::AuthorisedValues - Remove
GetKohaAuthorisedValuesMapping
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17102] Automatically minify swagger.json

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17102

--- Comment #5 from Tomás Cohen Arazi  ---
I don't think we should automatically regenerate it. The deployed file should
be production ready and no source of issues for end-users.

It looks to me that we just need to provide ways for devs to set that if
needed. Be it under kohadevbox or on regular dev setups.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17250] New: Koha::AuthorisedValues - Remove GetAuthValCode

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250

Bug ID: 17250
   Summary: Koha::AuthorisedValues - Remove GetAuthValCode
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17249] New: Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249

Bug ID: 17249
   Summary: Koha::AuthorisedValues - Remove
GetKohaAuthorisedValuesFromField
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248

--- Comment #1 from Jonathan Druart  
---
Created attachment 55175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55175=edit
Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

The subroutine C4::Koha::GetKohaAuthorisedValueLib just retrieves a description
(lib) for a given authorised value.

We can easily replace it using:
  Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av
})->lib
or
  Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av
})->opac_description

Test plan:
- On the detail page of a bibliographic record, the description for notforloan,
restricted and stack (?) should be correctly displayed
- View a shelf, the location (LOC) description should be displayed
- On the search result page, the location description should be displayed in
the
  facets
- Set AcqCreateItem=ordering and receiving items.
The description for notforloan, restricted, location, ccode, etc. field
should be displayed.
- When creating item in the acquisition module, the dropdown list for
  field linked to AV should display the AV' descriptions
- On the transfers page, the description of the location should be
  displayed.
- On the checkout list from the circulation.pl and returns.pl pages, the
  description for "materials" should be displayed
- Fill some OPAC_SUG AV and create a suggestion, the reason dropdown
  list should display the description of OPAC_SUG

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17234

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17234] ALTER IGNORE TABLE is invalid in mysql 5.7. This breaks updatedatabase.pl

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17234

M. Tompsett  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16573

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16573] Web installer fails to load structure and sample data on MySQL 5.7

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16573

--- Comment #29 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #28)
> ping!

bug 17234?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15799] Move authorised values related code into Koha:: AuthorisedValues - part 2

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799

--- Comment #6 from Jonathan Druart  
---
Bug 17248 - Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17248] New: Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248

Bug ID: 17248
   Summary: Koha::AuthorisedValues - Remove
GetKohaAuthorisedValueLib
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 17216
Blocks: 15799

The subroutine C4::Koha::GetKohaAuthorisedValueLib just retrieves a description
(lib) for a given authorised value.

We can easily replace it using:
  Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av
})->lib
or
  Koha::AuthorisedValues->search({ category => $cat, authorised_value => $av
})->opac_description


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799
[Bug 15799] Move authorised values related code into Koha::AuthorisedValues -
part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216
[Bug 17216] Add a new table to store authorized value categories
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-09-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17248


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248
[Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 149 matches

Mail list logo