date:20161102

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

M. Tompsett  changed:

   What|Removed |Added

 CC||eugen...@yahoo.com

--- Comment #16 from M. Tompsett  ---
Rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

M. Tompsett  changed:

   What|Removed |Added

  Attachment #53488|0   |1
is obsolete||

--- Comment #15 from M. Tompsett  ---
Created attachment 57113
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57113=edit
Bug 16892: Follow up with adding missing IGNORE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

M. Tompsett  changed:

   What|Removed |Added

  Attachment #53485|0   |1
is obsolete||

--- Comment #14 from M. Tompsett  ---
Created attachment 57112
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57112=edit
Bug 16892: System Preferences

This adds the missing system preferences for a fresh install.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

M. Tompsett  changed:

   What|Removed |Added

  Attachment #53257|0   |1
is obsolete||

--- Comment #13 from M. Tompsett  ---
Created attachment 57111
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57111=edit
Bug 16892: Add automatic patron registration via OAuth2 login

10988 added the ability to log into the OPAC authenticating with
Google Open ID Connect. This extends it, by allowing an
unregistered patron to have an account automatically created
with default category code and branch.

This is accomplished by adding 3 system preferences.
- GoogleOpenIDConnectAutoRegister
  whether it will attempt to auto-register the patron.
- GoogleOpenIDConnectDefaultCategory
  This category code will be used to create Google OpenID Connect patrons.
- GoogleOpenIDConnectDefaultBranch'
  This branch code will be used to create Google OpenID Connect patrons.

Sponsored-by: Tulong Aklatan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17524] Datepicker on checkout fails when dateformat = iso

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17542] New: Altering an invoice throws error unless shipment date and billing date both defined or both undefined

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17542

Bug ID: 17542
   Summary: Altering an invoice throws error unless shipment date
and billing date both defined or both undefined
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When creating an invoice you can create it without a billing or shipment date

You can then alter the shipment cost, however, trying to define a billing date
without first defining a shipment date causes:
invoice.pl: Odd number of elements in hash assignment at
/home/vagrant/kohaclone/C4/Acquisition.pm line 2700., referer:
http://localhost:8081/cgi-bin/koha/acqui/invoice.pl


Define only a shipment date and the change will go through, but then attempting
to change the shipment cost will fail until a billing date is also defined

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14764] Add OPAC News branch selector

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Liz Rea  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14764] Add OPAC News branch selector

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Liz Rea  changed:

   What|Removed |Added

  Attachment #57063|0   |1
is obsolete||

--- Comment #34 from Liz Rea  ---
Created attachment 57110
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57110=edit
Bug 14764: OPAC news selector

Test plan:

1) Add more than one library, at least two in total is needed. Make note of
which is your current user's home branch.
2) Go to Tools -> News and add one global ("All") news item and one specific
for each branch.
3) Apply the patches.
4) Perform database upgrades when you log in.
5) Go to OPAC main, it should work as before: Showing global news as well as
the news for your home branch once logged in.
6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to yes.
7) Go to OPAC main, you should see the global news item plus any items for your
home branch for the current user if logged in.
8) Above the news, you will see a dropdown that lists the branches. Select one,
and click "Change library."
9) You should now see global news and the news for the selected branch,
regardless of whether logged in or not.

Sponsored-By: Halland County Library

Fixes QA comments:

* Keep the current selected branch selected

* Change OPACNewsBranchSelect -> OPACNewsLibrarySelect

* fix 'system wide only' view for logged in user. We still show system wide
even when a library is selected.

* Removed the "change library" link

* Added a label to the field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Andreas Hedström Mace  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #24 from Andreas Hedström Mace  ---
Doesn't apply for me. Needs yet another rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12812] Longoverdue.pl --mark-returned doesn't return items

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12812

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12363] Marking an item as lost in koha always returns it, but longoverdue.pl may not

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12363

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17160] Foreign key constraint for message_transports is too loose

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17160

--- Comment #4 from Barton Chittenden  ---
(In reply to Katrin Fischer from comment #3)
> Wondering - how would you delete a single message transport line without
> SQL? In the GUI the letter with all its message types appears as one thing
> that can only be deleted completely.

Cait,

I'm pretty sure that updatedatabase did it on Bug 13171.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17541] Add ability to log all barcodes scanned at checkin

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17541

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17541] Add ability to log all barcodes scanned at checkin

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17541

Claire Gravely  changed:

   What|Removed |Added

  Attachment #57108|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 57109
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57109=edit
Bug 17541 - Add ability to log all barcodes scanned at checkin

On occasion, librarians claim that a barcode was scanned successfully
at checkin but the item was not returned. It would be useful to be able
to log all scanned barcodes at checkin regardless of validity to know if
the barcode scan made it to Koha or if there is an issue keeping it from
being received by the server.

Test Plan:
1) Apply the patch
2) Run updatedatabase.pl
3) Enable the new system preference CirculationCheckinLog
4) Can some valid and invalid barcdes through the checkin screen
5) View the circulation log from the log viewer tool
6) Note the barcodes are there!

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17518] Displayed language name for Czech is wrong

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17518

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17504] Installer shows PostgreSQL info when wrong DB permissions

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17504

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||frede...@tamil.fr

--- Comment #5 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17524] Datepicker on checkout fails when dateformat = iso

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17524

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|Pushed to Master|Pushed to Stable

--- Comment #11 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17443] Make possible to renew patron by later of expiry and current date

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17443

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||frede...@tamil.fr

--- Comment #8 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4880] koha-remove sometimes fails because user is logged in

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4880

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||frede...@tamil.fr

--- Comment #15 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7039] Link to existing record from result list in acquisition search

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7039

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16952] Add sorting rules for Czech language to Zebra

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16952

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #19 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17435] Gives ability to display stocknumber in the search results

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17435

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||frede...@tamil.fr

--- Comment #5 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17434] Moremember displaying primary and secondary phone number twice

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17434

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||frede...@tamil.fr

--- Comment #6 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17417] Correct invalid markup around news on the staff client home page

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17417

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17376] rebuild_zebra.pl in daemon mode no database access kills the process

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17376

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16935] launch export_records.pl with deleted_barcodes param fails

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16935

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||frede...@tamil.fr

--- Comment #5 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17541] Add ability to log all barcodes scanned at checkin

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17541

--- Comment #1 from Kyle M Hall  ---
Created attachment 57108
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57108=edit
Bug 17541 - Add ability to log all barcodes scanned at checkin

On occasion, librarians claim that a barcode was scanned successfully
at checkin but the item was not returned. It would be useful to be able
to log all scanned barcodes at checkin regardless of validity to know if
the barcode scan made it to Koha or if there is an issue keeping it from
being received by the server.

Test Plan:
1) Apply the patch
2) Run updatedatabase.pl
3) Enable the new system preference CirculationCheckinLog
4) Can some valid and invalid barcdes through the checkin screen
5) View the circulation log from the log viewer tool
6) Note the barcodes are there!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17541] Add ability to log all barcodes scanned at checkin

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17541

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17541] New: Add ability to log all barcodes scanned at checkin

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17541

Bug ID: 17541
   Summary: Add ability to log all barcodes scanned at checkin
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

On occasion, librarians claim that a barcode was scanned successfully at
checkin but the item was not returned. It would be useful to be able to log all
scanned barcodes at checkin regardless of validity to know if the barcode scan
made it to Koha or if there is an issue keeping it from being received by the
server.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17541] Add ability to log all barcodes scanned at checkin

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17541

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17375] Prevent internal software error when searching patron with invalid birth date

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17375

Frédéric Demians  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||frede...@tamil.fr

--- Comment #13 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.06.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17516] Add CSV export option to item search after displaying output to screen

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17516

Claire Gravely  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17516] Add CSV export option to item search after displaying output to screen

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17516

Claire Gravely  changed:

   What|Removed |Added

  Attachment #56998|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 57107
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57107=edit
Bug 17516 - Add CSV export option to item search after displaying output to
screen

To test:
1 - Perform an item search
2 - Note you now have a link to output to csv
3 - Click that link
4 - Page should not change and you should recieve a csv
5 - Ensure nothing breaks
6 - Sign off
High five!

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

--- Comment #7 from Claire Gravely  ---
(In reply to Jonathan Druart from comment #6)
> (In reply to Claire Gravely from comment #3)
> > test failed for me:
> > 
> > t/db_dependent/www/auth_values_input_www.t .. You tried to plan twice at
> > t/db_dependent/www/auth_values_input_www.t line 47.
> > # Looks like your test exited with 255 before it could output anything.
> > t/db_dependent/www/auth_values_input_www.t .. Dubious, test returned 255
> > (wstat 65280, 0xff00)
> > Failed 33/33 subtests
> 
> This is because you did not export KOHA_INTRANET_URL and KOHA_OPAC_URL

Thanks, yes, worked on kohadevbox!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #5 from Marcel de Rooy  ---
There is already an use_ok in the Reserves test.
If you add another use, maybe change use_ok to require_ok ?
Did the same somewhere else..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

--- Comment #6 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #5)
> There is already an use_ok in the Reserves test.
> If you add another use, maybe change use_ok to require_ok ?
> Did the same somewhere else..

Since we have tests for these modules, I am not sure the use_ok are really
useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15986] Add a script for sending hold waiting reminder notices

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15986

--- Comment #10 from Marcel de Rooy  ---
I like the feature, but would love to see less (new) code in cron scripts and
more code in our modules. With advantages of testing etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17534] Press a button and get a fresh DB

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17534

--- Comment #2 from Josef Moravec  ---
I think it's useful for development and testing... When I am working with db
changes I need new database relatively often :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17535] Regression: Search for reports by keywords

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17535] Regression: Search for reports by keywords

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17535

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57069|0   |1
is obsolete||

--- Comment #2 from Josef Moravec  ---
Created attachment 57106
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57106=edit
[SIGNED-OFF] Bug 17535: Fix search for reports by keywords

The commit cf9031711282f4be23e4a639797d0fd178940e1f
Bug 14435: Add the ability to store result's report
introduced a regression when searching for reports by keywords.
It also breaks tests in t/db_dependent/Reports/Guided.t

It's caused by the missing join on saved_reports.
The error says DBD::mysql::db selectall_arrayref failed: Unknown column
'report' in 'where clause'

Test plan:
Confirm that the tests are fixed and that you are able to search for
reports using the "keyword" input

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

--- Comment #6 from Jonathan Druart  
---
(In reply to Claire Gravely from comment #3)
> test failed for me:
> 
> t/db_dependent/www/auth_values_input_www.t .. You tried to plan twice at
> t/db_dependent/www/auth_values_input_www.t line 47.
> # Looks like your test exited with 255 before it could output anything.
> t/db_dependent/www/auth_values_input_www.t .. Dubious, test returned 255
> (wstat 65280, 0xff00)
> Failed 33/33 subtests

This is because you did not export KOHA_INTRANET_URL and KOHA_OPAC_URL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #5 from Josef Moravec  ---
Test passed cleanly for me...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
This should no longer be possible from the interface, so what about updating
the bad data as well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

Josef Moravec  changed:

   What|Removed |Added

  Attachment #57078|0   |1
is obsolete||

--- Comment #4 from Josef Moravec  ---
Created attachment 57105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57105=edit
[SIGNED-OFF] Bug 17540: (Bug 7216 followup) Fix tests for
auth_values_input_www.t

This is caused by bug 17216 which modified the structure of the AV admin
page

Test plan:
  prove t/db_dependent/www/auth_values_input_www.t
should return green

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17481] Cas Logout: bug 11048 has been incorrectly merged

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481

--- Comment #4 from Katrin Fischer  ---
Go for it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17481] Cas Logout: bug 11048 has been incorrectly merged

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |matthias.meusburger@biblibr
   ||e.com
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|enhancement |major

--- Comment #3 from Jonathan Druart  
---
Looking at the changes, it sounds trivial that the patches waited for 6 months
and that it conflicts.
Redirect after a redirect does not make sense.
I would be keen to sent it to PQA directly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

Claire Gravely  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com

--- Comment #3 from Claire Gravely  ---
test failed for me:

t/db_dependent/www/auth_values_input_www.t .. You tried to plan twice at
t/db_dependent/www/auth_values_input_www.t line 47.
# Looks like your test exited with 255 before it could output anything.
t/db_dependent/www/auth_values_input_www.t .. Dubious, test returned 255 (wstat
65280, 0xff00)
Failed 33/33 subtests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

Marc Véron  changed:

   What|Removed |Added

  Attachment #57010|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 57104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57104=edit
Bug 17526 - OPAC lists require a sortfield

Using the OPAC, going into the public lists, we click one of them and get

DBIx::Class::Storage::DBI::_dbh_execute(): You have an error in your SQL
syntax; check the manual that corresponds to your MySQL server version for the
right syntax to use near 'ASC LIMIT 10) `me`  JOIN `biblio` `biblionumber` ON
`biblionumber`.`biblionumber'

THis is because the sortfield is empty and creates a SQL like GROUP BY ASC
LIMIT 10.  Missing the group by .
In the intranet list, there's a default usage of 'title' that makes it all
work.

TESTING:
1) just create a public list with no sortfield.  In the DB:
   - virtualshelves.category = 2
   - virtualshelves.sortfield = ''
2) click on the list in the OPAC's public list.  Boom!

This simple patch uses 'title' if nothing else is specified.

Reproduced. Patch fixes issue as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537

Claire Gravely  changed:

   What|Removed |Added

  Attachment #57076|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 57103
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57103=edit
Bug 17537: Fix valid-templates.t for some include files

3 include files do not pass the template validation tests:
 - koha-tmpl/intranet-tmpl/prog/en/includes/admin-items-search-field-form.inc
 - koha-tmpl/intranet-tmpl/prog/en/includes/subscriptions-search.inc
 - koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-topissues.inc

This is because they process a block which has not been declared before.
As they are include files, they cannot stand on their own.
We could have added them to the exclude file list of
xt/author/valid-templates.t
but I think it's better to keep them into the validation loop.

Test plan:
  prove xt/author/valid-templates.t
should return green
And the library dropdown list should be correctly populated on the pages these
files are included
(opac-topissues for instance)

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17537] xt/author/valid-templates.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17537

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #29 from Josef Moravec  ---
I tested these patches and found some issues:

When editing biblio (cataloguing/addbiblio.pl), the button "Z39.50/SRU Search"
is here twice - probably due to rebase

Button "Link authorities automatically" doesn't have icon - please use font
awesome icons instead of obsoleted icon-* classes

When trying to link on blank record i got "undefined - undefined" response
instead of "No authority link was changed."

Icons next to authority fields  (approve.gif / deny.gif) are not showing.

The matching itself looks OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17522] opac-user.pl gives error of OpacRenewalAllowed is enabled

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17522] opac-user.pl gives error of OpacRenewalAllowed is enabled

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522

Marc Véron  changed:

   What|Removed |Added

  Attachment #57048|0   |1
is obsolete||

--- Comment #7 from Marc Véron  ---
Created attachment 57102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57102=edit
Bug 17522 - opac-user.pl gives error of OpacRenewalAllowed is enabled

If OpacRenewalAllowed is enabled, the following error message is
displayed:

Template process failed: undef error - The method is_expired is not
covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121.

Test Plan:
1) Check out an item for a patron
2) Enable OpacRenewalAllowed
3) Log in as that patron, go to opac-user.pl
4) Note the error
5) Apply this patch
6) Reload opac-user.pl
7) Page should now load!

Problem reproduced, patch fixes it. Signing off to move it forward.
However see comment #6 for QA
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17371] REST API: add CRUD for biblios

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371

--- Comment #3 from Magnus Enger  ---
Setting this to "needs signoff", please correct me if I'm wrong!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17371] REST API: add CRUD for biblios

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371

Magnus Enger  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||14610


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610
[Bug 14610] Add ability to place article requests in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

--- Comment #4 from Jonathan Druart  
---
Lari, good catch.
But still fail for me:
Tag "" is not a valid tag. at t/db_dependent/Reserves.t line 510.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17539


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539
[Bug 17539] t/db_dependent/Reserves.t is failing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #13 from Kyle M Hall  ---
Created attachment 57101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57101=edit
Bug 16735 - Replace existing library search groups functionality with the new
hierarchical groups system

Test Plan:
1) Apply this patch set
2) Note your existing search groups have been ported over to the new
   __SEARCH_GROUPS__ group if you had any
3) Create the group __SEARCH_GROUPS__ if one does not already exist
4) Add some first level subgroups to this group, add libraries to those groups
5) Search the library group searching in the intranet and opac
6) Note you get the same results as pre-patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #12 from Kyle M Hall  ---
Created attachment 57100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57100=edit
Bug 16735 - Clean up sample data

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

--- Comment #11 from Kyle M Hall  ---
Created attachment 57099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57099=edit
Bug 16735 - Remove tables no longer needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52732|0   |1
is obsolete||
  Attachment #52733|0   |1
is obsolete||
  Attachment #52734|0   |1
is obsolete||
  Attachment #52735|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 57098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57098=edit
Bug 16735 - Remove modules no longer needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17538] t/db_dependent/Upload.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17538

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #57077|0   |1
is obsolete||

--- Comment #2 from Marcel de Rooy  ---
Created attachment 57097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57097=edit
Bug 17538: (Bug 17216 follow-up) Fix t/db_dependent/Upload.t

The insert into authorised_values failed because of the missing FK

Test plan:
  prove t/db_dependent/Upload.t
should return green

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17538] t/db_dependent/Upload.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17538

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

Lari Taskula  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

--- Comment #3 from Lari Taskula  ---
Created attachment 57096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57096=edit
Bug 17539: Fix failing Reserves.t tests if category enrolmentfee > 0

To test:
1. Set patron category "S" with enrolmentfee 1
2. perl t/db_dependent/Reserves.t
3. Observe following errors:

not ok 59 - Bug 14464 - No fines at beginning
ok 60 - Bug 14464 - 1st reserve correctly created
ok 61 - Bug 14968 - Keep found column from reserve
not ok 62 - Bug 14464 - No fines after cancelling reserve with no charge
configured
ok 63 - Bug 14464 - 2nd reserve correctly created
not ok 64 - Bug 14464 - No fines after cancelling reserve with no charge
desired
ok 65 - Bug 14464 - 1st reserve correctly created
not ok 66 - Bug 14464 - Fine applied after cancelling reserve with charge
desired and configured

4. Apply patch
5. perl t/db_dependent/Reserves.t
6. Observe test pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

--- Comment #2 from Lari Taskula  ---
Created attachment 57095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57095=edit
Bug 17539: Fix Already in a transaction error

perl t/db_dependent/Reserves.t

1..72
ok 1 - use C4::Reserves;
ok 2 - CheckReserves Test 1
...
ok 52 - Reserve in waiting status cant be canceled
ok 53 - Reserving an ageRestricted Biblio without a borrower dateofbirth
succeeds
DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489.
DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1489.
at /usr/share/perl5/DBIx/Class/Schema.pm line 1080.
...
Koha::Object::store('Koha::Patron=HASH(0x9e43b20)') called at
/home/ubuntu/kohaclone/C4/Members.pm line 542
C4::Members::ModMember('borrowernumber', 658535, 'dateofbirth', '2001-11-02')
called at t/db_dependent/Reserves.t line 516

This patch fixes this issue by replacing dbh autocommit=0 with
txn_begin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

--- Comment #1 from Lari Taskula  ---
Created attachment 57094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57094=edit
Bug 17539: Fix Undefined subroutine ::Circulation::GetItem error

perl t/db_dependent/Reserves.t

1..72
ok 1 - use C4::Reserves;
ok 2 - CheckReserves Test 1
ok 3 - CheckReserves() include reserve_id in its response
ok 4 - CheckReserves Test 2
ok 5 - CheckReserves Test 3
ok 6 - GetReservesControlBranch returns item home branch when set to
ItemHomeLibrary
ok 7 - GetReservesControlBranch returns patron home branch when set to
PatronLibrary
ok 8 - Item is correctly waiting
ok 9 - Item is correctly priority 1
ok 10 - Item is correctly priority 2
ok 11 - GetWaiting got only the waiting reserve
ok 12 - GetWaiting got the reserve for the correct borrower
Undefined subroutine ::Circulation::GetItem called at
/home/ubuntu/kohaclone/C4/Circulation.pm line 1853.

This patch fixes this error. The solution was to use C4::Reserves before
C4::Items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17539] t/db_dependent/Reserves.t is failing

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17539

Lari Taskula  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|lari.task...@jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #107 from Kyle M Hall  ---
Created attachment 57091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57091=edit
Bug 15707 [QA Followup] - Remove class for treegrid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #109 from Kyle M Hall  ---
Created attachment 57093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57093=edit
Bug 15707 - Update Schema Files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #106 from Kyle M Hall  ---
Created attachment 57090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57090=edit
Bug 15707 [QA Followup] - Fix UI issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #108 from Kyle M Hall  ---
Created attachment 57092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57092=edit
Bug 15707 [QA Followup] - Allow object names to be styled without impeding
translation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #100 from Kyle M Hall  ---
Created attachment 57084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57084=edit
Bug 15707 - Add editor

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #104 from Kyle M Hall  ---
Created attachment 57088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57088=edit
Bug 15707 [QA Followup] - Switch to treetable which Koha already uses

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #57081|0   |1
is obsolete||

--- Comment #98 from Kyle M Hall  ---
Created attachment 57082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57082=edit
Bug 15707 - Update DB

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #102 from Kyle M Hall  ---
Created attachment 57086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57086=edit
Bug 15707 - Unit Tests

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #105 from Kyle M Hall  ---
Created attachment 57089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57089=edit
Bug 15707: QA follow-up - Drop table if exists

1/ DROP table if exists
2/ FAIL   spelling
decendents  ==> descendants

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #103 from Kyle M Hall  ---
Created attachment 57087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57087=edit
Bug 15707: Fix conflict with bug 15446 (type vs _type)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #101 from Kyle M Hall  ---
Created attachment 57085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57085=edit
Bug 15707 - Add TreeGrid library to about page

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #99 from Kyle M Hall  ---
Created attachment 57083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57083=edit
Bug 15707 - Add new modules

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #57080|0   |1
is obsolete||

--- Comment #97 from Kyle M Hall  ---
Created attachment 57081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57081=edit
Bug 15707 - Update DB

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17522] opac-user.pl gives error of OpacRenewalAllowed is enabled

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17522

--- Comment #6 from Jonathan Druart  
---
Comment on attachment 57048
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57048
Bug 17522 - opac-user.pl gives error of OpacRenewalAllowed is enabled

Review of attachment 57048:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17522=57048)
-

::: Koha/Patron.pm
@@ +467,5 @@
> +=head3 should_block_expired_patron_opac_actions
> +
> +=cut
> +
> +sub should_block_expired_patron_opac_actions {

It sounds to me that this method should actually override
Koha::Patron::Category->BlockExpiredPatronOpacActions, don't you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #52563|0   |1
is obsolete||
  Attachment #52564|0   |1
is obsolete||
  Attachment #52565|0   |1
is obsolete||
  Attachment #52566|0   |1
is obsolete||
  Attachment #52567|0   |1
is obsolete||
  Attachment #52568|0   |1
is obsolete||
  Attachment #52569|0   |1
is obsolete||
  Attachment #52570|0   |1
is obsolete||
  Attachment #52571|0   |1
is obsolete||
  Attachment #52572|0   |1
is obsolete||
  Attachment #52573|0   |1
is obsolete||
  Attachment #52575|0   |1
is obsolete||

--- Comment #96 from Kyle M Hall  ---
Created attachment 57080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57080=edit
Bug 15707 - Update DB

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #35 from Kyle M Hall  ---
In addition, shouldn't the notforloan field be a pulldown based on the
authorised value, rather than a free text field?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15503] Grab Item Information from Order Files

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15503

--- Comment #34 from Kyle M Hall  ---
I think I may have discovered an issue that will need resolution. Consider
this:
* Most sites have a default setting for notforloan of -1 ( ordered ) in the ACQ
framework
* This patch allows the notforloan setting to be defined in the MARC order
record per-item
* However, if the notforloan value is *not* passed in the text field is not
populated
* Saving the records/items to the basket causes an empty string to be passed as
the value
* Since the value for notforloan is not undefined, the default value for the
field ( as set in the ACQ framework ) is not used
* Due to this, the items added are listed as available for loan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Depends on|15498   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498
[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498

Josef Moravec  changed:

   What|Removed |Added

 Blocks|8612|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612
[Bug 8612] CSV export profile to have custom fields in export csv basket
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598

--- Comment #132 from Fridolin SOMERS  ---
(In reply to Marcel de Rooy from comment #130)
> Passed QA

Thanks a lot for your job, I'have not find the time to work en this but I will
have a close look at it when upgrading our machines.

Best regards,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #47 from Josef Moravec  ---
(In reply to Katrin Fischer from comment #45)
> 
> I'd really like a way to indicate what the CSV profile is to be used for. I
> am hesitating to pass this as is, as I think it will be harder to do this
> later on. Once the libraries have added profiles for both, there will be no
> way to assign them automatically to the correct module. If we do it now, we
> can safely assume that all SQL profiles are used for exporting late issues.
> Hope that makes sense?

It absolutely makes sense, I agree with you. I've submitted follow-up, to you
think I'm on right way, or should I take another approach to this problem?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612

--- Comment #46 from Josef Moravec  ---
Created attachment 57079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57079=edit
Bug 8612: QA follow-up - distinguish between late issues and basket export csv
profiles

tatus: Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

--- Comment #2 from Jonathan Druart  
---
Created attachment 57078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57078=edit
Bug 17540: (Bug 7216 followup) Fix tests for auth_values_input_www.t

This is caused by bug 17216 which modified the structure of the AV admin
page

Test plan:
  prove t/db_dependent/www/auth_values_input_www.t
should return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17540


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540
[Bug 17540] auth_values_input_www.t is broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17540] auth_values_input_www.t is broken

2016-11-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17540

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||17216

--- Comment #1 from Jonathan Druart  
---
This is caused by bug 17216 which modified the structure of the AV admin page


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216
[Bug 17216] Add a new table to store authorized value categories
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 154 matches

Mail list logo