[Koha-bugs] [Bug 17579] Add the Koha::Patron->is_expired method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com Attachment #57320|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Josef Moravec changed: What|Removed |Added Attachment #57314|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 57362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57362&action=edit [SIGNED-OFF] Bug 17580: Add the Koha::Patron->get_overdues method This method will be used by several patches later. Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Josef Moravec changed: What|Removed |Added Attachment #57246|0 |1 is obsolete|| --- Comment #5 from Josef Moravec --- Created attachment 57361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57361&action=edit [SIGNED-OFF] Bug 17556: Koha::Patrons - Remove GetHideLostItemsPreference The subroutine C4::Members::GetHideLostItemsPreference can easily be replaced with Koha::Patron->find(42)->category->hidelostitems Test plan: Create 2 patron categories, 1 with "Lost items in staff client" set to "shown" and another one to "Hidden by default" Create 2 patrons using them On the result search page, the detail page of a record, the item list page and the page to place a hold, make sure the lost items are shown/hidden as expected Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17556] Move GetHideLostItemsPreference to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17556 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #77 from Katrin Fischer --- I think I need help to fix the tests. :( My guess right now is that the "from" address, which for claims and orders is the email of the librarian sending it, is somehow generated and not valid - which could break the tests like that: # found carped warning: Bad or missing From address: '' found carped warning: Bad or missing From address: 'SSi32Vsm4u' The tests did run nicely when I was developing this, I haven't been able to locate when and why they broke :( -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Theodoros Theodoropoulos changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] Automatic renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #129 from David Cook --- Also, can someone confirm this line from the Help file: "Important: This feature needs to have the "no renewal before" column filled in or it will auto renew everyday after the due date." It looks to me that it will actually auto-renew before the due date if the "no renewal before" column is null. That's just based on code review though. I haven't tested it. The perldoc in automatic_renewals.pl seems to suggest this though. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] Automatic renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #128 from David Cook --- (In reply to David Cook from comment #127) > Can someone confirm that "No renewal before" is an integer indicating the > number of days after the due date to wait before automatically renewing an > item? > > There's nothing that indicates this in the Help file for the circulation > rules nor in the test plans below. > > It was obvious when I looked at t/db_dependent/Circulation/GetHardDueDate.t, > but perhaps it would be prudent to clarify this somewhere for Koha users. It looks like I completely misunderstood "No renewal before". It looks like it's referred to in https://wiki.koha-community.org/wiki/Automatic_renewal_RFC and https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7413... It looks like this is the key point: "One solution here would be to allow renewals only x days before the book is due." So it's really "No renewal allowed until X units before due date" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] Automatic renewals
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #127 from David Cook --- Can someone confirm that "No renewal before" is an integer indicating the number of days after the due date to wait before automatically renewing an item? There's nothing that indicates this in the Help file for the circulation rules nor in the test plans below. It was obvious when I looked at t/db_dependent/Circulation/GetHardDueDate.t, but perhaps it would be prudent to clarify this somewhere for Koha users. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #14 from Josef Moravec --- Endpoint does work as expected, but the test checkoutshistory.t is broken and also koha-qa says: FAIL Koha/REST/V1/Checkout.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL spelling perfomance ==> performance -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17006] REST API: add route to change patron's password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006
--- Comment #24 from Josef Moravec ---
Created attachment 57360
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57360&action=edit
[SIGNED-OFF] Bug 17006: (follow-up) Use Koha::Exceptions for change password
endpoint
Koha::Exceptions are a nice way to handle erros and they should be used much
more than they are now. This patch adds Koha::Exceptions into
Koha::Patron->change_password_to sub and catches the exceptions in the
controller.
1. Apply patch
2. Run t/db_dependent/api/v1/patrons.t
3. Send PATCH request to http://library/api/v1/patrons/YYY/password
where YYY is existing borrowernumber (borrowers flag required)
4. Make sure that password was changed.
5. Try also too short password, and wrong current password and observe
that errors are displayed appropriately.
curl -X PATCH http://library/api/v1/patrons/123/password \
--data '{"current_password":"123", "new_password":"1234"}' \
--cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10'
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17006] REST API: add route to change patron's password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #22 from Josef Moravec --- Created attachment 57358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57358&action=edit [SIGNED-OFF] Bug 17006: (follow-up) Test for changing another user's password The previous patches work for changing your own password, but the tests are lacking a case where librarian attempts to change patron's password. This feature was unnoticed and not implemented. To test: 1. Run t/db_dependent/api/v1/patrons.t 2. Observe failing test 3. Proceed to next patch to fix the failing test Signed-off-by: Josef Moravec -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17006] REST API: add route to change patron's password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006
--- Comment #23 from Josef Moravec ---
Created attachment 57359
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57359&action=edit
[SIGNED-OFF] Bug 17006: (follow-up) Let librarians change patron's passwords
This should obviously be part of this feature but was left unnoticed in the
first patch. If user has "borrowers"-flag, they should be able to change
patron's
password without providing old password.
To test:
1. Run t/db_dependent/api/v1/patrons.t
2. Observe failing test
3. Apply patch
4. Run t/db_dependent/api/v1/patrons.t
5. Observe passing test
6. Send PATCH request to http://library/api/v1/patrons/YYY/password
where YYY is existing borrowernumber (borrowers flag required)
and where YYY is not the same borrowernumber as your logged-in
user's borrowernumber
7. Make sure that password was changed for YYY.
You may find this useful for testing:
curl -X PATCH http://library/api/v1/patrons/123/password \
--data '{"new_password":"1234"}' \
--cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10'
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17006] REST API: add route to change patron's password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 --- Comment #21 from Josef Moravec --- Created attachment 57357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57357&action=edit [SIGNED-OFF] Bug 17006: Respect system preference "OpacPasswordChange" Allow patron to change their own password without borrowers-flag only if OpacPasswordChange system preference is enabled. To test: 1. Apply patch 2. Run t/db_dependent/api/v1/patrons.t 3. Set OpacPasswordChange system preference to "Don't allow". 4. Send PATCH request to http://library/api/v1/patrons/YYY/password where YYY is existing borrowernumber for a borrower that does not have any permissions 5. Observe permission error. 6. Set OpacPasswordChange system preference to "Allow". 7. Repeat step 4 and make sure that password was changed. Signed-off-by: Aleisha Amohia Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17006] REST API: add route to change patron's password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17006] REST API: add route to change patron's password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17006
Josef Moravec changed:
What|Removed |Added
Attachment #56283|0 |1
is obsolete||
Attachment #56284|0 |1
is obsolete||
Attachment #56399|0 |1
is obsolete||
Attachment #56400|0 |1
is obsolete||
Attachment #56409|0 |1
is obsolete||
--- Comment #20 from Josef Moravec ---
Created attachment 57356
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57356&action=edit
[SIGNED-OFF] Bug 17006: Add API route for changing patron's password
PATCH /patrons/{borrowernumber}/password (change password)
Required body params:
- current_password
- new_password
To test:
1. Apply patch
2. Run t/db_dependent/api/v1/patrons.t
3. Send PATCH request to http://library/api/v1/patrons/YYY/password
where YYY is existing borrowernumber (borrowers flag required)
4. Make sure that password was changed.
5. Try also too short password, and wrong current password and observe
that errors are displayed appropriately.
You may find this useful for testing:
curl -X PATCH http://library/api/v1/patrons/123/password
--data '{"current_password":"123456", "new_password":"1234"}'
--cookie 'CGISESSID=055ca5a9a3ad3fb5052143bd015c1c10'
Signed-off-by: Aleisha Amohia
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008 --- Comment #23 from Josef Moravec --- Created attachment 57355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57355&action=edit Bug 17008: followup - fix cityid type -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008 --- Comment #22 from Josef Moravec --- Created attachment 57354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57354&action=edit [SIGNED-OFF] Bug 17008: Test to compare Swagger property types against column data types This patch adds a test that iterates through each definition-object in Swagger and compares their properties' data types to corresponding Koha-object's column's data type by using Koha::Util::Swagger::column_type_to_swagger_type(). This test will also check if the column is nullable and will complain unless property has also "null" defined in its type. To test: 1. Run t/db_dependent/api/v1/swagger/definitions.t 2. Observe that tests pass (if not, open a Bug to fix issues) 3. Modify api/v1/swagger/definitions/patron.json cardnumber to be type "integer". 4. Run the test again. 5. Observe that test fails and will complain about incorrect data type. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008 --- Comment #21 from Josef Moravec --- Created attachment 57353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57353&action=edit [SIGNED-OFF] Bug 17008: Fix current data types This patch changes current Swagger definitions for patrons and holds to have data types corresponding to column data types in their database tables. To test: 1. GET http://yourlibrary/api/v1/patrons/YYY where YYY is existing borrowernumber 2. Observe that numbers / integers are in string data type. 3. Apply this patch 4. Repeat step 1. 5. Observe that numbers / integers are now actually numbers / integers. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17008] REST API: Correct data types in Swagger
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17008
Josef Moravec changed:
What|Removed |Added
Attachment #56279|0 |1
is obsolete||
Attachment #56280|0 |1
is obsolete||
Attachment #56281|0 |1
is obsolete||
--- Comment #20 from Josef Moravec ---
Created attachment 57352
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57352&action=edit
[SIGNED-OFF] Bug 17008: Add "swaggerize" for Koha::Object and Koha::Objects
This patch adds new subroutine "swaggerize" for Koha::Object and Koha::Objects.
By matching column data types with corresponding Swagger data type, we can e.g.
numify values in order to be able to return borrowernumber:123 instead of
borrowernumber:"123".
Before this patch, we usually returned an unblessed representation of the
Koha-object in controller by calling e.g.
$c->$cb($patron->unblessed, 200);
This would cause the returned JSON to have { "borrowernumber": "123" ... }, or
in other words everything as strings (apart from undefs, which would be null).
Now, we also return an unblessed representation of the Koha-object, but where
numbers are actually numified simply by calling e.g.
$c->$cb($patron->swaggerize, 200);
Here our returned JSON will have { "borrowernumber": 123 ... } in "integer"
data
type of Swagger, as well as every other column that is defined to be an
integer.
Decimals, doubles and floats should have "number" data type and will also be
numified for the returned JSON.
To test:
1. Apply this patch and run t/db_dependent/Koha/Util/Swagger.t
2. Apply REST of the patches and follow their test plan for seeing how this
works in practice
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17086] REST API: Reword borrowers to patrons in Swagger tags for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17086 Josef Moravec changed: What|Removed |Added Severity|enhancement |trivial CC||josef.mora...@gmail.com --- Comment #3 from Josef Moravec --- rebased on bug 16699 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17086] REST API: Reword borrowers to patrons in Swagger tags for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17086 Josef Moravec changed: What|Removed |Added Attachment #54197|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 57351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57351&action=edit [SIGNED-OFF] Bug 17086: Reword borrowers to patrons in Swagger tags for holds Routes for holds have tags called "borrowers". We should use "patrons" instead in order not to have both (endpoints for patrons already add "patrons"). This patch changes the tags from borrowers to patrons in: GET /holds POST /holds Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17086] REST API: Reword borrowers to patrons in Swagger tags for holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17086 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16497] REST API: add routes to list libraries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15165] REST API routes to list, edit and pay borrower's accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15165 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||josef.mora...@gmail.com --- Comment #29 from Josef Moravec --- Getting accountlines by borrowernumber is impossible, as t/db_dependent/api/v1/accountlines.t also shows... It is related to bug 17445 We should add borrowernumber to swagger definition of allowed parameters I think... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17543] Update German web installer sample files for 16.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17543 --- Comment #3 from Katrin Fischer --- Thx Bernardo! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Theodorus, if it works for you on master, please sign off! The QA team will take over from there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14974] Use the REST API for cities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 --- Comment #16 from Martin Renvoize --- Is Kyle planning to submit his ReactJS alternative to here or is that going elsewhere? I'm looking forward to seeing the alternative in code :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14974] Use the REST API for cities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 Josef Moravec changed: What|Removed |Added Depends on||17428 CC||josef.mora...@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 [Bug 17428] REST API: CRUD endpoint for cities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17428] REST API: CRUD endpoint for cities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428 Josef Moravec changed: What|Removed |Added Blocks||14974 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974 [Bug 14974] Use the REST API for cities -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17591] Use fully qualified C4::Items function names in C4:: Circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 Josef Moravec changed: What|Removed |Added Attachment #57344|0 |1 is obsolete|| --- Comment #2 from Josef Moravec --- Created attachment 57350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57350&action=edit [SIGNED-OFF] Bug 17591: Use fully qualified C4::Items function names in C4::Circulation To test: - Run: $ prove prove t/db_dependent/Members/IssueSlip.t => FAIL: C4::Circulation is not being able to find the GetItem function. - Apply the patch - Run: $ prove prove t/db_dependent/Members/IssueSlip.t => SUCCESS: All green - Sign off :-D Sponsored-by: ByWater Solutions Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17591] Use fully qualified C4::Items function names in C4:: Circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17592] Remove itemtype-related maxsuspensiondays.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17592 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 57349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57349&action=edit Bug 17592: Remove itemtype-related maxsuspensiondays.t warnings This patch makes t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17592] Remove itemtype-related maxsuspensiondays.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17592 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17592] New: Remove itemtype-related maxsuspensiondays.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17592 Bug ID: 17592 Summary: Remove itemtype-related maxsuspensiondays.t warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: tomasco...@gmail.com QA Contact: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17564] Acquisition/OrderUsers.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17564 Tomás Cohen Arazi changed: What|Removed |Added Attachment #57255|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 57348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57348&action=edit Bug 17564: Fix t/db_dependent/Acquisition/OrderUsers.t ModReceiveOrder takes now a 'order' parameter and is mandatory. This new test file has been added after the first submission of bug 13321 and has not been updated during the rebases. Test plan: prove t/db_dependent/Acquisition/OrderUsers.t should return green Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17564] Acquisition/OrderUsers.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17564 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17563] Acquisition/CancelReceipt.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17563 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17563] Acquisition/CancelReceipt.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17563 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 57347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57347&action=edit Bug 17563: (followup) Silence undef warnings Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17563] Acquisition/CancelReceipt.t is broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17563 Tomás Cohen Arazi changed: What|Removed |Added Attachment #57254|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 57346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57346&action=edit Bug 17563: Fix Acquisition/CancelReceipt.t Test plan: prove t/db_dependent/Acquisition/CancelReceipt.t should return green Confirm that the changes made by commit 20d9ed618fbe3cdcb9c0a1f8a584b0364069 Bug 13321: Rename variables was wrong for the budget_id var and that this patch reverts it Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17543] Update German web installer sample files for 16.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17543 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #57291|0 |1 is obsolete|| --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 57345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57345&action=edit [SIGNED-OFF] Bug 17543: Update German web installer sample files for 16.11 Updates sample files with German translations: - Authorised value HSBND_FREQ - Sample notices for article requests To test: - Make sure the German web installer installs all sample files correctly. - Bonus: check German translations. Signed-off-by: Bernardo Gonzalez Kriegel Tested german installer/translation No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17543] Update German web installer sample files for 16.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17543 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17591] Use fully qualified C4::Items function names in C4:: Circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17591] Use fully qualified C4::Items function names in C4:: Circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 57344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57344&action=edit Bug 17591: Use fully qualified C4::Items function names in C4::Circulation To test: - Run: $ prove prove t/db_dependent/Members/IssueSlip.t => FAIL: C4::Circulation is not being able to find the GetItem function. - Apply the patch - Run: $ prove prove t/db_dependent/Members/IssueSlip.t => SUCCESS: All green - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17591] Use fully qualified C4::Items function names in C4:: Circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |tomasco...@gmail.com CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17591] New: Use fully qualified C4::Items function names in C4:: Circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17591 Bug ID: 17591 Summary: Use fully qualified C4::Items function names in C4::Circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11463] GetItem must use item-level_itypes syspref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11463 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- This is already fixed, now that GetItem calls Koha::Items->find()->effective_itemtype -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17004] REST API: add route to authenticate patron ( Single Sign On - SSO)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17004 --- Comment #22 from Benjamin Rokseth --- (In reply to Martin Renvoize from comment #21) > I don't like this much.. We're in-explicitly mixing Authentication (Are you > who you say you are) and Authorization (What can this person/application on > behalf of person do) > I believe the main point here is authenticating a service outside koha against its userbase and services, although of course Koha intra and opac should profit from this. > At the very least I believe these functions should be made distinct to > prevent leaking security context. > No problem with that, as long as authorization is handled one place only. > The second reason I don't like this is that we're inventing out own wheel. > There are lots of solid standards out there to do this sort of thing. We > should really be leaning on the shoulders of giants and using an off the > shelf standard. OAuth and OpenID connect would be my preferred option > personally. Now this could be debated, openID and oAuth are easy to integrate against and are well formed standards, and would of course lower the barrier to use koha services outside the library without handling login in koha. But to be sure, local login needs to be handled anyways, and to use our library as an example, having a local patron base is a strength rather than a weekness. Being a user of the library implies a presence and represents a place outside the web, and I'm not sure SSO with oauth gives the same sensation. Just my two cent thoughts :) Now to rebase this against master... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17204] Rancor Z39.50 search fails under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17204 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17204] Rancor Z39.50 search fails under plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17204 Tomás Cohen Arazi changed: What|Removed |Added Attachment #56184|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 57343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57343&action=edit Bug 17204: Rancor Z39.50 search fails under plack MetaSearcher.pm forks children to handle searching each server. When the process waits for the children it never continues. The simplest solution here is to exclude the metasearcher service from running under plack Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17590] Exporting reports as CSV with 'delimiter' SysPref set to ' tabulation' creates files with 't' as separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17590 --- Comment #1 from Nick Clemens --- Created attachment 57342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57342&action=edit Bug 17590 - Exporting reports as CSV with 'delimiter' SysPref set to 'tabulation' creates files with 't' as separator To test: Set 'delimiter' system preference to 'tabs' Export a report as csv Open the file in text editor and note fields separated by character 't' Apply patch Export report as CSV Open file in text editor and note tabs are used to separate fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17590] Exporting reports as CSV with 'delimiter' SysPref set to ' tabulation' creates files with 't' as separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17590 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17590] New: Exporting reports as CSV with 'delimiter' SysPref set to 'tabulation' creates files with 't' as separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17590 Bug ID: 17590 Summary: Exporting reports as CSV with 'delimiter' SysPref set to 'tabulation' creates files with 't' as separator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcha...@gmail.com Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org We need to translate 'tabulation' to "\t" before creating our file with Text::CSV -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17590] Exporting reports as CSV with 'delimiter' SysPref set to ' tabulation' creates files with 't' as separator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17590 Nick Clemens changed: What|Removed |Added Severity|enhancement |normal Patch complexity|--- |Trivial patch Assignee|gmcha...@gmail.com |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17589] Improper method type in Koha::ItemType(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17589 Kyle M Hall changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #2 from Kyle M Hall --- Pushed to master for 16.11, simple fix with Jonathan's blessing ; ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17589] Improper method type in Koha::ItemType(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17589 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17589] Improper method type in Koha::ItemType(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17589 --- Comment #1 from Kyle M Hall --- Created attachment 57341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57341&action=edit Bug 17589 - Improper method type in Koha::ItemType(s) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17589] Improper method type in Koha::ItemType(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17589 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17589] Improper method type in Koha::ItemType(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17589 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17589] New: Improper method type in Koha::ItemType(s)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17589 Bug ID: 17589 Summary: Improper method type in Koha::ItemType(s) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org It looks like some merge cruft ended up in master, as the type() method was renamed to _type() to not conflict with columns of the same name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17582] Cannot edit an authority framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17582 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17582] Cannot edit an authority framework
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17582 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #57328|0 |1 is obsolete|| --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 57340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57340&action=edit [SIGNED-OFF] Bug 17582: Fix authority framework edition Step to recreate: Admin>Authority types > Actions > Marc structure Test plan Confirm that this patch fixes the issue Signed-off-by: Bernardo Gonzalez Kriegel Fix the issue, no errors. Can edit auth marc structure -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 --- Comment #17 from Jonathan Druart --- Bug 17553 - Move GetOverduesForPatron to Koha::Patron Bug 17554 - Move GetBorrowersWithEmail to Koha::Patron Bug 17556 - Move GetHideLostItemsPreference to Koha::Patron Bug 17557 - Move GetAge to Koha::Patron->get_age (and remove SetAge) Bug 17569 - Move GetUpcomingMembershipExpires to Koha::Patrons Bug 17578 - Replace GetMemberDetails with GetMember Bug 17588 - Move GetMemberIssuesAndFines to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Bug 14598 depends on bug 16216, which changed state. Bug 16216 Summary: Circulation_Branch.t doesn't set itemtype for test data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16216] Circulation_Branch.t doesn't set itemtype for test data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16216 Tomás Cohen Arazi changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #1 from Jonathan Druart --- Created attachment 57339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57339&action=edit Bug 17588: Koha::Patrons - Move GetMemberIssuesAndFines The GetMemberIssuesAndFines subroutine used to retrieve the issues, overdues and fines for a given patron. Most of the time, only 1 or 2 of these values were used. This patch removes this subroutine and uses the new get_issues, get_overdues and get_balance method from Koha::Patron and Koha::Account::Lines. Test plan: 1/ Add overdues, issues and fines to different patrons 2/ On the checkout, checkin and patron search result and the patron detail pages, these 3 informations, if displayed before this patch, must be correctly displayed. 3/ Use the batch patron deletion tool and make sure that patrons with a balance > 0 are not deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Jonathan Druart changed: What|Removed |Added Blocks||17588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Jonathan Druart changed: What|Removed |Added Depends on||17584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 [Bug 17584] Add the Koha::Patron->get_issues method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17578] Replace GetMemberDetails with GetMember
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 Jonathan Druart changed: What|Removed |Added Blocks||17588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Jonathan Druart changed: What|Removed |Added Blocks||17588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16846] Move patron related code to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 Jonathan Druart changed: What|Removed |Added Depends on||17588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17588] Move GetMemberIssuesAndFines to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Jonathan Druart changed: What|Removed |Added Blocks||16846 Depends on||17578, 17586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 [Bug 17578] Replace GetMemberDetails with GetMember https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 [Bug 17586] Add the Koha::Account::Lines->get_balance method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17588] New: Move GetMemberIssuesAndFines to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Bug ID: 17588 Summary: Move GetMemberIssuesAndFines to Koha::Patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Jonathan Druart changed: What|Removed |Added Attachment #57337|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 57338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57338&action=edit Bug 17586: Add the Koha::Account::Lines->get_balance method Test plan: prove t/db_dependent/Accounts.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Jonathan Druart changed: What|Removed |Added Depends on||17585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 [Bug 17585] Add the Koha::Patron->get_account_lines method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 --- Comment #1 from Jonathan Druart --- Created attachment 57337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57337&action=edit Bug 17596: Add the Koha::Account::Lines->get_balance method Test plan: prove t/db_dependent/Accounts.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Jonathan Druart changed: What|Removed |Added Blocks||17586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 [Bug 17586] Add the Koha::Account::Lines->get_balance method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17586] Add the Koha::Account::Lines->get_balance method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Jonathan Druart changed: What|Removed |Added Attachment #57335|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 57336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57336&action=edit Bug 17585: Add the Koha::Patron->get_account_lines method Test plan: prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart changed: What|Removed |Added Blocks||17585 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 [Bug 17585] Add the Koha::Patron->get_account_lines method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 --- Comment #1 from Jonathan Druart --- Created attachment 57335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57335&action=edit Bug 17585: Add the Koha::Patron->get_account_lines method Test plan: prove t/db_dependent/Koha/Patrons.t should return green -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Jonathan Druart changed: What|Removed |Added Depends on||17583 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 [Bug 17583] Use Koha::Patron->is_expired from circulation.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17585] Add the Koha::Patron->get_account_lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17583] Use Koha::Patron->is_expired from circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17583 Jonathan Druart changed: What|Removed |Added Attachment #57330|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 57334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57334&action=edit Bug 17583: Add the Koha::Patron->is_going_to_expired method In order to be consistent, we need to create this method as well. Test plan: Make sure the pref NotifyBorrowerDeparture works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17587] Remove itemtype-related IsItemIssued.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17587 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17587] Remove itemtype-related IsItemIssued.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17587 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 57333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57333&action=edit Bug 17587: Remove itemtype-related IsItemIssued.t warnings This patch makes t/db_dependent/Circulation/IsItemIssued.t create good sample data for its tests. It does so by creating a random itemtype. To test: - Run $ prove t/db_dependent/Circulation/IsItemIssued.t => FAIL: lots of warnings about "item-level_itypes set but no itemtype set for item" - Apply the patch - Run: $ prove t/db_dependent/Circulation/IsItemIssued.t => SUCCESS: Tests are green, and no warnings. - Sign off :-D Sponsored-by: ByWater Solutions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17579] Add the Koha::Patron->is_expired method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 Jonathan Druart changed: What|Removed |Added Depends on||17580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 [Bug 17580] Add the Koha::Patron->get_overdues method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17580] Add the Koha::Patron->get_overdues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17580 Jonathan Druart changed: What|Removed |Added Blocks||17579 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 [Bug 17579] Add the Koha::Patron->is_expired method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17579] Add the Koha::Patron->is_expired method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17579 --- Comment #3 from Jonathan Druart --- Created attachment 57332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57332&action=edit Bug 17579: Add the Koha::Patron->is_expired This new method will be handy for further uses Test plan: prove t/db_dependent/Koha/Patrons.t should return green Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation:: AddReturn
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi changed: What|Removed |Added Blocks||17587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17587 [Bug 17587] Remove itemtype-related IsItemIssued.t warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17587] Remove itemtype-related IsItemIssued.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17587 Tomás Cohen Arazi changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com Depends on||14598 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17587] New: Remove itemtype-related IsItemIssued.t warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17587 Bug ID: 17587 Summary: Remove itemtype-related IsItemIssued.t warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: tomasco...@gmail.com QA Contact: gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17470] overdue_notices.pl produces X emails with the SAME list of ALL overdue items if a patron has overdue items from X branches
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17470 --- Comment #2 from Theodoros Theodoropoulos --- Thank you Olivier for the patch! I can verify that the patch works as expected for 3.20 and master. Having said that, I leave it as 'Needs Signoff'. Maybe @Kyle or someone from QA team could/should sign it off? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17586] New: Add the Koha::Account::Lines->get_balance method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 Bug ID: 17586 Summary: Add the Koha::Account::Lines->get_balance method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17585] New: Add the Koha::Patron->get_account_lines method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17585 Bug ID: 17585 Summary: Add the Koha::Patron->get_account_lines method Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #76 from Katrin Fischer --- Ok, I will try... :( -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17584] Add the Koha::Patron->get_issues method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
