[Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not always work in staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673

--- Comment #5 from Marcel de Rooy  ---
Note from the author :)
Still arguable, because the other link on staff detail at Online resources will
still not work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9163] Cataloguing validation workflow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9163

Fridolin SOMERS  changed:

   What|Removed |Added

   Assignee|fridolin.som...@biblibre.co |alex.arn...@biblibre.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not always work in staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #57732|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 57733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57733=edit
Bug 17673: HTML5Media: Using an OPAC URL for an uploaded file does not always
work in staff

If you did not fill OPACBaseURL, the media URL for an uploaded file will
work in OPAC, but not in staff.
You can solve that by filling OPACBaseURL correctly.
We could also add a simple replace in C4/HTML5Media.pm.

Test plan:
[1] Add an upload (say .webm file) via 856$u in editor.
Put 'video/webm' into 856$q.
[2] Check media tab in opac and staff detail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6271] GetItemIssue(s) : renewals in both items and issues tables

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6271

--- Comment #11 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #10)
> Would you agree to remove it?
Yep

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not always work in staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673

--- Comment #3 from Marcel de Rooy  ---
The patches for 17501 are coming. This patch is built on top of those.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17501] Koha Objects for uploaded files

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||17673


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673
[Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not always
work in staff
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not always work in staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||17501
   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17501
[Bug 17501] Koha Objects for uploaded files
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not always work in staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673

--- Comment #2 from Marcel de Rooy  ---
Created attachment 57732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57732=edit
Bug 17673: HTML5Media: Using an OPAC URL for an uploaded file does not always
work in staff

If you did no fill OPACBaseURL, the media URL for an uploaded file will
work in OPAC, but not in staff.
You can solve that by filling OPACBaseURL correctly.
We could also add a simple replace in C4/HTML5Media.pm.

Test plan:
[1] Add an upload (say .webm file) via 856$u in editor.
[2] Check media tab in opac and staff detail.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not always work in staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17395] exporting checkouts in CSV generates a file with wrong extension

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17395

--- Comment #12 from Fridolin SOMERS  ---
(In reply to Jonathan Druart from comment #11)
> As I said previously, this has to be done in javascript to fill the "File
> name" input depending on the format the user picked.
Mmmm this is a point of view I think.
Fixing in perl is safer in my opinion, it fixes for all calls.

> to fill the "File name" input
There is actually no such input, create an hidden one you mean ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not always work in staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673

Marcel de Rooy  changed:

   What|Removed |Added

Summary|HTML5Media: Using an OPAC   |HTML5Media: Using an OPAC
   |URL for an uploaded file|URL for an uploaded file
   |does not work in staff  |does not always work in
   ||staff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9842] SIP tests : fix for 07hold.t on Cancel Hold

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9842

Christophe Croullebois  changed:

   What|Removed |Added

 CC||christophe.croullebois@bibl
   ||ibre.com
   Assignee|adrien.sau...@biblibre.com  |christophe.croullebois@bibl
   ||ibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14980] Add a page showing one news

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #17 from Fridolin SOMERS  ---
This is just a POC, needs more work

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17675] Broken links to Koha documentation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17675

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz
 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Liz Rea  ---
The affected links have been updated to working links, however the endpoints
might still change in the future with the new documentation manager/sphinx
setup.

Thank you very much for reporting this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17675] New: Broken links to Koha documentation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17675

Bug ID: 17675
   Summary: Broken links to Koha documentation
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Websites, Mailing Lists, etc
  Assignee: wizzy...@gmail.com
  Reporter: m...@adminkuhn.ch
QA Contact: testo...@bugs.koha-community.org

Many of the links shown under https://koha-community.org/documentation/ are
broken as of November 23, because they point to the following kind of paths:

http://translate.koha-community.org/manual/xx.xx/en/html-desktop/

http://translate.koha-community.org/manual/xx.xx/en/pdf/Koha-xx.xx-koha-manual-en.pdf

Someone with the needed privileges should fix this.

I wish links on any official websites would be permanent.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #101 from Mirko Tietgen  ---
Did an install with the latest patch added, got

Update errors :

[Thu Nov 24 00:06:08 2016] updatedatabase.pl: DBD::mysql::db do failed:
Duplicate column name 'updated_on' [for Statement "
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ALTER TABLE borrowers
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ADD COLUMN updated_on
timestamp NULL DEFAULT CURRENT_TIMESTAMP
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ON UPDATE CURRENT_TIMESTAMP
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: AFTER
privacy_guarantor_checkouts;
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: "] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
12626.
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: DBD::mysql::db do failed:
Duplicate column name 'updated_on' [for Statement "
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ALTER TABLE deletedborrowers
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ADD COLUMN updated_on
timestamp NULL DEFAULT CURRENT_TIMESTAMP
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: ON UPDATE CURRENT_TIMESTAMP
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: AFTER
privacy_guarantor_checkouts;
[Thu Nov 24 00:06:08 2016] updatedatabase.pl: "] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
12632.
[Thu Nov 24 00:06:15 2016] updatedatabase.pl: DBD::mysql::db do failed:
Can't create table 'koha_koha.#sql-2221_18d' (errno: 150) [for Statement "
[Thu Nov 24 00:06:15 2016] updatedatabase.pl: ALTER TABLE
marc_subfield_structure
[Thu Nov 24 00:06:15 2016] updatedatabase.pl: MODIFY COLUMN
authorised_value VARCHAR(32) DEFAULT NULL,
[Thu Nov 24 00:06:15 2016] updatedatabase.pl: ADD CONSTRAINT
marc_subfield_structure_ibfk_1 FOREIGN KEY (authorised_value) REFERENCES
authorised_value_categories (category_name) ON UPDATE CASCADE ON DELETE SET
NULL;
[Thu Nov 24 00:06:15 2016] updatedatabase.pl: "] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
13175.


@Jacek: that is what you are talking about, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15339] TestBuilder build parameter warnings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #100 from Jacek Ablewicz  ---
Huh, this is what happens (mysql 5.5.49): for a table with no default collation
defined on table level (like marc_subfield_structure)

   MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL

does not preserve existing collation for that field (which was, after all,
utf8_unicode_ci in my test DB before attempting that upgrade: manually set up
to utf8_unicode_ci for a bunch of marc_subfield_structure fields in DB update
from Bug 11944), and it subsequently fails with error 150 on adding FK
constraint because of collations inconsistency (I think.. not quite sure, but a
solution from comment #96 fixes this problem).

It's reproductible; note that I have different default collation defined mysql
server-side on that box (utf8_general_ci) - if it was utf8_unicode_ci
server-side, I guess there is a possibility this issue does not manifest itself
(?).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8067] HTML blocks in sysprefs should be definable for multiple languages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8067

M. Tompsett  changed:

   What|Removed |Added

 CC||eugen...@yahoo.com,
   ||indr...@l2c2.co.in,
   ||jkpatti...@gmail.com,
   ||manueltama...@gmail.com,
   ||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett  ---
Forgive me for adding you, if you didn't want to be added, folks. Just thought
this notion of multilingal system preferences might be a good idea.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

--- Comment #98 from Jacek Ablewicz  ---
(In reply to Katrin Fischer from comment #97)
> >Got the same error in my test setup. For undetermined reason, 
> >authorised_value >field in marc_subfield_structure table did not have 
> >utf8_unicode_ci collation.
> 
> That's intentional. ci = case insensitive breaks uppercase subfield codes
> which are often used to create additional fields in 952.

marc_subfield_structure.tagsubfield indeed has utf8_bin collation, but should
the same rule apply for authorised_value? By default (in fresh installs),
marc_subfield_structure.authorised_value has utf8_unicode_ci collation, for
some reasons (I still have no idea why, maybe update from Bug 11944 partially
failed) in my old test DB, this field has no collation defined, and that's why
adding FK failed for me with error 150.

But it can be failing for different reason[s] for other people - and probably
is, this collation issue seems to be some kind of problem which was specific to
this particular DB.

There is one other table (overduerules) in that DB which does not have
utf8_unicode_ci collation set by default for all text fields, but it looks more
like an omission in updatedatabase (Bug 13624, DB version: 3.23.00.007).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #99 from Jacek Ablewicz  ---
(In reply to Jacek Ablewicz from comment #96)

> No idea why this DB update is tagged 
> with "Bug 17357 - WTHDRAWN is still used in installer files)" and not with a
> "Bug 17216 ..." instead.

Uhm, scratch that; in fact it is tagged correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Blou  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #3 from Blou  ---
A test file for the changes in C4/Serials.pm will follow.

This enhancement was clamored for on the Koha (French) list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

--- Comment #2 from Blou  ---
Created attachment 57731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57731=edit
Bug 17674 - Allow UI to delete serials in batch

This new feature allows for batch deletion of serials through the UI.  The
current usage is a one-by-one long game.

Testing
- Have at least three serials, with items
- check the box to select two of them
- Press the Remove selected issues button
- Decide to delete their items as well or not
- Validate.

Sponsored by : CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] Allow UI to delete serials in batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Blou  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
   Assignee|koha-b...@lists.koha-commun |philippe.blo...@inlibro.com
   |ity.org |
 CC||bouzid.ferg...@inlibro.com,
   ||francois.charbonnier@inlibr
   ||o.com,
   ||marjorie.barry-v...@ccsr.qc
   ||.ca,
   ||philippe.blo...@inlibro.com
  Change sponsored?|--- |Sponsored

--- Comment #1 from Blou  ---
Sponsored by : CCSR

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17674] New: Allow UI to delete serials in batch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674

Bug ID: 17674
   Summary: Allow UI to delete serials in batch
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: philippe.blo...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

This new feature allows for batch deletion of serials through the UI.  The
current usage is a one-by-one long game.

Testing
- Have at least three serials, with items
- check the box to select two of them
- Press the Remove selected issues button
- Decide to delete their items as well or not
- Validate.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15339] TestBuilder build parameter warnings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15339

Chris Cormack  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|xarra...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #97 from Katrin Fischer  ---
>Got the same error in my test setup. For undetermined reason, authorised_value 
>>field in marc_subfield_structure table did not have utf8_unicode_ci collation.

That's intentional. ci = case insensitive breaks uppercase subfield codes which
are often used to create additional fields in 952.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7039] Link to existing record from result list in acquisition search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7039

Katrin Fischer  changed:

   What|Removed |Added

  Text to go in the|When creating orders from   |When creating orders from
  release notes|existing records in |existing records in
   |acquisiton, the result list |acquisiton, the result list
   |should link to the existing |now links to the existing
   |records, so that it's   |records, so that it's
   |possible to check for   |possible to check for
   |existing items. |existing items.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not work in staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673

--- Comment #1 from Marcel de Rooy  ---
Or use OPACBaseURL in all cases?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17673] HTML5Media: Using an OPAC URL for an uploaded file does not work in staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673

Marcel de Rooy  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17673] New: HTML5Media: Using an OPAC URL for an uploaded file does not work in staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17673

Bug ID: 17673
   Summary: HTML5Media: Using an OPAC URL for an uploaded file
does not work in staff
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Currently, playing an uploaded file in the Media tab will not work. The URL is
invalid.

The URLs should be:

OPAC /cgi-bin/koha/opac-retrieve-file.pl?id=bce868a0f5521e9329ccbc73414b4927
STAFF
/cgi-bin/koha/opac/opac-retrieve-file.pl?id=bce868a0f5521e9329ccbc73414b4927

Note that the URL used in staff is the OPAC one from 856$u.
In this case "opac-retrieve-file" should be prefixed with "opac/".

Alternatively, the staff upload URL could be:
/cgi-bin/koha/tools/upload.pl?op=download=316
NOTE: In this case the id is the real id; in opac parameter id is actually used
for the hashvalue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #96 from Jacek Ablewicz  ---
(In reply to Mirko Tietgen from comment #93)
> With a Debian package for 16.11, on upgrade from 16.05 the following happens:
> 
> Upgrade to 16.06.00.032 done (Bug 17357 - WTHDRAWN is still used in
> installer files)
> DBD::mysql::db do failed: Can't create table 'koha_upgrade.#sql-329_a5'
> (errno: 150) [for Statement "
> ALTER TABLE marc_subfield_structure
> MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL,
> ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY
> (authorised_value) REFERENCES authorised_value_categories (category_name) ON
> UPDATE CASCADE ON DELETE SET NULL;
> "] at
> /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
> 13175.
> Upgrade to 16.06.00.033 done (Bug 17216 - Add a new table to store
> authorized value categories)
> 
> I assume it is related to this bug? Is it safe to ignore? It does sound more
> scary than the duplicate warnings we get from time to time.

Got the same error in my test setup. For undetermined reason, authorised_value
field in marc_subfield_structure table did not have utf8_unicode_ci collation.

I replaced

MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL,

with

MODIFY COLUMN authorised_value VARCHAR(32) CHARACTER SET utf8 COLLATE
utf8_unicode_ci DEFAULT NULL,

and after that it seems to work fine. No idea why this DB update is tagged 
with "Bug 17357 - WTHDRAWN is still used in installer files)" and not with a
"Bug 17216 ..." instead.

BTW, there are some other text fields in my test DB with inconsistent collation
too, but this is a database with a long history of accumulated DB updates
(including various unstable / atomic ones).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17670] Grammar mistakes - 'effect' vs. 'affect'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57728|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 57730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57730=edit
Bug 17670: Grammar mistakes - effect vs affect

In two places:

1. Administration -> Preferences -> Circulation ->
   AllowMultipleIssuesOnABiblio: says effect, should say affect
2. Reports -> Lost Items -> Help (top-right corner): says effect, should
   say affect

To test, navigate to these two places and confirm charges have been made
and are correct.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17670] Grammar mistakes - 'effect' vs. 'affect'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17670

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9896] Show vendor in subscription search when creating an order for a subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9896

Zeno Tajoli  changed:

   What|Removed |Added

 CC|z.taj...@cineca.it  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9896] Show vendor in subscription search when creating an order for a subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9896

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the||In the staff client, when
  release notes||creating an order from a
   ||subscription the vendor
   ||name is be shown in a
   ||separate column.
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #95 from Jonathan Druart  
---
Created attachment 57729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57729=edit
Bug 17216: Fix SQL statement to setting
marc_subfield_structure.authorised_value to NULL

We want to update it if it's empty, not equal to ';'
nopaste vim mode is to blame

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7039] Link to existing record from result list in acquisition search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7039

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the||When creating orders from
  release notes||existing records in
   ||acquisiton, the result list
   ||should link to the existing
   ||records, so that it's
   ||possible to check for
   ||existing items.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Zeno Tajoli  changed:

   What|Removed |Added

 CC|z.taj...@cineca.it  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
  Text to go in the||Add ability to place
  release notes||article requests in Koha.
   ||Article Requests are
   ||somewhat similar to holds,
   ||but are not requests for an
   ||item to check out. Instead,
   ||article requests are
   ||requests for a photocopy of
   ||a particular section of a
   ||book ( most often ). This
   ||is very common in academic
   ||libraries where researchers
   ||may request a copy of a
   ||single article found in a
   ||journal.
   ||This patch set
   ||adds the ability to place
   ||article requests in Koha.
   ||It allows the control of
   ||what can be requested via
   ||the circulation rules.
   ||Since article requests of
   ||electronic resources are
   ||not outside the realm of
   ||possibility, the feature
   ||will check not only the
   ||items for requstability,
   ||but the record itself as
   ||well ( i.e. both
   ||items.itype and
   ||biblio.itemtype ).
   ||Article
   ||requests can be placed for
   ||patrons from the opac and
   ||staff intranet and can be
   ||viewed in most areas where
   ||holds are viewed ( e.g.
   ||patron details, record
   ||details, etc ).
   ||There is a
   ||script to view article
   ||requests in progress within
   ||the circulation module.
   ||Article requests can be
   ||Open ( i.e. new ), In
   ||Processing, Completed, or
   ||Canceled. The status of a
   ||given request can be
   ||updated from this script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14793] New cataloguing plugin unimarc_field_225a_bis

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14793

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
  Text to go in the||This plugin is used to fill
  release notes||225$a with a value already
   ||existing in table
   ||biblioitems.collectiontitle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666

--- Comment #9 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #8)
> Jonathan, does it work for you with this patch?

Yes of course it works but in that case it's certainly better to use
File::Slurp::read_file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280

--- Comment #10 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > Ok so, beginning of a release cycle, let's take decisions!
> > 
> > What is the plan of attack for these notices?
> > I think we need to know if 1. everybody agrees with the TT syntax for
> > notices and 2. we have dedicated time in a release cycle to move all of the
> > existing notices to TT syntax.
> > I don't think it's a good idea not to move all of the notices at the same
> > time (ie. during the same release cycle).
> 
> I totally agree with that. I think first we need to start a mailing list
> topic for this which should end with a simple vote of whether to continue to
> use the existing syntax by default or to switch to TT by default and
> eventually deprecate the existing syntax. What do you think?

We already had one :)
http://lists.koha-community.org/pipermail/koha-devel/2016-February/042316.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

--- Comment #94 from Mirko Tietgen  ---
FYI: I'll wait with the package release for 16.11.00 until this is solved. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17216] Add a new table to store authorized value categories

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #93 from Mirko Tietgen  ---
With a Debian package for 16.11, on upgrade from 16.05 the following happens:

Upgrade to 16.06.00.032 done (Bug 17357 - WTHDRAWN is still used in installer
files)
DBD::mysql::db do failed: Can't create table 'koha_upgrade.#sql-329_a5' (errno:
150) [for Statement "
ALTER TABLE marc_subfield_structure
MODIFY COLUMN authorised_value VARCHAR(32) DEFAULT NULL,
ADD CONSTRAINT marc_subfield_structure_ibfk_1 FOREIGN KEY
(authorised_value) REFERENCES authorised_value_categories (category_name) ON
UPDATE CASCADE ON DELETE SET NULL;
"] at
/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line
13175.
Upgrade to 16.06.00.033 done (Bug 17216 - Add a new table to store authorized
value categories)

I assume it is related to this bug? Is it safe to ignore? It does sound more
scary than the duplicate warnings we get from time to time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] New: Items table should have a damaged_on column

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

Bug ID: 17672
   Summary: Items table should have a damaged_on column
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Mirroring the itemlost_on column it would be nice to have the ability to see
when an item was marked damaged so libraries can track repairs and mending.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17670] Grammar mistakes - 'effect' vs. 'affect'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17670

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17670] Grammar mistakes - 'effect' vs. 'affect'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17670

Owen Leonard  changed:

   What|Removed |Added

  Attachment #57718|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 57728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57728=edit
[SIGNED-OFF] Bug 17670: Grammar mistakes - effect vs affect

In two places:

1. Administration -> Preferences -> Circulation ->
   AllowMultipleIssuesOnABiblio: says effect, should say affect
2. Reports -> Lost Items -> Help (top-right corner): says effect, should
   say affect

To test, navigate to these two places and confirm charges have been made
and are correct.

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #8 from Kyle M Hall  ---
Jonathan, does it work for you with this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17666] .perl atomic update does not work under kohadevbox

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17666

--- Comment #7 from Kyle M Hall  ---
Created attachment 57727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57727=edit
Bug 17666 - .perl atomic update does not work under kohadevbox

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280

--- Comment #9 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #8)
> Ok so, beginning of a release cycle, let's take decisions!
> 
> What is the plan of attack for these notices?
> I think we need to know if 1. everybody agrees with the TT syntax for
> notices and 2. we have dedicated time in a release cycle to move all of the
> existing notices to TT syntax.
> I don't think it's a good idea not to move all of the notices at the same
> time (ie. during the same release cycle).

I totally agree with that. I think first we need to start a mailing list topic
for this which should end with a simple vote of whether to continue to use the
existing syntax by default or to switch to TT by default and eventually
deprecate the existing syntax. What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15280] Switch default CHECKOUT notice to Template Toolkit

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280

--- Comment #8 from Jonathan Druart  
---
Ok so, beginning of a release cycle, let's take decisions!

What is the plan of attack for these notices?
I think we need to know if 1. everybody agrees with the TT syntax for notices
and 2. we have dedicated time in a release cycle to move all of the existing
notices to TT syntax.
I don't think it's a good idea not to move all of the notices at the same time
(ie. during the same release cycle).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14567] Browse interface for OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #32 from Jonathan Druart  
---
Scalar value @_[0] better written as $_[0] at
/home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch/Search.pm line 126.
Scalar value @_[0] better written as $_[0] at
/home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch/Search.pm line 128.
Can't use string ("(d)") as an ARRAY ref while "strict refs" in use at
/home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line
108.


Please do a *complete* pass on this patchset before sending it back to the QA
queue:
- Remove debug statements
- Add a test plan:
- Provide full test coverage
- The opac-browse template looks wrong (does not follow the usual pattern, is
it expected?)
- And finally, test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17671] Remove unused variables in Reserves.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671

--- Comment #1 from Petter Goksøyr Åsen  ---
Created attachment 57726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57726=edit
remove unused variables

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17671] New: Remove unused variables in Reserves.pm

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17671

Bug ID: 17671
   Summary: Remove unused variables in Reserves.pm
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: boutrosboutrosbout...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

I was reading through Reserves.pm trying to figure out a bug - found some
unused variables instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

--- Comment #17 from Jonathan Druart  
---
Created attachment 57725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57725=edit
Bug 15822: Fix 500 error when searching if items.onloan=-00-00

The calls
  output_pref({ dt => dt_from_string( $date ) })
are wrong and should be replaced with
  output_pref({ str => $date })
For better error handling.

Here we fix the problem of items.onloan when searching

Test plan:
- Set items.onloan=-00-00 (UPDATE items SET onloan='-00-00')
This can come from old data or bad migration
- Execute a search
=> Without this patch you get
Can't locate object method "ymd" via package "dateonly" (perhaps you forgot to
load "dateonly"?) at /home/vagrant/kohaclone/Koha/DateUtils.pm line 225.
=> With this patch you won't get the error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15822] STAFF Advanced search error date utils

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15822

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17516] Add CSV export option to item search *after* displaying output to screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17516

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57107|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 57724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57724=edit
Bug 17516 - Add CSV export option to item search after displaying output to
screen

To test:
1 - Perform an item search
2 - Note you now have a link to output to csv
3 - Click that link
4 - Page should not change and you should recieve a csv
5 - Ensure nothing breaks
6 - Sign off
High five!

Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17516] Add CSV export option to item search *after* displaying output to screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17516

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17566] Change initial focus in item editor depending on last action

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17566

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
I don't really like that, especially because it does not work with select. It's
weird to select the 4th element (in my case) of the add item form.
I'd like to get cataloguer specialist point of views.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57720|0   |1
is obsolete||

--- Comment #8 from Jonathan Druart  
---
Created attachment 57722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57722=edit
Bug 17416: Fix audio alerts

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17418] Move staff client home page JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17418

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56164|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 57723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57723=edit
Bug 17418 - Move staff client home page JavaScript to the footer

This patch alters the header and footer include files so that JavaScript
can be included in either one or the other. As a proof of concept, the
staff client home page is updated to include JS in the footer instead
of the header.

The processing of JavaScript included on individual pages can now be
similar to how it is done in the OPAC. A block is created with the
page's JavaScript which is then processed in js_includes.inc in the
correct order, after other required js assets.

On pages which have been modified to allow JavaScript to be moved to the
footer you must add a variable to the template: [% SET footerjs = 1 %].
Eventually all staff client templates should be modified so that setting
a flag is not required.

"[% MACRO jsinclude BLOCK %]" is used instead of "[% BLOCK %]" and "[%
PROCESS %]" because MACRO allows the template directives to be
processed correctly when included by intranet-bottom.inc.

To test, apply the patch and view the staff client home page.

- Confirm that you get a confirmation when deleting a news item from the
  home page.
- Enable the CircAutocompl system preference and test that patron
  autocomplete works from the "Check out" tab from the staff home page
  and from other pages where the "Check out" tab is present.
- Test that JavaScript is working correctly on other pages like
  Circulation, Preferences, etc.

Signed-off-by: Claire Gravely 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #57719|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 57721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57721=edit
Bug 17416 - Move javascript in doc-head-close.inc into a separate include

In order to prepare to move staff client javascript assets into the
footer, this patch creates a new include file containing all 

[Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56152|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 57719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57719=edit
Bug 17416 - Move javascript in doc-head-close.inc into a separate include

In order to prepare to move staff client javascript assets into the
footer, this patch creates a new include file containing all 

[Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

--- Comment #6 from Jonathan Druart  
---
Created attachment 57720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57720=edit
Bug 17416: Fix audio alerts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #4 from Jonathan Druart  
---
Ok, I have a fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17416] Move javascript in doc-head-close.inc into a separate include

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17416

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Owen, I have created an audio alert (#breadcrumbs using beep.ogg) to test if it
works and it does not on the main page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/