[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Marc Véron  changed:

   What|Removed |Added

  Attachment #60423|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

--- Comment #20 from Marc Véron  ---
(In reply to Katrin Fischer from comment #19)
> Sorry, but I am not sure that breaking up HTML in the pref files always
> makes sense, as it won't keep it out of translations and HTML there doesn't
> break the strings as it does in the templates. Putting it on different lines
> does.
> 
> Before the change:
> 
> First string (copied from 16.11):
> The following  href='http://schema.koha-community.org/16_11/tables/borrowers.html'
> target='blank'>database columns must be filled in on the patron entry
> screen:
> Second string:
> (separate columsn with |)
> 
> After the change:
> First string:
> The following database columns must be filled in on the patron entry screen:
> Second string:
>  target='blank'>Database schema
> Third string:
> (separate columsn with |)  href='http://schema.koha-community.org/master/tables/borrowers.html'
> target='blank'>Database schema
> 
> If we change it, why not have the "input help text" appear before the input
> field at least?

Sorry, I was not aware that splitting by HTML tags does not happen in system
preferences. Please disregard my alternative patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

Joy Nelson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18087] Clarification on File type when using file of biblionumbers to export data

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18087

Joy Nelson  changed:

   What|Removed |Added

  Attachment #60124|0   |1
is obsolete||

--- Comment #9 from Joy Nelson  ---
Created attachment 60431
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60431=edit
Bug 18087 - Clarification on File type when using file of biblionumbers to
export data

Added a line to the screen  detailing the types of files that can be used to
upload a list of biblionumbers.

Test plan:
1. Go to tools->export data
2. under File option,  (File types accepted: .csv and .txt)  should appear
3. Check both Bibliographic and Authority Export screens for this new string.

Signed-off-by: Claire Gravely 

Signed-off-by: Joy Nelson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

--- Comment #29 from Alex Buckley  ---
(In reply to Baptiste in comment 28)

Ah sorry I see what the issue is I accidentally missed some steps in the test
plan for this patch.

The ItemTypes.t unit test needs to be run after running the web installer
(installing libraries, categories and item types) but before adding/importing
any bibliographic records.

You were getting a duplicate entry error (which I have just replicated) by
having biblio record(s) in your Koha database before running this unit test and
so when a record with the primary key of 1 is inserted into the biblio table by
this unit test (a change I added to the ItemTypes.t unit test as part of this
patch) it throws an error because a biblio record with the primary key of 1
already exists.

Therefore a corrected test plan for attachment 59954 (Bug 17944 - Implemented a
subtest in the ItemTypes.t file for is_used function in ItemType.pm) is:

1. Apply patches of this bug
2. Restart memcached: sudo service memcached restart
3. Drop and recreate your Koha database 
4. Run through the Koha web installer making sure to select all data values for
installation
5. When the web installer has finished, in your terminal navigate to
t/db_dependent/Koha/
6. Start koha-shell: sudo koha-shell 
7. Run the ItemTypes.t unit test: prove -v ItemTypes.t
8. Notice all tests are successful, and notice that the last two outputs
show the is_used subtest gave successful results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18141] New: Edifact messages won't allow deletion of baskets

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18141

Bug ID: 18141
   Summary: Edifact messages won't allow deletion of baskets
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jacquel...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

If you have messages from a vendor in Edifact then you are not able to delete
baskets from that vendor until the messages are deleted on the back end. This
is even if the basket has not been closed and just cancelled.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

--- Comment #6 from Barton Chittenden  ---
When -n is used, so that status is not updated, the script still prints

22 patrons updated

This is the kind of thing that makes my blood pressure go up until I
double-check in the database. Yes, I see at the top of the run, 'No actions
will be taken (test mode)', but I would still prefer

22 patrons would have been updated

Just for my peace of mind.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

--- Comment #5 from Barton Chittenden  ---
The use of

-n  No Action. With this flag set, script will report changes but not
actually execute them on the database.

matches the options of j2a.pl, but I think that the use of

 --confirm  Don't commit changes to the database unless the --confirm option is 
used

Is preferred by the Koha community.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

--- Comment #4 from Barton Chittenden  ---
POD ERRORS
Hey! The above document had some coding errors, which are explained
below:

Around line 94:
'=item' outside of any '=over'

Around line 100:
'=item' outside of any '=over'

Around line 106:
'=item' outside of any '=over'

Around line 112:
'=item' outside of any '=over'

Around line 118:
'=item' outside of any '=over'

Around line 124:
'=item' outside of any '=over'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17461] Make plugins-home.pl complain about plugins that can not be loaded

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17461

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Magnus!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17453] Inter-site holds improvement

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17453

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #29 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan, Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14405] Add datatable to fines table in OPAC patron account

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14405

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #7 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11932] move delete checkbox on patron modification to right

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11932

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7626] Delete multiple tags at once

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7626

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18099] Put call number in its own column on inventory screen

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18099

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks David!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18063] Remove dead code from tools/manage-marc-import.tt

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18063

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for for 17.05, thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

Barton Chittenden  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #3 from Barton Chittenden  ---
update_patrons_category.pl --help shows

Usage:
update_patrons_category.pl [ -b= -f=
-t= ]

but

Options:

...

-f  *required* defines the category to update. Expects the code from
categories.categorycode.

-t  *required* defines the category patrons will be converted to.
Expects the code from categories.categorycode.

Square brackets indicate optional arguments. You don't need angle brackets
surrounding  and . Elipses show repeated arguments,
and a pipe shows alternative arguments.

Here's what I would expect for usage, given the options:

Usage:
update_patrons_category.pl -f=categorycode -t=categorycode 
   [-b=branchcode] [-n] [-a] [-fo=X] [-fu=X]
   [-rb=date] [-ra=date] [-v]
   [--field column=value ...] 
update_patrons_category.pl --help | --man

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

--- Comment #19 from Katrin Fischer  ---
Sorry, but I am not sure that breaking up HTML in the pref files always makes
sense, as it won't keep it out of translations and HTML there doesn't break the
strings as it does in the templates. Putting it on different lines does.

Before the change:

First string (copied from 16.11):
The following database columns must be filled in on the patron entry
screen:
Second string:
(separate columsn with |)

After the change:
First string:
The following database columns must be filled in on the patron entry screen:
Second string:
Database schema
Third string:
(separate columsn with |) Database schema

If we change it, why not have the "input help text" appear before the input
field at least?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18140] New: Print Full MARC bib record from Advance Editor

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18140

Bug ID: 18140
   Summary: Print Full MARC bib record from Advance Editor
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jacquel...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Need to be able to print a full MARC record from Advance Editor to streamline
processes instead of partners having to go to OPAC to accomplish this.

When you try to print from advance editor, you only get the first half of the
record.

A print button towards the top that would print the entire MARC record would be
beneficial for managers who are helping to educate their catalogers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18040] Updating buttons on Tools->Upload Local Cover Image

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18040

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18036] Improve test coverage for themelanguage

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18036

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #24 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Mark, Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865

Baptiste  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865

Baptiste  changed:

   What|Removed |Added

  Attachment #59199|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865

Baptiste  changed:

   What|Removed |Added

 CC||baptiste.wojtkowski@biblibr
   ||e.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17865] If a subscription has no history end date, it shows as expired today in OPAC

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17865

--- Comment #16 from Baptiste  ---
Created attachment 60430
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60430=edit
[SIGNED OFF] Bug 17865 'If a subscription has no history end date, it shows as
expired today in OPAC'

--TEST PLAN--
1) View a subscription with no history end date
2) Search for an item with a subcription in OPAC
3) Under subscription tab click more details
4) The end date will be the current date
5) Apply patch and refresh
6) The end date will not be shown

Signed-off-by: Baptiste Wojtkowski 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17947] Searching my library first shows the branchcode by the search bar rather than branchname

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17947

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17627] Move C4::Koha::GetItemTypesByCategory to Koha::ItemTypes

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17627

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17895] Small typo -'re-set'

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #6 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17846] Remove C4::Koha::get_infos_of

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17846

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #9 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan, Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17793] Make sysprefs search show on all Administration pages

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17793

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #24 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha, Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17932] Koha::Object should provide a TO_JSON method

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17932

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #25 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139

--- Comment #3 from Kyle M Hall  ---
Created attachment 60429
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60429=edit
Bug 18139 - Add additional unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139

--- Comment #1 from Kyle M Hall  ---
Created attachment 60427
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60427=edit
Bug 18139 - Prep unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #6 from Marc Véron  ---
On the patron's detail page, street number goes on a separate line, something
like
11
rue de Bâle

instead of
11 rue de Bâle

I think the code should go inside the li element in
member-display-address-style-fr.inc (maybe at other places as well?)

You have something like:

[% IF streetnumber %] [% streetnumber %][% END %]
[%IF roadtype_desc %] [% roadtype_desc %][% END %]
[% address %]


I think it should be something like:


[% IF streetnumber %] [% streetnumber %][% END %]
[%IF roadtype_desc %] [% roadtype_desc %][% END %]
[% address %]


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139

--- Comment #2 from Kyle M Hall  ---
Created attachment 60428
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60428=edit
Bug 18139 - 'Too many checked out' can confuse librarians

The too many checked out message can be very confusing for librarians
when the limit specified is more or less than the number of checkouts
the patron already has. We should make it clear to the librarian that
his is only counting certain types of checkouts by giving them the
issuing rule criteria used.

Test Plan:
1) Apply this patch
2) Try to check out more items than the circ rules allow for
   regular and on-site checkouts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18139] 'Too many checked out' can confuse librarians

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18139] New: 'Too many checked out' can confuse librarians

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18139

Bug ID: 18139
   Summary: 'Too many checked out' can confuse librarians
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The too many checked out message can be very confusing for librarians when the
limit specified is more or less than the number of checkouts the patron already
has. We should make it clear to the librarian that this is only counting
certain types of checkouts by giving them the issuing rule criteria used.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

--- Comment #5 from Baptiste  ---
Created attachment 60426
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60426=edit
BUG 18110 : Removed a wrong syspref from code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18112] opac-memberentry.pl doesn't contain streettype field

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18112

Serhij Dubyk  changed:

   What|Removed |Added

 CC||du...@ukr.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18110] Adds FR to the syspref AddressFormat

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18110

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #4 from Marc Véron  ---
Hi Babtiste, 
the patch adds a line 
('LoadSearchHistoryToTheFirstLoggedUser', 
to installer/data/mysql/sysprefs.sql (Line 237)

It seems to me that it is not related to this Bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14764] Add OPAC News branch selector

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Baptiste  changed:

   What|Removed |Added

  Attachment #60424|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14764] Add OPAC News branch selector

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Baptiste  changed:

   What|Removed |Added

  Attachment #59653|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14764] Add OPAC News branch selector

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

Baptiste  changed:

   What|Removed |Added

  Attachment #59827|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14764] Add OPAC News branch selector

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

--- Comment #45 from Baptiste  ---
Created attachment 60425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60425=edit
[SIGNED OFF] Bug 14764: OPAC news selector

Test plan:

1) Add more than one library, at least two in total is needed. Make note
   of which is your current user's home branch.
2) Go to Tools -> News and add one global ("All") news item and one
   specific for each branch.
3) Apply the patches.
4) Perform database upgrades when you log in.
5) Go to OPAC main, it should work as before: Showing global news as
   well as the news for your home branch once logged in.
6) Go to System Preferences -> OPAC and set 'OPACNewsBranchSelect' to
   yes.
7) Go to OPAC main, you should see the global news item plus any items
   for your home branch for the current user if logged in.
8) Above the news, you will see a dropdown that lists the branches.
   Select one, and click "Change library."
9) You should now see global news and the news for the selected branch,
   regardless of whether logged in or not.

Sponsored-By: Halland County Library

Fixes QA comments:

* Keep the current selected branch selected

* Change OPACNewsBranchSelect -> OPACNewsLibrarySelect

* fix 'system wide only' view for logged in user. We still show system
  wide even when a library is selected.

* Removed the "change library" link

* Added a label to the field.

Signed-off-by: Owen Leonard 
Signed-off-by: Zeno Tajoli 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14764] Add OPAC News branch selector

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14764

--- Comment #44 from Baptiste  ---
Created attachment 60424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60424=edit
Bug 18119: Fix comment in cataloguing.js

Test plan:
Go to cataloging, and try something which depends on javascript -
collapse/uncollapse fields, open authority search window, ...
-> without patch it is not working
-> with patch it is working correctly

Signed-off-by: Jonathan Druart 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17427] Replace CGI::Session with Data::Session

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17427

--- Comment #19 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #17)
> This seems to break scripts like stage-marc-import and tools/upload.pl.
> I am still testing a bit but after successfully uploading one file, I am not
> able to upload anymore.
> Also saw this error:
> stage-marc-import.pl: YAML::Tiny does not support C4::BackgroundJob
> references at /usr/local/share/perl/5.20.2/Data/Session/Serialize/YAML.pm
> line 18., 

That can be fixed using DataDumper or FreezeThaw instead of YAML as serializer.

(In reply to Marcel de Rooy from comment #18)
> Data::Session creates a CGI object.
> And we do not like that in scripts like upload-file.pl that call
> check_cookie_auth (calling get_session).
> The created CGI object in this case makes the upload disappear.
> Other scripts may have issues too going the similar cookie_auth way..

I do not know how to fix that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16018] Merge.pl code cleanup

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16018

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #27 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Remi!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17566] Change initial focus in item editor depending on last action

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17566

--- Comment #10 from Owen Leonard  ---
If we want to put the focus on the first select2-styled  I think we
have to trigger it to open:

https://select2.github.io/examples.html#programmatic

However, I wonder whether this bug makes too many assumptions about how
catalogers want to work. In our framework the first subfield is "Withdrawn
status," and that's almost never the first field the catalogers will want to
change.

The focus returns to the search form at the top after I have edited an item,
but what if I wanted to edit another item next?

I worry that this patch assumes a workflow which is not universal enough to
make it appropriate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16749] Additional fixes for debian scripts

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16749

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #66 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Marcel, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Baptiste  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||baptiste.wojtkowski@biblibr
   ||e.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Baptiste  changed:

   What|Removed |Added

  Attachment #60235|0   |1
is obsolete||
  Attachment #60292|0   |1
is obsolete||

--- Comment #18 from Baptiste  ---
Created attachment 60423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60423=edit
[SIGNED OFF] Bug 18026 [ALTERNATIVE PATCH FOR MASTER] URL to database columns
link in system preferences is incorrect

Alternative patch for Master (with unsplitted sentences for better
translatability)

To test:
- Apply patch to master
- Go to Home > Administration > System preferences
- Select Acquisitons, OPAC and Patrons, search for "Database schma", verify
that text and links are correct.

Signed-off-by: Baptiste Wojtkowski 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Baptiste  changed:

   What|Removed |Added

  Attachment #60234|0   |1
is obsolete||

--- Comment #17 from Baptiste  ---
Created attachment 60422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60422=edit
[SIGNED OFF] Bug 18026 - URL to database columns link in system preferences is
incorrect (3.22.x)

Here's a patch for the 3.22.x branch

Signed-off-by: Baptiste Wojtkowski 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Baptiste  changed:

   What|Removed |Added

  Attachment #60233|0   |1
is obsolete||

--- Comment #16 from Baptiste  ---
Created attachment 60421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60421=edit
[SIGNED OFF] Bug 18026 - URL to database columns link in system preferences is
incorrect (16.11.x)

Here's a patch for the 16.11.x branch

modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref

Signed-off-by: Baptiste Wojtkowski 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18026] URL to database columns link in system preferences is incorrect

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18026

Baptiste  changed:

   What|Removed |Added

  Attachment #60232|0   |1
is obsolete||

--- Comment #15 from Baptiste  ---
Created attachment 60420
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60420=edit
[SIGNED OFF] Bug 18026 - URL to database columns link in system preferences is
incorrect (16.05.x)

Here's a patch for the 16.05.x branch

modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref

Signed-off-by: Baptiste Wojtkowski 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18138] New: Use MARC modification template when adding/ updating bibliographic records

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

Bug ID: 18138
   Summary: Use MARC modification template when adding/updating
bibliographic records
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: stefan.berndts...@ub.gu.se
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

When importing records, MARC modification templates can be used to silently
remove unwanted tags among other thing. The same thing could be useful when
adding/updating bibliographic records from within Koha.

I therefor propose an addition of a SysPref to set a default template to use in
AddBiblio and ModBiblio before TransformMarcToKoha is called.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17566] Change initial focus in item editor depending on last action

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17566

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #9 from Marcel de Rooy  ---
Changing status to BLOCKED
Anyone have a clue how to make this focus visible?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60390|0   |1
is obsolete||

--- Comment #37 from Marcel de Rooy  ---
Created attachment 60415
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60415=edit
Bug 15498: Fix conflict with bug 17394

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60387|0   |1
is obsolete||

--- Comment #35 from Marcel de Rooy  ---
Created attachment 60413
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60413=edit
Bug 15498: Do not display sql csv profiles

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60388|0   |1
is obsolete||

--- Comment #36 from Marcel de Rooy  ---
Created attachment 60414
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60414=edit
Bug 15498: Fix show/hide csv profile list

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498

--- Comment #38 from Marcel de Rooy  ---
Created attachment 60416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60416=edit
Bug 15498: [QA Follow-up] Additional changes

Adds ExportRemoveFields to sysprefs.sql

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60385|0   |1
is obsolete||

--- Comment #33 from Marcel de Rooy  ---
Created attachment 60411
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60411=edit
Bug 15498: Let the user choose the CSV profile to export circ history

The way the export options are displayed at the bottom of the checkouts table
was not consistent.
Prior to this patch set, they are display if ExportRemoveFields or
ExportWithCsvProfile is set.
It does not make any sense, the user could want to export the checkouts in
iso2709 format without having to define a csv profile and fill the pref.

Moreover the behavior of this pref did not match its description: it's used as
a default CSV profile when exporting records from the export tools or the
command line.

This patch set adds a new pref ExportCircHistory and remove
ExportWithCsvProfile. The new pref is set if ExportWithCsvProfile or
ExportRemoveFields were set.
A new dropdown list with the CSV profile list will be displayed in the
export area, at the bottom of the checkouts table.

Note that now --csv_profile_id is mandatory for the export command line
(misc/export_records.pl) if the export format is csv.

Test plan:
0/ Do not execute the DB entry
1/ Clear both ExportWithCsvProfile and ExportRemoveFields prefs
2/ Execute the DB entry
3/ ExportCircHistory should not be set and the export options should not
be displayed at the bottom of the checkouts table.
4/ Remove the pref
  DELETE FROM systempreferences WHERE variable='ExportCircHistory';
and reinsert the previous one, with a value:
  INSERT INTO systempreferences (variable, value) VALUES
  ('ExportWithCsvProfile', 'something');
Execute the DB entry again
=> The now pref should be now set
5/ Export some checkouts using the CSV entry
6/ Note that the export tool and commandline script still work using the
csv format. You have to provide a --csv_profile_id option to make it
work.

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60386|0   |1
is obsolete||

--- Comment #34 from Marcel de Rooy  ---
Created attachment 60412
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60412=edit
Bug 15498: Add ExportCircHistory and remove ExportWithCsvProfile

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17990] Code to check perl module versions is buggy

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17990

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #10 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17977] Add acquisitions sidebar menu to suggestions

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17977

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17974] Add the Koha::Item->biblio method

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17974

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan, Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17973] Add the Koha::Checkout->item method

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17973

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5784] link to acq from budgets & funds

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17972] Reformat acquisitions sidebar menu with acquisitions and administration sections

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5784] link to acq from budgets & funds

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784

--- Comment #14 from Kyle M Hall  ---
Created attachment 60410
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60410=edit
Bug 5784 - Undo link in breadcrumbs

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17972] Reformat acquisitions sidebar menu with acquisitions and administration sections

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||5784


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784
[Bug 5784] link to acq from budgets & funds
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5784] link to acq from budgets & funds

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5784

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA
 Blocks||17972

--- Comment #13 from Kyle M Hall  ---
Issue resolved by 17972. Pushing followup to remove link from breadcrumbs.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17972
[Bug 17972] Reformat acquisitions sidebar menu with acquisitions and
administration sections
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58129|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 60406
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60406=edit
Bug 14146: Add tests for AddReturn + CumulativeRestrictionPeriods

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58131|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  
---
Created attachment 60408
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60408=edit
Bug 14146: Clean a bit and make the code understandable

The code was a bit weird and this patch cleans it a bit by renaming
variables and adding a variable.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58130|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  
---
Created attachment 60407
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60407=edit
Bug 14146: Add the ability to cumulate restriction periods

At the moment the default behaviour is not to cumulate the restriction
periods but to apply the longest one.
This patch set creates a new syspref CumulativeRestrictionPeriods. If
on, the behaviour changes and the restriction periods are cumulated: the
days of the second restriction are added to the actual restriction
period.

We could add a new circulation rule instead of a syspref, but I am not
sure it's very useful to have such granularity for this behaviour (can
be changed if needed).

How it works:
Let's take 2 items, A and B.
A is returned with Na days late, and B Nb days late
The grace period is Ng and there is 1 day of suspension charge per day
of overdue
The suspension period is until day D = Na - Ng + Nb - Ng

I would have expected D = Na + Nb - Ng but it's how it worked before
this patch.

Test plan:
Create several overdue for a given patron
Do the checkins and confirm that the period are added if the pref is on.
If the pref is off, you should not get any changes in the existing behaviour.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #58149|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 60409
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60409=edit
Bug 14146: Add the new pref CumulativeRestrictionPeriods

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #59540|0   |1
is obsolete||
  Attachment #59541|0   |1
is obsolete||
  Attachment #59542|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 60403
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60403=edit
Bug 17964: TT syntax for notices - Prove that CHECKIN and CHECKOUT are
compatible

>From the CHECKIN and CHECKOUT templates you should be able to access the
following information: item, biblio, biblioitem, patron and library

Test plan:
Define CHECKIN and CHECKOUT notice templates.
You should be able to define them using the TT syntax to produce the
same generated notice messages as with the historical syntax.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

--- Comment #9 from Kyle M Hall  ---
Created attachment 60405
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60405=edit
Bug 17964: Support date formatting

Using the KohaDates plugin will allow us to format dates as we want,
using the same filters as the ones defined in the KohaDates TT plugin.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

--- Comment #8 from Kyle M Hall  ---
Created attachment 60404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60404=edit
Bug 17964: Add old_issues

If it's a CHECKIN, C4::Circulation::SendCirculationAlert set a
"old_issues" key instead of "issues".

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17963] TT syntax for notices - Prove that AR_* are compatible

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17963

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #59539|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 60402
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60402=edit
Bug 17963: TT syntax for notices - Prove that AR_* are compatible

Nothing new here since bug 17962, the AR_* notice messages are quite
simple. They send the article_request, patron, biblio, biblioitem, item and
library linked to the article request.

All the fields from these 6 tables should still be accessible using the
TT syntax.

Test plan:
Define TT notice templates for AR_PENDING, AR_PROCESSING, AR_COMPLETED
or AR_CANCELED.

You should manage to create a template to generate the same result as
the historical syntax.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17959] Add the Koha::Notice::Message[s] packages (message_queue table )

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #59468|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 60401
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60401=edit
Bug 17959 - Add the Koha::Notice::Message[s] packages (message_queue table)

This just add Koha::Notice::Message[s] for later uses.

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17959] Add the Koha::Notice::Message[s] packages (message_queue table )

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17959] Add the Koha::Notice::Message[s] packages (message_queue table )

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17959

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17962] TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17958] Add the Koha::Notice::Template[s] packages (letter table)

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17958

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #9 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17950] Small improvements for Merge.t

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17950

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #15 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17964] TT syntax for notices - Prove that CHECKIN and CHECKOUT are compatible

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17964

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17948] Link to make a new list in masthead in OPAC does not take you straight to add form

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17948

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Caitlin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14854] Add DataTables on upload results table

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14854

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Aleisha!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18068] ES: Location and (home|holding)branch facets mixed

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18068

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #8 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Tomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18045] Reserves.t can fail because of caching issues

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18045

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #4 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14146] Additional days are not added to restriction period when checking-in several overdues for same patron

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||n...@bywatersolutions.com

--- Comment #9 from Nick Clemens  ---
Conflict in the tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18136] Content of ExportRemoveFields is not picked to pre-fill field list

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18136

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #5 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #60389|0   |1
is obsolete||

--- Comment #32 from Marcel de Rooy  ---
Comment on attachment 60389
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60389
Bug 15498: [QA Follow-up]

Somehow this is useless. Space gets away when committing..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18025] Expired password recovery links cause sql crash

2017-02-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18025

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #18 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Liz, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >