date:20170316

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

di...@calyx.net.au changed:

   What|Removed |Added

 CC||di...@calyx.net.au
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #7 from di...@calyx.net.au ---
Comment on attachment 61194
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194
Bug 13205: Last/first page options for result list paging for OPAC

>From bd80eca290f389e8e12d63dd220ec639763adcbb Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia 
>Date: Thu, 16 Feb 2017 02:28:13 +
>Subject: [PATCH] Bug 13205: Last/first page options for result list paging for
> OPAC
>
>Same fix but on OPAC side. Same test plan
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Dilan Johnpulle 
>
>---
> .../bootstrap/en/includes/page-numbers.inc | 26 --
> opac/opac-search.pl|  2 ++
> 2 files changed, 16 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc 
>b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>index f18c9ce..63e083e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>@@ -1,19 +1,21 @@
> [% IF ( PAGE_NUMBERS ) %]
> 
> 
>-[% IF ( previous_page_offset.defined ) %]
>- Previous
>-[% END %]
>-[% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %]
>-[% IF ( PAGE_NUMBER.highlight ) %]
>-[% PAGE_NUMBER.pg %]
>-[% ELSE %]
>-[% PAGE_NUMBER.pg %]
>+First
>+[% IF ( previous_page_offset.defined ) %]
>+ Previous
> [% END %]
>-[% END %]
>-[% IF ( next_page_offset ) %]
>-Next 
>-[% END %]
>+[% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %]
>+[% IF ( PAGE_NUMBER.highlight ) %]
>+[% PAGE_NUMBER.pg 
>%]
>+[% ELSE %]
>+[% PAGE_NUMBER.pg 
>%]
>+[% END %]
>+[% END %]
>+[% IF ( next_page_offset ) %]
>+Next 
>+[% END %]
>+Last
> 
> 
> [% END %]
>diff --git a/opac/opac-search.pl b/opac/opac-search.pl
>index a84e9d3..130aad3 100755
>--- a/opac/opac-search.pl
>+++ b/opac/opac-search.pl
>@@ -837,6 +837,7 @@ for (my $i=0;$i<@servers;$i++) {
> my @page_numbers;
> # total number of pages there will be
> my $pages = ceil($hits / $results_per_page);
>+my $last_page = ($pages * $results_per_page) - $results_per_page;
> # default page number
> my $current_page_number = 1;
> if ($offset) {
>@@ -887,6 +888,7 @@ for (my $i=0;$i<@servers;$i++) {
> 
> }
> $template->param(   PAGE_NUMBERS => \@page_numbers,
>+last_page => $last_page,
> previous_page_offset => 
> $previous_page_offset) unless $pages < 2;
> $template->param(next_page_offset => $next_page_offset) unless 
> $pages eq $current_page_number;
> }
>-- 
>2.1.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #6 from di...@calyx.net.au ---
Comment on attachment 61194
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194
Bug 13205: Last/first page options for result list paging for OPAC

>From bd80eca290f389e8e12d63dd220ec639763adcbb Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia 
>Date: Thu, 16 Feb 2017 02:28:13 +
>Subject: [PATCH] Bug 13205: Last/first page options for result list paging for
> OPAC
>
>Same fix but on OPAC side. Same test plan
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Dilan Johnpulle 
>
>---
> .../bootstrap/en/includes/page-numbers.inc | 26 --
> opac/opac-search.pl|  2 ++
> 2 files changed, 16 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc 
>b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>index f18c9ce..63e083e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>@@ -1,19 +1,21 @@
> [% IF ( PAGE_NUMBERS ) %]
> 
> 
>-[% IF ( previous_page_offset.defined ) %]
>- Previous
>-[% END %]
>-[% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %]
>-[% IF ( PAGE_NUMBER.highlight ) %]
>-[% PAGE_NUMBER.pg %]
>-[% ELSE %]
>-[% PAGE_NUMBER.pg %]
>+First
>+[% IF ( previous_page_offset.defined ) %]
>+ Previous
> [% END %]
>-[% END %]
>-[% IF ( next_page_offset ) %]
>-Next 
>-[% END %]
>+[% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %]
>+[% IF ( PAGE_NUMBER.highlight ) %]
>+[% PAGE_NUMBER.pg 
>%]
>+[% ELSE %]
>+[% PAGE_NUMBER.pg 
>%]
>+[% END %]
>+[% END %]
>+[% IF ( next_page_offset ) %]
>+Next 
>+[% END %]
>+Last
> 
> 
> [% END %]
>diff --git a/opac/opac-search.pl b/opac/opac-search.pl
>index a84e9d3..130aad3 100755
>--- a/opac/opac-search.pl
>+++ b/opac/opac-search.pl
>@@ -837,6 +837,7 @@ for (my $i=0;$i<@servers;$i++) {
> my @page_numbers;
> # total number of pages there will be
> my $pages = ceil($hits / $results_per_page);
>+my $last_page = ($pages * $results_per_page) - $results_per_page;
> # default page number
> my $current_page_number = 1;
> if ($offset) {
>@@ -887,6 +888,7 @@ for (my $i=0;$i<@servers;$i++) {
> 
> }
> $template->param(   PAGE_NUMBERS => \@page_numbers,
>+last_page => $last_page,
> previous_page_offset => 
> $previous_page_offset) unless $pages < 2;
> $template->param(next_page_offset => $next_page_offset) unless 
> $pages eq $current_page_number;
> }
>-- 
>2.1.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

di...@calyx.net.au changed:

   What|Removed |Added

  Attachment #60300|0   |1
is obsolete||

--- Comment #5 from di...@calyx.net.au ---
Created attachment 61194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194=edit
Bug 13205: Last/first page options for result list paging for OPAC

Same fix but on OPAC side. Same test plan

Sponsored-by: Catalyst IT

Signed-off-by: Dilan Johnpulle 
Signed-off-by: Your Full Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17895] Small typo -'re-set'

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17895

Katrin Fischer  changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4175] duplicate items does not obey autoBarcode sys pref

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4175

Candice Hope  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=8857

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8857] Add and duplicate functionality inconsistent w/autobarcode

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8857

Candice Hope  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=4175
 CC||candi...@payson.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #4 from Marc Véron  ---
I can not toggle code display.

It seems that something went lost from previous patch:

Show sql code
Hide
sql code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8857] Add and duplicate functionality inconsistent w/autobarcode

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8857

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15249] barcode duplicate warning missing during adding multiple copy

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15249

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18280

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18280] Item barcodes should be locked when record is created

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18280

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15249

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8425] Autobarcode generates duplicate barcodes with AcqCreateItems = on order

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8425

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18280

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18280] Item barcodes should be locked when record is created

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18280

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=8425

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284

Marc Véron  changed:

   What|Removed |Added

  Attachment #61184|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 61193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61193=edit
Bug 18284: (bug 17196 follow-up) Move biblio metadata when a biblio is deleted

There is a deletedbiblio_metadata table but it is not populated when a
biblio is deleted. Since we have a ON DELETE constraint on
biblio_metadata.biblionumber, the row is deleted when the biblio entry
is deleted => data lost!

Test plan:
- Create a biblio
- Delete it

=> Without this patch the deletedbiblio_metadata table is not populated
with the biblio_metadata row related to the biblio

=> With this patch applied you should see that the row has been moved.

Followed test plan, behaves as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283

Nick Clemens  changed:

   What|Removed |Added

  Attachment #61175|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 61192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61192=edit
Bug 18283 - Display improvements on report results - hide code and change
wording

This patch makes small display improvements to the report results page.

-Add toggle link for SQL code
-Change results count wording
-Add 'Notes:' label report notes

To test:
1 - Apply patch
2 - Run some reports
3 - Check that results page makes sense
4 - Hide and display code and ensure toggle works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

--- Comment #8 from Jonathan Druart  
---


% git log --oneline

619aa5f Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous
code duplication. Replace mock_dbh 2
5fb9461 Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous
code duplication. Replace mock_dbh 1
5875738 Bug 18286 - Test::DBIx::Class connection/schema is shadowed by a cached
connection/schema
8814c10 Bug 18285 - Koha::Database schema cache accessors

Last patch from this bug does not apply!

% prove t/Members/cardnumber.
t/Members/cardnumber.t .. # Can't initialize a schema with the given
configuration
# Returned Error: `' is not a module name
# configuration: {
#   'fixture_sets' => {}
# }
...

% pmvers Test::DBIx::Class
0.52

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #7 from Jonathan Druart  
---
% git log --oneline

619aa5f Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous
code duplication. Replace mock_dbh 2
5fb9461 Bug 18226 - Remove "use Test::DBIx::Class" instantiations' dangerous
code duplication. Replace mock_dbh 1
5875738 Bug 18286 - Test::DBIx::Class connection/schema is shadowed by a cached
connection/schema
8814c10 Bug 18285 - Koha::Database schema cache accessors

Last patch from this bug does not apply:

t/Members/cardnumber.t .. # Can't initialize a schema with the given
configuration
# Returned Error: `' is not a module name
# configuration: {
#   'fixture_sets' => {}
# }

% pmvers Test::DBIx::Class
0.52

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

--- Comment #6 from Olli-Antti Kivilahti  ---
See the blocked list of Bugs for more individual test fixes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13757] Make patron attributes editable in the opac if set to ' editable in OPAC'

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13757

--- Comment #103 from Jonathan Druart  
---
Just small things:
1. I think we should not display the attributes at the opac if they are empty
and not editable (it's especially weird for self registration)
2. 
[% IF !pm.extended_attributes and pm.size > 3 or
   pm.extended_attributes and pm.size > 4  %]
I am sure you can make it more readable :D

3. Typo 'FilterUnchagedAttributes'

Please fix ASAP and I PQA it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279

Marc Véron  changed:

   What|Removed |Added

  Attachment #61152|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 61191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61191=edit
Bug 18279: Remove C4::Items::GetLostItems

The JOIN done by this subroutine are not always useful (depending on
item-level_itypes). They also search with LIKE when it is not needed.

Since we have now Koha::Items, we can replace this subroutine with a
call to Koha::Items->search with the correct parameters.

A change in previous behaviours can happen: If a items.itemlost contains
a value that is not defined as a LOST authorised value, the item will
not be displayed. I think it's the expected behaviour, even if it should
not happen in correctly configured installations.

Test plan:
To test with item-level_itypes set to item and biblio:
List the lost items you have on your system, using the different
filters available.
The result table should contain the correct item's info.

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

https://bugs.koha-community.org/show_bug.cgi?id=18079

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18289] Fix t/Prices.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289

--- Comment #1 from Olli-Antti Kivilahti  ---
Created attachment 61190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61190=edit
Bug 18289 - Fix t/Prices.t having a Test::DBIx::Class cache issue

REPLICATE ISSUE:

perl t/Prices.t -> fails

AFTER THIS PATCH AND DEPENDENCIES:

perl t/Prices.t -> OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18266] Internal Server Error when paying fine for lost item

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||18289


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289
[Bug 18289] Fix t/Prices.t having a Test::DBIx::Class cache issue
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #61189|0   |1
is obsolete||

--- Comment #12 from Marc Véron  ---
Comment on attachment 61189
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61189
Bug 18279: Remove C4::Items::GetLostItems

Mistaked with Bug number, sorry for the noise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18289

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18289] Fix t/Prices.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18288,
   ||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18287
 Status|NEW |Needs Signoff
 Depends on||18266
   Assignee|ch...@bigballofwax.co.nz|olli-antti.kivila...@jns.fi


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18266
[Bug 18266] Internal Server Error when paying fine for lost item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18289] New: Fix t/Prices.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18289

Bug ID: 18289
   Summary: Fix t/Prices.t having a Test::DBIx::Class cache issue
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: gmcha...@gmail.com

REPLICATE ISSUE:

perl t/Prices.t -> fails

AFTER THIS PATCH AND DEPENDENCIES:

perl t/Prices.t -> OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18079] Cleanup of holds to pull page

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18079

--- Comment #11 from Marc Véron  ---
Created attachment 61189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61189=edit
Bug 18279: Remove C4::Items::GetLostItems

The JOIN done by this subroutine are not always useful (depending on
item-level_itypes). They also search with LIKE when it is not needed.

Since we have now Koha::Items, we can replace this subroutine with a
call to Koha::Items->search with the correct parameters.

A change in previous behaviours can happen: If a items.itemlost contains
a value that is not defined as a LOST authorised value, the item will
not be displayed. I think it's the expected behaviour, even if it should
not happen in correctly configured installations.

Test plan:
To test with item-level_itypes set to item and biblio:
List the lost items you have on your system, using the different
filters available.
The result table should contain the correct item's info.

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288

--- Comment #1 from Olli-Antti Kivilahti  ---
Created attachment 61188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61188=edit
Bug 18288 - Fix t/SocialData.t having a Test::DBIx::Class cache issue

REPLICATE ISSUE:

perl t/SocialData.t -> fails

AFTER THIS PATCH AND DEPENDENCIES:

perl t/SocialData.t -> OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||18288


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288
[Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Depends on||18226
   Assignee|ch...@bigballofwax.co.nz|olli-antti.kivila...@jns.fi


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226
[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18288

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18288] Fix t/SocialData.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18287

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18288] New: Fix t/SocialData.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18288

Bug ID: 18288
   Summary: Fix t/SocialData.t having a Test::DBIx::Class cache
issue
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: gmcha...@gmail.com

REPLICATE ISSUE:

perl t/SocialData.t -> fails

AFTER THIS PATCH AND DEPENDENCIES:

perl t/SocialData.t -> OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287

--- Comment #1 from Olli-Antti Kivilahti  ---
Created attachment 61187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61187=edit
Bug 18287 - Fix t/Koha.t having a Test::DBIx::Class cache issue

REPLICATE ISSUE:

perl t/Koha.t -> fails

AFTER THIS PATCH AND DEPENDENCIES:

perl t/Koha.t -> OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|olli-antti.kivila...@jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||18287


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287
[Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18287] New: Fix t/Koha.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287

Bug ID: 18287
   Summary: Fix t/Koha.t having a Test::DBIx::Class cache issue
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: gmcha...@gmail.com

REPLICATE ISSUE:

perl t/Koha.t -> fails

AFTER THIS PATCH AND DEPENDENCIES:

perl t/Koha.t -> OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18287] Fix t/Koha.t having a Test::DBIx::Class cache issue

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18287

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Depends on||18226


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226
[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||18226


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226
[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18285] Koha::Database schema cache accessors

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||18226


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226
[Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code
duplication
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18226] Remove "use Test::DBIx::Class" instantiations' dangerous code duplication

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18226

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Depends on||18285, 18286


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285
[Bug 18285] Koha::Database schema cache accessors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286
[Bug 18286] Test::DBIx::Class connection/schema is shadowed by a cached
connection/schema
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286

--- Comment #2 from Olli-Antti Kivilahti  ---
Prior to this patch, for example t/Koha.t fails due to this caching issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18285] Koha::Database schema cache accessors

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |olli-antti.kivila...@jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   Assignee|ch...@bigballofwax.co.nz|olli-antti.kivila...@jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18285] Koha::Database schema cache accessors

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Depends on||18285


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285
[Bug 18285] Koha::Database schema cache accessors
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18285] Koha::Database schema cache accessors

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Blocks||18286


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286
[Bug 18286] Test::DBIx::Class connection/schema is shadowed by a cached
connection/schema
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18286] Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286

--- Comment #1 from Olli-Antti Kivilahti  ---
Created attachment 61186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61186=edit
Bug 18286 - Test::DBIx::Class connection/schema is shadowed by a cached
connection/schema

If Koha::Database->schema gets called before

use Test::DBIx::Class

The DB connection from $KOHA_CONF is cached.

This happens most of the time because when C4::Context and friends are loaded
(in compile-time?), they already access the DB.

After Test::DBIx::Class is instantiated and hooks put in place to overload
Koha::Schema connection, those hooks are never called due to getting the old
connection from cache.

This feature introduces a test case to replicate the behaviour and shows how
flushing the connection cache solves the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18285] Koha::Database schema cache accessors

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285

--- Comment #1 from Olli-Antti Kivilahti  ---
Created attachment 61185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61185=edit
Bug 18285 - Koha::Database schema cache accessors

Safe way of getting and flushing the $database->{schema} -cache.

This is needed by Test::DBIx::Class to overcome pre-initialization connection
caching from C4::Context and others.

See Buug 18286

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18286] New: Test::DBIx::Class connection/ schema is shadowed by a cached connection/schema

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18286

Bug ID: 18286
   Summary: Test::DBIx::Class connection/schema is shadowed by a
cached connection/schema
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: gmcha...@gmail.com

If Koha::Database->schema gets called before

use Test::DBIx::Class

The DB connection from $KOHA_CONF is cached.

This happens most of the time because when C4::Context and friends are loaded
(in compile-time?), they already access the DB.

After Test::DBIx::Class is instantiated and hooks put in place to overload
Koha::Schema connection, those hooks are never called due to getting the old
connection from cache.

This feature introduces a test case to replicate the behaviour and shows how
flushing the connection cache solves the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #2 from Christopher Brannon  ---
Works great.  I would change it to a button and put it with the rest of the
buttons at the top of the report.

My 2 cents.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18285] New: Koha::Database schema cache accessors

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18285

Bug ID: 18285
   Summary: Koha::Database schema cache accessors
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org

Safe way of getting and flushing the $database->{schema} -cache.

This is needed by Test::DBIx::Class to overcome pre-initialization connection
caching from C4::Context and others.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284

--- Comment #1 from Jonathan Druart  
---
Created attachment 61184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61184=edit
Bug 18284: (bug 17196 follow-up) Move biblio metadata when a biblio is deleted

There is a deletedbiblio_metadata table but it is not populated when a
biblio is deleted. Since we have a ON DELETE constraint on
biblio_metadata.biblionumber, the row is deleted when the biblio entry
is deleted => data lost!

Test plan:
- Create a biblio
- Delete it

=> Without this patch the deletedbiblio_metadata table is not populated
with the biblio_metadata row related to the biblio

=> With this patch applied you should see that the row has been moved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is deleted

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17196] Move marcxml out of the biblioitems table

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18284

--- Comment #138 from Jonathan Druart  
---
(In reply to Olli-Antti Kivilahti from comment #137)
> Followup Bug 18265 is ready to be SO'd.


I have opened and submitted a patch on bug 18284 to deal with the move of the
biblio metadata and the data lost.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284
[Bug 18284] Biblio metadata are not moved to the deleted table when a biblio is
deleted
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18284] New: Biblio metadata are not moved to the deleted table when a biblio is deleted

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18284

Bug ID: 18284
   Summary: Biblio metadata are not moved to the deleted table
when a biblio is deleted
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: blocker
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

There is a deletedbiblio_metadata table but it is not populated when a biblio
is deleted. Since we have a ON DELETE constraint on
biblio_metadata.biblionumber, the row is deleted when the biblio entry is
deleted => data lost!

We absolutely need this one before the next release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #60851|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 61182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61182=edit
Bug 18120: REST api | /acquisitions/vendors unit tests

This patch introduces unit tests that need to be passed by an
/acquisitions/vendors/ REST endpoint.

To test:
- Apply the patch
- Run:
  $ sudo koha-shell kohadev
 k$ prove t/db_dependent/api/v1/acquisitions_vendors.t
=> FAIL: The endpoint is not present, should fail.

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #60852|0   |1
is obsolete||

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 61183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61183=edit
Bug 18120: REST api | Add a 'vendors' endpoint

This patch introduces an /acquisitions/vendors endpoint.
To test:
- Apply the patch
- Run:
  $ sudo koha-shell kohadev
 k$ prove t/db_dependent/api/v1/acquisitions_vendors.t
=> SUCCESS: Tests pass
- Sign off :-D

Sponsored-by: ByWater Solutions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18265] Followup to Bug 17196. deletedbiblio_metadata is not used. biblioitemnumber was forgotten

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18265

--- Comment #14 from Jonathan Druart  
---
(In reply to Olli-Antti Kivilahti from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > (In reply to Jonathan Druart from comment #7)
> > > You are going too far with this patch, we need a quick patch to fix the 
> > > data
> > > lost when deleting a bibliographic record,
> 
> I have to disagree. You need properly implemented features, not small steps
> and quick fixes.

Yes and that is something you did not understand yet, but I am sure you will at
some point.
That is exactly why you do not manage to get your patches pushed.
Small steps are the way to go if you want your changes to be integrated.
On this bug report you are addressing to many different points, you are just
slowing down its move.

I will take care of the moveto deletedbiblio_metadata.

Thanks for the try!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #30 from Lari Taskula  ---
(In reply to Lari Taskula from comment #29)
> Rewritten, now Mojolicious::Plugin::OpenAPI compatible.

Forgot to include this in the previous comment - Additional note for testers:
requires JSON::Validator version 0.96, otherwise tests fail for the following
reason: 

GET /api/v1/items/340856 [{"message":"Does not match date-time
format.","path":"\/timestamp"},{"message":"anyOf failed: Does not match
date-time format.","path":"\/itemlost_on"},{"message":"anyOf failed: Does not
match date-time format.","path":"\/withdrawn_on"}].

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

--- Comment #169 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #168)
> For efficiency. If you think it makes more sense to have all libraries in
> all subgroups selected as well I'd be happy to change it.

To me it does not make sense not to go all over the whole tree, I think it
would be good to get other opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #10 from Jonathan Druart  
---
Created attachment 61180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61180=edit
Bug 18276: Remove GetBiblioFromItemNumber - Easy ones

The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several
reasons:
- badly named, we can get biblio info from a barcode
- SELECT * from items, biblio and biblioitems
makes things hard to follow and debug, we never know where do come from
the value we display
- sometimes called only for trivial information such as biblionumber,
author or title

This patchset suggests to replace it with calls to:
- Koha::Items->find for item's info
- $item->biblio for biblio's info
- $item->biblio->biblioitem for biblioitem's info

Test plan:
Item's info should correctly be displayed on the following pages:
- circulation history
- transfer book
- checkin
- waiting holds

QA will check the other changes reading the code, it's trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #11 from Jonathan Druart  
---
Created attachment 61181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61181=edit
Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber subroutine

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #61122|0   |1
is obsolete||
  Attachment #61123|0   |1
is obsolete||
  Attachment #61124|0   |1
is obsolete||
  Attachment #61125|0   |1
is obsolete||
  Attachment #61126|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 61177
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61177=edit
Bug 18276: Remove GetBiblioFromItemNumber - Course reserves

Values from the items, biblio and biblioitems tables are used in the template,
so we need to pass all of them to the template, but separately.
That way we easily see which field from which table we are displaying.

Test plan:
Create a course reserve and add items.
Correct information must be displayed on the detail page of the course
reserve, on staff and OPAC interface.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #9 from Jonathan Druart  
---
Created attachment 61179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61179=edit
Bug 18276: Remove GetBiblioFromItemNumber - circulation pages

Test plan:
1. Checkout items in a batch
The information displayed should be ok (title, subtitles, author,
itemnotes, barcode)
2. Checkout an item using the standard checkout page
You should correctly see the information of the item that has been
checked out (title and author)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #8 from Jonathan Druart  
---
Created attachment 61178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61178=edit
Bug 18276: Remove GetBiblioFromItemNumber - ILSDI

Test plan:
Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=51_holds=1
The results should be the same before and after this patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

--- Comment #29 from Lari Taskula  ---
Rewritten, now Mojolicious::Plugin::OpenAPI compatible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56293|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56292|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff
 Depends on|15126   |18137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126
[Bug 15126] REST API: Use newer version of Swagger2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137
[Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to
Mojolicious::Plugin::OpenAPI
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Lari Taskula  changed:

   What|Removed |Added

  Attachment #56290|0   |1
is obsolete||

--- Comment #28 from Lari Taskula  ---
Created attachment 61176
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61176=edit
Bug 16825: Add API route for getting an item

GET /api/v1/items/{itemnumber} Gets one Item

This patch adds route to get one item from koha.items table. This table has
a column "itemnotes_nonpublic", which should not be returned if the user has no
catalogue permission.

The OpacHiddenItems syspref restriction is considered for users who are not
staff.
They see "Item Not Found" when trying to view item hidden from OPAC. Only staff
can see those items.

To test:
1. Apply patch
2. Open a browser tab on Koha staff and log in (to create CGISESSID
   cookie).
3. Send GET request to http://yourlibrary/api/v1/items/YYY
   where YYY is an existing itemnumber.
4. Make sure the returned data is correct.
5. Run unit tests in t/db_dependent/api/v1/items.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Lari Taskula  changed:

   What|Removed |Added

 Blocks||16825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825
[Bug 16825] REST API: Add API route for getting an item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15126] REST API: Use newer version of Swagger2

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15126

Lari Taskula  changed:

   What|Removed |Added

 Blocks|16825   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825
[Bug 16825] REST API: Add API route for getting an item
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18279] C4::Items - Remove GetLostItems

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18278
 Status|Patch doesn't apply |Needs Signoff

--- Comment #3 from Jonathan Druart  
---
Forgot to add the dependency, sorry.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278
[Bug 18278] C4::Items - Remove GetItemLocation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18278] C4::Items - Remove GetItemLocation

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18278

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18279


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18279
[Bug 18279] C4::Items - Remove GetLostItems
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17479] REST API: Save information on owner access

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479

Lari Taskula  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283

--- Comment #1 from Nick Clemens  ---
Created attachment 61175
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61175=edit
Bug 18283 - Display improvements on report results - hide code and change
wording

This patch makes small display improvements to the report results page.

-Add toggle link for SQL code
-Change results count wording
-Add 'Notes:' label report notes

To test:
1 - Apply patch
2 - Run some reports
3 - Check that results page makes sense
4 - Hide and display code and ensure toggle works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17479] REST API: Save information on owner access

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479

--- Comment #9 from Lari Taskula  ---
Rebased on top of Bug 18137. To test, first apply Bug 18137, then this one, and
run tests. Removed sign-offs as the test file was heavily rewritten.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17479] REST API: Save information on owner access

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479

Lari Taskula  changed:

   What|Removed |Added

 Depends on||18137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137
[Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to
Mojolicious::Plugin::OpenAPI
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Lari Taskula  changed:

   What|Removed |Added

 Blocks||17479


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479
[Bug 17479] REST API: Save information on owner access
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17479] REST API: Save information on owner access

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17479

Lari Taskula  changed:

   What|Removed |Added

  Attachment #57286|0   |1
is obsolete||

--- Comment #8 from Lari Taskula  ---
Created attachment 61174
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61174=edit
Bug 17479: Store information on owner access into $c->stash

There are two ways of accessing a resource via REST API; either:
- you have the required permission
- you do not have the permission but you are owner of the object, e.g. you want
  to GET your own patron information

In many cases we want to perform additional operations if the user is accessing
his
own object. Usually this additional operation is checking a system preference.

Example: Patron wants to update his own patron information via REST API. We
have to
check OPACPatronDetails system preference for this. If it is on, we should
forward
the changes for approval from a librarian.

Currently, in controller, we can check this opac-like access by checking that
the
user does not have permissions and that the patron he is accessing is himself.
This
would require another haspermission() call.

Instead, we could set a flag into $c->stash in Koha/REST/V1.pm in the case of
ownership access. After this, in controller, we only need to check $c->stash
for
this flag.

To test:
1. Apply patch
2. Run t/db_dependent/api/v1/ownerflag.t
3. Observe it pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18283] Display improvements on report results - hide code and change wording

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283

Nick Clemens  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18283] New: Display improvements on report results - hide code and change wording

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18283

Bug ID: 18283
   Summary: Display improvements on report results - hide code and
change wording
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

--- Comment #8 from Nick Clemens  ---
Created attachment 61173
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61173=edit
Bug 16187 - (QA followup) Tidy, add confirm, minor changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

--- Comment #10 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #7)
> Nick, do you have any good reasons to use DateTime instead of dt_from_string
> to get today's date?
Nope, was a copy paste job


> Note that you could have use
> Koha::Libraries->search->get_column('branchcode') to get an iterator on the
> branchcodes.
Advice taken


> Please resubmit tidying the whole file.
Done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

--- Comment #9 from Nick Clemens  ---
(In reply to Liz Rea from comment #6)
> I feel like this needs some safeguards.
> 
> Cheers,
> Liz

I added a 'confirm' option so this can be run to see what would be deleted
before going through with the deletion, is there another specific feedback you
would like to see?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18078] Updating buttons for z39.50 Authority search

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078

Marc Véron  changed:

   What|Removed |Added

  Attachment #60002|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 61172
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61172=edit
Bug 18078: Updating buttons for z39.50 Authority search

1) Go to Home > Authorities -> New from Z39.50
2) Notice how Search button is strangely off page (have to scroll down
to see it)
3) Do a search, noticing the ugly buttons from Comment 1
4) Apply patch and go back to a new search
5) Do a search again, notice no longer need to scroll to get to Search
button and new, nicer buttons
6) Confirm they still work as expected

Sponsored-by: Catalyst IT

Testplan changed to test with Authorities. Z39.50 search for authorities
displays and Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18206] REST API: Default exception handling

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula  changed:

   What|Removed |Added

  Attachment #61088|0   |1
is obsolete||

--- Comment #6 from Lari Taskula  ---
Created attachment 61171
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61171=edit
Bug 18206: Use this feature for cities

To test:
1. prove t/db_dependent/api/v1/cities.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18206] REST API: Default exception handling

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18206

Lari Taskula  changed:

   What|Removed |Added

  Attachment #61087|0   |1
is obsolete||

--- Comment #5 from Lari Taskula  ---
Created attachment 61170
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61170=edit
Bug 18206: Default exception handling for REST API

Many of our operations in REST API controllers now use try-catch blocks to
catch
exceptions and handle them appropriately. This is great, but we should
introduce
a centralized way of handling default HTTP 500 errors. Currently they are
checked
over and over again in each operation. As an example this same lovely poem, in
many cases, is currently replicated for each operation:

sub list {
  ...
  try {
blabla
  } catch {
# This should stay here, custom error handling for this particular
operation
if ($_->isa('Koha::Exceptions::Patron::Something')) {
   return $c->render(status => 400, openapi => { error => $_->error });
}
# But the checks below can be centralized!
elsif ($_->isa('DBIx::Class::Exception')) {
   return $c->render(status => 500, openapi => { error => $_->{msg} });
}
elsif ($_->isa('Koha::Exceptions::Exception')) {
   return $c->render(status => 500, openapi => { error => $_->error });
}
else {
   return $c->render(status => 500, openapi => { error =>
 "Something went wrong, check the logs." });
}
  };
}

Instead, my proposal for a more centralized solution is to use a before_render
hook to catch all of the default exceptions before rendering that are expected
to return a 500, logging the error and displaying an appropriate error message
in response body. After this patch, the above example would then look like
this:

sub list {
  ...
  try {
blabla
  } catch {
# This should stay here, custom error handling for this particular
operation
if ($_->isa('Koha::Exceptions::Patron::Something')) {
   return $c->render(status => 400, openapi => { error => $_->error });
}
# Simply rethrow the exception with the help of below function - it will
then
# be handled in before_render hook
Koha::Exceptions::rethrow_exception($_);
  };
}

What does this patch actually do?

After this patch, in case of an exception, we will normally visit the
catch-block.
If none of the specified Koha::Exceptions match the thrown $_, we will now
rethrow
the exception. This does not crash the whole app, but forwards the exception
eventually into our before_render hook at
Koha::REST::V1::handle_default_exceptions.
There, we are able to customize our way of handling these exceptions. In this
patch
I have added an error logging there. We should also discuss whether we want to
display a detailed error message, or simply "Something went wrong, check the
logs."
for all of the default exceptions. Perhaps this could be controlled by some
sort
of configuration for development/production (e.g. MOJO_MODE) ?

To test:
1. prove t/db_dependent/api
2. prove t/Koha/Exceptions.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 140 matches

Mail list logo