[Koha-bugs] [Bug 18242] Remove primary key on old_issues.issue_id

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242

--- Comment #17 from Fred  ---
Please I have problems in the loans, I deleted the circulation history, please
in what files should I make the changes ?. What change should I make in the
database ?. I have version 16.11.06

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #61866|0   |1
is obsolete||

--- Comment #9 from Srdjan Jankovic  ---
Created attachment 61932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61932=edit
Bug 17602 Add Oneclickdigital integration to Koha

Add OneClickdigital to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
Oneclickdigital)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18393] Canned report reports/ acquisitions_stats.pl not filtering correctly by collection code

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393

Barton Chittenden  changed:

   What|Removed |Added

   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18393] Canned report reports/ acquisitions_stats.pl not filtering correctly by collection code

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393

--- Comment #2 from Barton Chittenden  ---
Created attachment 61931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61931=edit
Report results, choose collection code 'music only'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18393] Canned report reports/ acquisitions_stats.pl not filtering correctly by collection code

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393

--- Comment #1 from Barton Chittenden  ---
Created attachment 61930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61930=edit
Report results, all collection codes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18393] New: Canned report reports/ acquisitions_stats.pl not filtering correctly by collection code

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393

Bug ID: 18393
   Summary: Canned report reports/acquisitions_stats.pl not
filtering correctly by collection code
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 61929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61929=edit
report settings

The canned report under Home › Reports › Acquisitions statistics is not
filtering on collection code.

To replicate:

'Received on'
check 'row'
Filter: From: 01/01/2016 To: 12/31/2016
(or use a date range that corresponds to acquisitions on your system)

'Collection code'
check 'column'
Filter: Select 'All'

Cell value
Choose 'Count items'

Output
Choose 'To screen into the browser'

Click Submit.

You will see columns of collection codes, with each row being a separate date.
All collection codes will be displayed.

Use the browser's back button, change the collection code

'Collection code'
check 'column'
Filter: Select 'Music'
(or a collection code on your system)

Click submit.

We would expect to see a single column showing the 'Music' collection code --
instead we see all collection codes again.

See screenshots for report settings and output.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14620] Contact information validations

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

--- Comment #21 from Marc Véron  ---
Hi Lari

Validation of phone number works fine with the exception of 
- Fax number
- Phone number in Alternative contact 
(both Staff client and OPAC)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18392] New: Allow importing/ exporting circulation conditions as CSV or spreadsheet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392

Bug ID: 18392
   Summary: Allow importing/exporting circulation conditions as
CSV or spreadsheet
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

As our circulation GUI is not perfect (yet) it would be nice if it offered a
similar feature to the bibliographic frameworks, allowing to export/import the
rules using CSV or spreadsheet files.

This would make it much easier to update rules in bulk and keep track of
changes to them as you could archive different versions easily too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18392] Allow importing/ exporting circulation conditions as CSV or spreadsheet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18392

Katrin Fischer  changed:

   What|Removed |Added

Version|16.11   |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18391] New: Error: You do not have permission to access this page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18391

Bug ID: 18391
   Summary: Error: You do not have permission to access this page.
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: Linux
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Authentication
  Assignee: gmcha...@gmail.com
  Reporter: fcuel...@biteca.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

Created attachment 61928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61928=edit
Remove "index.html" to enter

When you enter the administrator with the corresponding credentials the
following error appears: "Error: You do not have permission to access this
page." But when deleting "/index.html" from the url starts normally.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18387] 404 errors on page causes SCO user to be logged out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387

Nick Clemens  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

Marc Véron  changed:

   What|Removed |Added

  Attachment #61845|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

--- Comment #8 from Marc Véron  ---
Created attachment 61927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61927=edit
Bug 17814: koha-plack --stop should make sure that Plack really stop

Followed test plan in comment #5.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16885] koha-stop-zebra should be more sure of stopping zebrasrv

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16885

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17814

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=16885

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17814] koha-plack --stop should make sure that Plack really stop

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17814

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #100 from Jacek Ablewicz  ---
I have tested a bit earlier version of this patchset (from a ~week ago - not
exactly following the test plans, but focusing on the possibly "scary stuff"
which was not directly covered by the tests instead), and by a look of it there
is no need to fully retest it again. I reviewed all the changes in the code
once more (well, except for the *.t files, to be honest), and they all look
pretty solid to me - the only issue encountered in the previous try got fixed
in the meanwhile. Sign off time ;).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17465] Add a System Preference to control number of Saved Reports displayed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17465

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17465] Add a System Preference to control number of Saved Reports displayed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17465

Marc Véron  changed:

   What|Removed |Added

  Attachment #61864|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 61926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61926=edit
Bug 17465: NumSavedReports syspref

To test:
1) Apply patch and update database
2) Go to system preferences. Default value should be 20 reports.
3) Go to Reports -> Use saved. Confirm 20 results are showing
4) Change value in syspref to any integer (i.e. 50)
5) Go back to Reports -> Use saved. Confirm the number of results shown
is based on the value in the syspref.

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #22 from Marc Véron  ---
I tried to test  "Example usage of I18N Template::Toolkit plugin" , using the
test plan from comment #7

After perl translate update fr-FR, I edited: 
koha/misc/translator/po/fr_FR/LC_MESSAGES/Koha.po
translated the strings and changed the line:
"Plural-Forms: nplurals=INTEGER; plural=EXPRESSION;\n"
to:
"Plural-Forms: nplurals=2; plural=(n > 1);\n"

However, perl translate install fr-FR complains with following warnings:

Use of uninitialized value $pref_name in concatenation (.) or string at
LangInstaller.pm line 202.
Use of uninitialized value $pref_name in concatenation (.) or string at
LangInstaller.pm line 244.
NO PLURAL FORM HEADER FOUND - DEFAULTING TO 2
print() on closed filehandle $fh at LangInstaller.pm line 689.

What did I miss?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61904|0   |1
is obsolete||

--- Comment #99 from Jacek Ablewicz  ---
Created attachment 61925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61925=edit
Bug 9988: Add the cronjob and print an upgrade message

The Debian cron file and the misc crontab example are updated.
A message is printed when upgrading.

Note: At this moment the merge cron job is run once a day. This is imo a
good starting point. The load for this job greatly depends on the value of
pref AuthorityMergeLimit. Of course you can schedule the job more often,
and if this need is felt more globally, we can adjust it later.

Test plan:
[1] Run the dbrev and see the message.
[2] Read the changes to the cron files.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61901|0   |1
is obsolete||

--- Comment #96 from Jacek Ablewicz  ---
Created attachment 61922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61922=edit
Bug 9988: Add a subtest for specific postponed merge issues

This subtest shows that we need a few little tweaks to make merge
work in some specific postponed merge situations.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t.
The last subtest should fail.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61899|0   |1
is obsolete||

--- Comment #94 from Jacek Ablewicz  ---
Created attachment 61920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61920=edit
Bug 9988: Check the merge limit in sub merge

At this point, we are replacing dontmerge functionality by the new
AuthorityMergeLimit logic. Instead of doing this check before calling
merge, we just call merge and check it there. In order to let the cron
job do the larger (postponed) merges, we add a parameter override_limit.

A subtest is added in Merge.t to test the 'postponed merge' feature. Since
merge now also calls get_usage_count, an additional mock is added. All
references to dontmerge are removed.

In merge two lines, initializing $dbh and $counteditbiblios, are moved.
The dontmerge test in DelAuthority and ModAuthority is removed. Since this
did not leave much in ModAuthority, I fixed the whitespace on the remaining
lines rightaway (yes, I know).
A minimal set of changes is applied to the cron script; it will get further
attention on a next patch.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t
[2] Set AuthorityMergeLimit to 2. Modify an authority with two linked
biblios. Check that the merge was done immediately.
[3] Now modify an authority with more than 2 linked records.
Verify that the merge was postponed; a record must be inserted in
the need_merge_authorities table.
[4] Testing of the merge cron job is *postponed* to a next patch.
Note: I tested a modification, but the script just needs more
attention.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61903|0   |1
is obsolete||

--- Comment #98 from Jacek Ablewicz  ---
Created attachment 61924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61924=edit
Bug 9988: Refactor the cron script

The cron job is moved from migration tools to cronjobs. And renamed to
a plural form. The script is now based on Koha objects. It does no longer
include the code to merge one record. This can be done via the interface,
and will be added to a maintenance script on bug 18071. Should not be part
of this cron job.

Adding a cron_cleanup method to MergeRequests; this method is called from
the cron script to reset older entries still marked in progress and to
also remove old processed entries. Tested in a separate unit test.

Test plan:
[1] Run t/db_dependent/Authorities/MergeRequests.t
[2] Set AuthorityMergeLimit to 0. (All merges are postponed.)
[3] Modify an authority linked to a few records.
[4] Delete an authority linked to a few records with batch delete tool.
[5] And select two auth records with linked records.
Merge these two records with authority/merge.pl.
Note: Do not select Default. See also bug 17380.
[6] Check the need_merge_authorities table for inserted records.
[7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked
records and the record status in need_merge_authorities.

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61900|0   |1
is obsolete||

--- Comment #95 from Jacek Ablewicz  ---
Created attachment 61921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61921=edit
Bug 9988: Remove further references to dontmerge

[1] The preference was sent to HEA. We can now send both AuthorityMergeMode
as well as AuthorityMergeLimit.
[2] A comment in authorities/merge.pl is removed. Note that a subsequent
patch will modify and test the cron job.
[3] Script misc/batchRebuildItemsTables.pl temporarily enabled dontmerge.
This is equivalent to setting the mergelimit to zero.
The function defnonull is no longer needed. (If the pref was NULL,
we restore that value. Sub merge won't mind.)

Test plan:
[1] Run t/db_dependent/UsageStats.t
[2] Run misc/batchRebuildItemsTables.pl -t
This just ensures you it still compiles; the changes speak for itself.
[3] Now git grep on dontmerge.
You should only find hits in atomicupdate and misc/translator/po.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61902|0   |1
is obsolete||

--- Comment #97 from Jacek Ablewicz  ---
Created attachment 61923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61923=edit
Bug 9988: Few subtle changes for postponed merge

The fails in the previous test showed that we need the first three
changes here. Some final polishing in points 4 to 6.

[1] Sub merge: Refine the condition for initializing $tags_new.
A postponed 'modify'-merge (A to B) makes that $authtypefrom is not
defined when running merge later. When crossing the type boundary, we
need a new field too.
[2] Sub merge: Add condition for an empty @record_to array.
This indicates also that a field should be removed, since we should
otherwise only add a $9 subfield.
[3] Sub merge: Adjust initializing @record_from.
This change is tested by verifying a cleared subfield in the test.
[4] DelAuthority: Adding a skipmerge parameter to allow the call from
authorities/merge.pl to skip an unneeded merge.
This also prevents that the 'delete-merge' would precede the
'modify-merge' under a hypothetical race condition.
[5] DelAuthority: There is actually no need to call GetAuthority.
The subfields of the old record are not relevant in this case.
[6] Added a few POD lines to merge.
[7] Removed a trailing space in a comment line in merge.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t.
The last subtest should no longer fail now.
[2] See test plan of next patch.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61892|0   |1
is obsolete||

--- Comment #88 from Jacek Ablewicz  ---
Created attachment 61914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61914=edit
Bug 9988: DBIx schema changes for need_merge_authorities

As generated by misc/devel/update_dbix_class_files.pl.
No test plan.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61895|0   |1
is obsolete||

--- Comment #91 from Jacek Ablewicz  ---
Created attachment 61917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61917=edit
Bug 9988: Add get_usage_count and linked_biblionumbers to Koha::Authority

When replacing the Zebra code in sub merge, we actually need CountUsage
as well as the results it gets from SearchEngine.

In order to get count and/or results, we now create:

[1] instance methods get_usage_count and linked_biblionumbers in
Koha::Authority,
[2] class methods of the same name in Koha::Authorities.

The instance method calls the class method. The class method can be used
for deleted authority records, and in 'legacy calls' before refactoring.

Note: On BZ 18149 we will replace all CountUsage calls.

Test plan:
Run t/db_dependent/Koha/Authorities.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61898|0   |1
is obsolete||

--- Comment #93 from Jacek Ablewicz  ---
Created attachment 61919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61919=edit
Bug 9988: Remove the Zebra code from sub merge

Since we can now call linked_biblionumbers, we can now remove all Zebra
related code from merge. We also add a parameter biblionumbers; we use it
in the test now, but it may be handy too later in the maintenance script
when we want to trigger a merge for specific biblionumber(s). See bug
report 18071.

All mocks for ZOOM, Context::Zconn, Search::new_record_for_zebra in the
merge test can now be replaced by one mock for linked_biblionumbers. Note
that we test the biblionumbers parameter in the last subtest without that
mock.

Remove unused vars $countunmodifiedbiblio, $counterrors from merge.
Renamed zebrarecords to linkedrecords in the Merge test.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t
[2] Modify an authority record. Check the linked biblio records.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61891|0   |1
is obsolete||

--- Comment #87 from Jacek Ablewicz  ---
Created attachment 61913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61913=edit
Bug 9988: Table revision for need_merge_authorities

In order to let merge do exactly the same when called from the merge
cron job, we need three additional fields in the table. The use of these
fields will be explained in a follow-up.

Test plan:
Run the dbrev (updatestructure step in webinstaller).

Signed-off-by: Marcel de Rooy 
Also tested running kohastructure.sql for this table.

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61893|0   |1
is obsolete||

--- Comment #89 from Jacek Ablewicz  ---
Created attachment 61915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61915=edit
Bug 9988: Add Koha objects for table need_merge_authorities

This patch adds two Koha objects: MergeRequest(s).
MergeRequest has a new method and an oldmarc method.
A class method reporting_tag_xml is added to MergeRequests.pm.
All new routines are tested in Authorities.t.

Removes a few unneeded modules from Koha::Authority.

Test plan:
Run t/db_dependent/Koha/Authorities.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61890|0   |1
is obsolete||

--- Comment #86 from Jacek Ablewicz  ---
Created attachment 61912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61912=edit
Bug 9988: Database revision for AuthorityMergeLimit

Introduce the new preference and remove dontmerge.
If dontmerge was enabled, the new pref will be set to zero and we will
print a message about raising this value now.

Test plan:
Run the database revision or a new install.
In case of an upgrade, check the new pref value. Should be 0 when
dontmerge was enabled, otherwise 50.

Signed-off-by: Marcel de Rooy 
Also tested sysprefs.sql on a new database.

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61897|0   |1
is obsolete||

--- Comment #92 from Jacek Ablewicz  ---
Created attachment 61918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61918=edit
Bug 9988: Merge should have a parameter hash

We will need a few additional parameters for merge later on. This patch
puts the original parameters in a parameter hash.
For the same reason DelAuthority gets a parameter hash here.

Note: We remove the second parameter from the DelAuthority call in
authorities/authorities-home.pl here. It was not used and could have
presented problems in the future.

Test plan:
[1] Run t/db_dependent/AuthoritiesMarc.t.
[2] Run t/db_dependent/Authorities/Merge.t.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Jacek Ablewicz  changed:

   What|Removed |Added

  Attachment #61894|0   |1
is obsolete||

--- Comment #90 from Jacek Ablewicz  ---
Created attachment 61916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61916=edit
Bug 9988: Add extract_biblionumber to Koha/SearchEngine

When we will replace the Zebra code in sub merge, we will call SearchEngine
to pass records and we need a routine to extract a biblionumber from
a search result record. A record from Zebra still must be converted to
MARC::Record. This is no longer needed for a ElasticSearch record.

Test plan:
Run t/db_dependent/Koha/SearchEngine/Search.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 
Signed-off-by: Jacek Ablewicz 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] New: bulkmarcimport.pl does not take notice of MARC modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Bug ID: 18389
   Summary: bulkmarcimport.pl does not take notice of MARC
modification templates
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: gmcha...@gmail.com
  Reporter: j.p.kni...@lboro.ac.uk
QA Contact: testo...@bugs.koha-community.org

Created attachment 61907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61907=edit
Patch for bulkmarcimport.pl

When importing large numbers of MARC records from a legacy LMS to Koha we
needed to convert some of 852 fields to 952 fields for item holdings.  I'd
created MARC modification templates in the web administration front end, but
the bulkmarcimport.pl migration tool doesn't use these. 

Joubu on the #koha IRC channel told me that this was because bulkmarcimport.pl
was written before C4::MarcModificationTemplates.pm Perl module was available.

The change is actually relatively easy and I've attached a diff patch to this
case for others to contemplate and critic.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388

Alex Arnaud  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388

Alex Arnaud  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |alex.arn...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388

--- Comment #1 from Alex Arnaud  ---
Created attachment 61906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61906=edit
Bug 18388 - Standardize serials volume information displaying

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18388] New: Standardize serials volume information displaying in OPAC and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388

Bug ID: 18388
   Summary: Standardize serials volume information displaying in
OPAC and staff
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: alex.arn...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

On the opac-detail page, volume information for serial does not take into
account serialseq or published date. This is the on the staff side.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #24 from Baptiste  ---
Created attachment 61905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61905=edit
Bug 17047: Add report, factorize code, add a comment feature

Interface :
- On mana-search, rows are now sorted by date of last import, then by number of
users
- Windows redisigned to improve the user experience
- New Feature : report a record.
 - peoples can now report a weird report
 - if a record is reported a lot of time, it will appear differently
- Added few tooltip (to explain the fields last import, nb of users, to explain
  the new feature)
- Added the syspref "AutoShareWithMana", which enables to select which fields
  you want to share automatically with mana

API (svc/mana)
- add svc/mana/addvaluetofield: allows to ask mana incrementing a field of a
resource
- no hardcoding for resources in the code of api (api needs to be called with a
ressourcename)

- Factorize a lot of code in order to improve the speed of next developments

SytemPreferences:
Mana Activation:
- add a field "no, let me think" at the syspref "Mana"
- as long as this field is selected, messages ask if user want to activate
it
messages in pages:
- Administration
- Add-subscription(page 2)
AutoShareWithMana
- Add the syspref AutoShareWithMana: user can automatically share infos
with mana (automatically not set)

Report Share
- Create Koha::Report.pm and Koha::Reports.pm, objects class for Reports
- New feature: share reports with Mana
- New feature: search report in Mana Knowledge Base with keywords
- New feature: load reports from Mana

Comment Resources
- The comments can now be manually added
- On a resource mana datatable, you can now see comments, add comment and vote
for comments you think pertinent
- Comments are NOT dynamically generated on the table you need to reload the
page when you vote

Test plan:
1 - Apply Patch + update database
2 - Copy the three lines about mana config in etc/koha-conf.xml in
../etc/koha-conf.xml
3 - Check Mana syspref and AutoShareWithMana syspref are not activated

4 - subscriptions
- Try create a new subscription for a first serial  => mana shouldn't show you
anything (except if the base hase been filled)
- Share this serial with Mana (on the serial individual's page there must be a
Share button)
- Try to create a new subscription for serial nr1 => a message should appear
when you click on "next", click on "use", the fields should automaticaly appear
- Activate AutoShareWithMana => Subscriptions
- Create a new subscription for a second serial
- There shouldn't be any Share button
- Create a second subscription => the message should appear, click again on use

5 - Report
- Create a new report, without notes.
- On the table with all report (reports > use saved), there should be the
action "Share"
- If you click on share, you have an error message
- Create a new report, with a title and notes longer than 20 characters
- You  can share it with mana => you will have a success message
- On (report > use saved), there must be a message inviting you to search on
mana KB for more results, enter a few word from title, notes, type of  the
report you shared, it should appear. You can use it, it will load it into your
report list.

6 - Comments.
- On any table containing mana search results, you can comment. To comment,
click on report mistake. For now, you only can chose "other".
- If you click other, a new textbox appears. Enter a short comment.
- Reload the whole page, the comment should appear in the menu and in the
comment column.
- If you select a comment and reload the whole page, there should be one more
comment with this name
- If you select a comment and click on cancel just after, there shouldn't be
any change when you reload.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #85 from Marcel de Rooy  ---
(In reply to Marc Véron from comment #70)
> Went through test plans from comment #68 and comment #69, works as described.

Great, Marc ! Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61792|0   |1
is obsolete||

--- Comment #84 from Marc Véron  ---
Created attachment 61904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61904=edit
Bug 9988: Add the cronjob and print an upgrade message

The Debian cron file and the misc crontab example are updated.
A message is printed when upgrading.

Note: At this moment the merge cron job is run once a day. This is imo a
good starting point. The load for this job greatly depends on the value of
pref AuthorityMergeLimit. Of course you can schedule the job more often,
and if this need is felt more globally, we can adjust it later.

Test plan:
[1] Run the dbrev and see the message.
[2] Read the changes to the cron files.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61791|0   |1
is obsolete||

--- Comment #83 from Marc Véron  ---
Created attachment 61903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61903=edit
Bug 9988: Refactor the cron script

The cron job is moved from migration tools to cronjobs. And renamed to
a plural form. The script is now based on Koha objects. It does no longer
include the code to merge one record. This can be done via the interface,
and will be added to a maintenance script on bug 18071. Should not be part
of this cron job.

Adding a cron_cleanup method to MergeRequests; this method is called from
the cron script to reset older entries still marked in progress and to
also remove old processed entries. Tested in a separate unit test.

Test plan:
[1] Run t/db_dependent/Authorities/MergeRequests.t
[2] Set AuthorityMergeLimit to 0. (All merges are postponed.)
[3] Modify an authority linked to a few records.
[4] Delete an authority linked to a few records with batch delete tool.
[5] And select two auth records with linked records.
Merge these two records with authority/merge.pl.
Note: Do not select Default. See also bug 17380.
[6] Check the need_merge_authorities table for inserted records.
[7] Run misc/cronjobs/merge_authorities.pl -b and inspect the linked
records and the record status in need_merge_authorities.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7419] Add authority deduplication script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61790|0   |1
is obsolete||

--- Comment #82 from Marc Véron  ---
Created attachment 61902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61902=edit
Bug 9988: Few subtle changes for postponed merge

The fails in the previous test showed that we need the first three
changes here. Some final polishing in points 4 to 6.

[1] Sub merge: Refine the condition for initializing $tags_new.
A postponed 'modify'-merge (A to B) makes that $authtypefrom is not
defined when running merge later. When crossing the type boundary, we
need a new field too.
[2] Sub merge: Add condition for an empty @record_to array.
This indicates also that a field should be removed, since we should
otherwise only add a $9 subfield.
[3] Sub merge: Adjust initializing @record_from.
This change is tested by verifying a cleared subfield in the test.
[4] DelAuthority: Adding a skipmerge parameter to allow the call from
authorities/merge.pl to skip an unneeded merge.
This also prevents that the 'delete-merge' would precede the
'modify-merge' under a hypothetical race condition.
[5] DelAuthority: There is actually no need to call GetAuthority.
The subfields of the old record are not relevant in this case.
[6] Added a few POD lines to merge.
[7] Removed a trailing space in a comment line in merge.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t.
The last subtest should no longer fail now.
[2] See test plan of next patch.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61789|0   |1
is obsolete||

--- Comment #81 from Marc Véron  ---
Created attachment 61901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61901=edit
Bug 9988: Add a subtest for specific postponed merge issues

This subtest shows that we need a few little tweaks to make merge
work in some specific postponed merge situations.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t.
The last subtest should fail.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61788|0   |1
is obsolete||

--- Comment #80 from Marc Véron  ---
Created attachment 61900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61900=edit
Bug 9988: Remove further references to dontmerge

[1] The preference was sent to HEA. We can now send both AuthorityMergeMode
as well as AuthorityMergeLimit.
[2] A comment in authorities/merge.pl is removed. Note that a subsequent
patch will modify and test the cron job.
[3] Script misc/batchRebuildItemsTables.pl temporarily enabled dontmerge.
This is equivalent to setting the mergelimit to zero.
The function defnonull is no longer needed. (If the pref was NULL,
we restore that value. Sub merge won't mind.)

Test plan:
[1] Run t/db_dependent/UsageStats.t
[2] Run misc/batchRebuildItemsTables.pl -t
This just ensures you it still compiles; the changes speak for itself.
[3] Now git grep on dontmerge.
You should only find hits in atomicupdate and misc/translator/po.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61787|0   |1
is obsolete||

--- Comment #79 from Marc Véron  ---
Created attachment 61899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61899=edit
Bug 9988: Check the merge limit in sub merge

At this point, we are replacing dontmerge functionality by the new
AuthorityMergeLimit logic. Instead of doing this check before calling
merge, we just call merge and check it there. In order to let the cron
job do the larger (postponed) merges, we add a parameter override_limit.

A subtest is added in Merge.t to test the 'postponed merge' feature. Since
merge now also calls get_usage_count, an additional mock is added. All
references to dontmerge are removed.

In merge two lines, initializing $dbh and $counteditbiblios, are moved.
The dontmerge test in DelAuthority and ModAuthority is removed. Since this
did not leave much in ModAuthority, I fixed the whitespace on the remaining
lines rightaway (yes, I know).
A minimal set of changes is applied to the cron script; it will get further
attention on a next patch.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t
[2] Set AuthorityMergeLimit to 2. Modify an authority with two linked
biblios. Check that the merge was done immediately.
[3] Now modify an authority with more than 2 linked records.
Verify that the merge was postponed; a record must be inserted in
the need_merge_authorities table.
[4] Testing of the merge cron job is *postponed* to a next patch.
Note: I tested a modification, but the script just needs more
attention.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61786|0   |1
is obsolete||

--- Comment #78 from Marc Véron  ---
Created attachment 61898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61898=edit
Bug 9988: Remove the Zebra code from sub merge

Since we can now call linked_biblionumbers, we can now remove all Zebra
related code from merge. We also add a parameter biblionumbers; we use it
in the test now, but it may be handy too later in the maintenance script
when we want to trigger a merge for specific biblionumber(s). See bug
report 18071.

All mocks for ZOOM, Context::Zconn, Search::new_record_for_zebra in the
merge test can now be replaced by one mock for linked_biblionumbers. Note
that we test the biblionumbers parameter in the last subtest without that
mock.

Remove unused vars $countunmodifiedbiblio, $counterrors from merge.
Renamed zebrarecords to linkedrecords in the Merge test.

Test plan:
[1] Run t/db_dependent/Authorities/Merge.t
[2] Modify an authority record. Check the linked biblio records.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10295] add the ability to sort and filter batch of records in Staged Records Management Tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10295

--- Comment #3 from Alexandre  ---
Hi,

Some staff users have difficulty too to find their staged MARC records when
they have a big quantity loaded into their system. 

Path :
1) Go to "Tools" module
2) Go to "Staged MARC record management"
3) Observe that no research option are present in the board (no filter, no
advanced search)

A space for a dynamic search like the one for the board in the acquisition
module will be great. Or at least, up and down arrows in each title on the
upper line will be good too.

Thanks for helping,

Alexandre from CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10295] add the ability to sort and filter batch of records in Staged Records Management Tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10295

--- Comment #2 from Alexandre  ---
Created attachment 61896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61896=edit
Dynamic search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61785|0   |1
is obsolete||

--- Comment #77 from Marc Véron  ---
Created attachment 61897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61897=edit
Bug 9988: Merge should have a parameter hash

We will need a few additional parameters for merge later on. This patch
puts the original parameters in a parameter hash.
For the same reason DelAuthority gets a parameter hash here.

Note: We remove the second parameter from the DelAuthority call in
authorities/authorities-home.pl here. It was not used and could have
presented problems in the future.

Test plan:
[1] Run t/db_dependent/AuthoritiesMarc.t.
[2] Run t/db_dependent/Authorities/Merge.t.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61784|0   |1
is obsolete||

--- Comment #76 from Marc Véron  ---
Created attachment 61895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61895=edit
Bug 9988: Add get_usage_count and linked_biblionumbers to Koha::Authority

When replacing the Zebra code in sub merge, we actually need CountUsage
as well as the results it gets from SearchEngine.

In order to get count and/or results, we now create:

[1] instance methods get_usage_count and linked_biblionumbers in
Koha::Authority,
[2] class methods of the same name in Koha::Authorities.

The instance method calls the class method. The class method can be used
for deleted authority records, and in 'legacy calls' before refactoring.

Note: On BZ 18149 we will replace all CountUsage calls.

Test plan:
Run t/db_dependent/Koha/Authorities.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61783|0   |1
is obsolete||

--- Comment #75 from Marc Véron  ---
Created attachment 61894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61894=edit
Bug 9988: Add extract_biblionumber to Koha/SearchEngine

When we will replace the Zebra code in sub merge, we will call SearchEngine
to pass records and we need a routine to extract a biblionumber from
a search result record. A record from Zebra still must be converted to
MARC::Record. This is no longer needed for a ElasticSearch record.

Test plan:
Run t/db_dependent/Koha/SearchEngine/Search.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61782|0   |1
is obsolete||

--- Comment #74 from Marc Véron  ---
Created attachment 61893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61893=edit
Bug 9988: Add Koha objects for table need_merge_authorities

This patch adds two Koha objects: MergeRequest(s).
MergeRequest has a new method and an oldmarc method.
A class method reporting_tag_xml is added to MergeRequests.pm.
All new routines are tested in Authorities.t.

Removes a few unneeded modules from Koha::Authority.

Test plan:
Run t/db_dependent/Koha/Authorities.t

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18370] Columns settings patrons>id=memberresultst : display bug

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18370

--- Comment #9 from Jonathan Druart  
---
(In reply to Séverine Queune from comment #6)

> Thanks a lot Jonathan !!

Thank you for testing!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61781|0   |1
is obsolete||

--- Comment #73 from Marc Véron  ---
Created attachment 61892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61892=edit
Bug 9988: DBIx schema changes for need_merge_authorities

As generated by misc/devel/update_dbix_class_files.pl.
No test plan.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61780|0   |1
is obsolete||

--- Comment #72 from Marc Véron  ---
Created attachment 61891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61891=edit
Bug 9988: Table revision for need_merge_authorities

In order to let merge do exactly the same when called from the merge
cron job, we need three additional fields in the table. The use of these
fields will be explained in a follow-up.

Test plan:
Run the dbrev (updatestructure step in webinstaller).

Signed-off-by: Marcel de Rooy 
Also tested running kohastructure.sql for this table.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

  Attachment #61779|0   |1
is obsolete||

--- Comment #71 from Marc Véron  ---
Created attachment 61890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61890=edit
Bug 9988: Database revision for AuthorityMergeLimit

Introduce the new preference and remove dontmerge.
If dontmerge was enabled, the new pref will be set to zero and we will
print a message about raising this value now.

Test plan:
Run the database revision or a new install.
In case of an upgrade, check the new pref value. Should be 0 when
dontmerge was enabled, otherwise 50.

Signed-off-by: Marcel de Rooy 
Also tested sysprefs.sql on a new database.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

--- Comment #31 from sandbo...@biblibre.com  ---
Created attachment 61888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61888=edit
Bug 16892: Follow up with adding missing IGNORE

Signed-off-by: Eugene Jose Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

--- Comment #32 from sandbo...@biblibre.com  ---
Created attachment 61889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61889=edit
Bug 16892: Follow up use AddMember as per QA comment

Same Test plan as before.

Signed-off-by: Eugene Jose Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

--- Comment #30 from sandbo...@biblibre.com  ---
Created attachment 61887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61887=edit
Bug 16892: System Preferences

This adds the missing system preferences for a fresh install.

Signed-off-by: Eugene Jose Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

--- Comment #29 from sandbo...@biblibre.com  ---
Created attachment 61886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61886=edit
Bug 16892: Add automatic patron registration via OAuth2 login

10988 added the ability to log into the OPAC authenticating with
Google Open ID Connect. This extends it, by allowing an
unregistered patron to have an account automatically created
with default category code and branch.

This is accomplished by adding 3 system preferences.
- GoogleOpenIDConnectAutoRegister
  whether it will attempt to auto-register the patron.
- GoogleOpenIDConnectDefaultCategory
  This category code will be used to create Google OpenID Connect patrons.
- GoogleOpenIDConnectDefaultBranch'
  This branch code will be used to create Google OpenID Connect patrons.

Sponsored-by: Tulong Aklatan

Signed-off-by: Eugene Jose Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #61804|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #61803|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #61802|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #61801|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16892] Add automatic patron registration via OAuth2 login

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16892

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #28 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Eugene Jose Espinoza 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #70 from Marc Véron  ---
Went through test plans from comment #68 and comment #69, works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18201] Confusing language on Export data - bibliographic records " Remove non-local items"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

--- Comment #1 from Nick Clemens  ---
It's worse, it means 
'remove titles that don't contain items belonging to the branch I am signed in
as' 
which means you get all items on the records, even if those specific items are
from otherbranches

Clarification:
Record A has items from branches A B C
Record B has items from branches B C
Record C has items from branches A C

Signed in a branch b
Remove nonlocal items
Get:
Record A with all items
Record B with all items


Expected:
Record A with item from branch B
Record B with item from branch B

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

--- Comment #51 from Alex Sassmannshausen 
 ---
Created attachment 61885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61885=edit
Bug 11897: Add documentation for the cron script.

* misc/cronjobs/stockrotation.pl: Add documentation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18387] New: 404 errors on page causes SCO user to be logged out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18387

Bug ID: 18387
   Summary: 404 errors on page causes SCO user to be logged out
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Self checkout
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

If AutoSelfCheck is enabled but there is a 404 error in fetching resources on
an SCO page the user is logged out on each request. This is because a 404 also
requests the errorpages.tt which is outside the SCO module.

This causes a redirect to the opac-auth page when trying to print receipts
after completing SCO transaction

To recreate:
1 - Enable AuthoSelfCheck prefs
2 - In opacuserjs or scouserjs add a fetch of an unreachable resources
3 - Visit the SCO
4 - Sign in as a patron then click 'finish'
5 - Say 'yes' to receipt
6 - Note you are directed to log in

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12836] Add a script to regenerate Explain files from configs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12836

Magnus Enger  changed:

   What|Removed |Added

Summary|SRU Explain file needs to   |Add a script to regenerate
   |be rewritten|Explain files from configs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437

--- Comment #5 from Katrin Fischer  ---
(In reply to Felix Hemme from comment #4)
> Subfield $i is currently displayed on a new line. Wouldn't it be better to
> display $i in square brackets behind the subfields $a and $t? Just like
> field 246.

With our data that looks a little odd sometimes - I wonder if it would be nicer
at the beginning of the field as an 'intro'? I think we have examples for both
atm.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15437] MARC21: Show $i for 780/785

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15437

Felix Hemme  changed:

   What|Removed |Added

 CC||felix.he...@thulb.uni-jena.
   ||de

--- Comment #4 from Felix Hemme  ---
Subfield $i is currently displayed on a new line. Wouldn't it be better to
display $i in square brackets behind the subfields $a and $t? Just like field
246.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12802] Sent notices using several email addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #62 from Julian Maurice  ---
Patches reattached to fix their order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18378] Author name cannot add

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18378

--- Comment #4 from Ram Kumar  ---
How can install marc21?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12802] Sent notices using several email addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Julian Maurice  changed:

   What|Removed |Added

  Attachment #45482|0   |1
is obsolete||

--- Comment #61 from Julian Maurice  ---
Created attachment 61884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61884=edit
Bug 12802: Fix tests in Reserves.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12802] Sent notices using several email addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Julian Maurice  changed:

   What|Removed |Added

  Attachment #57296|0   |1
is obsolete||

--- Comment #56 from Julian Maurice  ---
Created attachment 61879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61879=edit
Bug 12802: Sent notices using several email addresses

Currently it is not possible to select several email addresses to notify
a patron. The only place where the mechanism exists is in the
overdue_notices.pl script.

This patch reuses the AutoEmailPrimaryAddress syspref and changes its
type to "multiple". Like that it is now possible to select several email
addresses. Note that there is no sense to select OFF and another value
for this pref. So if the 'OFF' (first valid) value exist, it takes the
priority.

It will add the ability to choose the email addresses to use to notify
patrons. The option is "email", "emailpro" and "B_email".
If "OFF" is selected, the first valid address will be returned (same
behavior as before this patch).

Note for the QA step:
I found a possible regression, but IMO it's not a big deal:
Before this patch if a letter did not contain a "to_address", the
C4::Letters::_send_message_by_email subroutine retrieve the email from the
given borrowernumber.
This is now done in the EnqueueMessage subroutine.
What it means: If a borrower didn't have an email address when the
notice was sent to the queue, the email address won't be check again when the
notice will really sent to the patron.
This change permits to sent a letter to the queue (EnqueueLetter)
without any information (from_address, to_address), only the borrowernumber is
mandatory to retrieve them.
The _send_message_by_email subroutine should not contain any useful code,
only sent the letter we ask it to sent.
The _update_message_to_address becomes useless since the to_address is
retrieved previously.

What this patch does:
The GetNoticeEmailAddress subroutine has been renamed to
GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails
defined in the AutoEmailPrimaryAddress pref.

If no 'to_address' parameter is given to EnqueueMessage, the emails
will be retrieved at this moment.

In C4::Message: An old form was found. The AutoEmailPrimaryAddress was
not check. The smsalertnumber was sent for the to_address param, which
is wrong.

C4::Reserves: AddReserve and _koha_notify_reserve:
The from address is built in the QueueLetter. It is useless to do it
here.

overdue_notices.pl: The script could be cleaned a little bit if we
remove the --email parameter. Indeed it is redundant with this new
enhancement. I can propose another patch with a die statement and a
message: "you should use the pref AutoEmailPrimaryAddress" if the
--email is provided.

opac/opac-shareshelf.pl and opac/opac-memberentry.pl:
just remove the from and to address. They will be filled on sending to the
queue
(because of the borrowernumber).

Test plan:
1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or
fill it with a single value if it is not done yet).
2/ Try the different way to sent notices to a patron (check the
following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE).
3/ Verify the email is correctly sent to the message_queue.
4/ Fill the pref with email and emailpro (for instance)
5/ Verify that 2 notices are sent to the message_queue: 1 with the email
and 1 with the emailpro.
6/ You can also verify that only 1 notice is generated if the emailpro
is empty.

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12802] Sent notices using several email addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Julian Maurice  changed:

   What|Removed |Added

  Attachment #45481|0   |1
is obsolete||

--- Comment #60 from Julian Maurice  ---
Created attachment 61883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61883=edit
Bug 12802: Fix tests in Letters.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12802] Sent notices using several email addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Julian Maurice  changed:

   What|Removed |Added

  Attachment #45479|0   |1
is obsolete||

--- Comment #58 from Julian Maurice  ---
Created attachment 61881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61881=edit
Bug 12802: Fix if AutoEmailOpacUser is enabled

Test plan:
Verify that the behavior of AutoEmailOpacUser still works as before.
Note that now the email can receive several emails if
AutoEmailPrimaryAddress has several values.

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12802] Sent notices using several email addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Julian Maurice  changed:

   What|Removed |Added

  Attachment #45480|0   |1
is obsolete||

--- Comment #59 from Julian Maurice  ---
Created attachment 61882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61882=edit
Bug 12802: Fix QA script issues

 FAIL   C4/Reserves.pm
   FAIL   pod
Spurious =cut command
in file C4/Reserves.pm

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12802] Sent notices using several email addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Julian Maurice  changed:

   What|Removed |Added

  Attachment #45478|0   |1
is obsolete||

--- Comment #57 from Julian Maurice  ---
Created attachment 61880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61880=edit
Bug 12802: FIX use the first valid email address if noemail is needed

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12802] Sent notices using several email addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Julian Maurice  changed:

   What|Removed |Added

  Attachment #45476|0   |1
is obsolete||

--- Comment #55 from Julian Maurice  ---
Created attachment 61878
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61878=edit
Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress

Signed-off-by: Brendan Gallagher 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853

--- Comment #7 from sandbo...@biblibre.com  ---
Created attachment 61877
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61877=edit
Bug 17853 - Don't remove () from link text

I have followed your test plan, applied the patch and have noticed that
there are now brackets around the link text.  Is this what you were
looking for?

Signed-off-by: Felix Hemme 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #59198|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17853] MARC21: Don't remove () from link text for 780/785

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17853

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com
 Status|Needs Signoff   |Signed Off

--- Comment #6 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Felix Hemme 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #21 from Julian Maurice  ---
(In reply to Marc Véron from comment #16)
> Patch does no longer apply.
> 
> How would disambiguation work?
> 
> e.g. for the 3 meanings of "Title" mentioned in
> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11285#c25

To attach context to a string, you have to use one of the 'p' variants (__p,
__px, __np, __npx). This context will appear in the PO file to help the
translator and gettext will use this information to choose the right
translation

https://www.gnu.org/software/gettext/manual/html_node/Contexts.html

Eg.
  __p('Patron', 'Title')
  __p('Bibliographic record', 'Title')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #50023|0   |1
is obsolete||

--- Comment #17 from Julian Maurice  ---
Created attachment 61873
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61873=edit
Bug 15395: Allow correct handling of plural translation

Locale::Maketext does not allow correct handling of plural translation
for languages that have more than one plural forms.
Locale::Messages does.

So Koha::I18N is now a wrapper around Locale::Messages, just like
Locale::TextDomain, and export the same symbols as Locale::TextDomain.
You can refer to documentation of Locale::TextDomain to know how to use
exported subroutines.

The PO file moves from misc/translator/po/xx-XX-messages.po to
misc/translator/po/xx_XX/LC_MESSAGES/Koha.po and now needs to be
compiled to MO in order to be used by Koha.
Compilation of PO file is done by running:
  ./translate install xx-XX

Remove dependency to Locale::Maketext and Locale::Maketext::Lexicon
Add dependency to Locale::Messages

Test plan:
1. Open a .pl script or .pm module with your favorite text editor
2. Add 'use Koha::I18N;' in the beginning of file
3. Use one of the subroutines exported by Koha::I18N and be sure to have
   a way to visualize the result (pass result to the template for
   example, or simply warn and watch the log file)
4. cd misc/translator && ./translate update fr-FR # try other languages
5. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po and translate your
   string(s)
   You will need to change the "Plural-Forms" header. See
   https://localization-guide.readthedocs.org/en/latest/l10n/pluralforms.html
6. ./translate install fr-FR
7. Use your web browser to go to the page that should display the
   translation, change language and verify the translation is correct

Example usage:
  __("Hi")
  __x("Hi {name}", name => 'Bob')
  __n("item", "items", $num_items)
  __nx("one item", "{count} items", $num_items, count => $num_items)
  __p("Bibliographic record", "item")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #50026|0   |1
is obsolete||

--- Comment #20 from Julian Maurice  ---
Created attachment 61876
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61876=edit
Bug 15395: Add plural translation capabilities to JS files

It adds Javascript equivalent of Koha::I18N's exported subroutines, and
they are used the same way.

String extraction is done only on *.js files and require gettext 0.19
(available in Debian stable, and also in wheezy-backports)

It adds Javascript library Gettext.js for handling translation and a
Perl script po2json to transform PO file into JSON.

Gettext.js and po2json both come from Locale::Simple.
There are several tools named po2json. It's simpler to integrate this
one into Koha than to check if the good one is installed on the system.
Locale::Simple is not needed.

To avoid polluting the global namespace too much, this patch also
introduce a global JS object named Koha and add some stuff in Koha.i18n

Test plan:
1. Add a translatable string in a JS file. For example, add this:
 alert(__nx("There is one item", "There are {count} items", 3,
 {count: 3}));
   to staff-global.js
2. cd misc/translator && ./translate update fr-FR
3. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po, verify that your
   string is present, and translate it
4. cd misc/translator && ./translate install fr-FR
5. (Optional) Verify that
   koha-tmpl/intranet-tmpl/prog/fr-FR/js/locale_data.js exists and
   contains your translation
6. Open your browser on the staff main page, change language and verify
   that the message is translated
7. Repeat 1-6 on OPAC side

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #50025|0   |1
is obsolete||

--- Comment #19 from Julian Maurice  ---
Created attachment 61875
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61875=edit
Bug 15395: Example usage of I18N Template::Toolkit plugin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #50024|0   |1
is obsolete||

--- Comment #18 from Julian Maurice  ---
Created attachment 61874
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61874=edit
Bug 15395: Plural translations in templates

Provides a way to handle translation of plural forms in templates

Add Template::Toolkit plugin for Koha::I18N

Use like this:

[%# USE the plugin and define some macros %]
[% PROCESS 'i18n.inc' %]

[%# tn is the equivalent of __n %]
[%# macro names can't start with underscore, t is for "translate" %]
[% tn('item', 'items', num_items) %]

Extraction of strings from templates is a bit complicated and use
Template::Parser and PPI. Template is compiled into Perl code and then
analyzed by PPI. It is slow, but should be correct even with complex
constructions.

Add dependency to PPI

Test plan:
1. Open a template file (.tt or .inc) with your favorite text editor
2. Add the PROCESS directive mentioned above in the beginning of file
3. Use one of the t* macros defined in i18n.inc. They are used like
   their "__" equivalent, with one difference: the 'x' variants take a
   hashref instead of a hash as last parameter
4. cd misc/translator && ./translate update fr-FR
5. Open misc/translator/po/fr_FR/LC_MESSAGES/Koha.po and translate your
   string(s)
6. ./translate install fr-FR
7. Use your web browser to go to the page that should display the
   translation, change language and verify the translation is
   correct

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537

Marc Véron  changed:

   What|Removed |Added

  Attachment #61862|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 61872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61872=edit
Bug 14537: Renaming OverdueNoticeBcc to NoticeBcc

To test:
1) Apply patch and update database
2) Run 'git grep "OverdueNoticeBcc"' and confirm there are no other
instances

Sponsored-by: Catalyst IT

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14537] The system preference 'OverdueNoticeBcc' is mis-named.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14537

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18386] Renew message in Default messaging preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18386

vimal kumar  changed:

   What|Removed |Added

   Priority|P5 - low|P2
 CC||vimal0...@gmail.com
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18386] New: Renew message in Default messaging preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18386

Bug ID: 18386
   Summary: Renew message in Default messaging preferences
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: vimal0...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

When renew a book user would like to get an SMS notification which contains
when is the next due date.

In default messaging preferences no option for the message to send after
renewal.
It's nice messaging preference for Renew in 

Administration > Patron categories > Default messaging preferences

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12365] Notes for rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3137] Add sys pref to collapse areas of the patron add by default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3137

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron  ---
I like the idea.

However:

If I disable e.g. Alternate address and then, from a patron's detail page,
follow the "Edit" link for Alternate address, I get an empty form, and I can
not toggle the fields. I would expect that the fields display anyway (without
toggling), since I explicitely clicked the "Edit" button for Alternate address.
- I think it is the same for all partial edit forms.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/