[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

--- Comment #22 from Srdjan Jankovic  ---
Ideally someone should try to replicate the original report in the top note. I
could not. But in discussion is fine with me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18396] New: UK format dates not sorting correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18396

Bug ID: 18396
   Summary: UK format dates not sorting correctly
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: david.robe...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 61956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61956=edit
Screenshot showing UK date sorting problem

When you view a user with a large number of checkouts, and you sort the
checkouts by date issued, if the system uses UK date format (DD/MM/) the
sorting doesn't working correctly - for example, you might see:

02/02/2017
03/03/2017
08/02/2017
10/01/2017
16/12/2016

instead of the correct order, which would be:

16/12/2016
10/01/2017
02/02/2017
08/02/2017
03/03/2017

See attached screenshot for a real example.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374

Nick Clemens  changed:

   What|Removed |Added

  Attachment #61953|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 61955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61955=edit
Bug 18374 - Respect QueryAutoTruncate syspref in Elasticsearch

This patchset adds a subroutine '_truncate_terms' to the ES QueryParser.

If QueryAutoTruncate is enabled this function will be called for any
search to add wildcard '*' to all terms

To test:
1 - Enable Elasticsearch and have some records indexed
2 - Search for partial terms
3 - Note they fail unless '*' is appended
4 - Apply patch, leave QueryAutoTruncate disabled
5 - Note partial term searches still fail
6 - Enable QueryAutoTruncate
7 - Note partial term searches succeed
8 - Do some regular and advanced searches to make sure results are as
expected

https://bugs.koha-community.org/show_bug.cgi?id=18347

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374

Nick Clemens  changed:

   What|Removed |Added

  Attachment #61952|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 61954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61954=edit
Bug 18374 - QueryAutoTruncate unit tests

To test:
1 - Apply just this patch - should fail
2 - Apply the other patch - should pass

https://bugs.koha-community.org/show_bug.cgi?id=18347

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374

--- Comment #4 from Nick Clemens  ---
Created attachment 61953
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61953=edit
Bug 18374 - Respect QueryAutoTruncate syspref in Elasticsearch

This patchset adds a subroutine '_truncate_terms' to the ES QueryParser.

If QueryAutoTruncate is enabled this function will be called for any
search to add wildcard '*' to all terms

To test:
1 - Enable Elasticsearch and have some records indexed
2 - Search for partial terms
3 - Note they fail unless '*' is appended
4 - Apply patch, leave QueryAutoTruncate disabled
5 - Note partial term searches still fail
6 - Enable QueryAutoTruncate
7 - Note partial term searches succeed
8 - Do some regular and advanced searches to make sure results are as
expected

https://bugs.koha-community.org/show_bug.cgi?id=18347

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374

Nick Clemens  changed:

   What|Removed |Added

  Attachment #61806|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 61952
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61952=edit
Bug 18374 - QueryAutoTruncate unit tests

To test:
1 - Apply just this patch - should fail
2 - Apply the second patch - should pass

https://bugs.koha-community.org/show_bug.cgi?id=18347

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

Nick Clemens  changed:

   What|Removed |Added

  Attachment #56275|0   |1
is obsolete||
  Attachment #61173|0   |1
is obsolete||

--- Comment #14 from Nick Clemens  ---
Created attachment 61951
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61951=edit
Bug 16187 - Add a script to cancel unfilled holds after a specified number of
days

This script takes parameters:
days - how many days waiting to concal an unfilled hold on or after
library - (repeatable) branches to consider
holidays - whether or not to count holidays (default is no)

This patchset adds two methods and covers them with tests:
Koha::Holds->unfilled(); To return holds where found = undef
Koha::Hold->age( $use_calendar ); To return the number of days since a
hold was placed (including or excluding holidays)

To test:
1 - Place some holds with varying reservedates
2 - Run script with different parameters to verify options are respected
(-v for verbosity will assist here)
3 - verify that script does nothing without days parameter

Sponsored by:
Siskiyou County Library (http://www.siskiyoulibrary.info/)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #60748|0   |1
is obsolete||

--- Comment #60 from Nick Clemens  ---
Created attachment 61948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61948=edit
Bug 14576 (QA Followup) Fix issue.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

--- Comment #62 from Nick Clemens  ---
Created attachment 61950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61950=edit
Bug 14576 (QA Followup) Fix warnings in tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #60747|0   |1
is obsolete||

--- Comment #59 from Nick Clemens  ---
Created attachment 61947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61947=edit
Bug 14576 (QA Followup) Remove C4:::Items::ShelfToCart

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #60751|0   |1
is obsolete||

--- Comment #61 from Nick Clemens  ---
Created attachment 61949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61949=edit
Bug 14576 - (QA Followup) Fix Returns.t

Two warnings, not one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #60663|0   |1
is obsolete||

--- Comment #58 from Nick Clemens  ---
Created attachment 61946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61946=edit
Bug 14576 (QA Followup) Fix undelcared use of $item Move strings from js files
Delete duplicated lines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #60658|0   |1
is obsolete||

--- Comment #53 from Nick Clemens  ---
Created attachment 61940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61940=edit
Bug 14576 - Allow arbitrary automatic update of location on checkin

This patch adds a new syspref "UpdateItemLocationOnCheckin" which
accepts pairs of shelving locations.  On check-in the items location is
compared ot the location on the left and, if it matches, is updated to
the location on the left.

This preference replaces ReturnToShelvingCart and
InProcessingToShelvingCart preferences.  The update statement should
insert values that replciate these functions.  Note existing
functionality of all items in PROC location being returned to
permanent_location is preserved by default.  Also, any items issued from
CART location will be returned to their permanent location on issue (if
it differs)

Special values for this pref are:
_ALL_ - used on left side only to affect all items
_BLANK_ - used on either side to match on/set to blank (actual blanks
will work, but this is an easier to read option)
_PERM_ - used on right side only to return items to permanent location

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set the new system preference UpdateitemLocationOnCheckin
   to the following (assuming sample data):
   NEW: FIC
   FIC: GEN
4) Create an item, set its location to NEW
5) Check in the item, note its location is now FIC
6) Check in the item again, note its location is now GEN
7) Check in the item again, note its location remains GEN
8) Test using _ALL_, _BLANK_ and _PERM_ for updates
9) Try entering various incorrect syntax in the pref and note you are warned

Sponsored by:
Arcadia Public Library (http://library.ci.arcadia.ca.us/)
Middletown Township Public Library (http://www.mtpl.org/)

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki  

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #60659|0   |1
is obsolete||

--- Comment #54 from Nick Clemens  ---
Created attachment 61941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61941=edit
Bug 14576 - Unit tests

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki  

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #60662|0   |1
is obsolete||

--- Comment #57 from Nick Clemens  ---
Created attachment 61945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61945=edit
Bug 14576 - (QA Followup) Remove other instances of
ReturnToShelvingCart/InprocessingToShelvingCart

This patch eliminates ReturnToShelvingCart and
InProcessingToShelvingCart,
Deletes Returns.t (it only tested those two
prefs and new tests are in issue.t)

Remaining instances found by:
git grep "ReturnToShelvingCart\|InProcessingToShelvingCart" | grep -v
translator | wc -l
are db update files and release notes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395

Marc Véron  changed:

   What|Removed |Added

  Attachment #61939|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 61943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61943=edit
Bug 18395: (bug 14601 followup) Remove article requests methods from
Koha::Patrons

There is something very wrong with the new subroutines, they have been added to
both Koha::Patron and Koha::Patrons:

% git grep 'sub article_request' Koha/Patron*.pm
Koha/Patron.pm:sub article_requests {
Koha/Patron.pm:sub article_requests_current {
Koha/Patron.pm:sub article_requests_finished {
Koha/Patrons.pm:sub article_requests {
Koha/Patrons.pm:sub article_requests_current {
Koha/Patrons.pm:sub article_requests_finished {

The ones in Koha::Patrons are wrong

Test plan:
  prove t/db_dependent/ArticleRequests.t
should still return green

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #60661|0   |1
is obsolete||

--- Comment #56 from Nick Clemens  ---
Created attachment 61944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61944=edit
Bug 14576 (QA Folllowup) Address issues

use mock for tests
use a separate variable for yaml
fix indentation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

  Attachment #60660|0   |1
is obsolete||

--- Comment #55 from Nick Clemens  ---
Created attachment 61942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61942=edit
Bug 14576 - (QA followup) Fix message for use of value not in authorized values

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki  

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395

--- Comment #1 from Jonathan Druart  
---
Created attachment 61939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61939=edit
Bug 18395: (bug 14601 followup) Remove article requests methods from
Koha::Patrons

There is something very wrong with the new subroutines, they have been added to
both Koha::Patron and Koha::Patrons:

% git grep 'sub article_request' Koha/Patron*.pm
Koha/Patron.pm:sub article_requests {
Koha/Patron.pm:sub article_requests_current {
Koha/Patron.pm:sub article_requests_finished {
Koha/Patrons.pm:sub article_requests {
Koha/Patrons.pm:sub article_requests_current {
Koha/Patrons.pm:sub article_requests_finished {

The ones in Koha::Patrons are wrong

Test plan:
  prove t/db_dependent/ArticleRequests.t
should still return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394

--- Comment #2 from Julian Maurice  ---
Created attachment 61938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61938=edit
Bug 18394: Add an option to item search to export a barcodes file

Test plan:
1. Go to item search (/cgi-bin/koha/catalogue/itemsearch.pl)
2. Fill the form with whatever you want
3. Leave the 'Output' option to 'Screen' and click 'Search'
4. Verify that the search still works
5. Click on 'Edit search' and set 'Output' to 'Barcodes file', click 'Search'
6. You should be able to download a 'barcodes.txt' file, open it and compare it
   to the previous search results
7. Now click on the 'Export results to barcodes file' button above the results,
   you should have the same result as in step 5
8. Verify that the CSV export still works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18394] Add an option to item search to export a barcodes file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394

--- Comment #1 from Julian Maurice  ---
Created attachment 61937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61937=edit
Bug 18394: Remove useless code from item search

The item search was originally designed to work even with JS disabled.
Since bug 15111, the staff interface does not work at all without JS, so some
parts of this code are useless and should be removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18395] New: Wrong article request methods in Koha::Patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395

Bug ID: 18395
   Summary: Wrong article request methods in Koha::Patrons
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

There is something very wrong with the new subroutines, they have been added to
both Koha::Patron and Koha::Patrons:

% git grep 'sub article_request' Koha/Patron*.pm
Koha/Patron.pm:sub article_requests {
Koha/Patron.pm:sub article_requests_current {
Koha/Patron.pm:sub article_requests_finished {
Koha/Patrons.pm:sub article_requests {
Koha/Patrons.pm:sub article_requests_current {
Koha/Patrons.pm:sub article_requests_finished {

The ones in Koha::Patrons are wrong

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18395] Wrong article request methods in Koha::Patrons

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||14610


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610
[Bug 14610] Add ability to place article requests in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14610] Add ability to place article requests in Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18395

--- Comment #265 from Jonathan Druart  
---
There is something very wrong with the new subroutines, they have been added to
both Koha::Patron and Koha::Patrons:

% git grep 'sub article_request' Koha/Patron*.pm
Koha/Patron.pm:sub article_requests {
Koha/Patron.pm:sub article_requests_current {
Koha/Patron.pm:sub article_requests_finished {
Koha/Patrons.pm:sub article_requests {
Koha/Patrons.pm:sub article_requests_current {
Koha/Patrons.pm:sub article_requests_finished {

See bug 18395.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18395
[Bug 18395] Wrong article request methods in Koha::Patrons
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18394] New: Add an option to item search to export a barcodes file

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18394

Bug ID: 18394
   Summary: Add an option to item search to export a barcodes file
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: julian.maur...@biblibre.com
  Reporter: julian.maur...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12365] Notes for rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

--- Comment #3 from Marc Véron  ---
Found a minor issue while testing: If you have text in the note field for 'All
libraries' + 'All item types', the text 'sticks' in the input field. This is
due to setting the value in smart-rules.tt line 384:



Works well if I change the line to:


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|18336   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336
[Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and
connections
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||11944


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
[Bug 11944] Cleanup Koha UTF-8
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18336


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336
[Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and
connections
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18336] Use utf8mb4 instead of utf8 for MySQL tables, columns, and connections

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18336

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|11944   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944
[Bug 11944] Cleanup Koha UTF-8
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18172] Logged in user page shows internal server error if OverDriveCirculation is disabled

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18172

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from Marc Véron  ---
Sorry, patch does not apply (merge conflict in opac-user.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14224] patron notes about item shown at check in

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

--- Comment #91 from Marc Véron  ---
Test plan step 4): 
AllowIssueNotes should read AllowCheckoutNotes

--

Test plan step 7): 
Enter "Buchrücken ist beschädigt", click "Submit changes", field shows:
"Buchr�cken ist besch�digt". Same with éàè etc.
Same in message "...has been saved and sent to the library."

Text seems to be OK in database (select note from issues;)

If I reload the page, text displays correctly.

--

Test plan step 17:
If I return an item with a hold placed on it, the note does not show. I see
only the message about confirming hold.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #27 from Julian Maurice  ---
(In reply to Marc Véron from comment #26)
> Hi Julian, I can not yet make it work. I think I missed something
> 
> perl translate install fr-FR
> Use of uninitialized value $pref_name in concatenation (.) or string at
> LangInstaller.pm line 202.
> Use of uninitialized value $pref_name in concatenation (.) or string at
> LangInstaller.pm line 244.
> SKIPPING ERROR MARKER IN HEADER: #-#-#-#-#  Koha-perl.pot (PACKAGE VERSION) 
> #-#-#-#-#
> SKIPPING ERROR MARKER IN HEADER: #-#-#-#-#  Koha-js.pot (PACKAGE VERSION) 
> #-#-#-#-#

I also have these messages, but they are only warnings, we can fix them later

> 
> Vales are not replaced in .tt file:
>  [% SEARCH_RESULT.items_count %] [% tn('item', 'items',
> SEARCH_RESULT.items_count) %](...)
> I would expect:
>  [% SEARCH_RESULT.items_count %] [% tn('exemplaire', 'exemplaires',
> SEARCH_RESULT.items_count) %](...)
> 

This result is expected. Messages are not translated directly in template
files, but tn() will return the correct translation at runtime.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18384] Add syspref to show all subs attached to a biblio in serial collection by default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18384

Claire Gravely  changed:

   What|Removed |Added

  Attachment #61860|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 61936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61936=edit
Bug 18384: ShowAllAttachedSubsSerialCollection syspref

To test:
1) Apply patch and update database
2) Find ShowAllAttachedSubsSerialCollection syspref, confirm it is set
to "Don't"
3) Go to Serials, find a serial with more than one subscription
4) Click Serial Collection, confirm you are taken to the subscription
summary for that one subscription
5) Set syspref to 'Always'
6) Go back to serials and find that same serial
7) Click Serial Collection, confirm you can see the subscription
summaries of all attached subs straight away.

Sponsored-by: Catalyst IT
Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #26 from Marc Véron  ---
Hi Julian, I can not yet make it work. I think I missed something

perl translate install fr-FR
Use of uninitialized value $pref_name in concatenation (.) or string at
LangInstaller.pm line 202.
Use of uninitialized value $pref_name in concatenation (.) or string at
LangInstaller.pm line 244.
SKIPPING ERROR MARKER IN HEADER: #-#-#-#-#  Koha-perl.pot (PACKAGE VERSION) 
#-#-#-#-#
SKIPPING ERROR MARKER IN HEADER: #-#-#-#-#  Koha-js.pot (PACKAGE VERSION) 
#-#-#-#-#

Vales are not replaced in .tt file:
 [% SEARCH_RESULT.items_count %] [% tn('item', 'items',
SEARCH_RESULT.items_count) %](...)
I would expect:
 [% SEARCH_RESULT.items_count %] [% tn('exemplaire', 'exemplaires',
SEARCH_RESULT.items_count) %](...)


This is the .po file after editing Plural forms:


# FIRST AUTHOR , YEAR.
#
#, fuzzy
msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 2017-04-06 10:52+0200\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME \n"
"Language-Team: LANGUAGE \n"
"Language: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: 8bit\n"
"#-#-#-#-#  Koha-perl.pot (PACKAGE VERSION)  #-#-#-#-#\n"
"Plural-Forms: nplurals=2; plural=(n > 1);\n"
"#-#-#-#-#  Koha-js.pot (PACKAGE VERSION)  #-#-#-#-#\n"

#: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt:1
msgid "item"
msgid_plural "items"
msgstr[0] "exemplaire"
msgstr[1] "exemplaires"
---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5276] subscription end date shouldn't be required / allow indefinite subscriptions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5276

--- Comment #1 from Katrin Fischer  ---
+1

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18384] Add syspref to show all subs attached to a biblio in serial collection by default

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18384

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #25 from Julian Maurice  ---
(In reply to Marc Véron from comment #22)
> NO PLURAL FORM HEADER FOUND - DEFAULTING TO 2

This was caused by an incompatibility between po2json and the newer version of
Locale::PO.
This is fixed in the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #23 from Julian Maurice  ---
Created attachment 61934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61934=edit
Bug 15395: Exclude xslt from the list of themes when building locale_data.js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

--- Comment #24 from Julian Maurice  ---
Created attachment 61935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61935=edit
Bug 15395: Fix PO header reading in po2json

Since version 0.24 Locale::PO do not escape newline characters in string
returned by dequote()
This patch set the required version of Locale::PO to 0.24 and fix po2json

https://rt.cpan.org/Public/Bug/Display.html?id=96016

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #21 from Marc Véron  ---
(In reply to Srdjan Jankovic from comment #20)
> Things have moved on meanwhile, and it seems to me that the page is being
> force reloaded now, so I'm not sure how useful this patch is. Maybe just a
> start of a full ajax solution.

Srdjan, do I get it right: No sign-off needed at the moment? Can status be
switched e.g. to "In Discussion"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17866] Change sender for claim and order notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866

--- Comment #36 from Marcel de Rooy  ---
(In reply to Marc Véron from comment #35)
> (In reply to Jonathan Druart from comment #34)
> > A test fails:
> > prove t/db_dependent/Letters.t
> > t/db_dependent/Letters.t .. 1/80 Can't call method "branchemail" on an
> > undefined value at /home/vagrant/kohaclone/C4/Letters.pm line 576.
> > 
> > userenv is not set in tests.
> 
> Should that go to a new Bug report? - Just stumbled over while testing Bug
> 12802 - Send notices using several email addresses

Yes, I will put it on a new report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17866] Change sender for claim and order notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17866

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #35 from Marc Véron  ---
(In reply to Jonathan Druart from comment #34)
> A test fails:
> prove t/db_dependent/Letters.t
> t/db_dependent/Letters.t .. 1/80 Can't call method "branchemail" on an
> undefined value at /home/vagrant/kohaclone/C4/Letters.pm line 576.
> 
> userenv is not set in tests.

Should that go to a new Bug report? - Just stumbled over while testing Bug
12802 - Send notices using several email addresses

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12802] Send notices using several email addresses

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802

Marc Véron  changed:

   What|Removed |Added

Summary|Sent notices using several  |Send notices using several
   |email addresses |email addresses

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7419] Add authority deduplication script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388

Marc Véron  changed:

   What|Removed |Added

  Attachment #61906|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 61933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61933=edit
Bug 18388 - Standardize serials volume information displaying

OPAC: Home > Details for (serial)
Compared information in tab 'Holdings' col 'Vol info' with
same information in staff client. With patch it's the same.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
Tested, will sign off.

Alex, next time please do not forget adding a test plan, even if it is a
trivial patch. It makes testing and sign offs easier :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7654] Add location at opac subscription view

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18388
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #24 from Marc Véron  ---
Merge conflict in opac-detail.tt

BTW:
Bug 18388 - Standardize serials volume information displaying will touch the
same file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18388] Standardize serials volume information displaying in OPAC and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18388

Marc Véron  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=7654

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob ( pref AuthorityMergeLimit)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988

--- Comment #101 from Marcel de Rooy  ---
(In reply to Jacek Ablewicz from comment #100)
> I have tested a bit earlier version of this patchset (from a ~week ago - not
> exactly following the test plans, but focusing on the possibly "scary stuff"
> which was not directly covered by the tests instead), and by a look of it
> there is no need to fully retest it again. I reviewed all the changes in the
> code once more (well, except for the *.t files, to be honest), and they all
> look pretty solid to me - the only issue encountered in the previous try got
> fixed in the meanwhile. Sign off time ;).

Thanks again Jacek.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18391] Error: You do not have permission to access this page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18391

Marc Véron  changed:

   What|Removed |Added

   Severity|normal  |trivial
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/