[Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515

di...@calyx.net.au changed:

   What|Removed |Added

  Attachment #63129|0   |1
is obsolete||

--- Comment #7 from di...@calyx.net.au ---
Created attachment 63317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63317=edit
Bug 16515 [Generated CSS] Did you mean? links don't wrap on smaller screens

Processed and minified CSS.

Works as expected and looks much tidier now.
Signed-off-by: Dilan Johnpulle 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16515] Did you mean? links don't wrap on smaller screens

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515

di...@calyx.net.au changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548

--- Comment #9 from Josef Moravec  ---
(In reply to dilan from comment #8)
> Just tried it Josef. It's still giving a 'getent [...]' message instead.

Can't help it, but it works for me... how do you try to test it? On devbox?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18548] running koha-create --request-db without an instance name should abort

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18548

di...@calyx.net.au changed:

   What|Removed |Added

 CC||di...@calyx.net.au

--- Comment #8 from di...@calyx.net.au ---
Just tried it Josef. It's still giving a 'getent [...]' message instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #6 from Mason James  ---
seems to work as expected, thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925

Mason James  changed:

   What|Removed |Added

  Attachment #59208|0   |1
is obsolete||

--- Comment #5 from Mason James  ---
Created attachment 63316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63316=edit
Bug 17925: Disable debugging in reports/bor_issues_top.pl

Remove setting $debug to 1. This prevents creation of file
tmp/bor_issues_top.debug.log.
Enable warnings pragma.
Resolve a uninitialized warning on $sep like:
Use of uninitialized value
$CGI::Compile::ROOT::usr_share_koha_masterclone_reports_bor_issues_top_2epl::sep
in string eq at /usr/share/koha/masterclone/reports/bor_issues_top.pl line 66.

Test plan:
Restart Plack (as you always do when testing).
Remove file /tmp/bor_issues_top.debug.log.
Open Reports/Patrons with the most checkouts.
Check if the file in /tmp has not been created again.
Check the log for warnings after you restarted Plack.

Signed-off-by: Marcel de Rooy 
Signed-off-by: Mason James 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17925] Disable debugging in reports/bor_issues_top.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17925

Mason James  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18566] Staff client should always show purchase suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18566

Vinod  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in,
   ||mishrav...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18566] New: Staff client should always show purchase suggestion

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18566

Bug ID: 18566
   Summary: Staff client should always show purchase suggestion
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mishrav...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Koha allows the staff to put the purchase suggestions on users behalf through
staff interface though in system preferences it has been marked as "not
allowed". But acquisition home page is missing "suggestion management" link
therefore staff is not able to view the same if he/she has made suggestions on
users behalf.

The requirement is it should always show the suggestions whether system
preference allows or not allows the users to make suggestions via OPAC.

I have tested it on 16.11.07 installed on debian via package.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551

--- Comment #10 from Marc Véron  ---
Two issues are addressed with first two patches, I signed the patches off.

But there is one more problem showing up (It was hidden by the first two
problems):

To reproduce:

- Apply first two patches

- Go to Home > Patrons

- Have a close look to the tabs Search Patrons / Check out / Check in ...
- You will see that first there is no green line around the tabs and the
  first tab 'Search patrons' is not in bold. The height of the whole search
  part changes, moving the rest of the page contents up. Then the green line 
  appears, font of 'Search patron' changes to bold, the area of the search part
  expands and the rest of the page moves down again.

- You can reproduce by performing a search as well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551

Marc Véron  changed:

   What|Removed |Added

  Attachment #63287|0   |1
is obsolete||

--- Comment #9 from Marc Véron  ---
Created attachment 63315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63315=edit
Bug 18551: followup - hide advanced filters in header, move hidding to css file

Test plan:
The same as first patch, but also with advanced search form in header hidden
on page load - see comment 4

Issue with advanced search form is gone.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551

Marc Véron  changed:

   What|Removed |Added

  Attachment #63171|0   |1
is obsolete||

--- Comment #8 from Marc Véron  ---
Created attachment 63314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63314=edit
Bug 18551 - Hide with CSS dynamic elements in member search

In member search page, the result table is in Ajax so fully managed by
Javascript. There is also a yellow dialog message prepared in HTML.

Thoses elements are hidden by JS code : ie $("#patron_list_dialog").hide().

The problem is that the static page is first loaded an displayed then the JS
code runs an hides the elements.
On a low performance computer, this action is visible and looks like there is a
blinking yellow message.

I propose to hide with CSS so that thoses elements are not displayed in static
page and are there shown in dynamic JS code.

Test plan :
Check display is unchanged :
- Go to home page /cgi-bin/koha/members/members-home.pl
- Perform patron search from header search box
- Perform patron search by clicking on a letter
- Perform patron search from filters (left of results table)
- Select a patron and add it to a list => you see the yellow message

Yellow message does no longer appear with this patch.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17438] Warnings from Business::ISBN::Data in webinstaller

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17438

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron  ---
I got the same while upgrading to the newest master 16.12.00.032
Perl modules on aobut page: Business::ISBN (2.05)   2.09 


[Wed May 10 05:33:06 2017] updatedatabase.pl: ISBN_RANGE_MESSAGE is set to
[] but that file does not exist!
[Wed May 10 05:33:06 2017] updatedatabase.pl: Trying to use the default
locations
[Wed May 10 05:33:06 2017] updatedatabase.pl: at
/usr/share/perl5/Business/ISBN.pm line 76.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438

--- Comment #23 from Alex Buckley  ---
Hi Jonathan

Sure thing, I'll do that when I have a bit of time this evening

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18564] koha-common.cnf parsing is too restrictive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
Summary|kola-common.cnf parsing is  |koha-common.cnf parsing is
   |too restrictive |too restrictive

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18565] Create system preference for OPACShowDueDate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18565

Jessie Zairo  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18565] New: Create system preference for OPACShowDueDate

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18565

Bug ID: 18565
   Summary: Create system preference for OPACShowDueDate
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jza...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

We have a few options through the system preferences to hide fields in the
OPAC, such as OPACShowBarcode which allows you to show or hide the barcode on
the holdings tab and OPACShowHoldQueueDetails which allows you to show or hide
the holds priority to patrons in the OPAC. It would be great to have a system
preference to show or hide the duedate on the holdings tab, like an option for
OPACShowDueDate.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18564] kola-common.cnf parsing is too restrictive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564

--- Comment #2 from Eric Vantillard  ---
maybe something like that

awk '
BEGIN {
FS="="
}
$1 ~/\[/ {
inclient=0
}
$1 ~/\[client\]/ {
inclient=1
next
}
inclient==1 && $1 ~/host/ {
print $2
}
' /etc/mysql/koha-common.cnf

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Bouzid  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #37 from Bouzid  ---
Hi Katrin,

Thanks for the feedback.

I fix all problems from the QA script and all problems when you open window for
add authority.

Now, if the authority is not found, when you click add authority, it's open the
 window with the correct authority type.

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Bouzid  changed:

   What|Removed |Added

  Attachment #63311|0   |1
is obsolete||

--- Comment #36 from Bouzid  ---
Created attachment 63313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63313=edit
Bug11299 - Fix problems when authority is not found and i want add it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #35 from Bouzid  ---
Created attachment 63312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63312=edit
Bug 11299 - QA fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #34 from Bouzid  ---
Created attachment 63311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63311=edit
Bug11299 - Fix problems when authority is not found and i want add it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294

--- Comment #4 from Magnus Enger  ---
(In reply to Magnus Enger from comment #3)
> I had a customer complaining about this exact issue. Setting UseQueryParser
> = Try solves it.

Not sure if that might cause other issues, though...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294

--- Comment #3 from Magnus Enger  ---
I had a customer complaining about this exact issue. Setting UseQueryParser =
Try solves it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #2 from Tomás Cohen Arazi  ---
(In reply to Barton Chittenden from comment #1)
> Note that this issue is separate from the URL encoding issues in Bug 13301.

Barton, have you tried enabling the QueryParser? I'm more inclined to fix the
QueryParser if there are issues with it, and stop spending time on the legacy
query parsing code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5456] Create a link to opac-ics.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18563
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=18563   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563
[Bug 18563] Force koha.ics to only show up on first day of created calendar
appointment
-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18563] Force koha.ics to only show up on first day of created calendar appointment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=5456|
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|enhancement |normal
 Depends on||5456


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456
[Bug 5456] Create a link to opac-ics.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18294] Keyword searches surrounded by double quotes fail on staff client and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18294

Magnus Enger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=7518
 CC||mag...@libriotech.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7518] searches with quotation marks don't work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518

Magnus Enger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18294

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18564] kola-common.cnf parsing is too restrictive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564

--- Comment #1 from Eric Vantillard  ---
adding spaces around the equal sign will resolve the issue

the problem is in kohl-create function getmysqlhost()

https://github.com/Koha-Community/Koha/blob/master/debian/scripts/koha-create#L124

the awk search require spaces

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18564] New: kola-common.cnf parsing is too restrictive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564

Bug ID: 18564
   Summary: kola-common.cnf parsing is too restrictive
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: gmcha...@gmail.com
  Reporter: eric.vantill...@evaxion.fr
QA Contact: testo...@bugs.koha-community.org

my koha-common.cnf is using this form:

[client]
host=db
user=root
password="move_rootpwd_to_dotenv"

this file is working has expected with mysql tools.

but koha-create parsing will not find the db host resulting in koha-conf.xml
containing no values in hostname element.

as a result trying to connect to the web serveur will raise an error :

Software error:

DBIx::Class::Storage::DBI::catch {...} (): DBI Connection failed: Can't connect
to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2) at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1490. at
/usr/share/koha/lib/Koha/Database.pm line 90
Compilation failed in require at /usr/share/koha/intranet/cgi-bin/mainpage.pl
line 31.
BEGIN failed--compilation aborted at
/usr/share/koha/intranet/cgi-bin/mainpage.pl line 31.
For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17320] MySQL 5.7 doesn't work well with SQL using '0000-00-00'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17320

--- Comment #10 from Jonathan Druart  
---
The test plan is wrong, we need to test the patch with older versions of MySQL
as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5456] Create a link to opac-ics.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5456

John Andrews  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18563

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18563] Force koha.ics to only show up on first day of created calendar appointment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563

John Andrews  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=5456

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18563] New: Force koha.ics to only show up on first day of created calendar appointment

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18563

Bug ID: 18563
   Summary: Force koha.ics to only show up on first day of created
calendar appointment
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: jandr...@washoecounty.us
QA Contact: testo...@bugs.koha-community.org

This is a follow-up to bug 5456 - create a link to opac-ics.pl. The
functionality established by that bug fix creates a file that can be imported
to a calendar program. In Outlook, with a due time of 11:59, a 1-hour
appointment is created, resulting in a 2-day "date due" appointment in the
calendar. The appointment created should be limited to the first (actual due)
date.


[tag] [reply] [−] Comment 13 John Andrews 2017-05-02 16:16:58 UTC
There's a problem with the lack of end time -- when importing this into my
outlook calendar, because there's no end time, outlook automatically creates an
hour long event. Which means that the due date reminder shows up both on the
due date, and on the day AFTER the due date. In our case, the time due is 11:59
pm, so the appointment gets created in outlook as from 11:59 pm on the due date
until 12:59 am on the next day. Is there a way to force the appointment to
start and end at the same time?

[tag] [reply] [−] Comment 14 Magnus Enger 2017-05-03 08:05:18 UTC
(In reply to John Andrews from comment #13)
Please report this as a new bug/issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

--- Comment #55 from Jonathan Druart  
---
Created attachment 63310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63310=edit
Bug 17944: QA follow-up

- Remove an unused use statement
- Fix pod
- Use snake_case
- Fix test "An itemtype cannot be deleted if and only if there is
biblioitem linked with it"

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63307|0   |1
is obsolete||
  Attachment #63308|0   |1
is obsolete||

--- Comment #54 from Jonathan Druart  
---
Created attachment 63309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63309=edit
Bug 17944 - Add Koha::ItemType->can_be_deleted and use it from
admin/itemtypes.pl

Removed the sql code from Itemtypes.pm and replaced  it with DBIx
database query in the itemtypes.pl administrative script

Test plan:
1. In the staff interface, stage and manage MARC records for import

2. Try to delete an itemtype. If there are items of that itemtype in the
   database then a message telling you the number of items of that
   itemtype there are will be displayed.

3. Record that number

4. View the admin/itemtpes.pl script and confirm that there is sql code
   written in this file.

5. Apply this patch

6. View the admin/itemtypes.pl script and observe that there is no sql
   in this file. There is however DBIx code, for example
   $schema->resultset('Item')->search({ 'itype' => $itemtype_code} );
   which is searching for items with the itype value matching
   $itemtype_code value.

7. In the staff interface try to delete the same itemtype

8. Record the number of items there are with that itemtype in the
   resulting message

9. The numbers recorded in steps 3 and 8 should match showing that the
   DBIx code is working as intended

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63259|0   |1
is obsolete||

--- Comment #52 from Jonathan Druart  
---
Created attachment 63307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63307=edit
Bug 17944 - Removed SQl query from itemtypes.pl and replaced it with
can_be_deleted method in Koha/ItemType.pm

In Koha/ItemTypes.t I have reworded unit test output and added test for item
deletion.

In addition to updating admin script by removing warn and changing if
statement check

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

--- Comment #53 from Jonathan Druart  
---
Created attachment 63308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63308=edit
Bug 17944: QA follow-up

- Remove an unused use statement
- Fix pod
- Use snake_case
- Fix test "An itemtype cannot be deleted if and only if there is
biblioitem linked with it"

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17944] Remove the sql code from itemtypes.pl administrative perl script

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17944

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

--- Comment #11 from Jonathan Druart  
---
If I do not misread the second patch, we have:

IF NOT A AND  B:
  Do stuff
ELSIF A AND NOT B:
  Do the same stuff

If that the case, we can simplify with:

IT NOT A AND B
OR A AND NOT B:
  Do the stuff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17212] ITEMTYPECAT broken if there is another authorised value with same code

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17212

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Assignee|gmcha...@gmail.com  |martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||18562


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562
[Bug 18562] There should be a koha-sip script to handle SIP daemons for
instances
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18562] There should be a koha-sip script to handle SIP daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18562] There should be a koha-sip script to handle SIP daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18114


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114
[Bug 18114] koha-start-* and koha-stop-* should be replaced with the new
command style
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18562] New: There should be a koha-sip script to handle SIP daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562

Bug ID: 18562
   Summary: There should be a koha-sip script to handle SIP
daemons for instances
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18114] koha-start-* and koha-stop-* should be replaced with the new command style

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||17467, 17468
Version|unspecified |master
 CC||tomasco...@gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467
[Bug 17467] There should be a koha-zebra script to handle Zebra daemons for
instances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468
[Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18114


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114
[Bug 18114] koha-start-* and koha-stop-* should be replaced with the new
command style
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17468] Remove koha-*-zebra scripts in favor of koha-zebra

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17468

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18114


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18114
[Bug 18114] koha-start-* and koha-stop-* should be replaced with the new
command style
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63285|0   |1
is obsolete||
  Attachment #63290|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 63305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63305=edit
Bug 18557 - Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Clubs.t

Signed-off-by: Josef Moravec 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557

--- Comment #7 from Jonathan Druart  
---
Created attachment 63306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63306=edit
Bug 18557 [QA Followup] - Use dt_from_string

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #13 from Jonathan Druart  
---
I am not sure this is acceptable, it will become hard to copy rules.
Maybe we need an additional "Copy" action button?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15246] Adding new patron triggers foreign key error if branchcode is hidden

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15246

Michael Kuhn  changed:

   What|Removed |Added

 CC||m...@adminkuhn.ch

--- Comment #3 from Michael Kuhn  ---
Under the described circumstances (Koha system preference
"BorrowerUnwantedField" containing "branchcode") almost the same problem
occurrs when trying to add new patrons.

In this case:

1. Environment: Debian GNU/Linux 8 with Koha 16.11.04 and Plack activated.

2. Trying to add a new patron using the staff client will result in the URL
".../cgi-bin/koha/members/memberentry.pl" showing just a white page saying
"Internal Server error".

3. The log file "plack-error.log" will show the following error (just as an
example):

DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key
constraint fails (`koha_phsh`.`borrowers`, CONSTRAINT `borrowers_ibfk_2`
FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) [for Statement
"INSERT INTO `borrowers` ( `address`, `address2`, `altcontactaddress1`,
`altcontactaddress2`, `altcontactaddress3`, `altcontactcountry`,
`altcontactfirstname`, `altcontactphone`, `altcontactstate`,
`altcontactsurname`, `altcontactzipcode`, `borrowernotes`, `cardnumber`,
`categorycode`, `city`, `contactnote`, `country`, `dateenrolled`, `dateexpiry`,
`dateofbirth`, `debarred`, `email`, `emailpro`, `firstname`, `mobile`,
`opacnote`, `othernames`, `password`, `phone`, `phonepro`, `privacy`,
`privacy_guarantor_checkouts`, `sex`, `sms_provider_id`, `sort1`, `sort2`,
`state`, `streetnumber`, `surname`, `title`, `userid`, `zipcode`) VALUES ( ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?,
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0="", 1="",
2="", 3="", 4="", 5="", 6="", 7="", 8="", 9="", 10="", 11="", 12="111",
13="13", 14="", 15="", 16="", 17='2017-05-09', 18='2100-08-09T00:00:00',
19=undef, 20=undef, 21="", 22="", 23="", 24="", 25="", 26="", 27='!', 28="",
29="", 30=0, 31=0, 32="", 33=undef, 34="", 35="", 36="", 37="", 38="",
39="", 40='', 41=""] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line
1832.
DBIx::Class::Storage::DBI::_dbh_execute(): Cannot add or update a child row: a
foreign key constraint fails (`koha_phsh`.`borrowers`, CONSTRAINT
`borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches`
(`branchcode`)) at /usr/share/koha/lib/Koha/Object.pm line 120

4. The problem can be solved by removing "branchcode" from Koha system
preference "BorrowerUnwantedField".

5. As Laura has suggested it may be a good idea to add a hint to the preference
"BorrowerUnwantedField" concerning field "branchcode" - so most people wouldn't
even try to include it. Or, as Owen Leonard has suggested, to automatically
select the logged-in branch for new patrons; even if the field "branchcode" is
hidden; although this may not always be the correct choice, if the library has
more than one branch. So maybe it would be safest to just forbid adding the
mandatory field "branchcode" to Koha system preference "BorrowerUnwantedField".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17915] warning in Stage MARC records for import when matching rule with offset

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17915

--- Comment #2 from Owen Leonard  ---
I can't reproduce this problem in master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561

--- Comment #4 from Josef Moravec  ---
(In reply to Owen Leonard from comment #3)
> I think this would not work well with screen readers. I suppose they way it
> is right now (with a text +) is probably not great for screen readers either.
> 
> Filament Group has a good reputation for thoughtful articles on this kind of
> thing:
> 
> https://www.filamentgroup.com/lab/bulletproof_icon_fonts.html
> 
> Their "Critical icons" section is interesting, but requires the js library
> Modernizr.
> 
> I think this issue requires some more discussion and investigation.

Good point Owen, thanks!

Accessibility should be important for us of course...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18320] patroncards/edit-layout.pl raises warnings

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18320

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard  ---
I'm assuming based on Comment 2 that this should be 'Failed QA'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277

--- Comment #7 from Josef Moravec  ---
Created attachment 63303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63303=edit
[SIGNED-OFF] Bug 18277: Remove GetBiblionumberFromItemnumber -
create_analytical_rel.pl

I have no idea how to test this patch, see bug 5528, or simply read the
code.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277

--- Comment #8 from Josef Moravec  ---
Created attachment 63304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63304=edit
[SIGNED-OFF] Bug 18277: Remove the C4::Biblio::GetBiblionumberFromItemnumber

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277

--- Comment #6 from Josef Moravec  ---
Created attachment 63302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63302=edit
[SIGNED-OFF] Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem

Test plan:
Enable EasyAnalyticalRecords and link an item to another one (Edit >
link to host item)

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277

Josef Moravec  changed:

   What|Removed |Added

  Attachment #61127|0   |1
is obsolete||
  Attachment #61128|0   |1
is obsolete||
  Attachment #61129|0   |1
is obsolete||
  Attachment #61130|0   |1
is obsolete||

--- Comment #5 from Josef Moravec  ---
Created attachment 63301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63301=edit
[SIGNED-OFF] Bug 18277: Remove GetBiblionumberFromItemnumber - Easy ones

To retrieve a biblionumber from an itemnumber, we can use:
  Koha::Item->biblio->biblionumber

This is only what this patchset does.
Doing that we will be able to get rid of the
C4::Biblio::GetBiblionumberFromItemnumber subroutine.

Test plan:
- Acquisition module: cancel a receipt
- Export a record to CSV
- Modify items in a batch

Item's info should be correct

Other changes with be checked by QA team, by reading the code.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18277] Koha::Biblio - Remove GetBiblionumberFromItemnumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18277

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #46 from Josef Moravec  ---
Created attachment 63300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63300=edit
[SIGNED-OFF] Bug 18276: (follow-up) Remove GetBiblioFromItemNumber - ILSDI

Take into account biblio level holds

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #43 from Josef Moravec  ---
Created attachment 63297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63297=edit
[SIGNED-OFF] Bug 18276: Remove GetBiblioFromItemNumber - Easy ones

The subroutine C4::Biblio::GetBiblioFromItemNumber was wrong for several
reasons:
- badly named, we can get biblio info from a barcode
- SELECT * from items, biblio and biblioitems
makes things hard to follow and debug, we never know where do come from
the value we display
- sometimes called only for trivial information such as biblionumber,
author or title

This patchset suggests to replace it with calls to:
- Koha::Items->find for item's info
- $item->biblio for biblio's info
- $item->biblio->biblioitem for biblioitem's info

Test plan:
Item's info should correctly be displayed on the following pages:
- circulation history
- transfer book
- checkin
- waiting holds

QA will check the other changes reading the code, it's trivial

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #44 from Josef Moravec  ---
Created attachment 63298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63298=edit
[SIGNED-OFF] Bug 18276: Remove the C4::Biblio::GetBiblioFromItemNumber
subroutine

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #45 from Josef Moravec  ---
Created attachment 63299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63299=edit
[SIGNED-OFF] Bug 18276: FIX status display for course reserves

This include file is terribly wrong, it's called from different places
that do not set the same flag.
The status from detail and result page might be different from the one
display on the course reserve table.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #42 from Josef Moravec  ---
Created attachment 63296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63296=edit
[SIGNED-OFF] Bug 18276: Remove GetBiblioFromItemNumber - circulation pages

Test plan:
1. Checkout items in a batch
The information displayed should be ok (title, subtitles, author,
itemnotes, barcode)
2. Checkout an item using the standard checkout page
You should correctly see the information of the item that has been
checked out (title and author)

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

--- Comment #41 from Josef Moravec  ---
Created attachment 63295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63295=edit
[SIGNED-OFF] Bug 18276: Remove GetBiblioFromItemNumber - ILSDI

Test plan:
Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=51_holds=1
The results should be the same before and after this patch

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

Josef Moravec  changed:

   What|Removed |Added

  Attachment #63121|0   |1
is obsolete||
  Attachment #63122|0   |1
is obsolete||
  Attachment #63123|0   |1
is obsolete||
  Attachment #63124|0   |1
is obsolete||
  Attachment #63125|0   |1
is obsolete||
  Attachment #63126|0   |1
is obsolete||
  Attachment #63166|0   |1
is obsolete||

--- Comment #40 from Josef Moravec  ---
Created attachment 63294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63294=edit
[SIGNED-OFF] Bug 18276: Remove GetBiblioFromItemNumber - Course reserves

Values from the items, biblio and biblioitems tables are used in the template,
so we need to pass all of them to the template, but separately.
That way we easily see which field from which table we are displaying.

Test plan:
Create a course reserve and add items.
Correct information must be displayed on the detail page of the course
reserve, on staff and OPAC interface.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Josef Moravec  changed:

   What|Removed |Added

  Attachment #63226|0   |1
is obsolete||

--- Comment #10 from Josef Moravec  ---
Created attachment 63293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63293=edit
[SIGNED-OFF] Bug 18450 - Implemented check if either AllowRenewLimitOverride or
AllowRenewalIfOtherItemsAvaliable were set to allow, so the user is only
blocked if both of these sysprefs are set to 'Dont allow'

Test plan:
1. In More->Administration->Global system preferences
ensure that both the AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont
allow'.
2. Place a hold on an item from a patron
3. Checkout the item out to a different patron
4. Renew the item and notice the 'Cannot renew: The item is on hold for
another patron' warning
5. Click the 'Override and renew' button and notice that you
can bypass the hold
6. Apply patch
7. Renew the item again and notice that the message does not have a
'Override and renew' button it just has the 'Ignore and continue' button
8. Go back to More->Administration->Global system preferences and set
AllowRenewalLimitOverride to 'Allow'
9. Try renewing the same item again and notice that the 'Override and
renew' button is displayed
10. In systems preferences now set the
AllowRenewalIfOtherItemsAvailable syspref to 'Allow' and
AllowRenewalLimitOverride to 'Dont allow' and notice the 'Override and
renew' button is displayed
11. Now set both these sysprefs to 'Allow' and notice the 'Override and renew'
button is displayed
because you will not be violating these preferences.

Note: Checking if the renewal exceeds the renewal level, if auto renew
is set up, or if renewal is to soon is checked earlier in this
conditional
if statement earlier and so the check in this patch does not need to
check the renewal level, auto renewal, if renewal is too soon.

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450

Josef Moravec  changed:

   What|Removed |Added

  Attachment #62447|0   |1
is obsolete||

--- Comment #9 from Josef Moravec  ---
Created attachment 63292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63292=edit
[SIGNED-OFF] Bug 18450 - Implemented a check to determine if the 'Override and
renew' button is displayed based on the setting of the
AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences.

This will display the 'Override and renew' button only if both
preferences are set to 'Allow'.

Test plan:
1. In More->Administration->Global system preferences
ensure that both the AllowRenewalLimitOverride and
AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Dont allow'.
2. Place a hold on an item from a patron
3. Checkout the item out to a different patron
4. Renew the item and notice the 'Cannot renew: The item is on hold for another
patron'
5. Click the 'Override and renew' button and notice that although you
can bypass the hold
6. Apply patch
7. Renew the item again and notice that the message does not have a
'Override and renew' button it just has the 'Ignore and continue' button
8. Go back to More->Administration->Global system preferences and set
AllowRenewalLimitOverride to 'Allow'
9. Try renewing the same item again and notice that the 'Override and
renew' button is still not being displayed.
10. In systems preferences now set the
AllowRenewalIfOtherItemsAvailable to 'Allow'
11. Try renewing the item again and notice that now both of these
preferences are allowed the 'Override and renew' button is displayed
because you will not be violating these preferences.

Note: Checking if the renewal exceeds the renewal level, if auto renew
is set up, or if renewal is to soon is checked earlier in this conditional
if statement earlier and so the check in this patch does not need to
check the renewal level, auto renewal, if renewal is too soon.

Folloed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14803] Rental and fine fees are not updating on circulation screen

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14803

--- Comment #32 from Josef Moravec  ---
(In reply to Srdjan Jankovic from comment #31)
> (In reply to Josef Moravec from comment #29)
> 
> Hi Josef, thanks for testing this.
> 
> > I have to more concerns about it:
> > 1) The barcode field doesn't have focus after page is loaded - probably easy
> > to fix, but important
> > 2) Looks like it waits than issues are loaded and then show the barcode
> > input field, maybe I am wrong and it just looks like, but in any case it is
> > much slower then current master...
> 
> Ok, now it should be behaving like master. I tried to add some accuracy, but
> drawbacks are obviously too big...

It is Ok now, thanks

> > 3) Message "loading, you can continue scanning" is badly placed (in the left
> > top corner)
> 
> For me it is placed center of the table. At any rate I believe my patch did
> not change the table, it just makes a issuesTable.api().ajax.reload() call.
> Could you please a) check it in another browser b) compare to master. Thanks
> a lot.

Hm, strange... On master it's ok for me, on this patchset still bad... but I
can't find out where's the problem...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #3 from Owen Leonard  ---
I think this would not work well with screen readers. I suppose they way it is
right now (with a text +) is probably not great for screen readers either.

Filament Group has a good reputation for thoughtful articles on this kind of
thing:

https://www.filamentgroup.com/lab/bulletproof_icon_fonts.html

Their "Critical icons" section is interesting, but requires the js library
Modernizr.

I think this issue requires some more discussion and investigation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #88 from Josef Moravec  ---
I found some issues with this patchset:
1) It removes field overdrive_auth_token field from tables borrowers and
deletedborrowers
2) Automic update and kohastructure has to be consistent in field order, in
atomic, the new field is added after 'privacy', in kohastructure at the end -
it is bad

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17240] Allow processes that rely on background jobs run in Plack mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240

--- Comment #14 from Fridolin SOMERS  ---
Created attachment 63291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63291=edit
Bug 17240 - Allow processes that rely on background jobs run in Plack mode -
followup 3

Followup 3
If not running in background mode, items are not displayed in result page in
tools/batchMod.pl.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557

--- Comment #5 from Kyle M Hall  ---
Created attachment 63290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63290=edit
Bug 18557 [QA Followup] - Use dt_from_string

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557

--- Comment #4 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #3)
> Kyle, my understanding is that the best would be to use dt_from_string:
> 
> my $dtf = Koha::Database->new->schema->storage->datetime_parser;
> then
>   ->search({ date_end => { '>=' => $dtf->format_datetime( dt_from_string() )
> } })
> 
> Do not you think?

That works for me! Followup incoming!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18356] Prediction pattern wrong, skips years, for some year based frequencies

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18356

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
 Status|NEW |ASSIGNED

--- Comment #1 from Marcel de Rooy  ---
Found similar things. Taking a look..

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561

Josef Moravec  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #2 from Josef Moravec  ---
Owen, does it make sense to you?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561

Josef Moravec  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561

--- Comment #1 from Josef Moravec  ---
Created attachment 63289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63289=edit
Bug 18561: Use Font Awesome icons for plus (and minus) signs in forms

Test plan:
0. Apply the patch
1. Go to these forms and confirm that you can see new plus (minus) sign icon
and
that this cion does work as before
- Acquisiton - search for orders form in header
- Patrons - patron search in header
- Advanced catalogue search - more options has to be activated
- Opac - advanced search - more options has to be activated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18561] Use font awesome icons for plus signs in forms

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561

Josef Moravec  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com
   |ity.org |
  Component|Staff Client|Templates

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18561] New: Use font awesome icons for plus signs in forms

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18561

Bug ID: 18561
   Summary: Use font awesome icons for plus signs in forms
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Staff Client
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: josef.mora...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16116] Change of issue publication date doesn' t reflect on the next issue generated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #9 from Marcel de Rooy  ---
Would it be possible for Francois, Gaetan or Julian to test this patch too?
I am not so sure if the proposed changes really solve all problems in this
area.
Another signoff would not be a bad idea.

Another point (referring to an earlier remark):
> Before 3.20, when receiving a new issue, you could change the "Published on" 
> date and Koha will adjust the subscription's next issue publication date for
> all the new issues to be received.

Would it be an idea to add an option to the subscription that makes it possible
to rebase issue dates somehow ? We now have a 'buggy' mix of using last issue
and first acqui date. Maybe an additional base date to use optionally
(overruling first acqui)? Other ideas ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549

--- Comment #9 from M. Tompsett  ---
(In reply to Martin Renvoize from comment #6)
> I think this bug is somewhat misleading to the user, unfortunately.
[SNIP]
> I think the current (as in, in master) implementation is more 'the norm'

It is. The problem is that if users walk away, someone else can click 'login'
and become the person who just left.


> and that adding this patch actually obfuscates that clarity a bit more.

That's what the whole dialogue message is supposed to make clear. If your
objection is with the explanation, then feel free to suggest alternative
wording.


> By allowing a 'logout of google too' option, you're inferring
> that a google logout affects koha in some way, when in fact it
> does not.

No, I am implying that by choosing that option, other google related
tabs/windows in the same browser may be affected. You inferred incorrectly, so
clearly the dialogue message needs tweaking, because 'Koha and Google' is the
button name, not what you are logging in and out of manually in random order.

TAB A: GMail
TAB B: Koha OPAC logged in via OAuth
Click logout in OPAC.
Get dialogue (because you've applied this patch)
Click 'Koha and Google' your TAB A will be affected, and you will be forced to
relogin in to continue reading your GMail.
But if you click 'Koha only', TAB A is not affected, but you suffer the next
user can become you problem when the next person clicks the Koha OPAC login.

I suspect this is why people go with the most complex and horrid iframe
solution, because that may do some authorization revoking without actually
logging out and thus not have the potential identity theft issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18309] UNIMARC update from IFLA

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309

--- Comment #15 from Koha Team Lyon 3  ---
I have tried to install it on a sandbox but it can't apply :
Cannot rebuild zebra: 
The command perl /home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r
--wait-for-lock fails with the following error: 'perl
/home/koha/src/misc/migration_tools/rebuild_zebra.pl -a -b -r --wait-for-lock'
exited with value 255 The error message is: 
Control fields (generally, just tags below 010) do not have subfields,
use data() at /home/koha/src/Koha/Filter/MARC/EmbedItemsAvailability.pm line
75. at /home/koha/lib/contrib/sandbox/cron/../Run.pm line 28.

Do we have to add zebra files modification in this patch or to do a new one
that blocks this one ?

Sonia

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125

Owen Leonard  changed:

   What|Removed |Added

  Attachment #60329|0   |1
is obsolete||

--- Comment #12 from Owen Leonard  ---
Created attachment 63288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63288=edit
[SIGNED-OFF] Disabled the select for patron Category and Item Type

Test plan
1 - Edit a circulation rule and check you can modify the patron Category 
and item type
2 - Apply patch
3 - Edit a circulation rule : you can't change anymore

https://bugs.koha-community.org/show_bug.cgi?id=18125

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18125] Edit button can duplicate some circulation rule

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18125

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14716] opac-detail.pl -- Series link fails when series title ends with semicolon preceded by space.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14716

--- Comment #24 from Peggy Thrasher  ---
I would certainly support a patch that solves the semi-colon problem even if
the other issues are not resolved.  If we could make the system work correctly
when the MARC record follows the standard that would be a big improvement.

Thanks
Peggy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18551] Hide with CSS dynamic elements in member search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18551

--- Comment #7 from Josef Moravec  ---
Created attachment 63287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63287=edit
Bug 18551: followup - hide advanced filters in header, move hidding to css file

Test plan:
The same as first patch, but also with advanced search form in header hidden
on page load - see comment 4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560

Owen Leonard  changed:

   What|Removed |Added

  Attachment #63266|0   |1
is obsolete||

--- Comment #3 from Owen Leonard  ---
Created attachment 63286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63286=edit
[SIGNED-OFF] Bug 18560: RSS link in opac shelves is broken

TEST PLAN
-
1) have books entered
2) log in create a list
3) add books to list
4) display list
5) click the RSS link button.
   -- bad HASH error.
6) apply patch
7) repeat steps 4&5
   -- readble junk without error messages.
8) run koha qa test tools

Signed-off-by: Marc Véron 

Signed-off-by: Owen Leonard 

Sure this doesn't need a signoff, but I was already signing off when 
Marc did!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18560] RSS Feed link from OPAC shelves is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18560

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12063] Change date calculation for reserve expiration to skip all holidays

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12063

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #87 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Alex, Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18557] Mysqlim CURRENT_DATE in Koha::Clubs::get_enrollable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18557

--- Comment #3 from Jonathan Druart  
---
Kyle, my understanding is that the best would be to use dt_from_string:

my $dtf = Koha::Database->new->schema->storage->datetime_parser;
then
  ->search({ date_end => { '>=' => $dtf->format_datetime( dt_from_string() ) }
})

Do not you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18549] There should be a warning that logging out of Koha will leave browser session logged in to OAuth

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18549

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18438] Check in: Modal about holds hides important check in messages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18438

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #22 from Jonathan Druart  
---
(In reply to Josef Moravec from comment #21)
> (In reply to Jonathan Druart from comment #20)
> > I do not understand where we are with these patches.
> > What are the expected behaviour changes?
> 
> As I understand, the change is, that the page doesn't reload after
> dismissing hold modal window, so the message under the window does not
> disappear and user haven't wait for another reload...

Yes, it is what I understood too, but it is the behaviour I already get against
master.

Alex, can you squash the patches and provide a simple test plan please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/