[Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 --- Comment #20 from Marc Véron --- (In reply to Jonathan Druart from comment #19) > I do not understand how using txt_continue is helping translators: > > Before the patch: > msgid "Continue to the next step" > > After the patch: > msgid "%s %sContinue to the next step%s %s" My intention was to have repeating test at one place, but you are right, the result in the po file is not what we want, and isolating with div tags does not work here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #10 from Marc Véron --- (In reply to Jonathan Druart from comment #9) > I replaced empty_string with [% '' %] and I got the same result (i.e. it > works). ...as in my tests from comment #6 What is the next step? - Change koha-tmpl/intranet-tmpl/prog/en/includes/empty_line.inc ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 di...@calyx.net.au changed: What|Removed |Added CC||di...@calyx.net.au --- Comment #20 from di...@calyx.net.au --- Is there a test plan for this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18508] Fix t/db_dependent/api/v1/swagger/definitions.t ( follow-up of 18137)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18508 M. Tompsett changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||ldjami...@marywood.edu --- Comment #8 from M. Tompsett --- (In reply to Lari Taskula from comment #0) > t/db_dependent/api/v1/swagger/definitions.t .. Can't locate object method > "cache_dir" via package "Swagger2::SchemaValidator" at > /usr/share/perl5/Swagger2.pm line 42. For the record, I was able to also solve this by upgrading Swagger2 (cpan2deb'ing it). However, this patch is the recommended way according to the noise it generates when you only apply 18763, if I recall correctly. For what it's worth, I git bz'd 18508 and then 18763. I had to tweak the git bz, but basically both combined fix noise and test failures. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18763] swagger/definitions.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 M. Tompsett changed: What|Removed |Added CC||ldjami...@marywood.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18763] swagger/definitions.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18763 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #3 from M. Tompsett --- For what it's worth, I git bz'd 18508 and then 18763. I had to tweak the git bz, but basically both combined fix noise and test failures. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18651] Move of checkouts is still not correctly handled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 Jonathan Druart changed: What|Removed |Added Severity|major |critical --- Comment #19 from Jonathan Druart --- Upping severity, please let move this forward quickly! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18798] Use Koha.Preference in OPAC Reading Record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 Aleisha Amohia changed: What|Removed |Added Attachment #64272|0 |1 is obsolete|| --- Comment #2 from Aleisha Amohia --- Created attachment 64273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64273&action=edit Bug 18798: Use Koha.Preference in OPAC Reading Record This patch uses the Koha.Preference plugin method for the following sysprefs: - OPACMySummaryHTML - OPACAmazonCoverImages - SyndeticsEnabled - SyndeticsCoverImages - SyndeticsClientCode - GoogleJackets - BakerTaylorEnabled (Bug 17896) - BakerTaylorBookstoreURL (Bug 17896) To test, apply the patch from Bug 17896 and confirm that enabling and disabling the above sysprefs does not break anything. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Aleisha Amohia changed: What|Removed |Added Blocks||18798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 [Bug 18798] Use Koha.Preference in OPAC Reading Record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Aleisha Amohia changed: What|Removed |Added Blocks|18798 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 [Bug 18798] Use Koha.Preference in OPAC Reading Record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18798] Use Koha.Preference in OPAC Reading Record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 Aleisha Amohia changed: What|Removed |Added Depends on|17986 |17896 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 [Bug 17986] Perl dependency evaluation incorrect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17986] Perl dependency evaluation incorrect
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 Aleisha Amohia changed: What|Removed |Added Blocks||18798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 [Bug 18798] Use Koha.Preference in OPAC Reading Record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18798] Use Koha.Preference in OPAC Reading Record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 Aleisha Amohia changed: What|Removed |Added Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18798] Use Koha.Preference in OPAC Reading Record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 --- Comment #1 from Aleisha Amohia --- Created attachment 64272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64272&action=edit Bug 18798: Use Koha.Preference in OPAC Reading Record This patch uses the Koha.Preference plugin method for the following sysprefs: - OPACMySummaryHTML - OPACAmazonCoverImages - SyndeticsEnabled - SyndeticsCoverImages - SyndeticsClientCode - GoogleJackets - BakerTaylorEnabled (Bug 17986) - BakerTaylorBookstoreURL (Bug 17986) To test, apply the patch from Bug 17986 and confirm that enabling and disabling the above sysprefs does not break anything. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18798] Use Koha.Preference in OPAC Reading Record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 Aleisha Amohia changed: What|Removed |Added Depends on||17986 Patch complexity|--- |Small patch Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17986 [Bug 17986] Perl dependency evaluation incorrect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18798] New: Use Koha.Preference in OPAC Reading Record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18798 Bug ID: 18798 Summary: Use Koha.Preference in OPAC Reading Record Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: alei...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org Should not be passing the preference from the pl file - can check the preference using template plugin Koha.Preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 --- Comment #4 from Aleisha Amohia --- Created attachment 64271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64271&action=edit Bug 17896: [FOLLOW-UP] Make opac-readingrecord.pl use module Also fix template to use Koha.Preference instead of passing it from the pl file -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17896] BakerTaylorEnabled is not plack safe in reading history at the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17896 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- ... and pushed to 2 stable releases (16.11 and 17.05) - congrats Lee! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18694] Translatability: Get rid of exposing [%% FOREACH in csv/ cash_register_stats.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18694 --- Comment #23 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18734] Internal server error in cash_register_stats.pl when exporting to file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18734 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18656] Require confirmation of deletion of files from patron record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18656 --- Comment #18 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.09. Agree with Fridolin - this one makes sense in stable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18773] t/db_dependent/www/history.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18773 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #11 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.09. Very excited to see those - hope they will turn Jenkins green! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18411] t/db_dependent/www/search_utf8.t fails
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18411 --- Comment #16 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.09. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18741] Web installer does not load default data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18741 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Dependency is not in 16.11.x - so this is probably not be needed there. Also: doesn't apply. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #31 from Nick Clemens --- looking here - SIP item_information request failed for me in testing (worked on master) - will try again tomorrow -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18629] Translatability: Fix problems with web installer 17.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18629 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart --- I do not understand how using txt_continue is helping translators: Before the patch: msgid "Continue to the next step" After the patch: msgid "%s %sContinue to the next step%s %s" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18752] Automatic item modifications by age should allow 'blank' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18752 Jonathan Druart changed: What|Removed |Added Attachment #64154|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 64270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64270&action=edit Bug 18752 - Automatic item modifications by age should allow 'blank' values This patch modifies the automatic item modification by age template to correct errors in form validation: - Age in days should not be required - A value should not be required in substitutions. To test, apply the patch and clear your browser cache if necessary. - Go to Tools -> Automatic item modification by age. - Confirm that when editing or creating a rule the only required field is the substitutions field name. Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18298] Enforce password complexity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #42 from Magnus Enger --- (In reply to Katrin Fischer from comment #40) > Why would one want different policies per patron category? I don't feel this > level of granularity would be necessary here - I'd prefer a global setting. You could demand really difficult passwords for staff? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18752] Automatic item modifications by age should allow 'blank' values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18752 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18601] OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18601] OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18601 Jonathan Druart changed: What|Removed |Added Attachment #63670|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 64269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64269&action=edit Bug 18601: OAI/Sets.t mangles data due to truncate in ModOAISetsBiblios This patch replaces the TRUNCATE statement in ModOAISetsBiblios by a DELETE statement. A truncate will cause an implicit commit and will therefore commit the transaction started in the test script. Also simplifying the module load in the test script. Test plan: Do not apply this patch and observe that biblio records are added to your database by running t/db_dependent/OAI/Sets.t. Apply this patch, run the test again and verify that it does no longer add records to your biblio table. Signed-off-by: Marcel de Rooy Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #9 from Jonathan Druart --- I replaced empty_string with [% '' %] and I got the same result (i.e. it works). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Blou changed: What|Removed |Added CC||eric.be...@inlibro.com, ||francois.charbonnier@inlibr ||o.com, ||marjorie.barry-v...@ccsr.qc ||.ca --- Comment #24 from Blou --- This problem has been known by Eric Bégin for many years. I guess usually we do not care, or it doesn't trigger. I've never done the deep dive like Marcel did to find the cause. All I know is that it happens in many cases for them (the users). On the CCSR's branch I just added a empty line at the bottom of EVERY .pref files, and it resolved all their missing parameters problems. As far as test case 1) translate install fr-CA 2) search for 'paypal' in the sysprefs screen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #23 from Blou --- Created attachment 64268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64268&action=edit English search for 'paypal' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 --- Comment #22 from Blou --- Created attachment 64267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64267&action=edit French search for 'paypal' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Nick Clemens changed: What|Removed |Added Attachment #64265|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #26 from Nick Clemens --- There was a fair bit of discussion here that underlying code needs a rewrite - between the two options here I think I would vote for the Alternate, simply because it fixes the problem without locking us into the Capitalization, less new code on top of code the needs rewritten. Obsoleting the original patch in favor of the new, I appreciate everyone's work here and would love to see this one move ahead quickly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #8 from Marc Véron --- It happens in English (see comment #4) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 --- Comment #25 from Kyle M Hall --- Created attachment 64266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64266&action=edit Bug 15438 [Alternate Solution] - Checking out an on-hold item sends holder's borrowernumber in AF (screen message) field. Description: Let's say that 'Holding Patron' puts a hold on title 'ASDF'. If 'SIP Patron' then tries to check out ASDF, Holding Patron's card number appears in the AF (i.e. Screen Message) field. This only occurs if the hold has *not* yet been finalized -- If ASDF is waiting for Holding Patron, the screen message will read "Item is on hold shelf for another patron." The screen message containing only the Holding Patron's borrowernumber is confusing because a) It contains no context as to the nature of the number showing on the screen b) SIP devices work with borrower card numbers, so the number being returned has the wrong context. Furthermore, we're leaking patron information in a place where we probably would never check. Replicating the problem: Set up instance with two patrons, as well as a bib/item to put on hold/check out. Make sure that circ rules allow holds. Set up SIPconfig.xml to allow checkouts on the IP/port of your choice. Start SIP2. Make sure that authentication, checkin and check out work for the 'SIP Patron'. Ensure that AllowItemsOnHoldCheckout is set to "Don't Allow". In the steps to replicate, the Title/barcode of the item on hold/being checked out will be 'asdf'. The Holding Patron will be referred to as 'holder' and the checkout patron will be referred to as 'sipper'. Let's say that sipper's borrowernumber is 52. 1/ Place a biblio level hold for asdf, with holder as the holding patron. 2/ Start `sudo tail -f /var/log/syslog | grep sip` 3/ Attempt to check out asdf to sipper. You will see the sip checkout message '11...' followed by a '120...|AF52|...' sip checkout response. This indicates that the checkout has failed (which we would expect), and that the screen message is '52'. Example using ./misc/sip_cli_emulator.pl $ ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su staff -sp staff -l CPL --patron 23529001223636 --password 1234 --item 1234 -m checkout Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNstaff|COstaff|CPCPL| READ: 941 Trying 'checkout' SEND: 11YN2015122905321120151229 053211AOCPL|AA23529001223636|AB1234|ACstaff|AD1234|BON|BIN| READ: 120NUN20151229053211AOCPL|AA23529001223636|AB1234|AJTheories of human development :|AH|AF52|BLY|BV5.00|BHUSD|BT06| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438
Kyle M Hall changed:
What|Removed |Added
Attachment #64264|0 |1
is obsolete||
--- Comment #24 from Kyle M Hall ---
Created attachment 64265
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64265&action=edit
Bug 15438 - Checking out an on-hold item sends holder's borrowernumber in AF
(screen message) field.
The returns from C4::Circulation::CanBookBeIssued used
to be structured as a hashref of entries like
REASON => {
data => 'foo',
moredata => 'bar',
};
Some entries still are. But many are now
REASON => 1,
data => 'foo',
moredata => 'bar',
The sip Checkout routine still assumed the former, as it
reports any causes it was not aware of (to maintain support for
a changing api) The data fields could leak into the screen message
field of the response. e.g. the borrowernumber or surname of the
borrower who has a hold on an issued title. Some real messages were
getting obscured by this
This patch sanatizes the return from from CanBookBeIssued
by removing keys which are not all uppercase
It also fixes a case where the key's data element was used
for the screen message when we should use the key itself
Updated the documentation of CanBookBeIssued to flag up
the assumption re case and the fact that 3 elements rather
than two may be returned
The loop through the returned keys was a bit bogus
so we now explicitly jump out if noerror is unset
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438
Kyle M Hall changed:
What|Removed |Added
Attachment #61738|0 |1
is obsolete||
--- Comment #23 from Kyle M Hall ---
Created attachment 64264
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64264&action=edit
Bug 15438: Stop leaking data into SIP screen message
The returns from C4::Circulation::CanBookBeIssued used
to be structured as a hashref of entries like
REASON => {
data => 'foo',
moredata => 'bar',
};
Some entries still are. But many are now
REASON => 1,
data => 'foo',
moredata => 'bar',
The sip Checkout routine still assumed the former, as it
reports any causes it was not aware of (to maintain support for
a changing api) The data fields could leak into the screen message
field of the response. e.g. the borrowernumber or surname of the
borrower who has a hold on an issued title. Some real messages were
getting obscured by this
This patch sanatizes the return from from CanBookBeIssued
by removing keys which are not all uppercase
It also fixes a case where the key's data element was used
for the screen message when we should use the key itself
Updated the documentation of CanBookBeIssued to flag up
the assumption re case and the fact that 3 elements rather
than two may be returned
The loop through the returned keys was a bit bogus
so we now explicitly jump out if noerror is unset
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15438] Checking out an on-hold item sends holder' s borrowernumber in AF (screen message) field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15438 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796 Marc Véron changed: What|Removed |Added Attachment #64261|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 64263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64263&action=edit Bug 18796: Allow to print notice while claiming serials It can be useful to have a printable version of a claim notice, for testing purposes or for when supplier has no email address for example Test plan: 1. Go to Serials > Claims and select a vendor 2. Select some serials by clicking on checkboxes 3. Click to the little arrow next to 'Send notification' button and click on 'Print notification' 4. Verify that the downloaded PDF contains the content of the selected notice 5. Verify that the 'Send notification' button still works as before 6. Run `prove t/db_dependent/Letters.t` Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18791] Add the ability for librarians to easily copy, download or print DataTables based tables in Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Marc Véron changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18790 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18790] Add ability to void payments
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=16486 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #7 from Jonathan Druart --- Did you update the po file correctly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18797] t/db_dependent/rollingloans.t is skipping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 M. Tompsett changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||ldjami...@marywood.edu, ||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18797] New: t/db_dependent/rollingloans.t is skipping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18797 Bug ID: 18797 Summary: t/db_dependent/rollingloans.t is skipping Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: mtomp...@hotmail.com QA Contact: testo...@bugs.koha-community.org t/db_dependent/rollingloans.t is need of a refactor using TestBuilder to correct its current lack of usefulness. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11443] Refactoring code sending basket from OPAC/intra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11443 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #6 from Marc Véron --- Re-tested on current master with patch applied, plack + memcached restarted, page reloaded, 2 late orders, CSV export, open in editor, result (in one line): ORDER DATE,ESTIMATED DELIVERY DATE,VENDOR,INFORMATION,TOTAL COST,BASKET,CLAIMS COUNT,CLAIMED DATE"2017-06-13 (0 days)","06/13/2017","PROBESHOP","Schokolade Author: Testmann, Hans.","1.00 x 1 = 1.00 (Fund 1)","Probebasket 1 (1)","0","""2017-06-13 (0 days)","06/13/2017","PROBESHOP","Republik im Fokus Author: Hanisch, Ernst.","2.00 x 1 = 2.00 (Fund 1)","Probebasket 1 (1)","0","",,Total orders in late, 2 If I add the [% '' %] to koha-tmpl/intranet-tmpl/prog/en/includes/empty_line.inc I get 4 lines (as expected): ORDER DATE,ESTIMATED DELIVERY DATE,VENDOR,INFORMATION,TOTAL COST,BASKET,CLAIMS COUNT,CLAIMED DATE "2017-06-13 (0 days)","06/13/2017","PROBESHOP","Schokolade Author: Testmann, Hans.","1.00 x 1 = 1.00 (Fund 1)","Probebasket 1 (1)","0","" "2017-06-13 (0 days)","06/13/2017","PROBESHOP","Republik im Fokus Author: Hanisch, Ernst.","2.00 x 1 = 2.00 (Fund 1)","Probebasket 1 (1)","0","" ,,Total orders in late, 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18740] [16.05.12-16.05.13] Cannot modify patron password
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18740 Jonathan Druart changed: What|Removed |Added Resolution|--- |FIXED Status|Signed Off |RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18749] xt/sample notices fails with "No sample notice to delete"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Jonathan Druart changed: What|Removed |Added Depends on||17855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17855] New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 Jonathan Druart changed: What|Removed |Added Blocks||18749 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 [Bug 18749] xt/sample notices fails with "No sample notice to delete" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18749] xt/sample notices fails with "No sample notice to delete"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Patch complexity|String patch|Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18749] xt/sample notices fails with "No sample notice to delete"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18749] xt/sample notices fails with "No sample notice to delete"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18749 Jonathan Druart changed: What|Removed |Added Attachment #64180|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 64262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64262&action=edit Bug 18749 - xt/sample_notices.t fails Bug Description: When performing a unit test on xt/sample_notices.t with the command 'prove xt/sample_notices.t' 11 tests fail with the error message "No sample notice to delete". Cause of bug: The failures are caused by an incorrect file path on Line 25 of xt/sample_notices.t. Patch Description: This patch corrects the failures by changing $base_notices_file from "en/default/sample_notices.sql" to "en/mandatory/sample_notices.sql" Test Plan: 1) Drop into koha-shell and run the command 'prove xt/sample_notices.' 2) 11 unit tests fail. 3) Apply the patch. 4) Re-run 'prove xt/sample_notices.t' 5) All of the tests pass now. 6) Quit out of koha-shell Signed-off-by: Josef Moravec Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Jonathan Druart changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18756] Users can view aq.baskets even if they are not allowed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18756 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- Christophe, please provide tests for this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18728] use html filter in suggestions datatable sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18728
--- Comment #7 from Jonathan Druart
---
I used the following script to generate the data:
use Modern::Perl;
use t::lib::TestBuilder;
my $builder = t::lib::TestBuilder->new;
my $type = 'Suggestion';
my $number = 100;
if ( $type eq 'Suggestion' ) {
for ( 1 .. $number ) {
my $managed_by = $builder->build({ source => 'Borrower' });
my $suggested_by = $builder->build({ source => 'Borrower' });
$builder->build({ source => 'Suggestion', value => { STATUS =>
'pending', managedby => $managed_by->{borrowernumber}, suggestedby =>
$suggested_by->{borrowernumber} } });
}
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18728] use html filter in suggestions datatable sort
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18728 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #6 from Jonathan Druart --- Sounds like it is already correctly sorted without the patch. Asking for another signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18792] Batch Patron Modification does not modify borrower home branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18792 Lucy Vaux-Harvey changed: What|Removed |Added CC||lucy.vaux-harvey@ptfs-europ ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18634] Missing empty line at end of opac.pref
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18634 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #21 from Jonathan Druart --- Can we have a test plan and screenshot please? That will ease the understanding. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201 --- Comment #9 from Marcel de Rooy --- (In reply to Nick Clemens from comment #8) > So if I understand you Marcel, the work to be done is- > 1 - Move all the checkboxes into a 'Select items to export' box > 2 - Remove "Don't export items:" & "Remove non-local items:" from the > 'Options' section > 3 - Add "Don't export records without items" to the 'Options' section > 4 - The option in #3 would be applied after the item selections Well, depends of course on what you mean with "all the checkboxes" :) If I am reading this again, I am still wondering if users will understand. Main problem might be: What means "itemtype BKS"? Or "library ABC"? Does this only affect item selection, or only biblio selection or both? Itemtype BKS => all biblios having a BKS item (and not the other items) seems the most logical? Library ABC => all biblios having a ABC item (not the other items) ? Note that having an ABC item should not(!) be worded as "owned by ABC". So, in both cases we apply the selection to both biblio and item level. Would you agree? Here we need some user feedback ! Sorry, this comment is indeed a move of position. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18732] Noisy t/ SMS.t triggered by koha_conf.xml without sms_send_config
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18732 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #8 from Jonathan Druart --- I do not think the behaviour is correct, C4::SMS::send_sms should just do nothing if the config is missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18331] CSV exports need to be fixed once and for all
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18331 --- Comment #5 from Jonathan Druart --- I have retested and it works for me (late orders). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #2 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 --- Comment #75 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #74) Most of the code from this bug report will be replaced with patches from bug 18298. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796 --- Comment #1 from Julian Maurice --- Created attachment 64261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64261&action=edit Bug 18796: Allow to print notice while claiming serials It can be useful to have a printable version of a claim notice, for testing purposes or for when supplier has no email address for example Test plan: 1. Go to Serials > Claims and select a vendor 2. Select some serials by clicking on checkboxes 3. Click to the little arrow next to 'Send notification' button and click on 'Print notification' 4. Verify that the downloaded PDF contains the content of the selected notice 5. Verify that the 'Send notification' button still works as before 6. Run `prove t/db_dependent/Letters.t` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18796] Allow to print notice while claiming serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18796] New: Allow to print notice while claiming serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18796 Bug ID: 18796 Summary: Allow to print notice while claiming serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Serials Assignee: julian.maur...@biblibre.com Reporter: julian.maur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com It can be useful to have a printable version of a claim notice, for testing purposes or for when supplier has no email address for example -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18298] Enforce password complexity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #41 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #38) > Did you know that there is already a bug for this feature? How do you want us to know about it? Status is "New", patches have been submitted 2 years ago and do no longer applied, changes are not covered by tests, etc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 --- Comment #2 from Kyle M Hall --- Created attachment 64260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64260&action=edit Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18759] Circulation.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18759 --- Comment #15 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #11) > Marcel, your errors look different that ones from Jenkins. > Yours should be fixed with this patch (I recreated mocking > IndependentBranches=1) > > Last patch pushed to master! Yeah. That was enough. Thx -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #30 from Jonathan Druart --- Created attachment 64259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64259&action=edit Bug 17680: C4::Circulation - Remove GetItemIssue, complex calls There are a few calls to GetItemIssue where it's not as easy to make sure everything will be fine just replacing the calls with a Koha::Issues->find - In AddReturn the overdue flag is used (that's why this patch depends on bug 17689) - In CanBookBeRenewed, as well as the overdue flag the dates converted to DateTime were used. It's now our job to convert them when we need them. - Same in AddRenewal but we also call _CalculateAndUpdateFine, so we need to update the variables in this subroutine. Note that, prior to this patch, AddReturn returned the GetItemIssue hashref in the $iteminformation. Most of the time this variable is not used, I have found only 1 place where it's used: circ/returns.pl TODO: In this script we should call ->is_overdue instead of the DateTime->compare calls Test plan: All the circulation tests must pass (it's how I have caught the specific cases). Do some checkins/checkouts/renewal and focus on the due date Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Jonathan Druart changed: What|Removed |Added Attachment #62102|0 |1 is obsolete|| Attachment #62103|0 |1 is obsolete|| Attachment #62104|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 64257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64257&action=edit Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls C4::Circulation::GetItemIssue returned all the issue and item informations for a given issue. Moveover it also did some date manipulations. Most of the time this subroutine was called, there additional information were useless as the caller usually just needed the basic issue's infos 'from the issue table). This first patch updates the simple calls, ie. the ones that just need the issue's infomations. Test plan: The following operations should success: - transfer a book - create a rule for on-site checkouts and confirm that a patron cannot check more items out that it's defined in the rule. - Renew an issue using ILSDI - Using SIP confirm that you are able to see your issues Followed test plan, works as expected Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 --- Comment #29 from Jonathan Druart --- Created attachment 64258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64258&action=edit Bug 17680: C4::Circulation - Remove GetItemIssue This patch simply removes the C4::Circulation::GetItemIssue subroutine Test plan: At this point, `git grep GetItemIssue` should not return any occurrence in the codebase Signed-off-by: Alex Buckley Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17680] C4::Circulation - Replace GetItemIssue with Koha::Checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17680 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18298] Enforce password complexity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #40 from Katrin Fischer --- Why would one want different policies per patron category? I don't feel this level of granularity would be necessary here - I'd prefer a global setting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171 Kyle M Hall changed: What|Removed |Added Assignee|n...@bywatersolutions.com |k...@bywatersolutions.com CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771 --- Comment #4 from Lee Jamison --- Not at all! I'll take a look at it this morning -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18771] CGI.pm: Subroutine multi_param redefined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18771 M. Tompsett changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||ldjami...@marywood.edu Severity|enhancement |minor --- Comment #3 from M. Tompsett --- I figured a side trip to a fresh web install after > drop database koha_library; > create database koha_library; would kind of tie into the fixing tests that we are doing with making tests more robust. Hope you don't mind being added, Lee and Jonathan. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18760] printable checkin alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Alex Arnaud changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18760] printable checkin alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 --- Comment #1 from Alex Arnaud --- Created attachment 64256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64256&action=edit Bug 18760 - Add item printable checkin alert field Test plan: - Apply this patch(es), - update databases, - launch misc/devel/update_dbix_class_files.pl, - edit an item to have html or text content in chekin_alert (may need a koha to marc mapping for gui edition), - check out this item, - check it in: you should get a modal showing the alert, - check that you can print the alert. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18760] printable checkin alerts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18760 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18298] Enforce password complexity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298 --- Comment #39 from Olli-Antti Kivilahti --- The important thing is that one doesn't add any more sysprefs. There are too many as is. Add a borrower category parameter, 'passwordpolicy' and configure the password policy per borrower category. Maybe even the password minSize can be set there. Much more flexible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi --- Comment #74 from Olli-Antti Kivilahti --- There already is an implementation for this feature. Bug 12617 I recommend you avoid adding new sysprefs and use borrower category parameters instead. There are way too many sysprefs already. Think on how to remove excess, not add new ones. See Bug 12617. The way the patches are split to separate pieces is pretty cool. This would be a great tutorial on how to write code for Koha! I believe the RM can squash these together when pushing to master. Personally I cannot find enough integrity to keep the code commits in such small and condensed chunks. Should be small enough steps for the community small-steps-guideline. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 --- Comment #2 from Lari Taskula --- Doesn't apply at the moment and needs to be rebased once Bug 18137 and Bug 17005 move forward. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Lari Taskula changed: What|Removed |Added Blocks||18795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 [Bug 18795] REST API: DELETE (anonymize) checkout history -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Lari Taskula changed: What|Removed |Added Depends on||17005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 [Bug 17005] REST API: add routes to list checkouts history -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 --- Comment #1 from Lari Taskula --- Created attachment 64255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64255&action=edit Bug 18795: DELETE (anonymize) checkout history Anonymize patron's checkout history via REST API DELETE /checkouts/history?borrowernumber=123 To test: 1. prove t/db_dependent/api/v1/checkoutshistory.t 2. Manually send DELETE request to /api/v1/checkouts/history?borrowernumber=123 where 123 is your patron's borrowernumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18795] New: REST API: DELETE (anonymize) checkout history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Bug ID: 18795 Summary: REST API: DELETE (anonymize) checkout history Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: lari.task...@jns.fi QA Contact: testo...@bugs.koha-community.org Anonymize patron's checkout history via REST API DELETE /checkouts/history?borrowernumber=123 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity /difficulty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 Olli-Antti Kivilahti changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18424 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18424] Implement different password strength settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18424 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi --- Comment #2 from Olli-Antti Kivilahti --- There already is an implementation for this feature. Bug 12617 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
