[Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA)

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

--- Comment #15 from David Cook  ---
(In reply to Marcel de Rooy from comment #14)
> No moves here yet?

Not that I know of. It's been on my to do list for a long time, but there have
been other priorities. Still an issue though I believe.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18949] OPAC MARC details holdings table is not styled with

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |alei...@catalyst.net.nz
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18949] OPAC MARC details holdings table is not styled with

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949

--- Comment #1 from Aleisha Amohia  ---
Created attachment 65087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65087=edit
Bug 18949: Adding thead tags to OPAC MARC details holdings table

So that it can be styled alongside other tables in the OPAC.

To test:
1) Log into staff side
2) Find OPACUserCSS syspref and add the following CSS:
th,
.table-bordered>thead>tr:first-child>th {
color: red;
}
3) Log into the OPAC
4) Go to your fines, your search history, your reading history etc -
notice all of these table's headings are styled with red text
5) Go to the detail page of an item, then the MARC view.
Notice this table's headings are now styled with red text
6) Apply patch and refresh page
7) Your holdings table should now have red headings.
(You can delete the CSS from OPACUserCSS if you'd like.)

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18949] OPAC MARC details holdings table is not styled with

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949

Aleisha Amohia  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18949] New: OPAC MARC details holdings table is not styled with < thead>

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18949

Bug ID: 18949
   Summary: OPAC MARC details holdings table is not styled with

 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: alei...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

The MARC details holdings table in the OPAC does not have  around the
header row, which means it doesn't get styled the same way as the other tables
in the OPAC. This is more noticeable when you adding custom styles and themes
to OPAC tables, where they don't get applied to this table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18910] Regression: Z39.50 wrong conversion in Unimarc by Bug 18152

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18910

--- Comment #4 from Zeno Tajoli  ---
Jonathan, OK on revert, but I sugggest also a comment about bad Unimard
haldling in MARC::Record library.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18948] Elasticsearch - Reindexes should use aliases to avoid down time while reindexing

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948

Nick Clemens  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||k...@bywatersolutions.com,
   ||ldjami...@marywood.edu,
   ||tomasco...@gmail.com

--- Comment #2 from Nick Clemens  ---
TODO:
1 - Ensure if records are indexed incrementally before first rebuild that an
alias is used
2 - Unit tests

Other comments welcome, this was first round proof of concept

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18948] Elasticsearch - Reindexes should use aliases to avoid down time while reindexing

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948

--- Comment #1 from Nick Clemens  ---
Created attachment 65086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65086=edit
Bug 18948 - Elasticsearch - Reindexes should use aliases to avoid down time
while reindexing

To test:
1  - Delete your current indices for ES (if any)
2  - Reindex your records
3  - curl -XGET 'localhost:9200/koha_kohadev?pretty'
4  - Note indices are now of form koha_kohadev_##
5  - The numbers there are a result of appending 'time' command to name
6  - Ensure searching works as before the patches
7  - Reindex your records with a commit setting of 1 (to slow things
down) you may need a large numebr fo records
8  - Ensure searching works during reindex
9  - Ensure reindexing completes successfully
10 - curl -XGET 'localhost:9200/koha_kohadev?pretty'
11 - There should only be one index each for biblios and authorities
** - Note number in above
12 - Perform a partial reindex by passing a biblionumber to the command
13 - Curl the indices again and ensure number/name has not changed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

--- Comment #21 from Jonathan Druart  
---
The last patch has been pushed to master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18948] New: Elasticsearch - Reindexes should use aliases to avoid down time while reindexing

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948

Bug ID: 18948
   Summary: Elasticsearch - Reindexes should use aliases to avoid
down time while reindexing
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: n...@bywatersolutions.com
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

This patchset aims to add the ability to leverage the ES alias feature during a
reindex - when doing a full reindex or a deletion the indexer will look for an
existing index under the alias - if not found it will create a new one, if
found it will index into a new index and point the alias there when done and
then delete the old index.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

--- Comment #20 from Jonathan Druart  
---
Created attachment 65085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65085=edit
Bug 18262: Fix C4::XISBN

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #13 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18832] Missing space between icon and label in button 'Patron lists'

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18832

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18672] Creation Date and Modification Date are the same for a list in the Lists Module

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18672

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #15 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18613] Deleting a Letter from a library as superlibrarian deletes the " All libraries" rule

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18613

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18910] Regression: Z39.50 wrong conversion in Unimarc by Bug 18152

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18910

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=18152   |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18152] UNIMARC bib records imported with invalid 'a' char in label pos.9

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18152

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=18910   |
 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #30 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #29)
> This patch introduced a regression, please provide a patch ASAP on bug 18910.

I suggest to revert these 2 patches, Rmaints please take a look at bug 18910.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18910] Regression: Z39.50 wrong conversion in Unimarc by Bug 18152

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18910

--- Comment #3 from Jonathan Druart  
---
Created attachment 65084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65084=edit
Bug 18910: Revert "Bug 18152 : fix unimarc label in SetMarcUnicodeFlag"

This reverts commit bf551a07222a7b9beffd7ca6cba38c675aa3ab28.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18910] Regression: Z39.50 wrong conversion in Unimarc by Bug 18152

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18910

--- Comment #2 from Jonathan Druart  
---
Created attachment 65083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65083=edit
Bug 18910: Revert "Bug 18152: Add tests"

This reverts commit a807d7199ea025aa507e0ca7e3ff2330902844f8.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18910] Regression: Z39.50 wrong conversion in Unimarc by Bug 18152

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18910

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947

Sven Coenye  changed:

   What|Removed |Added

Summary|Active Directory LDAP   |Unexpected Active Directory
   |authentication broken   |LDAP authentication failure
   ||mode

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18615] LDAP configuration error causes server resource depletion under Plack

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18615

--- Comment #3 from Sven Coenye  ---
2017.05 has exposed a addition way to trigger this condition.

2016.11 and prior did not need defined values for  and  in the
ldapserver configuration block in koha-conf.xml. A change in Auth_with_ldap.pm
(see bug 18947) causes KOHA to attempt an anonymous bind unless user and pass
are defined, regardless of whether these values will be used or not. This
causes Active Directory to reject the attempted login. This rejection is
unexpected and is trapped by a "die" clause, causing Plack to enter the death
spiral.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18947] New: Active Directory LDAP authentication broken

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947

Bug ID: 18947
   Summary: Active Directory LDAP authentication broken
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: Linux
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: helpd...@neci.edu
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

Commit 68c365ea8ab536a85d92d3769b0bbaa0e1691116 introduced the following line
in Auth_with_ldap.pm:

$ldap->{anonymous_bind} = 1 unless $ldapname && $ldappassword;

There is no comment in the code or the Git commit log as to why.

This change silently overrides the settings in koha-conf.xml and causes a
previously functional setup with LDAP authentication against Active Directory
to fail unless koha-conf.xml defines values for  and . As user and
pass are only used if auth_by_bind and anonymous_bind are both false, their
values should not come into play in the other cases.

Prior to this change, KOHA would bind against AD with the user supplied
credentials, as expected. With the change, KOHA attempts an anonymous bind and
then tries to search for the supplied user name. As there was no valid bind in
place, AD rejects the attempt.

Workaround: enter some value for  and  in the ldapserver
configuration block. These do not have to be real credentials as KOHA will not
attempt to use them now that auth_by_bind has priority again.

Note: there is an apparent duplicate attempt to do the same further down, by
setting $config{anonymous} to ($ldapname and $ldappassword) ? 0 : 1, although
that key is not used anywhere in Auth_by_ldap.pm

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #23 from Jonathan Druart  
---
Sent back to the RMaint queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616
Bug 18616 depends on bug 16711, which changed state.

Bug 16711 Summary: OPAC Password recovery: Handling if multiple accounts have 
the same mail address
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|FIXED   |---
   Severity|enhancement |normal
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16711] OPAC Password recovery: Handling if multiple accounts have the same mail address

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16711

Jonathan Druart  changed:

   What|Removed |Added

 Status|REOPENED|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||tomasco...@gmail.com
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 65082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65082=edit
Bug 18942: (QA followup) Add new tests descriptions

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65078|0   |1
is obsolete||

--- Comment #11 from Tomás Cohen Arazi  ---
Created attachment 65081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65081=edit
Bug 18942: Simplify syntax

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65056|0   |1
is obsolete||

--- Comment #10 from Tomás Cohen Arazi  ---
Created attachment 65080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65080=edit
Bug 18942: Internal Server Error symptomatic of using system user

TEST PLAN
-
1) sudo koha-shell -c bash kohadev
2) prove -v t/Budgets/CanUserUseBudget.t
   -- works
3) prove -v t/Budgets/CanUserModifyBudget.t
   -- works
4) exit
5) git bz apply 18942
   -- interactive just the test patch
6) repeat steps 1-4
   -- prove fails (similar message with 919 in comment #0)
7) git bz apply 18942
   -- interactive just the actual fix
8) repeat steps 1-4
   -- works
9) run koha qa test tools

Signed-off-by: Lee Jamison 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #65055|0   |1
is obsolete||

--- Comment #9 from Tomás Cohen Arazi  ---
Created attachment 65079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65079=edit
Bug 18942: Add test case to prove change

Signed-off-by: Lee Jamison 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18527] Add a system preference to exclude renewals from the quick slip

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18527

--- Comment #10 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #9)
> Can we document how this would work with TT?
> 
> Excluding the renewed ones = removing checkouts with last renewal today?

Since you have Koha::Objects based objects and the power of TT, you can do
whatever you like.

Something like the following should achieve the same goal.

[% SET today_date = today | $KohaDates %
[% FOREACH checkout IN checkouts %]
[% IF checkout.renewals %]
This checkout has been renewed [% checkout.renewals %] times.
[% SET last_renewal_date = checkout.lastreneweddate | $KohaDates %]
[% IF today_date == last_renewal_date%]
It has been renewed today!
[% END %]
[% ELSE %]
This checkout has never been renewed.
[% END %]
[% END %]

You can use today.substr instead of the the KohaDates filter if you prefer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18929] Merging records mandate 003 and 040 fields though in framework its not mandatory

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18929

--- Comment #3 from Jonathan Druart  
---
It works for me using the "default framework". 003 is first mandatory, but if I
remove the mandatory flag I am allowed to merge the 2 records.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

--- Comment #8 from Jonathan Druart  
---
Created attachment 65078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65078=edit
Bug 18942: Simplify syntax

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

--- Comment #7 from Jonathan Druart  
---
Login with DB user is not allowed, the only 2 available actions are 1. Create a
patron and 2. Set the superlibrarian permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user test cases

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||17829


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829
[Bug 17829] Move GetMember to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18942
[Bug 18942] CanUserUseBudget.t and CanUserModifyBudget.t missing system user
test cases
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7374] can't upload icon for auth values

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7374

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Patch doesn't apply

--- Comment #8 from Jonathan Druart  
---
Patch does not apply:
error: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt).   
error: could not build fake ancestor 

You should also correct the email address and the name of the author of the
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18428] move of holds to old_reserves is not handled correctly.

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18428

Jonathan Druart  changed:

   What|Removed |Added

URL||https://wiki.koha-community
   ||.org/wiki/DBMS_auto_increme
   ||nt_fix

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572

--- Comment #7 from Jonathan Druart  
---
Please also double check the indentation in tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18572] Improper branchcode set during OPAC renewal

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18572

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |Failed QA

--- Comment #6 from Jonathan Druart  
---
Why do not you use C4::Context->interface instead of adding a new parameter to
this subroutine?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412

sch...@uthscsa.edu changed:

   What|Removed |Added

 CC||sch...@uthscsa.edu
   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #89 from Mehdi Hamidi  ---
Created attachment 65077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65077=edit
Bug 17015 - Peformance tests for Koha::DiscreteCalendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #88 from Mehdi Hamidi  ---
Created attachment 65076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65076=edit
Bug 17015 - Updated Koha tests to use the new DiscreteCalendar module

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #86 from Mehdi Hamidi  ---
Created attachment 65074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65074=edit
Bug 17015 - Tests for DiscreteCalendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #87 from Mehdi Hamidi  ---
Created attachment 65075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65075=edit
Bug 17015 - Koha now uses the new DiscreteCalendar module

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17015] New Koha Calendar

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #63364|0   |1
is obsolete||
  Attachment #63365|0   |1
is obsolete||
  Attachment #63366|0   |1
is obsolete||
  Attachment #63367|0   |1
is obsolete||
  Attachment #64235|0   |1
is obsolete||

--- Comment #85 from Mehdi Hamidi  ---
Created attachment 65073
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65073=edit
Bug 17015 - DiscreteCalendar UI, Back-End and necessary scripts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18616] The "Add forgot password link to OPAC" should allow patrons to use their library card number in addition to username

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18616

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18468] When adding from a staged file order discounts are not passed into C4:: Acquisitions::populate_order_with_prices

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18468

--- Comment #11 from Jonathan Druart  
---
This patch is a follow-up for bug 15503, that is not in 16.11.x
What is raised on comment 5 must be reported on another bug report as it is
certainly not fixed by this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18632] CGI::param called in list context flooding error logs

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18632

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #63727|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 65072
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65072=edit
[16.11.x] Bug 18632: Remove 'CGI::param called in list context' warnings

Once again, after bug 16154 and bug 16259 we need to remove more
occurrence of CGi->param called in list context.
Refer to bug 15809 for more information.

Test plan:
Make sure you do not see the error on the modified scripts.

Signed-off-by: Josef Moravec 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18946] New: Change language from external web fails

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18946

Bug ID: 18946
   Summary: Change language from external web fails
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ha...@orex.es
QA Contact: testo...@bugs.koha-community.org

We have identified that if you add the url to change language from one external
web to koha, it doesn't work it just send you again to your current web.

How to reproduce:
1. Get a multilingüal Koha like 
http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=en
http://demo1.orex.es/cgi-bin/koha/opac-changelanguage.pl?language=es-ES

2. Copy that urls to any web page and try to link to the spanish or english
version,it will keep you in the same position

we suspect is opac-changelanguage.pl becuase it gets the url from the referer
and then construct a wrong url becuase of the referer... If 

#my $url  = $query->referer() || '/';
my $url= 'https://whatever/';

it works.. because we force the referer to the koha host domain

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11046] keeping uncertain or range dates in publicationyear and copyright date

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046

--- Comment #1 from Marcel de Rooy  ---
(In reply to mathieu saby from comment #0)
> In C4:Biblio::TransformMarcToKoha, publicationyear and copyrightdate are
> filled from MARC dates.
> MARC dates could be uncertain. like "200X", "2012?", "ca. 2012".
> If there is a "X" or a blank, the date is not copied in database.
> Maybe this could be fixed. But in that case, publicationyear and
> copyrightdate will sometimes contain non numerical data. Maybe that's an
> issue?
> 
> Sometime MARC dates are a range, like "2010-2013". In that case, Koha is
> currently using only the first one. Why not both?

I would feel for saving 18.. or 18XX etc. to 1800. Or 197X to 1970. Etc.
We cannot save two dates in one field obviously. So we have to choose and pick
the first one.

> Last remark : In UNIMARC, I don't know the difference between
> publicationyear and copyrightdate. Is it obvious for MARC21 people ?
In Koha the UNIMARC side uses publicationyear and MARC21 uses copyrightdate.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA)

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #14 from Marcel de Rooy  ---
No moves here yet?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18877] Outdated explanation of use when two patches applied

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18877

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #2 from Lee Jamison  ---
testing 2 commit(s) (applied to 3d24c19 'Bug 14533: remove CREATE USER when
ko')

Processing files before patches

Processing files after patches


kohadev-koha@kohadevbox:/home/vagrant/kohaclone$


It appears that applying this patch breaks QA Tools for some reason.

Failing QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18945] New: UseQueryParser system preference breaks subject searches

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18945

Bug ID: 18945
   Summary: UseQueryParser system preference breaks subject
searches
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: je...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 65071
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65071=edit
ScreenShot1

Steps to recreate.

1.Check and make sure UseQueryParser system preference is set to "Don't Try"
2.Preform a search in koha.
3.From an items detail page click on a subject heading.
4.Koha will return results.

Next - Turn on UseQueryParser and follow same steps.

This will cause Koha to break.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17505] REST API: Add route for messaging preferences

2017-07-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505

--- Comment #10 from Lari Taskula  ---
The only dependencies are Bug 18137 and Bug 17499... Are you sure all patches
from Bug 18137 were applied? (Especially the "sort definitions.json"?) Because
otherwise I don't see why it has an issue in definitions.json... However Bug
18137 needs a rebase anyway since it conflicts in the Holds controller after
Bug 18276 and Bug 18260.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/