date:20170822

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #66 from Srdjan Jankovic  ---

> but then we're also keeping all the data for all the
> different sites accessible in memory by the same process which could allow
> things to leak across if we're not careful (booo). 

That was exactly my point with Context. There should be no references to
*anything* external (db, cache etc handles) outside Context. Now because we are
still in this CGI frame of mind, we have all this horrible singletons. Once we
are able to instantiate contexts and keep them in app containers, and pass them
to request handlers we will be safe.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #65 from David Cook  ---
(In reply to Srdjan Jankovic from comment #64)
> Well did not think of that... It should be limited by resources available,
> not the application itself. It should...
> 

I suppose I was just thinking in terms of any leaks, but hopefully it won't
leak anywhere!

> I'm quite sure this will never see the light of day (although I did get it
> going), just too hard. However, I want to keep it alive for various reasons.
> The main one is: the fact that this *is* too hard tells that we are doing
> some things fundamentally wrong. Workarounds devised here (and most of it is
> exactly that - workarounds) should help understanding the problems better.
> Koha is being heavily optimised for the container per site scenario, but
> "abstractly thinking" I don't see why we should not be able to share the
> code. In a real world scenario you could imagine a cluster of small poor
> schools benefiting from that.
> 

Well, I was thinking about that from a security perspective. At the moment,
we're already sharing the code, but since it's CGI it loads it up in separate
processes on the fly. If we're using multiple sites with Plack managed by a
single process, then we're loading the code into memory once (yay for
efficiency!) but then we're also keeping all the data for all the different
sites accessible in memory by the same process which could allow things to leak
across if we're not careful (booo). 

It would be too bad if this didn't see the light of day since I imagine there
would be lots of people wanting to host multiple Koha instances with the same
Plack instance, but I do wonder a bit how feasible it would be, although surely
people do it with other apps or URLMap wouldn't exist, yeah? 

Actually, I've been thinking about Tomcat a bit lately as well. I reckon it
would work similarly to Plack. You define a number of URL routes and then
specify the code that you want to run for each route. So you can have lots of
Java apps running under the same single Tomcat instance. I don't know how it
separates them so that they don't overlap of course. 

I suppose Tomcat might do it by virtue of Java apps being written to be run on
Tomcat whereas we've been shoehorning Koha to work with Plack. 

> One day we will get rid of C4 and re-engineer Context, no CGI .pl... Maybe
> even move to static pages and API... Then this will become obsolete. But
> good to have it as a reference, until that happens.
> 
> And thanks for your wishes :) Public transport is useful even when it's
> horrible.

I've been thinking for a while how nice it would be to separate the staff
client and the OPAC. If I'm not mistaken, there are far fewer OPAC scripts than
Staff Client scripts, so in theory writing a new OPAC would be easier than
writing a new staff client. So we could build a new OPAC from the ground up
that works with Plack natively. I figure library patrons should probably be the
ones that demand the best performance, so why not start there, yeah?
(Alternatively, if a separate OPAC is possible, it wouldn't even necessarily
have to be written in Perl. Also, if we used APIs, we could use static pages
with Javascript or people could access the APIs from their own websites and
then we don't even have to worry about providing an OPAC - just maintaining the
API.)

Then maybe once the OPAC is separated out, we could work on overhauling the
staff client bit by bit. 

That's my pie in the sky dream ;). 

Alas, I have too much other work to do, but it's a dream I have nonetheless...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18999] Acq: Shipping cost not included in total spent on acq home and funds page

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18999

--- Comment #8 from Alex Buckley  ---
Created attachment 66378
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66378=edit
Bug 18999 - Added regression test

Added regression test for GetBudgetSpent() and GetBudgetOrdered() into
the t/db_dependent/Budgets.t

Test plan:
1. Go into your koha-shell

2. set the PERL5LIB variable

3. Run t/db_dependent/Budgets.t

All tests should pass

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #64 from Srdjan Jankovic  ---
Well did not think of that... It should be limited by resources available, not
the application itself. It should...

I'm quite sure this will never see the light of day (although I did get it
going), just too hard. However, I want to keep it alive for various reasons.
The main one is: the fact that this *is* too hard tells that we are doing some
things fundamentally wrong. Workarounds devised here (and most of it is exactly
that - workarounds) should help understanding the problems better. Koha is
being heavily optimised for the container per site scenario, but "abstractly
thinking" I don't see why we should not be able to share the code. In a real
world scenario you could imagine a cluster of small poor schools benefiting
from that.

One day we will get rid of C4 and re-engineer Context, no CGI .pl... Maybe even
move to static pages and API... Then this will become obsolete. But good to
have it as a reference, until that happens.

And thanks for your wishes :) Public transport is useful even when it's
horrible.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

--- Comment #63 from David Cook  ---
I keep thinking about this abstractly when I'm waiting for public transport,
and still wishing you all the best Srdjan. 

I keep wondering what the threshold is for number of Koha sites on a single
Plack server...

I suppose a person would use Apache or Nginx as the reverse proxy (so many
virtual hosts configured there) and have them funneling traffic to a particular
Plack server (or servers I suppose if we wanted to scale up)?

Anyway, Srdjan++.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #60725|0   |1
is obsolete||

--- Comment #61 from Srdjan Jankovic  ---
Created attachment 66376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66376=edit
bug_15562: Multi-host helper for plack installations

Sort of an apocalypse
* C4::Context->new() must be called with at least config file param.
  If you want current context, call C4::Context->current().
  C4::Context->some_method() will still work as is.
* Koha::Database->new_schema() now takes optional context param.
* C4::Context->set_context() and restore_context() are synched with
  database set_schema() and restore_schema().
  Created run_within_context() that wraps set_context() and
  restore_context() around code.
* Created Koha::Handler::Plack* to facilitate running same code within
  different (database) contexts.
* This initial version does not run with memcached turned on. Next patch
  will correct that.

https://bugs.koha-community.org/show_bug.cgi?id=15562

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #60726|0   |1
is obsolete||

--- Comment #62 from Srdjan Jankovic  ---
Created attachment 66377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66377=edit
bug_15562: Removed Koha::Caches->get_instance()

There should be no cache singletons, full stop. If Koha is to move away
from .pl scripts that is.
As an interim measure Koha::Caches->get_instance() is replaced with
C4::Context->cache. In that respect it will continue to work in the
singleton-ish way if context is used as a singleton, but supports
cache-per-context.

Koha::Handler::Plack->app_per_host() cache sysprefs using Context memcached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #60724|0   |1
is obsolete||

--- Comment #60 from Srdjan Jankovic  ---
Created attachment 66375
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66375=edit
[SIGNED-OFF] bug_15562: Revert "Bug 13690: use Koha::Schema only when it's
needed"

This reverts commit c52bc9756a5fa1e4f6bba7ce5c58124f150c5efc.

I don't see any place where we would use KOha::Database without wanting
Koha::Schema.
require Koha::Schema interferes with some plack setups - for some reason
it calls C4::Context->import() even when C4::Context is already used.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15562] Make Koha more suitable for shared hosting with plack

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15562

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #60723|0   |1
is obsolete||

--- Comment #59 from Srdjan Jankovic  ---
Created attachment 66374
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66374=edit
[SIGNED-OFF] bug_15562: Use do() rather than system() to execute
updatedatabase.pl from installer.pl

That way:
* no external process is spawned
* code executes in the same perl process, which is required for plack
  multi-site

I have a dream. A dream that one day all code from .pl's will be in some
.pm's.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

Liz Rea  changed:

   What|Removed |Added

  Attachment #66364|0   |1
is obsolete||

--- Comment #6 from Liz Rea  ---
Created attachment 66373
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66373=edit
Bug 19163: Critical typo in stage-marc-import process

Template says ISO2709 but script wants MARC or MARCXML..
Slipped in with bug 19049.
Trivial but critical fix.

Test plan:
Import a MARC file.

Signed-off-by: Tomas Cohen Arazi 
I picked this fix because I think MARC is always ambiguous. ISO2709
clearly denotes the serialization format used.

Signed-off-by: Liz Rea 
Just confirming this fixes the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #109 from M. Tompsett  ---
Created attachment 66372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66372=edit
Bug 14385: Corrected opac-details searchResult call

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19077] When loading patrons matching on userid updates to matched patrons are rejected

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Katrin Fischer  ---
Hi Colin, after Jonathan's fix the update using userid for matching works for
me without the patch. Can you verify?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15239] Add multiple items fail on barcode

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239

Ruben Norori  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15239] Add multiple items fail on barcode

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239

--- Comment #9 from Ruben Norori  ---
I have the definitive solution:
First we must add two new procedures, functions, methods, which consult in the
database the registry homebranch.

#Original function
sub get_item_from_barcode {
my ($barcode)=@_;
my $dbh=C4::Context->dbh;
my $result;
my $rq=$dbh->prepare("SELECT itemnumber from items where items.barcode=?");
$rq->execute($barcode);
($result)=$rq->fetchrow;
return($result);
}

#New function
sub get_home_from_barcode {
my ($barcode)=@_;
my $dbh=C4::Context->dbh;
my $result;
my $rq=$dbh->prepare("SELECT homebranch from items where items.barcode=?");
$rq->execute($barcode);
($result)=$rq->fetchrow;
return($result);
}

#New function
sub get_home_from_item {
my ($barcode)=@_;
my $dbh=C4::Context->dbh;
my $result;
my $rq=$dbh->prepare("SELECT homebranch from items where
items.itemnumber=?");
$rq->execute($barcode);
($result)=$rq->fetchrow;
return($result);
}

Then call the functions and save the result in a variable that we concate at
the final result, also add an "if" to use one function in the first iteration
and the other function executes it in the "else".

for (my $i = 0; $i < $number_of_copies;) {
# If there is a barcode
if ($barcodevalue) {
# Getting a new barcode (if it is not the first iteration
or the barcode we tried already exists)
# For execute only in the first iteration
if($i<1){
# Call new function
my $newv = get_home_from_item($exist_itemnumber);
$barcodevalue = $newv.$barcodeobj->next_value($oldbarcode)
if ($i > 0 || $exist_itemnumber);
}else{
# Call new function 
my $exin = get_home_from_barcode($barcodevalue);
$barcodevalue = $exin.$barcodeobj->next_value($oldbarcode)
if ($i > 0 || $exist_itemnumber);
}
# Putting it into the record
if ($barcodevalue) {
$record->field($tagfield)->update($tagsubfield =>
$barcodevalue);
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11897] Stock Rotation for Koha

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11897

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||tomasco...@gmail.com

--- Comment #150 from Tomás Cohen Arazi  ---
Hi guys, I've been looking at this patchset without trying it yet. Everything
looks as expected :-D
The only thing I would like to mention is that the auth chain added a check for
maintenance mode (usually on upgrades) that requires some more error codes to
be added to the spec. Can you please take a look at (say) patrons.json from bug
18137? It's pretty straightforward.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66340|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 66371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66371=edit
[SIGNED OFF] Add quantity field to the opac suggestions form (with correct
username and email)

https://bugs.koha-community.org/show_bug.cgi?id=19068

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON:: PP::Boolean :)

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #6 from Tomás Cohen Arazi  ---
@RM: I think this tests fix can skip QA. Please revert to SO if you think
another pair of eyes are needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON:: PP::Boolean :)

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #61195|0   |1
is obsolete||

--- Comment #5 from Tomás Cohen Arazi  ---
Created attachment 66370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66370=edit
Bug 18290: Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a
JSON::PP::Boolean :)

Mojolicious 7.21 onwards, no longer returns Mojo::JSON::Bool-objects but
JSON::PP instead.
Which might be pretty smart.

This version is required by bug 18137 and so this patch for the tests is
needed.

Signed-off-by: Tomas Cohen Arazi 
Tested along with 18137 and its dependencies (libs).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON:: PP::Boolean :)

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON:: PP::Boolean :)

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Severity|enhancement |normal
 Depends on||18137
  Component|Architecture, internals,|Test Suite
   |and plumbing|


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137
[Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to
Mojolicious::Plugin::OpenAPI
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18290


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290
[Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a
JSON::PP::Boolean :)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON:: PP::Boolean :)

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18290] Fix t/db_dependent/Koha/Object.t, Mojo::JSON::Bool is a JSON:: PP::Boolean :)

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18290

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #3)
> Tests pass for me, when will we need this patch?

With bug 18137 (or higher Mojolicious versions I suspect).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18282] OpenAPI operationId must be unique

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

--- Comment #7 from Tomás Cohen Arazi  ---
SKipping QA step on a trivial string change.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18282] OpenAPI operationId must be unique

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18282] OpenAPI operationId must be unique

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #61169|0   |1
is obsolete||

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 66369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66369=edit
Bug 18282: operationId must be unique

operationId has the following documentation:
 "Unique string used to identify the operation. The id MUST be unique among all
  operations described in the API."

This patch modifies operationIds to be unique accross our API operations.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14967] update_dbix_class_files.pl should have a default DB name

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14967

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name'

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130

--- Comment #6 from Kyle M Hall  ---
Created attachment 66366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66366=edit
Bug 19130: (followup) Add t/db_dependent/Koha/Acquisition/Booksellers.t

This followup patch adds a proper file in which add tests for
Koha::Acquisition::Bookseller(s) methods.

All current methods are covered.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Koha/Acquisition/Booksellers.t
 => SUCCESS: Test pass!
 - Sign off :-D

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name'

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130

--- Comment #8 from Kyle M Hall  ---
Created attachment 66368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66368=edit
Bug 19130: (followup) Controller scripts should preserve behaviour

This patch is a followup to making
Koha::Acquisition::Booksellers->search work as any other Koha::Objects
(DBIC) query instead of having a different behaviour hardcoded.

To achieve it, this patch makes the controller scripts add
wildcard/truncation chars as prefix and sufix for searches, and make the
default sorting for results be by 'name', ascending.

To test:
- Just verify the behaviour remains unchanged by this patchset on the
controller scripts (re. searching).

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name'

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130

--- Comment #7 from Kyle M Hall  ---
Created attachment 66367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66367=edit
Bug 19130: (followup) Add POD

This patch adds POD to the following files:

- Koha/Acquisition/Bookseller.pm
- Koha/Acquisition/Booksellers.pm

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name'

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #66348|0   |1
is obsolete||
  Attachment #66349|0   |1
is obsolete||
  Attachment #66350|0   |1
is obsolete||
  Attachment #66352|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 66365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66365=edit
Bug 19130: Remove ->search() overloading and adjust tests

This patch removes the custom ->search() function. Tests are adjusted
so the results from ->search() calls are not expected to return in the
previously hardcoded order.

To test:
- Apply this patch
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Bookseller.t
=> SUCCESS: Tests pass
- Sign off :-D

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name'

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Trivial fix, skipping QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66344|0   |1
is obsolete||
  Attachment #66346|0   |1
is obsolete||

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 66364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66364=edit
Bug 19163: Critical typo in stage-marc-import process

Template says ISO2709 but script wants MARC or MARCXML..
Slipped in with bug 19049.
Trivial but critical fix.

Test plan:
Import a MARC file.

Signed-off-by: Tomas Cohen Arazi 
I picked this fix because I think MARC is always ambiguous. ISO2709
clearly denotes the serialization format used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19164] Allow MARC modification templates to be used in staged MARC imports

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

--- Comment #3 from Katrin Fischer  ---
I like using the name as it's easier to remember and harder to confuse. Also
easier to set it up the same on multiple installations. Maybe we could just add
a warning when a non-unique template name is used?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] Allow using MARC modification templates in bulkmarcimport.pl

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #15 from Tomás Cohen Arazi  ---
Hi Jon, the enhancement works as advertised and things look ok :-D

I was wondering if using the template name was the best option, given the
'name' column is not a UNIQUE id.
I saw the UI doesn't show the real DB ID for the MARC modification template, so
I'm not sure what's the best solution.

Please add your comments on how could we make it rock solid.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] Allow using MARC modification templates in bulkmarcimport.pl

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] Allow using MARC modification templates in bulkmarcimport.pl

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|bulkmarcimport.pl does not  |Allow using MARC
   |take notice of MARC |modification templates in
   |modification templates  |bulkmarcimport.pl
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19164] Allow MARC modification templates to be used in staged MARC imports

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Woot!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name'

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18120


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120
[Bug 18120] REST API: CRUD endpoint for vendors
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Depends on||18137, 19130

--- Comment #15 from Tomás Cohen Arazi  ---
Patches rebased on top of bug 18137 (OpenAPI). Test plan applies and tests
pass.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137
[Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to
Mojolicious::Plugin::OpenAPI
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130
[Bug 19130] K::A::Booksellers->search broken for attribute 'name'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18137] REST API: Migrate from Mojolicious::Plugin:: Swagger2 to Mojolicious::Plugin::OpenAPI

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||18120


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120
[Bug 18120] REST API: CRUD endpoint for vendors
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #63164|0   |1
is obsolete||
  Attachment #63165|0   |1
is obsolete||
  Attachment #66046|0   |1
is obsolete||

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 66363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66363=edit
Bug 18120: REST api | Add a 'vendors' endpoint

This patch introduces an /acquisitions/vendors endpoint.
To test:
- Apply the patch
- Run:
  $ sudo koha-shell kohadev
 k$ prove t/db_dependent/api/v1/acquisitions_vendors.t
=> SUCCESS: Tests pass
- Sign off :-D

Sponsored-by: ByWater Solutions

Signed-off-by: Matthias Meusburger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18120] REST API: CRUD endpoint for vendors

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18120

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #63163|0   |1
is obsolete||

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 66362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66362=edit
Bug 18120: REST api | /acquisitions/vendors unit tests

This patch introduces unit tests that need to be passed by an
/acquisitions/vendors/ REST endpoint.

To test:
- Apply the patch
- Run:
  $ sudo koha-shell kohadev
 k$ prove t/db_dependent/api/v1/acquisitions_vendors.t
=> FAIL: The endpoint is not present, should fail.

Sponsored-by: ByWater Solutions

Signed-off-by: Matthias Meusburger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #108 from M. Tompsett  ---
Created attachment 66361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66361=edit
Bug 14385: Improve C4::Record::marcrecord2csv test cases

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19077] When loading patrons matching on userid updates to matched patrons are rejected

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #2)
> Hi Colin, with and without the patch I receive an internal server error when
> I try to match on username/uderid:
> 
> Use of uninitialized value $uploadborrowers in concatenation (.) or string
> at /home/vagrant/kohaclone/tools/import_borrowers.pl line 113.
> Use of uninitialized value $uploadborrowers in concatenation (.) or string
> at /home/vagrant/kohaclone/tools/import_borrowers.pl line 113.
> Can't call method "unblessed" on unblessed reference at
> /home/vagrant/kohaclone/tools/import_borrowers.pl line 255, <$fh> line 2.
> 
> Can you help?

Should be fixed by
  commit 6f595e4c95c22ba444f49c61c9d101483309871f
Bug 17829: (follow-up) Fix import patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

--- Comment #35 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #34)
> Created attachment 66360 [details] [review]
> Bug 17829: (follow-up) Fix import patron

Patch pushed to master!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829

--- Comment #34 from Jonathan Druart  
---
Created attachment 66360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66360=edit
Bug 17829: (follow-up) Fix import patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19077] When loading patrons matching on userid updates to matched patrons are rejected

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19077

Katrin Fischer  changed:

   What|Removed |Added

   Severity|minor   |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #150 from Jonathan Druart  
---
Created attachment 66359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66359=edit
Bug 12598: Re-add bug 18555: Create patron list from patron import

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #149 from Jonathan Druart  
---
Created attachment 66358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66358=edit
Bug 12598 Allow matched patron to be updated

When a test was introduced to not add duplicate userids
it overlooked that if you were matching on userid you
do not want the update to be rejected.

Add a test to overcome this logical flaw if updating
by matching userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #148 from Jonathan Druart  
---
Created attachment 66357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66357=edit
Bug 12598: Re-add some missing stuffs

This patch will have to be squashed with previous ones, but for
readability I prefer to let it alone for now.

It reintroduces 2 missing changes:
  commit fd123903651435c56ca14d88897e9ce4d7a38bb5
Bug 15010: Import patron tool creates 'duplicate' restrictions (
debarments )
  commit 011d8e9855ffeb1779f5c1aadc9f4367c298cee7
Bug 12543 - Add userid as matchpoint for "Import patrons" tool

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #147 from Jonathan Druart  
---
Created attachment 66356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66356=edit
Bug 12598: Fix conflict with 17829 - GetMember

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #146 from Jonathan Druart  
---
Created attachment 66355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66355=edit
Bug 12598: Fix conflict with bug 16911

Tests will have to be written for this change

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #145 from Jonathan Druart  
---
Created attachment 66354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66354=edit
Bug 12598: Update code to use new modules

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #65819|0   |1
is obsolete||
  Attachment #65820|0   |1
is obsolete||
  Attachment #65821|0   |1
is obsolete||
  Attachment #65822|0   |1
is obsolete||
  Attachment #65823|0   |1
is obsolete||
  Attachment #65824|0   |1
is obsolete||

--- Comment #144 from Jonathan Druart  
---
Created attachment 66353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66353=edit
Bug 12598: New misc/import_borrowers.pl command line tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18786] Add ability to create custom payment types

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786

--- Comment #10 from Martha Fuerst  ---
Got the following error when trying to pay a lost item charge, but fine is gone
from the account. No indication of payment on Account page or in
account_offsets table.

Software error:

{UNKNOWN}: Can't call method "unblessed" on an undefined value at
/var/lib/koha/hcpl/kohaclone/C4/Circulation.pm line 2178. at
/var/lib/koha/hcpl/kohaclone/C4/Circulation.pm line 2198
For help, please send mail to the webmaster ([no address given]), giving this
error message and the time and date of the error.

Everything else works fine.

Test Plan:
1) Apply patches
2) Update database
3) Add authorised value PAYMENT_TYPE with values 'Cash', 'Check', 'Credit card'
4) Go to the fines section of a patron who has several fines
5) Tab 'Fines'
6) Click on 'Pay' for an individual fine
7) Verify that in the form a 'Pay an individual fine' dropdown appears with
payment types - YES (also appears with all "Pay")
8) Select a payment type, confirm payment
9) Verify that payment type appears in "Description of charges" in tab
'Account'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name'

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||tomasco...@gmail.com
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name'

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130

--- Comment #4 from Tomás Cohen Arazi  ---
Created attachment 66352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66352=edit
Bug 19130: (followup) Controller scripts should preserve behaviour

This patch is a followup to making
Koha::Acquisition::Booksellers->search work as any other Koha::Objects
(DBIC) query instead of having a different behaviour hardcoded.

To achieve it, this patch makes the controller scripts add
wildcard/truncation chars as prefix and sufix for searches, and make the
default sorting for results be by 'name', ascending.

To test:
- Just verify the behaviour remains unchanged by this patchset on the
controller scripts (re. searching).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18853] Module wise email alerts

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18853

--- Comment #2 from Vinod  ---
Yes i mean if email is generated from Acquisition related things like Status of
books rejected/ordered/arrived etc. than it should go from email which is
specified by the Acquisition librarian say (acquisit...@gmail.com), similarly
if email checkout/check-in etc goes from circulation than it should be
configurable from different email say circulat...@gmail.com. 

The present problem is it goes from only one/two admin email however in
libraries there are several librarians like acquisition section, circulation
section, serial section etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19164] Allow MARC modification templates to be used in staged MARC imports

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

--- Comment #1 from Jon Knight  ---
Created attachment 66351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66351=edit
First cut at some changes to misc/stage_file.pl script to provide for MARC
modification template support. Not ready for QA yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19164] Allow MARC modification templates to be used in staged MARC imports

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

Jon Knight  changed:

   What|Removed |Added

 CC||j.p.kni...@lboro.ac.uk
   Assignee|koha-b...@lists.koha-commun |j.p.kni...@lboro.ac.uk
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19164] New: Allow MARC modification templates to be used in staged MARC imports

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

Bug ID: 19164
   Summary: Allow MARC modification templates to be used in staged
MARC imports
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic record staging/import
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: j.p.kni...@lboro.ac.uk
QA Contact: testo...@bugs.koha-community.org

In Bug 18690 Katrin Fischer suggested that it would be useful to have MARC
Modification Templates used in stage MARC imports in a similar way to that
enhancement's inclusion in bulkmarcimport.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18789] Send a Koha::Patron object to the templates

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18789

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |BLOCKED

--- Comment #12 from Jonathan Druart  
---
You need to apply the dependencies first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19121] Prevent XSS in the Staff Client and the OPAC - bis

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19121

--- Comment #8 from Robin Sheat  ---
It will be a long and annoying process, but if done right then it'll be very
hard for someone to introduce a new vulnerability by accident.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19121] Prevent XSS in the Staff Client and the OPAC - bis

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19121

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #66045|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19121] Prevent XSS in the Staff Client and the OPAC - bis

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19121

--- Comment #7 from Jonathan Druart  
---
Hi Robin,

Thanks for your input!

I have to admit that I should have explained what I have in mind a bit more.
At the moment we are facing lot of XSS vulnerabilities caused by input
parameters we sent to the template:
  $template->param( foo => scalar $cgi->param('foo') )
and them [% foo %]

That is our main problem.

Of course the idea was not to insert escaped strings into the DB, but to trust
data from DB (inserted from staff, not OPAC), and not url parameters.
Which is wrong (!) and just move the escape problem to somewhere else (we will
have to list the variable we trust and the ones we do not). I am obsoleting my
proposal.

Fixing XSS incrementally scared me. First it will be long and hard to be
exhaustive, then we will not be regression proof.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name'

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 66349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66349=edit
Bug 19130: (followup) Add t/db_dependent/Koha/Acquisition/Booksellers.t

This followup patch adds a proper file in which add tests for
Koha::Acquisition::Bookseller(s) methods.

All current methods are covered.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Koha/Acquisition/Booksellers.t
 => SUCCESS: Test pass!
 - Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name'

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 66350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66350=edit
Bug 19130: (followup) Add POD

This patch adds POD to the following files:

- Koha/Acquisition/Bookseller.pm
- Koha/Acquisition/Booksellers.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19130] K::A::Booksellers->search broken for attribute 'name'

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19130

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 66348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66348=edit
Bug 19130: Remove ->search() overloading and adjust tests

This patch removes the custom ->search() function. Tests are adjusted
so the results from ->search() calls are not expected to return in the
previously hardcoded order.

To test:
- Apply this patch
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/db_dependent/Bookseller.t
=> SUCCESS: Tests pass
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

--- Comment #107 from M. Tompsett  ---
Created attachment 66347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66347=edit
Bug 14385: Test C4/Labels/Label.pm changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

--- Comment #3 from Marcel de Rooy  ---
Created attachment 66346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66346=edit
Bug 19163: [COUNTERPATCH] Adjust script instead of template

See previous patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17827] Untranslatable "by" in MARC21slim2intranetResults.xsl

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17827

Serhij Dubyk  changed:

   What|Removed |Added

  Attachment #59578|0   |1
is obsolete||

--- Comment #6 from Serhij Dubyk  ---
Created attachment 66345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66345=edit
new patch

Perhaps the comment "!-- #13383 --" after the text term removed this term from
translation...

Test:

Before this patch in file en-GB-marc-MARC21.po present next paragraph:

#:
/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:457
#, fuzzy, c-format
msgid "by "
msgstr " by "

According string "by " in the file MARC21slim2intranetResults.xsl can not be
translated (in other languages).

After applying this patch performed next command:
cd /usr/share/koha/misc/translator
sudo env KOHA_CONF=/etc/koha/sites/mykohainstance/koha-conf.xml
PERL5LIB=/usr/share/koha/lib perl -I /usr/share/koha/lib "./translate" update

Now in the file en-GB-marc-MARC21.po present the following (modified)
paragraph:

#:
/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl:349
#:
/usr/share/koha/opac/htdocs/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl:457
#, fuzzy, c-format
msgid "by "
msgstr " by "

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

Marcel de Rooy  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

--- Comment #2 from Marcel de Rooy  ---
Resolves [from intranet-error.log]:

[Tue Aug 22 16:09:24.735068 2017] [cgi:error] [pid 20766] AH01215: [Tue Aug 22
16:09:24 2017] stage-marc-import.pl: Plugin ISO2709 cannot be loaded at
Koha/Plugins/Handler.pm line 72., referer:
/cgi-bin/koha/tools/stage-marc-import.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19158] SPAM

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19158

Jonathan Druart  changed:

   What|Removed |Added

  Component|Koha|Architecture, internals,
   ||and plumbing
   Assignee|ch...@bigballofwax.co.nz|koha-b...@lists.koha-commun
   ||ity.org
 QA Contact||testo...@bugs.koha-communit
   ||y.org
 Resolution|--- |INVALID
  Group|Koha security   |
 Status|NEW |RESOLVED
Product|Koha security   |Koha
Summary|eee |SPAM

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19049] Fix regression on stage-marc-import with to_marc plugin

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||19163

--- Comment #28 from Marcel de Rooy  ---
This causes a critical bug. See fix on bug 19163


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163
[Bug 19163] Critical typo in stage-marc-import process
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||19049


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049
[Bug 19049] Fix regression on stage-marc-import with to_marc plugin
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4461] Context-sensitive report a problem screen

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4461

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |
 CC||ha...@orex.es

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

--- Comment #1 from Marcel de Rooy  ---
Created attachment 66344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66344=edit
Bug 19163: Critical typo in stage-marc-import process

Template says ISO2709 but script wants MARC or MARCXML..
Slipped in with bug 19049.
Trivial but critical fix.

Test plan:
Import a MARC file.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19163] New: Critical typo in stage-marc-import process

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19163

Bug ID: 19163
   Summary: Critical typo in stage-marc-import process
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

Template says ISO2709 but script wants MARC or MARCXML..
Slipped in with bug 19049.
Trivial but critical fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

  Attachment #65988|0   |1
is obsolete||

--- Comment #33 from Nick Clemens  ---
Created attachment 66342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66342=edit
Bug 17602 RecordedBooks Integration to Koha - sysprefs and
Koha::ExternalContent::RecordedBooks

Koha::ExternalContent::RecordedBooks - a wrapper around
WebService::ILS::RecordedBooks::PartnerPatron

RecordedBooks* sysprefs

Nothing functional to test with this patch yet.
But you can run the tests that come with it

 t/db_dependent/Koha_ExternalContent_RecordedBooks.t

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

  Attachment #65989|0   |1
is obsolete||

--- Comment #34 from Nick Clemens  ---
Created attachment 66343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66343=edit
Bug 17602 RecordedBooks integration to Koha - OPAC

Add RecordedBooks to the users page in the public interface

To Test:
1/ Apply all 3 patches
2/ Set the sysprefs to valid values (you will need a test account with
RecordedBooks)
3/ Try a search
4/ Login to the OPAC, try to place a hold, or check an item out
5/ Check the opac-user page, see if your items are showing on the
oneclickdigital tab

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for ONeclickDigital/Recorded Books API

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

Nick Clemens  changed:

   What|Removed |Added

  Attachment #64098|0   |1
is obsolete||

--- Comment #32 from Nick Clemens  ---
Created attachment 66341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66341=edit
Bug 17602 Koha::ExternalContent->koha_patron() will retutn undef rather than
die if user not logged in

Signed-off-by: Nick Clemens 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18389] bulkmarcimport.pl does not take notice of MARC modification templates

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389

--- Comment #14 from Jon Knight  ---
Thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068

--- Comment #9 from Katrin Fischer  ---
I think the git bz instructions might have originally been written with
developers switching to it in mind - I'll try to take a look.

New patch looks perfect, will try to test and thx for your patience so far!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068

Jon Knight  changed:

   What|Removed |Added

  Attachment #66339|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068

--- Comment #8 from Jon Knight  ---
Created attachment 66340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66340=edit
Add quantity field to the opac suggestions form (with correct username and
email)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19068] OPAC purchase suggestion doesn' t allow users to enter quantity of items

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19068

Jon Knight  changed:

   What|Removed |Added

  Attachment #66281|0   |1
is obsolete||

--- Comment #7 from Jon Knight  ---
Created attachment 66339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66339=edit
Add quantity field to the opac suggestions form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #8 from Marcel de Rooy  ---
Note for QA:
 FAIL   C4/Koha.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666

This is a false negative. I stumbled over it already before. If you remove one
routine from a module without full coverage, the coverage will drop a little
bit. Qa tools wrongly blames me for that now..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

Marcel de Rooy  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative

2017-08-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096

--- Comment #6 from Marcel de Rooy  ---
Created attachment 66337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66337=edit
Bug 19096: Restructure MarcSubfieldStructures.t first

Before adding more tests, move all current tests in one subtest.

Test plan:
Run t/db_dependent/Koha/MarcSubfieldStructures.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 158 matches

Mail list logo