[Koha-bugs] [Bug 18990] Overdue Notices are not sending through SMS correctly

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19193] When displaying the fines of the guarantee on the guarantor account, price is not in correct format.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19193

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19193] When displaying the fines of the guarantee on the guarantor account, price is not in correct format.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19193

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19193] When displaying the fines of the guarantee on the guarantor account, price is not in correct format.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19193

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #67154|0   |1
is obsolete||

--- Comment #6 from Marcel de Rooy  ---
Created attachment 67666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67666=edit
Bug 19193 - When displaying the fines of the guarantee on the guarantor
account, price is not in correct format

1 - Have a patron with guarantees
2 - Charge some fines to the guarantees
3 - View the patron
4 - Fines are displayed unformatted
5 - Apply patch
6 - Refresh
7 - Fines should now be formatted correctly

Signed-off-by: Caroline Cyr La Rose 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17664] Silence non-zebra warnings in t/db_dependent/Search.t

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17664

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17664] Silence non-zebra warnings in t/db_dependent/Search.t

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17664

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #67027|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 67665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67665=edit
Bug 17664 - Silence non-zebra warnings in t/db_dependent/Search.t

TEST PLAN
-
0) back up database
1) drop database; create database
2) run web installer
3) prove t/db_dependent/Search.t
   -- the spammy warnings (other than zebra index warnings) may
  already be fixed, but the mocked value was not realistic.
4) apply patch
5) prove t/db_dependent/Search.t
   -- notice only zebra index warnings.
6) run qa test tools

Signed-off-by: Alex Buckley 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18528] Patron card creator template: switch form fields for card height and card width

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18528

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #63262|0   |1
is obsolete||

--- Comment #6 from Marcel de Rooy  ---
Created attachment 67664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67664=edit
Bug 18528: Patron card creator template: switch form fields for card height and
card width

This patch changes the sequnce of form fields for card height and card width.

To test:
- Apply patch
- Edit or create a patron card template
- Verify that the fields display in sequence Page height - Page width -Card
height - Card width

Followed test plan, worked as intended
Signed-off-by: Alex Buckley 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060

--- Comment #17 from Alex Buckley  ---
Created attachment 67663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67663=edit
Bug 18060: Followup solving $layout error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060

Alex Buckley  changed:

   What|Removed |Added

  Attachment #64951|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19198] Renewal as issue causes too many error

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19198

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #17 from Nick Clemens  ---
I think Tomas just didn't change status, revert if I am wrong :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19360] Give items URL a link text

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #8 from Alex Buckley  ---
Hi David

Sorry I missed the SQL atomicupdate files in the first patch, I have just
attached them in this second patch, can you please test again?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19360] Give items URL a link text

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360

--- Comment #7 from Alex Buckley  ---
Created attachment 67662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67662=edit
Bug 19360 - Added missing atomicupdate SQL file

Test plan:
1. Add a MARC record (of any framework)

2. Add an item making sure to write in a URL e.g.
https://www.google.com

3. Notice on the additem page there is no 'Link text' input

4. Submit the add item form

5. Search for the item in the intranet and OPAC and notice that the
whole URL is displayed, which would get annoying if the URL is long

6. Apply patch

7. Update the database by going to Administration->Global system
preferences-> local use and change the 'version' system preference
to an previous version and then click 'Save'

8. This will prompt the update process

9. After going through the update process repeat step 1 and add an
item.
When adding the item notice there is a 'Link text' option write in
an appropriate name e.g. 'Google' and write in the URI value

10. Submit the form

11. Repeat step 5 and notice that the link text value is displayed
instead of the URL

12. Click on the link and check that it works

13. Add another item to a record and write in a URI but no link text
value

14. Search for the item in intranet and OPAC and notice that when no
link text is entered but a URI is then the URI is displayed

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5620] Capture Mode of payment

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67634|0   |1
is obsolete||

--- Comment #34 from Alex Buckley  ---
Created attachment 67661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67661=edit
Bug 5620 - (Rebase) - Collect payment mode in staff interface

Followed test plan, patch worked as described. Also ran QA test tool
everything passed

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5620] Capture Mode of payment

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14576] Allow arbitrary automatic update of location on checkin

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||alexbuck...@catalyst.net.nz

--- Comment #69 from Alex Buckley  ---
Hi Nick

A couple of points I have found whilst testing your first patch;

1) Can you clarify the _ALL_ value because when I set this on the left hand
side e.g 
_ALL_: FIC
FIC: GEN

The only item that was set to FIC was the item was was checking in, not all
items.

2) I entered incorrect syntax such as !!! into the pref and I was not warned
instead this invalid syntax was saved

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

--- Comment #14 from Magnus Enger  ---
(In reply to Alex Buckley from comment #13)
> Oh Sorry Magnus I just saw your comment that you would test and sign off on
> these patches, apologies that I tested and found that everything worked and
> passed the QA test tool so I signed off

Hehe, absolutely no need to apologize for that! :-) Just very happy to see this
moving along.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18639] Separate replacement cost and retail price fields in acquisitions

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18639

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz

--- Comment #13 from Alex Buckley  ---
Oh Sorry Magnus I just saw your comment that you would test and sign off on
these patches, apologies that I tested and found that everything worked and
passed the QA test tool so I signed off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67654|0   |1
is obsolete||

--- Comment #12 from Alex Buckley  ---
Created attachment 67660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67660=edit
Bug 19260: Holds marked as problems being seen as expired ones and deleted
wrongly

Test plan:
0) Apply just the first patch - the one with test
1) Run t/db_dependent/Reserves.t - test for CancelExpiredReserves should
fail
2) Apply the second patch
3) t/db_dependent/Reserves.t should pass now

Followed test plan, patch worked as described. Passes QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67653|0   |1
is obsolete||

--- Comment #11 from Alex Buckley  ---
Created attachment 67659
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67659=edit
Bug 19260: Add test for CancelExpiredReserves

Passes QA test tool
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18621] After duplicate message system picks category expiry date rather than manual defined

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18621

--- Comment #9 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19129] Clean up templates for organisation patrons in staff

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19129

--- Comment #12 from Katrin Fischer  ---
Doesn't apply cleanly - will need more work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18812] SIP Patron status does not respect OverduesBlockCirc

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18812

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19055] GetReservesToBranch is not used

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19055

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #12 from Alex Buckley  ---
Hi Tomas

It is still failing when applying the patches (specifically it is failing when
applying the Unit Tests patch). I've applied the  dependencies listed on the
patch as of 5 minutes ago. Please let me know if I am missing something?

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19278: Add RESTdefaultPageSize syspref
Applying: Bug 19278: Unit tests
fatal: sha1 information is lacking or useless
(t/Koha/REST/Plugin/Pagination.t).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 19278: Unit tests
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-19278-Unit-tests-XOrn2r.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19007] Allow paypal payments via debit or credit card again

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19007

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #10 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353

--- Comment #10 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15924] Coce not enabled on lists

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15924

--- Comment #10 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19335] 00-merge-markers.t fails

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19335

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19289] Allow configuration of the fields on the ‘Catalog details’ form in the acquisition baskets

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19227] 00-merge-conflict-markers.t launches too many tests

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19227

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19290] Add the ability to filter a result list on staff client

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10748] Add option to block return of lost items

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

Alex Buckley  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

--- Comment #9 from Alex Buckley  ---
Created attachment 67658
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67658=edit
Bug 19361 - Followup altered wording of the default value

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

--- Comment #8 from Alex Buckley  ---
Thanks Caroline

I am attaching a amendment with the new wording now

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19391] auth_values_input_www.t is failing because of bug 19128

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19391

--- Comment #5 from Katrin Fischer  ---
This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794

--- Comment #9 from Katrin Fischer  ---
Now really:

This patch has been pushed to 16.11.x and will be in 16.11.13.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

Caroline Cyr La Rose  changed:

   What|Removed |Added

  Attachment #67385|0   |1
is obsolete||

--- Comment #7 from Caroline Cyr La Rose  ---
Created attachment 67657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67657=edit
Bug 19361 - Display the value of a MARC field in dropdown box after it is
linked to an authorised value

This patch displays the previously entered input of a MARC subfield
(inputted before an authorised value was linked to the MARC field) in the new
authorised
value dropdown so that it can be resubmitted and not lost from the
database.

Test plan:
1. Create a record and write a value into the Edition 942$e MARC field
and submit form

2. Create a new authorised value category and link it to the same
Edition MARC subfield

3. Load the MARC record again and notice that the Edition field is now
an empty dropdown box. Also for future reference in this test note the values
in the 942$2 and 942$c dropdown
boxes

4. Query the biblio_metadata table with the biblionumber of the
record that you created in step 1 and notice that the value you entered
in step 1 into the Edition 

[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Status|Failed QA   |Signed Off

--- Comment #6 from Caroline Cyr La Rose  ---
Hi Alex,

I tested your patch both in 16.05 ans in the master.

It didn't work in 16.05. I didn't see the old value as the default in the drop
down menu. I think it has to do with the db structure that is different. In
16.05 there is no biblio_metadata. The MARC information is stored in the
biblioitems table in the marc field.

In the master, everything work as you described it. I attached a screenshot of
the  field with the value followed by the mention that it is not authorized.
However, I would change the phrasing to "This is a previously entered..."
instead of "previous".

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18008] Use templates for generating pagination in intranet

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18008

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Alex Buckley  ---
Hi Josef

Thanks for rebasing, I have tested the patch and functionally everything works
well, however running QA test tools it fails for pagination.inc (see the below
test output). Can you please fix this up and then I'll be happy to sign off on
this patch.


 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/pagination.inc
   FAIL   forbidden patterns
forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 1)
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794

--- Comment #8 from Jonathan Druart  
---
I did not execute the tests, please test before pushing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #64240|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 67656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67656=edit
[16.11.x] Bug 18794: Fix test ListMetadataFormats in OAI/Server.t

This test may fail on slow servers, it compares the response date with
'now', but both can differ a bit.

https://jenkins.koha-community.org/job/Koha_Master_D8/198/consoleFull

   Failed test 'ListMetadataFormats'
   at t/db_dependent/OAI/Server.t line 150.
 Structures begin differing at:
  $got->{responseDate} = '2017-06-12T14:31:51Z'
 $expected->{responseDate} = '2017-06-12T14:31:50Z'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

--- Comment #5 from Caroline Cyr La Rose  ---
Created attachment 67655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67655=edit
Screenshot of success!

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

Josef Moravec  changed:

   What|Removed |Added

   Assignee|mag...@libriotech.no|josef.mora...@gmail.com

--- Comment #10 from Josef Moravec  ---
(In reply to Magnus Enger from comment #7)
> (In reply to Josef Moravec from comment #6)
> > But the solution should be more complex (and yes, we will need tests for
> > this)
> > 
> > The CancelExpiredReserved has to deal with ExpireReservesMaxPickUpDelay -
> > nad use the different SQL for this two cases.
> 
> Could you make an alternative patch for that? I will sign off.

I did try ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

--- Comment #9 from Josef Moravec  ---
Created attachment 67654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67654=edit
Bug 19260: Holds marked as problems being seen as expired ones and deleted
wrongly

Test plan:
0) Apply just the first patch - the one with test
1) Run t/db_dependent/Reserves.t - test for CancelExpiredReserves should
fail
2) Apply the second patch
3) t/db_dependent/Reserves.t should pass now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

Josef Moravec  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260

--- Comment #8 from Josef Moravec  ---
Created attachment 67653
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67653=edit
Bug 19260: Add test for CancelExpiredReserves

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18794] OAI/Server.t fails on slow servers

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18794

--- Comment #6 from Katrin Fischer  ---
Sorry, this doesn't apply. Please provide a rebased patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 Depends on|19196   |19369

--- Comment #11 from Tomás Cohen Arazi  ---
I changes the dependencies because I fixed it on a working branch with other
patches.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196
[Bug 19196] Add pagination helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369
[Bug 19369] Add a helper function for translating pagination params into
SQL::Abstract
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19369] Add a helper function for translating pagination params into SQL:: Abstract

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||19278


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278
[Bug 19278] Add a configurable default page size for endpoints
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19196] Add pagination helpers

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks|19278   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278
[Bug 19278] Add a configurable default page size for endpoints
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

--- Comment #4 from Dominic Pichette  ---
meant to write "I can't see what I first wrote in the field..."

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

Dominic Pichette  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Dominic Pichette  ---
I just attached a screen shot of the result I get at step 10. It doesn't seem
to have changed since I can see what i first wrote in the field inside the
dropdown. Also, 

[Koha-bugs] [Bug 19361] Linking an authorised value category to a field in a framework can lose data

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19361

Dominic Pichette  changed:

   What|Removed |Added

 CC||dominic.piche...@inlibro.co
   ||m

--- Comment #2 from Dominic Pichette  ---
Created attachment 67652
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67652=edit
screenshot of MARC during step 10

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19360] Give items URL a link text

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360

Dominic Pichette  changed:

   What|Removed |Added

 CC||dominic.piche...@inlibro.co
   ||m

--- Comment #6 from Dominic Pichette  ---
Can't find any SQL either...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19390] OPAC view link in staff results should open in a new tab

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19390

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10748] Add option to block return of lost items

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

Séverine Queune  changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19290] Add the ability to filter a result list on staff client

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290

Séverine Queune  changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] ability to download items lost report

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Séverine Queune  changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item ‘Lost’ from ‘Holds awaiting pickup’ list

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Séverine Queune  changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the ‘Catalog details’ form in the acquisition baskets

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Séverine Queune  changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378

Séverine Queune  changed:

   What|Removed |Added

  Change sponsored?|Seeking developer   |Sponsored

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16825] REST API: Add API route for getting an item

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16825

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply
 CC||tomasco...@gmail.com

--- Comment #34 from Tomás Cohen Arazi  ---
Lari, the second patch doens't apply. Please rebase/fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13847] Cannot download large reports as Open Office Spreadsheet ODS

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13847

Danielle Elder  changed:

   What|Removed |Added

 CC||danielle@bywatersolutions.c
   ||om

--- Comment #4 from Danielle Elder  ---
Bump. This is happening still for libraries. 14,000 row report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18002] Aquisitions onboarding tool - to help users set up acquisitions the first time

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com
 Status|Needs Signoff   |Signed Off

--- Comment #57 from David Bourgault  ---
Tested as described in test plan, everything worked exactly as announced.

QA tool still warned of a fail in pod coverage for C4/Budgets.pm. Changing
=head1 to =head2 fixed the problem on my end, and by looking at the other
comments in the file seemed to be standard. I amended the signed-off/attached
patch to reflect those minor (1 char) changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417

--- Comment #2 from Nick Clemens  ---
Note this changes the behavior of message in rancor, you now have to click to
clear them, they don't clear on mouse move

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18002] Aquisitions onboarding tool - to help users set up acquisitions the first time

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

David Bourgault  changed:

   What|Removed |Added

  Attachment #66301|0   |1
is obsolete||

--- Comment #56 from David Bourgault  ---
Created attachment 67651
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67651=edit
Bug 18002: Followup - Changes based on test feedback

In this patch the following changes have been made based on test
feedback:

* Added POD to GetHighestBudgetPeriod
* Removed unconditional warns in Budgets.pm
* Fixed typos and uncommented hint and date field
* Changed manual link

Made the acquisition onboarding tool less visible in the right hand side
of the screen rather than in the middle obscuring the rest of the
acquisition home page

Implemented conditional so this tool is only displayed when the user
is superlibrarian

Test plan:
1. Restart memcached: sudo service memcached restart

2. Drop and recreate the database

3. Go through the web installer selecting all data values (except the
basic currencies)

4. After the web installer is finished log into the staff interface
using database admin credentials

5. Create a patron and assign superlibrarian permissions to them

6. Log out of staff interface and log back in as the new user you just
created

7. Go to More->Acquisitions

8. Notice yellow/orange warning message telling you to create a budget

9. Apply the patches attached to this bug report

10. Repeat steps 1,2,3,4,5,6,7

11. Notice instead of warning messages a currency creation form appears
on the right hand side of the page along with explanation of what a currency is
and why the user is being
asked to fill this form out. Fill out and submit this form.

12. A budget creation form is displayed along with an explanation of
budgets above it. Fill this form out and submit it.

13. A fund creation form appears (again with explanation text above it),
fill it out and submit it

14. The acquisition onboard tool disappears from the right of the screen and a
table of
created funds is displayed and should show the fund you just created

15. On the left of the screen below the text 'Administration' click
on 'Funds' and delete the fund you just created

16. Click on More->Acquisitions and observe how the funds form is
displayed rather than the currency or budget forms (because we
already have a currency and budget in the database). Fill out the fund form and
submit it.

17. Again you'll notice the fund table is displayed

18. On the left of the screen click on 'Budget' and delete your
budget

19. Navigate to More->Acquisitions and observe how this time the
budget form is displayed. Fill out this form and submit it. You
should be redirected to the Budget Information page
(aqbudgetperiods.pl) where you can click Actions->Add fund to add a
fund.

20. Repeat steps 1,2,3,4,5,6,7 but making sure to install all sample
data in the web installer including the basic currencies

21. Notice this time because you have installed basic currencies the
first form to appear is the budget creation form

22. Repeat step 15 and then create a patron that does not have the
superlibrarian permissions
and log out and log back in.

23. Go to the Acquisitions module and notice that the yellow message
telling you that your administrator must define a budget is displayed

Sponsored by: Catalyst IT

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18002] Aquisitions onboarding tool - to help users set up acquisitions the first time

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

David Bourgault  changed:

   What|Removed |Added

  Attachment #64765|0   |1
is obsolete||

--- Comment #54 from David Bourgault  ---
Created attachment 67649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67649=edit
Bug 18002 - Created an acquisition onboarding tool to be displayed when no
currency, budget, or fund exists

Implemented scrolling for acquisition onboarding tool.

Hidden the active checkbox for currencies and budget, and made exchange
rate readonly (displayed).

Same test plan as comment 29.

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18002] Aquisitions onboarding tool - to help users set up acquisitions the first time

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18002

David Bourgault  changed:

   What|Removed |Added

  Attachment #64947|0   |1
is obsolete||

--- Comment #55 from David Bourgault  ---
Created attachment 67650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67650=edit
Bug 18002: Made rate hidden and removed the overflow attribute of
onboardingModal

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available'

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505

George Williams (NEKLS)  changed:

   What|Removed |Added

 CC||geo...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #54 from Tomás Cohen Arazi  ---
I've rebased the patches and checked everyting is ok regarding the changes
introduced by bug 19256 in Koha::Acquisition::Order(s).

Added tests for Koha::Acquisition::Order::basket (found a bug in the meantime).

Please re-test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417

--- Comment #1 from Nick Clemens  ---
Created attachment 67648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67648=edit
Bug 19417 - Display full error text when problem importing records

To test:
1 - Upload a file to stage
2 - Select your import options
3 - Delete the file form the server, example:
sudo rm /tmp/koha_kohadev_uploads/
4 - 'Click stage for import'
5 - Get an alert 'Failed to submit form: error'
6 - Apply patches
7 - Repeat 1-4
8 - Get a pretty error with all osrt of info

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19418] Patron search is broken

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19418

Alex Arnaud  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19418] Patron search is broken

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19418

Alex Arnaud  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19417] New: Improve display of errors from background job during stage for import

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417

Bug ID: 19417
   Summary: Improve display of errors from background job during
stage for import
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When importing records, if there is an error in the staging we display:
Failed to submit form: error

This is not helpful, we should instead display the error textReponse field

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19418] New: Patron search is broken

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19418

Bug ID: 19418
   Summary: Patron search is broken
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alex.arn...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Test plan:

syspref ExtendedPatronAttributes => enabled
Search fields: standard 
Search what you want
The call to svc/members/search raise an internal server error.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #51 from Tomás Cohen Arazi  ---
Created attachment 67645
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67645=edit
Bug 15685: (QA followup) Tidy tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #49 from Tomás Cohen Arazi  ---
Created attachment 67643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67643=edit
Bug 15685: (QA followup) Fix typo

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #50 from Tomás Cohen Arazi  ---
Created attachment 67644
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67644=edit
Bug 15685: (followup) K:A:O->find and ->fetch are no longer used

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #53 from Tomás Cohen Arazi  ---
Created attachment 67647
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67647=edit
Bug 15685: Add tests for Koha::Acquisition::Order->basket

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #52 from Tomás Cohen Arazi  ---
Created attachment 67646
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67646=edit
Bug 15685: POD

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #46 from Tomás Cohen Arazi  ---
Created attachment 67640
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67640=edit
Bug 15685: (QA followup) Fix qa script errors

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #48 from Tomás Cohen Arazi  ---
Created attachment 67642
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67642=edit
Bug 15685: Schema changes

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #47 from Tomás Cohen Arazi  ---
Created attachment 67641
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67641=edit
Bug 15685: QA Followup

DB revision fixes
Unit tests

Edit: fixed the update step description (tcohen)

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #44 from Tomás Cohen Arazi  ---
Created attachment 67638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67638=edit
Bug 15685: Allow creation of items (AcqCreateItem) to be customizable
per-basket

This adds a new basket attribute (create_items) that can optionally be
set to override AcqCreateItem.

The following have been modified to reflect this (with the value of
create_items that causes them to behave differently in parentheses):
  * Cancelling receipt of an order (receiving)
  * Creating an order by hand or from MARC (ordering)
  * Receiving an order (receiving)
  * Showing orders with uncertain price (ordering)
  * Showing orders (receiving)
  * Showing acquisition details in the OPAC (ordering)

Test plan:
  1) Create baskets with "Create items when:" set to ordering,
 receiving, cataloging and unset.
  2) Test each of the above for each of these baskets, verifying that
 the basket-specific attribute overrides AcqCreateItem if set and
 falls back to the syspref otherwise.

NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it
was redundant; the code path in question cannot be triggered unless
create_items/AcqCreateItems is set to the correct value anyway.

Signed-off-by: Kyle M Hall 
Signed-off-by: Barbara Fondren 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #45 from Tomás Cohen Arazi  ---
Created attachment 67639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67639=edit
Bug 15685: Implement needed changes in Koha::Edifact::Order

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66123|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66121|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66122|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66120|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #66124|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   >