[Koha-bugs] [Bug 18839] suggestion.pl: 'unknown' is spelled 'unkown'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18839 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |String patch CC||tomasco...@gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18282] OpenAPI operationId must be unique
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18282 Tomás Cohen Arazi changed: What|Removed |Added Component|Web services|REST api -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19367] $biblio variable redefined in same scope in ISBDdetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19367 Nick Clemens changed: What|Removed |Added Attachment #67370|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 67780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67780&action=edit Bug 19367 - $biblio variable redefined in same scope in ISBDdetail The following warning is generated by ISBDdetail.pl: my" variable $biblio masks earlier declaration in same scope at ./catalogue/ISBDdetail.pl line 171. This patch removes this unnecessary declaration, which removes the warning. _TEST PLAN_ After applying patch: 1) Check code compilation with "KOHA_CONF=/path/to/koha-conf.xml perl -c catalogue/ISBDdetail.pl" 2) Note the only message is "./catalogue/ISBDdetail.pl syntax OK" 2) On /cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=1, view the source of the page and verify that the Javascript contains a holdcount e.g. "var holdcount = 0". Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19367] $biblio variable redefined in same scope in ISBDdetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19367 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Nick Clemens changed: What|Removed |Added Status|Signed Off |In Discussion CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- This works, but defaulting the pref to on changes current behavior. If we feel the current behavior is so unusual that it shouldn't be standard I am not sure a syspref is the way to go. I would rather see us add a new column and name them appropriately, with classes for hiding/showing via css easily Would like a second opinion here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19340] Transferred orders show incorrect basket in transferred from/ to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19340] Transferred orders show incorrect basket in transferred from/ to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19340 Nick Clemens changed: What|Removed |Added Attachment #67331|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 67779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67779&action=edit Bug 19340 Read basket details of transfer partner Details of the basket an order is tranferred to or from are displayed in the basket display. Unfortunately these details were not being read so the display incorrectly showed the details of the current owning basket. Signed-off-by: David Bourgault Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 --- Comment #7 from Nick Clemens --- Created attachment 67778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67778&action=edit after selecting page 10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Nick Clemens changed: What|Removed |Added Status|Signed Off |Failed QA CC||n...@bywatersolutions.com --- Comment #6 from Nick Clemens --- Hi Aleisha, When I try this with a bunch of pages (218) the dropdown only lists the visible pages. If I select page 10, then the pages i can select goes up to 20 as does the dropdown, but the screen is very crowded. screenshot to follow My assumption was the dropdown would go from first page # to last page # and the bar would always be 5 on either side? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13205] Last/First page options for result list paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #20 from Nick Clemens --- Created attachment 6 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6&action=edit Bug 13205: [FOLLOW-UP] Fixing math and variable names Have changed my $last_page = $pages * ( $results_per_page - 1 ); to my $last_page = ( $pages - 1) * $results_per_page; which seems to fix the 'last' button offset! (Comment 10) Will add the box to jump to a page in a separate patch. Adding the pagination to the top on the staff client will be dealt with in Bug 18916 as it is slightly out of the scope of this bug. Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13205] Last/First page options for result list paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13205] Last/First page options for result list paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #18 from Nick Clemens --- Created attachment 67775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67775&action=edit Bug 13205: Last/first page options for result list paging for OPAC Same fix but on OPAC side. Same test plan Sponsored-by: Catalyst IT Signed-off-by: Dilan Johnpulle Signed-off-by: Your Full Name Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13205] Last/First page options for result list paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 --- Comment #19 from Nick Clemens --- Created attachment 67776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67776&action=edit Bug 13205: [FOLLOW-UP] Some extra logic See Comment 8. Test: When on first page of results, confirm that the 'First' and 'Previous' buttons do not show. Confirm they come back on the second page and every page after. When on last page of results, confirm that the 'Last' and 'Next' buttons do not show. Confirm they come back on all previous pages. Check on both staff side and OPAC. Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13205] Last/First page options for result list paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens changed: What|Removed |Added Attachment #64981|0 |1 is obsolete|| Attachment #64982|0 |1 is obsolete|| Attachment #64983|0 |1 is obsolete|| Attachment #64984|0 |1 is obsolete|| --- Comment #17 from Nick Clemens --- Created attachment 67774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67774&action=edit Bug 13205: Last/first page options for result list paging This patch adds first and last page buttons to the pagination at the bottom of a page of catalog search results. To test: 1) Apply patch 2) Do a number of searches 3) For each search, ensure that the first and last page buttons work as expected Sponsored-by: Catalyst IT Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13205] Last/First page options for result list paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens changed: What|Removed |Added Attachment #64670|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13205] Last/First page options for result list paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens changed: What|Removed |Added Attachment #64938|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13205] Last/First page options for result list paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens changed: What|Removed |Added Attachment #61194|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13205] Last/First page options for result list paging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Attachment #60248|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18916] Add pagination to top of search results in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18916 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18916] Add pagination to top of search results in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18916 Nick Clemens changed: What|Removed |Added Attachment #64997|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 67773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67773&action=edit Bug 18916: Add pagination to top of search results in staff client To look the same as OPAC. To test: 1) Do a catalogue search in staff client that results in more than one page 2) Notice pagination is only at the bottom 3) Apply patch and refresh page 4) Notice pagination is at top also Sponsored-by: Catalyst IT Signed-off-by: Lee Jamison Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #3 from Nick Clemens --- Why the conditional for footerjs? If we are setting it statically why not just always include the js in footer? If I understand the variable is to prvent doc-head-close / intranet-bottom.inc from adding more js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #32 from Nick Clemens --- Created attachment 67769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67769&action=edit Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules Test plan remains the same. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: David Bourgault Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #35 from Nick Clemens --- Created attachment 67772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67772&action=edit Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets To test: prove -v t/db_dependent/Koha/Acquisition/Baskets.t Signed-off-by: David Bourgault Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #34 from Nick Clemens --- Created attachment 67771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67771&action=edit Bug 13208: (QA follow-up) Remove blank breadcrumbs on successful deletion After order is deleted we don't have a vendor or basket so we get blank breadcrumbs, this removes them Signed-off-by: David Bourgault Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #33 from Nick Clemens --- Created attachment 67770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67770&action=edit Bug 13208: [FOLLOW-UP] Perl documentation for modules Signed-off-by: Katrin Fischer Signed-off-by: David Bourgault Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What|Removed |Added Attachment #67167|0 |1 is obsolete|| Attachment #67168|0 |1 is obsolete|| Attachment #67169|0 |1 is obsolete|| Attachment #67170|0 |1 is obsolete|| Attachment #67171|0 |1 is obsolete|| --- Comment #31 from Nick Clemens --- Created attachment 67768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67768&action=edit Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19267] Advanced Editor - Rancor - Add warning before leaving page if there are unsaved modifications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19267 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
Status|Signed Off |Failed QA
QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
|y.org |
--- Comment #10 from Nick Clemens ---
Hi Alex,
Why not use Koha::Template::Plugin::AuthorisedValues rather than processing the
category in the pl and passing it?
$(this).next("#other_reason").show();
should be the same as
$("#other_reason").show();
I like the way the 'Other' suggestions work but 'Cancel' is a confusing wording
(if I am editing an existing suggestion I am not 'cancelling' but 'changing') I
would suggest 'Choose an standard value' or something similar
Nice and needed feature.
-Nick
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14039] Add patron title to checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14039] Add patron title to checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 --- Comment #22 from Nick Clemens --- Created attachment 67767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67767&action=edit Bug 14039: Add the title to all places There are other scripts where the borrower variable is not defined and the fields are passed one by one. To have a consistent behaviour we should add the title at the different places. Note that this script also add the use of the include file for statistics.tt and remove the pass of parameters to the template, already done later: 99 $template->param(%$borrower); Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14039] Add patron title to checkout screen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14039 Nick Clemens changed: What|Removed |Added Attachment #65496|0 |1 is obsolete|| Attachment #65777|0 |1 is obsolete|| --- Comment #21 from Nick Clemens --- Created attachment 67766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67766&action=edit Add patron salutation to checkout screen https://bugs.koha-community.org/show_bug.cgi?id=14039 Signed-off-by: Owen Leonard Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18426] Subscriptions batch editing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #8 from Nick Clemens --- Caroline, Did you apply dependencies and restart services and regenerate schema? All seems to work for me. Julian, I like this feature a lot, a few comments: 1 - The edit button is inconsistent, it should be a link as the others, and I would suggest 'Edit selected serials' 2 - On the edit page we should display all editable values - when the dropdown is 'No change' I cannot know what the original value was for things like 'Create items when receiving 3 - We should have a 'Cancel' button if we choose not to edit the subs 4 - It might be nice to be able to select/deselect subs before applying the edits - not a blocker but saves from going back a page on wrong click 5 - Maybe 'Save' instead of 'Start batch edit'? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785 --- Comment #9 from Nick Clemens --- Created attachment 67765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67765&action=edit Bug 18785: Force scalar context in Koha::Subscription::biblio Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18785] Add Koha::Subscription::biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18785 Nick Clemens changed: What|Removed |Added Attachment #67383|0 |1 is obsolete|| Attachment #67384|0 |1 is obsolete|| --- Comment #8 from Nick Clemens --- Created attachment 67764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67764&action=edit Bug 18785: Add the Koha::Subscription->biblio method Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19377] Remove $5 charge from sample item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Nick Clemens changed: What|Removed |Added Status|Signed Off |In Discussion CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- I added a followup to cleanup books across all the files, I noticed though that some samples have charges for some itemtypes, and other have them for none. Maybe we should standardize all of them? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19377] Remove $5 charge from sample item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 --- Comment #4 from Nick Clemens --- Created attachment 67763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67763&action=edit Bug 19377: Follow - remove charge for 'books' in all sample data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19397] Release team 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19397] Release team 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19397 Nick Clemens changed: What|Removed |Added Attachment #67533|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 67762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67762&action=edit Bug 19397: Release team for 17.11 This patch adds the release team for 17.11 to about template. Test plan: Check the changes with the wiki pages for 17.05 and 17.11. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 --- Comment #9 from Nick Clemens --- Created attachment 67761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67761&action=edit Bug 19255: QA Followup - Fix tabs for spaces Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 --- Comment #8 from Nick Clemens --- Created attachment 67760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67760&action=edit Bug 19255: [Follow-up] Typo "will accessible" This patch speaks for itself. Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19255] Correct explanation about list categories on shelves.pl in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19255 Nick Clemens changed: What|Removed |Added Attachment #66889|0 |1 is obsolete|| Attachment #66890|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 67759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67759&action=edit Bug 19255: Correct explanation about list types on shelves.pl in staff The explanation on list categories on the shelves form is removed. The online help text is actualized. Test plan: Go to Lists in staff. Edit a list. The remarks about private and public lists on the right side are gone. Click Help. Read the adjusted text. Does it make sense? Signed-off-by: Marcel de Rooy Signed-off-by: Mark Tompsett Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 --- Comment #25 from Jonathan Druart --- Thanks Josef, patch push to master! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 --- Comment #5 from Jesse Weaver --- Created attachment 67758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67758&action=edit Bug 18936: (follow-up) Update REST definition for /.../kinds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Kyle M Hall changed: What|Removed |Added Attachment #67756|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 67757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67757&action=edit Bug 19066 [QA Followup] - Fix related unit test failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 --- Comment #8 from Kyle M Hall --- Created attachment 67756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67756&action=edit Bug 19066 [QA Followup] - Fix related unit test failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19371] Change template table column text from 'Delete?' to 'Cancel?' on the patron circulation page holds tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Nick Clemens changed: What|Removed |Added Attachment #67425|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 67755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67755&action=edit Bug: 19371: Changed table column text to 'Cancel?' on the patron circulation page Test plan: 1. Place a hold on an item 2. Search for the patron who the hold is associated with 3. View the Hold(s) tab of the Checkouts page and notice there is a column with the text 'Delete?' and a button below the table with the text 'Cancel marked holds' 4. Apply patch 5. Notice that the column text described in step 3 now has the text 'Cancel?' and the button text is the same as it was in step 3 Sponsored-By: Catalyst IT Signed-off-by: Marc Véron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19371] Change template table column text from 'Delete?' to 'Cancel?' on the patron circulation page holds tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19371 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18449] Renewal limit button on renew.pl misleading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18449 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18449] Renewal limit button on renew.pl misleading
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18449 Nick Clemens changed: What|Removed |Added Attachment #67483|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 67754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67754&action=edit Bug 18449: Rename misleading button when renewing If you hit the renewal limit on the renewal tab, the message gives you a message like: "Windows 8 / ( 50610018249545 ) has been renewed the maximum number of times by Johnny Test ( 12345678 )" And has a button that reads: "Ignore and continue" This button is misleading, as it may be interpreted as "ignore the limit and continue to renew the item". Signed-off-by: Dominic Pichette Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19190] Silly calculation of average time in touch_all scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19190 --- Comment #8 from Nick Clemens --- Created attachment 67753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67753&action=edit Bug 19190: [Follow-up] Do not rely on the return of ModItem touch_all_items looks at the return of ModItem to determine if the operation was successful. But ModItem does not return a meaningful value. This patch puts the ModItem call in an eval and looks at $@. Test plan: Run touch_all_items with a where condition and verbose option. Put print 1/0; at the end of ModItem. Run touch_all_items again. You should see: ERROR WITH ITEM xxx Signed-off-by: Marcel de Rooy Signed-off-by: David Bourgault Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19190] Silly calculation of average time in touch_all scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19190 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19190] Silly calculation of average time in touch_all scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19190 Nick Clemens changed: What|Removed |Added Attachment #67499|0 |1 is obsolete|| Attachment #67500|0 |1 is obsolete|| --- Comment #7 from Nick Clemens --- Created attachment 67752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67752&action=edit Bug 19190: Silly calculation of average time in touch_all scripts When you want to calculate average time, do not divide count by time :) Test plan: Run the script with a where condition and verbose option and see that the average time is meaningful. Signed-off-by: Marcel de Rooy Signed-off-by: David Bourgault Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410 Tomás Cohen Arazi changed: What|Removed |Added Attachment #67732|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 67751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67751&action=edit Bug 19410: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19066] Add branchcode to accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi --- (In reply to M. Tompsett from comment #6) > prove -r t/db_dependent fails after applying the patch. Constraint errors > related to test builder, I suspect. Can you please make it explicit what tests are failing? Otherwise its around an hour of waiting for something to fail... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #67731|0 |1
is obsolete||
--- Comment #4 from Tomás Cohen Arazi ---
Created attachment 67750
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67750&action=edit
Bug 19410: Add Koha::Objects->search_for_api
Following the discussion about the best way to make things simpler for
developing the REST api, I quote Lari's email:
"As many other endpoint will have the exact same usage, by looking at your
example, I would prefer to avoid writing parameter / pagination / sorting /
header handling for each list operation in our API controllers. Do you think
it's possible to centralize all of this e.g. by passing $c into a customized
search sub? Perhaps in Koha::Objects?
so instead we could have something like (ignore my bad choice of naming)...:
sub list_vendors {
my $c = shift->openapi->valid_input or return;
my $args = $c->validation->output;
my $vendors;
return try {
$vendors = Koha::Acquisition::Booksellers->api_list_search($c);
return $c->render(status => 200, openapi => $vendors);
} catch {
...
}
}"
We all agreed we neeed something like that. Here's a possible implementation. I
take
advantage of the previously written Mojo helpers, that are fully covered by
tests.
I submit this early so anyone can take a look and gather ideas to make it even
better.
I'm already using it (effectively) for the /acquisitions/orders endpoint I'm
writing
on bug 18731.
Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 Josef Moravec changed: What|Removed |Added Assignee|k...@bywatersolutions.com |josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #72 from Josef Moravec --- > Ability to delete a collection with items is current behavior in master, I > will fix it on another report It is Bug 17202 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #70 from Josef Moravec --- Created attachment 67749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67749&action=edit Bug 18606: (followup) Fix double delete confirmation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #63 from Josef Moravec --- Created attachment 67742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67742&action=edit Bug 18606: Get rid of TransferCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #67 from Josef Moravec --- Created attachment 67746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67746&action=edit Bug 18606: Rework tests for rotating collections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #64 from Josef Moravec --- Created attachment 67743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67743&action=edit Bug 18606: Get rid of isItemInThisCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #69 from Josef Moravec --- Created attachment 67748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67748&action=edit Bug 18606: Unify handling of success/error messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #62 from Josef Moravec --- Created attachment 67741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67741&action=edit Bug 18606: Get rid of RemoveItemFromCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #71 from Josef Moravec --- (In reply to Aleisha Amohia from comment #54) > Hi Josef > > I have one test failing in t/db_dependent/Circulation.t. I've pasted the > output here: http://paste.koha-community.org/621 > > All other tests pass. > > Some notes from following the rest of your test plan: > When deleting a collection, two different confirmation boxes pop up. (i know > this is the behaviour before your patches) > Deleting a collection with items was no different from deleting a collection > without items (no error message to say the collection had items). > No difference when returning an item in an untransferred collection and > returning an item in a transferred collection > > I know the first point is the original behaviour before your patches. > Unfortunately I can't test whether the second and third points are the > expected behaviour because rotating collections appears to be broken for me > without your patches! :) If the behaviour I've described is expected, then > everything looks good. > > Setting to Failed QA for the failed test. Thanks for testing! I did another rebase today. Test t/db_dependent/Circulation.t is passing form me. The double confirmation dialog was easy to fix, I am doing it in followup Ability to delete a collection with items is current behavior in master, I will fix it on another report Returning from transferred and untransferred collection is not diferrentiate in in current master too. Setting back to needs signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #65 from Josef Moravec --- Created attachment 67744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67744&action=edit Bug 18606: Get rid of isItemInAnyCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #66 from Josef Moravec --- Created attachment 67745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67745&action=edit Bug 18606: Remove lefover of C4::RotatingCollections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #68 from Josef Moravec --- Created attachment 67747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67747&action=edit Bug 18606: Add test to t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #61 from Josef Moravec --- Created attachment 67740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67740&action=edit Bug 18606: Get rid of AddItemToCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #60 from Josef Moravec --- Created attachment 67739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67739&action=edit Bug 18606: Get rid of GetCollectionItemBranches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #59 from Josef Moravec --- Created attachment 67738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67738&action=edit Bug 18606: Get rid of GetItemsInCollection -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #57 from Josef Moravec --- Created attachment 67736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67736&action=edit Bug 18606: Database changes - Add foreign keys to collections_tracking -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #56 from Josef Moravec --- Created attachment 67735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67735&action=edit Bug 18606: Easy ones - CRUD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 Josef Moravec changed: What|Removed |Added Attachment #66286|0 |1 is obsolete|| Attachment #66287|0 |1 is obsolete|| Attachment #66288|0 |1 is obsolete|| Attachment #66289|0 |1 is obsolete|| Attachment #66290|0 |1 is obsolete|| Attachment #66291|0 |1 is obsolete|| Attachment #66292|0 |1 is obsolete|| Attachment #66293|0 |1 is obsolete|| Attachment #66294|0 |1 is obsolete|| Attachment #66295|0 |1 is obsolete|| Attachment #66296|0 |1 is obsolete|| Attachment #66297|0 |1 is obsolete|| Attachment #66298|0 |1 is obsolete|| Attachment #66299|0 |1 is obsolete|| Attachment #66300|0 |1 is obsolete|| --- Comment #55 from Josef Moravec --- Created attachment 67734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67734&action=edit Bug 18606: Add RotationCollections object classes Test plan: 1) Apply the patch 2) Update database 3) Go to tools -> Rotating collections and play with trying to break it: 3a) Add some collections 3b) Edit them 3c) Add some items to collections 3d) Remove some items 3e) Transfer some collections 3f) Try to remove collection without items 3g) Try to remove collection with items 4) Go to returns and: 4a) Try to return item from untransferred collection 4b) Try to return item from transferred collection 5) prove t/db_dependent/Koha/RotatingCollections.t t/db_dependent/Koha/Items.t t/db_dependent/Circulation.t t/db_dependent/Circulation/Returns.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18606] Move rotating collections code to Koha::Object
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18606 --- Comment #58 from Josef Moravec --- Created attachment 67737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67737&action=edit Bug 18606: Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 --- Comment #24 from Josef Moravec --- Created attachment 67733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67733&action=edit Bug 19260: (followup) Fix CancelReserves.t test Test plan: Run t/db_dependent/Holds/CancelReserves.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #110 from Martha Fuerst --- RM: Really excited for this patch set, given the dependencies. Do we know what the plan is? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #109 from Martha Fuerst --- RM: Really excited for this patch set, given the dependencies. Do we know what the plan is? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Jonathan Druart changed: What|Removed |Added Attachment #67679|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 --- Comment #23 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #18) > Created attachment 67679 [details] [review] > Bug 19260: [QA Follow-up] Rearranging tests Tests fail even with this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Jonathan Druart changed: What|Removed |Added Attachment #67679|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 --- Comment #22 from Jonathan Druart --- Two tests are failing, please fix ASAP t/db_dependent/Holds/CancelReserves.t .. 1/5 # Failed test 'reserve 2 should be canceled.' # at t/db_dependent/Holds/CancelReserves.t line 61. # got: 'Koha::Hold=HASH(0x9fbec48)' # expected: undef # Failed test 'Reserve 3 should be canceled.' # at t/db_dependent/Holds/CancelReserves.t line 96. # got: 'Koha::Hold=HASH(0x9f3a750)' # expected: undef # Looks like you failed 2 tests of 5. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 67732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67732&action=edit Bug 19410: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #67613|0 |1
is obsolete||
--- Comment #2 from Tomás Cohen Arazi ---
Created attachment 67731
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67731&action=edit
Bug 19410: Add Koha::Objects->search_for_api
Following the discussion about the best way to make things simpler for
developing the REST api, I quote Lari's email:
"As many other endpoint will have the exact same usage, by looking at your
example, I would prefer to avoid writing parameter / pagination / sorting /
header handling for each list operation in our API controllers. Do you think
it's possible to centralize all of this e.g. by passing $c into a customized
search sub? Perhaps in Koha::Objects?
so instead we could have something like (ignore my bad choice of naming)...:
sub list_vendors {
my $c = shift->openapi->valid_input or return;
my $args = $c->validation->output;
my $vendors;
return try {
$vendors = Koha::Acquisition::Booksellers->api_list_search($c);
return $c->render(status => 200, openapi => $vendors);
} catch {
...
}
}"
We all agreed we neeed something like that. Here's a possible implementation. I
take
advantage of the previously written Mojo helpers, that are fully covered by
tests.
I submit this early so anyone can take a look and gather ideas to make it even
better.
I'm already using it (effectively) for the /acquisitions/orders endpoint I'm
writing
on bug 18731.
Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Reserves history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 --- Comment #5 from Josef Moravec --- Created attachment 67730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67730&action=edit Bug 14919: Add reserves history for patron Test plan: 0) Have a patron with some current and old reserves 1) Go to patron circulation page 2) Notice, there is new item called "Reserves history" in the left circulation menu 3) Go to this page and confirm the data on this page are OK, and that ui does behave as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Reserves history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 --- Comment #4 from Josef Moravec --- Created attachment 67729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67729&action=edit Bug 14919: Add Koha::Patron->old_holds subroutine Test plan: Run t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Reserves history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 --- Comment #3 from Josef Moravec --- Created attachment 67728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67728&action=edit Bug 14919: Add test for Koha::Patron->old_holds subroutine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Reserves history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Josef Moravec changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 --- Comment #20 from Nick Clemens --- (In reply to Jonathan Druart from comment #18) > Please add more tests: > - donald duck and the mouse > - * > - "donald duck" and "the mouse" > - field:value > > I am sure you will see that it needs more work :) Thanks Jonathan, followup provided, let me know if you think of more cases -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 --- Comment #19 from Nick Clemens --- Created attachment 67727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67727&action=edit Bug 18374: Followup - Add support and tests for quoted strings To test: 1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t 2 - do some searches in staff client and test results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18374] Respect QueryAutoTruncate syspref in Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18374 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19423] DecreaseLoanHighHolds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #2 from Jonathan Druart --- Patch pushed to master for 17.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19423] DecreaseLoanHighHolds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19423] DecreaseLoanHighHolds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423 Jonathan Druart changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@bugs.koha-c ||ommunity.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19423] DecreaseLoanHighHolds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
