date:20171007

[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #33 from Katrin Fischer  ---
Patch doesn't apply anymore, but this sounds like an interesting feature. Can
someone rebase?


Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14715: results per page setting for catalog search
Using index info to reconstruct a base tree...
M   C4/Search.pm
M   catalogue/search.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
M   opac/opac-search.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-search.pl
CONFLICT (content): Merge conflict in opac/opac-search.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
Auto-merging catalogue/search.pl
CONFLICT (content): Merge conflict in catalogue/search.pl
Auto-merging C4/Search.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 14715: results per page setting for catalog search
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-14715-results-per-page-setting-for-catalog-sea-nZTnir.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12902] Cronjob monitoring script, nagios3 compatible

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12902

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Patch still applies, but I don't know how to test this. Someone using Nagios
maybe?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179

--- Comment #3 from Katrin Fischer  ---
This is a cool feature. Maybe the clipboard could be mentioned in the bug title
for the release notes?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65090|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 67817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67817=edit
Bug 17179 - Add keyboard shortcuts to repeat (duplicate) a field, and cut text

This patchset introduces an internal clipboard to the advanced editor
and provides some new functionality to make use of this:

Ctrl-X:   Now cuts a line into the clipboard area
Ctrl-Shift-X: Now cuts current subfield into clipboard area
Ctrl-C:   Copies a line into the clipboard area
Ctrl-Shift-C: Copies current subfield into clipboard area
Ctrl-P:   Pastes the selected item from the clipboard at cursor
Ctrl-I:   Copies the current line and inserts onto a new line below
Ctrl-Z:   Functions as undo - this was supported but now in the
dropdown help

To test:
Verify all functionality above and confirm it behaves as expected

Note:
Ctrl-v pastes from the system clipboard - codemirror does not have
access and this is why we use our "Clipboard"
For browser cut/paste please use mouse right click or context menus
Ctrl-P can be accessed as print by focusing outside the editor window

Signed-off-by: Katrin Fischer 

https://bugs.koha-community.org/show_bug.cgi?id=17191

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17214] Add records to lists by biblio number

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add item in LIST by Record  |Add records to lists by
   |number  |biblio number

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179

Katrin Fischer  changed:

   What|Removed |Added

Summary|Add keyboard shortcuts to   |Advanced editor: Add
   |repeat (duplicate) a field, |keyboard shortcuts to
   |and cut text|repeat (duplicate) a field,
   ||and cut text
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17214] Add item in LIST by Record number

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #17 from Katrin Fischer  ---
Nice!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17214] Add item in LIST by Record number

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #64569|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 67815
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67815=edit
Bug 17214: Add records to lists by biblionumber

To test:
1) Apply patch and go to Lists
2) Click on an existing list or create a new list
3) Add items by barcode, confirm this functionality still works
4) Trigger error messages (adding duplicate barcodes, barcodes that
don't exist) to confirm they still show as appropriate
5) Test adding by biblionumber, confirm this works as expected
6) Trigger error messages (adding duplicate biblionumbers, biblionumbers
that don't exist). Confirm wording is appropriate in messages.
7) Add both barcodes and biblionumbers at the same time, confirm this
works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Israelex A Veleña for KohaCon17 
Signed-off-by: Israelex A Veleña for KohaCon17 

Signed-off-by: Harold 

Signed-off-by: macon lauren KohaCon2017 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17214] Add item in LIST by Record number

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66828|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 67816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67816=edit
Bug 17214: [FOLLOW-UP] Using Koha::Biblios instead of GetBiblio

Ready to test

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Katrin Fischer  ---
I've used some Japanese signs in 490 for testing: 日本日本日本;;;

The link is broken:
http://localhost:8080/cgi-bin/koha/opac-search.pl?q=se,phr:%22%3F%3F%3F%3F%3F%3F%3B%3B%3B%22

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16804] Searching can be broken by search terms containing semicolons in XSLT

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16804

--- Comment #5 from Katrin Fischer  ---
I think an easier solution would be to just remove ; for now as this is the
most common problem case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

--- Comment #6 from Katrin Fischer  ---
Created attachment 67814
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67814=edit
Screenshot of formatting issue on serial collection page

There is a tiny issue with the table heading on the serials collection page,
when a subscription is renewed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16962] Remove the use of "onclick" from serial collection and serial edit templates

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16962

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|grace.m...@gmail.com|oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16588] Remove the Readonly dependency (again)

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #33 from Katrin Fischer  ---
There is a conflict that I tried to fix, but maybe it's better you take a look.
Tried to locate other cases that need to be fixed: $ git grep '\$Koha:'

Koha/Authorities.pm:my $searcher = Koha::SearchEngine::Search->new({ index
=> $Koha::SearchEngine::BIBLIOS_INDEX });
Koha/Authorities.pm:my $searcher = Koha::SearchEngine::Search->new({ index
=> $Koha::SearchEngine::BIBLIOS_INDEX });

Looks suspicious.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15486] Restrict number of holds placed by day

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #17 from Katrin Fischer  ---
1) Translations in mind, I suggest to make the message a bit more specific:
Daily limit reached for patron >
Daily hold limit reached for patron

2) If nothing is entered, it appears to default to 0 (instead of unlimited). So
I think this will break existing installations. I'd suggest to copy the max
holds total into max holds daily.

3) The tests are giving me trouble:
kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Holds.t
t/db_dependent/Holds.t .. 26/59 # Looks like you planned 59 tests but ran 56.
t/db_dependent/Holds.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 3/59 subtests 

Test Summary Report
---
t/db_dependent/Holds.t (Wstat: 65280 Tests: 56 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 59 tests but ran 56.
Files=1, Tests=56,  2 wallclock secs ( 0.02 usr  0.01 sys +  1.70 cusr  0.34
csys =  2.07 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15869] Change framework on overlay

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869

Katrin Fischer  changed:

   What|Removed |Added

Summary|change framework on overlay |Change framework on overlay

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15869] change framework on overlay

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #3 from Katrin Fischer  ---
Sorry, patch no longer applies. Please rebase:

55543 - Bug 15869 - change framework on overlay

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15869 - change framework on overlay
.git/rebase-apply/patch:17: trailing whitespace.
# optional callback to monitor status 
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M   C4/ImportBatch.pm
M   koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt
M   tools/manage-marc-import.pl
.git/rebase-apply/patch:17: trailing whitespace.
# optional callback to monitor status 
warning: 1 line adds whitespace errors.
Falling back to patching base and 3-way merge...
Auto-merging tools/manage-marc-import.pl
CONFLICT (content): Merge conflict in tools/manage-marc-import.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/tools/manage-marc-import.tt
Auto-merging C4/ImportBatch.pm
CONFLICT (content): Merge conflict in C4/ImportBatch.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 15869 - change framework on overlay
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-15869---change-framework-on-overlay-K6lG8D.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #19 from Katrin Fischer  ---
There seems to be a bug in this patch set. I have run the database update and
restart_all, but when I click on "Save description" there is no visual feedback
and nothing happens.

Also internal server error when I try to save my patron card batch:
DBD::mysql::st execute failed: called with 4 bind variables when 5 are needed
[for Statement "INSERT INTO creator_batches (batch_id, description,
borrower_number, branch_code, creator) VALUES (?,?,?,?,?);" with ParamValues:
0=Null!, 1=Null!, 2=Null!, 3=Null!, 4=Null!] at
/home/vagrant/kohaclone/C4/Creators/Batch.pm line 71.
Database returned the following error on attempted INSERT: called with 4 bind
variables when 5 are needed at /home/vagrant/kohaclone/C4/Creators/Batch.pm
line 73.
Can't use string ("-2") as a HASH ref while "strict refs" in use at
/home/vagrant/kohaclone/patroncards/edit-batch.pl line 124.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14620] Contact information validations

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #61843|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 67812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67812=edit
Bug 14620: Contact information validations

This patch adds a phone number validation by regex and centralizes
different validation methods into Koha::Validation class.

Introduces a new system preference, ValidatePhoneNumber, that takes a
regular expression and uses it to validate phone numbers both client
and server side.

Unit tests to test:
1. prove t/db_dependent/Koha/Validation.t

To test:
1. Apply the patches and run updatedatabase.pl to install the new
   system preference
2. Set system preference ValidatePhoneNumber to any regex you like
   (there is an example in the description of the preference)
3. Navigate to edit user contact informations in Staff client and OPAC.
4. Insert invalid email (e.g. "invalid") and invalid phone number
("+123invalid")
   and send the form.
5. Confirm that form will not be submitted and errors will be given.
6. Disable JavaScript and test that these errors will also be provided by the
   server.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14620] Contact information validations

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

--- Comment #26 from Katrin Fischer  ---
Apart from the qa script this worked nicely, please fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14620] Contact information validations

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #23 from Katrin Fischer  ---
There are some complaints from the QA tool:

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
   FAIL   forbidden patterns
forbidden pattern: opac-tmpl should certainly replaced with [%
interface %] (line 233)
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template


 FAIL   Koha/Validation.pm
   OK critic
   FAIL   forbidden patterns
forbidden pattern: Koha is now under the GPLv3 license (line 9)
   OK git manipulation
   OK pod
   OK pod coverage
   OK spelling
   OK valid

Tests pass, database update is ok.

Reattaching the rebased patch and a tiny follow-up with a suggestion for better
system preference formatting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14620] Contact information validations

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

--- Comment #25 from Katrin Fischer  ---
Created attachment 67813
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67813=edit
Bug 14620: (follow-up) Link URL in system preference description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14620] Contact information validations

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #22 from Katrin Fischer  ---
Had a conflict, think I fixed it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14590] Validate messaging preferences

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |BLOCKED

--- Comment #20 from Katrin Fischer  ---
Sorry, I had missed the dependency on bug 14620, but this also doesn't apply.
Marking this one 'blocked' and the other 'doesn't apply'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14590] Validate messaging preferences

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #19 from Katrin Fischer  ---
I am sorry, this does no longer apply:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14590: Validate messaging preferences
.git/rebase-apply/patch:663: trailing whitespace.
print scalar ($destination eq "circ") ? 
error: sha1 information is lacking or useless (Koha/Validation.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 14590: Validate messaging preferences
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-14590-Validate-messaging-preferences-JMLoUs.patch


>From eyeballing the code I was wondering if you only check 'primary email' and
don't take AutoEmailPrimaryAddress into account?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #32 from Katrin Fischer  ---
Patch doesn't apply, not sure how to fix, sorry!

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 13952: Import and export authority types
Using index info to reconstruct a base tree...
M   admin/import_export_framework.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt
Auto-merging admin/import_export_framework.pl
CONFLICT (content): Merge conflict in admin/import_export_framework.pl
error: Failed to merge in the changes.
Patch failed at 0001 Bug 13952: Import and export authority types
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-13952-Import-and-export-authority-types-CLgCHQ.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #57 from Katrin Fischer  ---
Sorry, patch no longer applies :(

Bug 12446 - Enable an adult to have a guarantor

64794 - Bug 12446 - Enable an adult to have a guarantor
64828 - Bug 12446 - Added a missing comma in kohastructure.sql

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12446 - Enable an adult to have a guarantor
Using index info to reconstruct a base tree...
M   installer/data/mysql/kohastructure.sql
M   installer/data/mysql/sysprefs.sql
M   koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
M   koha-tmpl/intranet-tmpl/prog/js/members.js
M   members/memberentry.pl
M   members/moremember.pl
M   svc/members/search
Falling back to patching base and 3-way merge...
Auto-merging svc/members/search
Auto-merging members/moremember.pl
Auto-merging members/memberentry.pl
CONFLICT (content): Merge conflict in members/memberentry.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/js/members.js
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging installer/data/mysql/kohastructure.sql
error: Failed to merge in the changes.
Patch failed at 0001 Bug 12446 - Enable an adult to have a guarantor
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-12446---Enable-an-adult-to-have-a-guarantor-iB_HiD.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

--- Comment #14 from Katrin Fischer  ---
Hi Joseph, can you sign off my follow-up and switch status to signed off if
it's ok?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

--- Comment #13 from Katrin Fischer  ---
Created attachment 67811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67811=edit
Bug 14919: (follow-up) Fixing some typos and adding to pref description

- Adds 'holds' to pref description of intranetreadinghistory
- Fixes typo in link to holds history from patron account
- Changes reserve date to hold date in table heading

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

--- Comment #11 from Katrin Fischer  ---
Created attachment 67809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67809=edit
Bug 14919: Add Koha::Patron->old_holds subroutine

Test plan:
Run t/db_dependent/Koha/Patrons.t

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

--- Comment #12 from Katrin Fischer  ---
Created attachment 67810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67810=edit
Bug 14919: Add holds history for patron

Test plan:
0) Have a patron with some current and old reserves
1) Go to patron circulation page
2) Notice, there is new item called "Holds history" in the left
circulation menu
3) Go to this page and confirm the data on this page are OK, and that
ui does behave as expected
4) Go to adminitration, columns setting, try to change the setting for
holdshistory table and confirm it is taken into account on holds history
page

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67728|0   |1
is obsolete||
  Attachment #67729|0   |1
is obsolete||
  Attachment #67807|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 67808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67808=edit
Bug 14919: Add test for Koha::Patron->old_holds subroutine

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

--- Comment #13 from Katrin Fischer  ---
Ah, I tried to trigger the new warns, but didn't succeed. Can you add a more
detailed test plan please?

It might also be good to use some standard styling for the message instad of:


See here: https://wiki.koha-community.org/wiki/Interface_patterns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #12 from Katrin Fischer  ---
When I choose 'Label test' from the sample data for printing, the PDF link
doesn't work, but I can see lots of errors with koha-plack-err:

GetMarcBiblio called with undefined biblionumber at
/home/vagrant/kohaclone/C4/Labels/Label.pm line 399.

Maybe it needs some check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

--- Comment #9 from Katrin Fischer  ---
If we tie it to intranetreadinghistory, could you add a little note to the pref
description so it's clear please? Retesting now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

--- Comment #30 from Katrin Fischer  ---
pply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 8630 - Adlibris covers (OPAC minified CSS)
Using index info to reconstruct a base tree...
M   koha-tmpl/opac-tmpl/bootstrap/css/opac.css
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/opac.css
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
error: Failed to merge in the changes.
Patch failed at 0001 Bug 8630 - Adlibris covers (OPAC minified CSS)
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-8630---Adlibris-covers-OPAC-minified-CSS-2gtmVc.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #29 from Katrin Fischer  ---
There is a conflict with the CSS files, Aleisha, could you fix please?
Would it be safe to leave the first patch off and then regenereate opac.css
from the lst one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8628] Add digital signs to the OPAC

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8628

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #23 from Katrin Fischer  ---
Trying to test :)

- Nothing found in code review.
- Database update works nicely.

Not OK:

- QA test tools give some bad results:

 FAIL   Koha/Schema/Result/Sign.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
   OK spelling
   OK valid

 FAIL   Koha/Schema/Result/SignStream.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
   OK spelling
   OK valid

 FAIL   Koha/Schema/Result/SignsToStream.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
   OK spelling
   OK valid

 FAIL   Koha/Sign.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
   OK spelling
   OK valid

 FAIL   Koha/SignStream.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
   OK spelling
   OK valid

 FAIL   Koha/SignsToStream.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
   OK spelling
   OK valid

 FAIL   installer/data/mysql/atomicupdate/bug_8628-digital-signs-sysprefs.sql
   OK git manipulation
   FAIL   semicolon
   OK sysprefs_order

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-signs.tt
   FAIL   forbidden patterns
   OK git manipulation
   FAIL   spelling
   OK tt_valid
   OK valid_template

- On the /cgi-bin/koha/tools/signs.pl the datatable is broken (next page, etc.)
- I think it would be nicer to use "SIGN" instead of "SIG" for the report group
and include it in the sample values.
- On point 16) of the test plan I receive an internal server error, so can't
test the last steps:
Can't use string ("1") as a HASH ref while "strict refs" in use at
/home/vagrant/kohaclone/C4/Biblio.pm line 1182.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Holds history for patron

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
Summary|Reserves history for patron |Holds history for patron

--- Comment #8 from Josef Moravec  ---
(In reply to Katrin Fischer from comment #6)
> Hi Josef,

Hi Katrin, thanks for testing!

> some small things:
> - 'Reserves' should be 'holds' everywhere (see terminology page)
should be fixed now
> - Please be careful about capitalization (page title)
Also fixed
> - Should this be tied to intranetreadinghistory or not better be a new
> separate pref? Or leave it with borrowers permission for now?
> +[% IF ( CAN_user_borrowers ) %]
> +[% IF ( intranetreadinghistory ) %]

I thought about that an I think history of holds is very similar as history of
checkouts... it's kind of part of checkouts... so I tied id with existing
preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Reserves history for patron

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Josef Moravec  changed:

   What|Removed |Added

  Attachment #67730|0   |1
is obsolete||

--- Comment #7 from Josef Moravec  ---
Created attachment 67807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67807=edit
Bug 14919: Add holds history for patron

Test plan:
0) Have a patron with some current and old reserves
1) Go to patron circulation page
2) Notice, there is new item called "Holds history" in the left
circulation menu
3) Go to this page and confirm the data on this page are OK, and that
ui does behave as expected
4) Go to adminitration, columns setting, try to change the setting for
holdshistory table and confirm it is taken into account on holds history
page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13359] provide virtual-mysql-server Depends On to facilitate alternate mysql implementations

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13359

Pablo AB  changed:

   What|Removed |Added

 CC||pablo.bian...@gmail.com

--- Comment #6 from Pablo AB  ---
JFTR, on Koha 17.05 over Ubuntu 16.04 is a good idea to use mariadb-server
instead of mysql[0]. apt-cache depends koha-common | grep mysql  pipe flag (OR)
reveals is a good idea to install mariadb-server *before* koha-common (thanks
wizzyrea!).

[0]
https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#Ubuntu_16.04_and_MySQL_5.7

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

--- Comment #10 from Katrin Fischer  ---
It's a neat little feature, even with the translation issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67186|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 67806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67806=edit
Bug 19233: (follow-up) Send itemnumbers in report results to batch modification

This patch changes the obscure "^" symbol to a styled link with the text
"Batch modify." I think the only disadvantage of this is that it takes
up more space, but it is outweighed by the improved clarity.

This patch also makes minor indentation corrections to new lines of
HTML.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19233] Add ability to send itemnumbers in report results to batch modification

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19233

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67087|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 67805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67805=edit
Bug 19233 - Add ability to send itemnumbers in report results to batch
modification

To test:
1 - Apply patch
2 - Run a report with an itemnumber column
3 - Note there is a linked '^' after column title
4 - Hover over the '^'
5 - You should see a tooltip 'Send visible items to batch modification'
6 - Click the '^'
7 - You should be sent to batch item modification with itemnumbers that
were visible in report

Signed-off-by: George 
Signed-off-by: BWS Sandboxes 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #14 from Katrin Fischer  ---
Sorry, tests are failing:

t/db_dependent/Budgets.t .. 2/145 
#   Failed test 'total ordered price is 20'
#   at t/db_dependent/Budgets.t line 475.
#  got: '26'
# expected: '20.00'
t/db_dependent/Budgets.t .. 99/145 # Looks like you failed 1 test of 145.
t/db_dependent/Budgets.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/145 subtests 

Test Summary Report
---
t/db_dependent/Budgets.t (Wstat: 256 Tests: 145 Failed: 1)
  Failed test:  65
  Non-zero exit status: 1
Files=1, Tests=145,  4 wallclock secs ( 0.04 usr  0.00 sys +  3.57 cusr  0.36
csys =  3.97 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18923] Resolve a warn in Biblio::GetCOinSBiblio

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18923

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #7 from Katrin Fischer  ---
My record had a 773 like this:

  
000621110
3
3,2
  

Still no luck. Can you please test again? Maybe another patch fixed it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19430] New: Can't receive serials from subscription detail page

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19430

Bug ID: 19430
   Summary: Can't receive serials from subscription detail page
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

When trying to receive a serial from the serial subscription page, I receive an
internal server error:

Can't call method "title" on an undefined value at
/home/vagrant/kohaclone/serials/serials-edit.pl line 424.

URL:
http://localhost:8081/cgi-bin/koha/serials/serials-edit.pl?subscriptionid=8=1,3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Needs Signoff   |Failed QA

--- Comment #5 from Katrin Fischer  ---
Hi Julian,

I've run the database update, dbic, and restart_all in this sequence. The
database updates look fine, the aqbooksellerid is populated in serial. 

But when I try to receive an issue, I have an error:

Internal server error

koha-plack-error:

Can't call method "title" on an undefined value at
/home/vagrant/kohaclone/serials/serials-edit.pl line 424.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18426] Subscriptions batch editing

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
Hi Julian,

didn't get far in testing, because even after running dbic and restart_all I
still get an internal server error, when I try to 'edit':

Template process failed: undef error - The method biblio is not covered by
tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121.
Template process failed: undef error - The method biblio is not covered by
tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121.


The subscription search seems to work nicely, agreeing about Nick's 1:

1 - The edit button is inconsistent, it should be a link as the others, and I
would suggest 'Edit selected serials' - Agreed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18784] Add 'auto claim' option to subscription batch edit tool

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

--- Comment #3 from Katrin Fischer  ---
Blocked by depending patches in Failed QA :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18784] Add 'auto claim' option to subscription batch edit tool

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18784

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |julian.maur...@biblibre.com
   |ity.org |
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19021] Inventory column sorting

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67138|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 67804
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67804=edit
Bug 19021 - inventory column sorting

In inventory result page, items are shown in a JS DataTable.
For an inventory with barcode file second column is not sortable for no reason.
For an inventory without barcode file first column is not sortable but since it
is the default sort order the sorting icon is still displayed.

This patch corrects by setting default sort order on callnumber column.

Test plan :
- perform inventory with barcode file
- look at result table
- table is sorted by callnumber
=> Without patch second column is not sortable
=> With patch all columns are sortable
- perform inventory without barcode file
- look at result table
=> Without patch first column show sort icon and table is not sorted by
callnumber
=> With patch first column is not sortable and table is sorted by callnumber

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19021] Inventory column sorting

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19384] [OMNIBUS] Add Selenium tests

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19384

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Are there instructions somewhere on how to set up the Selenium environment
necessary for testing the attached patches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822

--- Comment #7 from Katrin Fischer  ---
Still trying to get Elasticsearch to work, when reindexing from koha-shell I
get:
[NoNodes] ** No nodes are available: [http://localhost:9200], called from sub
Search::Elasticsearch::Role::Client::Direct::__ANON__ at
/usr/share/perl5/Catmandu/Store/ElasticSearch.pm line
27.kohadev-koha@kohadevbox:/home/vagrant/kohaclone$

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19270] Advanced Editor - Rancor - Add ability to search batches on arbitrary marc fields

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19270

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Hi Nick, I am sorry, but patch doesn't apply:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19270: Rancor - add ability to search batches by arbitrary marc
fields
error: sha1 information is lacking or useless (Koha/MetaSearcher.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 19270: Rancor - add ability to search batches by
arbitrary marc fields
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-19270-Rancor---add-ability-to-search-batches-b-MINXbI.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19274] Translatability: Fix new splitting problems related to database warnings

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19274

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66942|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 67803
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67803=edit
Bug 19274: Translatability: Fix new splitting problems related to database
warnings

The warnings about database problems introduce new translatability problems,
mostly related to sentence splitting by html tags.

To test:
- Verify that text changes make sense
- Apply patch, verify that messages properly.
  Note: To force display you might want to add '1 ||' to the related
  if statements, including line 134,  e.g. [% IF 1 || has_ai_issues %]
- Bonus test: Go through an translation cicle and verify that fragemts as
  mentioned in initial comment are gone.

(Amended to fix tiny typo)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19274] Translatability: Fix new splitting problems related to database warnings

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19274

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14919] Reserves history for patron

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Hi Josef,

some small things:
- 'Reserves' should be 'holds' everywhere (see terminology page)
- Please be careful about capitalization (page title)
- Should this be tied to intranetreadinghistory or not better be a new separate
pref? Or leave it with borrowers permission for now?
+[% IF ( CAN_user_borrowers ) %]
+[% IF ( intranetreadinghistory ) %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14647] Make the file name extension dynamic on exporting records

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14647

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||katrin.fisc...@bsz-bw.de

--- Comment #9 from Katrin Fischer  ---
Patch doesn't apply, please rebase!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13560] need an add option in marc modification templates

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
I think Update is not quite right as the option actually adds a field when it
doesn't exist yet. I have used it to add items with different subfields a lot
of times. Maybe it needs a better description - Add or update?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12365] Notes for rules

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66830|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 67802
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67802=edit
Bug 12365 - Notes for rules

Lee Jamison  rescued this patch.
It is a clean re-build of attachments 61865 and 63902
to fix the merge conflict introduced during application of both
attachments.

To test:
Follow test plan in Comment 2

Signed-off-by: Mark Tompsett 

Signed-off-by: macon  lauren KohaCon17 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12365] Notes for rules

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12365

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19338] Dates sorting incorrectly in opac-account.tt

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19338

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67582|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 67801
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67801=edit
Bug 19338 - Dates sorting incorrectly in opac-account.tt

To test:
Find an account with lots of fines/payments
load up the borrower's account in the OPAC
note that the sort on the dates sorts by day, and not by date.
apply this patch
reload the page, note that the sort on the dates is now correct.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19200] Warns when exporting a basket

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66602|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 67799
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67799=edit
Bug 19200: Preventing warns when exporting a basket

To test:
1) Go to Tools -> CSV profiles -> New CSV Profile
2) Create a new CSV profile with any name of SQL fields. Ensure profile
type: SQL and usage: basket export in acquisition
3) Go to Acquisitions -> Find or create a vendor -> Use or create a
basket
4) Click the dropdown menu next to the 'Export as CSV' button. There
should be a 'Default' option and your new CSV profile (at least)
5) Click the 'Default' option. Notice warns
6) Click the 'Export as CSV' button. Notice warns
7) Click your new CSV profile option. Notice warns
8) Apply patch and refresh page
9) Repeat steps 5-7, confirm that warns do not show
10) Confirm export still works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19200] Warns when exporting a basket

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19200

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67795|0   |1
is obsolete||

--- Comment #7 from Lari Taskula  ---
Created attachment 67798
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67798=edit
Bug 19410: (follow-up) Fix typo in POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19230] Warn when deleting a course in course reserves

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19230] Warn when deleting a course in course reserves

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19230

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66678|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 67797
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67797=edit
Bug 19230: Preventing warn when deleting course

To test:
1) Ensure UseCourseReserves is enabled
2) Go to Course Reserves, create a course
3) Delete course
4) Notice warn
5) Apply patch
6) Create a course again and delete it
7) Notice no warn

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19292] Add MARC code column on libraries list

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19292

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67675|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 67796
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67796=edit
Bug 19292: Add MARC code column on libraries list

Test plan:
0) Apply the patch
1) Go to admin/branches.pl
2) In the list of libraries, you should see new column "MARC Organization Code"
3) Insert some codes to some libraries
4) Confirm they are shown in new column

Signed-off-by: Katrin Fischer 
Fixed capitalization.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19292] Add MARC code column on libraries list

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19292

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19429] No confirm message when deleting an invoice from invoice search

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19401

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19401] No confirm message when deleting an invoice from invoice detail page

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19429

--- Comment #4 from Katrin Fischer  ---
Hi Aleisha, this works nicely! I have filed another bug report for the invoice
search page that is also missing the confirmation message: bug 19429

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19410] Koha::Objects needs a ->search_for_api method

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410

--- Comment #6 from Lari Taskula  ---
Created attachment 67795
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67795=edit
Bug 19410: (follow-up) Fix typo in POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19401] No confirm message when deleting an invoice from invoice detail page

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67541|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 67794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67794=edit
Bug 19401: Add confirm message when deleting invoice

To test:
1) Go to Acquisitions
2) Go to Invoices (left nav menu)
3) Click Search (no need to filter results)
4) Click dropdown menu for an invoice, click Details
5) Click Delete
6) Notice invoice is deleted instantly
7) Apply patch and repeat steps 4 and 5
8) Confirm the confirm message shows and works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19429] New: No confirm message when deleting an invoice from invoice search

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19429

Bug ID: 19429
   Summary: No confirm message when deleting an invoice from
invoice search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

When deleting an invoice from the invoice search page, there is no confirmation
message.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19401] No confirm message when deleting an invoice from invoice detail page

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19401

Katrin Fischer  changed:

   What|Removed |Added

Summary|No confirm message when |No confirm message when
   |deleting an invoice |deleting an invoice from
   ||invoice detail page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67703|0   |1
is obsolete||

--- Comment #21 from Lari Taskula  ---
Created attachment 67793
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67793=edit
Bug 19278: Mention RESTdefaultPageSize in POD

This patch adds information about RESTdefaultPageSize usage
when the per_page parameter is absent on the query.

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Lari Taskula  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67702|0   |1
is obsolete||

--- Comment #20 from Lari Taskula  ---
Created attachment 67792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67792=edit
Bug 19278: Make the pagination plugin use RESTdefaultPageSize

This bug introduces a new syspref RESTdefaultPageSize that is used on
the Koha::REST::Plugin::Pagination plugin to default to a valid value
for the page size if the param is not present on the query.

This patch also considers the situation in which no 'page' param is
passed, and no header should be added.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> FAIL: Tests fail because the plugin doesn't behave as the tests
expect.
- Apply this patch
- Run:
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: Camden County
Sponsored-by: ByWater Solutions

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67700|0   |1
is obsolete||

--- Comment #18 from Lari Taskula  ---
Created attachment 67790
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67790=edit
Bug 19278: Add RESTdefaultPageSize syspref

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19278] Add a configurable default page size for endpoints

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19278

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67701|0   |1
is obsolete||

--- Comment #19 from Lari Taskula  ---
Created attachment 67791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67791=edit
Bug 19278: Unit tests

This patch introduces tests for a behaviour change in
Koha::REST::Plugin::Pagination.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Pagination.t
=> FAIL: Tests should fail without the followup patch applied

Sponsored-by: Camden County
Sponsored-by: Bywater Solutions

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19414] Move the location of the 'Import this batch into the catalog' button

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19414

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67628|0   |1
is obsolete||

--- Comment #2 from Katrin Fischer  ---
Created attachment 67789
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67789=edit
Bug 19414 - Move the location of the 'Import this batch into the catalog'
button

Moves the location of the button in question to be below the framework selector

Test plan:
1. Go to Tools -> Stage MARC records for import
2. Upload a .mrc file and stage it for import
3. Click Manage staged records
4. Note that the import button appears above the framework selector
5. Apply patch
6. Refresh the window
7. Notice that the button has now moved to below the framework selector

Sponsored-By: CALYX information essentials

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19414] Move the location of the 'Import this batch into the catalog' button

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19414

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Thx for your first patch, Dilan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19414] Move the location of the 'Import this batch into the catalog' button

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19414

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19415] FindDuplicateAuthority is searching on biblioserver since 16.05

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19415

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #67632|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 67788
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67788=edit
Bug 19415: FindDuplicateAuthority is searching on biblioserver since 16.05

Commit b4392018bc1f9bf6a2f7dfe70b488856ad3a3897 [Bug 12478: make things using
SimpleSearch use the new version] changed sub FindDuplicateAuthority and
replaced this call (from 3.22.x) in 16.05 (pushed April 2016):
my ($error, $results, $total_hits) = C4::Search::SimpleSearch( $query, 0,
1, [ "authorityserver" ] );

The new call does unfortunately not include the authorityserver:
my ($error, $results, $total_hits) = $searcher->simple_search_compat(
$query, 0, 1 );
Simple_search_compat redirects to C4/Search/SimpleSearch and SimpleSearch
assumes a biblioserver if no server is passed.

This effectively makes FindDuplicateAuthority useless since we will no longer
find duplicates and we could see an error like this in the log:
16:51:42-04/10 zebrasrv(51) [request] Search biblios ERROR 114 1 1+0 RPN
@attrset Bib-1 @and @attr 1=authtype PERSO_NAME @attr 1=Heading Moerenhout

The fix is obviously trivial.

Test plan:
[1] Go to Authorities.
[2] Add a new authority PERSO_NAME with 100a Moerenhout.
[3] Repeat step 2. Verify that you get the duplicate authority warning.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19415] FindDuplicateAuthority is searching on biblioserver since 16.05

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19415

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67377|0   |1
is obsolete||

--- Comment #26 from Lari Taskula  ---
Created attachment 67787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67787=edit
Bug 19234: (followup) Make Query plugin available to endpoints

Signed-off-by: Kyle M Hall 

Signed-off-by: Kyle M Hall 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67375|0   |1
is obsolete||

--- Comment #25 from Lari Taskula  ---
Created attachment 67786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67786=edit
Bug 19234: Add query parameters handling helpers

This patch introduces a Mojolicious plugin to be used on the REST api.
It adds a helper method:

generate_dbic_query
===

When used, it generates what's needed to perform a search on
DBIC/Koha::Objects like this:

my $params  = $c->validation->output;
my ($filtered_params, $reserved_params) =
$c->extract_reserved_params($params);

my $filter = do_smth($filtered_params, $reserved_params);
my $attributes = do_smth_reserved($reserved_params);

my $patrons = Koha::Patrons->search( $filter, $attributes );

It introduces reserved param names:
- _match
- _order_by
- _page
- _per_page

They are reserved for later usage (pagination, matching algorithm on building
DB queries)

All the plugin's behaviour is tested.

To test:
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass!
- Sign off :-D

Sponsored-by: ByWater solutions
Sponsored-by: Camden County

Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19234] Add query parameters handling helpers

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67374|0   |1
is obsolete||

--- Comment #24 from Lari Taskula  ---
Created attachment 67785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67785=edit
Bug 19234: Unit tests for query parameters handling helpers

This patch adds unit tests for the new query parameters handling Mojo plugin.

Sponsored-by: Camden County
Sponsored-by: ByWater Solutions

Signed-off-by: Kyle M Hall 
Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Kyle M Hall 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19370] Add a helper function for translating order_by params into SQL ::Abstract

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Lari Taskula  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19370] Add a helper function for translating order_by params into SQL ::Abstract

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67576|0   |1
is obsolete||

--- Comment #11 from Lari Taskula  ---
Created attachment 67784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67784=edit
Bug 19370: Remove undefined variable warning

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19370] Add a helper function for translating order_by params into SQL ::Abstract

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67402|0   |1
is obsolete||

--- Comment #9 from Lari Taskula  ---
Created attachment 67782
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67782=edit
Bug 19370: Unit tests

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19370] Add a helper function for translating order_by params into SQL ::Abstract

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370

Lari Taskula  changed:

   What|Removed |Added

  Attachment #67403|0   |1
is obsolete||

--- Comment #10 from Lari Taskula  ---
Created attachment 67783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67783=edit
Bug 19370: Add helper function for order_by attribute generation

This patch introduces a helper function called 'dbic_merge_sorting'
to Koha::REST::Plugin::Query.

This simple function adds SQL::Abstract order_by attribute to the passed
$filter hashref, as explained in the POD.

It introduces a syntax for passing sorting params on the request to the REST
api.
The proposed syntax has been found in the wild, and is pretty trivial to
parse/work with:

GET /api/v1/?order_by=+column_1|-column_2|column_3

As explained on the POD, + stands for 'asc' and - for 'desc'. If ommited, it
defaults to the
DB engine default (usually asc).

To test:
- Apply this patches
- Run:
  $ sudo koha-shell kohadev
 k$ cd kohaclone
 k$ prove t/Koha/REST/Plugin/Query.t
=> SUCCESS: Tests pass! And they make sense! :-P
- Sign off :-D

Edit: renamed params to match DBIC terminology. My bad :-D (tcohen)

Sponsored-by: Camden County

Signed-off-by: Lari Taskula 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Needs Signoff   |Failed QA

--- Comment #3 from Katrin Fischer  ---
The new message is not translatable, can you please fix?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19418] Patron search is broken

2017-10-07 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19418

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Katrin Fischer  ---
I've made sure that I have patron attributes configured, that it is marked
searchable and that at least one of the patrons has it set.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 110 matches

Mail list logo