[Koha-bugs] [Bug 16401] System preference staffClientBaseURL hardcoded to 'http://'

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401

--- Comment #15 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #12)
> I don't see how this change would affect notices or letters. When I tested
> this initially I checked all occurrences of the preference had been taken
> into account.

Are there any letters with something like <>? Because
OPACBaseURL had some with http:// in front for some letters/notices. I vaguely
remember checking and not finding anything, but that is how. So Passed QA is
fine with me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch
 Depends on||15084


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
[Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[y|ies]
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19328] Internal server error because of missing currency

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67321|0   |1
is obsolete||

--- Comment #5 from Nick Clemens  ---
Created attachment 67922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67922=edit
Bug 19328 - Internal server error because of missing currency

This patch fixes internal server errors because of missing active currency
in files aqbudgetperiods.pl, aqbudgets.pl and aqplan.pl.

To reproduce:
- Make sure that no active currency is defined. You can undefine the active
  currency in Administration->Currencies and exchange rates
- Try to go to Administration->Budgets and Admistration->Funds
Result: Internal server error

To test:
- Apply patch
- Restart plack
- Try to reproduce issue, it should no longer occur. There should be a
  yellow message box "No active currency is defined"
- From Administration-> Budgets administration try to edit a fund and go to
  "Planning". Verify that the message box appears here as well.

Signed-off-by: David Bourgault 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15084] Move the currency related code to Koha::Acquisition::Currenc[ y|ies]

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084

Nick Clemens  changed:

   What|Removed |Added

 Blocks||19328


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19328
[Bug 19328] Internal server error because of missing currency
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19259] Overdue rules do not save ( delay field should only accept numbers)

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19259] Overdue rules do not save ( delay field should only accept numbers)

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19259

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67482|0   |1
is obsolete||

--- Comment #14 from Nick Clemens  ---
Created attachment 67921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67921=edit
Bug 19259: Enforce type of the delay value when editing overdue rules -
template side only

Overdue rules do not save when a delay that is not an integer > 0,
without any warnings.
This patch forces the user to select a number > 0.

Test plan:
Without this patch applied, enter non-integer value or negative or 0
=> The rule will not be inserted without any warnings.
With this patch applied you will get an message from the browser and the
form will not save

Signed-off-by: David Bourgault 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18709] koha-foreach should use koha-shell, internally

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18709

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18709] koha-foreach should use koha-shell, internally

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18709

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67372|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 67920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67920=edit
Bug 18709: Make koha-foreach use koha-shell internally

This patch simplifies the koha-foreach script, making it use koha-shell
to gain instance privileges and have all environment variables set.

To test:
- Apply the patch
- Have one or more instances created (kohadev already exists in kohadevbox, add
  another onewith $ sudo koha-create --create-db test)
- Run:
  $ sudo kohaclone/debian/scripts/koha-foreach echo "This is instance
__instancename__"
=> SUCCESS: The script runs gracefuly, and outputs something like:
This is instance kohadev
This is instance test
  Note: this means the command was executed for each instance and the current
behaviour
of replacing the placeholder __instancename__ for the actual instance
name still
works as expected.
- You can try the different filter switches, but the logic has not been
touched. only the
  command call.
- Sign off :-D

Signed-off-by: Jonathan Druart 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16401] System preference staffClientBaseURL hardcoded to 'http://'

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67270|0   |1
is obsolete||
  Attachment #67271|0   |1
is obsolete||

--- Comment #13 from Nick Clemens  ---
Created attachment 67918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67918=edit
Bug 16401: System preference staffClientBaseURL hardcoded to 'http://'

Test plan:
1) Insert some value to staffBaseURL preference, without starting http://
2) Apply the patch
3) Update database
4) Go to system preferences adminsitration, find the staffBaseURL
preference, the inserted value should be prepended with 'http://' and
the comment should be "This should be a complete URL, starting with
http:// or https://. Do not include a trailing slash in the URL. (This
must be filled in correctly for CAS, svc, and load_testing to work.)"
5) prove t/db_dependent/Auth_with_cas.t
6) prove t/db_dependent/selenium/basic_workflow.t
7) prove t/db_dependent/check_sysprefs.t

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16401] System preference staffClientBaseURL hardcoded to 'http://'

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401

--- Comment #14 from Nick Clemens  ---
Created attachment 67919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67919=edit
Bug 16401: (follow-up) Avoid changing empty staffClientBaseURL preference

Adds a condition to check that the staffClientBaseUrl is not empty
before updating it with 'http://'.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16401] System preference staffClientBaseURL hardcoded to 'http://'

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16401

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #5 from Nick Clemens  ---
Works in my testing.

I would suggest adding parens to the second conditional:
if ( (a and b) or (c) )
just for clarity, but not necessary if you don't want to

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67863|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 67917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67917=edit
Bug 19431: Fix error when checking out an unknown barcode

It seems this has been caused by
  commit 1544f9a5d4a8acd47c97d7c6ac55dee8e759d3ff
Bug 18276: Remove GetBiblioFromItemNumber - circulation pages

To reproduce the problem you need switch on the two prefs
 - OnSiteCheckouts
 - OnSiteCheckoutsForce

Test plan:
Try to check an item out using an unknown barcode
With the 2 prefs set to on and without this patch, you will get the
following error in the log
  Can't call method "materials" on an undefined value at
/home/vagrant/kohaclone/circ/circulation.pl line 387.

With this patch applied you should not get this error and a correct
behaviour for the different pref combinations.

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19414] Move the location of the 'Import this batch into the catalog' button

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19414

Nick Clemens  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19414] Move the location of the 'Import this batch into the catalog' button

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19414

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67789|0   |1
is obsolete||

--- Comment #4 from Nick Clemens  ---
Created attachment 67916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67916=edit
Bug 19414 - Move the location of the 'Import this batch into the catalog'
button

Moves the location of the button in question to be below the framework selector

Test plan:
1. Go to Tools -> Stage MARC records for import
2. Upload a .mrc file and stage it for import
3. Click Manage staged records
4. Note that the import button appears above the framework selector
5. Apply patch
6. Refresh the window
7. Notice that the button has now moved to below the framework selector

Sponsored-By: CALYX information essentials

Signed-off-by: Katrin Fischer 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19414] Move the location of the 'Import this batch into the catalog' button

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19414

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12446] Enable an adult to have a guarantor

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446

Aleisha Amohia  changed:

   What|Removed |Added

 CC|alei...@catalyst.net.nz |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

--- Comment #35 from Aleisha Amohia  ---
Rebased, updated test plan, ready to test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #67914|0   |1
is obsolete||

--- Comment #34 from Aleisha Amohia  ---
Created attachment 67915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67915=edit
Bug 13952: Import and export authority types

This patch amends C4::ImportExportFramework to work for authority types as well
as MARC frameworks.
New file: admin/import_export_authtype.pl
Update: Ensuring we are passing the right column to the right tables.
Update2: Making the error messages the same to be consistent with patch on Bug
15665
Update3: Fixing merge conflicts
Update4: Fixing merge conflicts and removing tabs
Update5: Getting rid of warns, making sure Import and Export of default
authority will work
Update6: Merge conflicts and making sure export of default auth type
works
Update7: Fixing merge conflicts and updating buttons to bootstrap3

To test:
1) Go to Admin -> Authority types
2) Confirm there are two new columns 'Export' and 'Import' in the table
3) Click 'Export' on an existing authority type and choose a file type, click
'Export'
4) Confirm that the authority type is exported as your chosen file type. Save
the file
5) Create a new authority type
6) Import into your new authority type using the file you just exported
7) Confirm you are taken to auth_tag_structure.pl
8) Go back to Authority types
9) Export your new authority type. View the exported file and confirm
the authtypecode has been updated to match the code you set for the new
auth type
10) Click 'Import' next to any existing authority type and attempt to import a
file that is not XML, CSV or ODS. Confirm that this fails and you are asked to
import a file of the correct file type
11) Confirm Export and Import work for the Default authority type
12) Go to Admin -> MARC bibliographic framework
13) Confirm that the 'Export' and 'Import' functions still work here as well

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #59831|0   |1
is obsolete||

--- Comment #33 from Aleisha Amohia  ---
Created attachment 67914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67914=edit
Bug 13952: Import and export authority types

This patch amends C4::ImportExportFramework to work for authority types as well
as MARC frameworks.
New file: admin/import_export_authtype.pl
Update: Ensuring we are passing the right column to the right tables.
Update2: Making the error messages the same to be consistent with patch on Bug
15665
Update3: Fixing merge conflicts
Update4: Fixing merge conflicts and removing tabs
Update5: Getting rid of warns, making sure Import and Export of default
authority will work
Update6: Merge conflicts and making sure export of default auth type
works
Update7: Fixing merge conflicts and updating buttons to bootstrap3

To test:
1) Go to Admin -> Authority types
2) Confirm there are two new columns 'Export' and 'Import' in the table
3) Click 'Export' on an existing authority type and choose a file type, click
'Export'
4) Confirm that the authority type is exported as your chosen file type. Save
the file
5) Create a new authority type
6) IMPORTANT STEP:
Before you import, make sure that the authtypecode of the file you
are going to import matches the Code of your new authority type. Use
Vim or something similar to do a search and replace and change the
codes in your file - do NOT use LibreOffice etc. because it tries to
be too helpful and messes with the formatting of the file (this is what has
broken the Import function in previous testing of this patch)
7) Import into your new authority type using the file you just exported
(make sure you've done Step 6)
8) Confirm you are taken to auth_tag_structure.pl
9) Go back to Authority types
10) Click 'Import' next to any existing authority type and attempt to import a
file that is not XML, CSV or ODS. Confirm that this fails and you are asked to
import a file of the correct file type
11) Confirm Export and Import work for the Default authority type
12) Go to Admin -> MARC bibliographic framework
13) Confirm that the 'Export' and 'Import' functions still work here as well

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

--- Comment #36 from Aleisha Amohia  ---
Patches rebased, ready for testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #64250|0   |1
is obsolete||

--- Comment #35 from Aleisha Amohia  ---
Created attachment 67913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67913=edit
Bug 14715: [FOLLOW-UP] Fixing qa-tools issues

and merge conflicts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #61721|0   |1
is obsolete||

--- Comment #34 from Aleisha Amohia  ---
Created attachment 67912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67912=edit
Bug 14715: results per page setting for catalog search

Add new select field to catalog search results pages which allows user to set
number
of results to be shown per page. Setting saved in cookie "results_per_page".

To test:
1) Do a catalog search in the intranet and OPAC
2) Confirm that results automatically update upon selection of results
per page to show
3) Test for all options (20, 40, 60, 80, 100, all)

Bug 14715: syspref for results per page options

Remove the "all" option.

Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of
results per page including [OPAC]numSearchResults.

Bug 14715: database updates

Bug 14715: Fixing pagination problems

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #85 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #80)
> my $basket = Koha::Acquisition::Orders->find($ordernumber)->basket;
> 
> should be enough.
Indeed - I was debugging a typo so was more specific to be sure error was not
there

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #84 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #83)
> Nick, does this last patch makes sense to you?

Yes, there is more we could switch to use of objects, but I didn't want to get
sidetracked

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18626] Add ability to track cardnumber changes for patrons

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18298] Enforce password complexity

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10021

--- Comment #71 from Jonathan Druart  
---
Note: sounds like the "notify" code is not used (see bug 10021).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12768

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #83 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #82)
> Created attachment 67911 [details] [review]
> Bug 15685: Send the basket to _cancel_items_receipt

Nick, does this last patch makes sense to you?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #81 from Jonathan Druart  
---
Created attachment 67910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67910=edit
Bug 15685: Avoid "Use of uninitialized value" warning in logs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #82 from Jonathan Druart  
---
Created attachment 67911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67911=edit
Bug 15685: Send the basket to _cancel_items_receipt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #80 from Jonathan Druart  
---
my $basket = Koha::Acquisition::Orders->find($ordernumber)->basket;

should be enough.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #79 from Jonathan Druart  
---
Comment on attachment 67907
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67907
Bug 15685: Followup - address QA issues

Review of attachment 67907:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15685=67907)
-

-my $basket = Koha::Acquisition::Order->find( $order->{ordernumber}
)->basket;
+my $basket = Koha::Acquisition::Orders->find({ordernumber =>
$ordernumber})->basket;

Why?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #78 from Jonathan Druart  
---
Created attachment 67909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67909=edit
Bug 15685: DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #74 from Jonathan Druart  
---
Created attachment 67905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67905=edit
Bug 15685: POD

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #77 from Jonathan Druart  
---
Created attachment 67908
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67908=edit
Bug 15685: Fix DB columns order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #76 from Jonathan Druart  
---
Created attachment 67907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67907=edit
Bug 15685: Followup - address QA issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #75 from Jonathan Druart  
---
Created attachment 67906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67906=edit
Bug 15685: Add tests for Koha::Acquisition::Order->basket

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #73 from Jonathan Druart  
---
Created attachment 67904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67904=edit
Bug 15685: (QA followup) Tidy tests

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #71 from Jonathan Druart  
---
Created attachment 67902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67902=edit
Bug 15685: (QA followup) Fix typo

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #72 from Jonathan Druart  
---
Created attachment 67903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67903=edit
Bug 15685: (followup) K:A:O->find and ->fetch are no longer used

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #70 from Jonathan Druart  
---
Created attachment 67901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67901=edit
Bug 15685: QA Followup

DB revision fixes
Unit tests

Edit: fixed the update step description (tcohen)

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #69 from Jonathan Druart  
---
Created attachment 67900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67900=edit
Bug 15685: (QA followup) Fix qa script errors

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #67689|0   |1
is obsolete||
  Attachment #67690|0   |1
is obsolete||
  Attachment #67691|0   |1
is obsolete||
  Attachment #67692|0   |1
is obsolete||
  Attachment #67693|0   |1
is obsolete||
  Attachment #67694|0   |1
is obsolete||
  Attachment #67695|0   |1
is obsolete||
  Attachment #67696|0   |1
is obsolete||
  Attachment #67697|0   |1
is obsolete||
  Attachment #67698|0   |1
is obsolete||
  Attachment #67884|0   |1
is obsolete||

--- Comment #67 from Jonathan Druart  
---
Created attachment 67898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67898=edit
Bug 15685: Allow creation of items (AcqCreateItem) to be customizable
per-basket

This adds a new basket attribute (create_items) that can optionally be
set to override AcqCreateItem.

The following have been modified to reflect this (with the value of
create_items that causes them to behave differently in parentheses):
  * Cancelling receipt of an order (receiving)
  * Creating an order by hand or from MARC (ordering)
  * Receiving an order (receiving)
  * Showing orders with uncertain price (ordering)
  * Showing orders (receiving)
  * Showing acquisition details in the OPAC (ordering)

Test plan:
  1) Create baskets with "Create items when:" set to ordering,
 receiving, cataloging and unset.
  2) Test each of the above for each of these baskets, verifying that
 the basket-specific attribute overrides AcqCreateItem if set and
 falls back to the syspref otherwise.

NOTE: A check of AcqCreateItem in opac-detail.tt was removed because it
was redundant; the code path in question cannot be triggered unless
create_items/AcqCreateItems is set to the correct value anyway.

Signed-off-by: Kyle M Hall 
Signed-off-by: Barbara Fondren 

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #68 from Jonathan Druart  
---
Created attachment 67899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67899=edit
Bug 15685: Implement needed changes in Koha::Edifact::Order

Signed-off-by: Katrin Fischer 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #70 from Jonathan Druart  
---
1. accounttype "PF" must be handle in the SWITCH block in templates
2. Any chances to see the tests cleaned a bit? There are a lot of c/p
3. I got an error, to reproduce:
 useDefaultReplacementCost set to "Use"
 itemtype.defaultreplacecost = 1
 itemtype.processfee = 2
Check an item out
Mark it as lost
=> 2 fines are created (L=1, PF=2)
Use the "pay selected" button

{UNKNOWN}: Can't call method "unblessed" on an undefined value at
/home/vagrant/kohaclone/C4/Circulation.pm line 2177. at
/home/vagrant/kohaclone/C4/Circulation.pm line 2194

May be a bug in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #69 from Jonathan Druart  
---
Created attachment 67897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67897=edit
Bug 12768: DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #68 from Jonathan Druart  
---
Created attachment 67896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67896=edit
Bug 12768: Fix YAML syntax in circulation.pref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #64 from Jonathan Druart  
---
Created attachment 67892
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67892=edit
Bug 12768 - Replacement cost and processing fee management

Signed-off-by: Eivin Giske Skaaren 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #65 from Jonathan Druart  
---
Created attachment 67893
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67893=edit
Bug 12768 - Fix up unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #67875|0   |1
is obsolete||
  Attachment #67876|0   |1
is obsolete||
  Attachment #67877|0   |1
is obsolete||
  Attachment #67878|0   |1
is obsolete||

--- Comment #63 from Jonathan Druart  
---
Created attachment 67891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67891=edit
Bug 12768 - DB changes

Signed-off-by: Eivin Giske Skaaren 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #67 from Jonathan Druart  
---
Created attachment 67895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67895=edit
Bug 12768: Add missing IGNORE clauses

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #66 from Jonathan Druart  
---
Created attachment 67894
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67894=edit
Bug 12768 - Revert changes to getcharges

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18957] Book renewed online does not show the time of renewal

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957

--- Comment #6 from Vinod  ---
Yes Jonathan, i can see the time when renewed from staff client, but now i have
to check the behavior again and i have upgraded to Koha 16.11.11.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |Failed QA

--- Comment #15 from Jonathan Druart  
---
You need to escape the string somewhere, try to enter "a reason" (with the
quote)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED

--- Comment #3 from Nick Clemens  ---
That's fair, I can look into that, this was mostly just in response to having
to chase down that code, may take a while before I get back here

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417

--- Comment #4 from Nick Clemens  ---
The error is returned by the Ajax call, I don't know if we can make it
translatable, I think we would have to define our own messages, but parsing out
directories etc might be difficult.  

How would it be to preserve the existing but add a 'more details' option that
would display this untranslatable text?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67601|0   |1
is obsolete||

--- Comment #15 from Nick Clemens  ---
Created attachment 67890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67890=edit
Bug 19166 - Unit tests for GetBudgetSpent and GetBudget ordered

To test:
1. prove -v t/db_dependent/Budgets.t
2. Should return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18957] Book renewed online does not show the time of renewal

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957

--- Comment #5 from Jonathan Druart  
---
(In reply to Vinod from comment #4)
> At least staff if renewed from staff slient it shows time but not if renewed
> from OPAC.

Are you sure? How? I do not see the time part, even if renewed from the staff
side.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7468] Add label to batch by barcode range

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7468

Michael Kuhn  changed:

   What|Removed |Added

 CC||m...@adminkuhn.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17526] OPAC lists require a sortfield

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526

--- Comment #9 from Jonathan Druart  
---
This patch is no longer relevant, it has been fixed by
  commit 45cffd874c62c7b090390c5fb3c955c31f524608
Bug 17901: Fix possible SQL injection in shelf editing

However we could update the existing bad data anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #8 from Nick Clemens  ---
Created attachment 67888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67888=edit
Bug 15494 - Update display of renewal errors

To test:
1 - Define a rule to deny renewal
2 - Checkout an item meeting this rule
3 - Attempt renew an item via the OPAC
4 - Attempt renewal via SIP
5 - Attempt renewal via staff client
6 - Verify errors are reasonable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #7 from Nick Clemens  ---
Created attachment 67887
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67887=edit
Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #9 from Nick Clemens  ---
Created attachment 67889
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67889=edit
Bug 15494 - Add syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

  Attachment #63700|0   |1
is obsolete||
  Attachment #63701|0   |1
is obsolete||
  Attachment #63702|0   |1
is obsolete||
  Attachment #63703|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 67886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67886=edit
Bug 15494 - Unit tests

prove t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18957] Book renewed online does not show the time of renewal

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957

--- Comment #4 from Vinod  ---
Ok, But what if i need time part also to have some reason/observation on user
activities on renewal time?

At least staff if renewed from staff slient it shows time but not if renewed
from OPAC. Hope this may be a genuine bug to resolve.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19275] clubs table broken at the opac if public enrollment is not allowed

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19275] clubs table broken at the opac if public enrollment is not allowed

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19275

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #4 from Jonathan Druart  
---
I do not get this error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

--- Comment #14 from Nick Clemens  ---
Added Sonia's sign off back to patch (one line change)

Works well, 'Cancel' does seem awkward but like the feature, not a blocker

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18957] Book renewed online does not show the time of renewal

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957

--- Comment #3 from Jonathan Druart  
---
I am seeing
  "The following items have been renewed on 10/10/2017 00:00"
>From both OPAC and staff interface.

You must use the "dateonly" filter if you want to get rid of the time part
(00:00):
  The following items have been renewed on <>

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18399] Reason is missing in suggestion management part

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18399

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67832|0   |1
is obsolete||

--- Comment #13 from Nick Clemens  ---
Created attachment 67885
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67885=edit
Bug 18399 - Add reasons in edit suggestion page

Test plan:

 - Fill the authorised values's category 'SUGGEST' with reason
 - Edit a pending suggestion. Set the status to rejected
   and select a reason
 - Check the reason has been saved (i.e in the suggestions
   table of rejected tab)
 - Check in the corresponding message_queue that the reason
   is here
 - Re-edit the same suggestion
 - Check that the correct reason is selected by defaut
 - Edit an other pending suggetion. Set the status to rejected,
   select other reason and fill the input text
 - Re-edit the previews suggestion and make sure the input
   "other" is displayed by default with the correct value

Signed-off-by: Sonia BOUIS 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18772] t/ImportBatch.t noise

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18772

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||10407
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407
[Bug 10407] Allow MARCXML records to be imported with Tools/Stage MARC records
for import
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10407] Allow MARCXML records to be imported with Tools/ Stage MARC records for import

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18772


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18772
[Bug 18772] t/ImportBatch.t noise
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18957] Book renewed online does not show the time of renewal

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957

--- Comment #2 from Vinod  ---
I am using the following template in my defined library

"Dear Patron,

The following Book/s have been renewed on <>:


<>"


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18957] Book renewed online does not show the time of renewal

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
What notice template are you using for RENEWAL?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19443] Error while attempting to duplicate a patron

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443

Alex Arnaud  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19443] New: Error while attempting to duplicate a patron

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443

Bug ID: 19443
   Summary: Error while attempting to duplicate a patron
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alex.arn...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

HTML in the patron creating/editing form is not correct.
If you create a patron and Koha detect a duplicate one, the new page
loaded contains a new form at the top with a button inside: 
"Not a duplicate. Save as new record"

This form is not closed () and in some situations this could
be problematic.

Try this test plan:

 - Edit the syspref IntranetUserJS and type the following code:
   "$(document).ready(function() {
$("#memberentry_library_management").insertBefore("#memberentry_identity");
});"
   This code move the "Library management" part (cardnumber, Library, Category
etc...) on the top of the page.
 - create a patron so that Koha will warn you about a duplicate one,
 - click on "Not a duplicate. Save as new record",
 - you should get error(s) about empty field(s).
   Note that now, the library management part's fields are empty or reset to
default

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19196] Add pagination helpers

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

--- Comment #34 from Marcel de Rooy  ---
(In reply to Tomás Cohen Arazi from comment #33)
> (In reply to Marcel de Rooy from comment #32)
> > Error while loading /etc/koha/plack.psgi: Can't load application from file
> > "api/v1/app.pl": Can't locate
> > Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm:  
> > ./Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm: Permission denied at
> > (eval 1295) line 1.
> 
> Mojolicious version?

7.21

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

--- Comment #66 from Nick Clemens  ---
Created attachment 67884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67884=edit
Bug 15685: Followup - address QA issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19442] New: add patron attributes into the patron card creator

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19442

Bug ID: 19442
   Summary: add patron attributes into the patron card creator
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Work to be done: 
1 - Add the ability to define fields as attribute.CODE in the card creator
template 
2 - When these codes are found replace them with the correct value for the
patron

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19196] Add pagination helpers

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196

--- Comment #33 from Tomás Cohen Arazi  ---
(In reply to Marcel de Rooy from comment #32)
> Error while loading /etc/koha/plack.psgi: Can't load application from file
> "api/v1/app.pl": Can't locate
> Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm:  
> ./Mojolicious/Plugin/Koha/REST/Plugin/Pagination.pm: Permission denied at
> (eval 1295) line 1.

Mojolicious version?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18963] Some checkins have been moved to old_issues without a returndate

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18963

Jonathan Druart  changed:

   What|Removed |Added

Summary|Check In Issue  |Some checkins have been
   ||moved to old_issues without
   ||a returndate

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18963] Check In Issue

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18963

--- Comment #2 from Jonathan Druart  
---
Seen also on the mailing list:
https://lists.katipo.co.nz/pipermail/koha/2017-September/049004.html

It seems that some checkouts has been moved to old_issues when checked in
without a returndate. No idea how it is possible, neither which versions are
impacted.

Please report and give information if you encountered this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

--- Comment #8 from David Bourgault  ---
A patch correcting errors in Bug 17015 (on which this bug depends) broke this
bug. I rebased the patches to correct this, and corrected an error in
minutes_loan.t which should now pass OK.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18961] Datatable column filters of style 'select' should do an exact match

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18961

--- Comment #1 from Jonathan Druart  
---
Created attachment 67883
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67883=edit
Bug 18961: Use exact match for select filters on item search

The SQL operator LIKE is always used for filters when searching for
items.

If the filter is a select, we should search for an exact match.
That way we avoid problematic search like "%NFIC%" and "%FIC%" (one
includes the other one).

Test plan:
- Make sure you have collection codes 'Fiction' and 'Non-fiction'
- Do an item search
- Filter column 'Collection', select 'Fiction'
- Result: Column contains items from Fiction only

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18961] Datatable column filters of style 'select' should do an exact match

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18961

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

David Bourgault  changed:

   What|Removed |Added

  Attachment #59522|0   |1
is obsolete||

--- Comment #6 from David Bourgault  ---
Created attachment 67881
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67881=edit
Bug 17983 - Enabled the use of minutes loan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

David Bourgault  changed:

   What|Removed |Added

  Attachment #59523|0   |1
is obsolete||

--- Comment #7 from David Bourgault  ---
Created attachment 67882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67882=edit
Bug 17983 - Tests for minutes loan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

David Bourgault  changed:

   What|Removed |Added

  Attachment #59521|0   |1
is obsolete||

--- Comment #5 from David Bourgault  ---
Created attachment 67880
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67880=edit
Bug 17983 - Add Minutes math to DiscreteCalendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18961] Datatable column filters of style 'select' should do an exact match

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18961

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

David Bourgault  changed:

   What|Removed |Added

   Assignee|mehdi.ham...@inlibro.com|david.bourga...@inlibro.com
 CC||david.bourga...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

2017-10-10 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

--- Comment #97 from David Bourgault  ---
Created attachment 67879
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67879=edit
Bug 17015 - Fix QA tools criticism

Adds POD to Koha/DiscreteCalendar.pm
Fixes spelling errors/bad pratices in various files.

QA tools now passes all green with the exception of
Koha::Schema::Result::DiscreteCalendar. I'm not sure what to do here, this file
did not exist before, and is (as far as I understand) generated automatically.
Any ideas?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   >