[Koha-bugs] [Bug 19456] New: Some pages title tag contains html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456 Bug ID: 19456 Summary: Some pages title tag contains html Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com This comes from patron-title.inc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Holds history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 --- Comment #21 from Josef Moravec--- (In reply to Owen Leonard from comment #20) > (In reply to Josef Moravec from comment #19) > > Hm, I don't have html in title tag... > > Ah... It's because I have a salutation defined for this patron. > > Holds history for Mr Owen > Leonard You are right, but is problem on more pages toot - circulation.pl, readingrec.pl, and so on... I think it's out of the scope of this enhancement... we need to fix it generally... I'll create new bug report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19440] XISBN tests should skip if XISBN returns overlimit error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19440 Jonathan Druartchanged: What|Removed |Added CC||fridolin.som...@biblibre.co ||m, ||katrin.fisc...@bsz-bw.de, ||m...@kohaaloha.com --- Comment #5 from Jonathan Druart --- RMaints, please backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules ' fine days = 0'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 David Bourgaultchanged: What|Removed |Added Status|Failed QA |In Discussion CC||david.bourga...@inlibro.com --- Comment #21 from David Bourgault --- Hi Katrin, I can still reproduce the problem on my end... Maybe this more detailed test plan can help : 0) Create a circulation rules under Koha > Admin > Circulation and fine rules with the value "0" for "Suspension days" (this maps to finedays in the database) 1) Select a test patron with the corresponding patron category. 2) Checkout an item (with the item_type corresponding to the rule set in step #0)for this patron, setting a due date in the past. 3) Manually set an indefinite restriction on this user 4) Check-in the item. 5) There should be a warning reminding that the user is debarred/restricted, but it is not there. If finedays is > 0, the reminder (or the new suspension) appears. If the item is not overdue, the reminder appears. If the item is overdue AND finedays is 0, the reminder does not appear. To answer your questions : A) You can restrict the user before or after checking out, this does not affect the result in my testing (but you will need to override the restriction). B) You might manually restrict users for different reasons, regardless of your circulation rules. This bug is only about a missing warning, not a missing suspension. The issue happens because of a "else if" which does not make sense if finedays is set to 0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #17 from Blou--- Hi Jen, I'm curious, those things (calendar...) are put in with Bug 17015. You've applied it first (I presume), have you tested it before applying 17983? That could help us see where the issue is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #76 from Kyle M Hall--- Created attachment 68039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68039=edit Bug 12768: Add missing IGNORE clauses -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #78 from Kyle M Hall--- Created attachment 68041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68041=edit Bug 12768: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #74 from Kyle M Hall--- Created attachment 68037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68037=edit Bug 12768 - Fix up unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #79 from Kyle M Hall--- Created attachment 68042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68042=edit Bug 12768 - Fix up unit tests a bit more -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #77 from Kyle M Hall--- Created attachment 68040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68040=edit Bug 12768: Fix YAML syntax in circulation.pref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #75 from Kyle M Hall--- Created attachment 68038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68038=edit Bug 12768 - Revert changes to getcharges -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Kyle M Hallchanged: What|Removed |Added Attachment #67891|0 |1 is obsolete|| Attachment #67892|0 |1 is obsolete|| Attachment #67893|0 |1 is obsolete|| Attachment #67894|0 |1 is obsolete|| Attachment #67895|0 |1 is obsolete|| Attachment #67896|0 |1 is obsolete|| Attachment #67897|0 |1 is obsolete|| --- Comment #72 from Kyle M Hall --- Created attachment 68035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68035=edit Bug 12768 - DB changes Signed-off-by: Eivin Giske Skaaren Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 --- Comment #73 from Kyle M Hall--- Created attachment 68036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68036=edit Bug 12768 - Replacement cost and processing fee management Signed-off-by: Eivin Giske Skaaren Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10748] Add option to block return of lost items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 --- Comment #3 from Jonathan Druart--- Created attachment 68034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68034=edit Bug 10748: Add the ability to block return of lost items Mimicking what does BlockReturnOfWithdrawnItems we can easily add a new syspref to block return of lost items. This patch adds BlockReturnOfLostItems, if set to 'Block' a item marked as lost cannot be checked in. Test plan: 1/ Set BlockReturnOfLostItems to 'Do not block' 2/ Check an item out to a patron 3/ Edit the item and mark it as lost (*) 4/ Check the item in => The item is checked in 5/ Edit the item and remove the lost status 6/ Check the item out again 7/ Edit the item and mark it as lost (*) 8/ Check the item in => The item is not checked in (*) There are 2 ways to mark an item lost: - From the item list view (/catalogue/moredetail.pl?biblionumber=42) If you set the lost status from this form, the issue will be returned Maybe this should be optional (?) - From the edit items form (/cataloguing/additem.pl?biblionumber=42) It is the form you must use to not mark the issue returned. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10748] Add option to block return of lost items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15378] Remove 'lost' items from course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15378 --- Comment #3 from Jonathan Druart--- Created attachment 68033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68033=edit Bug 15378: Allow removal of lost items from course reserves It seems that this restriction is not necessary, it should be possible to remove lost items from course reserves. Test plan: Create a course and add reserve with a lost item => Without this patch the "Remove" button is disabled and the item cannot be removed from the course => With this patch applied the button is enable and the item can be removed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Keywords||rel_17_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #142 from Kyle M Hall--- Created attachment 68032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68032=edit Bug 14826 [QA Followup] - Make db update idempotent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #141 from Kyle M Hall--- Created attachment 68031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68031=edit Bug 14826 [QA Followup] - Correct number of tests run following rebase -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #138 from Kyle M Hall--- Created attachment 68028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68028=edit Bug 14826: (QA followup) Only use plural modules in other modules Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #140 from Kyle M Hall--- Created attachment 68030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68030=edit Bug 14826: (QA followup) POD fixes This patch just fixes POD. There are still some false positives with the QA scripts. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #139 from Kyle M Hall--- Created attachment 68029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68029=edit Bug 14826: Add account offset type table Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #136 from Kyle M Hall--- Created attachment 68026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68026=edit Bug 14826: Add unit tests for _FixAccountForLostAndReturned and _FixOverduesOnReturn Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #137 from Kyle M Hall--- Created attachment 68027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68027=edit Bug 14826: (QA followup) Fix minor issues with unit tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #135 from Kyle M Hall--- Created attachment 68025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68025=edit Bug 14826: Add offset for rental fees Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #134 from Kyle M Hall--- Created attachment 68024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68024=edit Bug 14826: Add new offset table schema file Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #133 from Kyle M Hall--- Created attachment 68023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68023=edit Bug 14826: Remove old offset table schema file Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #132 from Kyle M Hall--- Created attachment 68022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68022=edit Bug 14826: Remove old offset table schema file Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #131 from Kyle M Hall--- Created attachment 68021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68021=edit Bug 14826; Unit Tests Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #129 from Kyle M Hall--- Created attachment 68019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68019=edit Bug 14826: Add Koha::Account::Offset(s) modules Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hallchanged: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hallchanged: What|Removed |Added Attachment #67936|0 |1 is obsolete|| Attachment #67937|0 |1 is obsolete|| Attachment #67938|0 |1 is obsolete|| Attachment #67939|0 |1 is obsolete|| Attachment #67940|0 |1 is obsolete|| Attachment #67942|0 |1 is obsolete|| Attachment #67943|0 |1 is obsolete|| Attachment #67944|0 |1 is obsolete|| Attachment #67945|0 |1 is obsolete|| Attachment #67946|0 |1 is obsolete|| Attachment #67947|0 |1 is obsolete|| Attachment #67948|0 |1 is obsolete|| Attachment #67949|0 |1 is obsolete|| --- Comment #128 from Kyle M Hall --- Created attachment 68018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68018=edit Bug 14826: Update database Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 --- Comment #130 from Kyle M Hall--- Created attachment 68020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68020=edit Bug 14826: Resurrect account offsets table The account offsets table should be used to track increments and decrements of fines via payments and credits, as well as fine accruals. It should be able to match fees to payments and visa versa, so we can know which fee was paid by a given payment, and which payments applied to a given fee. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Note the table accountoffsets has been renamed to account_offsets 4) Ensure fine generation creates offsets 5) Ensure creating a manual invoice creates an offset 6) Ensure a lost item charge creates an offset 7) Ensure Reverse Payment creates an offset 8) Ensure a payment creates an offset 9) Ensure a payment for multiple fees creates an offset for each 10) Ensure writeoffs create offsets Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #16 from J Schmidt--- Created attachment 68017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68017=edit Bug 17983 part 2 screen capture, collapsed checkout options This goes with the last attachment. Screen shot for 17983 to show collapsed checkout options at the point of checkout. No calendar window triggered. I almost went into staff client JS to look for anything there FYI. jen. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #15 from J Schmidt--- Created attachment 68016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68016=edit no calendar option at point of checkout Screen shot for 17983. Not seeing a calendar option via JS at the point of Koha checkout. Sandbox 3 ByWater... to test bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hallchanged: What|Removed |Added Attachment #67941|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983 --- Comment #14 from J Schmidt--- Hello, Trying this again...cleared browser cache. --Sandbox3 from ByWater. --Login and set my library to be Betatown. --Go to Koha Admin > IUtem Types. Create a new item type for EQUIPMENT with EQUIP code. --Koha Admin > Circ and fine rules for Betatown. --Created a new loan rule for Library Betatown for all patrons using new EQUIP item type. Current checkouts allowed is 10; Current on-site checkouts allow is 10. Loan period is 60 minutes. No hard due date. Fine amount is 1.00 fine charging interval is 60 minutes. Charged at the END of interval. Fine grace period is 0. Overdue fines cap is $10.00. Renewaks allowed is 0. No automatic renewwal or holds... Saved loan rule. --Search the catalog for a record. Not seeing any records readily. I make a new brief bib on a default framework (filling in required fields like 942, 005, 040, etc.) and item record (952$a, b is betatown, item type is EQUIP, filled in replacement cost, date acquired...). Add item. --item barcode is 319209 --Go to test patron, 201016 to check out above item (Equip)... --Again no calendar to be found... See attached image. --Really do not think it's updated. Hmmm. jen.s -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hallchanged: What|Removed |Added Blocks|12768 | Text to go in the||The account offsets table release notes||allows libraries to know ||the entire history of fees ||and payments in Koha. ||Previously there was no way ||to directly connect fees ||and payments. The addition ||of the account offsets ||table allows you to know ||which fees paid which fines ||visa versa. This data will ||be accessible via reports ||and later via the staff ||intranet ( via Bug 2696 ). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 [Bug 12768] Replacement cost and processing fee management -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Kyle M Hallchanged: What|Removed |Added Depends on|14826 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 [Bug 14826] Resurrect account offsets table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12768] Replacement cost and processing fee management
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 Kyle M Hallchanged: What|Removed |Added Depends on||14826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 [Bug 14826] Resurrect account offsets table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14826] Resurrect account offsets table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826 Kyle M Hallchanged: What|Removed |Added Blocks||12768 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768 [Bug 12768] Replacement cost and processing fee management -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11446] Authority not searching full corporate name with and (&) symbol
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11446 --- Comment #3 from Marjorie Barry-Vila--- Still valid in 16.05 with uniform title too. Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19016] Add a script to fix corrupted data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016 --- Comment #15 from Tomás Cohen Arazi--- Created attachment 68015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68015=edit Bug 19016: Trigger reindex on fixing biblios Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19455] Circulation/SwitchOnSiteCheckouts.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #2 from Jonathan Druart --- Pushed to master for 17.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19455] Circulation/SwitchOnSiteCheckouts.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455 Jonathan Druartchanged: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19455] Circulation/SwitchOnSiteCheckouts.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19455] Circulation/SwitchOnSiteCheckouts.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455 Jonathan Druartchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19455] Circulation/SwitchOnSiteCheckouts.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455 --- Comment #1 from Jonathan Druart--- Created attachment 68014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68014=edit Bug 19455: Prevent SwitchOnSiteCheckouts.t to fail randomly If categorycode is 'X', the test will fail Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19455] Circulation/SwitchOnSiteCheckouts.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455 Jonathan Druartchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19423, ||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19403 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19403] Again and again, Circulation.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19403 Jonathan Druartchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19455 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19423] DecreaseLoanHighHolds.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19423 Jonathan Druartchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19455 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19455] New: Circulation/SwitchOnSiteCheckouts.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19455 Bug ID: 19455 Summary: Circulation/SwitchOnSiteCheckouts.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org # Failed test 'Do not renew on-site checkouts' # at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 103. # got: undef # expected: '1' # Failed test 'If SwitchOnSiteCheckouts, switch the on-site checkout' # at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 107. # got: undef # expected: '1' # Failed test 'Specific case 1 - Switch is allowed' # at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 131. # got: undef # expected: '1' # Failed test 'Not a specific case, $delta should not be incremented' # at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 146. # got: undef # expected: 'TOO_MANY_CHECKOUTS' # Failed test 'Specific case 2 - Switch is allowed' # at t/db_dependent/Circulation/SwitchOnSiteCheckouts.t line 159. # got: undef # expected: '1' # Looks like you failed 5 tests of 10. [19:29:48] t/db_dependent/Circulation/SwitchOnSiteCheckouts.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #91 from Julian Maurice --- Patches rebased on master, some patches (the signed-off ones) squashed with the main patch for simplicity. Testers, be sure to read the added "Important note for testers" after the test plan in comment 86 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #68007|0 |1 is obsolete|| --- Comment #90 from Julian Maurice --- Created attachment 68013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68013=edit Bug 12802: Make tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #68006|0 |1 is obsolete|| --- Comment #89 from Julian Maurice --- Created attachment 68012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68012=edit Bug 12802: Update all circulation alerts, not only the first one Since SendCirculationAlert can generate multiple entries in message_queue, it should update them all if pending messages already exist -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #68005|0 |1 is obsolete|| --- Comment #88 from Julian Maurice --- Created attachment 68011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68011=edit Bug 12802: Fix tests in Reserves.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #68004|0 |1 is obsolete|| --- Comment #87 from Julian Maurice --- Created attachment 68010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68010=edit Bug 12802: Fix tests in Letters.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #68003|0 |1 is obsolete|| --- Comment #86 from Julian Maurice --- Created attachment 68009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68009=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Important note for testers: Pending messages must be removed each time you change the value of AutoEmailPrimaryAddress. When there are already existing pending messages for a borrower, Koha tries to update them rather than enqueuing new ones, but it will not update the recipient's email address, nor add/remove messages depending on the new value of AutoEmailPrimaryAddress; not sure if this is a bug or not. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #68002|0 |1 is obsolete|| --- Comment #85 from Julian Maurice --- Created attachment 68008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68008=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19452] The -truncate option in borrowers-force-messaging-defaults.pl should not remove category preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452 Marcel de Rooychanged: What|Removed |Added Status|Needs Signoff |BLOCKED --- Comment #2 from Marcel de Rooy --- Wondering if having this reset option actually makes sense. Or can we just remove it ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #66938|0 |1 is obsolete|| --- Comment #84 from Julian Maurice --- Comment on attachment 66938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66938 Bug 12802: Fix QA script issues Patch squashed with the main one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #66937|0 |1 is obsolete|| --- Comment #83 from Julian Maurice --- Comment on attachment 66937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66937 Bug 12802: Fix if AutoEmailOpacUser is enabled Patch squashed with the main one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #66936|0 |1 is obsolete|| --- Comment #82 from Julian Maurice --- Comment on attachment 66936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66936 Bug 12802: FIX use the first valid email address if noemail is needed Patch squashed with the main one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454 Marcel de Rooychanged: What|Removed |Added Summary|Script |Script |borrowers-force-messaging-d |borrowers-force-messaging-d |efaults.pl should filter on |efaults.pl should be able |patron category |to filter on patron ||category -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #66940|0 |1 is obsolete|| --- Comment #79 from Julian Maurice --- Created attachment 68005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68005=edit Bug 12802: Fix tests in Reserves.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #80 from Julian Maurice--- Created attachment 68006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68006=edit Bug 12802: Update all circulation alerts, not only the first one Since SendCirculationAlert can generate multiple entries in message_queue, it should update them all if pending messages already exist -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #66935|0 |1 is obsolete|| --- Comment #77 from Julian Maurice --- Created attachment 68003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68003=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #66939|0 |1 is obsolete|| --- Comment #78 from Julian Maurice --- Created attachment 68004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68004=edit Bug 12802: Fix tests in Letters.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #81 from Julian Maurice--- Created attachment 68007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68007=edit Bug 12802: Make tests pass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Send notices using several email addresses
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Mauricechanged: What|Removed |Added Attachment #66934|0 |1 is obsolete|| --- Comment #76 from Julian Maurice --- Created attachment 68002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68002=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should filter on patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454 Marcel de Rooychanged: What|Removed |Added Summary|working title |Script ||borrowers-force-messaging-d ||efaults.pl should filter on ||patron category -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Owen Leonardchanged: What|Removed |Added Attachment #67913|0 |1 is obsolete|| --- Comment #38 from Owen Leonard --- Created attachment 68001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68001=edit Bug 14715: [FOLLOW-UP] Fixing qa-tools issues and merge conflicts Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Owen Leonardchanged: What|Removed |Added Attachment #67912|0 |1 is obsolete|| --- Comment #37 from Owen Leonard --- Created attachment 68000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68000=edit Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17282] Ability to create charts for SQL reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17282 Magnus Engerchanged: What|Removed |Added CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18923] Resolve a warn in Biblio::GetCOinSBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18923 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18923] Resolve a warn in Biblio::GetCOinSBiblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18923 Owen Leonardchanged: What|Removed |Added Attachment #67835|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 67999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67999=edit Bug 18923: Warning in Biblio::GetCOinSBiblio Use of uninitialized value in concatenation (.) or string at C4/Biblio.pm line 1456. Note: In current master this is now line 1370 (Oct 9, 2017). Test plan: Enable COinSinOPACResults. Select a record with leader pos6==a and pos7==a. This triggers genre to be journalArticle and titletype to be a. Without this patch, do an opac search that includes this record. Check the log. You should see the warning. Apply this patch, search again and check the log. The warning should not be repeated again. Signed-off-by: Marcel de Rooy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19452] The -truncate option in borrowers-force-messaging-defaults.pl should not remove category preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452 --- Comment #1 from Marcel de Rooy--- Created attachment 67998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67998=edit Bug 19452: Replace the truncate option by reset_all The truncate option is not really useful. Its result is probably not what most users of this script expect or need. It truncates both tables borrower_message_preferences and borrower_message_transport_preferences. This (unfortunately) includes deleting messaging preferences for patron categories. After that, adding preferences again will not add categories again, but only borrower preferences which are all disabled. Furthermore, we do not need to disable the foreign key check. Neither do we actually need to truncate, deleting records seems sufficient. Also deleting transport preferences is not needed, since it will be done by a cascade from messaging preferences. This patch replaces -truncate by -reset_all: It will only delete records from borrower_message_preferences directly, and skip patron categories. This allows you to reset all borrower prefs to the untouched prefs from the patron category. In a follow-up report I will propose to add a category parameter in order to allow resetting prefs for specific categories. Test plan: [1] Select a patron category (say ST) and change days_in_advance to x. [2] Select a ST patron and set days_advance to y in his msg prefs. [3] Run borrowers-force-messaging-defaults.pl -doit -reset_all [4] Verify that the patron has been reset to the default prefs (incl. value x in days_in_advance). [5] Verify that the patron category prefs are still intact. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19452] The -truncate option in borrowers-force-messaging-defaults.pl should not remove category preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452 Marcel de Rooychanged: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18197] Make borrowers-force-messaging-defaults a bit more standard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18197 Marcel de Rooychanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19454 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19454] working title
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454 Marcel de Rooychanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18197 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19452] The -truncate option in borrowers-force-messaging-defaults.pl should not remove category preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452 Marcel de Rooychanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18197 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18197] Make borrowers-force-messaging-defaults a bit more standard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18197 Marcel de Rooychanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19452 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18197] Make borrowers-force-messaging-defaults a bit more standard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18197 --- Comment #3 from Marcel de Rooy--- Bug 19452 addresses the side-effects of -truncate. Bug 19454 will add a filter on patron category. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18197] Make borrowers-force-messaging-defaults a bit more standard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18197 --- Comment #2 from Marcel de Rooy--- empty_only became no_overwrite in the meantime -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19452] The -truncate option in borrowers-force-messaging-defaults.pl should not remove category preferences
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452 Marcel de Rooychanged: What|Removed |Added Summary|Fix -truncate option in |The -truncate option in |borrowers-force-messaging-d |borrowers-force-messaging-d |efaults.pl (replacing it by |efaults.pl should not |-reset_all) |remove category preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 Fridolin SOMERSchanged: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #34 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. UT fails without correction and success with it. Thanks a lot Josef. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19452] Fix -truncate option in borrowers-force-messaging-defaults.pl (replacing it by -reset_all)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452 Marcel de Rooychanged: What|Removed |Added Summary|Truncate is too drastic in |Fix -truncate option in |borrowers-force-messaging-d |borrowers-force-messaging-d |efaults.pl |efaults.pl (replacing it by ||-reset_all) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19453] Client side validation broken for "Fund" select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 Owen Leonardchanged: What|Removed |Added Attachment #67996|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 67997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67997=edit Incorrect jQuery selector for fund drop down validation Steps to reproduce: 1. Create a new basket 2. Choose "Add to masket" 3. Choose "From a staged file" 4. Select a file 5. Save without selecting a fund Expected results: A validation error should be shown, and form submit halted. Actual results: No validation error is shown and form submits. https://bugs.koha-community.org/show_bug.cgi?id=19453 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19453] Client side validation broken for "Fund" select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19453] Client side validation broken for "Fund" select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 Owen Leonardchanged: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |glask...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4319] waiting items cannot be reserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Koha Team Lyon 3changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #37 from Koha Team Lyon 3 --- Hello, I found the same problem as in comment 31 while testing today : "When items is in transit, "place hold" doesn't appears on the details page" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Holds history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 --- Comment #20 from Owen Leonard--- (In reply to Josef Moravec from comment #19) > Hm, I don't have html in title tag... Ah... It's because I have a salutation defined for this patron. Holds history for Mr Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 --- Comment #33 from Josef Moravec--- (In reply to Fridolin SOMERS from comment #28) > Patch "Holds marked as problems being seen as expired ones and deleted > wrongly" does not apply easily to 17.05.x. > Please provide a rebased patch. I rebased whole patchset, qa tools passes, test passes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19443] Error while attempting to duplicate a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443 Alex Arnaudchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19453] Client side validation broken for "Fund" select
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 --- Comment #1 from David Gustafsson--- Created attachment 67996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67996=edit Incorrect jQuery selector for fund drop down validation Steps to reproduce: 1. Create a new basket 2. Choose "Add to masket" 3. Choose "From a staged file" 4. Select a file 5. Save without selecting a fund Expected results: A validation error should be shown, and form submit halted. Actual results: No validation error is shown and form submits. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 --- Comment #31 from Josef Moravec--- Created attachment 67994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67994=edit [17.05] Bug 19260: [QA Follow-up] Remove obsolete $dbh The variable is no longer used. Removed a few empty lines on the way. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 --- Comment #32 from Josef Moravec--- Created attachment 67995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67995=edit [17.05] Bug 19260: (followup) Fix CancelReserves.t test Test plan: Run t/db_dependent/Holds/CancelReserves.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19260] Reservations / holds marked as problems being seen as expired ones and deleted wrongly.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19260 --- Comment #30 from Josef Moravec--- Created attachment 67993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67993=edit [17.05] Bug 19260: Holds marked as problems being seen as expired ones and deleted wrongly Test plan: 0) Apply just the first patch - the one with test 1) Run t/db_dependent/Reserves.t - test for CancelExpiredReserves should fail 2) Apply the second patch 3) t/db_dependent/Reserves.t should pass now Followed test plan, patch worked as described. Passes QA test tool Signed-off-by: Alex Buckley Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/