date:20171016

[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Hugh Rundle  changed:

   What|Removed |Added

 CC||hu...@brimbank.vic.gov.au

--- Comment #4 from Hugh Rundle  ---
Nick have you made any further progress on this? This bug is definitely
confusing and we'd love it resolved at my library.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #58 from M. Tompsett  ---
Okay, tested. It generally works. However, the test bothers me. The preference
is not mocked; it is used directly. This can be bad if the test is interrupted
in the middle of the test with the value changed. And the test is loud,
generating noise when the prove is run.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19468] Can't create basket in acquisitions

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19468

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #2 from Katrin Fischer  ---
Was logged in with superlibrarian, closing.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #33 from Katrin Fischer  ---
Jon, did you mean to sign off? Switching status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||katrin.fisc...@bsz-bw.de

--- Comment #20 from Katrin Fischer  ---
Hi Jon, in this case please set 'Patch doesn't apply' as status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

--- Comment #93 from Katrin Fischer  ---
Hi Ehsan, please open a new bug report or ask on the mailing list. Bugs with
patches already released should not be reopened, but you can link bugs together
using 'depends on'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19290] Add the ability to filter a result list on staff client

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290

--- Comment #3 from Jonathan Druart  
---
Created attachment 68193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68193=edit
Bug 19290: Browse selected bibliographic records - Staff interface

This patch adds the same feature as bug 10858 for the OPAC interface:
after a search, librarians will be able to browse selected results.
The results can be selected from several pages.
By extension it is possible to add results from several pages to a list
or the cart.

When at least one result is selected, a new "Browse selected records" button
becomes usable and change the behaviour of the existing browser.

The whole feature can be turned off with the pref BrowseResultSelection.

Test plan:
- Launch a search (on the staff interface)
- Check some biblios
- Go on another page
- Check some biblios
- Come back to a page you already check results and confirm that they are
still checked
- Click on the "Browse selected records" button
- Check that you are able to browse results you had checked.

You can also:
- add them to the cart
- add them to a list

QA note: the browsers at the OPAC and the one at the staff interface are
completely different
That's why the code is not mimicking what has been done on bug 10858.
The behaviour must stay the same anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19290] Add the ability to filter a result list on staff client

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library' s circ rules

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520

Jesse Weaver  changed:

   What|Removed |Added

 Blocks||15522


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
[Bug 15522] New interface for revamped circulation rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Jesse Weaver  changed:

   What|Removed |Added

 Depends on||15520


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520
[Bug 15520] Add more granular permission for only editing own library's circ
rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Jesse Weaver  changed:

   What|Removed |Added

 Depends on|15524   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524
[Bug 15524] Set limit on maximum possible holds per patron by category
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15524] Set limit on maximum possible holds per patron by category

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15524

Jesse Weaver  changed:

   What|Removed |Added

 Blocks|15522   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
[Bug 15522] New interface for revamped circulation rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15395] Allow correct handling of plural translation

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395

Jesse Weaver  changed:

   What|Removed |Added

 Blocks||15522


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
[Bug 15522] New interface for revamped circulation rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

Jesse Weaver  changed:

   What|Removed |Added

 Blocks||15522


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522
[Bug 15522] New interface for revamped circulation rules
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Jesse Weaver  changed:

   What|Removed |Added

 CC||pianohac...@gmail.com
 Depends on||15395, 18936


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395
[Bug 15395] Allow correct handling of plural translation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936
[Bug 18936] Convert issuingrules fields to circulation_rules
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394

--- Comment #14 from Alex Buckley  ---
Thanks David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

--- Comment #13 from David Bourgault  ---
Combined both patches into one rebase patch.

Removed unrelated SQL manipulations (they were leftovers from testing on Bug
19422)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

David Bourgault  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11976] show issue date instead of received date for serials in opac

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976

David Bourgault  changed:

   What|Removed |Added

  Attachment #67615|0   |1
is obsolete||
  Attachment #67964|0   |1
is obsolete||

--- Comment #12 from David Bourgault  ---
Created attachment 68192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68192=edit
Bug 11976 - Choose date to display

Allows choosing between publication date or receival date (or both) for serials
information in the OPAC.

Test plan :
0) If you have no serials :
a) Create a subscription
b) Receive the item, making sure to have a different publication and
receival date
1) Visit the OPAC details page for the item you've created
2) Without the patch only the receival date will be displayed
3) Apply patch
4) Run installer/data/mysql/updatedatabase.pl
5) With the patch the publication date and the receival date will be displayed.
This can be changed to either (or both) with the
'OPACSerialDisplayPublishedDate' system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394

--- Comment #13 from David Bourgault  ---
oops, I forgot to add the signoff line.

Patch works as expected. QA tool did say something about a missing blank line
before =cut in Koha/Patrons.pm, but I didn't want to fail QA patch for this so
I took the liberty of adding the missing line. Hope that's OK.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394

David Bourgault  changed:

   What|Removed |Added

  Attachment #68188|0   |1
is obsolete||

--- Comment #11 from David Bourgault  ---
Created attachment 68190
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68190=edit
Bug 19394 - Ability to skip the onboarding tool implemented

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394

David Bourgault  changed:

   What|Removed |Added

  Attachment #68189|0   |1
is obsolete||

--- Comment #12 from David Bourgault  ---
Created attachment 68191
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68191=edit
Bug 19384 - Ability to skip the onboarding tool and then redirect the next user
to it

To allow IT staff and support vendors to quickly install Koha for
clients this patch allows these people to skip the onboarding tool and
go straight from the web installer to authenticating to the intranet.

As well as allowing these users to install Koha quickly, the other
purpose of this patch is that these people are unlikely to know what the
library wants set as the library, patron category, administrator patron
credentials, item type and circulation rule and so it is better to leave
that to a librarian to fill out.

The next user to log in (they will have to use the Koha db administrator
credentials) after Koha has been installed (and only if the onboarding
tool was skipped) is then redirected to
login to the web installer to go through the onboarding tool.

Test plan:
1. Drop and recreate your Koha database

2. Restart memcached

3. Go through the web installer and notice that on the page which says
congradulations that you have successfully installed Koha there is a
link to click to load the onboarding tool otherwise if you wait 10
seconds you are redirected anyway.

4. Apply patch

5. Repeat steps 1 and 2

6. Go through the web installer without installing sample patrons and
notice on the same page described in step 3 there are now 2 links: one
to go to the onboarding tool and one to skip the onboarding process.
Also notice that if you wait 10 seconds you are not redirected to the
onboarding tool.

7. Click the skip link

8. Notice the intranet login page appears, login using the Koha db
adminstrator credentials and notice that the mainpage appears.

9. Now logout and login again and notice that you are redirected to the
Web installer login page, login and notice that the onboarding tool is
displayed

10. Repeat steps 1 and 2 and this time install sample data including sample
patrons

11. On the page described on step 3 click the skip link.

12. Notice that the intranet login page appears, login and then logout

13. Try logging in again and notice that you are redirected to the web
installer login page and after authenticating the onboarding tool is
displayed.

14. Repeat steps 1 and 2 go through the web installer and on the page
described in step 3 click the onboarding link and notice that a page
from the onboarding process is displayed.

15. Aftergoing through the onboarding tool login as db administrator and
then logout and login again and notice that you are not redirected to
the onboarding tool because you have already completed it

Sponsored-By: Catalyst IT

https://bugs.koha-community.org/show_bug.cgi?id=19394

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394

David Bourgault  changed:

   What|Removed |Added

  Attachment #68117|0   |1
is obsolete||

--- Comment #10 from David Bourgault  ---
Created attachment 68189
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68189=edit
Bug 19384 - Ability to skip the onboarding tool and then redirect the next user
to it

To allow IT staff and support vendors to quickly install Koha for
clients this patch allows these people to skip the onboarding tool and
go straight from the web installer to authenticating to the intranet.

As well as allowing these users to install Koha quickly, the other
purpose of this patch is that these people are unlikely to know what the
library wants set as the library, patron category, administrator patron
credentials, item type and circulation rule and so it is better to leave
that to a librarian to fill out.

The next user to log in (they will have to use the Koha db administrator
credentials) after Koha has been installed (and only if the onboarding
tool was skipped) is then redirected to
login to the web installer to go through the onboarding tool.

Test plan:
1. Drop and recreate your Koha database

2. Restart memcached

3. Go through the web installer and notice that on the page which says
congradulations that you have successfully installed Koha there is a
link to click to load the onboarding tool otherwise if you wait 10
seconds you are redirected anyway.

4. Apply patch

5. Repeat steps 1 and 2

6. Go through the web installer without installing sample patrons and
notice on the same page described in step 3 there are now 2 links: one
to go to the onboarding tool and one to skip the onboarding process.
Also notice that if you wait 10 seconds you are not redirected to the
onboarding tool.

7. Click the skip link

8. Notice the intranet login page appears, login using the Koha db
adminstrator credentials and notice that the mainpage appears.

9. Now logout and login again and notice that you are redirected to the
Web installer login page, login and notice that the onboarding tool is
displayed

10. Repeat steps 1 and 2 and this time install sample data including sample
patrons

11. On the page described on step 3 click the skip link.

12. Notice that the intranet login page appears, login and then logout

13. Try logging in again and notice that you are redirected to the web
installer login page and after authenticating the onboarding tool is
displayed.

14. Repeat steps 1 and 2 go through the web installer and on the page
described in step 3 click the onboarding link and notice that a page
from the onboarding process is displayed.

15. Aftergoing through the onboarding tool login as db administrator and
then logout and login again and notice that you are not redirected to
the onboarding tool because you have already completed it

Sponsored-By: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394

David Bourgault  changed:

   What|Removed |Added

  Attachment #68116|0   |1
is obsolete||

--- Comment #9 from David Bourgault  ---
Created attachment 68188
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68188=edit
Bug 19394 - Ability to skip the onboarding tool implemented

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the ‘Catalog details’ form in the acquisition baskets

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=12743

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19289

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13287] Add a system preference to define the number of days used in purge_suggestions.pl

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13287

Jon Knight  changed:

   What|Removed |Added

  Attachment #60570|0   |1
is obsolete||

--- Comment #32 from Jon Knight  ---
Created attachment 68187
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68187=edit
Bug 13287: QA Follow up

Added missing upgrade SQL system preference.
Corrected system preference screen message
Fixes on purge_suggestions.pl
- perlcritic friendlier
- address $PERL5LIB comment by using $PROGRAM_NAME (comment #10)
- used STDERR (comment #10)
- perltidy

TEST PLAN
-
$ ./installer/data/mysql/updatedatabase.pl
-- should run upgrade and generate new systempreference in table
$ ./misc/cronjobs/purge_suggestions.pl --help
-- should give help with a real path used instead of $PERL5LIB.
$ ./misc/cronjobs/purge_suggestions.pl -days -1
-- should give error message as expected
$ ./misc/cronjobs/purge_suggestions.pl -days 0
-- should give error message as expected

Go to OPAC system preferences tab and check the
PurgeSuggestionsOlderThan system preference
-- message should be as expected (see comment #9)

run koha qa test tools
-- all should pass

Signed-off-by: Marc Véron 
Signed-off-by: Jon Knight 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267

Jon Knight  changed:

   What|Removed |Added

 CC||j.p.kni...@lboro.ac.uk

--- Comment #19 from Jon Knight  ---
No longer appears to apply cleanly to master or 16.11.x heads with a git bz
apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18961] Datatable column filters of style 'select' should do an exact match

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18961

--- Comment #11 from Marc Véron  ---
(In reply to Jonathan Druart from comment #10)
> I suggest to push my patch and assume that only these 5 columns are linked
> to a AV. It's not perfect but I do not think it worth the effort.

+1
Marc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #116 from Alex Sassmannshausen 
 ---
Created attachment 68186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68186=edit
Bug 7317: Add unit tests & fix, add comments to Illrequest.pm.

* Koha/Illrequest.pm: Add code commentary.
  (_backend_capability): We need to invoke our code ref.
* t/db_dependent/Illrequest/Config.t: Improve tests.
* t/db_dependent/Illrequestattributes.t: Improve tests.
* t/db_dependent/Illrequests.t: Improve tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #115 from Alex Sassmannshausen 
 ---
Created attachment 68185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68185=edit
Bug 7317: Remove obsolete files.

The tests files will be replaced with
t/db_dependent/Illrequests.t. Dummy backend files are now in their own
repository.

* Koha/Illrequest/Backend/Dummy/Base.pm: Delete.
* t/db_dependent/Illrequest.t: Delete.
* t/db_dependent/Illrequest/Dummy.t: Delete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #57 from M. Tompsett  ---
Trying to test acquisition change... having difficulties. I don't think it is a
code issue. BTW, Additional fields does look okay for a circulation Z39.50
search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19463] TestBuilder.t is failing randomly

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19463

--- Comment #3 from Jonathan Druart  
---
Violation of unique constraint in Category at
/kohadevbox/koha/t/lib/TestBuilder.pm line 240.

#   Failed test 'Testing Koha::Ratings'
#   at t/db_dependent/TestBuilder.t line 390.
#  got: ''
# expected: 'Koha::Rating'
# Looks like you failed 1 test of 70.

#   Failed test 'Test all classes'
#   at t/db_dependent/TestBuilder.t line 392.
# Looks like you failed 1 test of 6.

#   Failed test 'build_object() tests'
#   at t/db_dependent/TestBuilder.t line 393.
# Looks like you failed 1 test of 13.
[15:07:54] t/db_dependent/TestBuilder.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #56 from M. Tompsett  ---
Comment on attachment 67314
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67314
Bug 12747 - Corrections on QA feedback

Review of attachment 67314:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12747=67314)
-

::: C4/Breeding.pm
@@ -224,5 @@
> -@servers = ();
> -foreach my $id (@id) {
> -push @servers, {id => $id};
> -}
> -

Why was this removed? Did you add it before?

@@ +344,5 @@
> +
> +return $row;
> +}
> +
> +sub _add_custom_field_rowdata

Nice extraction.

::: installer/data/mysql/sysprefs.sql
@@ +9,2 @@
>  ('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC 
> field/subfields are displayed in -Additional field- column in the result of a 
> search Z3950', 'Free'),
> +('AddressFormat','us','us|de|fr','Choose format to display postal 
> addresses', 'Choice'),

Intermediate patches dealing with rebases makes this look like a mistake.
Squashing is frequently a good idea where possible.

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
@@ +133,4 @@
>  Author
>  ISBN
>  LCCN
> +[% IF Koha.Preference('AdditionalFieldsInZ3950ResultSearch') != '' %]

Length, != ''... okay, this is better.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

David Bourgault  changed:

   What|Removed |Added

   Assignee|philippe.blo...@inlibro.com |david.bourga...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #55 from M. Tompsett  ---
Comment on attachment 66589
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66589
Bug12747 - Small fix for add this field correctly in cataloging module

Review of attachment 66589:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12747=66589)
-

I don't see the point of this patch. If the issue was adding 000, then check
length. Less parameters is always better.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #54 from M. Tompsett  ---
Comment on attachment 66588
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66588
Bug12747 - Follow-up to QA

Review of attachment 66588:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12747=66588)
-

::: t/db_dependent/Breeding.t
@@ +195,5 @@
> +
> +sub test_add_rowdata {
> +
> + my $old_preference = 
> C4::Context->preference("AdditionalFieldsInZ3950ResultSearch");
> +C4::Context->set_preference("AdditionalFieldsInZ3950ResultSearch","");

It would be better to mock the preference, so that failure would not affect the
database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #53 from M. Tompsett  ---
Comment on attachment 66587
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66587
Bug 12747 - Add extra column in Z3950 search result

Review of attachment 66587:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12747=66587)
-

::: C4/Breeding.pm
@@ +362,4 @@
>  my @addnumberfields;
>  foreach (@addnumber_array) {
>  my $length = length($_);
>  my $adTag = substr($_, 0, 3);

If the field is:
100$a 245$a 700$a
Then why aren't you:
my @fields_to_add = split / /, $pref_addnumber;
And inside the the loop:
foreach my $field (@fields_to_add) {
my ($tag,$subtags) = split |\$|, $field;
You are making an assumption that the user won't type something bad like
20$a instead of 020$a.
Notice my use of $subtags, because that would be the 'abc' or whatever was set.
my @subtags = split //,$subtags; # I believe this splits each character out.
foreach my $subtag (@subtags) {
substr() calculations are just messy and slow.

@@ +385,5 @@
> +   my $subfields_text = $field->as_string();
> +   push(@addnumberfields, $_);
> +   $row->{$_} = $subfields_text;
> +   }
> +   }

And then all this logic could be optimized.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #10 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #8)
> The patch appears to break the list of checkouts in the patron account:
> 
> Error: Syntax error, unrecognized expression: ##issues-table

Indeed, I git grepped on **/*.tt but there was an occurrence in a .js file.
Thanks for the catch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #9 from Jonathan Druart  
---
Created attachment 68184
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68184=edit
Bug 9573: (follow-up) Lost items report - add KohaTable to itemlost

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19472] Add perl extension to borrowers-force-messaging-defaults

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #3 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add actives parameter to force_borrower_messaging_defaults script

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #20 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add actives parameter to force_borrower_messaging_defaults script

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

--- Comment #19 from Jonathan Druart  
---
Created attachment 68183
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68183=edit
Bug 13572: Patrons are still active if their expiry date is today

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19472] Add perl extension to borrowers-force-messaging-defaults

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472

--- Comment #2 from Jonathan Druart  
---
Created attachment 68182
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68182=edit
Bug 19472: Update SYNOPSIS with the correct script name

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #52 from M. Tompsett  ---
Comment on attachment 66586
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66586
Bug 12747 - Add extra column in Z3950 search

Review of attachment 66586:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12747=66586)
-

::: C4/Breeding.pm
@@ +365,5 @@
> +   my $fieldContent='';
> +   if ($length > 3){
> +   my $adSubfield;
> +   for (my $i=0; $i<$length-3; $i++){
> +  $adSubfield = substr($_, 3+$i, 1);

When you have nested loops, one should avoid $_ and be explicit (on line 359)
to improve readability and prevent accidental breakage later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15259] Formatting spine labels

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15259

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18920] Some config values are not saved in koha-install-log

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64956|0   |1
is obsolete||

--- Comment #3 from M. Tompsett  ---
Created attachment 68181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68181=edit
Bug 18920 Save DB_USE_TLS and FONT_DIR to install log

Configuration values should be included in the koha-install-log
so that when running Makefile.PL with the --prev-install-log option
values can be read from there and reapplied rather than prompting
the user on each subsequent run.
This adds FONT_DIR and DB_USE_TLS (and its dependent options) to
koha-install-log so that the set values will be written by make
during a make install or make upgrade

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18920] Some config values are not saved in koha-install-log

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18920] Some config values are not saved in koha-install-log

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett  ---
NOTE: Untestable in a SYNC_REPO Windows Dev Box, due to ::'s in the man pages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19243] Selenium test for testing the administration module functionality

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19243

--- Comment #15 from Jonathan Druart  
---
Alex, some remarks:
1. take a look at basic_workflow.t, there are some changes you did not take
into account (19337)
2. Tests must create the data they need and delete them. Here you are using the
FA framework and modify it. That means the tests will fail if executed twice.
3. The cleanup method is wrong, it should not be a method as the different
selenium test files will have different a cleanup.
4. t::lib::Selenium::pause_driver does not work as you would like?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17768] spinelabel.css should be user editable.

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17768

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19471] Show creation date in patron restrictions list

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19471

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19471] Show creation date in patron restrictions list

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19471

Owen Leonard  changed:

   What|Removed |Added

  Attachment #68174|0   |1
is obsolete||

--- Comment #2 from Owen Leonard  ---
Created attachment 68180
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68180=edit
Bug 19471: Show creation date in patron restrictions list

Test plan:
1. Go to the "Details" vertical tab of a patron.
2. Click the "Restriction" tab in the bottom and add a manual restriction.
3. Verify a creation date is visible.

4. Edit the same patron.
5. Under "Patron restrictions" verify the creation date of the listed
   restiction is visible.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19471] Show creation date in patron restrictions list

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19471

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |glask...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2500] Standing enhancement request for adding/ updating call number splitting algorithms in C4/Labels.pm

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12064] labels that don't use the splitter print zeros

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12064

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add actives parameter to force_borrower_messaging_defaults script

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Francois Charbonnier  changed:

   What|Removed |Added

 CC||francois.charbonnier@inlibr
   ||o.com

--- Comment #18 from Francois Charbonnier  ---
No objection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377

Julian Maurice  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #8 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #7)
> It does not sound like a good idea to add a third .psgi file to
> maintain/update.

My first intention was to move debian/templates/plack.psgi into app.psgi and
remove misc/plack/ but I felt that it would have prevented a quick integration
into master...

I believe that we should have one (and only one) psgi file, it should not be
hidden in debian/ directory, and it should work out-of-the box on dev installs.

Changing status to In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18961] Datatable column filters of style 'select' should do an exact match

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18961

--- Comment #10 from Jonathan Druart  
---
I suggest to push my patch and assume that only these 5 columns are linked to a
AV. It's not perfect but I do not think it worth the effort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18342] Set memcached as 'enabled' by default

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18342

--- Comment #6 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #5)
> Can this be tested on kohadevbox?

You can test koha-create, yes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

--- Comment #11 from M. Tompsett  ---
Comment on attachment 68082
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68082
Bug 19176: Compare the number of seconds when comparing dates in tests

Review of attachment 68082:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19176=68082)
-

::: t/Test/Dates.pm
@@ +10,5 @@
> +
> +is( t::lib::Dates::compare( $dt_1, $dt_2 ), -1, '2017 is before 2018' );
> +is( t::lib::Dates::compare( $dt_2, $dt_1 ), 1,  '2018 is after 2017' );
> +
> +is( t::lib::Dates::compare( $date_1, $date_2 ), -1, '2017 is before 2018 
> (strings comparaison)' );

Typo: comparison.

::: t/lib/Dates.pm
@@ +19,5 @@
> +my $dt_expected = dt_from_string($expected);
> +$dt_got->set_time_zone('floating');
> +$dt_expected->set_time_zone('floating');
> +my $diff = $dt_got->epoch - $dt_expected->epoch;
> +if ( abs($diff) < 60 ) { return 0 }

A slow server isn't going to have a 15+ second gap, I believe this 60 could be
smaller.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18477] AR_PENDING notice does not populate values from article_requests table.

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18477

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #6 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #3)
> Please provide tests!

Reading the code the change is obvious (the same call exists for other
methods), but why do we call $self->SUPER::store instead of $self->store?

Back to NQA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18377] Add Plack/PSGI file for dev install

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18377

--- Comment #7 from Jonathan Druart  
---
It does not sound like a good idea to add a third .psgi file to
maintain/update.

Tomas, what is your feeling about this change/need?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027
Bug 12027 depends on bug 12026, which changed state.

Bug 12026 Summary: Shibboleth auto-provisioning - Create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12026] Shibboleth auto-provisioning - Create

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

Ehsna  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 CC||eh...@iub.edu.bd
 Resolution|FIXED   |---

--- Comment #92 from Ehsna  ---
My Shibboleth and ADFS is working if I manually created the user. it's not
creating the user automatically. here is my koha-conf.xml 

  
userid

  
  
  
  


  

What I am missing ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18507] Shibboleth auto-provisioning - Sync

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507
Bug 18507 depends on bug 12026, which changed state.

Bug 12026 Summary: Shibboleth auto-provisioning - Create
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12026

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #6 from Julian Maurice  ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16213] Allow to select hold's itemtype when using API

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16213

Julian Maurice  changed:

   What|Removed |Added

  Attachment #50017|0   |1
is obsolete||

--- Comment #5 from Julian Maurice  ---
Created attachment 68179
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68179=edit
Bug 16213: Allow to select hold's itemtype when using API

Test plan:
1/ Use your usual "REST testing" tool to place a title-level hold with
an itemtype. The request should look like this:

POST /api/v1/holds
{
"borrowernumber": 1234,
"biblionumber": 456,
"branchcode": "CPL",
"itemtype": "A"
}

2/ Check that the hold was placed and the itemtype is correctly selected
3/ prove t/db_dependent/api/v1/holds.t

Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18298] Allow enforcing password complexity

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298

Jonathan Druart  changed:

   What|Removed |Added

  Text to go in the||Add the option to enforce a
  release notes||strong password policy.
   ||That policy would mean that
   ||passwords should include 1
   ||lowercase, 1 uppercase and
   ||1 digit.
   ||This option is
   ||turned on for new
   ||installations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19373] CAS Login for staff interface always go back to home.

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19373

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #13 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18298] Allow enforcing password complexity

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18298

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #67 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19472] Add perl extension to borrowers-force-messaging-defaults

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19472] Add perl extension to borrowers-force-messaging-defaults

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||19472


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472
[Bug 19472] Add perl extension to borrowers-force-messaging-defaults
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add preferences only when not already present

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on|13572   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572
[Bug 13572] Add actives parameter to force_borrower_messaging_defaults script
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19472] Add perl extension to borrowers-force-messaging-defaults

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472

Marcel de Rooy  changed:

   What|Removed |Added

 Depends on||13572


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572
[Bug 13572] Add actives parameter to force_borrower_messaging_defaults script
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19472] Add perl extension to borrowers-force-messaging-defaults

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add actives parameter to force_borrower_messaging_defaults script

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||19472


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472
[Bug 19472] Add perl extension to borrowers-force-messaging-defaults
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add actives parameter to force_borrower_messaging_defaults script

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks|19451   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451
[Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add
preferences only when not already present
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19472] Add perl extension to borrowers-force-messaging-defaults

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks||19451


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19451
[Bug 19451] Let borrowers-force-messaging-defaults.pl optionally add
preferences only when not already present
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19472] Add perl extension to borrowers-force-messaging-defaults

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472

--- Comment #1 from Marcel de Rooy  ---
Created attachment 68178
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68178=edit
Bug 19472: Add perl extension to script borrowers-force-messaging-defaults

There is no reason to keep this perl script without the regular extension.
Please see other scripts in the same folder too.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19472] Add perl extension to borrowers-force-messaging-defaults

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19472] New: Add perl extension to borrowers-force-messaging-defaults

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19472

Bug ID: 19472
   Summary: Add perl extension to
borrowers-force-messaging-defaults
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

See bug 13572

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add actives parameter to force_borrower_messaging_defaults script

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

--- Comment #17 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #16)
> Just asking: maybe --not-expired is more meaningful here?
> I do not think we already use "active" on the interface or scripts.

No objection

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add actives parameter to force_borrower_messaging_defaults script

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

--- Comment #16 from Jonathan Druart  
---
Just asking: maybe --not-expired is more meaningful here?
I do not think we already use "active" on the interface or scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13572] Add actives parameter to force_borrower_messaging_defaults script

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68060|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  
---
Comment on attachment 68060
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68060
Bug 13572: (Follow-up) Add perl extension to script

Please do that on its own bug report (can break scripts if not highlight in the
release notes).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19411] opac-shelves.tt : the opaccredits block should be outside of the main

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411

--- Comment #1 from David Bourgault  ---
Similar issue exists in opac-advsearch.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13812] Facet links broken because double-quotes are not URL encoded.

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13812

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7419] Add authority deduplication script

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13775] software error when choosing authority via plugin

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18138] Use MARC modification template when adding/ updating bibliographic records

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17511] Authority linking subfield

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19015] Searches fail with error Fielddata is disabled on text fields by default for elastic search 5.3 and 5.4

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19015

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18319] Elasticsearch Advanced search breadcrumbs broken

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18319

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18969] Elasticsearch - _all field is deprecated - should use copy_to to prepare for ES6

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4226] bulkmarcimport.pl doesn' t replace 001 when keepids is not specified

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4226

Frank Hansen  changed:

   What|Removed |Added

 CC||frank.han...@ub.lu.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17951] koha-create should create the template cache dir and configure it in koha-conf.xml

2017-10-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17951

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_17_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 138 matches

Mail list logo