[Koha-bugs] [Bug 16759] Make opac holdings table configurable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

--- Comment #15 from Alex Buckley  ---
Hi 

I have taken a second look at these patches for Tomás, and they work well and
pass the QA test tool so I have signed off on them as well

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16759] Make opac holdings table configurable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

Alex Buckley  changed:

   What|Removed |Added

  Attachment #68345|0   |1
is obsolete||

--- Comment #14 from Alex Buckley  ---
Created attachment 68346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68346=edit
[SIGNED-OFF] Bug 16759: (followup) Make it work with OpacSeparateHoldings

This patch fixes columns_settings.inc so it works for all objects when
the selector returns more than one object.

To test:
- Have the first patch applied
- Verify it works correctly
- Enable OpacSeparateHoldings
- Reload
=> FAIL: Notice the second holdings tab doesn't have the visualization
rules applied.
- Apply this patch
- Reload
=> SUCCESS: Rules applied correctly!
- Sign off :-D

Edit: amended so it preserves the original semantic, returning the
resulting table objects.

Sponsored-by: Dover

Signed-off-by: Owen Leonard 

Followed test plan, patch worked as described. Also passed QA test tool
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16759] Make opac holdings table configurable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

Alex Buckley  changed:

   What|Removed |Added

  Attachment #68343|0   |1
is obsolete||

--- Comment #13 from Alex Buckley  ---
Created attachment 68345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68345=edit
Bug 16759: (followup) Make it work with OpacSeparateHoldings

This patch fixes columns_settings.inc so it works for all objects when
the selector returns more than one object.

To test:
- Have the first patch applied
- Verify it works correctly
- Enable OpacSeparateHoldings
- Reload
=> FAIL: Notice the second holdings tab doesn't have the visualization
rules applied.
- Apply this patch
- Reload
=> SUCCESS: Rules applied correctly!
- Sign off :-D

Edit: amended so it preserves the original semantic, returning the
resulting table objects.

Sponsored-by: Dover

Signed-off-by: Owen Leonard 

Followed test plan, patch worked as described. Also passed QA test tool
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16759] Make opac holdings table configurable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

Alex Buckley  changed:

   What|Removed |Added

  Attachment #68342|0   |1
is obsolete||

--- Comment #12 from Alex Buckley  ---
Created attachment 68344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68344=edit
[SIGNED-OFF] Bug 16759: Make OPAC holdings table configurable

This patch makes the holdings table in the OPAC biblio detail page
configurable using the Columns configuration tools.

This patch:
- Moves the holdingst table from plain DataTable to KohaTable
- Creates a sample yml colvis configuration for this table
  containing all the currently available columns

To test:
- Visit some record's detail page in the OPAC
- Apply this patch
- Reload
=> SUCCESS: The page shows the same information
- On the staff interface, go to:
  Home > Administration > Columns settings
=> SUCCESS: There's a new OPAC section containing the configuration for
   holdingst.
- Choose to hide some fields (both currently displayed and currently hidden).
- Reload the OPAC detail page
=> SUCCESS:
   - Required fields are hidden
   - It doesn't explode because of trying to hide stuff that is not there to
start with
- Sign off :-D

Sponsored-by: DOVER

Signed-off-by: Owen Leonard 

Followed test plan, patch worked as described. Also passed QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16759] Make opac holdings table configurable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
  Attachment #65563|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16759] Make opac holdings table configurable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

Alex Buckley  changed:

   What|Removed |Added

  Attachment #65564|0   |1
is obsolete||

--- Comment #11 from Alex Buckley  ---
Created attachment 68343
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68343=edit
[SIGNED-OFF] Bug 16759: (followup) Make it work with OpacSeparateHoldings

This patch fixes columns_settings.inc so it works for all objects when
the selector returns more than one object.

To test:
- Have the first patch applied
- Verify it works correctly
- Enable OpacSeparateHoldings
- Reload
=> FAIL: Notice the second holdings tab doesn't have the visualization
rules applied.
- Apply this patch
- Reload
=> SUCCESS: Rules applied correctly!
- Sign off :-D

Edit: amended so it preserves the original semantic, returning the
resulting table objects.

Sponsored-by: Dover

Signed-off-by: Owen Leonard 

Followed test plan, patch worked as described. Also passed QA test tool
Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16759] Make opac holdings table configurable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

--- Comment #10 from Alex Buckley  ---
Created attachment 68342
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68342=edit
Bug 16759: Make OPAC holdings table configurable

This patch makes the holdings table in the OPAC biblio detail page
configurable using the Columns configuration tools.

This patch:
- Moves the holdingst table from plain DataTable to KohaTable
- Creates a sample yml colvis configuration for this table
  containing all the currently available columns

To test:
- Visit some record's detail page in the OPAC
- Apply this patch
- Reload
=> SUCCESS: The page shows the same information
- On the staff interface, go to:
  Home > Administration > Columns settings
=> SUCCESS: There's a new OPAC section containing the configuration for
   holdingst.
- Choose to hide some fields (both currently displayed and currently hidden).
- Reload the OPAC detail page
=> SUCCESS:
   - Required fields are hidden
   - It doesn't explode because of trying to hide stuff that is not there to
start with
- Sign off :-D

Sponsored-by: DOVER

Signed-off-by: Owen Leonard 

Followed test plan, patch worked as described. Also passed QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19164] Allow MARC modification templates to be used in staged MARC imports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19164

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz

--- Comment #12 from Alex Buckley  ---
Created attachment 68341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68341=edit
Record not visible in staged file after running misc/stage-file.pl

Hi Jon 

After running the misc/stage-file.pl with the parameters as set in your test
plan I have found that instead of displaying the "Basic Christianity. Stott,
John R. W. (0802811892)" record a record link 'null' is displayed (see
screenshot) and it only contains MARC fields: 000, 001 003, 005 and 008

I copied the contents of your marc file across into my kohadevbox and pasted it
into new file with vi and made sure the formatting matched your marc file so I
am assuming that this issue may be in the misc/stage-file.pl script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17015] New Koha Calendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015

Alex Buckley  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #105 from Alex Buckley  ---
Hi David and Medhi

While testing patch 17983 I applied this dependency patch and found that it no
longer applies successfully on a master branch any more, the conflict is in
C4/Overdues.pm. Can you please rebase, then after checking everything is still
working as it was when I last tested and I will sign off again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67115|0   |1
is obsolete||

--- Comment #54 from Alex Buckley  ---
Created attachment 68340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68340=edit
Bug 12532 - Send emails to guarantee and guarantor

Adds setting "RedirectGuaranteeEmail". When setting is enabled,
emails to patron with a guarantor will be send to both guarantor
and guarantee.

Does this by amending the C4::Members::GetNoticeEmail() sub. It does
not affect values in the message_queue table.

Test plan:

Before applying
1) Select patron with guarantor
2) Enable checkout emails
3) Checkout item. Email will be sent only to guarantee
4) Apply patch
5) Run updatedatabase.pl
6) Enable 'RedirectGuaranteeEmail' in system preferences
7) Go through step 1) to 3). Email should now be sent to both.
8) Run t/db_dependant/Members.t

Sponsored by: Ville de Victoriaville

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alex Buckley  changed:

   What|Removed |Added

  Attachment #68318|0   |1
is obsolete||

--- Comment #5 from Alex Buckley  ---
Created attachment 68336
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68336=edit
Bug 19336 - Correct DateTime and Koha calls

This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).

Passes QA test tool

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alex Buckley  changed:

   What|Removed |Added

  Attachment #67191|0   |1
is obsolete||

--- Comment #4 from Alex Buckley  ---
Created attachment 68335
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68335=edit
Bug 19336 - Add --maxfinesday option to fines.pl

This is a functionality we have for some of our clients we want to push
to the community.

Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.

e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.

Here is a test plan I followed based on above.
Test plan:
1. Create circulation rule with Overdue fines cap set

2. Set finesMode systempreference to 'Calculate and charge'

3. Check out an item with the due date set 30 days ago

4. In Koha shell run ./fines.pl --maxfinesdays 30

5. There should now be a new fine in the accountlines table of the
amount set in overdue fines cap

Followed test plan, patch worked as intended

Signed-off-by: Alex Buckley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19368] Add syspref to ignore words when sorting serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||alexbuck...@catalyst.net.nz

--- Comment #10 from Alex Buckley  ---
Hi David

The syspref SortIgnoreArticles is not being displaying in the Global System
preferences module to fix this can you please add SortIgnoreArticles syspref to
the admin.pref YAML file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #100 from Katrin Fischer  ---
Just wondering, if the values are not supposed to be translated, maybe an ENUM
instead of the separate table or having a code that can later be translated in
the templates? "Payment Reversed" seems like an odd PK and some of the values
are codes in accountlines (F, FU, ...), so we might want them to match.
Can file a separate bug if this is not totally off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #145 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #144)
> Created attachment 68334 [details] [review]
> Bug 14826: account_offset_types.sql is not in the mandatory subdir

Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

--- Comment #144 from Jonathan Druart  
---
Created attachment 68334
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68334=edit
Bug 14826: account_offset_types.sql is not in the mandatory subdir

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19503] Duplicating a dropdown menu subfield yields an empty subfield tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19503

Andreas Roussos  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19503] Duplicating a dropdown menu subfield yields an empty subfield tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19503

Andreas Roussos  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |arouss1...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19503] Duplicating a dropdown menu subfield yields an empty subfield tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19503

--- Comment #1 from Andreas Roussos  ---
Created attachment 68333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68333=edit
Bug 19503: Duplicating a dropdown menu subfield yields an empty subfield tag

While editing a record in the staff client, if you clone a repeatable
dropdown subfield the cloned subfield's tag is empty. This can result
in data loss if the record is saved, re-opened, and saved yet again.
This patch (originally written by Sophie MEYNIEUX for bug 17818) fixes that.

Test plan:
0) [PREREQUISITE] In your MARC framework (Home > Administration > MARC
   bibliographic framework) ensure that you have at least one subfield
   of a particular tag linked to an authorised value (e.g. in UNIMARC,
   tag 700 subfield 4 is 'Relator Code' and can be linked to CCODE for
   testing purposes). This is so that the relevant subfield will be a
   dropdown menu and not a textbox.
1) In the Staff Client, edit an existing record or create a new one.
   Then, try to clone any subfield that is a dropdown menu. Observe
   that the cloned subfield's tag is empty.
2) Apply the patch.
3) Hit CTRL-F5 in your browser (to ensure cataloging.js is re-loaded)
   and try to clone a dropdown menu subfield again. This time the tag
   is cloned as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #99 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #96)
> (In reply to Nick Clemens from comment #93)
> > Created attachment 68274 [details] [review] [review]
> > Bug 12768 - (QA Followup) Fix doubled code
> > 
> > Signed-off-by: Nick Clemens 
> 
> This last patches changes a behaviour:
> Before, chargelostitem created a Koha::Account::Offset with type="Lost
> Item", now it is "Manual Debit".
> 
> What do we want?

(In reply to Katrin Fischer from comment #97)
> Fix capitalization? :)

Please take care of that with a follow-up asap.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19356] Move staff client cart JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19356

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #64 from Tomás Cohen Arazi  ---
Marcel, I've looked at this patchset, along with bug 19096. Everything looks
correct so far. I'm only concerned about the UI changes, the 'comma' separator
for subfields, and no feedback on wrong input.

Maybe we can talk about it on monday, and maybe a quick fix might allow passing
QA on this one :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18961] Datatable column filters of style 'select' should do an exact match

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18961

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #16 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19487] Internal server error when writing off lost fine for item not checked out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19487

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19348] Title column in item search is too narrow

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19348

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16187] Add a script to cancel unfilled holds after a specified number of days

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16187

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #27 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Dominic Pichette  changed:

   What|Removed |Added

 CC||dominic.piche...@inlibro.co
   ||m

--- Comment #10 from Dominic Pichette  ---
I'm having trouble applying the patch.
I did a reset and still can't apply the patch without getting:
fatal: sha1 information is lacking or useless
(installer/data/mysql/kohastructure.sql).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18564] koha-common.cnf parsing is too restrictive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Jonathan Druart  
---
Patch pushed to master for 17.11.

Thanks and congrats Éric it is your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14826] Resurrect account offsets table

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14826

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #143 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #98 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #97 from Katrin Fischer  ---
Fix capitalization? :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #96 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #93)
> Created attachment 68274 [details] [review]
> Bug 12768 - (QA Followup) Fix doubled code
> 
> Signed-off-by: Nick Clemens 

This last patches changes a behaviour:
Before, chargelostitem created a Koha::Account::Offset with type="Lost Item",
now it is "Manual Debit".

What do we want?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #95 from Jonathan Druart  
---
Created attachment 68332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68332=edit
Bug 12768: (follow-up) Add 'Processing fee' to templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19503] Duplicating a dropdown menu subfield yields an empty subfield tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19503

Andreas Roussos  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=17818
 CC||arouss1...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17818] Duplicating a subfield yields an empty subfield tag [follow-up ]

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17818

Andreas Roussos  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19503

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645

Blou  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com
   ||,
   ||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19503] New: Duplicating a dropdown menu subfield yields an empty subfield tag

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19503

Bug ID: 19503
   Summary: Duplicating a dropdown menu subfield yields an empty
subfield tag
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: arouss1...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Created attachment 68331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68331=edit
screenshot of staff client showing the error

[This is a follow-up from bug 17818 which referred to v3.22. Apparently, the
same problem exists in v16.05.17, so I'm creating a new bug report here.]

The problem is as follows:
When editing a record in the staff client, if you clone a repeatable dropdown
subfield the cloned subfield's tag is empty (see attached screenshot). If you
then save the record and re-open it, the cloned subfield is not shown at all.
And if you save the record once more, that subfield is gone for good :(

I've tested versions 16.11.12 and 17.05.04 and they seem unaffected by this,
so I'm filing this bug against 16.05.

If you try to reproduce this bug, please note that it's only the cloning of
dropdown menu subfields that is broken. Cloning of textarea subfields works
fine.

Setting severity to 'major' as per bug 17818 and bug 17477.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18426] Subscriptions batch editing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18426

--- Comment #10 from Caroline Cyr La Rose  ---
Nick,

I did not do any of those things and I don't know what they mean. I'm not that
technical... Sorry!

BUT I just did a git pull and I had to reinstall Koha for the latest version.
It asked to install dependencies, so I guess that's done...

I retested and IT WORKS! And it's really neat! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19487] Internal server error when writing off lost fine for item not checked out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19487

--- Comment #11 from Jonathan Druart  
---
Created attachment 68330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68330=edit
Bug 19487: Refetch the object to get up-to-date values

This has been raised by failures on t/db_dependent/Circulation/issue.t
(thanks tests!)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19487] Internal server error when writing off lost fine for item not checked out

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19487

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68313|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Comment on attachment 68313
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68313
Bug 19487: (QA follow-up) More changes to MarkIssueReturned.t

I am not willing to push this patch.
We want a fix for stable releases, so something easy to backport.
This change is quite big may slow down the backport.

Moreover it seems that at least one test has been removed:
-unlike ( $@, qr, );

and this line too, which makes me think you cut a bit too much:
t::lib::Mocks::mock_preference('AnonymousPatron', $anonymous_borrowernumber);

Please move it to its own bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19495] Automatic report conversion needs to do global replace on ' biblioitems' and 'marcxml'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495

Dominic Pichette  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||dominic.piche...@inlibro.co
   ||m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19495] Automatic report conversion needs to do global replace on ' biblioitems' and 'marcxml'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495

Dominic Pichette  changed:

   What|Removed |Added

  Attachment #68324|0   |1
is obsolete||

--- Comment #4 from Dominic Pichette  ---
Created attachment 68329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68329=edit
Bug 19495 - Automatic report conversion needs to do global replace on
'biblioitems' and 'marcxml'

Bug 17898 provides a way of converting reports that use biblioitems.marcxml so
that they will use biblio_metadata.metadata instead.

This only works with reports that do not refer to other columns in the
biblioitems table. This is a known limitation. It means that we should be able
to do a substitution of every occurrence of biblioitems with biblio_metadata,
and every occurrence of marcxml with metadata.

Unfortunately, we're not doing a global replace, we're only replacing the first
occurrence.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Reports/Guided.t

All tests successful.
Files=1, Tests=9, 10 wallclock secs ( 0.11 usr  0.01 sys +  2.85 cusr  0.25
csys =  3.22 CPU)
Result: PASS

Signed-off-by: Dominic Pichette 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19492] Field 'lowestPriority' doesn't have a default value (MariaDB)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19492

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
What is the version of MariaDB?
Did you modify my.cnf?
Does `grep -r sql-mode /etc/mysql` return something?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17455] Add system preference to receive acq order e-mails as BCC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17455

--- Comment #1 from Marjorie Barry-Vila  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Alex Sassmannshausen  changed:

   What|Removed |Added

  Attachment #68186|0   |1
is obsolete||

--- Comment #118 from Alex Sassmannshausen 
 ---
Created attachment 68328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68328=edit
Bug 7317: Add unit tests & fix, add comments to Illrequest.pm.

* Koha/Illrequest.pm: Add code commentary.
  (_backend_capability): We need to invoke our code ref.
* Koha/Illrequest/Config.pm: Correct reference to potentially
  uninstantiated $reply_date variable.
* t/db_dependent/Illrequest/Config.t: Improve tests.
* t/db_dependent/Illrequestattributes.t: Improve tests.
* t/db_dependent/Illrequests.t: Improve tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431

--- Comment #12 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #11)
> -unless( $onsite_checkout and
> C4::Context->preference("OnSiteCheckoutsForce") ) {
> +if ( $error->{UNKNOWN_BARCODE} or not $onsite_checkout or not
> C4::Context->preference("OnSiteCheckoutsForce") ) {
> 
> If CanBookBeIssued sets the UNKNOWN_BARCODE flag, it returns no DEBT
> question and no other impossible errors. But since there is one error, it
> will set $blocker to 1. 
> Just wondering if there are other errors that should trigger the blocker
> flag when doing onsite checkouts here. If CanBookBeIssued said No, when is
> an onsite checkout still possible?

I put the test there to avoid to copy paste the blocker=1 and the IMPOSSIBLE
flag. Do you have something better to suggest?

> -if( !$blocker || $force_allow_issue ){
> +
> +if( $item and ( !$blocker or $force_allow_issue ) ){
> 
> Since you raised the blocker flag in the unknown barcode case, you do not
> need to test for $item here. Note that item is found by barcode and
> CanBookBeIssued calls GetItem with barcode parameter.

Yes definitely, but this code is very confusing and I think explicitly tell we
need $item here makes sense (even if useless in a algorithm pov, in my opinion
it helps the read).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

--- Comment #5 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #4)
> We will be doing this a lot of times when a biblio has more items:
> 
> my $issuing_rule = Koha::IssuingRules->get_effective_issuing_rule({
> categorycode => $borrowercategory, itemtype => $itype, branchcode =>
> $branchcode });
> 
> The categorycode is always the same. Branchcode is holding branch, often
> too. And probably we will not have a lot of different itemtypes for one
> biblio. So this could be more intelligent.
> For longer lists with biblios having much items (serials), we are not
> improving performance.

The calculation was wrong, this patch suggests to fix it (calculate it as it is
everywhere else).
The performance point is valid, but is outside the scope of this bug report.
See as the related bug to understand where I am going (move to Koha namespace,
then improve code from there. We can easily imagine a cache mechanism in
Koha::IssuingRules). 

> And another thing:
> We are using OnShelfHoldsAllowed on detail forms but NOT on search results
> with 20 biblios. Why should we use it on a list that may contain much more
> biblios?
> I would rather set $this_item->{allow_onshelf_holds} to 1 and let
> opac-reserve handle the details, similar to opac-search. The template
> already contains itemsloo.norequests and also tests itemsloo.itemsissued..

I guess that could be considered as a regression by somebody else.

Again, this is a bug I found where I started moving code. I would like to
improve the way it is calculated/displayed, etc (see bug 19297).
But this patch is the very first step :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68305|0   |1
is obsolete||

--- Comment #42 from Simon Pouchol  ---
Created attachment 68327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68327=edit
Bug 14715: [FOLLOW-UP] Removing 'all' option, fixing QA tools issues

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19495] Automatic report conversion needs to do global replace on ' biblioitems' and 'marcxml'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14715] results per page setting for catalog search in staff client and opac

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||simon.pouc...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19470] Add information about item being in rotating collection on detail page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19470

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19502] New: Elasticsearch - result sets limited to 10000

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502

Bug ID: 19502
   Summary: Elasticsearch - result sets limited to 1
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com

With the new feature to jump to a last page of search results it is apparent
that we can't do this with our current use of ES. The standard limit is 1
results, it can be increased at the cost of memory - need to look into 'Scroll'
or 'Search after' options

https://www.elastic.co/guide/en/elasticsearch/reference/5.5/index-modules.html
 index.max_result_window
The maximum value of from + size for searches to this index. Defaults to
1. Search requests take heap memory and time proportional to from + size
and this limits that memory. See Scroll or Search After for a more efficient
alternative to raising this. 

https://www.elastic.co/guide/en/elasticsearch/reference/5.6/search-request-scroll.html

https://www.elastic.co/guide/en/elasticsearch/reference/5.6/search-request-search-after.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128

Nick Clemens  changed:

   What|Removed |Added

  Attachment #64980|0   |1
is obsolete||
  Attachment #68306|0   |1
is obsolete||

--- Comment #10 from Nick Clemens  ---
Created attachment 68325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68325=edit
Bug 18128: Go to page option for search results in OPAC and staff

This patch adds a dropdown of all available search result pages for a
user to jump to.

To test:
1) Apply Bug 13205
2) Do a search in OPAC and in staff client
3) Try to jump to different pages in the dropdown, confirm they always
work

Sponsored-by: Catalyst IT

Signed-off-by: Lee Jamison 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128

--- Comment #11 from Nick Clemens  ---
Created attachment 68326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68326=edit
Bug 18128: [FOLLOW-UP] Some display fixes

This patch addresses some of the display issues brought up in Comment 6.

The dropdown list should now include every page number.
The bar will only show up to 5 page numbers on each side of the current
active page.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #13 from Koha Team Lyon 3  ---
Hello Alex,

Good thing for dayly and monthly publication.
As for weekly issues, don't know if it's realistic but what about basing
calculation on week numbering (iso 8601) ?
Some review (not so unusual cases) announce clearly their "not issued weeks".
Example the New Yorker publishes 5 issues that runs along 2 weeks and they are
cited in the publication information block.

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19495] Automatic report conversion needs to do global replace on ' biblioitems' and 'marcxml'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||17898


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898
[Bug 17898] Add a way to automatically convert SQL reports
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17898] Add a way to automatically convert SQL reports

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17898

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||19495


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495
[Bug 19495] Automatic report conversion needs to do global replace on
'biblioitems' and 'marcxml'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19495] Automatic report conversion needs to do global replace on ' biblioitems' and 'marcxml'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #68324|Forgot to add an|Bug 19495 - Automatic
description|explanation to the unit |report conversion needs to
   |test|do global replace on
   ||'biblioitems' and 'marcxml'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19495] Automatic report conversion needs to do global replace on ' biblioitems' and 'marcxml'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #68323|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 68324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68324=edit
Forgot to add an explanation to the unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19495] Automatic report conversion needs to do global replace on ' biblioitems' and 'marcxml'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Severity|enhancement |blocker

--- Comment #2 from Kyle M Hall  ---
Updating importance to blocker because we should *really* get this fixed before
release.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19495] Automatic report conversion needs to do global replace on ' biblioitems' and 'marcxml'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19495] Automatic report conversion needs to do global replace on ' biblioitems' and 'marcxml'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19495

--- Comment #1 from Kyle M Hall  ---
Created attachment 68323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68323=edit
Bug 19495 - Automatic report conversion needs to do global replace on
'biblioitems' and 'marcxml'

Bug 17898 provides a way of converting reports that use biblioitems.marcxml so
that they will use biblio_metadata.metadata instead.

This only works with reports that do not refer to other columns in the
biblioitems table. This is a known limitation. It means that we should be able
to do a substitution of every occurrence of biblioitems with biblio_metadata,
and every occurrence of marcxml with metadata.

Unfortunately, we're not doing a global replace, we're only replacing the first
occurrence.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Reports/Guided.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Simon Pouchol  changed:

   What|Removed |Added

 CC||simon.pouc...@biblibre.com

--- Comment #3 from Simon Pouchol  ---
Hey,
I tried to test this patch, and couldn't apply it (Dependency patch 14826
applied just fine):

Applying: Bug 19191 - Add ability to email receipts for account payments and
write-offs
Using index info to reconstruct a base tree...
M   C4/Letters.pm
M   Koha/Account/Offset.pm
M   t/db_dependent/Letters/TemplateToolkit.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Letters/TemplateToolkit.t
Auto-merging Koha/Account/Offset.pm
CONFLICT (content): Merge conflict in Koha/Account/Offset.pm
Auto-merging C4/Letters.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 19191 - Add ability to email receipts for account
payments and write-offs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16660] Elasticsearch broken if OpacSuppression is activated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16660

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16660] Elasticsearch broken if OpacSuppression is activated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16660

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68224|0   |1
is obsolete||

--- Comment #12 from Tomás Cohen Arazi  ---
Created attachment 68320
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68320=edit
Bug 16660: Moved Opac Supression filtering from opac-search.pl to
Zebra::QueryBuilder

To test:
OPAC: Both SearchEngine "Elasticsearch" and "Zebra" should work with
OpacSuppression set to "yes"

NB: OPAC suppression is not implemented for Elasticsearch

Signed-off-by: David Bourgault 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16660] Elasticsearch broken if OpacSuppression is activated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16660

--- Comment #14 from Tomás Cohen Arazi  ---
Created attachment 68322
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68322=edit
Bug 16660: (followup) Unit tests

This patch adds unit tests for the introduced changes in
build_query_compat.

It removes a warning too.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16660] Elasticsearch broken if OpacSuppression is activated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16660

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68280|0   |1
is obsolete||

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 68321
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68321=edit
Bug 16660: Add support for OpacSuppression to Elasticsearch

To test:
1 - Enable suppression
2 - Suppress some records
3 - Apply all the patches
4 - Reindex ES
5 - Search and don't get suppressed records
6 - Disable suppression
7 - Search and get all the records

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||simon.pouc...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19017] Script that checks and transforms SMS alert numbers

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19017

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #65498|0   |1
is obsolete||

--- Comment #5 from Simon Pouchol  ---
Created attachment 68319
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68319=edit
Checks and transform SMS alert number

This patch adds a new package C4::SMSNumber::Fr (new ones could be added
for other countries)
and a scrip (misc/check_smsalertnumber.pl):
  check_smsalertnumber.pl -a|--area fr [-h|--help] [-c|--confirm]
[-o|--country-option] [-l|--liste-mode]

Test plan #1:
  - Create or modify patrons and add some SMS alert numbers like:
 06 98 35 72 28, 0656871221, +336-01-55-83-11, 0033 6.23.54.54.00,
0126698376
  - launch perl misc/check_smsalertnumber.pl -a Fr
  - Transformation proposal should be like:
- 06 98 35 72 28 => 0698357228,
- 0656871221 => no proposal (number Ok),
- +336-01-55-83-11 => 0601558311,
- 0033 6.23.54.54.00 => 0623545400,
- 0126698376 => Can't find a replacement

Test plan #2:
  - with the same numbers launch perl misc/check_smsalertnumber.pl -a Fr
-o +33
  - Transformation proposal should be like:
- 06 98 35 72 28 => +33698357228,
- 0656871221 => +33656871221,
- +336-01-55-83-11 => +33601558311,
- 0033 6.23.54.54.00 => +33623545400,
- 0126698376 => Can't find a replacement

Test plan #3:
  - with the same numbers launch perl misc/check_smsalertnumber.pl -a Fr
-o 0033
  - Transformation proposal should be like:
- 06 98 35 72 28 => 0033698357228,
- 0656871221 => 0033656871221,
- +336-01-55-83-11 => 0033601558311,
- 0033 6.23.54.54.00 => 0033623545400,
- 0126698376 => Can't find a replacement

https://bugs.koha-community.org/show_bug.cgi?id=19017
Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979

--- Comment #6 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #5)
> Files=1, Tests=842, 42 wallclock secs ( 0.20 usr  0.02 sys + 41.23 cusr 
> 0.40 csys = 41.85 CPU)
> 
> Files=1, Tests=842, 37 wallclock secs ( 0.06 usr  0.01 sys + 42.91 cusr 
> 0.84 csys = 43.82 CPU)
> 
> Does this justify another dependency ?

The dependency is used by bug 18055 as well, and we gain 10min

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

Simon Pouchol  changed:

   What|Removed |Added

 CC||simon.pouc...@biblibre.com

--- Comment #7 from Simon Pouchol  ---
Works as intended for the tables statistics, deleted catalogs, branch transfers
and deleted patrons (there is a typo in your test plan for this one : "- Run
cleanup : misc/cronjobs/cleanup_database.pl -v --delete-patrons 30" is missing
a "d" at --deleted-patrons).

AS for the tables old_issues and old_reserves, I couldn't get the test done on
mysql, the count returns "ERROR 1054 (42S22): Unknown column 'datetime' in
'field list'" for both tables. The cleanup seems to be working, but I just
can't verify it in mysql.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909

--- Comment #11 from Marjorie Barry-Vila  ---
Anyone is working on this?

Still valid in 16.11.

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17983] Add minutes loan to DiscreteCalendar

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17983

David Bourgault  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

David Bourgault  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

--- Comment #3 from David Bourgault  ---
Created attachment 68318
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68318=edit
Bug 19336 - Correct DateTime and Koha calls

This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and last modifier in MARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||simon.pouc...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19349] Allow to store biblio record' s creator and last modifier in MARC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19349

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #67233|0   |1
is obsolete||

--- Comment #4 from Simon Pouchol  ---
Created attachment 68317
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68317=edit
Bug 19349: Store record's creator and last modifier in record

Test plan:
1. Run updatedatabase.pl
2. Set sysprefs MarcFieldForCreatorId, MarcFieldForCreatorName,
   MarcFieldForModifierId, MarcFieldForModifierName
3. Create a new biblio
4. Verify that the fields are correctly filled
5. Logout and login as another user
6. Modify the same biblio
7. Verify that only the fields for last modifier have been modified

Works perfectly.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336

David Bourgault  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |david.bourga...@inlibro.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

David Bourgault  changed:

   What|Removed |Added

  Attachment #67150|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #15 from Katrin Fischer  ---
Maybe you are just missing a dependency on the one computer?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9573] Ability to download items lost report

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573

--- Comment #14 from Séverine Queune  ---
(In reply to Jonathan Druart from comment #13)
> (In reply to Séverine Queune from comment #11)
> > Everyting work well (set csv profile, filter the list on notforloen ou
> > itemlost, select items) until I try to export the selected items.
> > I always get this Software error :
> > Can't locate object method "new" via package "Text::CSV_XS" (perhaps you
> > forgot to load "Text::CSV_XS"?) at /home/koha/src/reports/itemslost.pl line
> > 68.
> > For help, please send mail to the webmaster ([no address given]), giving
> > this error message and the time and date of the error.
> 
> I did not recreate with my perl version, but indeed there was a missing use
> statement.

I first tried at home with my personal laptop when I had this message.

I just tried :
 - my professional computer + BULAC wired connexion : it works
 - my personal laptop + BULAC wifi for guests : it works

I'll try again tonight with home wifi + laptop and will sign the patch if
everything is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19501] New: New list category to restrict specific lists to staff & hide from OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19501

Bug ID: 19501
   Summary: New list category to restrict specific lists to staff
& hide from OPAC
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jeremy.ev...@nibsc.org
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

We are creating various lists of titles that need to be hidden from view in the
OPAC for the time being but other staff members need to see them. 
At the moment the options are Public or Private so this won't do what we
require.  We would like an additional list category selection of Staff so that
those lists are then visible in the staff client (& presumably also to anyone
who logs into the OPAC with a staff permissions login) but are not publicly
visible in the OPAC.

The intention is that multiple staff members may need to add items to some of
these lists.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19499] Notice update fails on SQL UPDATE

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19499

Mirko Tietgen  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18979] Speed up 'valid-templates.t' tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18979

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #5 from Marcel de Rooy  ---
Files=1, Tests=842, 42 wallclock secs ( 0.20 usr  0.02 sys + 41.23 cusr  0.40
csys = 41.85 CPU)

Files=1, Tests=842, 37 wallclock secs ( 0.06 usr  0.01 sys + 42.91 cusr  0.84
csys = 43.82 CPU)

Does this justify another dependency ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #18 from Séverine Queune  ---
I now have a button "Mark item as lost", thanks !

Behaviour is correct also for the "Holds waiting over" tab, except for the last
and, to me, the main part of this patch : items are supposed to be marked as
lost and not be available, but they are not.

This is one of the enhancement we ask for, as you can see on the third point of
the description of this ticket :
>- "set the field “items.notforloan” or “items.itemlost” (define in a system
> preference) from “0” to a value from the same ‘authorized values list’ and set
> in another system preference").

Dis I misunderstood something in you're comment #16 ?

I open ticket #19500 about the name of the module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19500] New: Difference in Koha module names for notices linked to Holds/Reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19500

Bug ID: 19500
   Summary: Difference in Koha module names for notices linked to
Holds/Reserves
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: severine.que...@bulac.fr
QA Contact: testo...@bugs.koha-community.org

Choose 'Holds Koha module' in the form displays 'Reserves module' in the
tools/letter.pl page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #4 from Marcel de Rooy  ---
We will be doing this a lot of times when a biblio has more items:

my $issuing_rule = Koha::IssuingRules->get_effective_issuing_rule({
categorycode => $borrowercategory, itemtype => $itype, branchcode =>
$branchcode });

The categorycode is always the same. Branchcode is holding branch, often too.
And probably we will not have a lot of different itemtypes for one biblio. So
this could be more intelligent.
For longer lists with biblios having much items (serials), we are not improving
performance.

And another thing:
We are using OnShelfHoldsAllowed on detail forms but NOT on search results with
20 biblios. Why should we use it on a list that may contain much more biblios?
I would rather set $this_item->{allow_onshelf_holds} to 1 and let opac-reserve
handle the details, similar to opac-search. The template already contains
itemsloo.norequests and also tests itemsloo.itemsissued..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #3 from Marcel de Rooy  ---
Yes, $this_item is a great variable for a biblio.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68304|0   |1
is obsolete||

--- Comment #22 from Simon Pouchol  ---
Created attachment 68316
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68316=edit
Bug 16486: [FOLLOW-UP] Adding timestamp to date in other places

As suggested in Comment 7.
The timestamp has also been added to printfeercpt.tt, printinvoice.tt,
and opac-account.tt

To test:
1) In Staff side, go to member account, go to Fines, go to Account tab
2) Click the Print button next to a payment
3) Confirm timestamp shows on print slip
4) Create a manual invoice
5) Go back to the Account tab
6) Click the Print button next to the invoice
7) Confirm timestamp shows on print slip
8) Log into OPAC
9) Go to your fines
10) Confirm timestamp shows

Works as intended.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18564] koha-common.cnf parsing is too restrictive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|--- |Small patch

--- Comment #9 from Marcel de Rooy  ---
Thanks, Eric'.
Looks good to me, improving my awk skills on the way..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18564] koha-common.cnf parsing is too restrictive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18564] koha-common.cnf parsing is too restrictive

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18564

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #67371|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 68315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68315=edit
Bug 18564: Improve koha-common.cnf parsing to pick the mysql host

my koha-common.cnf is using this form:

[client]
host=db
user=root
password="move_rootpwd_to_dotenv"

this file is working has expected with mysql tools.

but koha-create parsing will not find the db host resulting in
koha-conf.xml containing no values in hostname element.

Signed-off-by: Jonathan Druart 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/