date:20171024

[Koha-bugs] [Bug 18913] Allow symbolic link in /etc/koha/sites

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18913

--- Comment #5 from Pongtawat  ---
Thanks for signing off.

And sorry that I forgot that the script has to be copied to system location
first. BTW, is there a way to test Debian script directly from the git (dev)
layout?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19359] Reporting module selenium test

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19359

--- Comment #7 from M. Tompsett  ---
Comment on attachment 68122
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68122
Bug 19359 - Followup patch with xpaths changed to id's

Review of attachment 68122:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19359=68122)
-

::: t/lib/Selenium.pm
@@ +13,5 @@
> +
> +my $dbh = C4::Context->dbh;
> +my $login = 'koha';
> +my $password = 'koha';
> +my $base_url= 
> 'http://'.C4::Context->preference("staffClientBaseURL")."/cgi-bin/koha/";

You have the same "lack of ENV code as used by other tests" problem here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19359] Reporting module selenium test

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19359

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18913] Allow symbolic link in /etc/koha/sites

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18913

M. Tompsett  changed:

   What|Removed |Added

  Attachment #64935|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 68511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68511=edit
Bug 18913 - Allows symbolic link in /etc/koha/sites

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18913] Allow symbolic link in /etc/koha/sites

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18913

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18913] Allow symbolic link in /etc/koha/sites

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18913

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett  ---
Had to adapt test plan, because you need to copy the script file into place.

perl /home/vagrant/misc4dev/do_all_you_can_do.pl --instance test --userid admin
--password admin

But other than that, seems to work. -L basically says to follow symbolic links,
so this doesn't break anything as far as I can tell.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18216] Apache2.4 403 errors for Gitified or git clone installs

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18216

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett  ---
What about the debian/template/apache* files that might be related? This only
really fixes old school git installs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

M. Tompsett  changed:

   What|Removed |Added

  Attachment #68501|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 68510
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68510=edit
Bug 18417: Followup - Document new shortcuts in dropdown

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

M. Tompsett  changed:

   What|Removed |Added

  Attachment #62057|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 68509
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68509=edit
Bug 18417 - Advanced Editor - Rancor - add shortcuts for copyright symbols (C)
(P)

To test:
1 - Apply patch
2 - Open advanced cataloging editor
3 - Try using Alt+P and Alt+C and note symbols are added
4 - Save record and ensure symbols are saved

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #5 from M. Tompsett  ---
Sweet little patch. Works great. Nice display of what the ALT+C and ALT+P do. I
attempted it on a random MARC subfield (028$b), and it saved and retrieved the
changes just fine. Signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #142 from David Cook  ---
Created attachment 68508
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68508=edit
Fix problems reported by Koha QA tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #141 from David Cook  ---
(In reply to Josef Moravec from comment #139)
> No problem, here is relevant output from qa tools:
> 
> FAIL  Koha/Daemon.pm
>FAIL critic
>   "$fh" is declared but not used at line 78, column 14. Unused 
> variables
> clutter code and make it harder to read.
>   Bareword file handle opened at line 64, column 18. See pages 
> 202,204 of
> PBP.
> 
> 

Fixed.

> FAIL  Koha/OAI/Harvester.pm
>FAIL critic
>   Variable declared in conditional statement at line 291, column 
> 9. Declare
> variables outside of the condition.
>FAIL pod
>   =head3 without preceding higher level
>in file Koha/OAI/Harvester.pm
> 
> 

Fixed.

> FAIL  Koha/OAI/Harvester/Downloader.pm
>FAIL pod
>in file Koha/OAI/Harvester/Downloader.pm
>   =head2 without preceding higher level
> 
> 

Fixed.

> FAIL  Koha/OAI/Harvester/Import/RDFXML.pm
>FAIL critic
>   Variable declared in conditional statement at line 110, column 
> 5. Declare
> variables outside of the condition.
>FAIL forbidden patterns
>   forbidden pattern: tab char (line 32)
> 
> 

Fixed.

> FAIL  Koha/OAI/Harvester/Import/Record.pm
>FAIL critic
>   Variable declared in conditional statement at line 325, column 
> 17. Declare
> variables outside of the condition.
>   Variable declared in conditional statement at line 262, column 
> 13. Declare
> variables outside of the condition.
>   "return" statement with explicit "undef" at line 145, column 
> 41. See page
> 199 of PBP.
>   Variable declared in conditional statement at line 252, column 
> 5. Declare
> variables outside of the condition.
>FAIL forbidden patterns
>   forbidden pattern: tab char (line 152)
>   forbidden pattern: tab char (line 156)
>   forbidden pattern: tab char (line 142)
>   forbidden pattern: tab char (line 139)
>   forbidden pattern: tab char (line 136)
>   forbidden pattern: tab char (line 384)
>   forbidden pattern: tab char (line 380)
>   forbidden pattern: tab char (line 140)
>   forbidden pattern: tab char (line 141)
>   forbidden pattern: tab char (line 151)
>   forbidden pattern: tab char (line 155)
>   forbidden pattern: tab char (line 149)
>   forbidden pattern: tab char (line 154)
>   forbidden pattern: tab char (line 153)
>   forbidden pattern: tab char (line 138)
>   forbidden pattern: tab char (line 150)
>   forbidden pattern: tab char (line 137)
>FAIL pod
>in file Koha/OAI/Harvester/Import/Record.pm
>   =head3 without preceding higher level
>   empty =head3
>
> 

Fixed.

> FAIL  Koha/OAI/Harvester/Request.pm
>FAIL forbidden patterns
>   forbidden pattern: tab char (line 69)
>   forbidden pattern: tab char (line 191)
>   forbidden pattern: tab char (line 189)
>   forbidden pattern: tab char (line 181)
>   forbidden pattern: tab char (line 188)
>   forbidden pattern: tab char (line 193)
>   forbidden pattern: tab char (line 104)
>   forbidden pattern: tab char (line 98)
>   forbidden pattern: tab char (line 77)
>   forbidden pattern: tab char (line 113)
>   forbidden pattern: tab char (line 183)
>   forbidden pattern: tab char (line 184)
>   forbidden pattern: tab char (line 89)
>   forbidden pattern: tab char (line 185)
>   forbidden pattern: tab char (line 101)
>   forbidden pattern: tab char (line 190)
>   forbidden pattern: tab char (line 83)
>   forbidden pattern: tab char (line 102)
>   forbidden pattern: tab char (line 70)
>   forbidden pattern: tab char (line 78)
>   forbidden pattern: tab char (line 95)
>   forbidden pattern: tab char (line 194)
>   forbidden pattern: tab char (line 107)
>   forbidden pattern: tab char (line 76)
>   forbidden pattern: tab char (line 80)
>   forbidden pattern: tab char (line 108)
>   forbidden pattern: tab char (line 182)
>   forbidden pattern: tab char (line 99)
>   forbidden pattern: tab char (line 109)
>   forbidden pattern: tab char (line 66)
>   forbidden pattern: tab char (line 97)
>   forbidden pattern: tab char (line 106)
>   forbidden pattern: tab char (line 103)
>   forbidden pattern: tab char

[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from M. Tompsett  ---
t/db_dependent/selenium/authenticate.t .. 2/9
#   Failed test at t/db_dependent/selenium/authenticate.t line 83.
Wide character in print at /usr/local/share/perl/5.20.2/Test2/Formatter/TAP.pm
line 113.
#   'Koha › Log in to Koha'
# doesn't match '(?^u:Patron categories)'
23:10:33.991 INFO - Executing: [find element: By.xpath:
//a[@id="newcategory"]])
23:10:34.114 WARN - Exception thrown
org.openqa.selenium.NoSuchElementException: Unable to locate element:
{"method":"xpath","selector
":"//a[@id=\"newcategory\"]"}
Command duration or timeout: 10 milliseconds

Yes, this is a yucky mix of outputs.
But sorry, I'm going to Failed QA this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

--- Comment #5 from M. Tompsett  ---
Comment on attachment 66505
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66505
Bug 19181 - Selenium test for logging into the Koha intranet and OPAC

Review of attachment 66505:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19181=66505)
-

See the description of ENV variables to be used here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19337#c1

::: t/db_dependent/selenium/authenticate.t
@@ +32,5 @@
> +use MARC::Field;
> +
> +my $dbh = C4::Context->dbh;
> +my $login = 'koha';
> +my $password = 'koha';

This (user/password) does not use the possible ENV code that other tests use.

@@ +33,5 @@
> +
> +my $dbh = C4::Context->dbh;
> +my $login = 'koha';
> +my $password = 'koha';
> +my $base_url= 
> 'http://'.C4::Context->preference("staffClientBaseURL")."/cgi-bin/koha/";

protocol is now part of staff URL.

@@ +34,5 @@
> +my $dbh = C4::Context->dbh;
> +my $login = 'koha';
> +my $password = 'koha';
> +my $base_url= 
> 'http://'.C4::Context->preference("staffClientBaseURL")."/cgi-bin/koha/";
> +my $opac_url= C4::Context->preference("OPACBaseURL");

KOHA_INTRANET_URL and KOHA_OPAC_URL env logic should be used here too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19181] Intranet and OPAC authentication selenium test

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19181

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #4 from M. Tompsett  ---
This should be tweaked according to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19337#c1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16759] Make opac holdings table configurable

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

--- Comment #20 from Tomás Cohen Arazi  ---
I've submitted this alternative followup, that's supposed to do the job, but it
isn't happening. I can't find a way to solve it yet. I post it so other people
can spot the problem with it.
It is supposed to replace the previous followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16759] Make opac holdings table configurable

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

--- Comment #19 from Tomás Cohen Arazi  ---
Created attachment 68507
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68507=edit
Bug 16759: (Alternative followup) Handle otherholdings gracefuly

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #22 from Jonathan Druart  
---
Created attachment 68506
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68506=edit
Bug 10021: Restore "Pay fines" list

Previous changes were wrong, the notify_id was always equal to 1 and
GetBorNotifyAcctRecord was used to retrieved the account lines to pay

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #21 from Jonathan Druart  
---
Created attachment 68505
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68505=edit
Bug 10021: Remove notify columns in circ/branchoverdues.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #68503|0   |1
is obsolete||

--- Comment #31 from Aleisha Amohia  ---
Created attachment 68504
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68504=edit
Bug 10267: Display the message only if the user enters too many characters

It seems better to display the warning if the user tries to enter too
many characters in the input.

Test plan:
With max=16
1. Copy/paste a string with 15, 16 and 17 characters
2. Enter a cardnumber of 15, 16, 17 characters
The warning should be displayed only the input overflows

Signed-off-by: Aleisha Amohia 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

--- Comment #30 from Aleisha Amohia  ---
(In reply to Jonathan Druart from comment #29)
> Aleisha, can you take a look at this try please?

Ah yes I see how your change works, I like it and it makes sense. Will sign off
on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #29 from Jonathan Druart  
---
Aleisha, can you take a look at this try please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

--- Comment #28 from Jonathan Druart  
---
Created attachment 68503
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68503=edit
Bug 10267: Display the message only if the user enters too many characters

It seems better to display the warning if the user tries to enter too
many characters in the input.

Test plan:
With max=16
1. Copy/paste a string with 15, 16 and 17 characters
2. Enter a cardnumber of 15, 16, 17 characters
The warning should be displayed only the input overflows

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19525] Bulk-add patrons to a list

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19525

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Kyle, can you explain a bit more?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19526] Unable to upload PDF files to Koha under 856$u

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19526

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED
 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hi Emmanuel, I think this is more likely to be a configuration/support issue
(permissions on your upload directory). Please ask for more help on the mailing
list.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

--- Comment #43 from Aleisha Amohia  ---
(In reply to Katrin Fischer from comment #41)
> I am sorry Aleisha, but the bibliographic default framework still exports as
> .ods when I select csv. 
> 
> To test:
> - Go to administration > bibliographic marc frameworks
> - Export > CSV
> - Verify file ending is .csv
> - Apply patches
> - restart_all on kohadevbox
> - Repeat export
> - Verify file ending is now .ods

Sorry Katrin I was missing the 'default' part. Found the problem, fixed in
latest patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

--- Comment #42 from Aleisha Amohia  ---
Created attachment 68502
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68502=edit
Bug 13952: [FOLLOW-UP] Fixing export on default biblio framework

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13952] Import and export of authority types

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

--- Comment #27 from Aleisha Amohia  ---
(In reply to Jonathan Druart from comment #26)
> With CardnumberLength=16, if I enter a 16 chars length string, I get the
> warning.
> It should display only if > 16, right?

Not quite - you can't actually input more than 16 characters so no warning
would show if we made that change, which is the problem already. Having a
warning at 16 characters (rather than > 16 characters) just lets the user know
that there is a limit in place and that they've reached the max. Does that make
sense?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11780] Need to prevent specific fields from being overwritten with z39.50 import

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11780

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776

Barry Cannon  changed:

   What|Removed |Added

 CC||b...@interleaf.ie

--- Comment #19 from Barry Cannon  ---
I am not sure about this patch. I managed to get it working on 16.11.10 but not
on 16.11.13. apply patch, enable plack - shibboleth auth doesn't work. Disable
plack and shib works again. Shib log seems to to be comparable during both
login attempts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

--- Comment #4 from Nick Clemens  ---
Created attachment 68501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68501=edit
Bug 18417: Followup - Document new shortcuts in dropdown

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18417] Advanced Editor - Rancor - add shortcuts for copyright symbols (C) (P)

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18417

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67596|0   |1
is obsolete||

--- Comment #20 from Nick Clemens  ---
Created attachment 68499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68499=edit
Bug 18201 - Export data -Fix "Remove non-local items" option and add "Removes
non-local records" option for existing functionality

It turns out the modules had the option expected  built in, we just didn't call
it. This patch set expands the options for passing to the export.

To test:
1 - Go to Tools->Export data
2 - Perform an export and check 'Remove non-local items'
3 - Note that file contains only 'local' records, but includes all items
on those records
4 - Apply patch
5 - Note Tools->Export data has a new option to remove records not owned
by logged in branch
6 - Export as before checking records option, file should be as before
7 - Now check 'Remove items not owned by logged in branch'
8 - File should now only have local items (may have empty records)
9 - Check both boxes and recieve only 'local' records and items

Signed-off-by: Scott Kehoe 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

Nick Clemens  changed:

   What|Removed |Added

  Attachment #67597|0   |1
is obsolete||

--- Comment #21 from Nick Clemens  ---
Created attachment 68500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68500=edit
Bug 18201 - Unit tests

To test:
1. prove -v t/db_dependent/Exporter/Record.t
2. Tests should pass/be green/make the day a little brighter

Signed-off-by: Scott Kehoe 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18201] Export data -Fix "Remove non-local items" option and add " Removes non-local records" option for existing functionality

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18201

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19526] Unable to upload PDF files to Koha under 856$u

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19526

--- Comment #2 from Emmanuel Pandula  ---
Created attachment 68498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68498=edit
Koha version etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

M. Tompsett  changed:

   What|Removed |Added

  Attachment #65356|0   |1
is obsolete||

--- Comment #14 from M. Tompsett  ---
Created attachment 68496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68496=edit
Bug 19008 - More database cleanups - item transfers

misc/cronjobs/cleanup_database.pl provides some database cleanup.
Yet some tables that could need cleanup are not in this script.

This patch adds cleanup for branchtransfers table.

Test plan :
- Count : select count(*),datearrived from branchtransfers group by
datearrived;
- Run cleanup : misc/cronjobs/cleanup_database.pl -v --transfers 30
- Recount

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

M. Tompsett  changed:

   What|Removed |Added

  Attachment #65355|0   |1
is obsolete||

--- Comment #13 from M. Tompsett  ---
Created attachment 68495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68495=edit
Bug 19008 - More database cleanups - old reserves

misc/cronjobs/cleanup_database.pl provides some database cleanup.
Yet some tables that could need cleanup are not in this script.

This patch adds cleanup for old_reserves table.

Test plan :
- Count : select count(*),date(timestamp) from old_reserves group by
date(timestamp);
- Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-reserves 30
- Recount

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19526] Unable to upload PDF files to Koha under 856$u

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19526

--- Comment #1 from Emmanuel Pandula  ---
Created attachment 68497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68497=edit
Error message screenshot

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

M. Tompsett  changed:

   What|Removed |Added

  Attachment #65352|0   |1
is obsolete||

--- Comment #10 from M. Tompsett  ---
Created attachment 68492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68492=edit
Bug 19008 - More database cleanups - deleted catalog

misc/cronjobs/cleanup_database.pl provides some database cleanup.
Yet some tables that could need cleanup are not in this script.

This patch adds cleanup for deleted catalog tables.
Note that deletedbiblio_metadata is managed by foreign key on biblionumber.

Test plan :
- Count :
select count(*),year(timestamp) from deleteditems group by year(timestamp);
select count(*),year(timestamp) from deletedbiblio group by year(timestamp);
select count(*),year(timestamp) from deletedbiblioitems group by
year(timestamp);
- Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-catalog 30
- Recount

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

M. Tompsett  changed:

   What|Removed |Added

  Attachment #65354|0   |1
is obsolete||

--- Comment #12 from M. Tompsett  ---
Created attachment 68494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68494=edit
Bug 19008 - More database cleanups - old issues

misc/cronjobs/cleanup_database.pl provides some database cleanup.
Yet some tables that could need cleanup are not in this script.

This patch adds cleanup for old_issues table.

Test plan :
- Count : select count(*),date(timestamp) from old_issues group by
date(timestamp);
- Run cleanup : misc/cronjobs/cleanup_database.pl -v --old-issues 30
- Recount

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

M. Tompsett  changed:

   What|Removed |Added

  Attachment #65351|0   |1
is obsolete||

--- Comment #9 from M. Tompsett  ---
Created attachment 68491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68491=edit
Bug 19008 - More database cleanups - statistics

misc/cronjobs/cleanup_database.pl provides some database cleanup.
Yet some tables that could need cleanup are not in this script.

This patch adds cleanup for statistics table.

Test plan :
- Count statistics : select count(*),date(datetime) from statistics group by
date(datetime);
- Run cleanup : misc/cronjobs/cleanup_database.pl -v --statistics 30
- Recount statistics

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

M. Tompsett  changed:

   What|Removed |Added

  Attachment #65353|0   |1
is obsolete||

--- Comment #11 from M. Tompsett  ---
Created attachment 68493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68493=edit
Bug 19008 - More database cleanups - deleted patrons

misc/cronjobs/cleanup_database.pl provides some database cleanup.
Yet some tables that could need cleanup are not in this script.

This patch adds cleanup for deletedborrowers table.

Test plan :
- Count : select count(*),date(updated_on) from deletedborrowers group by
date(updated_on);
- Run cleanup : misc/cronjobs/cleanup_database.pl -v --deleted-patrons 30
- Recount

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19008] More database cleanups

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19008

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #8 from M. Tompsett  ---
(In reply to Simon Pouchol from comment #7)
> Works as intended for the tables statistics, deleted catalogs, branch
> transfers and deleted patrons (there is a typo in your test plan for this
> one : "- Run cleanup : misc/cronjobs/cleanup_database.pl -v --delete-patrons
> 30" is missing a "d" at --deleted-patrons).

I am tweaking the test plan with this correction.


> AS for the tables old_issues and old_reserves, I couldn't get the test done
> on mysql, the count returns "ERROR 1054 (42S22): Unknown column 'datetime'
> in 'field list'" for both tables. The cleanup seems to be working, but I
> just can't verify it in mysql.

All these were test plan typos, likely caused by cut-and-paste.
Reading the code, they should have been timestamp.
I am tweaking the test plan to match.

The code reads well. Passes Koha QA Test tool.

And while I had no data to actually test the purge, the code ran perfectly
fine. I'm signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19526] New: Unable to upload PDF files to Koha under 856$u

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19526

Bug ID: 19526
   Summary: Unable to upload PDF files to Koha under 856$u
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: emmanuel@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Hi, 

I have been trying to upload pdf files in Koha and have been receiving the
error message "File could not be created. Check permissions." 

I have followed all the steps from the link
http://kohageek.blogspot.com/2015/12/attaching-files-to-catalog-records.html
but I still receive the same error message. No one is able to solve this issue
for quite sometime. Checked all the permissions and settings.

I think there is a bug that is causing this issue.

Koha details:

Version: 17.5.04.000
OS Version: Linux S30320 4.4.0-97-generic
Perl Version: 5.022001
mySql Version: 15.1 Distrib 10.0.31-MariaDB
Apache Version: Apache/2.4.18
Zebra Version: Zebra 2.0.59

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19028] Add 'shelving location' to holdings table in detail page

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19028

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #9 from Jonathan Druart  
---
Why do we have item_shelving_location hidden by default?
If you set OpacLocationOnDetail="on a separate column", it will not be
displayed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16759] Make opac holdings table configurable

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16759] Make opac holdings table configurable

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #18 from Jonathan Druart  
---
(In reply to Nick Clemens from comment #17)
> Created attachment 68465 [details] [review]
> Bug 16759: (followup) Make it work with OpacSeparateHoldings

There is something wrong in this patch:
1. columns_settings.inc of opac and intranet will differ
2. KohaTable will not return an array, that's weird, it should return a table

I think a better way to do that is that add different ids to the table and
instantiate two KohaTable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18355] Permanent location should show with cart location

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #19 from Nick Clemens  ---
If permanent_location is NULL the current location shows in parens

If the current location is not defined in authorised values:
On staff side there is nothing displayed (current behavior on staff sideshows
the code)
On OPAC you get blank parens for null permanent_location


I think the proper logic is:
1 - If permanent location is defined
a - display the description if available, display the code if not
b - display the current location in parens
2 - If permanent location is not defined, but location is defined
a - display the current location description if available, display the code
if not
3 - If neither are defined, show nothing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19513] More changes to MarkIssueReturned.t (after bug 19487)

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19513

--- Comment #2 from Jonathan Druart  
---
Created attachment 68490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68490=edit
Bug 19513: Re-add AnonymousPatron-related tests

These tests are still useful

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #20 from Josef Moravec  ---
Good job Jonathan, just few small things:

1) There is still remaining one column "Notified by" in table on page
branchtransfers (line 41 of branchtransfers.tt", it is using values overdue1,
overdue2, overdue3, which were removed from branchtransfers.pl

2) The column "Overdue status" should be removed too

3) Any owed fees are not shown on pay.pl page

Otherwise it looks good for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

Jon Knight  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||j.p.kni...@lboro.ac.uk

--- Comment #2 from Jon Knight  ---
Patch fails to apply on my Kohadevbox VM and also on the PTFS-E sandbox:

vagrant@kohadevbox:kohaclone(master)$ git bz apply 19280
Bug 19280 - CanBookBeIssued must take a Koha::Patron in parameter

66999 - Bug 19280: Pass a Koha::Patron to CanBookBeIssued

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 19280: Pass a Koha::Patron to CanBookBeIssued
/home/vagrant/kohaclone/.git/rebase-apply/patch:24: trailing whitespace.
  ( $issuingimpossible, $needsconfirmation ) =  CanBookBeIssued( $patron, 
fatal: sha1 information is lacking or useless (C4/Circulation.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 19280: Pass a Koha::Patron to CanBookBeIssued
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-19280-Pass-a-KohaPatron-to-CanBookBeIssued-qZZNx2.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Nick Clemens  changed:

   What|Removed |Added

  Attachment #66133|0   |1
is obsolete||
  Attachment #68476|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 68488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68488=edit
Bug 19038: Remove the OPACShowBarcode syspref

Followed test plan and works as expected. Functionality of patch from bug 16759
appears intact too.

Signed-off-by: Dilan Johnpullé 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

--- Comment #7 from Nick Clemens  ---
Created attachment 68489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68489=edit
Bug 19038: QA Followup - Hide barcode column by default (as syspref default is
hide)

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #26 from Jonathan Druart  
---
With CardnumberLength=16, if I enter a 16 chars length string, I get the
warning.
It should display only if > 16, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19461] Add floating toolbar to staff client catalog search results

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19461

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68277|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19461] Add floating toolbar to staff client catalog search results

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19461

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
  Attachment #68093|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #131 from Tomás Cohen Arazi  ---
Created attachment 68487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68487=edit
Bug 7317: Adjust packages koha-conf.xml

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

--- Comment #5 from Tomás Cohen Arazi  ---
(In reply to Nick Clemens from comment #4)
> I think this one is good, however, what I see is that the upgrade is odd.
> 
> If you have set columns configuration already, this won't set it regardless
> of syspref so if pref is set to "Don't show" and columns setting is set to
> show barcode then after this patch the column will show(it was hidden before)
> 
> I don't know if this matters if both bugs are pushed to same version, can
> you answer Tomas?

This is a followup bug for 16759 and is intended to be pushed along with it.
There shouldn't actually exist column settings when the upgrade is done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #130 from Tomás Cohen Arazi  ---
Created attachment 68485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68485=edit
Bug 7317: (followup) Migrate endpoint to OpenAPI

This patch moves the current endpoint implementation from Swagger2 to
the OpenAPI plugin.

It also takes advantage of the overloaded Koha::Illrequest::TO_JSON method
which has now the option to embed what's needed for the REST api.

The path spec is adjusted to fit OpenAPI, and some minor fixes are
applied:
- Missing 'metadata' query param
- 'ill' permissions should be required instead of 'borrowers'
- Full test coverage

To test:
- Apply  this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/api/v1/illrequests.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #129 from Tomás Cohen Arazi  ---
Created attachment 68484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68484=edit
Bug 7317: Overload Koha::Illrequest::TO_JSON

This patch implements an overloaded TO_JSON method, that introduces
the option to (selectively) embed information required on the REST
api.

Tests are included for the new method.

To test:
- Apply this patch
- Run:
  $ kshell
 k$ prove t/db_dependent/Illrequests.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #128 from Tomás Cohen Arazi  ---
Created attachment 68483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68483=edit
Bug 7317: (QA folowup) 404 if module is disabled (intranet)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68445|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68444|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #19 from M. Tompsett  ---
Code changes read okay.
But given that I don't know how to trigger all the changes, I'm not going to
sign off. I'll leave that for someone else more fearless.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #20 from Jonathan Druart  
---
(In reply to Séverine Queune from comment #0)
>   - set the field “items.notforloan” or “items.itemlost” (define in a system
> preference) from “0” to a value from the same ‘authorized values list’ and
> set in another system preference

I do not know what is better here. Do we need 2 more sysprefs? Only 1 with a
YAML syntax?
Or we can also display the LOST authorised values on the "Holds awaiting
pickup" page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #19 from Jonathan Druart  
---
Hi Sally and Séverine,

(In reply to Sally Healey from comment #17)
> How does this interact with system preference
> ExpireReservesMaxPickUpDelayCharge/WaitingHoldCancelationFee ?

The pref ExpireReservesMaxPickUpDelayCharge is only used by the cronjob
cancel_expired_holds.pl. No cancellation fees are charged from this form.

> Also, this might be out of the scope of this bug (maybe a new bug?) but in a
> similar scenario:
> 
> Patron visits library to collect item.
> Item is missing.
> Staff marks item as lost.
> Patron still wants the item, so a new hold needs to be placed.  
> 
> Is it possible to retain the original hold so another copy can fill the
> request instead of cancelling it?

I would consider this as another enhancement indeed. However I do not think it
is linked directly to this one particularly.


(In reply to Séverine Queune from comment #18)
> I now have a button "Mark item as lost", thanks !
> 
> Behaviour is correct also for the "Holds waiting over" tab, except for the
> last and, to me, the main part of this patch : items are supposed to be
> marked as lost and not be available, but they are not.
> 
> This is one of the enhancement we ask for, as you can see on the third point
> of the description of this ticket :
> >- "set the field “items.notforloan” or “items.itemlost” (define in a system
> > preference) from “0” to a value from the same ‘authorized values list’ and 
> > set
> > in another system preference").
> 
> Dis I misunderstood something in you're comment #16 ?

Nope, I completely forgot that part sorry. I will try to provide a fix soon.

> I open ticket #19500 about the name of the module.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17381] Add system preference SCOMainUserBlock

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17381

Nick Clemens  changed:

   What|Removed |Added

  Attachment #66322|0   |1
is obsolete||

--- Comment #12 from Nick Clemens  ---
Created attachment 68481
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68481=edit
Bug 17381: Add system preference SCOMainUserBlock

This patch adds a system preference SCOMainUserBlock to display custom HTML
on the self checkout page.

To test:
- Set up self checkout (see section Self Checkout in Circulaton sysprefs )
- Apply patch
- Update db
- Add some HTML system preference SCOMainUserBlock
- Go to sco page
- Verify that HTML displays on page (logged in and not logged in)

New version based on Koha.Preference TT plugin as of comment #7
Depends on Bug 12691

Signed-off-by: Josef Moravec 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #18 from Jonathan Druart  
---
Created attachment 68480
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68480=edit
Bug 10021: Remove accountlines columns - DBIC Schema changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #17 from Jonathan Druart  
---
Created attachment 68479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68479=edit
Bug 10021: Update DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #16 from Jonathan Druart  
---
Created attachment 68478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68478=edit
Bug 10021: Drop columns notify_id and notify_level from accountlines

It appears that has never worked.
Could someone confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68419|0   |1
is obsolete||
  Attachment #68420|0   |1
is obsolete||
  Attachment #68421|0   |1
is obsolete||
  Attachment #68422|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  
---
Created attachment 68477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68477=edit
Bug 10021: Drop table notifys and related code

This patch drops the notifys table and its related code in C4::Overdues.
A second patch should remove the 2 columns notify_id and notify_level
from the accountlines table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19525] New: Bulk-add patrons to a list

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19525

Bug ID: 19525
   Summary: Bulk-add patrons to a list
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: je...@bywatersolutions.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Some libraries would like to have the ability to add patrons to lists in bulk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19524] New: Share patron lists between staff

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524

Bug ID: 19524
   Summary: Share patron lists between staff
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: je...@bywatersolutions.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Some libraries would like to allow arbitrary lists to be used by all librarians
with the 'manage_patron_lists' permission.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Signed Off  |In Discussion

--- Comment #4 from Nick Clemens  ---
I think this one is good, however, what I see is that the upgrade is odd.

If you have set columns configuration already, this won't set it regardless of
syspref so if pref is set to "Don't show" and columns setting is set to show
barcode then after this patch the column will show(it was hidden before)

I don't know if this matters if both bugs are pushed to same version, can you
answer Tomas?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19038] Remove OPACShowBarcode syspref

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038

--- Comment #3 from Nick Clemens  ---
Created attachment 68476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68476=edit
Bug 19038: QA Followup - Hide barcode column by default (as syspref default is
hide)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13178] cardnumber field length is too short

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com,
   ||tomasco...@gmail.com

--- Comment #20 from Nick Clemens  ---
Looks good here, added the max length to syspref notes so want an opinion on
that

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13178] cardnumber field length is too short

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178

--- Comment #19 from Nick Clemens  ---
Created attachment 68475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68475=edit
Bug 13178: QA Followup - fix kohastructure and update info in fields

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13178] cardnumber field length is too short

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178

--- Comment #18 from Nick Clemens  ---
Created attachment 68474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68474=edit
Bug 13178: Correct Max cardnumberlength

($max is the value of the max size of a card number)
- $max not hardcoded anymore in C4::Memeber
- $max now correctly adapts to the field of cardnumber in database

Signed-off-by: Marc Véron 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13178] cardnumber field length is too short

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178

Nick Clemens  changed:

   What|Removed |Added

  Attachment #64646|0   |1
is obsolete||
  Attachment #64647|0   |1
is obsolete||

--- Comment #17 from Nick Clemens  ---
Created attachment 68473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68473=edit
Bug 13178: increase max value of CardnumberLength

testplan
1 - Apply patch
2 - Run updatedatabase.pl
3 - Update dbix scheme
4 - set the value of CardnumberLength to a value between 16 and 32
5 - Check you can enter a propper cardnumber
(modify to 32 instead 20)

+ max value now depends on the database field value to

Signed-off-by: Marc Véron 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68461|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

--- Comment #15 from Marcel de Rooy  ---
Well, too bad performance wise. Push it without that follow-up..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

--- Comment #14 from Marcel de Rooy  ---
(In reply to Marcel de Rooy from comment #13)
> Oops I see it now

Funny thing is that I didnt see anything particular when testing..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

--- Comment #12 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #11)
> (In reply to Marcel de Rooy from comment #9)
> > Created attachment 68461 [details] [review] [review]
> > Bug 19298: (QA follow-up) Remove GetBiblioData call
> > 
> > In order to do at least something for performance, we could replace
> > the call to GetBiblioData since we are already fetching biblio data
> > with Koha::Biblios.
> 
> GetBiblioData also returns biblioitems fields, and the template uses them.
> At least publishercode, place, publicationyear, pages, notes, etc.

my $query = " SELECT * , biblioitems.notes AS bnotes, itemtypes.notforloan
as bi_notforloan, biblio.notes
FROM biblio
LEFT JOIN biblioitems ON biblio.biblionumber =
biblioitems.biblionumber
LEFT JOIN itemtypes ON biblioitems.itemtype = itemtypes.itemtype
WHERE biblio.biblionumber = ?";

Please explain.
See my commit message too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

--- Comment #13 from Marcel de Rooy  ---
Oops I see it now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19298] allow_onshelf_holds is not calculated correctly in opac-shelves

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19298

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off

--- Comment #11 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #9)
> Created attachment 68461 [details] [review]
> Bug 19298: (QA follow-up) Remove GetBiblioData call
> 
> In order to do at least something for performance, we could replace
> the call to GetBiblioData since we are already fetching biblio data
> with Koha::Biblios.

GetBiblioData also returns biblioitems fields, and the template uses them.
At least publishercode, place, publicationyear, pages, notes, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19431] Error when trying to checkout an unknown barcode

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19431

--- Comment #17 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #15)
> (In reply to Jonathan Druart from comment #14)
> > UNKNOWN_BARCODE is the one we need to add to fix this bug.
> 
> Hmm I never thought of that ;)
> I am not blocking this patch but I raised a valid question and got no answer.

To be honest I have no idea what we need to do more. The subroutine and the
script are very ugly and need a full refurnish to be readable and less
error-prone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber

2017-10-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 163 matches

Mail list logo