[Koha-bugs] [Bug 19543] New: Sistema não faz reserva de item caso tenha algum disponível em outra biblioteca.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19543 Bug ID: 19543 Summary: Sistema não faz reserva de item caso tenha algum disponível em outra biblioteca. Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cristianbib...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 68792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68792&action=edit Erro na reserva quando há itens disponíveis em outra biblioteca Mesmo após configurar o sistema para reservar itens quando todos estiverem emprestados, o Koha não reserva caso tenha um item disponível em outra biblioteca do sistema. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18483] Customised help: Enhance staff client with news based, easily editable help system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18483 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||katrin.fisc...@bsz-bw.de Status|Passed QA |In Discussion --- Comment #25 from Jonathan Druart --- I still think it is not a good idea to hijack the news feature for the help editing. We are currently working on the manual and its translation. We already thought a bit about how we can stop duplicating the manual (the website and the help files inside Koha). An idea would be to link to the k-c.org manual from Koha (with the ability to link to a local git repository, a syspref/config would link to a local path). We could then imagine an editor to update the manual, inside Koha (the changes could be made adding commits to the git repository for the local changes a library made). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18267] Update price and tax fields in EDI to reflect DB changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18267 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #35 from Jonathan Druart --- Lack of tests and POD coverage. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15565] Place multiple holds at once for the same record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #65 from Jonathan Druart --- Undefined subroutine &CGI::Compile::ROOT::home_vagrant_kohaclone_opac_opac_2dreserve_2epl::GetBiblionumberFromItemnumber called at /home/vagrant/kohaclone/opac/opac-reserve.pl line 244. This subroutine has been removed on bug 18277. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Dominic Pichette changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15486] Restrict number of holds placed by day
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 --- Comment #43 from Dominic Pichette --- Created attachment 68791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68791&action=edit Bug 18282: operationId must be unique operationId has the following documentation: "Unique string used to identify the operation. The id MUST be unique among all operations described in the API." This patch modifies operationIds to be unique accross our API operations. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Dominic Pichette -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Holds history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Eric Bégin changed: What|Removed |Added CC||eric.be...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19456] Some pages title tag contains html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456 David Bourgault changed: What|Removed |Added CC||david.bourga...@inlibro.com --- Comment #9 from David Bourgault --- Worked as planned, QA tool green across the board. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19456] Some pages title tag contains html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456 David Bourgault changed: What|Removed |Added Attachment #68787|0 |1 is obsolete|| --- Comment #8 from David Bourgault --- Created attachment 68790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68790&action=edit Bug 19456: Make patron-title ability to be generated with or without html tags Modified pages: circ/circulation.pl circ/circulation_batch_checkouts.pl members/boraccount.pl members/files.pl members/holdshistory.pl members/housebound.pl members/moremember.pl members/notices.pl members/purchase-suggestions.pl members/readingrec.pl members/routing-lists.pl members/statistics.pl Test plan: 0) Do not apply the patch 1) Have a patron with title/salution filled in 2) Confirm bug, go for example to circ/circulation page and see there is html in tag (you can see it in your browser page/window title) 3) Apply the patch 4) Go through circulation/patron pages (see modified page above) and confirm there is no html in tag, but on the page itself the salutation should be in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19456] Some pages title tag contains html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456 David Bourgault changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited' values produces invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539 David Bourgault changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19539] Editing rules that contain 'Unlimited' values produces invalid data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19539 David Bourgault changed: What|Removed |Added Attachment #68719|0 |1 is obsolete|| --- Comment #2 from David Bourgault --- Created attachment 68789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68789&action=edit Bug 19539: Fix column index shift in cirulation rules This patch fixes an index shift introduced by bug 18857 when it introduced a new column. To test: - On the Circulation and fine rules page - Empty the value of 'Current on-site checkouts allowed' and save - Notice 'Unlimited' shows on the saved rule. - Click edit => FAIL: the 'Unlimited' string displays instead of the empty string on the editing row. - Apply this patch - Re-open the circ rules page - Click edit => SUCCESS: An empty string fills the 'Unlimited' fields - Sign off :-D Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for sorting in mappings.yaml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 David Bourgault changed: What|Removed |Added CC||david.bourga...@inlibro.com --- Comment #4 from David Bourgault --- Test worked as planned, however sorting by title and author seemed strange. I assume the issue wasn't introduced by this bug, but looking at the results list, it did not seem alphabetical to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for sorting in mappings.yaml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 David Bourgault changed: What|Removed |Added Attachment #68241|0 |1 is obsolete|| --- Comment #3 from David Bourgault --- Created attachment 68788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68788&action=edit Bug 19481 - Set default sort options as sortable in ES default mappings To test: 1 - Setup Koha with ES 2 - perform a search 3 - try sorting by pubdate, acqdate, popularity, or title 4 - Search fails! 5 - Apply patch 6 - visit: /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 7 - Re-index ES 8 - Perform search 9 - All sorting options should work Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for sorting in mappings.yaml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481 David Bourgault changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Holds history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Josef Moravec changed: What|Removed |Added Text to go in the||This enhancement adds new release notes||page called "Holds ||history". The page is ||accessible from left menu ||on every patron related ||page. It allows librarians ||to see the history of all ||holds of given patron, with ||the actual status. It could ||be useful especially when ||the hold is cancelled. ||Before this patch the hold ||just disappeared when ||cancelled (automatically or ||manually). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19456] Some pages title tag contains html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456 Josef Moravec changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Josef Moravec --- (In reply to Jonathan Druart from comment #5) > 1/ QA script detected a missing % > FAIL > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt >FAIL valid_template > parse error - > /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/circ/ > circulation_batch_checkouts.tt line 109: unexpected token (]) > [% INCLUDE 'patron-title.inc' invert_name = 1 use_html = 1 ] [% END %] > Fixed in new patch, now it passes qa tools > > 2/ So basically we want use_html everywhere but in title tags, right? > If this is correct, I would prefer to do the reverse: add a do_not_use_html > flag when patron-title.inc is used in title tags. That could be easily > caught with `git grep patron-title.inc|grep ''` You are right, the ratio is 23 in page content versus 12 in title tag I changed it. Followup would rewrite almost everything anyway, so I decided to make new patch and ask again for sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19456] Some pages title tag contains html
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19456 Josef Moravec changed: What|Removed |Added Attachment #68702|0 |1 is obsolete|| --- Comment #6 from Josef Moravec --- Created attachment 68787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68787&action=edit Bug 19456: Make patron-title ability to be generated with or without html tags Modified pages: circ/circulation.pl circ/circulation_batch_checkouts.pl members/boraccount.pl members/files.pl members/holdshistory.pl members/housebound.pl members/moremember.pl members/notices.pl members/purchase-suggestions.pl members/readingrec.pl members/routing-lists.pl members/statistics.pl Test plan: 0) Do not apply the patch 1) Have a patron with title/salution filled in 2) Confirm bug, go for example to circ/circulation page and see there is html in tag (you can see it in your browser page/window title) 3) Apply the patch 4) Go through circulation/patron pages (see modified page above) and confirm there is no html in tag, but on the page itself the salutation should be in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19377] Remove $5 charge from sample item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19400] Reminder to unset gone no address flag after patron makes a modification request
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19400 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19274] Translatability: Fix new splitting problems related to database warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19274 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19231] No warning of number of attached items when deleting a course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19212] Warns when asking for a discharge OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19212 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19022] inventory location and author display
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19022 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19021] Inventory column sorting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19021 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18920] Some config values are not saved in koha-install-log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18920 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17039] No cancel/new item option when editing an item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17039 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Holds history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #41 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13796] Alert in OPAC when renewing an item with a rental charge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13796 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #33 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #46 from Jonathan Druart --- Reviewed on top of bug 10306 1/ I always though we would need to fix the mapping at some point, and make it use the correct template. Here we are moving the other way around. Does that mean we should move the mapping out of the framework tables? 2/ return wantarray ? @retval : ( @retval ? $retval[0] : undef ); This is not necessary, do not do that please. Caller can do my ( $v ) = the_sub(); Not blocker. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15650] Credit Card Payment development other than Paypal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15650 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18820] The different parts in the main don' t automatically adjust with the available space.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Owen Leonard changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #17 from Owen Leonard --- I'm not sure if this is something I missed or if this is a new problem, but with opacuserlogin off OpacNavRight is misplaced. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4319] waiting items cannot be reserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Charles Farmer changed: What|Removed |Added Attachment #68782|0 |1 is obsolete|| --- Comment #53 from Charles Farmer --- Created attachment 68786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68786&action=edit Bug 4319 - [OPAC] allow to holds waiting items Test plan: - Checkout an item - Place hold on this item, - Return the item - Make sure the hold is waiting (found W) and AllowOnShelfHolds is not to 'Allow' - Check that the button "Place hold" appears in opac detail page of the biblio - do the samewith items/reserves in transit Changes on C4::Reserves::IsAvailableForItemLevelRequest Make sure this tests pass: - t/db_dependent/Reserves.t - t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t Signed-off-by: Charles Farmer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4319] waiting items cannot be reserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Charles Farmer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 --- Comment #18 from Dominic Pichette --- Created attachment 68785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68785&action=edit the string failed to be translated... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522 Dominic Pichette changed: What|Removed |Added CC||dominic.piche...@inlibro.co ||m --- Comment #17 from Dominic Pichette --- Doesn't seem to work. Maybe the translated string is only present in your .po? You can take a look at the screenshot I took : fr-FR.png -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19377] Remove $5 charge from sample item types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19377 --- Comment #11 from Jonathan Druart --- Created attachment 68784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68784&action=edit Bug 19377: (follow-up) Remove charge for 'books' in ru-RU sample data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19542] Koha should display Elasticsearch information in the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542 Tomás Cohen Arazi changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19542] New: Koha should display Elasticsearch information in the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542 Bug ID: 19542 Summary: Koha should display Elasticsearch information in the about page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19231] No warning of number of attached items when deleting a course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19231 --- Comment #7 from Jonathan Druart --- Created attachment 68783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68783&action=edit Bug 19231: No need to pass the size to the template We have the array already, we just need to call .size on it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4319] waiting items cannot be reserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Charles Farmer changed: What|Removed |Added Attachment #68531|0 |1 is obsolete|| --- Comment #52 from Charles Farmer --- Created attachment 68782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68782&action=edit Bug 4319 - [OPAC] allow to holds waiting items Test plan: - Checkout an item - Place hold on this item, - Return the item - Make sure the hold is waiting (found W) and AllowOnShelfHolds is not to 'Allow' - Check that the button "Place hold" appears in opac detail page of the biblio - do the samewith items/reserves in transit Changes on C4::Reserves::IsAvailableForItemLevelRequest Make sure this tests pass: - t/db_dependent/Reserves.t - t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4319] waiting items cannot be reserved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Charles Farmer changed: What|Removed |Added CC||charles.far...@inlibro.com --- Comment #51 from Charles Farmer --- Patch didn't apply smoothly: the template variable OPACShowBarcode disappeared from opac/opac-detail.pl. Resubmitting a corrected version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18820] The different parts in the main don' t automatically adjust with the available space.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #16 from Jonathan Druart --- I need another confirmation. Before the patch: https://screenshots.firefox.com/i220lvWCoUM1Mlf8/catalogue.kohadev.org After the patch: https://screenshots.firefox.com/PBXfxyLVaP1tHIXm/catalogue.kohadev.org Could you confirm it is what we want? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Holds history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19069] "Doesn't match" option fails in MARC Modification Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19069 --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #14) > Created attachment 68781 [details] [review] > Bug 19069: (follow-up) Remove perlcritic error > > Subroutine prototypes used at line 6, column 1. See page 194 of PBP. > (Severity: 5) Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19069] "Doesn't match" option fails in MARC Modification Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19069 --- Comment #14 from Jonathan Druart --- Created attachment 68781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68781&action=edit Bug 19069: (follow-up) Remove perlcritic error Subroutine prototypes used at line 6, column 1. See page 194 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11210] Allow partial writeoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11210] Allow partial writeoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210
--- Comment #6 from Jonathan Druart
---
Comment on attachment 68754
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68754
Bug 11210 - Writeoff partial amounts
Review of attachment 68754:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11210&attachment=68754)
-
::: koha-tmpl/intranet-tmpl/prog/en/modules/members/paycollect.tt
@@ +191,5 @@
> +
> +
> +Writeoff amount:
> +
> + value="[% amountoutstanding | format('%.2f') %]" />
No, price values must not be formatted when displayed in inputs.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12363] Marking an item as lost in koha always returns it, but longoverdue.pl may not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12363 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Holds history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19541] Remove notifiactiondate and reminderdate from reserves/ old_reserves tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19541 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED CC||jonathan.dru...@bugs.koha-c ||ommunity.org Resolution|--- |INVALID --- Comment #1 from Jonathan Druart --- Done in a follow-up for bug 14919. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Holds history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Jonathan Druart changed: What|Removed |Added Attachment #68756|0 |1 is obsolete|| --- Comment #39 from Jonathan Druart --- Created attachment 68780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68780&action=edit Bug 14919: Remove notificationdate and reminderdate These columns are not used, we do not need to display them -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14919] Holds history for patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 --- Comment #40 from Jonathan Druart --- (In reply to Josef Moravec from comment #38) > (In reply to Jonathan Druart from comment #36) > > Great job Josef! > > > > It seems that notificationdate and reminderdate are not used, why do you > > want to display them? :) > > I wanted to remove it completely on another report... > > But for now I've just added followup to make these two column hidden by > default. No need to wait, done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19333] XSS vulnerability in opac-shelves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19333 Jonathan Druart changed: What|Removed |Added Component|Koha|Architecture, internals, ||and plumbing Product|Koha security |Koha Group|Koha security | Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18956] Possible privacy breach with OPAC password recovery
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18956 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master Product|Koha security |Koha Group|Koha security | Component|Koha|Architecture, internals, ||and plumbing --- Comment #25 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19117] paycollect.pl is vulnerable for CSRF attacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19117 Jonathan Druart changed: What|Removed |Added Product|Koha security |Koha Group|Koha security | Status|Passed QA |Pushed to Master Component|Koha|Architecture, internals, ||and plumbing --- Comment #9 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9031] Overdue items crossing DST boundary throw invalid local time exception
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9031 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #26 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18389] Allow using MARC modification templates in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 --- Comment #30 from Jonathan Druart --- Note: I did not catch before the wrong bug number in the commit message. It has been pushed with "bug 18690: ". Please do not be dyslexic with bug numbers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #23 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19531] When editing patrons without circulation permission redirect should be to the patron 's detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19531 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19528] Fixing a few typos like corrosponding
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19528 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19493] Remove few warnings from circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19493 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19503] Duplicating a dropdown menu subfield yields an empty subfield tag
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19503 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19484] Checkout page does not like itemtype NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19484 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19443] Error while attempting to duplicate a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19443 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19462] Add a koha-elasticsearch command
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19462 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #12 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19389] Don' t offer search option for libary groups when no groups are defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19389 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19216] Patron clubs table has an empty column in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19216 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19069] "Doesn't match" option fails in MARC Modification Templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19069 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19178] Remove outdated sms/* scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19178 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19029] Implement a security question for cloning circulation conditions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19029 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #19 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18884] Advanced search on staff client, Availability limit not properly limiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18884 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18389] Allow using MARC modification templates in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18389 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #29 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18118] Unexpected behaviour with 'GoogleOpenIDConnect' and ' OpacPublic' syspref combination
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18118 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17467] There should be a koha-zebra script to handle Zebra daemons for instances
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17467 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #28 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17214] Add records to lists by biblio number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17214 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #24 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16899] Add ability to disallow overpayments via SIP
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16899 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16660] Elasticsearch broken if OpacSuppression is activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16660 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #18 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19493] Remove few warnings from circulation.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19493 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #25 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12363] Marking an item as lost in koha always returns it, but longoverdue.pl may not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12363 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #34 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 --- Comment #3 from Kyle M Hall --- Editing fines should create account offsets to reflect the change in amount to a fine if applicable. It would also be nice if the code use Koha::Account::Line(s) instead of direct sql. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16820] add possibility to edit fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18128] 'Go to page' option for search results in opac and staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA CC||katrin.fisc...@bsz-bw.de, ||oleon...@myacpl.org --- Comment #15 from Jonathan Druart --- I see only 1 page, maybe I messed up the rebase. (In reply to Nick Clemens from comment #11) > Created attachment 68326 [details] [review] > Bug 18128: [FOLLOW-UP] Some display fixes > > This patch addresses some of the display issues brought up in Comment 6. > > The dropdown list should now include every page number. > The bar will only show up to 5 page numbers on each side of the current > active page. Why? 10 was good number IMO. I'd like more opinion about this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 --- Comment #41 from Kyle M Hall --- Created attachment 68775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68775&action=edit Bug 19096: Adjusts unit tests The subroutines listed in the former patch are extensively tested in Biblio.t, TransformKohaToMarc.t and TransformMarcToKoha.t. These tests do no longer use new frameworks to add mappings. In Biblio.t and TransformMarcToKoha.t we also test passing an individual framework code (for an empty framework) to see if Default is still used. Note that this parameter will be removed later on. In Items.t the cache keys MarcStructure-0- and MarcStructure-1- are not touched, so they do not need to be cleared. The cache key default_value_for_mod_marc- should be used without framework now. Similar adjustments in Items/AutomaticItemModificationByAge.t and Reserves.t. Furthermore the subtest for _build_default_values_for_mod_marc in Items.t is adjusted since framework is no longer relevant. The biblio record with items is created in a new framework, but the mappings from Default are consulted. Test plan: Run all adjusted unit tests. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 --- Comment #43 from Kyle M Hall --- Created attachment 68777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68777&action=edit Bug 19096: Online help changes On the page admin/marc_subfields_structure we now tell that Koha link has been disabled and refer to the help for koha2marclinks. On the page admin/koha2marclinks we mention that the Default mapping is considered authoritative now. Test plan: Read these online help pages and verify that the changes make sense. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 --- Comment #45 from Kyle M Hall --- Created attachment 68779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68779&action=edit Bug 19096: Add dbrev to sync kohafield in all frameworks The dbrev will use two new routines in MarcSubfieldStructures: [1] get_kohafield_exceptions is used to report deviating kohafields in the additional frameworks, [2] sync_kohafield is used to reset kohafield in the other frameworks to the mapping in Default. Test plan: Unit test and database revision: [1] Run t/db_dependent/Koha/MarcSubfieldStructures.t [2] Verify that your Default 100a is mapped to biblio.author. Go to another framework and clear the mapping via mysql command line: UPDATE marc_subfield_structure SET kohafield=NULL WHERE frameworkcode=[your_framework] AND tagfield='100' AND tagsubfield='a'; [3] Run the db revision. It should report that 100a was adjusted. [4] Check in admin/marc_subfield_structure that your 100a is mapped to biblio.author again in that framework. Additional interface testing (ensuring that the changes on this report do not interfere with multiple mappings): [5] Make two mappings for copyrightdate: 260c and 264a. And make two mappings for biblioitems.pages: 300a and say 300g. Toggle with some field values in those fields in the cataloging editor and verify the contents of biblio.copyrightdate and biblioitems.pages. The former should contain one year (due to additional logic) and the latter should contain A | B if both fields are filled. Remove the mapping for 300g. [6] Set AcqCreateItem to ordering or placing. Verify that you can still add or receive an order as usual. [7] Add a mapping for itemcallnumber to 952f (this should remove the one for coded_location_qualifier). This is very unusual but serves well in testing multiple mappings for items. Add or receive an order (fill 952f and 952o) with same and/or different values. Verify the contents of items.callnumber. (Check with regular item editor; see note.) Do a similar edit in the regular item editor. Note: You should expect to see A | B in both 952f and 925o if both fields are filled with a different value. Set items.coded_location_qualifier back to 952f in koha2marclinks. Note: When AcqCreateItem==ordering, you will not see A|B in the callno field when adding an item on neworderempty.pl. But when you submit the main form, addorder.pl is called. At that time an item is created and you will see that A|B is in both fields (952f and 952o). Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 --- Comment #44 from Kyle M Hall --- Created attachment 68778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68778&action=edit Bug 19096: Restructure MarcSubfieldStructures.t first Before adding more tests, move all current tests in one subtest. Test plan: Run t/db_dependent/Koha/MarcSubfieldStructures.t Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 --- Comment #42 from Kyle M Hall --- Created attachment 68776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68776&action=edit Bug 19096: Do not allow changes to kohafield within MARC frameworks This patch makes two changes in the script for managing the MARC frameworks in order to support making the Default authoritative as for Koha to MARC mappings: [1] Disable the kohafield select combo. Add a hidden input to save value. [2] When a new subfield is added, the kohafield is still empty and should be overwritten with its Default counterpart. Note: Although we could leave the field empty, since Koha looks at the Default framework only, it does not cost much to keep these fields in sync with Default and perhaps catch a bug when someone somewhere looks in the wrong framework. Note: The description of Koha to MARC mapping on admin-home has been adjusted accordingly (removing last two lines). Test plan: [1] Add a new tag and subfield in Default. [2] Map it to a kohafield in koha2marclinks.pl [3] Add the same tag and subfield in another framework. Verify that the kohafield is updated after you saved the subfield. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 Kyle M Hall changed: What|Removed |Added Attachment #68205|0 |1 is obsolete|| Attachment #68206|0 |1 is obsolete|| Attachment #68207|0 |1 is obsolete|| Attachment #68208|0 |1 is obsolete|| Attachment #68209|0 |1 is obsolete|| Attachment #68210|0 |1 is obsolete|| --- Comment #40 from Kyle M Hall --- Created attachment 68774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68774&action=edit Bug 19096: Make Default authoritative in core modules After feedback from the dev mailing list, it seems appropriate here to propose making the Default framework authoritative for Koha to MARC mappings. This implies checking only the Default framework in the routines: [1] GetMarcFromKohaField: The parameter frameworkcode is removed. A follow-up report (19097) will update the calls not adjusted here. This is safe since the parameter is silently ignored. [2] GetMarcSubfieldStructureFromKohaField: Framework parameter is removed and calls are adjusted. Includes acquisitions_stats.pl. [3] TransformKohaToMarc: The parameter is removed; all calls are verified or adjusted. [4] TransformMarcToKoha: The parameter is no longer used and will be removed in a follow-up report (19097). It always goes to Default now. [5] TransformMarcToKohaOneField: The parameter is removed and all calls are adjusted. Including: Breeding, XISBN and MetadataRecord modules. [6] C4::Koha::IsKohaFieldLinked: This routine was called only once (in C4::Items::_build_default_values_for_mod_marc. It can be replaced by calling GetMarcFromKohaField. If there is no kohafield linked, undef is returned. (Corresponding unit test is removed here.) [7] C4::Items::ModItemFromMarc: The helper routine _build_default_values_for_mod_marc does no longer have a framework parameter. The cache key default_value_for_mod_marc- is no longer combined with a frameworkcode. Three admin scripts are adjusted accordingly; some tests will be corrected in the next patch. Test plan: See next patch. That patch adjusts all tests involved. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #74 from Kyle M Hall --- Created attachment 68773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68773&action=edit Bug 10306: (QA follow-up) More feedback for admins in koha2marclinks As requested by Tomas, this patch does: [1] Add a js alert when you did not type field,subfield [2] Print a yellow alert div when the field,subfield is not found. [3] Bonus: Make it little bit more secure by demanding a POST. (Leaving CSRF etc. for another report.) Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #73 from Kyle M Hall --- Created attachment 68772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68772&action=edit Bug 10306: [QA Follow-up] Correct a TestBuilder call In order to create a new framework, MarcSubfieldStructure was used as source. This works since that table contains a FK for frameworkcode. But obviously, we should use BiblioFramework as source. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #72 from Kyle M Hall --- Created attachment 68771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68771&action=edit Bug 10306: Adjusted online help text for koha2marclinks Test plan: Click on Help. Read the text. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #71 from Kyle M Hall --- Created attachment 68770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68770&action=edit Bug 10306: Support for multiple mappings in koha2marclinks This actually refactors koha2marclinks.pl in order to support multiple mappings per kohafield. Instead of three separate mapping pages for biblio, biblioitems and items, the script now lists them together. This gives a complete overview of all mappings rightaway. Changes are applied immediately across all frameworks. Note: This report handles the Default mappings just like it did before. In this script Koha already considered them as authoritative, although other parts of Koha did not. Follow-up report 19096 makes Default mappings authoritative throughout all Koha. On each line two buttons are provided, Add and Remove, in order to add or remove an individual mapping. We do no longer provide a separate form with the names of MARC tags. Since this form is targeted for administrators, it should be enough to ask for a field tag and subfield code. Note: The mappings for biblionumber, biblioitemnumber and itemnumber are so vital that this form marks them as readonly. It is not recommended to change them. Test plan: [1] Add a mapping. Verify via Frameworks or mysql command line that the kohafield is saved to the other frameworks too. [2] Remove the mapping again. Check Frameworks or mysql cl again. [3] Test adding a second mapping. Map copyrightdate to 260c and 264c. And map biblioitems.place to 260a and 264a. [4] Edit biblio record 1: Put 1980 in 260c. Do not include 264c. Edit biblio record 2: Put 1990 in 264c. Do not include 260c. Edit biblio record 3: Put 2000 in both 260c and 264c. Put CityA in 260a and in 264a. Edit biblio record 4: Put 2010 in 260c, and 2015 in 264c (which you should refuse normally). Put CityA in 260a, and CityB in 264a. [5] Create a report that shows biblioitems.place and biblio.copyrightdate for those biblio records. Record 4 should have 2010 in copyrightdate (since TransformMarcToKoha picks the first year for copyrightdate). Record 3 should have place CityA; record 4 should have CityA | CityB. Note: The CityA | CityB example illustrates that we should add some additional handling in TransformMarcToKoha for multiple 264s. [6] Add these four biblio records to a new list. Sort by Year. With OPACXSLTListsDisplay==default, check if the order = 1,2,3,4. (The order is based on biblio.copyrightdate.) Note that (RDA) record 2 would be on top without this patch set, since copyrightdate would have been null. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10306] Koha to MARC mappings (Part 1): Allow multiple mappings per kohafield (for say 260/RDA 264)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 --- Comment #70 from Kyle M Hall --- Created attachment 68769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68769&action=edit Bug 10306: Restructure TransformMarcToKoha and update some POD lines This patch makes the following changes: [1] Added POD for CountItemsIssued, GetBiblioItemData [2] Moved TransformMarcToKohaOneField closer to TransformMarcToKoha (before sub CountItemsIssued) [3] Restructured TransformMarcToKoha by extracting individual kohafields via TransformMarcToKohaOneField. The latter does no longer call the former. This small optimization avoids traversing the whole MARC record again and again. [4] Moved adjusting copyrightdate/publicationyear to separate helper routine _adjust_pubyear [5] Removed obsolete sub _get_inverted_marc_field_map. Test plan: Run t/db_dependent/Biblio/TransformMarcToKoha.t Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
