[Koha-bugs] [Bug 18213] Add language facets to Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18213] Add language facets to Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

--- Comment #7 from Nick Clemens  ---
Created attachment 68945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68945=edit
Bug 18213 - DB Update (facet order)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18213] Add language facets to Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

--- Comment #8 from Nick Clemens  ---
Created attachment 68946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68946=edit
Bug 18213 - Add Template plugin and fix for C4/Languages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18213] Add language facets to Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

Nick Clemens  changed:

   What|Removed |Added

  Attachment #64798|0   |1
is obsolete||
  Attachment #64841|0   |1
is obsolete||
  Attachment #64905|0   |1
is obsolete||

--- Comment #6 from Nick Clemens  ---
Created attachment 68944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68944=edit
Bug 18213 - Add language facets to Elasticsearch

This patch add language as a facet to ES results - it adds
a new template plugin for languages to get the appropriate
description given an iso 639-2 code

To test:
1 - Make sure you have records with differing languages (in the MARC21 008
field characters 35-37 or UNIMARC 101a)
2 - Apply patch
3 - Reload Elasticsearch settings:
http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset_know_what_i_am_doing=1
4 - Reindex your records
5 - Search for a phrase that will return results in several languages
6 - Verify you see factes correctly labelled for 'Language'
7 - Verify the facets work
8 - Verify both opac and staff results
9 - prove t/db_dependent/Languages.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #17 from Nick Clemens  ---
(In reply to Caroline Cyr La Rose from comment #16)
> I want this so much to work! I've been asked for this many many times!
> 
> But I got a software error.
> 
> BIx::Class::Storage::DBI::_dbh_execute(): Table
> 'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at
> /inlibro/git/koha-master-dev-inlibro/Koha/Object.pm line 121
> 
> Plus the prove -v ... returned red.

HI Caroline, Did you run the database updates? It looks like the tables
introduced in this patchset have not been created.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

--- Comment #8 from Nick Clemens  ---
(In reply to David Bourgault from comment #7)
> Is there a step missing form the test plan? I applied the patch, change my
> Circulation rules to set no holds for All/All (I have no other rules for my
> test patron's category) and tried to place a hold but got the message "No
> available items.", but I can see it as available on the OPAC detail page.

Sorry, I did miss a detail, this patch only affects the staff side, not the
OPAC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

--- Comment #8 from Nick Clemens  ---
(In reply to David Gustafsson from comment #4)
> Would be nice if "." could as be included as a valid field characters, since
> it is used for subfields in Elasticsearch. ("Control-number.raw" for
> example).

This could be done, opening a new bug 19580

We may need more adjustments to when we do and do not truncate/split

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Nick Clemens  changed:

   What|Removed |Added

 Blocks||19580


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580
[Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting
character in autotruncation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 Depends on||19559


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559
[Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens
if data is quoted
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

--- Comment #2 from Nick Clemens  ---
Created attachment 68943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68943=edit
Bug 19580: Exclude period as splitting character for autotrunction

To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number.raw:"4"' (or a vlid biblionumber)
7 - should get expected result

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

--- Comment #1 from Nick Clemens  ---
Created attachment 68942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68942=edit
Bug 19580: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] New: Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

Bug ID: 19580
   Summary: Elasticsearch: QueryAutoTruncate exclude period as
splitting character in autotruncation
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #13 from Nick Clemens  ---
(In reply to Marcel de Rooy from comment #11)
> Upload local cover image
> Upload status: Failed - (2) Root directory for uploads not defined
> No, the directory was not writable.
> This went wrong since the errcode is 2, but you forgot to add a zero entry
> in you errMsgs array. So they are one position out of sync.
> Please add a leading entry here (see also upload.tt)
> var errMsgs = [ _("File already exists"), _("Directory is not writeable"),
> _("Root directory for uploads not defined"), _("Temporary directory for
> uploads not defined") ];
> Adjust same thing in two other places ?
Adjusted :-)

> 
>  //Next three errors have no code path to trigger that I see
> I am very confident that I tested all codes when I wrote this. They may be
> hard to simulate, but I did. Please remove this comment.

Removed, I though we only passed 1-4 back in the pm file, my apologies

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68910|0   |1
is obsolete||

--- Comment #12 from Nick Clemens  ---
Created attachment 68941
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68941=edit
Bug 19420 - Add errors on other pages

Fix error array (add '0' value)
Update errors on other places using upload.js

Eventually these should all be using the same code in a js file

upload.tt already dealt with these errors, but has diff code, made it
work with new error syntax

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19579] PatronSelfRegistrationEmailMustBeUnique does not prevent duplicates when using PatronSelfRegistrationVerifyByEmail

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19579

BASE Library Consortium  changed:

   What|Removed |Added

 CC||baselibrary.consortium@nhs.
   ||net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19579] New: PatronSelfRegistrationEmailMustBeUnique does not prevent duplicates when using PatronSelfRegistrationVerifyByEmail

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19579

Bug ID: 19579
   Summary: PatronSelfRegistrationEmailMustBeUnique does not
prevent duplicates when using
PatronSelfRegistrationVerifyByEmail
 Change sponsored?: ---
   Product: Koha
   Version: 16.05
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: baselibrary.consort...@nhs.net
QA Contact: testo...@bugs.koha-community.org

With PatronSelfRegistrationVerifyByEmail set to Require and
PatronSelfRegistrationEmailMustBeUnique set to Consider a patron can still self
register many times using the same email address.

Test case
1. Patron submits self registration form using the same email address 3 times
2. Patron receives 3 verification emails
3. Patron clicks on 3 verify token URLs
4. Staff client now shows the 3 patrons
5. Patron logs into 3 accounts on OPAC
6. Patron cannot change personal details because email address already exists

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

--- Comment #3 from Jason Palmer  ---
(In reply to Caroline Cyr La Rose from comment #2)
> Is this for multiple holds on the same biblio?

Yes.  Multiple holds for same bib.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19549] Reserve Slip prints first found hold when patron has multiple holds on a biblio

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19549

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #2 from Caroline Cyr La Rose  ---
Is this for multiple holds on the same biblio?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19471] Show creation date in patron restrictions list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19471

Charles Farmer  changed:

   What|Removed |Added

  Attachment #68180|0   |1
is obsolete||

--- Comment #3 from Charles Farmer  ---
Created attachment 68940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68940=edit
Bug 19471: Show creation date in patron restrictions list

Test plan:
1. Go to the "Details" vertical tab of a patron.
2. Click the "Restriction" tab in the bottom and add a manual restriction.
3. Verify a creation date is visible.

4. Edit the same patron.
5. Under "Patron restrictions" verify the creation date of the listed
   restiction is visible.

Signed-off-by: Owen Leonard 

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19452] The -truncate option in borrowers-force-messaging-defaults.pl should not remove category preferences

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19452

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #6 from Charles Farmer  ---
Can't really say where the problem lies, but I couldn't apply your patches:
> fatal: sha1 information is lacking or useless 
> (misc/maintenance/borrowers-force-messaging-defaults.pl).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18602] SPAM

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18602

Katrin Fischer  changed:

   What|Removed |Added

Summary|intuitI8OO3672164   |SPAM
   |Quickbooks Payroll Tech |
   |Support Phone Number|
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16461] Add some information (branch and barcode) in fine description for overdue

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com

--- Comment #8 from David Bourgault  ---
Missing a test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19454] Script borrowers-force-messaging-defaults.pl should be able to filter on patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19454

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #6 from Charles Farmer  ---
Can't really say if the problem is on my end or not, but I couldn't apply your
patches:
> fatal: sha1 information is lacking or useless 
> (misc/maintenance/borrowers-force-messaging-defaults.pl)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13188] Mandatory fields are wrong in patron personal details page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13188

Ola Andersson  changed:

   What|Removed |Added

 CC||ola.anders...@ltu.se

--- Comment #3 from Ola Andersson  ---
It is not possible with Koha 17.05.05 to configure a set of mandatory fields in
SelfRegistration and at the same time configure another set of mandatory fields
in SelfModification. This seems to be a design flaw.

E.g. we would like to have Address2 field mandatory in SelfRegistration but
optional in SelfModification.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #16 from Caroline Cyr La Rose  ---
I want this so much to work! I've been asked for this many many times!

But I got a software error.

BIx::Class::Storage::DBI::_dbh_execute(): Table
'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at
/inlibro/git/koha-master-dev-inlibro/Koha/Object.pm line 121

Plus the prove -v ... returned red.

DBD::mysql::st execute failed: Table
'koha_master_dev_inlibro.invoice_adjustments' doesn't exist [for Statement
"SELECT `me`.`adjustment_id`, `me`.`invoiceid`, `me`.`adjustment`,
`me`.`reason`, `me`.`note`, `me`.`budget_id`, `me`.`encumber_open`,
`me`.`timestamp` FROM `invoice_adjustments` `me`  JOIN `aqinvoices` `invoiceid`
ON `invoiceid`.`invoiceid` = `me`.`invoiceid` WHERE ( ( `budget_id` = ? AND
`closedate` IS NOT NULL ) )" with ParamValues: 0='6'] at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1765.
DBIx::Class::Storage::DBI::_dbh_execute(): Table
'koha_master_dev_inlibro.invoice_adjustments' doesn't exist at
/inlibro/git/koha-master-dev-inlibro/Koha/Objects.pm line 209
# Looks like your test exited with 255 just after 60.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 85/145 subtests 

Test Summary Report
---
t/db_dependent/Budgets.t (Wstat: 65280 Tests: 60 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 145 tests but ran 60.
Files=1, Tests=60,  1 wallclock secs ( 0.02 usr  0.00 sys +  1.49 cusr  0.08
csys =  1.59 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18213] Add language facets to Elasticsearch

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||david.bourga...@inlibro.com

--- Comment #5 from David Bourgault  ---
Does not apply.
fatal: sha1 information is lacking or useless
(Koha/SearchEngine/Elasticsearch.pm).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com

--- Comment #8 from David Bourgault  ---
No test plan?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18950] Elasticsearch - Add password access for admin functions

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||david.bourga...@inlibro.com

--- Comment #3 from David Bourgault  ---
Patch applies, and basic functionality is there, however:

- "Reindex" checked for password correctly but failed since 18948 does not
apply for me (not an issue, just a note)

- The password input field is of type=text but should be of type=password
- The error message when you enter a wrong password should probably more
obvious (like being red, or using the standard koha warning boxes)
- I'd suggest moving the  XML node inside the
 group, seems cleaner to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] Items table should have a damaged_on column

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

--- Comment #10 from Charles Farmer  ---
Created attachment 68939
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68939=edit
Bug 17672 - Dumping Items.t expected tests from 12 to 13

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] Items table should have a damaged_on column

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

--- Comment #8 from Charles Farmer  ---
Created attachment 68937
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68937=edit
Bug 17672 - Items table should have a damaged_on column

This patchset adds a 'damaged_on' column to store the date an item is
marked damaged, analogous to withdrawn_on and itemlost_on

To test:
1 - Apply patch
2 - Mark an item damaged via moredetail.pl (Items tab on left in
details)
3 - Note the damaged on date apears below
4 - Unmark the item, the date is removed
5 - Go to the edit items screen (from top bar 'Edit->edit items')
6 - Mark item damaged - check db or moredetails.pl to see damaged_on
date
7 - Unmark item damaged - confirm date is removed
8 - prove t/db_dependent/Items.t

Signed-off-by: Owen Leonard 

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] Items table should have a damaged_on column

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

Charles Farmer  changed:

   What|Removed |Added

  Attachment #65551|0   |1
is obsolete||
  Attachment #65552|0   |1
is obsolete||

--- Comment #9 from Charles Farmer  ---
Created attachment 68938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68938=edit
Bug 17672 - Schema updates

Signed-off-by: Owen Leonard 

Signed-off-by: Charles Farmer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18948] Reindexing should use aliases to avoid down time

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #6 from David Bourgault  ---
Patch does not apply, SHA1 error for Indexer.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #25 from Dominic Pichette  ---
i translated using misc/translator/translate fr-CA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17672] Items table should have a damaged_on column

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17672

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #7 from Charles Farmer  ---
Since we see the date at which the item was damaged on the moredetail.pl,
should we also see this information in the header table of the additem.pl page
along the status? Just pitching the idea out there.

Everything worked fine, though I had to bump up the number of tests from 12 to
13 in order to make it work on the current master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19066] Add branchcode to accountlines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||david.bourga...@inlibro.com

--- Comment #10 from David Bourgault  ---
Patch doesnt apply for me on master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||david.bourga...@inlibro.com

--- Comment #4 from David Bourgault  ---
The 2nd patch does not apply on current master. (Lacking or useless SHA1)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19542] Koha should display Elasticsearch information in the about page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

David Bourgault  changed:

   What|Removed |Added

  Attachment #68862|0   |1
is obsolete||

--- Comment #6 from David Bourgault  ---
Created attachment 68936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68936=edit
Bug 19542: Add Elasticsearch information in the 'About' page

This patch adds Elasticsearch related information to the 'About' page.

The information is gathered and displayed only when the 'SearchEngine' syspref
is set to 'Elasticsearch'. It displays configured nodes, and the status:
- Running
- Not running

In case it is running, it displays the defined indices and the document count
on each.
If there are configuration problems, exceptions are catch and a convenient
warning
message is displayed.

To test:
- Apply this patches
- Run:
  $ kshell
 k$ prove t/Koha/SearchEngine/Elasticsearch.t
=> SUCCESS: Tests pass!
- Have ES configured in your koha-conf.xml file (by default in kohadevbox)
- Set the 'SearchEngine' syspref to 'Elasticsearch'
- Comment out pieces of the elasticsearch-specific entries (server, index_name,
  the whole elasticsearch block). Reload on each change.
=> SUCCESS: Warning messages are displayed and make sense in the context of
your changes.
> the rest of the tests require having ES running on the dev env. This can
be easily
  achieved by creating the kohadevbox using:
$ KOHA_ELASTICSEARCH=1 vagrant up
- Stop the 'elasticsearch' service:
  $ sudo service elasticsearch stop
- Reload about.pl
=> SUCCESS: The configured nodes are displayed, and the status is 'not running'
- Start the 'elasticsearch' service:
  $ sudo service elasticsearch start
- Reload about.pl
=> SUCCESS: The configured nodes are displayed, the status is 'running' and
created indices info is displayed, along with the document count
on each index.
- Sign off :-D

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19542] Koha should display Elasticsearch information in the about page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

David Bourgault  changed:

   What|Removed |Added

  Attachment #68861|0   |1
is obsolete||

--- Comment #5 from David Bourgault  ---
Created attachment 68935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68935=edit
Bug 19542: Add a check for ES configuration health

This patch adds a new statuc function to Koha::SearchEngine::ElasticSearch
which is instended to replace most of get_elasticsearch_params. This function
reads the configuration from C4::Context->config('elasticsearch') and raises
relevant exceptions when mandatory entries are missing.

Its behaviour is covered by tests.

To test:
- Run:
  $ kshell
 k$ prove t/Koha/SearchEngine/Elasticsearch.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19542] Koha should display Elasticsearch information in the about page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19542

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron' s record has expired

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #11 from Dominic Pichette  ---
I tried it, I started by setting BlockExpiredPatronOpacActions to set, checked
out an item for a particular patron, change the expiration date of that patron
so he is now expired and then executed automatic_renewals.pl. The patch didn't
seem to make a difference, it passed in both cases..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #182 from Jonathan Druart  
---
1/ Error handling on borrowernumber when creating or updating a request
(backend issue?)
2/ Capitalization problems, deprecated words (Branch, borrowers), etc
3/ Use dateformat to display dates
4/ ill/ill-requests.pl?method=generic_confirm_id=3
click "send email"
Software error to handle correctly:
No target email addresses found. Either select at least one partner or check
your ILL partner library records. at /home/vagrant/kohaclone/Koha/Illrequest.pm
line 896.

5/ Same for "Your branch has no email address. Please set it. at
/home/vagrant/kohaclone/Koha/Illrequest.pm line 901."

6/ Should not we use message_queue instead of sendmail directly?

7/ Maybe we should add a warning to the about page if the partner_code defined
in the config does not match a category_code (?)

(not finished)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19485] Limiting by title-series (se) broken on ES

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19485

--- Comment #3 from David Bourgault  ---
The mappings are supposed to be located in
admin/searchengine/elasticsearch/mappings.yaml

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron' s record has expired

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

Dominic Pichette  changed:

   What|Removed |Added

 CC||dominic.piche...@inlibro.co
   ||m

--- Comment #10 from Dominic Pichette  ---
I tried it, I started by setting BlockExpiredPatronOpacActions to set, checked
out an item for a particular patron, change the expiration date of that patron
so he is now expired and then executed automatic_renewals.pl. The patch didn't
seem to make a difference, it passed in both cases..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68898|0   |1
is obsolete||

--- Comment #31 from Jonathan Druart  
---
Created attachment 68934
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68934=edit
Bug 6918 - can't place holds on 'on order' items with AllowOnShelfHolds off

Test Plan:
1) Apply patch
2) Turn off AllowOnShelfHolds
3) Create a bib with one item, mark the item as 'on order'
4) Attempt to place a hold on the item, you should now be able to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||david.bourga...@inlibro.com

--- Comment #7 from David Bourgault  ---
Is there a step missing form the test plan? I applied the patch, change my
Circulation rules to set no holds for All/All (I have no other rules for my
test patron's category) and tried to place a hold but got the message "No
available items.", but I can see it as available on the OPAC detail page.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68929|0   |1
is obsolete||

--- Comment #181 from Tomás Cohen Arazi  ---
Created attachment 68933
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68933=edit
Bug 7317: opac.css update

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68928|0   |1
is obsolete||

--- Comment #180 from Tomás Cohen Arazi  ---
Created attachment 68932
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68932=edit
Bug 7317: (QA followup) Get rid of warnings from the tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68927|0   |1
is obsolete||

--- Comment #179 from Tomás Cohen Arazi  ---
Created attachment 68931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68931=edit
Bug 7317: Handle backend absense more gracefuly

5/ This patch makes Koha::Illrequest->load_backend raise an exception
if the passed backend is invalid. This way we will catch more errors
introduced.

The patch also disables the 'New Ill request' when no backends are available.
Gets
rid of a related warnings.

Both OPAC and Intranet now display a warning message when no backends
are available.

Tests are added for the load_backend changes.

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the
include
for tablesorter, as this implementation uses Datatables. This is obviously code
for older
Koha, ported to master.

TODO: There's something wrong on the styling. My idea is to get rid
of the custom column visualization tool, and have it display as regular
DataTables. We can then introduce the use of colvis on a separate bug
report.

Note: POD coverage for the exceptions file is wrongly tested. It is a false
positive.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18357] On-site checkouts issues with 'Unlimited'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18357

David Bourgault  changed:

   What|Removed |Added

  Attachment #68896|0   |1
is obsolete||

--- Comment #5 from David Bourgault  ---
Created attachment 68930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68930=edit
Bug 18357: Handle unlimited on-site checkouts

If on-site checkouts are set to unlimited (i.e. NULL/undef), they are
currently blocked.

Test plan:
1/ Set All/All rule with Unlimited/unlimited for normal/onsite checkouts
2/ Will be able to perform onsite checkout
3/ Edit rule to be 15/Unlimited normal/onsite
4/ Will be able to perform onsite checkout
=> Without this patch it was blocked
5/ Set rule to 15/15
6/ Onsite checkouts work again

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com
 Status|Needs Signoff   |Failed QA

--- Comment #5 from Caroline Cyr La Rose  ---
Hi Jonathan,

I'm having trouble testing this. Which cron job are we supposed to run? Is it
automatic_renewals.pl --send-notices?

Furthermore, I had an item due in the future (in december) and I still received
a notice saying the auto renewal failed because I had fines (which was true).
But why would it try to renew something due in december?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68922|0   |1
is obsolete||

--- Comment #177 from Tomás Cohen Arazi  ---
Created attachment 68928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68928=edit
Bug 7317: (QA followup) Get rid of warnings from the tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68926|0   |1
is obsolete||

--- Comment #178 from Tomás Cohen Arazi  ---
Created attachment 68929
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68929=edit
Bug 7317: opac.css update

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68921|0   |1
is obsolete||

--- Comment #176 from Tomás Cohen Arazi  ---
Created attachment 68927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68927=edit
Bug 7317: Handle backend absense more gracefuly

5/ This patch makes Koha::Illrequest->load_backend raise an exception
if the passed backend is invalid. This way we will catch more errors
introduced.

The patch also disables the 'New Ill request' when no backends are available.
Gets
rid of a related warnings.

Both OPAC and Intranet now display a warning message when no backends
are available.

Tests are added for the load_backend changes.

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the
include
for tablesorter, as this implementation uses Datatables. This is obviously code
for older
Koha, ported to master.

TODO: There's something wrong on the styling. My idea is to get rid
of the custom column visualization tool, and have it display as regular
DataTables. We can then introduce the use of colvis on a separate bug
report.

Note: POD coverage for the exceptions file is wrongly tested. It is a false
positive.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Dominic Pichette  changed:

   What|Removed |Added

 CC||dominic.piche...@inlibro.co
   ||m

--- Comment #30 from Dominic Pichette  ---
I did a reset --hard on origin/master and still have the same error than
Simon..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Jonathan Druart  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Jonathan Druart  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com,
   ||tomasco...@gmail.com
 Status|NEW |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19578] New: TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Bug ID: 19578
   Summary: TT syntax for notices - There is no way to pre-process
DB fields
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

Jenkins fails (run 287) on a test in t/db_dependent/Letters/TemplateToolkit.t:

With the historical syntax:
# Your request for an article from tQYRS (c3Av58O0P5xkkIGu) has been
canceled for the following reason:

With the TT syntax:
# Your request for an article from tQYRS_ (c3Av58O0P5xkkIGu) has been
canceled for the following reason:

The last character of the biblio's title has been removed because it's a
punctuation character.
It comes from: C4::Letters::_parseletter
 893 $val =~ s/\p{P}$// if $val && $table=~/biblio/;

The same replacement is done for patron's attributes too.

With the TT syntax we retrieve the objects and send them to the template,
without fetching the attributes.
To restore this behaviour we could apply this regex on all the fields of the
biblio objects, but it could be perf killer (we will process fields that we
will certainly not used in the template).
I thought about the TT filter we could apply on all the variables we display,
but we will not know where come from the data, and we need to apply this change
only for the biblio table.

Any other ideas?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com
 Status|Needs Signoff   |Failed QA

--- Comment #20 from David Bourgault  ---
Test plan works as described, but QA tools warns of forbidden patterns.

koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc
   FAIL   forbidden patterns
forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 5)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #175 from Tomás Cohen Arazi  ---
Created attachment 68926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68926=edit
Bug 7317: opac.css update

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #9 from Caroline Cyr La Rose  ---
The test plan works. 

However, is it normal that if I add <> in the notice it comes back
as blank in the message_queue table?

I checked and my notes are in the issues table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68561|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com

--- Comment #8 from David Bourgault  ---
It would be easier if you could provide maybe a hint on how to block access to
the message_queue table? Not sure how to test this otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||david.bourga...@inlibro.com

--- Comment #7 from David Bourgault  ---
Works as described in test plan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

David Bourgault  changed:

   What|Removed |Added

  Attachment #68881|0   |1
is obsolete||

--- Comment #5 from David Bourgault  ---
Created attachment 68924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68924=edit
Bug 19559 - Unit tests

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

David Bourgault  changed:

   What|Removed |Added

  Attachment #68882|0   |1
is obsolete||

--- Comment #6 from David Bourgault  ---
Created attachment 68925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68925=edit
Bug 19559 - Add '-' to list of characters we don't split search terms on

Test plan assumes
QueryAutoTruncate = automatically
SearchEngine = Elasticsearch

To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number:"4"' (or a vlid biblionumber)
7 - should get expected result

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19577] New: Secondary email is unable to receive notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19577

Bug ID: 19577
   Summary: Secondary email is unable to receive notices
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: nick.weinga...@valorchristian.com
QA Contact: testo...@bugs.koha-community.org

Overview: Patrons are able to have multiple email addresses in Koha, but
notices can only be sent to the primary email. The purpose of this bug is to
develop an enhancement that would allow a notice be sent to both emails.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18625] update borrower last seen from SIP

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18625

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #128 from Josef Moravec  ---
Hi Srdjan,
I did test these patches now, but I am sorry:

The test Search.t is failing after this patchset...

 #   Failed test 'Warning is raised correctly for invalid tags in MARC::Record'
 #   at t/db_dependent/Search.t line 681.

there are also so many warnings about preferences missing in mock


virtualshelves on intranet and opac goes to ISE:

DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse
has_many results in iterator mode due to order criteria - performed an eager
cursor slurp underneath. Consider using ->all() instead at
/home/vagrant/kohaclone/Koha/Objects.pm line 209
Can't use string ("1") as an ARRAY ref while "strict refs" in use at
/home/vagrant/kohaclone/C4/XSLT.pm line 290.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19576] opac-detail has duplicate 'use Koha::Biblios; '

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #4 from Jonathan Druart  
---
Pushed to master for 17.11, thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

--- Comment #28 from Jonathan Druart  
---
Last patch pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19176] Dates comparison fails on slow server

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19176

--- Comment #27 from Jonathan Druart  
---
Created attachment 68923
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68923=edit
Bug 19176: (QA follow-up) few cosmetic changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68885|0   |1
is obsolete||

--- Comment #173 from Tomás Cohen Arazi  ---
Created attachment 68921
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68921=edit
Bug 7317: Handle backend absense more gracefuly

5/ This patch makes Koha::Illrequest->load_backend raise an exception
if the passed backend is invalid. This way we will catch more errors
introduced.

The patch also disables the 'New Ill request' when no backends are available.
Gets
rid of a related warnings.

Both OPAC and Intranet now display a warning message when no backends
are available.

Tests are added for the load_backend changes.

4/ This patch fixes the path for the checkboxes jquery plugin, and removes the
include
for tablesorter, as this implementation uses Datatables. This is obviously code
for older
Koha, ported to master.

TODO: There's something wrong on the styling. My idea is to get rid
of the custom column visualization tool, and have it display as regular
DataTables. We can then introduce the use of colvis on a separate bug
report.

Note: POD coverage for the exceptions file is wrongly tested. It is a false
positive.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #68886|0   |1
is obsolete||

--- Comment #174 from Tomás Cohen Arazi  ---
Created attachment 68922
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68922=edit
Bug 7317: (QA followup) Get rid of warnings from the tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #29 from Jonathan Druart  
---
Simon, make sure your branch is up-to-date with origin/master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #34 from Jonathan Druart  
---
Created attachment 68920
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68920=edit
Bug 10021: (QA follow-up) Rename variables

To avoid $account, $accounts and @accounts variables in the same scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

--- Comment #33 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #30)
> When you remove a sub from a module without full coverage, this is the
> result. Something for QA tools ?

Yes, could be improved. POD failures must be considered as warnings.

(In reply to Marcel de Rooy from comment #31)
> (In reply to Jonathan Druart from comment #8)
> > It appears that has never worked.
> > Could someone confirm?
> 
> Did you have any response whatsoever ?

I think we discussed it on IRC, but I do not find the logs.

(In reply to Marcel de Rooy from comment #32)
> QA Comment:
> 
> GetOverduesForBranch
> Please add a test. You make some fundamental changes here.

Fundamental? I do not understand what you want me to test.

> koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
> -
> Not sure. Why do yo remove this line ?

Yes it could have been done somewhere else, it's not directly related to these
changes. There is no "totals*" variables retrieved from the pl script.

> New code:
> +my $accounts = Koha::Account::Lines->search({ borrowernumber =>
> $borrowernumber, }, { order_by => ['accounttype'] });
> +my @accounts;
> +while ( my $account = $accounts->next ) {
> This does not look very nice. Can we get more confusion on $account,
> @accounts or $accounts ?
> Renaming @accounts here might be the least we can do?
> No blocker on itself.

Will fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10748] Add option to block return of lost items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10748] Add option to block return of lost items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

--- Comment #8 from Jonathan Druart  
---
Created attachment 68919
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68919=edit
Bug 10748: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

--- Comment #28 from Simon Pouchol  ---
Hey Jonathan,
It seems to me the patch isn't applying :
Applying: Bug 6918 - can't place holds on 'on order' items with
AllowOnShelfHolds off
fatal: sha1 information is lacking or useless (C4/Biblio.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 6918 - can't place holds on 'on order' items with
AllowOnShelfHolds off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19290] Add the ability to filter a result list on staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68204|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 68918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68918=edit
Bug 19290: Browse selected bibliographic records - Staff interface

This patch adds the same feature as bug 10858 for the OPAC interface:
after a search, librarians will be able to browse selected results.
The results can be selected from several pages.
By extension it is possible to add results from several pages to a list
or the cart.

When at least one result is selected, a new "Browse selected records" button
becomes usable and change the behaviour of the existing browser.

The whole feature can be turned off with the pref BrowseResultSelection.

Test plan:
- Launch a search (on the staff interface)
- Check some biblios
- Go on another page
- Check some biblios
- Come back to a page you already check results and confirm that they are
still checked
- Click on the "Browse selected records" button
- Check that you are able to browse results you had checked.

You can also:
- add them to the cart
- add them to a list

QA note: the browsers at the OPAC and the one at the staff interface are
completely different
That's why the code is not mimicking what has been done on bug 10858.
The behaviour must stay the same anyway.

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19290] Add the ability to filter a result list on staff client

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19576


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576
[Bug 19576] opac-detail has duplicate 'use Koha::Biblios;'
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19576] opac-detail has duplicate 'use Koha::Biblios; '

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18262
 Status|Signed Off  |Passed QA

--- Comment #3 from Jonathan Druart  
---
Introduced by bug 18262.
Trivial, skipping QA.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18262
[Bug 18262] Koha::Biblios - Remove GetBiblioData - part 1
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19576] opac-detail has duplicate 'use Koha::Biblios; '

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68915|0   |1
is obsolete||

--- Comment #2 from Jonathan Druart  
---
Created attachment 68917
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68917=edit
Bug 19576: Remove extra 'use Koha::Biblios' statement

Marcel noticed this while QA'ing another bug.

TEST PLAN
-
Apply patch and confirm the page still loads and works as expected.
Run Koha QA Test tools

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19576] opac-detail has duplicate 'use Koha::Biblios; '

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68534|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 68916
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68916=edit
Bug 19280: Pass a Koha::Patron to CanBookBeIssued

We need to make subroutine from C4 use more Koha::Object objects
Seeing bug 19276, starting here is a good start.

Test plan:
The tests should still pass.

Signed-off-by: Jon Knight 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||simon.pouc...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19576] opac-detail has duplicate 'use Koha::Biblios; '

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

M. Tompsett  changed:

   What|Removed |Added

Summary|opac-detail has multiple|opac-detail has duplicate
   |Koha::Biblios   |'use Koha::Biblios;'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19576] opac-detail has multiple Koha::Biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19576] opac-detail has multiple Koha::Biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

--- Comment #1 from M. Tompsett  ---
Created attachment 68915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68915=edit
Bug 19576: Remove extra Koha::Biblios

Marcel noticed this while QA'ing another bug.

TEST PLAN
-
Apply patch and confirm the page still loads and works as expected.
Run Koha QA Test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19576] opac-detail has multiple Koha::Biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19576] opac-detail has multiple Koha::Biblios

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19576

M. Tompsett  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/