[Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool patron creation

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

Alex Buckley  changed:

   What|Removed |Added

 Status|Failed QA   |In Discussion

--- Comment #6 from Alex Buckley  ---
Hi Jonathan

I have tried implemented the client side validation by doing the following:

1. Adding the following pragma at the start of onboardingstep3.tt:
[% USE Koha %]  

2. Adding the following to the bottom of the same file:
[% PROCESS 'password_check.inc' %] 
[% PROCESS 'add_password_check' new_password => 'newpassword' %]


3. Added the following to the validation in the ../../../js/onboarding.js
password: 
required: true,
password_strong: true
password_no_spaces: true
},?
password2: {
required: true,
password_match: true
}
. 
I notice that I get the JS error 'TypeError: _(...).format is not a function.
This error is not thrown by the memberentrygen.tt file which uses the same
client side validation.

Can you give me any suggestions as to how to fix this issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68947|0   |1
is obsolete||

--- Comment #3 from Nick Clemens  ---
Created attachment 68949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68949=edit
Bug 19581: Unit tests

This patch makes a few changes to the tests to take into account the
change to indexing.

To test:
prove t/db_dependent/Koha_Elasticsearch_Indexer.t
Should return green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for sorting in mappings.yaml

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

--- Comment #5 from Nick Clemens  ---
(In reply to David Bourgault from comment #4)
> Test worked as planned, however sorting by title and author seemed strange.
> I assume the issue wasn't introduced by this bug, but looking at the results
> list, it did not seem alphabetical to me.

See bug 19581 and bug 18827 for ordering issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

--- Comment #1 from Nick Clemens  ---
Created attachment 68947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68947=edit
Bug 19581: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

--- Comment #2 from Nick Clemens  ---
Created attachment 68948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68948=edit
Bug 19581: Remove 'split' option from Catmandu fixes for marc

This option in combination with append seems to add null entries in the indexes
for fields that don't exist. These fields then affect sorting. Removing it
solves
the issue

To test:
1 - Have an ES setup
2 - Catalog and index some records
3 - View a record in ES:
curl 'localhost:9200/koha_kohadev_biblios/data/4?pretty=yes'
4 - Note there are 'null' entries in the indexes, save this result for
comparison
5 - Apply patch
6 - Reindex, amking sure to delete existing indexes
perl misc/search_tools/rebuild_elastic_search.pl -d
7 - View the record again
8 - Note the null entries are removed
9 - Note indices are otherwise intact

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] New: Elasticsearch - Catmandu split option adds extra null fields to indexes

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

Bug ID: 19581
   Summary: Elasticsearch - Catmandu split option adds extra null
fields to indexes
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: n...@bywatersolutions.com
  Reporter: n...@bywatersolutions.com

This affects sorting, when encountering a null field the title in question will
sort out of place.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482

Nick Clemens  changed:

   What|Removed |Added

 Depends on||19481
 Status|Patch doesn't apply |Needs Signoff


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481
[Bug 19481] Elasticsearch - Set default fields for sorting in mappings.yaml
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for sorting in mappings.yaml

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

Nick Clemens  changed:

   What|Removed |Added

 Blocks||19482


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482
[Bug 19482] Elasticsearch - prevent removal / editing of required indexes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

David Gustafsson  changed:

   What|Removed |Added

 CC||glask...@gmail.com

--- Comment #3 from David Gustafsson  ---
I think you need to escape that hyphen unless its the last character within the
character class brackets (like this: my @tokens = split
/((?:[\w\-.]+:)?"[^"]+"|\s+)/, $query;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19538] Advanced editor - Rancor - Move syspref from labs to cataloging and remove experimental note

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19538

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19538] Advanced editor - Rancor - Move syspref from labs to cataloging and remove experimental note

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19538

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|In Discussion   |Signed Off

--- Comment #4 from Katrin Fischer  ---
We discussed this at the last meeting and agreed to move it out of labs. There
are no open bug reports, just ongoing enhancements. I think it's ripe to leave
the labs.

https://wiki.koha-community.org/wiki/Development_IRC_meeting_11_October_2017

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17314] REST API: Add API route to create, list and delete a purchase suggestion

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17314

--- Comment #21 from Jiri Kozlovsky  ---
(In reply to Jon Knight from comment #20)
> I noticed that this doesn't apply cleanly to the latest master HEAD on my
> kohadevbox.  I could help rebase if that would be useful to nudge this bug
> along?  Unless of course Jiri is working on an updated version?

Well, I've been working on rebasing on top of master HEAD for a little time
already and I'm near completion. 

Right now I'm actually solving a really strange bug when GET on an item
(/suggestions/{id}) works perfectly fine, but GET on a list of items
(/suggestions) fails on "Method not implemented" although I've basically copy &
pasted the /patrons implementation.

As soon as I'll solve this strange behaviour, I'll post my work here ;) But
thank you for your effort.(In reply to Jon Knight from comment #19)

> Is development of this patch still ongoing?  Also PUT appears to actually be
> a PATCH operation as it doesn't require the whole object data to be
> specified - should the HTTP method be changed to reflect that?

I'm going to fix this too in my next patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10708] make fine receipt customizable

2017-11-04 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708

Jamsheer N P  changed:

   What|Removed |Added

 CC||jamsheer...@gmail.com

--- Comment #7 from Jamsheer N P  ---
There shall be an option for receipt number in the payment slip which can be
reset at beginning of the financial year. So that one need not have to depend
on a manual receipt writing/printing. With the help of a unique receipt number,
payment can be verified later (especially where financial auditing in library
is mandatory).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/