[Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when date changes during test run

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when date changes during test run

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #3 from M. Tompsett  ---
Created attachment 68996
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68996=edit
Bug 17770: Perltidy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when date changes during test run

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #1 from M. Tompsett  ---
Created attachment 68994
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68994=edit
Bug 17770: Sitemapper.t fails if date changes during test run

To compensate, DateTime->now is mocked to the current date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17770] t/db_dependent/ Sitemapper.t fails when date changes during test run

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17770

--- Comment #2 from M. Tompsett  ---
Created attachment 68995
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68995=edit
Bug 17770: Improve perlcritic level

before patch: perlcritic -4 noisy
after patch: perlcritic -4 ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #47 from Srdjan Jankovic  ---
(In reply to Jonathan Druart from comment #46)
> Quick note: use String.format() when needed.

Money or somewhere else?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #130 from Srdjan Jankovic  ---
(In reply to Josef Moravec from comment #128)
> Hi Srdjan,
> I did test these patches now, but I am sorry:
> 
> The test Search.t is failing after this patchset...

Don't be sorry, thanks for testing.
I've decided that Search.t is broken, and there's no use changing it at this
stage, so I dropped that patch.


> virtualshelves on intranet and opac goes to ISE:
> 
> DBIx::Class::ResultSet::_construct_results(): Unable to properly collapse
> has_many results in iterator mode due to order criteria - performed an eager
> cursor slurp underneath. Consider using ->all() instead at
> /home/vagrant/kohaclone/Koha/Objects.pm line 209
> Can't use string ("1") as an ARRAY ref while "strict refs" in use at
> /home/vagrant/kohaclone/C4/XSLT.pm line 290.

Can you please tell me the steps to get that. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #68820|0   |1
is obsolete||

--- Comment #129 from Srdjan Jankovic  ---
Comment on attachment 68820
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68820
bug_11213: Include XSLT processing for searchResults() test

Not required

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens  changed:

   What|Removed |Added

  Attachment #68984|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 68992
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68992=edit
Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

To test:
1 - Enable Zebra
2 - Perform an auth search
3 - note results
4 - Enable ES
5 - Repeat search, note (likely) diff results
6 - Open a record in cataloging and use the button to launch auth search
7 - Perform same search as above, note results match for eiher engine
selected
8 - NOTE: Disable sorting for ES search - this will be dealt with in
another report

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #3 from Nick Clemens  ---
Created attachment 68993
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68993=edit
Bug 19582: Unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19583] New: Report updater triggers on auth_header.marcxml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19583

Bug ID: 19583
   Summary: Report updater triggers on auth_header.marcxml
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

In Home › Reports › Guided reports wizard › Saved reports,

Any reports that use auth_header.marcxml will display

"This report seems obsolete, it uses biblioitems.marcxml field" with an "Update
SQL" button.

auth_header.marcxml still exists in the schema however.

This is bound to be confusing to users.

--Barton

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17602] Integrate support for OneClickdigital/Recorded Books API

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17602

--- Comment #46 from Jonathan Druart  
---
Quick note: use String.format() when needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #28 from Jonathan Druart  
---
(In reply to Séverine Queune from comment #26)
> We vote suggestion 1.

Sally and Katrin, would you also agree with a new "UpdateItemWhenLost" pref?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #6 from Jonathan Druart  
---
(In reply to Séverine Queune from comment #5)
> I wanted to test this patch even thought it's signed off but I couldn't
> apply it on Biblibre's sandbox.

It applies correctly for me on top of bug 3841, did you apply the dependency
patches before?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

--- Comment #6 from Jonathan Druart  
---
Marcel, what do you think about this approach?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #68990|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 68991
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68991=edit
Bug 19578: Remove MARC punctuation in notices (TT syntax)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #4 from Jonathan Druart  
---
Created attachment 68990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68990=edit
Bug 19578: Remove MARC punctuation in notices (TT syntax)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13990] ILS-DI LookupPatron Requries ID Type

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13990

Jon Knight  changed:

   What|Removed |Added

 Status|NEW |In Discussion
 CC||j.p.kni...@lboro.ac.uk

--- Comment #2 from Jon Knight  ---
I assume the obvious fix to this is to say that the id_type is required rather
than optional in the POD?  Alternative there could be a set of well defined
id_types that are cycled through to find matches (that would be a pretty easy
bit of code).

On a similar note, we've noticed that "email" also appears to be a valid
id_type but isn't in the POD list. A quick look in the code (hoorah for open
source!) shows that any field in the borrower table can be looked up with this
call.  For example "phone", "phonepro" or "mobile" let me find myself using my
primary, secondary and "other" phone number. 

This begs the question: should Koha be constraining the list of id_type's that
can be passed into this routine from the client? Or is being able to search on
any column in the borrowers table regarded as a useful feature (we've found
"email" to be handy for sure).

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14180] Make "Always show checkouts immediately" a global setting

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14180

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #10 from Séverine Queune  ---
We added this code on 'IntranetUserJS' syspref and it works perfectly for us :)
(Found on Biblibre's documentation)


$(document).ready(function() {

if ( typeof script !== 'undefined' && !
$.cookie("issues-table-load-immediately-" + script) ) {
$.cookie("issues-table-load-immediately-" + script, true, { expires: 365
});
}

});

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #185 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #182)
> 1/ Error handling on borrowernumber when creating or updating a request
> (backend issue?)

This is definitely a backend issue. The Dummy backend does no check, it just
passes the borrowernumber from the UI to the Koha::Illrequest->store method
with no error catching. The FreeForm plugin does some checks before the
->store, though. Out of the scope of the bug anyway.

> 6/ Should not we use message_queue instead of sendmail directly?

There's a bug filed for this: bug 18588.

> 7/ Maybe we should add a warning to the about page if the partner_code
> defined in the config does not match a category_code (?)

Done in one of the recent followups.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #184 from Tomás Cohen Arazi  ---
Created attachment 68989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68989=edit
Bug 7317: (followup) Make tests independent of data on the DB

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

--- Comment #183 from Tomás Cohen Arazi  ---
Created attachment 68988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68988=edit
Bug 7317: Add partner_code checks to abot page

This patch adds checks to the configured (or fallback) partner_code.
It produces two different warnings:

- Configured partner_code doesn't match an existing patron category
code.
- partner_code is not defined, a fallback to ILLLIBS is done

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #5 from Séverine Queune  ---
I wanted to test this patch even thought it's signed off but I couldn't apply
it on Biblibre's sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] make test is failing with an empty DB - t/Matcher.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Signed Off

--- Comment #9 from M. Tompsett  ---
Though, I think the last two patches probable belong on their own bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] make test is failing with an empty DB - t/Matcher.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

M. Tompsett  changed:

   What|Removed |Added

  Attachment #68890|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 68985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68985=edit
Bug 18712: Fix t/Matcher.t if DB is empty

t/Matcher.t is failing with an empty DB, the data are not mocked
correctly

Test plan:
drop your DB and recreate it without any data and prove t/Matcher.t

Signed-off-by: Mark Tompsett 

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] make test is failing with an empty DB - t/Matcher.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

M. Tompsett  changed:

   What|Removed |Added

  Attachment #68891|0   |1
is obsolete||

--- Comment #7 from M. Tompsett  ---
Created attachment 68986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68986=edit
Bug 18712: Remove unecessary fixtures

2 fixtures are in a subroutine that is never called, it can be removed

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18712] make test is failing with an empty DB - t/Matcher.t

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18712

--- Comment #8 from M. Tompsett  ---
Created attachment 68987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68987=edit
Bug 18712: Added missing done_testing

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com
   ||,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||tomasco...@gmail.com
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

--- Comment #1 from Nick Clemens  ---
Created attachment 68984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68984=edit
Bug 19582 - Use compat routines for searching authorities in auth_finder.pl

To test:
1 - Enable Zebra
2 - Perform an auth search
3 - note results
4 - Enable ES
5 - Repeat search, note (likely) diff results
6 - Open a record in cataloging and use the button to launch auth search
7 - Perform same search as above, note results match for eiher engine
selected
8 - NOTE: Disbale sorting for ES search - this will be dealt with in
another report

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19582] New: Elasticsearch: Auth-finder.pl must use search_auth_compat

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19582

Bug ID: 19582
   Summary: Elasticsearch: Auth-finder.pl must use
search_auth_compat
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com

When Elasticsearch is enable the authorities search from cataloging is using
Zebra, we need to use the compat functions to select the correct engine

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19548] Search Result Second page not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548

--- Comment #5 from Jonathan Druart  
---
Can you paste the complete configuration of the SRU server you configured?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19547] Maria DB doesn't have a debian.cnf

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19547

--- Comment #6 from M. Tompsett  ---
(In reply to M. Tompsett from comment #4)
> TEST PLAN
> ---
...
> 10) git checkout -b bug_19547 origin/master
-- 10.5 git bz apply 19547
> 11) git checkout master

Oops... forgot the obvious line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19342] Show name private list on biblio when user is logged

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19342

Marjorie Barry-Vila  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool patron creation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

Jonathan Druart  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19514] No Password restrictions in onboarding tool patron creation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19514

--- Comment #7 from Jonathan Druart  
---
Created attachment 68982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68982=edit
Bug 19514: Add client-side check

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16339] Add search "start with" in z39.50 authority search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16339

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19538] Advanced editor - Rancor - Move syspref from labs to cataloging and remove experimental note

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19538

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19548] Search Result Second page not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548

--- Comment #4 from rainer.stowas...@zamg.ac.at ---
Then I have to enlarge the bug ;-)

Library of Congress SRU gives NOTHING
(you are right, but is this intended ?)

Deutsche Natiional Bibliothek SRU services.dnb.de:80 
gives the result Ive described

Search Terms:
meteorology
"meteorology"

Ive looked at /usr/share/koha/intranet/cgi-bin/cataloguing/z3950_search.pl
and as I understands it its the same for z39.50 and SRU

so if I want to fiddle its the right place to look right ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18992] LDAP fallback behaviour not consistent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18992

--- Comment #4 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #2)
> Is this related to bug 18880?

And no, I think this exists separate from the work there - the decision is
whether we should fallback if the user exists in ldap but password is wrong ( 
I think we should)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

--- Comment #1 from Nick Clemens  ---
This broke LDAP configuration after upgrade to 17.05, will tyr to provide a
patch shortly

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19444] Automatic renewal script should not auto-renew if a patron' s record has expired

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19444

--- Comment #12 from Jonathan Druart  
---
(In reply to Dominic Pichette from comment #11)
> I tried it, I started by setting BlockExpiredPatronOpacActions to set,
> checked out an item for a particular patron, change the expiration date of
> that patron so he is now expired and then executed automatic_renewals.pl.
> The patch didn't seem to make a difference, it passed in both cases..

Dominic, you need to know how automatic renewals work if you want to test this
patch. You should enable it in the issuing rule and then tick the "Automatic
renewal" on the checkout screen. Is it what you tried?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18992] LDAP fallback behaviour not consistent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18992

--- Comment #3 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #2)
> Is this related to bug 18880?

I commented on wrong bug, meant for 18947

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19548] Search Result Second page not available

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19548

--- Comment #3 from Jonathan Druart  
---
If I search for "test" (with quotation marks), I do not get any results at all.
Could you give us more details to recreation the issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15522] New interface for revamped circulation rules

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15723] Add preview marc in authority results authorities-home.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15723

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882

--- Comment #43 from Marjorie Barry-Vila  ---
(In reply to Kyle M Hall from comment #38)
> Created attachment 24228 [details] [review]
> Bug 7882: Inputs should be editable
> 
> disableSelection is deprecated and cause an issue on editing an input
> (input, select, textarea, etc.)
> see http://api.jqueryui.com/disableselection/
> 
> Signed-off-by: Kyle M Hall 

Hi Kyle,

Do you think you can rebase the patch for the master version?

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19358] Purchase suggestions - enhancements to linking to orders

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19358

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18992] LDAP fallback behaviour not consistent

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18992

--- Comment #2 from Jonathan Druart  
---
Is this related to bug 18880?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18314] Account lockout

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||18880
   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=18880   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880
[Bug 18880] Regression breaks local authentication fallback for all external
authentications
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880

Jonathan Druart  changed:

   What|Removed |Added

   See Also|https://bugs.koha-community |
   |.org/bugzilla3/show_bug.cgi |
   |?id=18314   |
 Depends on||18314


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314
[Bug 18314] Account lockout
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10748] Add option to block return of lost items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10748

--- Comment #13 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #9)
> Adding a comment in a follow-up.

Thanks a lot Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68970|0   |1
is obsolete||

--- Comment #39 from Simon Pouchol  ---
Created attachment 68978
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68978=edit
Bug 19522: Label creator: edit batch: make Call number translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. then you should see "Call number" in the column names
6. apply this patch
7. install the fr_FR locale
8. refresh the page
9. then you should see "Cote" in the column names

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68966|0   |1
is obsolete||

--- Comment #35 from Simon Pouchol  ---
Created attachment 68974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68974=edit
Bug 19522: Coding style: Fix alignement after previous patch

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68969|0   |1
is obsolete||

--- Comment #38 from Simon Pouchol  ---
Created attachment 68977
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68977=edit
Bug 19522: Label creator: translate empty list message

The name of the element wasn't translated in the message.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. ensure that the list is empty
4. then you should see "pas de Batches actuellement"
5. then you should see "créer un nouveau batch."
6. apply this patch
7. install the language
8. refresh the page
9. then you should see "pas de Lots actuellement"
10. then you should see "créer un nouveau lot ."

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68971|0   |1
is obsolete||

--- Comment #40 from Simon Pouchol  ---
Created attachment 68979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68979=edit
Bug 19522: Label creator: edit batch: make "Export label" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. Switch the language to French if you haven't done it yet
6. click on "Exporter le lot entier"
7. then you should see "Export labels"
8. apply this patch
9. install the language
10. replay steps 2 to 6
11. then you should see "Exporter des étiquettes"

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #36 from Simon Pouchol  ---
Created attachment 68975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68975=edit
Bug 19522: Label creator - some strings are not translatable

Templates: new form:
Add hardcoded unit names to make them translatable.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new
3. then you should see the "Unités" dropdown with english units
4. apply this patch
5. install the language
6. refresh the page
7. then you should see the "Unités" dropdown with french units

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68968|0   |1
is obsolete||

--- Comment #37 from Simon Pouchol  ---
Created attachment 68976
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68976=edit
Bug 19522: Coding style: Replace tabs with spaces

In Label creator: Templates: new/edit form

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68965|0   |1
is obsolete||
  Attachment #68967|0   |1
is obsolete||

--- Comment #34 from Simon Pouchol  ---
Created attachment 68973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68973=edit
Bug 19522: Label creator - some strings are not translatable

Add missing case to make "Fields to print" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout
3. ensure that the list isn't empty
4. then you should see "Fields to print" in the table header
5. apply this patch
6. update the language
7. open misc/translator/po/fr-FR-staff-prog.po
8. translate the new string with something like "foobar"
   and remove the fuzzy flag
9. install the language
10. refresh the page
11. then you should see "foobar" instead of "Fields to print"

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price diplay on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

--- Comment #7 from sandbo...@biblibre.com  ---
Created attachment 68972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68972=edit
Bug 19479: Patch to format totals according to the CurrencyFormat syspref.

On the page acqui/basketgroup.pl the prices of baskets should be shown
according to the selected CurrencyFormat syspref.

Test plan:

1) Create some baskets with items in them.
2) Go to acqui/basketgroup.pl page and check that the price format matches
   the current CurrencyFormat syspref.
3) Go to Administration and change CurrencyFormat syspref to one of the other
   available options and recheck step 2.

https://bugs.koha-community.org/show_bug.cgi?id=19479

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price diplay on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com

--- Comment #6 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19479] Price diplay on a basketgroup

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19479

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #68849|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68616|0   |1
is obsolete||

--- Comment #31 from Simon Pouchol  ---
Created attachment 68969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68969=edit
Bug 19522: Label creator: translate empty list message

The name of the element wasn't translated in the message.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. ensure that the list is empty
4. then you should see "pas de Batches actuellement"
5. then you should see "créer un nouveau batch."
6. apply this patch
7. install the language
8. refresh the page
9. then you should see "pas de Lots actuellement"
10. then you should see "créer un nouveau lot ."

Signed-off-by: Your Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68739|0   |1
is obsolete||

--- Comment #32 from Simon Pouchol  ---
Created attachment 68970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68970=edit
Bug 19522: Label creator: edit batch: make Call number translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. then you should see "Call number" in the column names
6. apply this patch
7. install the fr_FR locale
8. refresh the page
9. then you should see "Cote" in the column names

Signed-off-by: Your Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68964|0   |1
is obsolete||

--- Comment #33 from Simon Pouchol  ---
Created attachment 68971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68971=edit
Bug 19522: Label creator: edit batch: make "Export label" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. Switch the language to French if you haven't done it yet
6. click on "Exporter le lot entier"
7. then you should see "Export labels"
8. apply this patch
9. install the language
10. replay steps 2 to 6
11. then you should see "Exporter des étiquettes"

Signed-off-by: Simon Pouchol 

Signed-off-by: Your Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68613|0   |1
is obsolete||

--- Comment #28 from Simon Pouchol  ---
Created attachment 68966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68966=edit
Bug 19522: Coding style: Fix alignement after previous patch

Signed-off-by: Your Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68615|0   |1
is obsolete||

--- Comment #30 from Simon Pouchol  ---
Created attachment 68968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68968=edit
Bug 19522: Coding style: Replace tabs with spaces

In Label creator: Templates: new/edit form

Signed-off-by: Your Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

--- Comment #29 from Simon Pouchol  ---
Created attachment 68967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68967=edit
Bug 19522: Label creator - some strings are not translatable

Templates: new form:
Add hardcoded unit names to make them translatable.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-edit-template.pl?op=new
3. then you should see the "Unités" dropdown with english units
4. apply this patch
5. install the language
6. refresh the page
7. then you should see the "Unités" dropdown with french units

Signed-off-by: Your Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68612|0   |1
is obsolete||
  Attachment #68614|0   |1
is obsolete||

--- Comment #27 from Simon Pouchol  ---
Created attachment 68965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68965=edit
Bug 19522: Label creator - some strings are not translatable

Add missing case to make "Fields to print" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=layout
3. ensure that the list isn't empty
4. then you should see "Fields to print" in the table header
5. apply this patch
6. update the language
7. open misc/translator/po/fr-FR-staff-prog.po
8. translate the new string with something like "foobar"
   and remove the fuzzy flag
9. install the language
10. refresh the page
11. then you should see "foobar" instead of "Fields to print"

Signed-off-by: Your Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13915] Inventory tool no longer hides items with date last seen greater than the inventory date

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Failed QA   |RESOLVED
 Resolution|--- |FIXED

--- Comment #6 from Marcel de Rooy  ---
Seems this could be closed in favor of bugs 12913/14399.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #3 from Marcel de Rooy  ---
(In reply to Kyle M Hall from comment #2)
> 1) Remove line 893 ( what is it's purpose? )
Remove MARC punctuation that seems to end the sentence. too early :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19578] TT syntax for notices - There is no way to pre-process DB fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19578

--- Comment #2 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #0)
> Jenkins fails (run 287) on a test in
> t/db_dependent/Letters/TemplateToolkit.t:
> 
> With the historical syntax:
> # Your request for an article from tQYRS (c3Av58O0P5xkkIGu) has been
> canceled for the following reason:
> 
> With the TT syntax:
> # Your request for an article from tQYRS_ (c3Av58O0P5xkkIGu) has
> been canceled for the following reason:
> 
> The last character of the biblio's title has been removed because it's a
> punctuation character.
> It comes from: C4::Letters::_parseletter
>  893 $val =~ s/\p{P}$// if $val && $table=~/biblio/;
> 
> The same replacement is done for patron's attributes too.
> 
> With the TT syntax we retrieve the objects and send them to the template,
> without fetching the attributes.
> To restore this behaviour we could apply this regex on all the fields of the
> biblio objects, but it could be perf killer (we will process fields that we
> will certainly not used in the template).
> I thought about the TT filter we could apply on all the variables we
> display, but we will not know where come from the data, and we need to apply
> this change only for the biblio table.
> 
> Any other ideas?

I think there are two valid options:
1) Remove line 893 ( what is it's purpose? )
2) Add a TT filter like you suggest. I think if we just apply it to any TT
syntax that contains ".biblio" within TT tags ( something like
/^\[%.*biblio\..*%\]$/ ) it would be safe.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13560] need an add option in marc modification templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13560

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||victor.grous...@biblibre.co
   ||m

--- Comment #7 from Victor Grousset/tuxayo  ---
Conflict when applying the patch.
In t/db_dependent/MarcModificationTemplates.t

<<< ff82c9aadc441f9ca18dcad2e58783e733cdd839 (from November 3 on master)
use Test::More tests => 96;

||| merged common ancestors
use Test::More tests => 95;

===
use Test::More tests => 114;
>>> Bug 13560 - need an add option in marc modification templates
 (this patch's version)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #68740|0   |1
is obsolete||

--- Comment #26 from Simon Pouchol  ---
Created attachment 68964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68964=edit
Bug 19522: Label creator: edit batch: make "Export label" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. Switch the language to French if you haven't done it yet
6. click on "Exporter le lot entier"
7. then you should see "Export labels"
8. apply this patch
9. install the language
10. replay steps 2 to 6
11. then you should see "Exporter des étiquettes"

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Nick Clemens  changed:

   What|Removed |Added

Summary|Differences in whitespace   |Differences in field ending
   |cause duplicate facets  |(whitespace, punctuation)
   ||cause duplicate facets

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #20 from Marcel de Rooy  ---
(In reply to Nick Clemens from comment #13)
> (In reply to Marcel de Rooy from comment #11)
> > Upload local cover image
> > Upload status: Failed - (2) Root directory for uploads not defined
> > No, the directory was not writable.
> > This went wrong since the errcode is 2, but you forgot to add a zero entry
> > in you errMsgs array. So they are one position out of sync.
> > Please add a leading entry here (see also upload.tt)
> > var errMsgs = [ _("File already exists"), _("Directory is not writeable"),
> > _("Root directory for uploads not defined"), _("Temporary directory for
> > uploads not defined") ];
> > Adjust same thing in two other places ?
> Adjusted :-)

Works now. Thanks

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68365|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68941|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #18 from Marcel de Rooy  ---
Created attachment 68962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68962=edit
Bug 19420: (Follow-up) Add errors on other pages

Fix error array (add '0' value)
Update errors on other places using upload.js

Eventually these should all be using the same code in a js file

upload.tt already dealt with these errors, but has diff code, made it
work with new error syntax

Signed-off-by: Marcel de Rooy 
Amended: Removed the added js comment in upload.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68909|0   |1
is obsolete||

--- Comment #17 from Marcel de Rooy  ---
Created attachment 68961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68961=edit
Bug 19420: (QA Follow-up) Fix test, correct POD

The test needs the code level in the error hash now.
And POD is adjusted accordingly.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #16 from Marcel de Rooy  ---
Created attachment 68960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68960=edit
Bug 19420: Improve display of errors from failure of uploading file during
stage import

To test:
1 - sudo chown www-data:www-data /tmp/koha_kohadev_upload/ (or your
relevant dir and user)
2 - Attempt to stage a file
3 - Error message is: Upload status: Failed
4 - Apply patch
5 - Repeat upload
6 - Error is now: Failed - Directory is not writeable:
/tmp/koha_kohadev_upload
7 - Trigger the other errors if you can and note better responses

Signed-off-by: Katrin Fischer 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #19 from Marcel de Rooy  ---
Created attachment 68963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68963=edit
Bug 19420: (QA Follow-up) Change in error reporting affects upload.pl

The change from the first patch requires a similar change in upload.pl
when a few error codes are passed to the template.

Signed-off-by: Marcel de Rooy 
Tested by deleting a temporary file manually and downloading or deleting
the file from the upload search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

--- Comment #15 from Marcel de Rooy  ---
(In reply to Nick Clemens from comment #13)
> Removed, I though we only passed 1-4 back in the pm file, my apologies

Ah. See the last follow-up. upload.pl passed these codes.
As you already said, this still needs some improvement. I crossed a TODO also.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains '

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Severity|normal  |major

--- Comment #2 from Victor Grousset/tuxayo  ---
Still happens on master as of today.
Also, as a consequence, it's vulnerable to XSS. Putting
"alert(123)" in the description works.


Idea to fix: escape in the template with replace()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #27 from Séverine Queune  ---
(In reply to Katrin Fischer from comment #24)
> Hi all, trying to understand this bug a bit better. Could you explain the
> use case for your library a bit? What is the additional not-for-loan used
> for? Why is it needed in addition to the lost setting?

Hi Katrin,

Some libraries interested with this enhancement may prefer using 'notforloan'
instead of the 'itemlost' field (the one we'll use), so we asked for these 2
options to feet the different local usages.
We understand it adds a difficulty for this development.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #26 from Séverine Queune  ---
(In reply to Jonathan Druart from comment #23)
> Suggestion 1:
> Bug 11629 adds UpdateNotForLoanStatusOnCheckin and bug 14576 adds
> UpdateitemLocationOnCheckin.
> Both have the same behaviour: it will update the NotForLoan or Location
> value of the checked in item following the rules defined in the sysprefs.
> For instance: 
>NEW: FIC
>FIC: GEN
> will modified the value of location to FIC if was NEW, and to GEN if was FIC.
>
> I am not sure it makes sense for us here, but we could imagine a new pref
> UpdateItemWhenLost which could be filled with:
>   itemlost: 1
>   notforloan: 2
> which will work for any fields of the items table.
> 
> Suggestion 2:
> We already have a DefaultLongOverdueLostValue, would it make sense to use it
> here too?
> 
> Suggestion 3:
> We add 2 other sysprefs: UpdateNotForLoanStatusWhenLost and
> UpdateItemLostWhenLost (weird name)
> 
> Suggestion 4:
> We display the different LOST authorised values on the "Holds awaiting
> pickup" page, like it is on the "Items details" page for Lost, Damaged and
> Withdrawn.
> 
> Vote by text message, send 1, 2, 3 or 4 to 0424242


Sorry for the delay...
We vote suggestion 1.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15814] Templates for MARC modification: Edit action does not work when Description contains '

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15814

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #22 from Alex Arnaud  ---
(In reply to Alex Arnaud from comment #21)
> (In reply to David Bourgault from comment #20)
> > Test plan works as described, but QA tools warns of forbidden patterns.
> > 
> > koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.
> > inc
> >FAIL   forbidden patterns
> > forbidden pattern: Do not use line breaks inside template tags 
> > (bug 18675)
> > (line 5)
> 
> Hello David,
> 
> I have no warning when launching the qa script (koha-qa.pl -v 3 -c 1)
> For the file subscription_daily_choice file i got:
> 
>  OK
> koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.
> inc
>OK forbidden patterns
>OK git manipulation
>OK spelling
>OK tt_valid
>OK valid_template

Sorry you are right. My QA tools was not up to date

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19420] Improve display of errors from failure of uploading file during stage import

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19420

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #14 from Marcel de Rooy  ---
Looking here again. I still found an issue. Please wait..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds awaiting pickup ' list

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #25 from Nicolas Legrand  ---
Hey Katrin,

we use on shelf holds to pick documents from our stacks. Sometimes, the
document which is in the catalogue is no more in stacks. When we cancel the
hold, it is cancelled silently. Our patrons don't understand why it disappeared
and may ask it again.

So, we want our patrons to be informed, and we want to mark the item as lost so
it cannot be asked again and again. Those who fetch the books are not always
those who edit the catalogue, we would like them to modify the item without
having to open the cataloguing module.

Is it more clear? Best regards,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656

--- Comment #21 from Alex Arnaud  ---
(In reply to David Bourgault from comment #20)
> Test plan works as described, but QA tools warns of forbidden patterns.
> 
> koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.
> inc
>FAIL forbidden patterns
>   forbidden pattern: Do not use line breaks inside template tags 
> (bug 18675)
> (line 5)

Hello David,

I have no warning when launching the qa script (koha-qa.pl -v 3 -c 1)
For the file subscription_daily_choice file i got:

 OK
koha-tmpl/intranet-tmpl/prog/en/includes/serials/subscription_daily_choice.inc
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #43 from Marcel de Rooy  ---
Would have preferred to see a test for GetOverduesForBranch, but it is not a
blocker for me.
A rename of this sub would be nice too (see FIXME). Something like
GetOverduesWithFines ?
Similarly, it is weird that the script branchoverdues.pl (whats in a name) does
not list Overdues with fines in the header but just Overdues.
Apart from these observations, it is wonderful to see dead code moving out !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68920|0   |1
is obsolete||

--- Comment #42 from Marcel de Rooy  ---
Created attachment 68959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68959=edit
Bug 10021: (QA follow-up) Rename variables

To avoid $account, $accounts and @accounts variables in the same scope

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68798|0   |1
is obsolete||

--- Comment #41 from Marcel de Rooy  ---
Created attachment 68958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68958=edit
Bug 10021: Restore "Pay fines" list

Previous changes were wrong, the notify_id was always equal to 1 and
GetBorNotifyAcctRecord was used to retrieved the account lines to pay

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68797|0   |1
is obsolete||

--- Comment #40 from Marcel de Rooy  ---
Created attachment 68957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68957=edit
Bug 10021: Remove notify columns in circ/branchoverdues.tt

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68794|0   |1
is obsolete||

--- Comment #37 from Marcel de Rooy  ---
Created attachment 68954
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68954=edit
Bug 10021: Drop columns notify_id and notify_level from accountlines

It appears that has never worked.
Could someone confirm?

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10021] Remove dead code related to notifys

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68796|0   |1
is obsolete||

--- Comment #39 from Marcel de Rooy  ---
Created attachment 68956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68956=edit
Bug 10021: Remove accountlines columns - DBIC Schema changes

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/