[Koha-bugs] [Bug 19609] New: BARCODING

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19609

Bug ID: 19609
   Summary: BARCODING
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: Linux
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: cnighswon...@foundations.edu
  Reporter: jabbarelaya...@gmail.com
QA Contact: testo...@bugs.koha-community.org

HOW CAN I PRINT BARCODES THROUGH KOHA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||david.bourga...@inlibro.com

--- Comment #3 from David Bourgault  ---
QA tool passed
Works as described, but also prevents accentuated characters like é or à. For
category codes I think this is acceptable/preferable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

David Bourgault  changed:

   What|Removed |Added

  Attachment #69062|0   |1
is obsolete||

--- Comment #2 from David Bourgault  ---
Created attachment 69097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69097=edit
Bug 19560: Unable to delete library when branchcode contains special characters

This patch modifies the library administration page so that the library
delete button submits a form using POST rather than linking to the
delete operation with GET variables.

This patch also adds validation to the library entry form so that it
will only accept letters, numbers, hyphen, and underscore.

The validation method for this already existed in categories.js, so it
has been moved to staff-global.js and the validator warning message has
been moved to validator-strings.inc so it is included globally.

To test:
  - Add a library with a branchcode containing characters like & or
#.
  - Apply the patch and clear your browser cache if necessary.
  - Try to delete the new library. It should delete successfully.
  - Add a library again and try to include spaces and/or special
characters in the branchcode. The form validation script should
prevent you from submitting the form.
  - Go do Administration -> Patron categories and add a new patron
category. The category code field should prevent you from entering a
code with spaces or special characters.

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18235] Elastic search - Configurable facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com

--- Comment #14 from David Bourgault  ---
Also patch does not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300

Bouzid  changed:

   What|Removed |Added

  Attachment #67165|0   |1
is obsolete||

--- Comment #21 from Bouzid  ---
Created attachment 69096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69096=edit
Bug 11300 - Add a new authority linker which searches for authority links on a
Z39.50 server.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19604] Elasticsearch Fixes for build_authorities_query for auth searching

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19604

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com
 Status|Needs Signoff   |Failed QA

--- Comment #2 from David Bourgault  ---
I did a search for 'me' from the OPAC's Auth search.

With Zebra I got 1411 results (some, but not all, matching on 'mé')
With ES I got a single result, in which the word 'Me' was found as-is

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||david.bourga...@inlibro.com

--- Comment #7 from David Bourgault  ---
Tests passed
Works as described

QA tools threw errors, as David Gustafsson said. I corrected and amend the
patch accordingly.

QA tools passed green

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

David Bourgault  changed:

   What|Removed |Added

  Attachment #68943|0   |1
is obsolete||

--- Comment #6 from David Bourgault  ---
Created attachment 69095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69095=edit
Bug 19580: Exclude period as splitting character for autotrunction

To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number.raw:"4"' (or a vlid biblionumber)
7 - should get expected result

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

David Bourgault  changed:

   What|Removed |Added

  Attachment #68942|0   |1
is obsolete||

--- Comment #5 from David Bourgault  ---
Created attachment 69094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69094=edit
Bug 19580: Unit tests

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

David Bourgault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||david.bourga...@inlibro.com

--- Comment #6 from David Bourgault  ---
QA tools green
Tests passed
Work as described. 

I could still values being set to null, but only as indicators of 00X fields,
which I assume is on purpose.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

David Bourgault  changed:

   What|Removed |Added

  Attachment #68948|0   |1
is obsolete||

--- Comment #4 from David Bourgault  ---
Created attachment 69092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69092=edit
Bug 19581: Remove 'split' option from Catmandu fixes for marc

This option in combination with append seems to add null entries in the indexes
for fields that don't exist. These fields then affect sorting. Removing it
solves
the issue

To test:
1 - Have an ES setup
2 - Catalog and index some records
3 - View a record in ES:
curl 'localhost:9200/koha_kohadev_biblios/data/4?pretty=yes'
4 - Note there are 'null' entries in the indexes, save this result for
comparison
5 - Apply patch
6 - Reindex, amking sure to delete existing indexes
perl misc/search_tools/rebuild_elastic_search.pl -d
7 - View the record again
8 - Note the null entries are removed
9 - Note indices are otherwise intact

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19581] Elasticsearch - Catmandu split option adds extra null fields to indexes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19581

David Bourgault  changed:

   What|Removed |Added

  Attachment #68949|0   |1
is obsolete||

--- Comment #5 from David Bourgault  ---
Created attachment 69093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69093=edit
Bug 19581: Unit tests

This patch makes a few changes to the tests to take into account the
change to indexing.

To test:
prove t/db_dependent/Koha_Elasticsearch_Indexer.t
Should return green

Signed-off-by: David Bourgault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #53 from Tomás Cohen Arazi  ---
(In reply to David Cook from comment #51)
> What does "issues retrieval" mean?

That was renamed 'checkouts retrieval'. It is related to checkout informations
:-P

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

--- Comment #52 from Tomás Cohen Arazi  ---
(In reply to Katrin Fischer from comment #36)
> functionality. Maybe too paranoid?

Yes :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895

Tomás Cohen Arazi  changed:

   What|Removed |Added

Summary|REST API: Add API routes|Add routes for checkouts
   |for checkouts retrieval and |retrieval and renewal
   |renewal |
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18458] Merging authority record incorrectly orders subfields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18458

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14769] Authorities merge: Set correct indicators in biblio field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14769

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10213] UniqueItemFields should be implemented for creating items in cataloguing and serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10213

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19591] Saving a system preference jumps to main page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19591

--- Comment #2 from Christian Stelzenmüller 
 ---
(In reply to Owen Leonard from comment #1)
> When you save a system preference the page shouldn't refresh at all. The
> change happens behind the scenes and a message should pop up briefly
> indicating success.
> 
> If you find that clicking the save button redirects the page, you might have
> a JavaScript error somewhere. Do you have something in the IntranetUserJS
> system preference?

There is indeed a js error:
"Error: Syntax error, unrecognized expression: .transl."

Maybe it's that. I'll ask Katrin on Monday, thanks :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19608] New: Move admin templates JavaScript to the footer: The rest

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608

Bug ID: 19608
   Summary: Move admin templates JavaScript to the footer: The
rest
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: jonathan.dru...@bugs.koha-community.org,
n...@bywatersolutions.com, simon.pouc...@biblibre.com,
testo...@bugs.koha-community.org
Depends on: 19594
Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for administration templates not already converted in
other patches.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

Alex Arnaud  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19594] Move admin templates JavaScript to the footer: MARC-related

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard  changed:

   What|Removed |Added

 Blocks||19608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19608


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19608
[Bug 19608] Move admin templates JavaScript to the footer: The rest
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17047] Mana Knowledge Base : share data

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047

--- Comment #176 from Alex Arnaud  ---
Created attachment 69091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69091=edit
Bug 17047 - Move ability to comment mana entities from search results table to
report/subscription detail page

+ code refactoring

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11210] Allow partial writeoff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #69001|0   |1
is obsolete||

--- Comment #9 from Simon Pouchol  ---
Created attachment 69090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69090=edit
Bug 11210 - Writeoff partial amounts

Minor changes to pay.pl and paycollect.tt to allow writing off a partial amount
of a fine.

Test plan:
0) Go to the Fines tab of a test patron's profile
1) Create a fine if there are none (under the Manual invoice tab)
2) Go to the "Pay fines" tab
3) Press the write off button on the corresponding account line

Without patch, you'll be asked to confirm, but will not be able to edit the
amount
With patch, you'll be able to edit the amount.

Followed test plan, patch worked as described. Also ran QA test tool and
modified files passed

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11210] Allow partial writeoff

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||simon.pouc...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Julian Maurice  changed:

   What|Removed |Added

  Attachment #62087|0   |1
is obsolete||

--- Comment #14 from Julian Maurice  ---
Created attachment 69087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69087=edit
Bug 18131: ES - Fix matching staged records

The code in C4::Matches::get_matches is terrible and a bug has been introduced
by bug 12478 because of its way to handle uniqueness.

If search engine is elastic, simple_search_compat returns array ref of
MARC::Record,
used as a string for the key of the matches hashref we get things like
"MARC::Record=HASH(0x8f76ab0)".
Yes, terrible...

The file is never staged and we get an internal server error:
stage-marc-import.pl: Can't locate object method "fields" via package
"MARC::Record=HASH(0x8f76ab0)" (perhaps you forgot to load
"MARC::Record=HASH(0x8f76ab0)"?) at /home/vagrant/kohaclone/C4/Biblio.pm line
2691

To recreate the issue:
- Set SearchEngine == Elastic
- Create a matching rule on 999$c (you need to edit the existing one and
specify
'Local-number' as search index, not 'local-number')
- Import a file with bibliographic records and use the matching rule you
defined.

Test plan:
Import authority and bibliographic records with Zebra and Elastic using a
matching rule.
Everything should work correctly.

Note: I found a bug when importing authorities using Elastic, see bug 17255
comment 38.

Signed-off-by: Nick Clemens 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Julian Maurice  changed:

   What|Removed |Added

  Attachment #68884|0   |1
is obsolete||

--- Comment #16 from Julian Maurice  ---
Created attachment 69089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69089=edit
Bug 18131: Followup - Use data if biblionumber_tag < 10

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18131] Matching staged records when using elastic search fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18131

Julian Maurice  changed:

   What|Removed |Added

  Attachment #62088|0   |1
is obsolete||

--- Comment #15 from Julian Maurice  ---
Created attachment 69088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69088=edit
Bug 18131: ES - Fix matching staged records - Authority

Occurrences of C4::AuthoritiesMarc::SearchAuthorities must be replaced
by search_auth_compat.

You need to define the search index of matching rule with one of the
values defined in %koha_to_index_name (from
Koha::SearchEngine::Elasticsearch::QueryBuilder::build_authorities_query_compat)

Signed-off-by: Nick Clemens 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19516] can't save changes on notices if letter is already created

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19516

Stefan Berndtsson  changed:

   What|Removed |Added

 CC||stefan.berndts...@ub.gu.se

--- Comment #1 from Stefan Berndtsson  ---
Created attachment 69086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69086=edit
Fix condition when updating an existing letter with language support turned on

There is a missing condition for "lang" in the UPDATE line in letter.pl.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575

--- Comment #3 from David Gustafsson  ---
Think I have missed a few places (facets for example) where field names are
hard coded and needs to be changes. So no point in trying out patch in it's
current state until these things are fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

--- Comment #4 from David Gustafsson  ---
Tried making this change myself but got "'fatal: sha1 information is lacking or
useless“ when apply a patch" when running git bz apply. Perhaps best to wait
until https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559 has been
commited and then reroll this patch on master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's date acquired field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's date acquired field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #9 from Marcel de Rooy  ---
In view of its rather trivial nature, passing QA in one run.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's date acquired field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

--- Comment #8 from Marcel de Rooy  ---
(In reply to Owen Leonard from comment #3)
> I consider this a bug BECAUSE it is a change in behavior. Functionality
> which my catalogers used daily has been removed, making their work more
> difficult.

There is difficult and difficult :) Clicking in the field would have triggered
the Focus event, but indeed it would not overwrite. But overwriting date
acquired might not be a good idea most of the time ..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's date acquired field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

--- Comment #7 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #4)
> (In reply to Marcel de Rooy from comment #1)
> > If you hover your mouse over the "plugin link", you will see "No popup".
> 
> I see "Tag editor"

Caused by the presence of a Click event

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19607] Move admin templates JavaScript to the footer: Basic parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's date acquired field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #69082|0   |1
is obsolete||

--- Comment #6 from Marcel de Rooy  ---
Created attachment 69085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69085=edit
Bug 19595: Clicking plugin link does not fill item's date acquired field

This patch updates the dateaccessioned plugin for the item edit form to
return functionality which was removed in a previous patch.

To test, apply the patch and open an item for editing. Clicking the
"..." link next to the "Date acquired" field should insert the current
date, overwriting the existing date.

Open a blank item add form. Putting the cursor in the "Date acquired"
field should automatically insert the current date.

Signed-off-by: Marcel de Rooy 
Added a comment line in set_to_today.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's date acquired field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19607] Move admin templates JavaScript to the footer: Basic parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #69083|0   |1
is obsolete||

--- Comment #2 from Simon Pouchol  ---
Created attachment 69084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69084=edit
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19607] Move admin templates JavaScript to the footer: Basic parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19607] Move admin templates JavaScript to the footer: Basic parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

--- Comment #1 from Owen Leonard  ---
Created attachment 69083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69083=edit
Bug 19607: Move admin templates JavaScript to the footer: Basic parameters

This patch modifies the staff client catalog-related administration
templates so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
tabs, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19607


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607
[Bug 19607] Move admin templates JavaScript to the footer: Basic parameters
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19594] Move admin templates JavaScript to the footer: MARC-related

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594

Owen Leonard  changed:

   What|Removed |Added

 Blocks||19607


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607
[Bug 19607] Move admin templates JavaScript to the footer: Basic parameters
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19607] New: Move admin templates JavaScript to the footer: Basic parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607

Bug ID: 19607
   Summary: Move admin templates JavaScript to the footer: Basic
parameters
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: jonathan.dru...@bugs.koha-community.org,
n...@bywatersolutions.com, simon.pouc...@biblibre.com,
testo...@bugs.koha-community.org
Depends on: 19560, 19594
Blocks: 17858

In order to conform to best practices for performance staff client template
javascript should be in the footer instead of the header.

This patch will do so for the "basic parameters" administration templates.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
[Bug 17858] Omnibus: Move staff client JavaScript to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560
[Bug 19560] Unable to delete library when branchcode contains special
characters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594
[Bug 19594] Move admin templates JavaScript to the footer: MARC-related
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Owen Leonard  changed:

   What|Removed |Added

 Blocks||19607


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19607
[Bug 19607] Move admin templates JavaScript to the footer: Basic parameters
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's date acquired field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's date acquired field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

--- Comment #5 from Owen Leonard  ---
Created attachment 69082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69082=edit
Bug 19595: Clicking plugin link does not fill item's date acquired field

This patch updates the dateaccessioned plugin for the item edit form to
return functionality which was removed in a previous patch.

To test, apply the patch and open an item for editing. Clicking the
"..." link next to the "Date acquired" field should insert the current
date, overwriting the existing date.

Open a blank item add form. Putting the cursor in the "Date acquired"
field should automatically insert the current date.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19603] Move admin templates JavaScript to the footer: Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

--- Comment #4 from Simon Pouchol  ---
Yes I did, followed the same steps as for signing off bug 19601.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19595] Clicking plugin link does not fill item's date acquired field

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19595

Owen Leonard  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19603] Move admin templates JavaScript to the footer: Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

--- Comment #3 from Owen Leonard  ---
Did you apply the patch for Bug 19594 first?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC only appears / works if no other list already exists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Simon Pouchol  changed:

   What|Removed |Added

 CC||simon.pouc...@biblibre.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19573] Link to make a new list in masthead in OPAC only appears / works if no other list already exists

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19573

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #69067|0   |1
is obsolete||

--- Comment #2 from Simon Pouchol  ---
Created attachment 69081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69081=edit
Bug 19573: Link to make a new list in masthead in OPAC only appears / works if
no other list already exists

This patch corrects the OPAC masthead include file so that the "New
list" link will appear whether or not the logged-in user has existing
private lists.

To test, apply the patch and log into the OPAC as both a user with
private lists and a user without private lists. The header's "Lists"
dropdown menu should include a "New list" link in both cases.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18990] Overdue Notices are not sending through SMS correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18990] Overdue Notices are not sending through SMS correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #67686|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 69080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69080=edit
Bug 18990 - Overdue Notices are not sending through SMS correctly

Bug 18478 fixed sms via email problems under the assumption that
to_address was either smsalertnumber or blank.

It seems overdues set the to_address to email. This patch changes the
code to enforce that an sms sent with emial driver will use the
smsalertnumebr and provider defined for the borrower, regardless of what
is set in the queue

To test:
 1 - Define a messaging prefs for a patron to recieve hold notices via
  SMS
 2 - Ensure you have defined an SMS message for an overdue letter
 3 - Set an SMS alert number for patron
 4 - Set the SMS::Send driver to 'Email'
 5 - Checkout an item as overdue to trigger notice above
 6 - Run overdue_notices.pl
 6 - Check the db and note the address is email
 7 - run process_message_queue.pl
 8 - Check db - address is email followed by service provider
 9 - Apply patch
 10 - repeat
 11 - Message to_address should be populated with smsalertnumber

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18990] Overdue Notices are not sending through SMS correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18990

Marcel de Rooy  changed:

   What|Removed |Added

Version|16.11   |master
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19602] Add usage statistics link to administration sidebar menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||simon.pouc...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19602] Add usage statistics link to administration sidebar menu

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19602

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #69073|0   |1
is obsolete||

--- Comment #2 from Simon Pouchol  ---
Created attachment 69079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69079=edit
Bug 19602 - Add usage statistics link to administration sidebar menu

This patch adds a link to the new usage statistics page in the
administration sidebar menu.

To test, apply the patch and view an administration page which includes
the admin sidebar. Confirm that the link to usage statistics is there.

Visit the usage statistics page and confirm that the usage statistics
link in the sidebar is display in bold.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19603] Move admin templates JavaScript to the footer: Patrons and circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19603

--- Comment #2 from Simon Pouchol  ---
Hi Owen,
I was unable to apply this patch :
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19601] Move admin templates JavaScript to the footer: Additional parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

Simon Pouchol  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19601] Move admin templates JavaScript to the footer: Additional parameters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19601

Simon Pouchol  changed:

   What|Removed |Added

  Attachment #69055|0   |1
is obsolete||

--- Comment #2 from Simon Pouchol  ---
Created attachment 69078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69078=edit
Bug 19601: Move admin templates JavaScript to the footer: Additional parameters

This patch modifies the staff client "additional parameters"
administration templates so that JavaScript is included in the footer
instead of the header.

To test, apply the patch and test the JavaScript-driven features of
each page: All button controls, DataTables functionality, tabs, etc.

Signed-off-by: Simon Pouchol 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Marcel de Rooy  changed:

   What|Removed |Added

Version|16.11   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #67520|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy  ---
Created attachment 69077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69077=edit
Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message

If a hold is 'waiting' for the patron to collect then the patron should be
prevented from cancelling the hold via their account in the opac.
If a patron tries to cancel the hold, Koha will give an 'are you sure' alert
and when you click Yes the page just refreshes and the hold remains.
Staff can cancel the hold from the staff interface but they can then action the
waiting hold.
I think therefore that it is correct behaviour that a patron cannot cancel a
hold when it reaches waiting state via the opac but it would be useful to
either have a warning to prevent the cancellation or a useful message when they
attempt to do so.

The template was using a method that tells Koha if *staff* can cancel a hold,
instead of patron.

Test Plan:
1) Set up a waiting hold
2) Try to cancel it from the opac
3) Note you cannot
4) Apply this patch
5) Reload the page
6) Note the cancel button has disappeared for found holds

Signed-off-by: Kyle M Hall 
Signed-off-by: Caroline Cyr La Rose 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #6 from Marcel de Rooy  ---
Just confirming the above by doublechecking the code:
Cancel button calls opac-modrequest.pl (once called only in opac-user)
opac-modrequest.pl checks with CanReserveBeCanceledFromOpac. This sub returns
false for waiting or transit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19439] Some error responses from opac/unapi get lost in eval

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19439

Marcel de Rooy  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Marcel de Rooy  ---
Jonathan: Would you consider this one as a bugfix too ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for sorting in mappings.yaml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

--- Comment #6 from Julian Maurice  ---
Patch works as described (except for popularity when in UNIMARC, since the
field is not defined).
But I wonder about 6th step in test plan. Shouldn't it be done in an
updatedatabase script ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19481] Elasticsearch - Set default fields for sorting in mappings.yaml

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19481

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 QA Contact||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16820] Add possibility to edit fines

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16820

--- Comment #4 from Katrin Fischer  ---
Please also consider to add a separate permission for this, some libraries
might consider it dangerous or not want everyone to be able to do this.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19036] Number payment receipts / payment slips

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19036

Katrin Fischer  changed:

   What|Removed |Added

Summary|Numer payment receipts /|Number payment receipts /
   |payment slips   |payment slips

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Julian Maurice  changed:

   What|Removed |Added

  Attachment #68925|0   |1
is obsolete||

--- Comment #10 from Julian Maurice  ---
Created attachment 69076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69076=edit
Bug 19559 - Add '-' to list of characters we don't split search terms on

Test plan assumes
QueryAutoTruncate = automatically
SearchEngine = Elasticsearch

To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number:"4"' (or a vlid biblionumber)
7 - should get expected result

Signed-off-by: David Bourgault 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Julian Maurice  changed:

   What|Removed |Added

  Attachment #68924|0   |1
is obsolete||

--- Comment #9 from Julian Maurice  ---
Created attachment 69075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69075=edit
Bug 19559 - Unit tests

Signed-off-by: David Bourgault 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19559] Elasticsearch QueryAutoTruncate truncate field names with hyphens if data is quoted

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19559

Julian Maurice  changed:

   What|Removed |Added

 QA Contact||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19606] New: 773$g is not showing if 773$0 - MARC21slim2OPACDetail.xsl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19606

Bug ID: 19606
   Summary: 773$g is not showing if 773$0 -
MARC21slim2OPACDetail.xsl
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ha...@orex.es
QA Contact: testo...@bugs.koha-community.org

we have seen a possible bug in MARC21slim2OPACDetail.xsl

We have identified for those bibliographic records that have 773$t and 773$g
and 773$0, Koha only show 773$t, because 773$g is not declare when 773$0, it is
declared in all other cases.


It is-->

 /cgi-bin/koha/opac-detail.pl?biblionumber=
 
 

It is -->
 
 /cgi-bin/koha/opac-detail.pl?biblionumber=
 
 

; 
 

do you agree?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/