[Koha-bugs] [Bug 19684] Colon char in MARC data breaks facets

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19684

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||Academy
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #37 from Liz Rea  ---
These are functionality notes for Aleisha

OPAC client view:

We probably want to show the borrower when the book is now expected to be
returned by on /cgi-bin/koha/opac-recalls.pl

Staff views:

- syspref needs to be defaulted to off please :)

/cgi-bin/koha/circ/recalls_queue.pl
- probably want to see the new due date here as well

/cgi-bin/koha/catalogue/detail.pl?biblionumber=16
- do we want to see what the old due date was here? (to think about, not
required)
- Probably want to show somewhere in the item table that there is a recall, and
for whom (kinda like we do with holds)
- do we want a tab on the detail page that shows all of the recalls for this
biblio, and who they are for?

General questions: 

- If we add an item with the same item type to a biblio that has a recall,
should checking in this newly available item trigger the recall to be filled?

I'm out of time for this run at it, but honestly what a great first whack at
it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308

--- Comment #19 from Alex Buckley  ---
Hi Dominic 

thanks for testing the patch, can you please try again and apply bug 19514
first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Item number in biblio description in fine page

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Alex Buckley  changed:

   What|Removed |Added

   Assignee|amitddng...@gmail.com   |alexbuck...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19718] New: Create message for patrons with multiple holds on the same item

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718

Bug ID: 19718
   Summary: Create message for patrons with multiple holds on the
same item
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ka...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

One of our partners allows 3 holds per record. They have noticed that patrons
will place multiple holds on an item that they have already placed on hold. 

They would like for Koha to display a message to the patron when they place a
hold on an item they already have on hold. Their suggested message is "You
already have placed a hold on this record. Are you sure you want to place
another?"

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19717] New: Dependency on deprecated Swagger2 whose installation fails

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19717

Bug ID: 19717
   Summary: Dependency on deprecated Swagger2 whose installation
fails
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: federicol...@tiscali.it
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

Created attachment 69425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69425=edit
Assorted failures

I'm installing koha 17.05 on fedora 25 and the web installer complains I didn't
install Swagger2. CPAN logs are very keen on informing me repeatedly that
"Mojolicious::Plugin::Swagger2 is deprecated in favor of 
Mojolicious::Plugin::OpenAPI".

If I do "cpanm experimental Test::Mojo", then "cpanm
Mojolicious::Plugin::Swagger2" fails with just one test failure, so I'm forced
to use the -n option to disable the tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Mike  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||paul.poul...@biblibre.com
 Status|NEW |In Discussion
Summary|New EU General Data |[omnibus] GDPR (General
   |Protection Regulation 2018  |Data Protection Regulation)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19716] Add option to send header line for CSV output

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19716] Add option to send header line for CSV output

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716

--- Comment #1 from Kyle M Hall  ---
Created attachment 69424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69424=edit
Bug 19716 - Add option to send header line for CSV output

Currently, if outputting a CSV file using runreport.pl, you need to look at the
report used to know what each column means. It would be nice if we could
include column headers.

Test Plan:
1) Apply this patch
2) Try using runreport.pl with --format csv --csv-header

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19716] New: Add option to send header line for CSV output

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19716

Bug ID: 19716
   Summary: Add option to send header line for CSV output
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Currently, if outputting a CSV file using runreport.pl, you need to look at the
report used to know what each column means. It would be nice if we could
include column headers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19318] Add ability to use custom file upload paths

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19715] Add the amount of contract's in the vendor' s détails page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19715

Patrick Robitaille  changed:

   What|Removed |Added

Summary|Add the amount of   |Add the amount of
   |contract's on the vendor's  |contract's in the vendor's
   |détails page.   |détails page.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19715] New: Add the amount of contract's on the vendor' s détails page.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19715

Bug ID: 19715
   Summary: Add the amount of contract's on the vendor's détails
page.
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: patrick.robitai...@collecto.ca
QA Contact: testo...@bugs.koha-community.org

Hi, 

In a vendor's page details, we can regist informations about contracts. We can
already add some informations like the contact details and ordering
informations but It would be nice to have the possibility to regist more
contract's informations. We could add somne champs fot the amount of the
contract. Afther that we could use this information as a limit not to exceed
when we make orders with this vendor. 

Patrick

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2093] Add OPAC dashboard for logged-in users

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2093

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #11 from Joy Nelson  ---
Ah!  I see.  Yes, escaping or restricting would work.  I can't say I have a
preference in the matter.  

Thanks!
joy

(In reply to Jonathan Druart from comment #10)
> Joy, What I tried to say is: If we escape correctly the variable, we will
> not have problem to delete a library with branchcode=A, see the follow-up.
> I am so wondering if it is really useful to restrict the code to a-Z0-9_-

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #10 from Jonathan Druart  
---
Joy, What I tried to say is: If we escape correctly the variable, we will not
have problem to delete a library with branchcode=A, see the follow-up.
I am so wondering if it is really useful to restrict the code to a-Z0-9_-

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #9 from Jonathan Druart  
---
Created attachment 69423
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69423=edit
Bug 19560: Correctly escape branchcode in admin/branches.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

--- Comment #8 from Joy Nelson  ---
Jonathon,
I encountered this because a library was adding a branch for "Art &
Architecture" as A
When they decided to go with a different naming convention, they were unable to
delete the branch.

joy


(In reply to Jonathan Druart from comment #7)
> This patch does 2 things:
> 1. Only accept few chars for branchcode (accentuated chars are rejected)
> 2. Fix the deletion problem if a branchcode contains special characters
> 
> It may be a problem for non latin alphabets to restrict as possiblities. Do
> we have known problems with branchcode containing special chars?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #36 from Tomás Cohen Arazi  ---
Comment on attachment 69102
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69102
Bug 19532: Cancel recall and see recalls in OPAC


>+=head3 branch
>+
>+Returns the related Koha::Library object for this Hold
>+
>+=cut
>+
>+sub branch {
>+my ($self) = @_;
>+
>+$self->{_branch} ||= Koha::Libraries->find( $self->branchcode() );
>+
>+return $self->{_branch};
>+}

Please call this method 'library' instead, and 'patron' instead of 'borrower'
on the followup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19532] Recalls for Koha

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532

--- Comment #35 from Tomás Cohen Arazi  ---
Comment on attachment 68572
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68572
Bug 19532: Module files for Recall and OldRecall

>Koha/Recall.pm
>Koha/Recalls.pm
>Koha/Old/Recall.pm
>Koha/Old/Recalls.pm
>and the schema files for Recall and OldRecall.

I agree we should avoid old_*, probably index definitions are relevant for
performance (speed, because they will eat more hard disk space of course).

>+=head2 Class Methods

This are usually labeled 'Internal methods', to distinguish them from public
'Class methods'. Fix the case.

>+=head3 type
>+
>+=cut
>+
>+sub type {
>+return 'OldRecall';
>+}

This should be called '_type'. Look at Koha/Object.pm:260, a sample place it is
used. If it is not well documented, please file a bug for it!

>+=head2 found
>+
>+  data_type: 'varchar'
>+  is_nullable: 1
>+  size: 1

Please use tinyint(1) for booleans. While it is not a real type (it is an
integer with a mask), it clearly denotes its use. If you plan to expose this
through the api, having it be VARCHAR will make our stack consider it a string.
If you set it a numeric type, then we can add:

__PACKAGE_->add_columns({

  '+found' => { is_boolean => 1 }

});

to the schema file, and thus it is considered a Boolean when rendering on the
API.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19560] Unable to delete library when branchcode contains special characters

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19560

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |In Discussion

--- Comment #7 from Jonathan Druart  
---
This patch does 2 things:
1. Only accept few chars for branchcode (accentuated chars are rejected)
2. Fix the deletion problem if a branchcode contains special characters

It may be a problem for non latin alphabets to restrict as possiblities. Do we
have known problems with branchcode containing special chars?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |In Discussion
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
What about the other occurrence of is_cancelable in the same template file?

 695 [% IF ( RESERVE.is_cancelable ) %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14828] Move the item types related code to Koha::ItemTypes

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19646


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646
[Bug 19646] value_builder marc21_linking_section template is broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19646] value_builder marc21_linking_section template is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

Jonathan Druart  changed:

   What|Removed |Added

   Severity|normal  |major
 Depends on||14828

--- Comment #8 from Jonathan Druart  
---
Caused by commit aafe73eefb5151454fa8957bf188768324d23955
Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828
[Bug 14828] Move the item types related code to Koha::ItemTypes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19683] Export.pl does not populate the Authority Types dropdown correctly

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Depends on||15381

--- Comment #4 from Jonathan Druart  
---
Caused by commit 7283069a9d3b2ffb2edc31022d96bb4aea107098
Bug 15381: Remove getauthtypes and getauthtype


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381
[Bug 15381] Move the authority types related code to Koha::Authority::Type[s] -
part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15381] Move the authority types related code to Koha::Authority::Type [s] - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15381

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19683


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19683
[Bug 19683] Export.pl does not populate the Authority Types dropdown correctly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the checkout is due in the future

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #6 from Jonathan Druart  
---
(In reply to Caroline Cyr La Rose from comment #5)
> Hi Jonathan,
> 
> I'm having trouble testing this. Which cron job are we supposed to run? Is
> it automatic_renewals.pl --send-notices?

Yes

> Furthermore, I had an item due in the future (in december) and I still
> received a notice saying the auto renewal failed because I had fines (which
> was true). But why would it try to renew something due in december?

You need to tune that using the 'No automatic renewal before/after' settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19411] opac-shelves.tt : the opaccredits block should be outside of the main

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411

--- Comment #3 from David Bourgault  ---
Created attachment 69422
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69422=edit
opac-shelves.tt in Chrome element inspector

It might have been my database causing the issue in opac-advsearch.tt, but
after clearing all html/css/js from my database, on master branch I could still
reproduce the issue for opac-shelves.tt

As you can see in the file attached, the comment for closing main is two levels
deeper than it should.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11751] Some code related to "institution" is unused and obsolete

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19714


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714
[Bug 19714] 2 occurrences of memberofinstitution have not been removed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19714] New: 2 occurrences of memberofinstitution have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19714

Bug ID: 19714
   Summary: 2 occurrences of memberofinstitution have not been
removed
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 11751

C4/UsageStats.pm:memberofinstitution
t/db_dependent/UsageStats.t:memberofinstitution


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11751
[Bug 11751] Some code related to "institution" is unused and obsolete
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19713] New: 2 occurrences of OpacShowLibrariesPulldownMobile have not been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713

Bug ID: 19713
   Summary: 2 occurrences of OpacShowLibrariesPulldownMobile have
not been removed
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 12513

t/db_dependent/UsageStats.t:OpacShowLibrariesPulldownMobile
C4/UsageStats.pm:OpacShowLibrariesPulldownMobile


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513
[Bug 12513] PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile
system preference
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12513] PROG/CCSR deprecation: Remove OpacShowLibrariesPulldownMobile system preference

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12513

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19713


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19713
[Bug 19713] 2 occurrences of OpacShowLibrariesPulldownMobile have not been
removed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19712] New: Fix command line options of delete_records_via_leader.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19712

Bug ID: 19712
   Summary: Fix command line options of
delete_records_via_leader.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mag...@libriotech.no
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

1. This code:

  56  if ( $help || !$confirm ) {
  57 
...
  70 exit();
  71 }

means that unless you specify --confirm you will never be able to run the
script - it will just print the usage and exit. That means --test is useless. 

2. The script has both of these options:

 -c --confirm: Script will do nothing without this parameter
 -t --test: Test mode, does not delete records.

What happens if you specify both? Or none? I think test mode should be the
default (when no options are specified) and changes to the database should only
be done when --confirm is specified. This would be consistent with other
scripts, I think.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19710] Move plugins templates javascript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19710] Move plugins templates javascript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710

Claire Gravely  changed:

   What|Removed |Added

  Attachment #69419|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 69421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69421=edit
Bug 19710: Move plugins templates javascript to the footer

This patch modifies the staff client plugins template so that
JavaScript is included in the footer instead of the header.

To test, apply the patch and test the JavaScript-driven features of
the modified template:

- The plugins link should be bold in the sidebar menu.
- Choosing "Uninstall" for an installed plugin should trigger a
  confirmation alert.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19411] opac-shelves.tt : the opaccredits block should be outside of the main

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19411

--- Comment #2 from Owen Leonard  ---
I don't see a different between opac-shelves.tt, opac-advsearch.tt, and
opac-main.tt in the placement of opaccredits. Could you double-check? Do you
have any custom HTML (opacheader, opacmain, etc.) which might be causing the
HTML to be off?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17721] Do we need utf8_bin collation on tagsubfield?

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17721

--- Comment #5 from Nicolas Legrand  ---
I don't see any such limitation in UNIMARC standard. Unfortunately, I don't
have a ISO 2709 version right now so I can't check there too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19646] value_builder marc21_linking_section template is broken

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19646

--- Comment #7 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #6)
> Erk, I missed this one!

You missed much more. Too bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19690] Smart rules: Term "If any unavailable" is confusing

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19690

--- Comment #5 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #4)
> Sorry, you lost me :(

Well, this confirms that the term confusing is quite correct! :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16284] Borrower Previously Checked Out: Serials

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16284

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m

--- Comment #2 from Victor Grousset/tuxayo  ---
Just some info about the context:

«In discussion of Bug 6909, Radek Šiman raised the following additional
concerns around CheckPreviousCheckouts functionality»

It was actually in bug 6906
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6906#c27

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/