[Koha-bugs] [Bug 13520] add rental to circ matrix

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13520

Mike  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474

--- Comment #8 from Owen Leonard  ---
Created attachment 70315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70315=edit
Bug 19474 (Follow-up) Convert staff client CSS to SCSS

This patch brings staff-global.scss up to date with changes which have
been recently committed to staff-global.css, specifically staff client
responsiveness improvements (Bug 19851).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001

--- Comment #1 from Jonathan Druart  
---
Created attachment 70314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70314=edit
Bug 12001: Move C4::Members::GetMemberAccountRecords

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921

--- Comment #2 from Jonathan Druart  
---
Created attachment 70313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70313=edit
Bug 19921: Fix update child when only one adult patron category exist

We are passing the Koha::Patron::Category object to the template instead
of the categorycode.

To reproduce this bug you must test in a system which has only one
patron category of the "adult" type. View the details of a patron with a
child-type patron category and choose More -> Update child to adult
patron.

This results in an error:

Can't call method "category_type" on an undefined value at
/home/vagrant/kohaclone/members/update-child.pl line 84.

The URL of the error page shows a problem with the parameters being
passed:

members/update-child.pl?op=update=12345=Koha::Patron::Category=HASH(0xa168a18)_multi=

Test plan:
Make sure you have only 1 adult patron category
Update a child to adult
=> With this patch applied the error is gone and the patron has been
correctly updated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19921


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921
[Bug 19921] Error when updating child to adult patron on system with only one
adult patron category
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||15407

--- Comment #1 from Jonathan Druart  
---
Caused by commit cae4b980607be083e5e0fb163c4949c73d6347db
Bug 15407: Koha::Patron::Categories - replace GetborCatFromCatType


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407
[Bug 15407] Move the patron categories related code to Koha::Patron::Categories
- part 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19922] New: Reordering of fields in elasticsearch mapping configuration does not work

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19922

Bug ID: 19922
   Summary: Reordering of fields in elasticsearch mapping
configuration does not work
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
   URL: /cgi-bin/koha/admin/searchengine/elasticsearch/mapping
s.pl
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Searching - Elasticsearch
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: oleon...@myacpl.org

If I navigate to /cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl and
try reordering fields under the 'Biblios' or 'Authorities' tabs, after clicking
'Save' the fields are still where they are to begin with.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19921] New: Error when updating child to adult patron on system with only one adult patron category

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921

Bug ID: 19921
   Summary: Error when updating child to adult patron on system
with only one adult patron category
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: major
  Priority: P5 - low
 Component: Patrons
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Blocks: 19641

To reproduce this bug you must test in a system which has only one patron
category of the "adult" type. View the details of a patron with a child-type
patron category and choose More -> Update child to adult patron.

This results in an error:

Can't call method "category_type" on an undefined value at
/home/vagrant/kohaclone/members/update-child.pl line 84.

The URL of the error page shows a problem with the parameters being passed:

members/update-child.pl?op=update=12345=Koha::Patron::Category=HASH(0xa168a18)_multi=


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641
[Bug 19641] Move patron templates JavaScript to the footer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Owen Leonard  changed:

   What|Removed |Added

 Depends on||19921


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921
[Bug 19921] Error when updating child to adult patron on system with only one
adult patron category
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

Nick Clemens  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
   |y.org   |

--- Comment #19 from Nick Clemens  ---
Added some additional feedback, please verify you are okay with changes Marcel,
otherwise looks good.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

--- Comment #18 from Nick Clemens  ---
Created attachment 70312
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70312=edit
Bug 18071: (QA Followup) - Add additional feedback and expand commit option

To test:
Test as before, verify commit option makes no changes and provides
additional feedback when verbose

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

--- Comment #17 from Nick Clemens  ---
Created attachment 70311
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70311=edit
Bug 18071: (QA follow-up) Add commit parameter, add warning

Addressing points mentioned in comment12:
[1] Commit parameter.
[2] Warning if authid does not exist for -merge.

Test plan:
[1] Run update_authorities.pl -authid X -merge -ref Y -c
where X does not exist in your db and Y does.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

Nick Clemens  changed:

   What|Removed |Added

  Attachment #66854|0   |1
is obsolete||
  Attachment #69428|0   |1
is obsolete||

--- Comment #16 from Nick Clemens  ---
Created attachment 70310
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70310=edit
Bug 18071: Add authorities maintenance script

With bug 9988 the manual merge option of merge_authorities was removed.
(Note that it did not work any more too.) This patch reintroduces this
functionality on the command line.

This maintenance script now allows you to force renumbering field 001 for
selected authid's, to delete authid's including the removal of references
in biblio records, as well as merging several authid's into one reference
record.

Test plan:
[1] Test the -renumber parameter. Field 001 and 005 should be updated.
[2] Test the -delete parameter. Check if a linked biblio does no longer
contain a reference to the deleted authority.
[3] Test the -merge parameter.
Create two PERSO_NAME records (say A,B) and attach biblios to them.
Pick a CORPO_NAME record as reference record C.
Now pass -merge -reference C -authid A,B
Verify that A and B are gone, and the records link to C now.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Lee Jamison 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911

--- Comment #9 from Arturo  ---
Just tested again and it looks great to me. Thank you for your work on this,
Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911

--- Comment #8 from sandbo...@biblibre.com  ---
Created attachment 70309
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70309=edit
Bug 19911: Escape password value during self-registration confirmation

The password must be correctly escape, it can contains html character
and break the display.

Test plan:
Apply first patch and confirm that the display is broken
Apply second patch (this one) and confirm that the display is fixed

Signed-off-by: Arturo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911

--- Comment #7 from sandbo...@biblibre.com  ---
Created attachment 70308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70308=edit
Bug 19911: Do not escape html characters when saving passwords

When the password is not generated automatically, we should not escape
the html characters. Otherwise it will be changed without any warnings.

Signed-off-by: Arturo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #70289|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com
 Status|Needs Signoff   |Signed Off

--- Comment #6 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Arturo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #70271|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19920] changepassword is exported from C4:: Members but has been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920

Jonathan Druart  changed:

   What|Removed |Added

Summary|changepasswordis exported   |changepassword is exported
   |from C4::Members but has|from C4::Members but has
   |been removed|been removed

--- Comment #1 from Jonathan Druart  
---
C4/Members.pm:

But bug 16853 removed this subroutine.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19920] New: changepasswordis exported from C4:: Members but has been removed

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920

Bug ID: 19920
   Summary: changepasswordis exported from C4::Members but has
been removed
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 16853


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853
[Bug 16853] Move changepassword to Koha::Patron->update_password
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16853] Move changepassword to Koha::Patron->update_password

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19920


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920
[Bug 19920] changepasswordis exported from C4::Members but has been removed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17833] _initilize_memcached() warns if errors

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833

--- Comment #8 from Jonathan Druart  
---
Created attachment 70307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70307=edit
Bug 17833: Make sure this warning will not be ignored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #21 from Marcel de Rooy  ---
+ unless ($item){ carp "No item passed in!" && return }
Not our preferred coding style

+ return () if (! $yaml =~ /\S/ );
Just return here. The only call is in scalar context. We do not need a list.
Shorter: return if $yaml !~ /\S/;

+eval {
+$denyingrules = YAML::Load($yaml);
+};
How much time are we spending on doing this? What is the performance effect? If
the pref always looks like field1: [val]\nfield2: [val2] we can just split on
newline and split on ':', etc. Give me some convincing numbers please.

+return ();
Same as above

+my $val;
+if (exists $item->{$field}) {
+$val = $item->{$field};
+}
+$val = '' unless defined $val;
Why not in just one line: my $val = $item->{$field} // '';

+- How to write these rules is documented on the http://wiki.koha-community.org/wiki/OpacHiddenItems; target="_blank">Koha
wiki.
This is from the preference file. Not sure if this is the preferred way. A wiki
page could be gone just as easily. Why not just provide an example as close as
possible to the pref itself. Just another 40 chars ?

Just curious too if this supports denying renewal on an empty string? If so,
the conversion from undef to empty string might not be what we want. Can we
signal empty string or undef to be a blocking value? [No blocker for me btw :)]

Changing status. Please make some adjustments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

--- Comment #13 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #11)
> 1. I prefer the version without Marcel's patch (especially because of the
> size of the parameter list)

I have seen worse :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

--- Comment #12 from Jonathan Druart  
---
Created attachment 70306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70306=edit
Bug 19792: Few minor fixes

- No string extrapolation needed on SQL queries
- '== undef' must be written 'if not defined'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Passed QA   |In Discussion

--- Comment #11 from Jonathan Druart  
---
I am not convinced.

1. I prefer the version without Marcel's patch (especially because of the size
of the parameter list)

2. GetBudgetHierarchy is called from a lot of other places, with a budget_id
For all these calls we are going to get worst performance(?)

3. GetBudgetHierarchy is not tested when called without parameter

4. There is a FIXME you removed, but you did not fix the problem, you hid it

5.
> This causes slow downs and performance issues for some libraries.

How many budgets/funds? What are the performances before/after this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19884] Improve performance of GetItem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #40 from David Gustafsson  ---
As far as I know the Mysql 'max_allowed_packet' setting is the only concern for
large IN-clauses, 1MB is the default I think (but can be raised if necessary).
1MB is about 1_000_000 characters, it's probably safe to assume that the
average IN-argument doesn't exceed 10 bytes. So as long as itemnumbers for each
batch < 100_000 it's probably fine (and if it's not one can simply raise the
conf-setting). Right now batch size is set to 2000, and with an average number
of items per biblio of around 1.3 there is absolutely no risk of exceeding the
max_allowed_packet limit.

Regarding C4 I did not know that was depricated, but if things are to be moved
into the Koha-namespace, and subroutines in C4 will become methods on the
appropriate objects, it's not very feasable to place the current addition of
pluralized subroutines to Koha:: right now before that refactoring has taken
place. I'm quite confident that the addition of the pluralized subroutines will
not make this future change more difficult. It is only really GetMarcBiblios
that "needs" to be exposed (since it's used in Koha::BiblioUtils, all the
others can be considered private helpers. I understand that adding pluralized
versions is not a insignificant addition to to API, but I have made no
alternations of the current API, and architecturally I think this is the way to
go for opening up several optimization paths for Koha. Drupal for example uses
the very same technique for loading fields for it's "entities" (biblios could
be considered an entity in this context), and without it performance would be
horrible. We have also been working on a hook-system
(https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19306). Invoking
hooks for each biblio/item etc would probably be quite expensive, but instead
placing those hooks where biblios etc can be loaded in bulk would mean that the
addition of hooks would not degrade performance as much, if at all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #20 from Marcel de Rooy  ---
(In reply to Nick Clemens from comment #19)
> It seems due dates were being set to now. If the tests take long enough to
> run then the items were overdue. Set the date in the future now

Yes, that works better. Thx

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #42 from Jonathan Druart  
---
Created attachment 70305
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70305=edit
Bug 17981: Remove uneeded module JS var

As we only support CHECKIN and CHECKOUT for now, we do not need this
module variable. It may be useful to re-add it later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #39 from Jonathan Druart  
---
Created attachment 70302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70302=edit
Bug 17981: Add a preview mode for notice templates

This patch is a first step to provide a preview mode for notice
templates.

CHECKIN, CHECKOUT and HOLD_SLIP are supported so far.
Maybe more, but I have not tested yet and the interface will not allow
you to generate the preview.

The idea is to provide an idea of how will render the messages generated
from a notice template.

A new "Preview" button is added close to each textarea on the editing
notice templates view.
For each notice template code (letter_code), we will need some input
data to produce the preview.

For instance, for CHECKIN we need an barcode. From the barcode we
can guess all the other data.
For CHECKOUT we will need the borrowernumber and the barcode.
Note that the way to enter the data for the preview is not really
user-friendly, for CHECKOUT you will have to fill
'borrowernumber|barcode', but the placeholder will help you to know how
and what to fill.
In the modal window, you will see 4 blocks:
1/ the content of the letter (with the placeholds << >>)
2/ the generated message (with the data filled)
3/ if the letter contained historical syntax markers, the screen will
try to generate a notice template using the TT syntax
4/ the generated message from this TT syntax
=> You will be able to compare the 2 generated messages.

What is the goal of this first patchset:
- Show this first POC and get feedback from other developpers
- Add a way to easily visualise the differences between the 2 syntaxes
- Confort users with the TT syntax and the migration step from the
historical syntax.

I'd like to get opinions before going further.

The possibilities:
- Mock data to get fully working generated messages for any notice
templates. For instance, for CHECKIN and CHECKOUT, the item is not
checked in/out yet. So we cannot access the issue's information.
(I have no idea how to do that)
- Browse the data to get the ones we want to use for the preview (big).

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #41 from Jonathan Druart  
---
Created attachment 70304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70304=edit
Bug 17981: Move the divs to the top of the modal

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #40 from Jonathan Druart  
---
Created attachment 70303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70303=edit
Bug 17981: Better error handling

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #67144|0   |1
is obsolete||
  Attachment #67145|0   |1
is obsolete||
  Attachment #67146|0   |1
is obsolete||
  Attachment #67147|0   |1
is obsolete||
  Attachment #67148|0   |1
is obsolete||
  Attachment #67152|0   |1
is obsolete||

--- Comment #37 from Jonathan Druart  
---
Created attachment 70300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70300=edit
Bug 17981: Move svc/letters to svc/letters/get

To allow another script under svc/letters

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

--- Comment #38 from Jonathan Druart  
---
Created attachment 70301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70301=edit
Bug 17981: Add a 'letter' param to GetPreparedLetter

This will allow us to call GetPreparedLetter with a letter content that
does not exist in the DB

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #69413|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 70299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70299=edit
Bug 18007: Interface updates to notices and notice previews

This patch makes changes to the form for adding and editing notices, and
to the template for viewing a rendered preview of notices.

- Preview now shows side-by-side comparisons
- JavaScript has been movied out of template into separate file
- Validation of the add/edit form improved through use of validation
  plugin
- There is now better visual feedback for AJAX form checks

To test, apply the patch on top of those for Bug 17981

- Add a new notice.
  - Confirm that the form can't be submitted without data in the "code"
and "name" fields.
  - Confirm that the form can't be submitted without filling in at least
one message template (subject and body).
  - Confirm that you cannot submit the form while using an
existing notice code.
  - Follow Bug 17981's test plan for testing the preview function.
Confirm that the preview loads correctly and looks correct.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #70297|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 70298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70298=edit
Bug 19792: (QA follow-up) Move anonymous sub out of GetHierarchy

Test plan:
Run t/db_dependent/Budgets.t.
Without both patches, running the test is slower than with only the first
or both patches.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

Marcel de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #69960|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 70296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70296=edit
Bug 19792 - Perf. boost for GetBudgetHierarchy

This patches reduces the number of SQL calls by combining multiple calls to the
recursive functions GetBudgetSpent(), GetBudgetOrdered(), etc. into 4 big
queries.
It also removes duplicate function calls from acqui-home.pl

Test plan:
0) Visit Acquisition home
0) Apply patch
1) Refresh page. It shoud look identical.
2) prove t/db_dependent/budgets.t

Signed-off-by: Jon Knight 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

--- Comment #9 from Marcel de Rooy  ---
Created attachment 70297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70297=edit
Bug 19792: (QA follow-up) Move anonymous sub out of GetHierarchy

Test plan:
Run t/db_dependent/Budgets.t.
Without both patches, running the test is slower than with only the first
or both patches.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

--- Comment #6 from Owen Leonard  ---
(In reply to Josef Moravec from comment #4)

> Few buttons in patron toolbar on checkouts screen does not work -
> circulation.tt is not part of this patch and so does not include
> members-menu.js. I think you will fix this bug 19728, true?

I've marked 19728 as a duplicate of this bug and will submit a follow-up that
includes circulation.tt and circulation_batch_checkouts.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #19 from Nick Clemens  ---
It seems due dates were being set to now. If the tests take long enough to run
then the items were overdue. Set the date in the future now

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792

--- Comment #7 from Marcel de Rooy  ---
(In reply to David Bourgault from comment #6)
> I don't think I can move the recursive sub out of GetBudgetHierarchy, since
> it calls variables local to that function. If it were moved out it would
> need to either rebuild them everytime, which voids the perf boost, or
> receive them as parameters, which would make the code less readable, and
> requires the dev to know the exact SQL query result to pass.
> 
> In this case I strongly believe an anonymous inner function is the best way
> to go. As for tests, the current test to budgets.t should be sufficient as
> this does not (should not!) change behavior. It is supposed to replace the
> inner workings of the function with no impact on input or output.

Will add a (trivial) follow-up that times around the same, and improves imo
readability. Since we just pass references to hash structures, we are not
rebuilding structures.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

--- Comment #18 from Nick Clemens  ---
Created attachment 70295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70295=edit
Bug 15494 - Followup: Make sure items in tests are not overdue

prove -v t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19728] Move template JavaScript to the footer: Circulation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19728

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Owen Leonard  ---


*** This bug has been marked as a duplicate of bug 19641 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858
Bug 17858 depends on bug 19728, which changed state.

Bug 19728 Summary: Move template JavaScript to the footer: Circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19728

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

--- Comment #5 from Owen Leonard  ---
*** Bug 19728 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19884] Improve performance of GetItem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #39 from Jonathan Druart  
---
David, my main concern with your approach is that we are adding new subroutines
to C4 (against our coding guidelines) and too specific methods (for items only
when we should think Koha::Object[s] instead).

Moreover IIRC the IN clause should not be used for big ranges, there is a
maximum number of elements we can passed in [ref needed].

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19897] Make status 'on hold' more specific

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19897

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

--- Comment #9 from Kyle M Hall  ---
Created attachment 70294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70294=edit
Bug 18856 [QA Followup] - Catch missed instance of is_cancelable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #17 from Marcel de Rooy  ---
# Subtest: ItemsDeniedRenewal preference
1..14
not ok 1 - Renewal allowed when no rules
#   Failed test 'Renewal allowed when no rules'
#   at t/db_dependent/Circulation.t line 2108.
#  got: '0'
# expected: '1'
not ok 2 - Renewal allowed when no rules
#   Failed test 'Renewal allowed when no rules'
#   at t/db_dependent/Circulation.t line 2109.
#  got: 'overdue'
# expected: undef
ok 3 - Renewal blocked when 1 rules (withdrawn)
ok 4 - Renewal blocked when 1 rule (withdrawn)
not ok 5 - Renewal allowed when 1 rules not matched (withdrawn)
#   Failed test 'Renewal allowed when 1 rules not matched (withdrawn)'
#   at t/db_dependent/Circulation.t line 2121.
#  got: '0'
# expected: '1'
not ok 6 - Renewal allowed when 1 rules not matched (withdrawn)
#   Failed test 'Renewal allowed when 1 rules not matched (withdrawn)'
#   at t/db_dependent/Circulation.t line 2122.
#  got: 'overdue'
# expected: undef
ok 7 - Renewal blocked when 2 rules matched (withdrawn, itype)
ok 8 - Renewal blocked when 2 rules matched (withdrawn,itype)
not ok 9 - Renewal allowed when 2 rules not matched (withdrawn, itype)
#   Failed test 'Renewal allowed when 2 rules not matched (withdrawn,
itype)'
#   at t/db_dependent/Circulation.t line 2135.
#  got: '0'
# expected: '1'
not ok 10 - Renewal allowed when 2 rules not matched (withdrawn, itype)
#   Failed test 'Renewal allowed when 2 rules not matched (withdrawn,
itype)'
#   at t/db_dependent/Circulation.t line 2136.
#  got: 'overdue'
# expected: undef
ok 11 - Renewal blocked when 3 rules matched (withdrawn, itype, location)
ok 12 - Renewal blocked when 3 rules matched (withdrawn,itype, location)
not ok 13 - Renewal allowed when 3 rules not matched (withdrawn, itype,
location)
#   Failed test 'Renewal allowed when 3 rules not matched (withdrawn,
itype, location)'
#   at t/db_dependent/Circulation.t line 2150.
#  got: '0'
# expected: '1'
not ok 14 - Renewal allowed when 3 rules not matched (withdrawn, itype,
location)
#   Failed test 'Renewal allowed when 3 rules not matched (withdrawn,
itype, location)'
#   at t/db_dependent/Circulation.t line 2151.
#  got: 'overdue'
# expected: undef
# Looks like you failed 8 tests of 14.
not ok 114 - ItemsDeniedRenewal preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19919] New: Writing off a Lost Item Fee marks as "Paid for by patron"

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919

Bug ID: 19919
   Summary: Writing off a Lost Item Fee marks as "Paid for by
patron"
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: lisettesla...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 70293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70293=edit
An example

A replacement copy was ordered for an item that was "long lost overdue" on a
patron's account. 
The librarian wanted the old copy deleted from the system to keep the record
clean. 
We checked in the item, marked it as lost, and then wrote off the fee
associated with the item. Finally we reapplied the fee manually, no longer
associated with the item. 
We noticed that at the point of the write off, the item gets a line that says
paid for by (Patron name and barcode) DATE TIME.


This also happens if the book is checked in and no longer marked as lost (say
it was returned by the borrower so we wrote off the lost item fee.)

The borrower has not paid for the book in either situation.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #68916|0   |1
is obsolete||
  Attachment #70287|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 70291
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70291=edit
Bug 19280: Pass a Koha::Patron to CanBookBeIssued

We need to make subroutine from C4 use more Koha::Object objects
Seeing bug 19276, starting here is a good start.

Test plan:
The tests should still pass.

Signed-off-by: Jon Knight 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

--- Comment #10 from Marcel de Rooy  ---
Created attachment 70292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70292=edit
Bug 19280: refresh unblessed patron too

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19422] kohastructure.sql missing DROP TABLES

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19783


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783
[Bug 19783] make check_kohastructure.t compatible to package build process
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19783] make check_kohastructure.t compatible to package build process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
What is the error? The file does not exist? intranetdir does not exist?
We should not use intranetdir in t (DB independent)?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19783] make check_kohastructure.t compatible to package build process

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19783

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||19422


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19422
[Bug 19422] kohastructure.sql missing DROP TABLES
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

Jonathan Druart  changed:

   What|Removed |Added

Summary|Software error while check  |The float items feature is
   |in, The method noreturn is  |broken - cannot checkin
   |not covered by tests!   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

--- Comment #9 from Jonathan Druart  
---
Created attachment 70290
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70290=edit
Bug 19899: Restore Item floats feature - do not crash

Error is "The method noreturn is not covered by tests!"
caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
Bug 18276: Remove GetBiblioFromItemNumber - Easy ones

When the "Return policy" (var returnbranch) is set to "Item floats" (value
noreturn)
the library must be the current library (from userenv).
This behaviour is used in C4::Circulation::AddReturn

On bug 18276 I assumed that the value was either holdingbranch or
homebranch, and forgot it could be "noreturn"

Test plan:
Set Return policy to Item floats
Check an item in
=> without this patch it explodes
=> With this patch applied it will check the item in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||18276

--- Comment #8 from Jonathan Druart  
---
Certainly caused by commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299
Bug 18276: Remove GetBiblioFromItemNumber - Easy ones


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276
[Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19899


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899
[Bug 19899] Software error while check in, The method noreturn is not covered
by tests!
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

Jonathan Druart  changed:

   What|Removed |Added

Summary|Software error while check  |Software error while check
   |in, The method noreturn is  |in, The method noreturn is
   |not covered by tests! after |not covered by tests!
   |upgrade from 16.05 to 17.11 |
   Severity|normal  |critical
   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org
Version|17.11   |master

--- Comment #7 from Jonathan Druart  
---
Ok I recreate the problem, it happens when "Return policy" is "Item floats"
(value noreturn) in circ rules.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

--- Comment #6 from Jonathan Druart  
---
Do you have something else in the Koha log file?

I will need the file and line number where the error occurs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||19918

--- Comment #5 from Jonathan Druart  
---
(In reply to Arturo from comment #3)
> Thank you for the patches, Jonathan! I've tested this out on a sandbox and
> it works great! There is only one issue that I found -- the  tag on
> line 45 of opac-registration-confirmation.tt is missing a closing 
> tag. Right now both of the tags are opening tags, so it is causing an HTML
> validation error.

Well spotted!
I have opened, filled and pushed bug 19918 to fix that.
And rebased the patch on top.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918
[Bug 19918] span tag not closed in opac-registration-confirmation.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19911


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911
[Bug 19911] Passwords displayed to user during self-registration are not
HTML-encoded
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #70253|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 70289
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70289=edit
Bug 19911: Escape password value during self-registration confirmation

The password must be correctly escape, it can contains html character
and break the display.

Test plan:
Apply first patch and confirm that the display is broken
Apply second patch (this one) and confirm that the display is fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #2 from Jonathan Druart  
---
Trivial, patch pushed for 18.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918

--- Comment #1 from Jonathan Druart  
---
Created attachment 70288
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70288=edit
Bug 19918: Close span tag in opac-registration-confirmation.tt

Introduced by:
commit 06f4950aa21ff889cff81f27b2f4e79788db193f
Bug 13599 - Add patron cardnumber to self registration confirmation

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19918] New: span tag not closed in opac-registration-confirmation.tt

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918

Bug ID: 19918
   Summary: span tag not closed in
opac-registration-confirmation.tt
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: trivial
  Priority: P5 - low
 Component: Templates
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 13599

In opac-registration-confirmation.tt:
 43 
 44 Password:
 45 [%
password_cleartext %]
 46 

Introduced by:
commit 06f4950aa21ff889cff81f27b2f4e79788db193f
Bug 13599 - Add patron cardnumber to self registration confirmation


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599
[Bug 13599] Add patron cardnumber to self registration confirmation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19918


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918
[Bug 19918] span tag not closed in opac-registration-confirmation.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

--- Comment #8 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #6)
> -$patron = Koha::Patrons->find( $borrower->{borrowernumber} );
> +$patron = Koha::Patrons->find( $patron->borrowernumber ); # FIXME
> Refetch just in case, to avoid regressions. But must not be needed
> 
> [...]
> 
> my $toomany = TooMany( $patron_unblessed, $item->{biblionumber}, $item,
> { onsite_checkout => $onsite_checkout, switch_onsite_checkout =>
> $switch_onsite_checkout, } );
> 
> You do not refetch $patron_unblessed. I would opt for not refetching
> $patron. But this is not consistent..

Good catch Marcel. I also think it's not needed, that's why I added the FIXME.
But I would prefer not to do it on this bug report as it will need more
attention.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

--- Comment #7 from Jonathan Druart  
---
Created attachment 70287
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70287=edit
Bug 19280: refresh unblessed patron too

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19884] Improve performance of GetItem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #38 from David Gustafsson  ---
The SQL-hack is still included in the last patch, but if you like the
biblio-batch-loading approach, I can polish and test this some more (add
subroutine documentation etc), and even remove the SQL-hack since it no longer
needed to speed up indexing at least.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19884] Improve performance of GetItem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #37 from David Gustafsson  ---
The last two flamegraphes are from running this script
(https://gist.github.com/gnucifer/1e33f9aa7155b1b771baaa357dfc7141) without the
SQL-hack and batching enabled/disabled. On the last graph the long thin flame
to the left corresponds to the Koha::Obects::Search one on the first (without
batching).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19884] Improve performance of GetItem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #36 from David Gustafsson  ---
Created attachment 70286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70286=edit
search_batched

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19884] Improve performance of GetItem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #35 from David Gustafsson  ---
Created attachment 70285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70285=edit
search_not_batched

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19015] Searches fail with error Fielddata is disabled on text fields by default for elastic search 5.3 and 5.4

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19015

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19884] Improve performance of GetItem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #34 from David Gustafsson  ---
Also note that this latest benchmark includes all work done in GetMarcBiblio,
so more illustrates the actual speedup of loading biblios for indexing (for
example), not how much faster items loading is.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19884] Improve performance of GetItem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #33 from David Gustafsson  ---
Forgot to add my results of running the script:

Batching enabled + SQL-hack:
32.422s

Batching enabled (using ->search, no SQL-hack):
33.387s

Batching disabled + SQL-hack:
38.269s

Batching disabled (using ->search, no SQL-hack):
59.755s

The benchmarks for ->search includes unblessing the item and calling
effective_itemtype().

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

--- Comment #5 from Mohd Hafiz Yusoff  ---
Return from command

lib/C4/Circulation.pm:  noreturn: do not return, let item remain where checked
in (floating collections)
lib/C4/Circulation.pm:# if $hbr was "noreturn" or any other non-item
table value, then it should 'float' (i.e. stay at this branch)
intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:
   [% IF ( default_returnbranch == 'noreturn' ) %]
intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:
   
intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:
   
intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:
   [% ELSIF ( branch_item_rule_loo.returnbranch == 'noreturn' ) %]
intranet/htdocs/intranet-tmpl/prog/en/modules/admin/smart-rules.tt:
   Item floats
intranet/cgi-bin/installer/data/mysql/kohastructure.sql:  `returnbranch`
varchar(15) default NULL, -- the branch the item returns to (homebranch,
holdingbranch, noreturn)
man/man3/C4::Circulation.3pm:  noreturn: do not return, let item remain where
checked in (floating collections)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899

--- Comment #4 from Mohd Hafiz Yusoff  ---
Fresh install koha using this instruction:
https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages

After install, I restore old database (from KOHA 16.05).

And then upgrade schema "koha-upgrade-schema {instance}"

Last reindex "koha-rebuild-zebra -v -f {instance}"

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19884] Improve performance of GetItem

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884

--- Comment #32 from David Gustafsson  ---
I made variants of GetMarcBiblio and EmbedItemsInMarcBiblio (GetMarcBiblios and
EmbedItemsInMarcBiblio) that accepts multiple biblionumbers instead of just
one. This way all items can be loaded at once for all of these biblios,
avoiding the overhead of callings search/find once for each item. Running this
script (https://gist.github.com/gnucifer/1e33f9aa7155b1b771baaa357dfc7141) it
seems to give about the same performance boost as the SQL-hack. When using this
strategy just benchmarking GetItems is not feasible since the speedup is
because GetItems now need to run a fraction of the times (about 1/2000 for a
batch size of 2000) as before, making the impact of DBIx-search having a large
overhead preparing the query compared to the low lever interface not matter
that much.

I will try to produce a before/after NYTProf-flamegraph with the latest
benchmarking script (it's a little bit messy since does not have the production
data available in my dev-box, and need to produce the results in our staging
environment).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/