date:20180112

[Koha-bugs] [Bug 17553] Move GetOverduesForPatron to Koha::Patron

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17553

--- Comment #12 from Tomás Cohen Arazi  ---
Why 'get_overdues' instead of 'overdues'?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18923] Resolve a warn in Biblio::GetCOinSBiblio

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18923

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #16 from Chris Cormack  ---
Pushed to 16.11.x will be in 16.11.16

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19875] When & is in the title of a search result, subscribing via rss can be broken

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19875

Roch D'Amour  changed:

   What|Removed |Added

 CC||roch.dam...@inlibro.com

--- Comment #4 from Roch D'Amour  ---
I applied the patch, searched for results with a "&" in the title, and
subscribed to the RSS feed. The feed show up, but I only get entrys up untill
the records with the "&" in the title. After this records, nothing else show
up. I followed the test plan, and I was wondering what do you meant by
"subscribe is ok | nok"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

M. Tompsett  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from M. Tompsett  ---
Failed QA test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19969] New: Adding a manual restriction in memberentrypl with a date does not restrict the patron

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19969

Bug ID: 19969
   Summary: Adding a manual restriction in memberentrypl with a
date does not restrict the patron
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ke...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When entering a patron manual restriction with a specific date in the
memberentry.pl page- the restriction is not carried over into the checkout page
and patron is not restricted.  Entering a manual restriction on the
memberentry.pl page without a date will carry over the restriction and not
allow patron to checkout. 

This is seen in Koha Version 17.05.07.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15707] Add ability to define hierarchical groups of libraries

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15707

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Owen Leonard  changed:

   What|Removed |Added

  Attachment #70477|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

--- Comment #18 from Owen Leonard  ---
Created attachment 70479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70479=edit
Bug 9302 [QA Followup] Copy merged patrons to deletedborrowers table

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Owen Leonard  changed:

   What|Removed |Added

  Attachment #70474|0   |1
is obsolete||

--- Comment #17 from Owen Leonard  ---
Created attachment 70478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70478=edit
Bug 9302 - Add ability to merge patron records

It would be great if there were a merge patrons feature. If you
accidentally end up with one patron with two cards it would be nice to
merge their records together so that you don't lose their history or
holds or anything.

This patch adds a basic patron merge feature. It attempts to relink all
patron related tables from the patron(s) to be merged. It does not
attempt to relink librarian account related tables at this time. This
feature does not attempt to automatically resolve issues such as
duplicate holds. Such a feature could build upon this one though.

Test Plan:
1) Apply this patch
2) Find two or more patrons
3) Perform a patron search that will bring them up on the same page of
   results, or add them all to a list of patrons.
4) Use the 'merge' button to begin the merging process
5) Choose a patron to keep
6) Verify the deleted patrons data ( checkouts, holds, etc )
   are now linked to the kept patron

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

--- Comment #16 from Kyle M Hall  ---
Created attachment 70477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70477=edit
Bug 9302 [QA Followup] - Copy merged patrons to deletedborrowers table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
  Attachment #68836|0   |1
is obsolete||

--- Comment #42 from M. Tompsett  ---
Comment on attachment 68836
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68836
Allow restricting SCO to IP or IP range

Patch attached in a non-patch way making things harder to git bz.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

--- Comment #41 from M. Tompsett  ---
Created attachment 70476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70476=edit
Bug 14407: Unit tests for in_ipset

TEST PLAN
-
1) apply all pathches
2) sudo koha-shell -c bash kohadev
   prove t/Auth.t
   -- should run.
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

--- Comment #40 from M. Tompsett  ---
Created attachment 70475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70475=edit
Bug 14407: Allow restricting SCO to IP or IP range

Converted this to actual applicable patches.
I think the test plan is comment #28. -- Mark Tompsett

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #68606|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall  ---
Created attachment 70474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70474=edit
Bug 9302 - Add ability to merge patron records

It would be great if there were a merge patrons feature. If you accidentally
end up with one patron with two cards it would be nice to merge their records
together so that you don't lose their history or holds or anything.

This patch adds a basic patron merge feature. It attempts to relink all patron
related tables from the patron(s) to be merged. It does not attempt to relink
librarian account related tables at this time. This feature does not attempt to
automatically resolve issues such as duplicate holds. Such a feature could
build upon this one though.

Test Plan:
1) Apply this patch
2) Find two or more patrons
3) Perform a patron search that will bring them up on the same page of results,
   or add them all to a list of patrons.
4) Use the 'merge' button to begin the merging process
5) Choose a patron to keep
6) Verify the deleted patrons data ( checkouts, holds, etc )
   are now linked to the kept patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

--- Comment #12 from M. Tompsett  ---
(In reply to Victor Grousset/tuxayo from comment #11)
> I remember removing the post/pre-chomp after having checked that the output
> was still correct. Is there another caveat?

If you say it is the same, I'll test it. But it just didn't eyeball well. It if
works, I'll set to signed off. If not, I'll confirm that it didn't.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19967] Search patrons with non-Latin languages is broken if DefaultPatronSearchFields includes dateofbirth

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967

--- Comment #1 from Katrin Fischer  ---
I think we need to do the fix for all date fields, I just tried adding
datexpiry and it breaks the search as well. (dateexpiry, dateenrolled,
lastseen, updated_on..?)

To test:

- Configure DefaultPatronSearchFields including dateofbirth and surname
- Add a patron to your database with a cyrillig surname
- Try to search for the patron
- > keeps loading forever

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19967] Search patrons with non-Latin languages is broken if DefaultPatronSearchFields includes dateofbirth

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|Search patrons with |Search patrons with
   |non-Latin languages is  |non-Latin languages is
   |brocken if  |broken if
   |DefaultPatronSearchFields   |DefaultPatronSearchFields
   |includes dateofbirth|includes dateofbirth

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19968] Undefined subroutine ::Calc::Today

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968

--- Comment #1 from Jean-Daniel Tissot  ---
OS is  Debian Jessie and Koha is installed from
http://debian.koha-community.org/koha

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19968] New: Undefined subroutine ::Calc::Today

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19968

Bug ID: 19968
   Summary: Undefined subroutine ::Calc::Today
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: Linux
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: jean-daniel.tis...@univ-fcomte.fr
QA Contact: testo...@bugs.koha-community.org

Software error:

Undefined subroutine ::Calc::Today called at
/usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/unimarc_field_100.pl
line 75.

Jonathan Druart propose to add "use Date::Calc;" after other use statements in
file
/usr/share/koha/intranet/cgi-bin/cataloguing/value_builder/unimarc_field_100.pl

After adding this line, the problem is solved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

--- Comment #11 from Victor Grousset/tuxayo  ---
(In reply to M. Tompsett from comment #10)
> basket.tt and basketgroup.tt aren't [%- delimiter -%]. I believe the hyphens
> are important to the formatting of the file. Please correct.

I remember removing the post/pre-chomp after having checked that the output was
still correct. Is there another caveat?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||mtomp...@hotmail.com

--- Comment #10 from M. Tompsett  ---
basket.tt and basketgroup.tt aren't [%- delimiter -%]. I believe the hyphens
are important to the formatting of the file. Please correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9302] Add ability to merge patron records

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302

--- Comment #14 from Nick Clemens  ---
*** Bug 19567 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19567] Development

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19567

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Resolution|--- |DUPLICATE
 Status|NEW |RESOLVED

--- Comment #1 from Nick Clemens  ---


*** This bug has been marked as a duplicate of bug 9302 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19967] New: Search patrons with non-Latin languages is brocken if DefaultPatronSearchFields includes dateofbirth

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19967

Bug ID: 19967
   Summary: Search patrons with non-Latin languages is brocken if
DefaultPatronSearchFields includes dateofbirth
 Change sponsored?: ---
   Product: Koha
   Version: 16.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ulrich.klei...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

In this particular case you get the mysql error message: 

Illegal mix of collations for operation 'like'

You can prevent this error by removing dateofbirth from
DefaultPatronSearchFields or by the following patch:

diff --git a/C4/Utils/DataTables/Members.pm b/C4/Utils/DataTables/Members.pm
index 2446703..ba32a12 100644
--- a/C4/Utils/DataTables/Members.pm
+++ b/C4/Utils/DataTables/Members.pm
@@ -117,7 +117,12 @@ sub search {

 my @where_strs_or;
 for my $searchfield ( split /,/, $searchfields->{$searchfieldstype} )
{
-push @where_strs_or, "borrowers." .
$dbh->quote_identifier($searchfield) . " LIKE ?";
+if ( $searchfield eq 'dateofbirth' ) {
+push @where_strs_or, "DATE_FORMAT(borrowers." .
$dbh->quote_identifier($searchfield) . ", '%Y-%m-%d') LIKE ?";
+} else {
+push @where_strs_or, "borrowers." .
$dbh->quote_identifier($searchfield) . " LIKE ?";
+}
+
 push @where_args, $term;
 }

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10708] Make fine receipt customizable

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

M. Tompsett  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #15 from M. Tompsett  ---
It seemed from comment #11 and comment #12, that the FailedQA was for the git
commit messages, not the actual code.

Changing the return value and tweaking code based on that is a refactor, just
not in a huge rewrite from scratch sense. Perhaps there is a better word, but I
can't think of it right now.

As I only changed the commit message, I'm moving this back to Signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70397|0   |1
is obsolete||

--- Comment #14 from M. Tompsett  ---
Created attachment 70473
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70473=edit
Bug 19938: Refactor checkoverdues

TEST PLAN
-
0) back up plack error log if you care.

1) Run these on your kohadevbox:
echo | sudo tee /var/log/koha/kohadev/plack-error.log
sudo koha-shell -c bash kohadev
prove t/db_dependent/Circulation/dateexpiry.t
prove t/db_dependent/www/search_utf8.t
./misc/cronjobs/staticfines.pl
exit

They will all pass or run without error.
However, the log file will have noise.

2) Run these on your kohadevbox:
git bz apply 19938
restart_all
echo | sudo tee /var/log/koha/kohadev/plack-error.log
sudo koha-shell -c bash kohadev
prove t/db_dependent/Circulation/dateexpiry.t
prove t/db_dependent/www/search_utf8.t
./misc/cronjobs/staticfines.pl
exit

They will all pass or run without error.
This time the log file will have no noise.

3) run koha qa test tools

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

--- Comment #13 from M. Tompsett  ---
Created attachment 70472
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70472=edit
Bug 19938: Refactor checkoverdues call in C4/Members.pm

Due to concerns that another bug may conflict, this was
purposefully split. The other bug removes patronflags().
It is this function that has the C4::Overdues::checkoverdues
call refactored.

TEST PLAN
-
Apply both patches and follow the test plan in the larger one.

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70396|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||19191


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191
[Bug 19191] Add ability to email receipts for account payments and write-offs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||19966


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966
[Bug 19966] Add ability to pass objects directly to slips and notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #68812|0   |1
is obsolete||
  Attachment #70466|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 70471
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70471=edit
Bug 19191 - Add ability to email receipts for account payments and write-offs

Some libraries are paperless and require all payment receipts to be emailed.
Koha should give libraries the option to send email receipts if a patron has an
email address. If a notice for the type of "credit" exists ( payment or
writeoff ), then an email receipt will be sent.

These notices only support Template Toolkit syntax.

Test Plan:
1) Apply this patch and dependencies
2) Add the two new notices, you can find them in
installer/data/mysql/en/mandatory/sample_notices.sql
3) Note two new notices exist in the notices editor, ACCOUNT_PAYMENT and
ACCOUNT_WRITEOFF
4) Find or create a patron with an email address that owes some amount of money
5) Make a payment for one or more fees
6) Note a new email is queued for the patron
7) Make a writeoff for one or more fees
8) Note a new new email is queued for the patron

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966

--- Comment #1 from Kyle M Hall  ---
Created attachment 70470
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70470=edit
Bug 19966 - Add ability to pass objects directly to slips and notices

Koha spends an incredible amount of time on parsing and processing parameters
passed in to slips and notices. It would be immensely more efficient to be able
to pass objects directly to GetPreparedLetter so it doesn't need to do any
fetching / processing on them.

Test plan:
1) Apply this patch
2) prove t/db_dependent/Letters/TemplateToolkit.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19966] Add ability to pass objects directly to slips and notices

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19966] New: Add ability to pass objects directly to slips and notices

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19966

Bug ID: 19966
   Summary: Add ability to pass objects directly to slips and
notices
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Koha spends an incredible amount of time on parsing and processing parameters
passed in to slips and notices. It would be immensely more efficient to be able
to pass objects directly to GetPreparedLetter so it doesn't need to do any
fetching / processing on them.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19965] 008 tag editor not showen completely

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19965

--- Comment #1 from Hussain A  ---
Created attachment 70469
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70469=edit
008 tag editor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19965] New: 008 tag editor not showen completely

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19965

Bug ID: 19965
   Summary: 008 tag editor not showen completely
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: reza0...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

We updating Koha from 3.18 to 17.11
But we encountered a problem after the update was complete
When create a new bibliographic record and click on 008 tag editor, does not
showing completely.
How we can fix this problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19470] Add information about item being in rotating collection on detail page

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19470

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Signed Off  |BLOCKED

--- Comment #3 from Julian Maurice  ---
Changing status to BLOCKED because it depends on a NSO bug (bug 18606)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #15 from Julian Maurice  ---
Hi Alex,

Here are a few things you need to change:
1. Remove all occurences of onboardingrequired, it's stored in a bad place,
it's badly used and you don't need it (explanation below:)
  a. userflags contain name and description of user permissions, it's not a
place to store arbitrary flags (despite its name)
  b. if we decide to skip the onboarding tool, the first time the DB user logs
in they are not redirected to the onboarding tool because onboardingrequired's
value is 0 (it's set to 1 only at this moment), so the user need to reload the
page to be redirected to the onboarding tool. Moreover onboardingrequired is
still equals to 1 after the onboarding process
  c. you don't need it because you have another check that is (IMO) enough : if
there is at least one user that have permission superlibrarian, it means that
someone is gone through the onboarding process (or someone has manually
configured Koha, which means the onboarding process is not needed)

2. check_if_patrons_have_flags is not needed: you can replace it by
Koha::Patrons->search({flags => { '!=' => undef }}) (and anyway the previous
check is enough IMO, so it could be completely removed)

3. I think that changes in installer/onboarding.pl are not needed:
  a. you changed the redirection to installer/install.pl to mainpage.pl, which
then redirects to installer/install.pl, so it adds one more redirection for the
same result
  b. there seems to be no scenario where $op == 'skip', can you confirm that ?

Now that's a personal opinion but I believe that a warning message would be
better than an automatic redirect. There might be some cases where I don't want
to go through the onboarding process at all and this redirect could become
annoying

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 QA Contact|testo...@bugs.koha-communit |julian.maur...@biblibre.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19483] t/db_dependent/www/ * crashes test harness due to misconfigured test plan

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19483

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19483] t/db_dependent/www/ * crashes test harness due to misconfigured test plan

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19483

Julian Maurice  changed:

   What|Removed |Added

  Attachment #68307|0   |1
is obsolete||

--- Comment #3 from Julian Maurice  ---
Created attachment 70468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70468=edit
Bug 19483: Fix test plan in t/db_dependent/www/*

t/db_dependent/www/* crashes test harness due to misconfigured test plan

prove t/db_dependent/www/

without defining KOHA_INTRANET_URL
bails out and marks the whole test suite as failed.
Test suite should not be failed if this optional WWW::Mechanize test
suite is not activated.

After this patch, the tests are properly skipped without failing the
whole tests.

This is important when running all tests under t, as this needlessly
fails the test suite.

Also handling of 'skip_all' is inconsistent in t/db_dependent/www
-tests, so this normalizes it to skip_all instead of bail_out

Signed-off-by: Mark Tompsett 
Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19703] Some items have the incorrect item type displayed in the ' Most popular' section in OPAC

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19703

Owen Leonard  changed:

   What|Removed |Added

   Severity|enhancement |normal
Version|17.05   |master

--- Comment #2 from Owen Leonard  ---
The query in Circulation.pm is pulling itemtype from biblioitems, so it looks
like the information being displayed is accurate if unexpected. I'm not sure
how one reconciles the notion of item-level item types with a limit on item
type which groups by biblionumber.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19483] t/db_dependent/www/ * crashes test harness due to misconfigured test plan

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19483

Julian Maurice  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |julian.maur...@biblibre.com
   |y.org   |
 CC||julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related tools

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

Owen Leonard  changed:

   What|Removed |Added

  Attachment #69737|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 70467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70467=edit
Bug 19682: Move JS to the footer: Two patron-related tools

This patch modifies two patron-related tools templates in the staff
client so that JavaScript is included in the footer instead of the
header.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

  - Import patrons
  - Upload patron images

Signed-off-by: Claire Gravely 

Edit for QA: Fixed datepickers on import patron form

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19682] Move JS to the footer: Two patron-related tools

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19325] Enable padding of printed barcodes

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19325

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com

--- Comment #9 from Julian Maurice  ---
Why new system preferences ? Shouldn't it be configurable at the layout level ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046

--- Comment #17 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #15)
> (In reply to Jonathan Druart from comment #13)
> > Can we have a patch for the manual please? :)
> 
> Does the Manual keyword trigger someone of the Documentation team to do so?

I think the author or someone involved in the development/testing of the patch
should write something to explain to the manual team what the feature/change
is.
And then the manual team could adapt it correctly to the manual and make a
patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19931] Omnibus: Update popup window templates to use Bootstrap grid

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19931

Owen Leonard  changed:

   What|Removed |Added

Summary|Update popup window |Omnibus: Update popup
   |templates to use Bootstrap  |window templates to use
   |grid|Bootstrap grid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19964] Can't call method "fields" on an undefined value at /usr/share /koha/lib/C4/Biblio.pm line 2438

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19964

Nick Clemens  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 CC||n...@bywatersolutions.com
 Status|NEW |RESOLVED

--- Comment #1 from Nick Clemens  ---
It sounds like an indexing error - you should run a full rebuild of your
indexes to make sure these are all cleared out. 

As to why it happened, that is harder to say. If records were deleted via the
db the zebra queue may not have been updated.

You can ask in IRC or on the mailing lists for more information, but I think it
is not a bug

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #70465|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 70466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70466=edit
Bug 19191 [QA Followup] - Remove db update so feature is disabled by default
for existing installations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19191] Add ability to email receipts for account payments and write-offs

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19191

--- Comment #8 from Kyle M Hall  ---
Created attachment 70465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70465=edit
Bug 19191 [QA Followup] - Remove db update so feature is disabled by default
for existing installations

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

--- Comment #12 from Julian Maurice  ---
(In reply to Julian Maurice from comment #10)
> I don't see how they can conflict. Bug 19933 only adds a comment to
> C4/Members.pm, and not very close to the lines modified by this bug's
> patches.
> I think it's safe to squash the patches.

I didn't realize the code modified by this patch was inside patronflags(), so
feel free to squash the patches or not, but if you decide to keep both patches
separated, please rewrite the first commit message too, it doesn't describe
what the patch does

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

Julian Maurice  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

--- Comment #11 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #7)
> (In reply to M. Tompsett from comment #0)
> > While retesting a bug, I ran a prove -r -v t, which generated a lot of log
> > noise. One such entry was:
> > [Tue Jan  9 03:54:58 2018] starman: Use of uninitialized value
> > $overdues_count in numeric gt (>) at
> > /home/vagrant/kohaclone/opac/opac-main.pl line 76.
> 
> Prove generated a log entry from opac-main.pl? How?
> 
> https://jenkins.koha-community.org/job/Koha_Master_D8/lastCompletedBuild/
> console

t/db_dependent/www/search_utf8.t use Test::WWW::Mechanize to do various HTTP
requests to Koha, that's how.

I can confirm that warnings disappear after applying the patches, but before I
mark this as Passed QA, please rewrite the commit message. It's not really a
refactoring because it changes behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19964] New: Can't call method "fields" on an undefined value at /usr/ share/koha/lib/C4/Biblio.pm line 2438

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19964

Bug ID: 19964
   Summary: Can't call method "fields" on an undefined value at
/usr/share/koha/lib/C4/Biblio.pm line 2438
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: PC
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mj...@reitoria.ulisboa.pt
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Created attachment 70464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70464=edit
3 images as described in comment

This error occurs on records that are data as deleted, but actually appear in
the results of an OPAC and Intranet environment search (image 1).
What appears to give rise to these failures is some power failure when creating
a new bibliographic record. The record gets an error in some field, does not
allow us to have access to continue to edit or correct, but appears in the
search results (image 1); and when trying to open this error appears (image 2 &
3).

can anyone help find a solution, especially so that erroneous bibliographic
records do not appear in the OPAC and Intranet search results?

Thanks

Maria Nunes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||18081
 Depends on|18081   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081
[Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||18081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081
[Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|13667   |
 Depends on||13667


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667
[Bug 13667] Provide script to regularly clean deletedborrowers table
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||13667


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667
[Bug 13667] Provide script to regularly clean deletedborrowers table
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667

Katrin Fischer  changed:

   What|Removed |Added

 Blocks|18081   |

--- Comment #1 from Katrin Fischer  ---
This is quite a big privacy issue. If a patron asks for his data to be deleted,
it should be deleted. Keeping it might even be against law in some contexts.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081
[Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Katrin Fischer  changed:

   What|Removed |Added

 Depends on|13667   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667
[Bug 13667] Provide script to regularly clean deletedborrowers table
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081

Magnus Enger  changed:

   What|Removed |Added

 Depends on||13667


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667
[Bug 13667] Provide script to regularly clean deletedborrowers table
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667

Katrin Fischer  changed:

   What|Removed |Added

Summary|Provide script to regularly |Provide script to regularly
   |clean deletedpatrons table  |clean deletedborrowers
   ||table

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no
 Blocks||18081


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081
[Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19963] New: ethnicity and ethnicity tables and columns survived update

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19963

Bug ID: 19963
   Summary: ethnicity and ethnicity tables and columns survived
update
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Database
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

The database update for 3.21.00.033 should have removed the ethnicity table and
the ethnicity and ethnotes columns from borrowers, deletedborrowers and
borrower_modifications. This didn't work right in all cases. I just noticed
that all those survived in our older databases. The reason is that the database
update only checked for NULL when counting existing data, but not for "":

11054 $DBversion = "3.21.00.033";
11055 if ( CheckVersion($DBversion) ) {
11056 
11057 my $done = 0;
11058 my $count_ethnicity = $dbh->selectrow_arrayref(q|
11059 SELECT COUNT(*) FROM ethnicity
11060 |);
11061 my $count_borrower_modifications = $dbh->selectrow_arrayref(q|
11062 SELECT COUNT(*)
11063 FROM borrower_modifications
11064 WHERE ethnicity IS NOT NULL
11065 OR ethnotes IS NOT NULL
11066 |);
11067 my $count_borrowers = $dbh->selectrow_arrayref(q|
11068 SELECT COUNT(*)
11069 FROM borrowers
11070 WHERE ethnicity IS NOT NULL
11071 OR ethnotes IS NOT NULL
11072 |);
11073 # We don't care about the ethnicity of the deleted borrowers, right?
11074 if ( $count_ethnicity->[0] == 0
11075 and $count_borrower_modifications->[0] == 0
11076 and $count_borrowers->[0] == 0
11077 ) {
11078 $dbh->do(q|
11079 DROP TABLE ethnicity
11080 |);
11081 $dbh->do(q|
11082 ALTER TABLE borrower_modifications
11083 DROP COLUMN ethnicity,
11084 DROP COLUMN ethnotes
11085 |);
11086 $dbh->do(q|
11087 ALTER TABLE borrowers
11088 DROP COLUMN ethnicity,
11089 DROP COLUMN ethnotes
11090 |);
11091 $dbh->do(q|
11092 ALTER TABLE deletedborrowers
11093 DROP COLUMN ethnicity,
11094 DROP COLUMN ethnotes
11095 |);
11096 $done = 1;
11097 }
11098 if ( $done ) {
11099 print "Upgrade to $DBversion done (Bug 10020: Drop table
ethnicity and columns ethnicity and ethnotes)\n";
11100 }
11101 else {
11102 print "Upgrade to $DBversion done (Bug 10020: This database
contains data related to 'ethnicity'. No change will be done on the DB
structure but note that the Koha codebase does not use it)\n";
11103 }
11104 
11105 SetVersion ($DBversion);

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

--- Comment #10 from Julian Maurice  ---
(In reply to M. Tompsett from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > "Bug 19938: Split C4/Members.pm to avoid conflict issues"
> > 
> >  => What does it mean?
> 
> because 19933 might trigger a conflict in C4/Members with the removal of
> patronflags, so put the possible conflict area elsewhere. I split it from a
> single commit, so as to avoid the conflict as needed.

I don't see how they can conflict. Bug 19933 only adds a comment to
C4/Members.pm, and not very close to the lines modified by this bug's patches.
I think it's safe to squash the patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19938] Refactor C4::Overdues::checkoverdues

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 QA Contact|testo...@bugs.koha-communit |julian.maur...@biblibre.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #70378|0   |1
is obsolete||

--- Comment #22 from Marcel de Rooy  ---
Created attachment 70462
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70462=edit
Bug 18915: Renaming svc/patron_notes to svc/checkout_notes

For consistency.

Signed-off-by: Marjorie Barry-Vila 

https://bugs.koha-community.org/show_bug.cgi?id=19801

Signed-off-by: Marjorie Vila 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

--- Comment #23 from Marcel de Rooy  ---
Created attachment 70463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70463=edit
Bug 18915: (QA follow-up) Add note for installs after 17.05

Since the 17.05 upgrade adds the note and the sql file did not yet include
the note, we should add it when it is not there (for example new 17.11s).

Signed-off-by: Marcel de Rooy 
Tested by running the dbrev while there is a letter and while not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #70376|0   |1
is obsolete||

--- Comment #20 from Marcel de Rooy  ---
Created attachment 70460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70460=edit
Bug 18915: Fix checkout note email message

This patch replaces the <> in the email with
<> and uses CHECKOUT_NOTE instead of PATRON_NOTE.
This patch also adds the notice to
installer/data/mysql/en/mandatory/sample_notices.sql, and updates the
PATRON_NOTE entry in installer/data/mysql/updatedatabase.pl

To test:
1) Apply patch and update database
2) View the message_queue table in mysql
3) Check out an item if haven't already
4) Go to OPAC and set a checkout note for an item
5) View message_queue table and confirm it the title is included in the
email and all instances of 'patron note' have been replaced with
'checkout note'
6) Disable javascript in browser
7) repeat steps 4 and 5 and confirm all works as expected

Sponsored-by: Catalyst IT

Signed-off-by: Marjorie Vila 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #70377|0   |1
is obsolete||

--- Comment #21 from Marcel de Rooy  ---
Created attachment 70461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70461=edit
Bug 18915: Giving CHECKOUT_NOTE access to issues table

This patch allows the notice to reference the issues table so that the
checkout note itself can be added to the note if wanted, such as in
Comment 9.

Sponsored-by: Catalyst IT

Signed-off-by: Marjorie Barry-Vila 

https://bugs.koha-community.org/show_bug.cgi?id=19801

Signed-off-by: Marjorie Vila 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19962] Introduce koha-sip to replace koha-*-sip

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962

--- Comment #3 from Pongtawat  ---
Created attachment 70459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70459=edit
Bug 19962 - Introduce koha-sip to replace koha-*-sip

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19962] Introduce koha-sip to replace koha-*-sip

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962

Pongtawat  changed:

   What|Removed |Added

  Attachment #70458|1   |0
   is patch||
  Attachment #70458|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19962] Introduce koha-sip to replace koha-*-sip

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962

Pongtawat  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #2 from Pongtawat  ---
To test:

- Apply this patch
- koha-sip --start koha1  => same as koha-start-sip koha1
- koha-sip --stop koha1 => same as koha-stop-sip koha1
- koha-sip --restart koha1 => same as koha-stop-sip koha1 && koha-start-sip
koha1
- koha-sip --enable koha1 => same as koha-enable-sip koha1
- koha-sip --disable koha1 => new, move SIP config file

Note:
- stop use start-stop-daemon (same as koha-plack) to make sure it really stop
- enable and disable is a bit different from koha-plack. It will continue even
if some instances are already enabled (or disabled). In contrast, koha-plack
--enable will just stop at the instance that was already enabled without
processing the following instances.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19962] Introduce koha-sip to replace koha-*-sip

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962

--- Comment #1 from Pongtawat  ---
Created attachment 70458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70458=edit
Bug 19962 - Introduce koha-sip to replace koha-*-sip

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19962] New: Introduce koha-sip to replace koha-*-sip

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962

Bug ID: 19962
   Summary: Introduce koha-sip to replace koha-*-sip
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Command-line Utilities
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pongta...@punsarn.asia
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

Introduce a new koha-sip script which use new command style (as koha-plack,
etc) to replace old set of SIP commands.

Also add an ability to disable SIP.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #80 from Alex Arnaud  ---
(In reply to Jonathan Druart from comment #77)
> 
> I am pretty sure something is wrong.

As already asked by Marcel, can you give me more explanation about what is
wrong?

Otherwise, i renamed hasItemswaitingOrInTransit to
has_items_waiting_or_intransit and and added pod description.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4319] waiting and in transit items cannot be reserved

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319

--- Comment #79 from Alex Arnaud  ---
Created attachment 70457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70457=edit
Bug 4319 - [QA follow-up] Rename hasItemswaitingOrInTransit to
has_items_waiting_or_intransit and update pod

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18915] Creating a checkout note (patron note) sends an incomplete email message

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18915

Marcel de Rooy  changed:

   What|Removed |Added

Version|unspecified |master
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

--- Comment #11 from Marcel de Rooy  ---
Looks good to me. Not tested with ES. No harm expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #69095|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 70456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70456=edit
Bug 19580: Exclude period as splitting character for autotrunction

To test:
0 - Apply Unit test patch only
1 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
2 - Should fail
3 - Apply this patch
4 - prove t/db_dependent/Koha_SearchEngine_Elasticsearch_Search.t
5 - should pass
6 - search for 'Local-number.raw:"4"' (or a vlid biblionumber)
7 - should get expected result

Signed-off-by: David Bourgault 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #69094|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 70455
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70455=edit
Bug 19580: Unit tests

Signed-off-by: David Bourgault 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19580] Elasticsearch: QueryAutoTruncate exclude period as splitting character in autotruncation

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19580

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #67 from Katrin Fischer  ---
(In reply to Marcel de Rooy from comment #66)
> (In reply to Katrin Fischer from comment #65)
> > I think it should work like this: Check the framework for the authority type
> > linked to a field and check for authorities of that type to link it with
> > automatically. Fields not linked to an authority type, should not be
> > auto-linked.
> 
> Currently this is hardcoded in Heading somewhere.

Hm, yeah, I seem to remember that this was used for importing authorities in
order to assign the correct framework. Maybe this could be seen as a separate
bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Failed QA

--- Comment #24 from Marcel de Rooy  ---
ShibUseHeaders On|Off
Defaults to "Off", this turns on the use of request headers to publish
attributes to applications. Use of this option should be avoided. Be sure to
review the topic on spoof checking if you enable it.

You are suggesting to disable ShibUseEnvironment and enable ShibUseHeaders.
Please explain. It is not recommended..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #55 from Victor Grousset/tuxayo  ---
(In reply to Jonathan Druart from comment #48)
> error: sha1 information is lacking or useless
> (koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt).

I resolved the conflict in this file.
The strange thing is that there didn't seem to be a conflict.
A git diff between my previous local branch for this bug and a new one (used
for the conflict resolution) showed nothing on the involved file.
But the patches successfully apply now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299

--- Comment #66 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #65)
> I think it should work like this: Check the framework for the authority type
> linked to a field and check for authorities of that type to link it with
> automatically. Fields not linked to an authority type, should not be
> auto-linked.

Currently this is hardcoded in Heading somewhere.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #70019|0   |1
is obsolete||

--- Comment #52 from Victor Grousset/tuxayo  ---
Created attachment 70452
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70452=edit
Bug 19522: Label creator: translate empty list message

The name of the element wasn't translated in the message.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. ensure that the list is empty
4. then you should see "pas de Batches actuellement"
5. then you should see "créer un nouveau batch."
6. apply this patch
7. install the language
8. refresh the page
9. then you should see "pas de Lots actuellement"
10. then you should see "créer un nouveau lot ."

Signed-off-by: Simon Pouchol 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #70021|0   |1
is obsolete||

--- Comment #54 from Victor Grousset/tuxayo  ---
Created attachment 70454
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70454=edit
Bug 19522: Label creator: edit batch: make "Export label" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. Switch the language to French if you haven't done it yet
6. click on "Exporter le lot entier"
7. then you should see "Export labels"
8. apply this patch
9. install the language
10. replay steps 2 to 6
11. then you should see "Exporter des étiquettes"

Signed-off-by: Simon Pouchol 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2018-01-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Victor Grousset/tuxayo  changed:

   What|Removed |Added

  Attachment #70020|0   |1
is obsolete||

--- Comment #53 from Victor Grousset/tuxayo  ---
Created attachment 70453
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70453=edit
Bug 19522: Label creator: edit batch: make Call number translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. then you should see "Call number" in the column names
6. apply this patch
7. install the fr_FR locale
8. refresh the page
9. then you should see "Cote" in the column names

Signed-off-by: Simon Pouchol 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 113 matches

Mail list logo