[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

--- Comment #19 from Katrin Fischer  ---
[% PROCESS $whole.opac_template %] doesn't work... but I am not sure why.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

--- Comment #18 from Katrin Fischer  ---
As the create functionality works on the intranet side, I wonder if it's a
problem with picking the right templates on OPAC?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

--- Comment #11 from Josef Moravec  ---
(In reply to M. Tompsett from comment #8)
> (In reply to Matthias Meusburger from comment #6)
> > Your patch works well, it prevents from crashing on a unknown barcode.
> > 
> > However, I couldn't reproduce the crash on a payment.
> 
> I will revise test plan so it is explicitly clear. I confirmed it does fail
> on payments. I am also pleased to announce that FINALLY, I RTFM'd regarding
> the offline client, and am much happier about it now.

Thanks Mark, excellent work!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20041] New: ILL module missing from more menu in staff when activated

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041

Bug ID: 20041
   Summary: ILL module missing from more menu in staff when
activated
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: ILL
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
Depends on: 7317

When the ILL module is activated and configured it shows as a new icon on the
start page, but it's missing on the 'more' menu in the top navigation.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317
[Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||20041


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20041
[Bug 20041] ILL module missing from more menu in staff when activated
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

--- Comment #17 from Katrin Fischer  ---
I am passing QA on the fix as it's obviously correct, but this bug is not
resolved with it yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70701|0   |1
is obsolete||

--- Comment #16 from Katrin Fischer  ---
Created attachment 70737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70737=edit
Bug 20001: Fix confusion between array and arrayref

Illrequest->available_backends always returned only 1 element

TEST PLAN
-
See bug 7317 comment #20 for configuring ILL
Make sure to restart_all
Strangely, ILLIBS didn't exist, but IL did in default install,
so use that as the patron code in your koha-conf.xml
Make sure to turn on the ILL related system preference.

1) Configure ILL.
   -- this is the hard part. Hopefully the above will give you
  enough.
2) open OPAC and log in
3) Click the 'your interlibrary loan request' in the left pane
4) Click the 'Create a new request' button.
   -- when you hover your mouse over the links for the backends,
  they will have ARRAY(...) instead of a meaningful name.
  This is what triggers the error (see comment #7).
5) Run the following commands
git checkout -b bug_20001 origin/master
git bz apply 20001
restart_all
6) Refresh the OPAC page, and repeat step 4.
-- when hovering your mouse over the links for the backends,
   they will have meaningful values now.
7) run koha qa test tools.

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

--- Comment #15 from Katrin Fischer  ---
The button's functionality is restored with the patch. But the problem of the
non-functional exploding Dummy and FreeForm (which should work universally)
remains. Actually using the button still leads to:

Template process failed: file error - : not found at
/home/vagrant/kohaclone/C4/Templates.pm line 122.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19928] Acquisitions' CSV exports should honor syspref "delimiter"

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19928

--- Comment #24 from Katrin Fischer  ---
(In reply to Victor Grousset/tuxayo from comment #21)
> (In reply to Katrin Fischer from comment #17)
> > It's missing steps.
> > 
> > - you need to update the po files after the patch was applied
> > - you have to check that the string got not marked as 'fuzzy'
> > - you have to reinstall the language
> > 
> > Only then the test gives you a correct result.
> 
> I don't get, isn't this covered in the steps 18?

Sorry Viktor, it appears I didn't read to the end of the test plan...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040

Katrin Fischer  changed:

   What|Removed |Added

   Severity|blocker |major

--- Comment #2 from Katrin Fischer  ---
Not a blocker - feature can be turned off (workaround) and no data loss:
https://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines#Severity

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18314] Account lockout

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||20040


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040
[Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot
log in unless the syspref is cleared
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||18314
 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Barton, the preference is not related to ifNorwegianPatronDBEnable. See
here:
bug 18314

This login_attempts field is reset when a patron correctly logs in. When
the account is locked the patron has to reset his/her password using
the OpacResetPassword feature or ask a staff member to generate a new
password.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314
[Bug 18314] Account lockout
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70592|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 70735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70735=edit
Bug 9634: Allow for combining same paraneters in SQL reports

This patch set adds a new colum to saved_sql 'combine_params'

If set, parameters that have the same name and data type will only be
asked for once from the user

To test:
 1 - Create a report that takes multiple parameters, e.g.:
SELECT <> AS one, <> AS two, <> as three,
   <> as four, <> as five
 2 - Run this report, note you are asked for five parameters
 3 - Apply patch
 4 - Update database
 5 - Run report, note you are still asked for five parameters
 6 - Edit report, note the 'Combine params' options, say YES!
 7 - Re-run the report, you shoudl be asked for three parameters
 8 - Verify the results reflect the supplied parameters
 9 - Create a new report (perhaps something more substantive)
10 - Save with 'combine params' checke
11 - View in saved reports and see the new 'combine params' column
12 - Verify it is correctly set
13 - Run the report and verify correct results
14 - prove -v t/db_dependent/Reports/Guided.t

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9634] Allow for parameters re-use on SQL reports

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70685|0   |1
is obsolete||

--- Comment #6 from M. Tompsett  ---
Created attachment 70736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70736=edit
Bug 9634 [QA Followup] - Add new column to kohastructure.sql

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13995] Proper Exception handling

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

--- Comment #26 from Tomás Cohen Arazi  ---
This patch doesn't really require unit tests in my opinion. But we didn't agree
(explicitly) on the one exception per file approach, and since this patch was
posted several exceptions have been added.

This patch is of big value because Olli put a lot of time thinking about the
exceptions we might need and also how to organize them.

This should be used as a basis for new exceptions addition. Maybe organized by
type or module as the ones we already have (which should be rearranged too,
virtualshelves, etc)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13995] Proper Exception handling

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

--- Comment #25 from M. Tompsett  ---
(In reply to Josef Moravec from comment #24)
> (In reply to Olli-Antti Kivilahti from comment #23)
> > Created attachment 60963 [details] [review] [review]
> > Bug 13995 - Proper Exception handling
> 
> Is it ready for testing again? What is the test plan?

Nope. Because the test that Olli-Antti Kivilahti added was only for one of the
exceptions added. Still Failed QA, because of inadequate test coverage.
Jonathan Druart came across as rather particular on this point in a recent IRC
meeting.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19802] Move Selenium code to its own module

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802

M. Tompsett  changed:

   What|Removed |Added

  Attachment #69756|0   |1
is obsolete||

--- Comment #4 from M. Tompsett  ---
Created attachment 70733
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70733=edit
Bug 19802: Move Selenium code to t::lib::Selenium

To make it reusable easily.

Test plan:
The basic_workflow.t tests should still pass after this change.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19802] Move Selenium code to its own module

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com
 Status|Needs Signoff   |Signed Off

--- Comment #6 from M. Tompsett  ---
prove before and after both pass, as expected. Code eyeballs well enough.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19802] Move Selenium code to its own module

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19802

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70158|0   |1
is obsolete||

--- Comment #5 from M. Tompsett  ---
Created attachment 70734
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70734=edit
Bug 19802: Add stack trace to ease debugging

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19712] Fix command line options of delete_records_via_leader.pl

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19712

--- Comment #2 from M. Tompsett  ---
Created attachment 70732
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70732=edit
Bug 19712: Followup adding missing use Pod::Usage

pod2usage call failed otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20026] Add new permission related to personal data

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20026

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19832] SIP checkout removes extra hold on same biblio

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19832

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #1 from Liz Rea  ---
This is clearly wrong, I have a library having this exact problem right now.

Will give your solution a go and see what happens.

Cheers,
Liz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

--- Comment #10 from M. Tompsett  ---
While the rebase was easy enough to do, I still couldn't figure out how to get
step 2 to happen.

When I locked the table, the canary code paused the script execution until I
unlocked it.

I did try filling the message_queue table. Somewhere around 1.5 million
messages, and it complained the table was full in sql. However, that doesn't
prevent an update. And the number of records was a function of how much space
was left.

I attempted to 'dd' the drive full, and yet I was still able to run the script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040

Barton Chittenden  changed:

   What|Removed |Added

   Severity|enhancement |blocker

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20040] New: FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040

Bug ID: 20040
   Summary: FailedLoginAttempts syspref will lock out users so
that they cannot log in unless the syspref is cleared
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

I think that the FailedLoginAttempts system preference is only meant to be set
ifNorwegianPatronDBEnable is set to 'Enable'; my testing is all done with
ifNorwegianPatronDBEnable set to 'Disable'.

What's happening:

Setting FailedLoginAttempts, then logging in with incorrect credentials will
lock the account. The login screen says that the account is locked, and no
further attempts to log in will work.

It is entirely unclear how to unlock the account -- resetting the password does
not work, and the lock is not set via borrower debarments, so it can't be
disabled there.

The only way I was able to re-enable logins for a locked patron was to blank
out FailedLoginAttempts.

If this is only meant to be used in conjunction with ifNorwegianPatronDBEnable,
it shouldn't be settable unless that is enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #70730|0   |1
is obsolete||

--- Comment #40 from Aleisha Amohia  ---
Created attachment 70731
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70731=edit
Bug 14272: [FOLLOW-UP] Show single news item

This patch fixes merge conflicts, an error in the query, and changes the
column name `new` to `content`. This patch is now ready to test.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #59483|0   |1
is obsolete||

--- Comment #39 from Aleisha Amohia  ---
Created attachment 70730
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70730=edit
Bug 14272: [FOLLOW-UP] Show single news item

This patch fixes merge conflicts, an error in the query, and changes the
column name `new` to `content`. This patch is now ready to test.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #50559|0   |1
is obsolete||

--- Comment #38 from Aleisha Amohia  ---
Created attachment 70729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70729=edit
Bug 14272: Show single news item (OPAC)

This change makes the news shown on opac-main-pl have
clickable headings which shows just that news item in isolation.
This is to allow further patches that adds commentary functions.

Sponsored-By: Halland County Library

Test plan:
  * Apply this patch.
  * Go to OPAC main, you should see multiple news items by default.
* If you do not see any, go to Staff interface and add a few.
  * Each nees item heading should be clickable.
  * When clicked only that item should be shown.
* When 'news_id' is present, only a single news item should show.
* The breadcrumb should say 'News item' after 'Home'.

Updates:
  * Renamed URL parameter and local variables with 'news_' prefix.
  * Fixed Search-And-Replace error; 'news_news_id' => 'news_id'
  * Added breadcrumb for viewing single news item.
  * Updated OPAC to use new GetNewsToDisplay parameters
  * Fixed template formatting and calling of GetNewsToDisplay

Signed-off-by: Aleisha 

Fixing merge conflicts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14272] Allow OPAC to show a single news item

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #50558|0   |1
is obsolete||

--- Comment #37 from Aleisha Amohia  ---
Created attachment 70728
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70728=edit
Bug 14272: Show single news item (backend)

Updates:
  * Date formatting added to get_opac_new()
  * Proper filtering by way of GetNewsToDisplay

Sponsored-by: Halland County Library

Signed-off-by: Aleisha 

Fixing merge conflicts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19660] Set borrower password on first login from self registration

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660

jway...@hotmail.com changed:

   What|Removed |Added

  Attachment #70727|Bug-19960   |Bug-19960: Fix password
description||field

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19660] Set borrower password on first login from self registration

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19660

--- Comment #2 from jway...@hotmail.com ---
Created attachment 70727
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70727=edit
Bug-19960

This is a follow up patch to fix the password field on the registration
complete page.
Please upload this patch along with the previous version :)
Test plan:
1. Apply this patch
2. The password field has the pregenerated password if the syspref is
enabled
3. Before the patch the password was displayed on the screen in a span
tag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Zoe Bennett  changed:

   What|Removed |Added

  Attachment #70723|0   |1
is obsolete||

--- Comment #14 from Zoe Bennett  ---
Created attachment 70726
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70726=edit
Bug 19641 (Follow-up) Correct popup templates

This patch corrects the footer include for two patron-related popup
windows. popup-bottom.inc should be considered obsolete, and
"'intranet-bottom.inc' popup_window=1" used in its place.

To test you must have more than one adult-type patron category defined.

- Locate and view a child-type patron record.
- From the "More" menu in the toolbar, choose "Update child to adult
  patron."
  - The popup window which appears should look correct and work
correctly.
- Add a new patron and enter the first and last names of an existing
  patron.
  - When Koha asks to confirm a possible duplicate record, click the
"View existing record" link. The popup which is triggered should
look correct.

Signed-off-by: Zoe Bennett 

Signed-off-by: Your Full Name 

Signed-off-by: Your Full Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Zoe Bennett  changed:

   What|Removed |Added

  Attachment #70428|0   |1
is obsolete||

--- Comment #12 from Zoe Bennett  ---
Created attachment 70724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70724=edit
Bug 19641: Move patron templates to the footer

This patch modifies the staff client patron module templates so that
JavaScript is included in the footer instead of the header.

This patch touches a lot of files because the changes are all
interdependent, affecting a couple of module-wide include files.

To test, apply the patch and test the JavaScript-driven features of the
modified templates: All button controls, DataTables functionality, tabs,
etc.

Patrons -> Patrons home, patron search results
  -> Manage pending modification requests
  -> Patron detail page
-> Edit patron
  -> Set guarantor
-> Fines
   -> Account, Pay fines, Create manual invoice, Create manual
  credit
   -> Print receipts for different kinds of charges
-> Routing lists
-> Circulation history
-> Holds history
-> Notices
-> Statistics
-> Files
-> Purchase suggestions
-> Discharges
-> Housebound
-> Set permissions
-> Change password
-> Print summary, slips, and overdues
-> Update child to adult patron type

Patron toolbar and patron search bar operations should work correctly on
all pages.

This patch also updates the template for searching the Norwegian
national patron database, but it has NOT been tested.

Signed-off-by: Claire Gravely 

Signed-off-by: Your Full Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Zoe Bennett  changed:

   What|Removed |Added

  Attachment #70429|0   |1
is obsolete||

--- Comment #13 from Zoe Bennett  ---
Created attachment 70725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70725=edit
Bug 19641 (Follow-up) Update circulation.tt too

This patch makes the same JS-to-footer changes to circulation.tt.
Inclusion of this template in this bug is necessary because it includes
members-toolbar.inc.

To test, apply the patch and clear your browser cache if necessary.

- Enter a patron card for checkout
- Test any JavaScript-driven actions on the checkout page, for instance:
- Select all/clear all controls
- Datepicker/timepickers
- Datatable sorting, columns configuration
- Renewals, check-ins
- Patron message interactions, print slip, and other toolbar actions
- Checkout exports
- Search to hold
- Tab loading: Restrictions, Holds, Clubs

Signed-off-by: Your Full Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Zoe Bennett  changed:

   What|Removed |Added

  Attachment #70720|0   |1
is obsolete||

--- Comment #11 from Zoe Bennett  ---
Created attachment 70723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70723=edit
Bug 19641 (Follow-up) Correct popup templates

This patch corrects the footer include for two patron-related popup
windows. popup-bottom.inc should be considered obsolete, and
"'intranet-bottom.inc' popup_window=1" used in its place.

To test you must have more than one adult-type patron category defined.

- Locate and view a child-type patron record.
- From the "More" menu in the toolbar, choose "Update child to adult
  patron."
  - The popup window which appears should look correct and work
correctly.
- Add a new patron and enter the first and last names of an existing
  patron.
  - When Koha asks to confirm a possible duplicate record, click the
"View existing record" link. The popup which is triggered should
look correct.

Signed-off-by: Zoe Bennett 

Signed-off-by: Your Full Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952

Te Rauhina Jackson  changed:

   What|Removed |Added

  Attachment #70423|0   |1
is obsolete||

--- Comment #2 from Te Rauhina Jackson  ---
Created attachment 70722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70722=edit
Bug 19952: Update popup window templates to use Bootstrap grid: UNIMARC
cataloging plugins

This patch updates two UNIMARC cataloging plugin templates to use the
Bootstrap grid instead of the YUI grid.

- unimarc_field_210c_bis.tt
- unimarc_field_686a.tt

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that the
page in the popup window looks correct. Confirm that changes made in the
popup window are saved to the corresponding field in the editor.

Signed-off-by: Te Rauhina Jackson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19952] Update popup window templates to use Bootstrap grid: UNIMARC cataloging plugins

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19952

Te Rauhina Jackson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595

jway...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595

--- Comment #2 from jway...@hotmail.com ---
Created attachment 70721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70721=edit
Bug-15595: Google cover staff search and detail

Test plan:
1. Apply patch
2. In system preferences enable GoogleJacketsIntra
3. Cover images from Google should show in results page and detail page
4. If the record doesn't have a cover, it should display "No cover image
available"
4. Disabling the GoogleJacketIntra will cause the cover images not to
show
5. Without patch there is no GoogleJacketsIntra syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Zoe Bennett  changed:

   What|Removed |Added

  Attachment #70433|0   |1
is obsolete||

--- Comment #10 from Zoe Bennett  ---
Created attachment 70720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70720=edit
Bug 19641 (Follow-up) Correct popup templates

This patch corrects the footer include for two patron-related popup
windows. popup-bottom.inc should be considered obsolete, and
"'intranet-bottom.inc' popup_window=1" used in its place.

To test you must have more than one adult-type patron category defined.

- Locate and view a child-type patron record.
- From the "More" menu in the toolbar, choose "Update child to adult
  patron."
  - The popup window which appears should look correct and work
correctly.
- Add a new patron and enter the first and last names of an existing
  patron.
  - When Koha asks to confirm a possible duplicate record, click the
"View existing record" link. The popup which is triggered should
look correct.

Signed-off-by: Zoe Bennett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641

Zoe Bennett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595

jway...@hotmail.com changed:

   What|Removed |Added

 CC||jway...@hotmail.com
  Attachment #70719|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15595] Display Google Jacket image on staff client search list and detail page

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15595

--- Comment #1 from jway...@hotmail.com ---
Created attachment 70719
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70719=edit
Decided to make no cover message the same

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947

Charlotte Cordwell  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19947] Update popup window templates to use Bootstrap grid: Acquisitions transfer order

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19947

Charlotte Cordwell  changed:

   What|Removed |Added

  Attachment #70412|0   |1
is obsolete||

--- Comment #2 from Charlotte Cordwell  ---
Created attachment 70718
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70718=edit
Bug 19947: Update popup window templates to use Bootstrap grid: Acquisitions
transfer order

This patch updates the acquisitions transfer order template to use the
Bootstrap grid instead of the YUI grid.

Also fixed: Corrected footer include for popup window.

To test, apply the patch and go to Acquisitions -> Vendor -> Open order
-> Transfer.

In the popup window search for a vendor, select, and choose a basket.

Signed-off-by: Charlotte Cordwell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022

--- Comment #1 from Grace  ---
Created attachment 70717
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70717=edit
Bug 20022 - use Modern::Perl in t (test) perl scripts

Test Plan:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

00-checkdatabase-version.t
00-deprecated.t
00-valid-xml.t
AuthoritiesMarc_MARC21.t
AuthoritiesMarc_UNIMARC.t
Barcodes_EAN13.t
Barcodes_annual.t
Barcodes_hbyymmincr.t
Barcodes_incremental.t
Bookseller.t
Budgets.t
ClassSortRoutine.t
ClassSortRoutine_Dewey.t
ClassSortRoutine_Generic.t
ClassSortRoutine_LCC.t
ClassSource.t
Contract.t
Creators.t
EdiInvoice.t
Edifact.t
Ediorder.t
Ediordrsp.t
External/Syndetics.t
Form_MessagingPreferences.t
Heading.t
HtmlTags.t
Installer_PerlDependencies.t
Installer_pm.t
ItemCirculationAlertPreference.t
Koha_Util_MARC.t
Labels.t
Labels_split_ccn.t
Labels_split_ddcn.t
Labels_split_lccn.t
Log.t
Members_Attributes.t
Members_Messaging.t
Output.t
Output_JSONStream.t
Patroncards.t
Patroncards_Batch.t
Patroncards_Layout.t
Patroncards_Lib.t
Patroncards_Patroncard.t
Patroncards_Profile.t
Patroncards_Template.t
Print.t
QueryParser.t
Scheduler.t
Scrubber.t
Stats.t
SuggestionEngine.t
TmplToken.t
db_dependent/00-strict.t
db_dependent/Amazon.t
db_dependent/Heading_MARC21.t
db_dependent/LDAP/test_ldap_add.pl
db_dependent/Languages.t
db_dependent/MungeMarcPrice.t
db_dependent/Record/Record.t
db_dependent/RecordProcessor_EmbedSeeFromHeadings.t
db_dependent/Reports.t
db_dependent/Service.t
db_dependent/SuggestionEngine_ExplodedTerms.t
db_dependent/Tags.t
smolder_smoke_signal

:)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20022] use Modern::Perl in t (test) perl scripts

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20022

Grace  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946

Te Rauhina Jackson  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946

Te Rauhina Jackson  changed:

   What|Removed |Added

  Attachment #70411|0   |1
is obsolete||

--- Comment #2 from Te Rauhina Jackson  ---
Created attachment 70716
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70716=edit
Bug 19946: Update popup window templates to use Bootstrap grid: Authority
Z39.50 search

This patch updates the authority Z39.50 search template to use the
Bootstrap grid instead of the YUI grid.

Also fixed: Some capitalization corrections, better 
handling. This patch does not fix Bug 17119.

To test, apply the patch and go to Authorities -> New from Z39.50.
In the popup window, both the search form and search results pages
should look correct.

Signed-off-by: Te Rauhina Jackson 

Signed-off-by: Te Rauhina Jackson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949

Zoe Bennett  changed:

   What|Removed |Added

  Attachment #70417|0   |1
is obsolete||

--- Comment #2 from Zoe Bennett  ---
Created attachment 70715
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70715=edit
Bug 19949: Update popup window templates to use Bootstrap grid: Cataloging
authority search

This patch updates the cataloging authority search templates to use the
Bootstrap grid instead of the YUI grid.

To test you must have a MARC subfield configured with "Thesaurus"
linked to an authority type.

Apply the patch and go to Cataloging -> New record. Click the plugin
link for the field which is linked to authorities. In the popup window,
the search form and search results should look correct.

Signed-off-by: Zoe Bennett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949

Zoe Bennett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959

Charlotte Cordwell  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19959] Update popup window templates to use Bootstrap grid: Label creator

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19959

Charlotte Cordwell  changed:

   What|Removed |Added

  Attachment #70438|0   |1
is obsolete||

--- Comment #2 from Charlotte Cordwell  ---
Created attachment 70714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70714=edit
Bug 19959: Update popup window templates to use Bootstrap grid: Label creator

This patch updates two label creator templates to use the Bootstrap grid
instead of the YUI grid.

To test, apply the patch and go to Label creator -> Manage -> Label
batches.

- Create a new or open an existing label batch.
- Click "Add items."
  - The resulting pop-up window should look correct.
  - Perform a search
- The search results screen should look correct.

Signed-off-by: Charlotte Cordwell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932

Zoe Bennett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19932] Update popup window templates to use Bootstrap grid: Cataloging Z39.50 search

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19932

Zoe Bennett  changed:

   What|Removed |Added

  Attachment #70341|0   |1
is obsolete||

--- Comment #2 from Zoe Bennett  ---
Created attachment 70713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70713=edit
Bug 19932: Update popup window templates to use Bootstrap grid: Cataloging
Z39.50 search

This patch updates the cataloging Z39.50 search template to use the
Bootstrap grid instead of the YUI grid.

Also fixed: Several un-quoted HTML attributes have been corrected.

To test, apply the patch and go to Cataloging -> New from Z39.50/SRU.
In the popup window, both the search form and search results pages
should look correct.

Signed-off-by: Zoe Bennett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019

Te Rauhina Jackson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20019] use Modern::Perl in miscellaneous perl scripts

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20019

--- Comment #1 from Te Rauhina Jackson  ---
Created attachment 70712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70712=edit
Bug-20019 - use Modern::Perl in misc perl scripts

Test Plan:
Test Plan:
Check the following files have been updated from
use strict;
use warnings;
to
use Modern::Perl;

services/itemrecorddisplay.pl
suggestion/suggestion.pl
tags/list.pl
tags/review.pl
virtualshelves/sendshelf.pl
help.pl
changelanguage.pl
koha_perl_deps.pl
debian/bd-to-depends
debian/build-git-snapshot
debian/list-deps
docs/CAS/CASProxy/examples/koha_webservice.pl
docs/CAS/CASProxy/examples/proxy_cas.pl
docs/CAS/CASProxy/examples/proxy_cas_callback.pl
docs/CAS/CASProxy/examples/proxy_cas_data.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

--- Comment #5 from Zoe Bennett  ---
Created attachment 70711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70711=edit
Bug 2: Fixing problems with the change to 'use strict: use warnings;' to
'use Modern::Perl;' in the following installer scripts

data/mysql/patroncards_upgrade.pl
data/mysql/update22to30.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

Zoe Bennett  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20000] use Modern::Perl in installer perl scripts

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2

--- Comment #4 from Zoe Bennett  ---
Created attachment 70710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70710=edit
Bug 2: Fixing problems with the change to 'use strict: use warnings;' to
'use Modern::Perl;' in the follwing installer script

data/mysql/labels_upgrade.pl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987

Grace  changed:

   What|Removed |Added

  Attachment #70659|0   |1
is obsolete||

--- Comment #3 from Grace  ---
Created attachment 70709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70709=edit
Bug 19987: If no z39.50/SRU servers the button should not show

Test plan:
[1.] Load the patch and make sure you have some Z39.50/SRU servers
(Administration => Z39.50/SRU servers administration)
[2.] Then go to authorities and notice that the 'New from
Z39.50/SRU' button is
there
[3.] Next go to cataloging and notice that the 'New from Z39.50/SRU'
button
is there too
[4.] Now make sure you have no Z39.50/SRU servers (remove the
servers)
(Administration => Z39.50/SRU servers administration)
[5.] Go to authorities and notice that the 'New from Z39.50/SRU'
button
is not there
[6.] Lastly go to cataloging and notice that the 'New fromZ39.50/SRU'
Z39.50/SRU'
button is not there too

:)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19987] If no z39.50/SRU servers, the z39.50/ SRU buttons should not show

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19987

Grace  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427

Te Rauhina Jackson  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16427] Direct link to authority records missing in staff detail view

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16427

Te Rauhina Jackson  changed:

   What|Removed |Added

  Attachment #70666|0   |1
is obsolete||

--- Comment #6 from Te Rauhina Jackson  ---
Created attachment 70708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70708=edit
Bug 16427 - Direct link to authority records missing staff detail view

Thanks Owen, I've just added the whitespace before the magnifying glass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||mtomp...@hotmail.com

--- Comment #9 from M. Tompsett  ---
Bug 18894 broke this easily applying... I'll get around to fixing it later, if
Kyle doesn't beat me to it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20038] New: Switch single-column templates to Bootstrap grid: Acquisitions

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038

Bug ID: 20038
   Summary: Switch single-column templates to Bootstrap grid:
Acquisitions
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 19980

There are several single-column templates in the Acquisitions module which can
be updated to use Bootstrap.

acqui\addorder.tt
acqui\z3950_search.tt
acqui\basketheader.tt
acqui\cancelorder.tt
acqui\modordernotes.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980
[Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20038


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20038
[Bug 20038] Switch single-column templates to Bootstrap grid: Acquisitions
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19864] UNIMARC field 100 plugin broken

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19864

Owen Leonard  changed:

   What|Removed |Added

 Status|RESOLVED|CLOSED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037

--- Comment #1 from Owen Leonard  ---
Created attachment 70707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70707=edit
Bug 20037: Switch single-column templates to Bootstrap grid: Serials

This patch updates several single-column Serials module templates to
use the Bootstrap grid. In addition to grid changes, some templates have
been modified to include the footer with the correct popup parameter.

- serials\acqui-search.tt - Go to Serials -> New subscription. Click
  "Search for a vendor."

- serials\acqui-search-result.tt - Vendor search results

- serials\result.tt - Click "Search for record."

- serials\subscription-bib-search.tt - Catalog search results.

Each of these pages should look correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20037] Switch single-column templates to Bootstrap grid: Serials

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19863] Add more save options when edditing authorities

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19863

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18034] Pseudonym records not found in a research by author

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18034

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18023] Add "New from Z39.50" button on search results in Authorities module

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18023

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20037] New: Switch single-column templates to Bootstrap grid: Serials

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037

Bug ID: 20037
   Summary: Switch single-column templates to Bootstrap grid:
Serials
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 19980

There are several single-column Circulation templates which can be updated to
use the Bootstrap grid.

- serials\acqui-search-result.tt
- serials\acqui-search.tt
- serials\result.tt
- serials\subscription-bib-search.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980
[Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20037


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20037
[Bug 20037] Switch single-column templates to Bootstrap grid: Serials
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #18 from Jonathan Druart  
---
(In reply to Nicolas Legrand from comment #16)
> is it me or there is a catalog_details.js that should be there and is not?

It was a first try, but I did not create this file finally. This line should be
removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

--- Comment #17 from Jonathan Druart  
---
Created attachment 70706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70706=edit
Bug 19289: Remove reference to a non-existent .js file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #37 from Jonathan Druart  
---
(In reply to Séverine Queune from comment #35)
> Did I miss a dependency ? The patch doesn’t seem to apply.

It applied correctly here, could you test again with this rebased version?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

--- Comment #36 from Jonathan Druart  
---
Created attachment 70705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70705=edit
Bug 19287: Add ability to mark an item 'Lost' from 'Holds to pull' list

The goal to this enhancement is to add the ability to cancel a hold and
mark items as lost from the 'Holds to pull' page.
A new pref is added to control the behaviour, default is off

To mark items as lost you need to set the new pref CanMarkHoldsToPullAsLost to
one of these two values:
- "Allow to mark items as lost"
=> The item will be marked as lost and the hold will be cancelled
- "Allow to mark items as lost and notify the patron"
=> Same as previously but the patron will be notified as well.

The notification is done using a new notice template
(code=CANCEL_HOLD_ON_LOST).
Feel free to suggest another default wording.

To update the values of the items when one of these 2 buttons are used, you
need to
fill the UpdateItemWhenLostFromHoldList with something like: 'itemlost: 1'

Test plan:
1/ Place holds on some items
2/ Go to Home > Circulation > Holds to pull
>From here you can cancel the hold or
3/ Mark the items as lost
=> You will receive feedback messages depending on different situations:
* The CANCEL_HOLD_ON_LOST does not exist
* The patron does not have an email address (but the notice has been
enqueued! It is the current behaviour with other notices)
* The notice has been enqueued
* The hold has been cancelled

QA Notes:
>From which library do we want to pick the notice? This patch use
reserves.branchcode

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #69746|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977

M. Tompsett  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20036] Switch single-column templates to Bootstrap grid: Offline circulation

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036

--- Comment #1 from Owen Leonard  ---
Created attachment 70704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70704=edit
Bug 20036: Switch single-column templates to Bootstrap grid: Offline
circulation

This patch updates three single-column offline circulation templates to
use the Bootstrap grid.

- offline_circ\process_koc.tt - Circulation -> Upload offline
  circulation.

- offline_circ\enqueue_koc.tt - After uploading offline circulation
  file -> Add to offline circulation queue. The confirmation page is the
  page to be tested.

- offline_circ\list.tt - From the confirmation page -> View pending
  offline circulation actions.

Each of these pages should look correct, with a single centered column
with wide margins on either side. At lower browser widths the margins
should disappear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20036] Switch single-column templates to Bootstrap grid: Offline circulation

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20036] New: Switch single-column templates to Bootstrap grid: Offline circulation

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036

Bug ID: 20036
   Summary: Switch single-column templates to Bootstrap grid:
Offline circulation
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 19980

There are three single-column Offline circulation templates which can be
updated to use the Bootstrap grid:

offline_circ\enqueue_koc.tt
offline_circ\list.tt
offline_circ\process_koc.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980
[Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20036


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20036
[Bug 20036] Switch single-column templates to Bootstrap grid: Offline
circulation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70548|0   |1
is obsolete||

--- Comment #3 from M. Tompsett  ---
Created attachment 70703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70703=edit
Bug 19977: Open only .pref files in Local Use tab (sysprefs)

Test plan:
1. Open .../prog/en/modules/admin/preferences/circulation.pref
with vim (check that it creates a .circulation.pref.swp in the same
directory)
2. Go to the "Local Use" tab in admin/systempreferences.pl
3. Confirm that the page works normally

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19977] Local Use tab in systempreferences tries to open text editor' s temporary files, and die

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19977

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #2 from M. Tompsett  ---
One would hope this case never happens. And if it does, stop editing the files
on a live system. That being said, this is a straight-forward regexp
tightening.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19873] Make it possible to search on value 0

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873

--- Comment #3 from M. Tompsett  ---
Comment on attachment 70122
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70122
Bug 19873 - Ability to search on 0 value

Review of attachment 70122:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=19873=70122)
-

::: C4/Search.pm
@@ +1532,4 @@
>  for ( my $i = 0 ; $i <= @operands ; $i++ ) {
>  
>  # COMBINE OPERANDS, INDEXES AND OPERATORS
> +if ( $operands[$i] ne '' ) {

perhaps a $operands[$i] // q{} ne q{} would be in order.
We don't want floody logs if $operands[$i] is undef.

@@ +1677,4 @@
>  query_desc => $query_desc,
>  operator => ($operators[ $i - 1 ]) ? $operators[ $i - 1 
> ] : '',
>  parsed_operand => $operand,
> +original_operand => ($operands[$i] ne '') ? 
> $operands[$i] : '',

perhaps a $operands[$i] // q{} is sufficient?
We don't want floody logs if $operands[$i] is undef.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20035] Switch single-column templates to Bootstrap grid: Patron clubs

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035

--- Comment #1 from Owen Leonard  ---
Created attachment 70702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70702=edit
Bug 20035: Switch single-column templates to Bootstrap grid: Patron clubs

This patch updates two single-column Patron clubs templates to
use the Bootstrap grid.

- clubs/clubs-add-modify.tt - Tools -> Patron clubs -> New club.
- clubs/templates-add-modify.tt - Tools -> Patron clubs -> New club
  template. Also changed in this file: Markup corrections. Label "for"
  attribute should match the form field's id attribute.

Each of these pages should look correct, with a single centered column
with wide margins on either side. At lower browser widths the margins
should disappear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20035] Switch single-column templates to Bootstrap grid: Patron clubs

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70700|0   |1
is obsolete||

--- Comment #14 from M. Tompsett  ---
Created attachment 70701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70701=edit
Bug 20001: Fix confusion between array and arrayref

Illrequest->available_backends always returned only 1 element

TEST PLAN
-
See bug 7317 comment #20 for configuring ILL
Make sure to restart_all
Strangely, ILLIBS didn't exist, but IL did in default install,
so use that as the patron code in your koha-conf.xml
Make sure to turn on the ILL related system preference.

1) Configure ILL.
   -- this is the hard part. Hopefully the above will give you
  enough.
2) open OPAC and log in
3) Click the 'your interlibrary loan request' in the left pane
4) Click the 'Create a new request' button.
   -- when you hover your mouse over the links for the backends,
  they will have ARRAY(...) instead of a meaningful name.
  This is what triggers the error (see comment #7).
5) Run the following commands
git checkout -b bug_20001 origin/master
git bz apply 20001
restart_all
6) Refresh the OPAC page, and repeat step 4.
-- when hovering your mouse over the links for the backends,
   they will have meaningful values now.
7) run koha qa test tools.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70696|0   |1
is obsolete||

--- Comment #13 from M. Tompsett  ---
Created attachment 70700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70700=edit
Bug 20001: Fix confusion between array and arrayref

Illrequest->available_backends always returned only 1 element

TEST PLAN
-
See bug 7317 comment #20 for configuring ILL
Make sure to restart_all
Strangely, ILLIBS didn't exist, but IL did in default install,
so use that as the patron code in your koha-conf.xml
Make sure to turn on the ILL related system preference.

1) Configure ILL.
   -- this is the hard part. Hopefully the above will give you
  enough.
2) open OPAC and log in
3) Click the 'your interlibrary loan request' in the left pane
4) Click the 'Create a new request' button.
   -- when you hover your mouse over the links for the backends,
  they will have ARRAY(...) instead of a meaningful name.
  This is what triggers the error (see comment #7).
5) Run the following commands
git checkout -b bug_20001 origin/master
git bz apply 20001
reset_all
6) Refresh the OPAC page, and repeat step 4.
-- when hovering your mouse over the links for the backends,
   they will have meaningful values now.
7) run koha qa test tools.

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20035] New: Switch single-column templates to Bootstrap grid: Patron clubs

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035

Bug ID: 20035
   Summary: Switch single-column templates to Bootstrap grid:
Patron clubs
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Keywords: Academy
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org
CC: testo...@bugs.koha-community.org
Blocks: 19980

There are two single-column Patron clubs templates which can be updated to use
Bootstrap:

clubs\clubs-add-modify.tt
clubs\templates-add-modify.tt


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980
[Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980

Owen Leonard  changed:

   What|Removed |Added

 Depends on||20035


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20035
[Bug 20035] Switch single-column templates to Bootstrap grid: Patron clubs
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20001] ILL: Adding a 'new request' from OPAC is not possible

2018-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001

--- Comment #12 from M. Tompsett  ---
(In reply to M. Tompsett from comment #11)
> I can't sign off, because I can't figure out how to set up my koha-conf.xml
> file for inter-library loans. Anyone have documentation or links?

Bug 7317 comment #20 was helpful for addressing this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >