[Koha-bugs] [Bug 20452] Add HTML classes to search results availability data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20452
--- Comment #3 from paxed ---
(In reply to M. Tompsett from comment #2)
> While the patch is good, I'm thinking that such short generic names is
> probably a bad thing. For example, look at the staff-global.css or the
> opac.less file. There are branchgrid things or #item things. Perhaps just
> adding the word list would be a good idea?
The patch doesn't add any branchgrid class, so I don't know why that would be a
problem? Also, staff-global.css doesn't have any selectors for #item? (And the
patch doesn't add any item class either - it has itemcn, which is not matched
by anything in staff-global.css - and certainly shouldn't be!
If there were any css selectors that match globally with a short, generic,
simple word commonly used in Koha (say, for example. "item"), then those
selectors should be written to be more specific - For example, a hypothetical:
#item { background: pink; }
should be written to match only at the place where we want that pink
background, say in the search results:
#searchresults #item { background: pink; }
Otherwise, the too widely matching selector would have side effects, for
example sometime later, people might add code that uses class item, but aren't
expecting it to show up with pink bg.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 M. Tompsett changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #15 from M. Tompsett --- Katrin makes a valid point. Sign off now, tests later. I didn't officially sign off, because I just shut down my work computer where I was signing off. But I'll set to Signed Off, because it truly is an identical reversion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #14 from Katrin Fischer --- We can ask why no tests was submitted initially OR when the new feature was added, but this doesn't change that this is a critical bug and we broke an important acquisitions workflow. Tomorrow releases might happen already. If we want to have a chance to get this included, we need to move fast. Can someone verify the change now is correct and sign off? I suggest documenting the need for tests on a separate bug for now. Even better of course, if someone provides them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20395] Use Price formatter in more templates (paycollect, request, parcel, smart-rules)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 --- Comment #11 from Katrin Fischer --- It might look a little different in the code, but I think still worth fixing as with this patches we have a formatted value appearing right next to an unformatted value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20395] Use Price formatter in more templates (paycollect, request, parcel, smart-rules)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 --- Comment #10 from M. Tompsett --- (In reply to Katrin Fischer from comment #9) > The change on smart rules is incomplete, the fine amount still doesn't use > the formatter, so we are getting a mixed display. can you please fix? Anything that was formatted has been fixed already. Are you finding a different bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 M. Tompsett changed: What|Removed |Added Attachment #71625|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 73130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73130&action=edit Bug 20180: [sql_modes] Remove GROUP BY clause in manage-marc-import.pl Replaced with a distinct. Fix for: 'koha_kohadev.me.frameworktext' isn't in GROUP BY t/db_dependent/www/search_utf8.t NOTE: I added a [% frameworks.count %] into the template file, and compared master and a branch with this applied when managing a staged marc import. Values were identical. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20180] Remove GROUP BY clause in manage-marc-import.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20180 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What|Removed |Added Attachment #64245|0 |1 is obsolete|| --- Comment #36 from Aleisha Amohia --- Created attachment 73125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73125&action=edit Bug 8630 - Adlibris covers (intranet templates) Changes to staff interface (intranet) templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test results.tt * From the main intranet page, select "Search the catalog" and enter the title we added, "1984" and press "Search". * You should end up with the url: http://127.0.1.1:8080/cgi-bin/koha/catalogue/search.pl?q=1984 * The cover image should be shown in the leftmost column. * If cover is clicked, the full cover image should be shown. * Test detail.tt (continue from the search results used in prev. test) * Click on the title text, you should be sent to: http://127.0.1.1:8080/cgi-bin/koha/catalogue/detail.pl?biblionumber=2 * The cover image should be shown on the right. * If clicked, the full cover should be shown. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What|Removed |Added Attachment #64248|0 |1 is obsolete|| --- Comment #39 from Aleisha Amohia --- Created attachment 73128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73128&action=edit Bug 8630 - Adlibris covers (OPAC less changes) This patch adds two new CSS classes specific to Adlibris covers. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What|Removed |Added Attachment #68366|0 |1 is obsolete|| --- Comment #40 from Aleisha Amohia --- Created attachment 73129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73129&action=edit Bug 8630 - Regenerated CSS - Not minified, do NOT PUSH! Had trouble with rgenerating the minified CSS in kohadevbox, but uploading this as a help for others. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What|Removed |Added Attachment #64247|0 |1 is obsolete|| --- Comment #38 from Aleisha Amohia --- Created attachment 73127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73127&action=edit Bug 8630 - Adlibris covers (OPAC templates) Changes to OPAC templates. Depends on new CSS clases defined in separate patch. Test plan: To test this particular patch (intranet templates) you need: * The syspref patch applied * The intranet CSS patch applied To test: * Apply this patch * Enable covers (if not done already) * Go to staff interface, log in as a priviliged user. * Select "More" -> "Administration" -> "Global system preferences" -> "Enhanced content". * Set ""AdlibrisCoversEnabled" to "Show" under "Adlibris". * Save changes * Add a book with a known cover/ISBN (if none exists) * Set MARC field 020 a, "INTERNATIONAL STANDARD BOOK NUMBER" to: 9780451524935 * Set MARC field 245 a, "Title" to: 1984 * Save changes * Test opac-results.tt * Search library catalog from OPAC for "1984". * You should be sent to: http://127.0.1.1/cgi-bin/koha/opac-search.pl?idx=&q=1984 * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * Test opac-detail.tt (continued from previous test's location) * Click on the title with cover (1984, ISBN: 9780451524935) * Cover should be displayed to the left in full size. * If clicked, should link to the full-size image. Test opac-results-grouped.tt * This template is only used if an external "grouping" server is setup and the syspref "OPACGroupResults" is set to "Use". * Personally I did not test this, b/c: terminally lazy * Test opac-showreviews.tt * Could not find any links to this location, manually enter it: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl * Image should be shown to the right in full size. * If clicked it should take you to the detail view with the comments tab opened. * Test opac-showreviews-rss.tt * Click on the RSS icon from previous test's start location. URL should be: http://127.0.1.1/cgi-bin/koha/opac-showreviews.pl?format=rss * An image tag linking to the full-size image without any styling class should be present. * Test opac-user.tt * Click on your username to open: http://127.0.1.1/cgi-bin/koha/opac-user.pl * Covers should be shown for checked out items with CSS class: adlibris-cover * When clicked the destination should be the same as clicking the title column entry: opac-details.pl * Test opac-opensearch.tt * Click on "Advanced search" and enter "1984" then press "Search" * This search screen uses a different template. * Cover image should be shown to the right of each title with CSS class: "adlibris-cover" * If clicked, should link to the OPAC detail view. * Test opac-readingrecord.tt * Click on your logged-in name to go to your personal page. * Click on "Your reading history" tab on the left. http://127.0.1.1/cgi-bin/koha/opac-readingrecord.pl * Covers should be shown in leftmost column with CSS class: adlibris-cover * If clicked, should link to the same as the 'Title' link. Sponsored-By: Halland County Library Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8630] Add covers from AdLibris to the OPAC and Intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8630 Aleisha Amohia changed: What|Removed |Added Attachment #64246|0 |1 is obsolete|| --- Comment #37 from Aleisha Amohia --- Created attachment 73126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73126&action=edit Bug 8630 - Adlibris covers (intranet CSS) This defined two new CSS classes for use by the intranet templates. Apply this patch before doing the testing of "intranet templates". Sponsored-By: Halland County Library Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20456] Remove the C4::Serials::GetSubscriptionsFromBorrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 --- Comment #3 from Katrin Fischer --- I assume this is a false positive as removing a method should reduce POD :) FAIL C4/Serials.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer changed: What|Removed |Added Attachment #73115|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 73121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73121&action=edit Bug 20400: Add routing list tab in OPAC This patch adds the base for the new feature: Show a list of the serial titles a patron is on routing lists for in the OPAC. Test plan applies to the complete patch set: To test: - Apply all patches - Make sure RoutingSerials is not activated - Check patron account in OPAC - no tab should appear - Activate RoutingSerials - Create subscriptions and different routing lists, test with: - Patron with no routing list entries = no tab - Patron with one or more routing list entries = tab appears -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer changed: What|Removed |Added Attachment #73118|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 73124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73124&action=edit Bug 20400: Display new tab in OPAC only for patrons with routing lists The visibility of the routing list tab in the OPAC depends on the system preference RoutingSerials and the existence of routing list entries for the patron. Some libraries only offer routing lists to certain user groups and would not want it generally visible. As there are currently no actions you can perform from the list, this appears to be a reasonable behaviour. See test plan in first patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer changed: What|Removed |Added Attachment #73116|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 73122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73122&action=edit Bug 20400: Rewrite using Koha::Objects Adds - Koha::Subscription::Routinglist - Koha::Subscription::Routinglists Adds 2 methods - Koha::Patron::get_routinglists - Koha::Routinglist::subscription -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer changed: What|Removed |Added Attachment #73117|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 73123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73123&action=edit Bug 20400: Add unit tests prove t/db_dependent/Koha/Subscription/Routinglists.t prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20456] Remove the C4::Serials::GetSubscriptionsFromBorrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20456] Remove the C4::Serials::GetSubscriptionsFromBorrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 --- Comment #2 from Katrin Fischer --- Created attachment 73120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73120&action=edit Bug 20456: Remove the C4::Serials::GetSubscriptionsFromBorrower Bug 20400 added a routing list tab to the patron account in the OPAC using Koha::Object. After changing the staff view too, we can now safely remove GetSubscriptionsFromBorrower as it is no longer used. To test: - Make sure that GetSubscriptionsFromBorrower is no longer used. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20456] Remove the C4::Serials::GetSubscriptionsFromBorrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 --- Comment #1 from Katrin Fischer --- Created attachment 73119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73119&action=edit Bug 20456: Switch routling list tab in staff to use Koha::Object Bug 20400 added a routing list tab to the patron account in the OPAC using Koha::Object. This patch switches the routing list tab in the patron account in intranet over to the new code. It also adds an additional column showing the position of the patron on the routing list and fixes the search. To test: - Create some subscriptions with routing lists - Take a look at the patron accounts of several patrons having - no entries on routing lists - 1 entry on a routing list - entries on several routing lists - Make sure the display works correctly. - Search for a subscription and make sure search works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer changed: What|Removed |Added Blocks||20456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 [Bug 20456] Remove the C4::Serials::GetSubscriptionsFromBorrower -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20456] Remove the C4::Serials::GetSubscriptionsFromBorrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Katrin Fischer changed: What|Removed |Added Depends on||20400 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 [Bug 20400] Add routing list tab to the patron account in OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20456] New: Remove the C4::Serials::GetSubscriptionsFromBorrower
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 Bug ID: 20456 Summary: Remove the C4::Serials::GetSubscriptionsFromBorrower Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org C4::Serials::GetSubscriptionsFromBorrower is only used for the display of the routing list tab in staff. Bug 20400 implements this for the OPAC using Koha::Object. After switching staff the routine can be safely removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #8 from Katrin Fischer --- Created attachment 73118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73118&action=edit Bug 20400: Display new tab in OPAC only for patrons with routing lists The visibility of the routing list tab in the OPAC depends on the system preference RoutingSerials and the existence of routing list entries for the patron. Some libraries only offer routing lists to certain user groups and would not want it generally visible. As there are currently no actions you can perform from the list, this appears to be a reasonable behaviour. See test plan in first patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #7 from Katrin Fischer --- Created attachment 73117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73117&action=edit Bug 20400: Add unit tests prove t/db_dependent/Koha/Subscription/Routinglists.t prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer changed: What|Removed |Added Attachment #72974|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 73116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73116&action=edit Bug 20400: Rewrite using Koha::Objects Adds - Koha::Subscription::Routinglist - Koha::Subscription::Routinglists Adds 2 methods - Koha::Patron::get_routinglists - Koha::Routinglist::subscription -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20400] Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer changed: What|Removed |Added Attachment #72973|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 73115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73115&action=edit Bug 20400: Add routing list tab in OPAC This patch adds the base for the new feature: Show a list of the serial titles a patron is on routing lists for in the OPAC. Test plan applies to the complete patch set: To test: - Apply all patches - Make sure RoutingSerials is not activated - Check patron account in OPAC - no tab should appear - Activate RoutingSerials - Create subscriptions and different routing lists, test with: - Patron with no routing list entries = no tab - Patron with one or more routing list entries = tab appears -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20322] Circulation page layout and design update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #12 from Liz Rea --- Created attachment 73114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73114&action=edit Screenshot of 3rd proposed changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20322] Circulation page layout and design update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 Liz Rea changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20322] Circulation page layout and design update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #11 from Liz Rea --- Created attachment 73113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73113&action=edit Bug 20322: (follow up) design refresh for circulation page Further revisions, compromise. - 4 columns to three - offline circulation demoted to below the intranet homepage preference, and no buttons, due to its relative lack of everyday use. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20322] Circulation page layout and design update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 --- Comment #10 from Katrin Fischer --- (In reply to Liz Rea from comment #9) > I'm not keen on giving the offline circulation links that much importance > for the amount they are used. > > I do like the icons on the download links though, that's neat. Maybe I'll > revise your revision. ;) > > Cheers, > Liz +1 Also there is a lot of text on the buttons which will probably not translate well. Something a little smaller might also work better for verbose languages like German :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20322] Circulation page layout and design update
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322 Liz Rea changed: What|Removed |Added Status|NEW |In Discussion --- Comment #9 from Liz Rea --- I'm not keen on giving the offline circulation links that much importance for the amount they are used. I do like the icons on the download links though, that's neat. Maybe I'll revise your revision. ;) Cheers, Liz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #15 from Katrin Fischer --- Hi Julian, can you please add a test plan for this to your commit message? Thx! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20455] New: Can't sort patron search on date expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20455 Bug ID: 20455 Summary: Can't sort patron search on date expired Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The patron search hangs when you try to sort by date expired. The error in the Plack logs is: Odd number of elements in anonymous hash at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189. output_pref is called with 'dateonly' (ref SCALAR), not a DateTime objectOdd number of elements in anonymous hash at /home/vagrant/kohaclone/C4/Utils/DataTables/Members.pm line 189. To test: - Make sure sample patron data is loaded - Make an empty search for all patrons or another search that gives you a good amount of results - Try to sort on the date expired column -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20433] Remove unused Mozilla Persona image file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20433 Katrin Fischer changed: What|Removed |Added Attachment #73096|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 73112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73112&action=edit Bug 20433: Remove unused Mozilla Persona image file This patch removes an unused image file from the OPAC which was added when we added Mozilla Persona authentication but wasn't removed when Mozilla Persona went away. To test, apply the patch and confirm that the image no longer exists: koha-tmpl/opac-tmpl/bootstrap/images/sign_in_green.png Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20433] Remove unused Mozilla Persona image file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20433 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20395] Use Price formatter in more templates (paycollect, request, parcel, smart-rules)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer --- The change on smart rules is incomplete, the fine amount still doesn't use the formatter, so we are getting a mixed display. can you please fix? Everything else appears to work nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20454] Suspend Holds if patron wouldn't be able to check items out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20454 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20454] New: Suspend Holds if patron wouldn't be able to check items out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20454 Bug ID: 20454 Summary: Suspend Holds if patron wouldn't be able to check items out Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: lisettesla...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com If a person can't check out an item due to hitting the fine limit, it would be great if the holds could be suspended automatically so it wasn't filled until the account was cleared off. This would be a good system preference so systems that didn't want to use it wouldn't be forced into it. Currently in our system patrons can't check out if they have more than $5 in fines. Sometimes they place a hold, rack up fines, and can't check out the book when it comes in for them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20395] Use Price formatter in more templates (paycollect, request, parcel, smart-rules)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Katrin Fischer changed: What|Removed |Added Summary|Paycollect does not use |Use Price formatter in more |Price formatter |templates (paycollect, ||request, parcel, ||smart-rules) --- Comment #8 from Katrin Fischer --- ... Hm, missed the patch was already done. We should change the title in that case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20395] Paycollect does not use Price formatter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20395] Paycollect does not use Price formatter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20395 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Hi Josef and others - I think fixing one file here is ok and easier to test. Let's move the others to separate bugs? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12020] Allow translating label-edit-batch hardcoded strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 Katrin Fischer changed: What|Removed |Added Attachment #72895|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 73111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73111&action=edit Bug 12020: Allow translating label-edit-batch hardcoded strings Move the hardcoded error strings in the batch label edit into the template, so they can be translated. Test plan: 1) Apply patch 2) Go to Home -> Tools -> Label edit 3) Create a new batch with some items in it 4) Try to trigger any of the errors, check that the error messages look correct 5) Update a language xx-YY 5) Check that the error messages show up in xx-YY-staff-prog.po Signed-off-by: Pasi Kallinen Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Changed branch to library in one of the error messages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12020] Allow translating label-edit-batch hardcoded strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12020] Allow translating label-edit-batch hardcoded strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12020] Allow translating label-edit-batch hardcoded strings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- A little sad that it took us so long to fix that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer changed: What|Removed |Added Attachment #72844|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer changed: What|Removed |Added Attachment #72843|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer changed: What|Removed |Added Attachment #72845|0 |1 is obsolete|| --- Comment #30 from Katrin Fischer --- Created attachment 73110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73110&action=edit Bug 17809: (follow-up) search in COUNTRY category Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #28 from Katrin Fischer --- Created attachment 73108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73108&action=edit Bug 17809: Correct authorised values for fr-FR This corrects: CC -- duplicate, but name not full. GQ -- duplicate, but only one name correct. PK -- Poland was mislabelled. This removes and edits duplicates and corrects PK to PL. Signed-off-by: Luke Honiss Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 --- Comment #29 from Katrin Fischer --- Created attachment 73109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73109&action=edit Bug 17809: Fix ER country appearing twice in fr-FR database files In installer/data/mysql/fr-FR/1-Obligatoire/authorised_values.sql, ER is defined twice, for "Erythrée" (correct one) and "Allemagne". Test plan : - Create a new database using fr-FR or import the sql file - Look at authorised values COUNTRY => without patch you have ER / Allemange => with patch you have ER / ErythrÃe NOTE: Allemange occurs twice as well, correctly with DE. This patch correctly removes the ER one. Signed-off-by: Mark Tompsett Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17809] Correct some authorised values in fr-FR
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17809 Katrin Fischer changed: What|Removed |Added Attachment #72842|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 73107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73107&action=edit Bug 17809: Add upgrade warning messages TEST PLAN - 0) backup db 1) drop db and recreate empty 2) run fr-FR web install 3) update systempreferences set Value='16.3' where variable='Version'; -- it is currently 16.4 as of this writing 4) run fr-FR web install -- bottom of red warnings should be the check messages. 5) perlcritic -1 installer/data/mysql/atomic_update/bug_17809_pretty_red.perl -- $VERSION message, which we don't care about -- maybe a message about return value of print ignored. Signed-off-by: Brendan Gallagher Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #13 from Colin Campbell --- (In reply to M. Tompsett from comment #12) > My mistake. Colin is correct. misc/cronjobs/edi_cron.pl calls > process_quote() in Koha::EDI, which calls quote_item in Koha::EDI. As far as > I can tell there is no other way to trigger quote_item. And so, I believe > the original patch was more correct, in that it is simpler. So apologies for > any frustrations. > > *IF* in the future, someone wanted to manually integrate EDI quote > processing -- it would be useful to see debugging feedback step by step -- > Kyle's patch makes sense. > > However, I still believe there should be test coverage. There is no test > coverage of Koha::EDI. This needs to be solved. It is a serious hole. Test > coverage for quote_item and/or process_quote would be good, leaving Failed > QA. patch reinstates a call to C4::Context - do we need another test to show that works? QA failed not for this patch, but for more global concerns, I'd argur thats counterproductive - or shall we just remove this functionality from Koha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #12 from M. Tompsett --- My mistake. Colin is correct. misc/cronjobs/edi_cron.pl calls process_quote() in Koha::EDI, which calls quote_item in Koha::EDI. As far as I can tell there is no other way to trigger quote_item. And so, I believe the original patch was more correct, in that it is simpler. So apologies for any frustrations. *IF* in the future, someone wanted to manually integrate EDI quote processing -- it would be useful to see debugging feedback step by step -- Kyle's patch makes sense. However, I still believe there should be test coverage. There is no test coverage of Koha::EDI. This needs to be solved. It is a serious hole. Test coverage for quote_item and/or process_quote would be good, leaving Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #11 from Colin Campbell --- (In reply to Colin Campbell from comment #10) > There is and cannot be a user interaction - you bare processing a file there > is no user satr at a terminal. This is an offline process. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #10 from Colin Campbell --- There is and cannot be a user interaction - you bare processing a file there is no user satr at a terminal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #9 from M. Tompsett --- (In reply to Colin Campbell from comment #7) > Kyle your patch is illogical the baskets in question CANNOT override the > syspreference, because we have just created them in accordance with that > syspreference microseconmds before. > Baskets can override the systempreference if there is user interaction to > make that choice, the whole point of electronic ordering is that there is no > such interaction and the basket is generated from the QUOTES message > directly with no user interaction. > reinstanting the original patch But his change allows for the case where there IS user interaction. And if it was created microseconds before, the values should be identical. If it is user interaction later, why should a system preference change after the order creation change the behaviour? Once the order is created, should you not change the behaviour on the order, not forcefully via system preference? This is why tests are very much needed, because then we'd know how it is supposed to behave, because the tests would demonstrate trigger cases. Marking Failed QA until I see tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20340] Ability to use authentication plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #18 from M. Tompsett --- Created attachment 73106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73106&action=edit Nasty Empty Drop Down Drop downs should never look like this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20340] Ability to use authentication plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #17 from M. Tompsett --- (In reply to Alex Arnaud from comment #16) > (In reply to M. Tompsett from comment #15) > > It would be nice to rework the authentication logic to all be plugins, > If you mean that LDAP, CAS and Shibboleth should be removed from the source > code and provided only as plugins, it is also my opinion :) Exactly. > > then we could actually prioritize the order of attempts, etc. etc. > We are already able to prioritize. Each auth plugin can have a priority > value and they are ordered before the call. But not the archaic LDAP, CAS, Shibboleth, etc. etc. that's hard coded already. > > 1) the test module should have an uninstall at least. > Why? See the attached empty Actions dropdown. Now bug 20438 will solve this, but still. How hard is an uninstall which calls the inherited parent? > > 2) Also, annoying POD coverage failure on the QA Test tools. [SNIP magic] > Why did you failed QA? kshell /home/vagrant/qa-test-tools/koha-qa.pl -v 2 -c 2 Though, I believe bug 20357 will deal with this, but given the feedback on my fixes, it's not getting in quickly. > And i don't understand the changes in opac-user.pl try logging in with test/test into OPAC: internal server errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20437] Force requirement for HTTP::OAI 3.27
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20437 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 73105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73105&action=edit [ALTERNATIVE] Bug 20437: Add HTTP::OAI@3.27 to the source tree -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Colin Campbell changed: What|Removed |Added Attachment #73103|0 |1 is obsolete|| --- Comment #8 from Colin Campbell --- Created attachment 73104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73104&action=edit proposed patch to allow users to use acquisitions via EDI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #7 from Colin Campbell --- Kyle your patch is illogical the baskets in question CANNOT override the syspreference, because we have just created them in accordance with that syspreference microseconmds before. Baskets can override the systempreference if there is user interaction to make that choice, the whole point of electronic ordering is that there is no such interaction and the basket is generated from the QUOTES message directly with no user interaction. reinstanting the original patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 --- Comment #15 from Matthias Meusburger --- > The second encoding parameter of new_from_xml is the desired result > encoding. Since we want UTF-8, there is no need to pass utf8. The third > parameter is the source format (UNIMARC, USMARC, MARC21), not the encoding. Yes, my bad. > Please specify what the problem was. What settings/encodings ? Nothing to see here. In the end, it was a problem I created myself. Doh. > The xml itself should contain an encoding too. > No, that is a misunderstanding. We are converting to UTF-8 as an internal > format for Koha, not as a source encoding. Yes, indeed. However, if new_from_xml can manage the encoding of the xml by itself to produce valid UTF-8, and we always use UTF-8 in Koha, this dropdown list "Encoding (z3950 can send records in various encodings. Choose one):" is completely useless when editing an SRU server, right? If it is the case, shouldn't we disable it or hide it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20438] Allow uninstalling plugins not implementing the 'uninstall' method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20438 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |kyle.m.h...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Josef Moravec changed: What|Removed |Added CC||blac...@gmail.com, ||r...@rbit.cz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20453] New: Send notification when hold is cancelled by librarian
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Bug ID: 20453 Summary: Send notification when hold is cancelled by librarian Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com When librarian cancel a patrons hold manually, it woul be nice to send a message to a patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 --- Comment #6 from Kyle M Hall --- (In reply to Colin Campbell from comment #4) > Where was the test when this code was introduced to break EDI? A lack of a test does not obviate our responsibility to add regression tests where possible and reasonable. Adding unit tests while fixing regressions in Koha is a very common occurrence. I do understand the frustration as I've been in this situation dozens of times ; ) I notice that there unit test files for invoices and orders, but not quotes. Is there any reason quotes weren't unit tested when introduced? I'll leave it to cait of mtompsett to decide if unit tests are necessary. > Basically people cant run Edifact EDI with the addition of this code > It undoes a change that should never have been made Your patch seems to introduce a regression of its own. Baskets in Koha can now override AcqCreateItem with their own alternative setting. The patch I've submitted should take care of the issue and keep support for the new feature! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19436] Add SRU support for authorities
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19436 --- Comment #14 from Marcel de Rooy --- (In reply to Matthias Meusburger from comment #13) > Both parts (in handle_one_result and Z3950SearchAuth) were made to fix an > encoding problem, but I may have not made the best of fixes. Please specify what the problem was. What settings/encodings ? > The problem comes from the fact that I tried to use the encoding string from > the Z3950 profiles for the MARC::Record->new_from_xml calls, just like it is > used for MarcToUTF8Record. > However, if MarcToUTF8Record recognizes 'UTF-8' as well as 'utf8', > MARC::Record->new_from_xml doesn't. The second encoding parameter of new_from_xml is the desired result encoding. Since we want UTF-8, there is no need to pass utf8. The third parameter is the source format (UNIMARC, USMARC, MARC21), not the encoding. The xml itself should contain an encoding too. The optimization in handle_one_result eliminated the need for calling new_from_xml and MarcToUTF8Record in a row, doing more or less the same. > So I'm perfectly fine with your revert of _handle_one_result, and making the > calls in Z3950SearchAuth in line with _handle_one_result (with the use of > the 'UTF-8' string in plain text in the code). > However, that would be assuming that all SRU servers are serving UTF-8 (are > they?). > In that case, we should disable the "Encoding" dropdown list in SRU servers > configuration. No, that is a misunderstanding. We are converting to UTF-8 as an internal format for Koha, not as a source encoding. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20452] Add HTML classes to search results availability data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20452 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||mtomp...@hotmail.com --- Comment #2 from M. Tompsett --- While the patch is good, I'm thinking that such short generic names is probably a bad thing. For example, look at the staff-global.css or the opac.less file. There are branchgrid things or #item things. Perhaps just adding the word list would be a good idea? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Kyle M Hall changed: What|Removed |Added Attachment #73090|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 73103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73103&action=edit Bug 20446: QUOTES processing broken by run time error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20438] Allow uninstalling plugins not implementing the 'uninstall' method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20438 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20438] Allow uninstalling plugins not implementing the 'uninstall' method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20438 Kyle M Hall changed: What|Removed |Added Attachment #73080|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 73102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73102&action=edit Bug 20438: Allow uninstalling plugins not implementing the 'uninstall' method The plugins handling code expects plugins implementing an 'uninstall' method for cleanup purposes. It executes this method, and then moves on with removing the configuration entries in the storage, and the plugin itself. But the 'plugins-home.tt' template makes the tool display the 'Uninstall' link in the dropdown ONLY when the plugin has the 'uninstall' method. This patch fixes the issue. To reproduce: - Install the KitchenSink plugin [1] => SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option - Edit the code for the plugin: $ sudo vim /var/lib/koha/kohadev/plugins/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm - Remove the uninstall sub - Restart everything: $ restart_all - Reload the browser => FAIL: There's no 'Uninstall' option in the actions dropdown. - Apply this patch - Restart everything $ restart_all - Reload the browser => SUCCESS: The 'actions' dropdown for KitchenSink shows an 'Uninstall' option - Sign off :-D [1] https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases Signed-off-by: Tomas Cohen Arazi Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20340] Ability to use authentication plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20340 --- Comment #16 from Alex Arnaud --- (In reply to M. Tompsett from comment #15) > It would be nice to rework the authentication logic to all be plugins, If you mean that LDAP, CAS and Shibboleth should be removed from the source code and provided only as plugins, it is also my opinion :) > then we could actually prioritize the order of attempts, etc. etc. We are already able to prioritize. Each auth plugin can have a priority value and they are ordered before the call. > This is an excellent start, but: > > 1) the test module should have an uninstall at least. Why? > 2) Also, annoying POD coverage failure on the QA Test tools. And i don't understand the changes in opac-user.pl Why did you failed QA? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20452] Add HTML classes to search results availability data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20452 paxed changed: What|Removed |Added Assignee|oleon...@myacpl.org |pasi.kalli...@joensuu.fi Status|NEW |Needs Signoff --- Comment #1 from paxed --- Created attachment 73101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73101&action=edit Bug 20452: Add HTML classes to search results availability data The data in the Location-column in the search results table is impossible to style because there are no HTML classes. Sprinkle those around, so libraries can hide information they don't need. Test plan: 1) Apply patch 2) Search for biblios 3) Check that the data in the Location-column looks correct. 4) Optionally, look through the page source that it looks correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Fiona Borthwick changed: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20452] New: Add HTML classes to search results availability data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20452 Bug ID: 20452 Summary: Add HTML classes to search results availability data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: pasi.kalli...@joensuu.fi QA Contact: testo...@bugs.koha-community.org The data in the Location-column in the search results table is impossible to style because there are no HTML classes. Sprinkle those around, so libraries can hide information they don't need. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15922] Show authorized value description in staff client search results for lost, withdrawn, and damaged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #13 from Fridolin SOMERS --- (In reply to Katrin Fischer from comment #12) > Fridolin, what's missing here? I'm OK with it. Jonathan has set in discussion, depends on him. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20446] QUOTES processing broken by run time error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20446 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15685 CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Mason James changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20446 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #19 from Francesco Rivetti --- thanks Benjamin! (In reply to Benjamin Rokseth from comment #16) > Created attachment 73093 [details] [review] > Bug 20271: fix remaining tests, add checks and report in atomicupdate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #18 from Benjamin Rokseth --- raised the importance to critical since it does in fact lead to data loss and possibly data corruption -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deletedbiblio* and deleteitems tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Benjamin Rokseth changed: What|Removed |Added Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 --- Comment #6 from Claire Gravely --- Created attachment 73100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73100&action=edit Bug 20427 (follow-up) Compiled CSS This patch contains the compiled CSS. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 Claire Gravely changed: What|Removed |Added Attachment #73033|0 |1 is obsolete|| Attachment #73034|0 |1 is obsolete|| --- Comment #5 from Claire Gravely --- Created attachment 73099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73099&action=edit Bug 20427: Convert OPAC LESS to SCSS This patch converts the OPAC LESS files to SCSS. In the process of converting opac.less (and other .less files) to .scss, I have improved the completeness of the nesting, reordered properties, and in general done cleanup based on rules in .scss-lint.yml. All of these changes should have no impact on the style of the OPAC. This patch modifies the commands used to compile CSS so that OPAC and staff assets can be processed separately: 'yarn build' <-- Builds the staff client assets by default 'yarn build --view opac' <-- Builds OPAC assets To test, apply the patch and compile the CSS by running the command above (or apply the follow-up patch with compiled CSS). Do a thorough review of the OPAC, taking care to cover as many pages as possible and checking responsive behavior at the same time. There should be no visual differences in the OPAC before and after applying the patch. Signed-off-by: Claire Gravely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20427] Convert OPAC LESS to SCSS
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20427 Claire Gravely changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20434] Updating Unimarc existing frameworks with IFLA updates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20434 --- Comment #2 from Julian Maurice --- If you don't want to add a new remote to your git repository you can apply the patch with the following command: wget -q -O- http://git.biblibre.com/biblibre/kohac/commit/457524cef965faf96a9516c17e9e0a8bbdec19aa.patch | git am -3 - -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20451] New: Add ability to specify due date to batch checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20451 Bug ID: 20451 Summary: Add ability to specify due date to batch checkout Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: stuart.johns...@knowsley.gov.uk QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When batch-issuing items, our staff would like to be able to specify a due date, as they are able to when issuing items one at a time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20450] New: Add Collection field to list of items when placing hold on specific copy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20450 Bug ID: 20450 Summary: Add Collection field to list of items when placing hold on specific copy Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: stuart.johns...@knowsley.gov.uk QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When on the screen where we can place holds on specific copies of a title, we'd like to add the 'Collection' field as a column so our staff can identify Hardback or Paperback copies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
