[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

--- Comment #18 from M. Tompsett  ---
Created attachment 73278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73278=edit
Bug 18725: Tests to trigger canary case

Since replicating the conditions necessary for the canary case
proved difficult, tests were written to simulate it.

prove t/db_dependent/Letters.t

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18725] Process_message_queue sends duplicate emails if message_queue is not writable.

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18725

M. Tompsett  changed:

   What|Removed |Added

  Attachment #70876|0   |1
is obsolete||

--- Comment #17 from M. Tompsett  ---
Created attachment 73277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73277=edit
Bug 18725 - Process_message_queue sends duplicate emails if message_queue is
not writable.

Last week, we had a database server whose disk filled, causing database writes
to fail.

This meant that messages in message_queue marked 'pending' were not marked as
'sent' when they were added to the postfix mail queue; messages were sent every
15 minutes (as specified in the cron job) until the disk space issues were
cleared.

I would suggest adding a token write to the start of process_message_queue.pl
as a 'canary in the coal mine'. If the database write fails,
process_message_queue should stop, because it's not safe to proceed sending
emails that may not be marked 'sent'.

Test Plan:
1) Apply this patch
2) Make the message_queue table unwriteable somehow
3) Run process_message_queue.pl
4) Script should die with error

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946

--- Comment #9 from Katrin Fischer  ---
Created attachment 73276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73276=edit
Bug 19946: (Follow-up) Add fixed footer to authorities Z39.50 popup

This patch adds additional Bootstrap framework markup to the search form
so that the "Save" and "Cancel" controls are in a fixed footer at the
bottom of the window. This prevents the controls from disappearing down
off screen.

This patch also adds some whitespace to the "Author
(meeting/conference)" label to enable better word wrapping.

To test, apply the patch and go to Authorities -> New from Z39.50/SRU.
In the popup window, both the search form and search results pages
should look correct.

Patch applies, form resizes, displays and functions as expected.
Signed-off-by: Dilan Johnpullé 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71204|0   |1
is obsolete||
  Attachment #73274|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 73275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73275=edit
Bug 19946: Update popup window templates to use Bootstrap grid: Authority
Z39.50 search

This patch updates the authority Z39.50 search template to use the
Bootstrap grid instead of the YUI grid.

Also fixed: Some capitalization corrections, better 
handling. This patch does not fix Bug 17119.

To test, apply the patch and go to Authorities -> New from Z39.50.
In the popup window, both the search form and search results pages
should look correct.

Signed-off-by: Te Rauhina Jackson 

Signed-off-by: Te Rauhina Jackson 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20452] Add HTML classes to search results availability data

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20452

--- Comment #8 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #7)
> Maybe better to use 'results_'. Would this be ok for you?

Don't care what is prepended, appended... just not so bare as "branch", "item",
etc. and as long as it makes sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946

Dilan Johnpullé  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19946] Update popup window templates to use Bootstrap grid: Authority Z39.50 search

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19946

Dilan Johnpullé  changed:

   What|Removed |Added

  Attachment #71384|0   |1
is obsolete||

--- Comment #7 from Dilan Johnpullé  ---
Created attachment 73274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73274=edit
Bug 19946: (Follow-up) Add fixed footer to authorities Z39.50 popup

This patch adds additional Bootstrap framework markup to the search form
so that the "Save" and "Cancel" controls are in a fixed footer at the
bottom of the window. This prevents the controls from disappearing down
off screen.

This patch also adds some whitespace to the "Author
(meeting/conference)" label to enable better word wrapping.

To test, apply the patch and go to Authorities -> New from Z39.50/SRU.
In the popup window, both the search form and search results pages
should look correct.

Patch applies, form resizes, displays and functions as expected.
Signed-off-by: Dilan Johnpullé 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20393] Remove redundant 'koha.psgi' and 'plackup.sh' files

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20393

Dilan Johnpullé  changed:

   What|Removed |Added

 CC||di...@calyx.net.au
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #3 from Dilan Johnpullé  ---
Attempted to sign off but patch fails to apply. The following is my devbox
terminal output:

vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 20393
Bug 20393 - Remove redundant 'koha.psgi' and 'plackup.sh' files

72824 - Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh' files
fatal: sha1 information is lacking or useless (misc/plack/koha.psgi).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 20393: Remove redundant 'koha.psgi' and 'plackup.sh'
files
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-20393-Remove-redundant-kohapsgi-and-plackupsh--Te2c8M.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20394] Koha hangs when importing a .koc file containing a non-existent barcode

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20394

Katrin Fischer  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE
 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---


*** This bug has been marked as a duplicate of bug 19771 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19771] Pending offline circulation actions page will crash on unknown barcode or on payment action

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19771

Katrin Fischer  changed:

   What|Removed |Added

 CC||ch...@stayawake.co.uk

--- Comment #16 from Katrin Fischer  ---
*** Bug 20394 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19818] Add id into tag html from moremember.tt

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19818

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

--- Comment #9 from Katrin Fischer  ---
Hi Victor, I think it's safe to take this one, if you want to. Please make your
changes in a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72484|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #16 from Katrin Fischer  ---
I really like it, giving it a first sign-off. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

--- Comment #14 from Katrin Fischer  ---
Created attachment 73272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73272=edit
Bug 20322: (follow-up) Circulation page layout and design update

This follow-up makes some suggestions about how to push this further:

- Put content in four columns which reduces to two on smaller screens
- Adjust font size of large links
- Move Offline Circulation links into its own column
- Add image icons to the Firefox extension and Windows application
  download links
- Improve indentation in template

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73113|0   |1
is obsolete||

--- Comment #15 from Katrin Fischer  ---
Created attachment 73273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73273=edit
Bug 20322: (follow up) design refresh for circulation page

Further revisions, compromise.

- 4 columns to three
- offline circulation demoted to below the intranet homepage preference,
and no buttons, due to its relative lack of everyday use.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20322] Circulation page layout and design update

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20322

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72342|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 73271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73271=edit
Bug 20322: design refresh for circulation page

do note, I don't actually mind if these aren't the changes eventually accepted.
I just know it needs doing and starting it will hopefully get some gears
turning.

To test:
Click all the links and check they work.
Do you like the styling? it's different. :)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20355] Add example column to administration currency table

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20355

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Josef, can you explain a bit more?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20387] There is no calendar on first acquisition, subscrition start and end

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20387

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #2 from Katrin Fischer  ---
Hi Hugo, works for me as well. Maybe some custom JavaScript breaking things on
that page? Marking WORKSFORME for now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9290] Restricting patron category for online purchase suggestion

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290

--- Comment #8 from Katrin Fischer  ---
Maybe instead of using a yes/no setting on patron category, you could use a
number of allowed suggestions. There already is already a global setting for
this, that might be extendable in this way: MaxOpenSuggestions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20452] Add HTML classes to search results availability data

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20452

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff
 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
Maybe better to use 'results_'. Would this be ok for you?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19708] Printing code improvements in opac-basket.tt

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19708

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72640|0   |1
is obsolete||

--- Comment #9 from Katrin Fischer  ---
Created attachment 73270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73270=edit
Bug 19708: Improve code for printing the cart in OPAC

This removes a lot of useless code relating to the print function from
opac-basket.tt, opac-basket.pl and opac/basket.js.

It also fixes the CSS so that no extra blank page is printed.

To test:
0) Add an item to your cart
1) Print your basket
Note the appearance of the page. There will be an extra blank page.
2) Apply patch
3) Reload basket
4) Print your basket
The appearce should be identical. The extra blank page is gone.

This only affects the OPAC.

Signed-off-by: Tomás Cohen Arazi 
Signed-off-by: claude 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19488] Add borrowernumber to brief info on patron details pages in staff client

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19488

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72872|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19488] Add borrowernumber to brief info on patron details pages in staff client

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19488

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19488] Add borrowernumber to brief info on patron details pages in staff client

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19488

--- Comment #8 from Katrin Fischer  ---
Created attachment 73269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73269=edit
Bug 19488: (QA follow-up) Fix spelling, remove ()

Fixes spelling to match the details page and removes ().

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19488] Add borrowernumber to brief info on patron details pages in staff client

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19488

--- Comment #7 from Katrin Fischer  ---
Created attachment 73268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73268=edit
Bug 19488: Add borrowernumber to brief info on patron details pages in staff
client

To test:
- View different tabs of a borrower's patron account in staff
- Verify the borrowernumber is shown in the brief info section
  on the left

Signed-off-by: JM Broust 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19488] Add borrowernumber to brief info on patron details pages in staff client

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19488

Katrin Fischer  changed:

   What|Removed |Added

Summary|Adding patron "Borrower |Add borrowernumber to brief
   |Number" to  |info on patron details
   |'patronbriefinfo'  on   |pages in staff client
   |patron details page in  |
   |staff client|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20181] Allow plugins to add CSS and Javascript to OPAC

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20181] Allow plugins to add CSS and Javascript to OPAC

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71567|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20181] Allow plugins to add CSS and Javascript to OPAC

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71568|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20181] Allow plugins to add CSS and Javascript to OPAC

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71569|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 73267
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73267=edit
Bug 20181: Add POD for new plugin

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20181] Allow plugins to add CSS and Javascript to OPAC

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181

--- Comment #11 from Katrin Fischer  ---
Created attachment 73265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73265=edit
Bug 20181: Unit tests

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20181] Allow plugins to add CSS and Javascript to OPAC

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181

--- Comment #12 from Katrin Fischer  ---
Created attachment 73266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73266=edit
Bug 20181: (follow-up) Ensure test runs

If EnablePlugins was 0, this test before this patch fails.
After this patch, it passes.

TEST PLAN
-
1) Apply all but this patch
2) Run the following commands
kshell
prove t/Koha_Template_Plugin_KohaPlugins.t
   -- two tests fail, if you have the conf or syspref set to 0.
3) Apply this patch
4) Repeat step 2.
   -- all tests pass, including the positive and negative case checks.
5) run koha qa test tools

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20181] Allow plugins to add CSS and Javascript to OPAC

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71566|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 73264
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73264=edit
Bug 20181: Allow plugins to add css and javascript to OPAC

A number of Koha plugins have been written that enhance Koha's public catalog.
These plugins often make due to adding css and javascript to the various opac
system preferences. It would be nice if the plugin system had hooks so plugin
developers could add code the the head block and the area where we include
javascript in the opac template.

Test Plan:
1) Apply this patch
2) Download and install the Kitchen Sink plugin ( v2.1.12 or later )
  
https://github.com/bywatersolutions/koha-plugin-kitchen-sink/releases/download/v2.1.12/koha-plugin-kitchen-sink-v2.1.12.kpz
3) Install the plugin
4) Restart all the things if you can ( restart_all if you are using kohadevbox
)
   This will ensure the plugin takes effect right away, it should be
   necessary but it won't hurt anything!
5) Load the opac, notice you get an alert message and the background
   for your opac is now orange ( assuming you've not customized the
   opac in any way )

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19520] Show more information about rotating collections

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520

--- Comment #10 from Josef Moravec  ---
(In reply to M. Tompsett from comment #5)
> Comment on attachment 72819 [details] [review]
> Bug 19520: Update database
> 
> Review of attachment 72819 [details] [review]:
> -
> 
> :::
> installer/data/mysql/atomicupdate/
> Bug19520_Add_more_information_to_rotating_collections.perl
> @@ +5,5 @@
> > +$dbh->do( "ALTER TABLE collections ADD CONSTRAINT `collections_ibfk_2` 
> > FOREIGN KEY (`createdBy`) REFERENCES `borrowers` (`borrowernumber`) ON 
> > DELETE SET NULL ON UPDATE CASCADE");
> > +
> > +$dbh->do( "ALTER TABLE collections ADD COLUMN createdOn datetime 
> > default NULL AFTER createdBy" );
> > +
> > +$dbh->do( "ALTER TABLE collections ADD COLUMN lastTransferredOn 
> > datetime default NULL AFTER createdOn" );
> 
> These 4 do's should be encapsulated by !column_exists checks.
> 
> @@ +10,5 @@
> > +
> > +# or perform some test and warn
> > +# if( !column_exists( 'biblio', 'biblionumber' ) ) {
> > +#warn "There is something wrong";
> > +# }
> 
> And you don't need comments. :)

Done, thanks ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19520] Show more information about rotating collections

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520

--- Comment #7 from Josef Moravec  ---
Created attachment 73261
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73261=edit
Bug 19520: Update databse schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19520] Show more information about rotating collections

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520

--- Comment #8 from Josef Moravec  ---
Created attachment 73262
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73262=edit
Bug 19520: Add tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19520] Show more information about rotating collections

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520

--- Comment #9 from Josef Moravec  ---
Created attachment 73263
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73263=edit
Bug 19520: Add more information about rotating collections

Test plan:
1) Apply the patch
2) Update database
3) prove t/db_dependent/Koha/RotatingCollections.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19520] Show more information about rotating collections

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520

Josef Moravec  changed:

   What|Removed |Added

  Attachment #72819|0   |1
is obsolete||
  Attachment #72820|0   |1
is obsolete||
  Attachment #72821|0   |1
is obsolete||
  Attachment #72822|0   |1
is obsolete||

--- Comment #6 from Josef Moravec  ---
Created attachment 73260
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73260=edit
Bug 19520: Update database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19519] Ability to bind the rotating collection with branch during creating

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519

Josef Moravec  changed:

   What|Removed |Added

  Attachment #72818|0   |1
is obsolete||

--- Comment #6 from Josef Moravec  ---
Created attachment 73259
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73259=edit
Bug 19519: Add ability to bind rotating collectino with library during creation

Test plan:
0) Apply the patch
1) Go to rotating collections tool
2) Try to create and edit collections, note there is new field
"library", try to set and unset it
3) try to transfer a collection, the library saved by creating/editing
collection should be preselected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19519] Ability to bind the rotating collection with branch during creating

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19519

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20181] Allow plugins to add CSS and Javascript to OPAC

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20181

Katrin Fischer  changed:

   What|Removed |Added

Summary|Allow plugins to add css|Allow plugins to add CSS
   |and javascript to OPAC  |and Javascript to OPAC
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70766|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 73258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73258=edit
Bug 17171: Add a syspref to allow currently issued items to be issued to a new
patron without staff confirmation

Some libraries don't want to force the librarians to manually confirm
each checkout when the item is checked out to another. Instead, they
would prefer to be alerted after the fact.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Enable the new syspref AutoReturnCheckedOutItems
4) Check an item out to a patron
5) Check the same item out to another patron
6) Note you are not prompted to confirm the checkout,
   but are instead alerted that is had been checked out to another patron!

Signed-off-by: Christopher Brannon 
Signed-off-by: BWS Sandboxes 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

--- Comment #12 from Katrin Fischer  ---
Had to fix the alphabetic order in sysprefs.sql, but no other complaints ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17171] Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17171

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70878|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 73257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73257=edit
Bug 20081: Set inline headers for uploaded pdfs

To test:
1 - Edit a framework and add the 'upload/pl' plugin to the 856 field
2 - Attach a pdf to one record
3 - Attach a different type of file to another
(To attach, edit a record in the framework edited above and find the
 helper by the 856 field)
4 - Click the links on the record
5 - Verify the pdf opens inline
6 - Verify the other file does not
7 - prove t/db_dependent/Upload.t

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20081] Enable uploaded pdfs to be viewed inline

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20081

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19743] Header and Footer should be updated on each item for checkin / checkout / renewal notices

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19743

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #5 from Katrin Fischer  ---
Patch applied, restart_all, but tests are failing for me:

#   Failed test 'Bug 19743 - Header and Footer should be updated on each
item for checkin / checkout / renewal notices'
#   at t/db_dependent/Letters/TemplateToolkit.t line 611.
# Looks like you planned 7 tests but ran 8.
t/db_dependent/Letters/TemplateToolkit.t .. 16/18 # Looks like you failed 1
test of 8 run.

#   Failed test 'regression tests'
#   at t/db_dependent/Letters/TemplateToolkit.t line 985.
# Looks like you planned 18 tests but ran 17.
# Looks like you failed 1 test of 17 run.
t/db_dependent/Letters/TemplateToolkit.t .. Dubious, test returned 1 (wstat
256, 0x100)
Failed 2/18 subtests 

Test Summary Report
---
t/db_dependent/Letters/TemplateToolkit.t (Wstat: 256 Tests: 17 Failed: 1)
  Failed test:  16
  Non-zero exit status: 1
  Parse errors: Bad plan.  You planned 18 tests but ran 17.
Files=1, Tests=17,  6 wallclock secs ( 0.02 usr  0.01 sys +  4.78 cusr  0.29
csys =  5.10 CPU)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19584] Inventory: Trivial interface improvements

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

--- Comment #11 from Katrin Fischer  ---
Created attachment 73256
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73256=edit
Bug 19584: Check compare barcodes box when uploading barcodes

This patch makes two trivial changes in the inventory interface:

[1] If you have uploaded a barcode file, the compare barcodes checkbox is
automatically checked. In most cases this will be the option the user wants.
The compare will report missed items on the shelf.
[2] If the compare barcodes checkbox is checked, the Skip items on loan-
checkbox is automatically checked. This again is often desirable. If you
compare, you normally are not interested in seeing items reported missing
while they are checked out.

Test plan:
[1] Upload a barcode file on inventory. Is the compare checked?
[2] Toggle compare. Does 'skip items on loan' change accordingly?

Signed-off-by: Marcel de Rooy 

Signed-off-by: Grace Smyth 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19584] Inventory: Trivial interface improvements

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19584] Inventory: Trivial interface improvements

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19584

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #71656|0   |1
is obsolete||
  Attachment #71657|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 73255
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73255=edit
Bug 19584: Replace label Status by Not for loan

Status does not tell me that this is the Not for loan column.
Trivial edit.

Signed-off-by: Marcel de Rooy 

Signed-off-by: Grace Smyth 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins, part 7

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72946|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 73254
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73254=edit
Bug 19878: Move template JavaScript to the footer: UNIMARC editor plugins, part
7

This patch updates the last of the UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as
other templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_210c.tt
- unimarc_field_210c_bis.tt
- unimarc_field_225a.tt
- unimarc_field_225a_bis.tt
- unimarc_field_4XX.tt
- unimarc_field_700-4.tt
- unimarc_leader.tt

Signed-off-by: Anne-Claire Bernaudin 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19878] Move template JavaScript to the footer: UNIMARC editor plugins, part 7

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19878

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19877] Move template JavaScript to the footer: UNIMARC editor plugins, part 6

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19877

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19877] Move template JavaScript to the footer: UNIMARC editor plugins, part 6

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19877

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72864|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 73253
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73253=edit
Bug 19877: Move template JavaScript to the footer: UNIMARC editor plugins, part
6

This patch updates more UNIMARC plugin templates than ever before, so
that JavaScript is included in the footer following the same pattern as
other templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_128a.tt
- unimarc_field_128b.tt
- unimarc_field_128c.tt
- unimarc_field_130.tt
- unimarc_field_135a.tt
- unimarc_field_140.tt
- unimarc_field_141.tt

Signed-off-by: delaye 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19874] Move template JavaScript to the footer: UNIMARC editor plugins, part 5

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72863|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 73252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73252=edit
Bug 19874: Move template JavaScript to the footer: UNIMARC editor plugins, part
5

This patch updates yet more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_125a.tt
- unimarc_field_125b.tt
- unimarc_field_126a.tt
- unimarc_field_126b.tt
- unimarc_field_127.tt

Signed-off-by: delaye 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19874] Move template JavaScript to the footer: UNIMARC editor plugins, part 5

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19874

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19872] Move template JavaScript to the footer: UNIMARC editor plugins, part 4

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72862|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 73251
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73251=edit
Bug 19872: Move template JavaScript to the footer: UNIMARC editor plugins, part
4

This patch updates more and more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_124a.tt
- unimarc_field_124b.tt
- unimarc_field_124c.tt
- unimarc_field_124d.tt
- unimarc_field_124e.tt
- unimarc_field_124f.tt
- unimarc_field_124g.tt

Signed-off-by: delaye 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19872] Move template JavaScript to the footer: UNIMARC editor plugins, part 4

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19872

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19869] Move template JavaScript to the footer: UNIMARC editor plugins, part 3

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19869] Move template JavaScript to the footer: UNIMARC editor plugins, part 3

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19869

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72994|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 73250
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73250=edit
Bug 19869: Move template JavaScript to the footer: UNIMARC editor plugins, part
3

This patch updates even more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_123a.tt
- unimarc_field_123d.tt
- unimarc_field_123e.tt
- unimarc_field_123f.tt
  - This template has been modified, but doesn't appear to be used. The
unimarc_field_1234.pl script uses unimarc_field_123g.tt as its
template.
- unimarc_field_123g.tt
- unimarc_field_123i_j.tt

Signed-off-by: Anne-Claire Bernaudin 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19868] Move template JavaScript to the footer: UNIMARC editor plugins, part 2

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19868] Move template JavaScript to the footer: UNIMARC editor plugins, part 2

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19868

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72636|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 73249
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73249=edit
Bug 19868: Move template JavaScript to the footer: UNIMARC editor plugins, part
2

This patch updates several more UNIMARC plugin templates so that
JavaScript is included in the footer following the same pattern as other
templates which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_116.tt
- unimarc_field_117.tt
- unimarc_field_120.tt
- unimarc_field_121a.tt
- unimarc_field_121b.tt
- unimarc_field_122.tt

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins, part 1

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins, part 1

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72631|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 73248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73248=edit
Bug 19866: Move template JavaScript to the footer: UNIMARC editor plugins, part
1

This patch updates several UNIMARC plugin templates so that JavaScript
is included in the footer following the same pattern as other templates
which have been modified to fix Bug 17858.

To test you do not need a UNIMARC system.

Apply the patch and for each plugin, configure a MARC subfield (e.g.
100$a) to use that plugin.

>From the MARC edit page, trigger the plugin and confirm that changes
made in the popup window are saved to the corresponding field in the
editor.

- unimarc_field_100.tt
- unimarc_field_100_authorities.tt
- unimarc_field_105.tt
- unimarc_field_106.tt
- unimarc_field_110.tt
- unimarc_field_115a.tt
- unimarc_field_115b.tt

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19866] Move template JavaScript to the footer: UNIMARC editor plugins, part 1

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19866

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
The pop-up for unimarc_field_106.pl is not sized right, but it's the same
without the patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70715|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 73247
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73247=edit
Bug 19949: Update popup window templates to use Bootstrap grid: Cataloging
authority search

This patch updates the cataloging authority search templates to use the
Bootstrap grid instead of the YUI grid.

To test you must have a MARC subfield configured with "Thesaurus"
linked to an authority type.

Apply the patch and go to Cataloging -> New record. Click the plugin
link for the field which is linked to authorities. In the popup window,
the search form and search results should look correct.

Signed-off-by: Zoe Bennett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19949] Update popup window templates to use Bootstrap grid: Cataloging authority search

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19949

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19961] Move template JavaScript to the footer: Patron card creator

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19961

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72904|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 73246
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73246=edit
Bug 19961: Move template JavaScript to the footer: Patron card creator

This patch modifies the staff client patron card creator templates so
that JavaScript is included in the footer instead of the header.

Also changed: Removed "type" attribute from script tags.

To test, apply the patch and test the JavaScript-driven features of
each modified template: All button controls, DataTables functionality,
form validation, etc.

- Creating and managing layouts
- Creating and managing card batches
- Creating and managing card templates
- Creating and managing printer profiles
- Creating and managing images

Signed-off-by: Jesse Maseto 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19961] Move template JavaScript to the footer: Patron card creator

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19961

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19983] Switch single-column templates to Bootstrap grid: Authorities

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19983

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72626|0   |1
is obsolete||

--- Comment #8 from Katrin Fischer  ---
Created attachment 73245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73245=edit
Bug 19983: Switch single-column templates to Bootstrap grid: Authorities

This patch updates several single-column Authorities module templates to
use the Bootstrap grid.

- authorities-home - The home page of the Authorities module.
- authorities.tt - The authority add/edit page.
- blinddetail-biblio-search.tt - Not really testable -- It's the small
  popup window which appears during the process of linking an authority
  to a MARC record.
- detail.tt - The authority detail page. Search for an authority record
  and click on the "details" link in the search results.
- merge.tt - From a list of authority search results, select "Merge"
  from the Actions menu of two authority records. Test both the initial
  selection screen and the source/destination merging view.
- searchresultlist.tt - The authority search results page.

Each of these pages should look correct, with a single centered column
with wide margins on either side. At lower browser widths the margins
should disappear.

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20044] Switch single-column templates to Bootstrap grid: Cataloging

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20044

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #8 from Katrin Fischer  ---
Hi Owen, the toolbar on 'edit title' behaves better now, but a long title won't
wrap (as it did before). Could you please take another look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20217] Make header's catalog search menu into a split button

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20217

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
I am not totally persuaded by the usability of this. The way it is now the
distance between 'Search' and the arrow is bigger than the distance between the
arrow and the next menu item which makes it a little confusing. I'd like to get
others people's opinions on this.

Btw: the more direct way to access the item search has been a big hit among our
libraries!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20420] Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20420

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20420] Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20420

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72964|0   |1
is obsolete||
  Attachment #73243|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 73244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73244=edit
Bug 20420: Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources

This patch removes [% KOHA_VERSION %] from the 

[Koha-bugs] [Bug 20420] Remove unnecessary [% KOHA_VERSION %] from OPAC third-party sources

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20420

--- Comment #4 from Katrin Fischer  ---
Created attachment 73243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73243=edit
k

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20052] Add Reports object class

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20052] Add Reports object class

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20052

--- Comment #4 from Katrin Fischer  ---
Comment on attachment 72386
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72386
Bug 20052 - Add Koha Reports object class

Review of attachment 72386:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=20052=72386)
-

Hi Nick,

Is this base work for a new feature?

there are some issues with POD here:
1)
 FAIL   Koha/Report.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
POD coverage was greater before, try perl
-MPod::Coverage=PackageName -e666
   OK spelling
   OK valid

 FAIL   Koha/Reports.pm
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   FAIL   pod coverage
POD is missing for 'object_class'
   OK spelling
   OK valid

::: t/db_dependent/Koha/Reports.t
@@ +1,3 @@
> +#!/usr/bin/perl
> +
> +# Copyright 2015 Koha Development team

2) Should we lose this line here on a new file?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19957] Allow continued editing after saving a report

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70776|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 73242
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73242=edit
Bug 19957: Allow continued editing of report after saving

To test:
 1 - Edit or create a report
 2 - Save it
 3 - Note the report is saved but you can't keep editing
 4 - Clicking 'Edit' returns you to editing
 5 - Apply patch
 6 - Save report
 7 - Note success message remains, but report is still open for editing
 8 - Note when you click the saved/updated message dissappears
 9 - Try again after inserting erros into report (No Select, bad
authorised value, etc.)
10 - Note errors stil display as expected
11 - Verify message works on update of existing report and save of new
  new report

Signed-off-by: Owen Leonard 

Signed-off-by: Charles Farmer 

Signed-off-by: Katrin Fischer 



Current patch-complexity: Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19957] Allow continued editing after saving a report

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|Trivial patch   |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19957] Allow continued editing after saving a report

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19957

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer  ---
At first I was a little irritated, but as the toolbar gives you all the options
here, I think the returning to the edit form works for this page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20345] Put saved report keyword search form on reports home

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72628|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 73241
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73241=edit
Bug 20345: Put saved report keyword search form on reports home

This patch makes cosmetic changes to the reports home page in the staff
client following the pattern set on the Administration home page with
the system preferences search box. A reports keyword search form is
added, and reports actions have font-awesome icons.

To test, apply the patch and view the reports home page. Confirm that
all affected links work correctly and that the search form works
correctly.

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20345] Put saved report keyword search form on reports home

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20345

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20045] Switch single-column templates to Bootstrap grid: Various

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72621|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 73240
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73240=edit
Bug 20045: Switch single-column templates to Bootstrap grid: Various

This patch updates various unrelated templates to use the Bootstrap
grid.

- about.tt - The about page
- auth.tt - The login page

  These pages should look correct.

- reports/reports-home.tt - The reports home page
- admin/admin-home.tt - The administration home page

  These pages should look correct, with a single centered column
  with wide margins on either side. At lower browser widths the margins
  should disappear.

- serials/subscription-add.tt - Serials -> Add subscription. The entry
  form should look correct during each step of the add/edit process.

- suggestion/suggestion.tt - Acquisitions -> Suggestions -> New
  suggestion. The page with the new suggestion form should look correct.

Signed-off-by: Roch D'Amour 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20045] Switch single-column templates to Bootstrap grid: Various

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20045

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20467] Add ability to batch add items to a course

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20467] Add ability to batch add items to a course

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73220|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 73239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73239=edit
Bug 20467: Add ability to batch add items to a course

Some librarians have requested the ability to batch add items to a
course using the same settings for all items.

Test Plan:
1) Apply this patch
2) Create a new course
3) Click the new 'Batch add reserves' button
4) Enter some valid and invalid barcodes in the text box, add some settings
5) Submit the batch, note the results list added items and invalid barcodes
6) Note the valid items were added to the course

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Maksim Sen 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18791] Add the ability for librarians to easily copy, download or print DataTables based tables in Koha

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18791

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #9 from Katrin Fischer  ---
Hi Kyle,

I'd really like to get this feature in. 2 things:

- Can you please double-check the about page for the Javascript libraries
updated and introduced here? I see only one entry changed, but 4 were touched.

- One of the libraries contains another string that is not translatable this
way. It is the "copy" modal text:

c.i18n("buttons.copySuccess",{1:"Copied one row to clipboard",_:"Copied %d rows
to clipboard"},a.rows),2E3);

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20298] Notices template uses same html id for each language

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20298

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72993|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 73238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73238=edit
Bug 20298: Fix SMS characters counter when TranslateNotices is set

If you have multiple languages installed, the notices and slips page
uses the same HTML id multiple times, once for each language. This
prevents eg. the SMS character count javascript from working, because
each of the textareas has the same id.

Test plan:
Test the sms characters counter, with and without TranslateNotices
Make sure other features on this page still work correctly

QA: Make sure this change of id did not break something else.

Signed-off-by: Brendan Gallagher 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20298] Notices template uses same html id for each language

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20298

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73148|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 73237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73237=edit
Bug 20111: i18nize units in Patron card creator

Test plan:
1. install and switch to the fr_FR locale
 or another one and adapt the test plan accordingly
2. go to /cgi-bin/koha/patroncards/edit-template.pl?op=new
3. then you should see the "Unités" dropdown with english units
4. apply this patch
5. install the language
6. refresh the page
7. then you should see the "Unités" dropdown with french units

Signed-off-by: Mark Tompsett 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20111] Patron card creator - some strings are not translatable

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20111

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #73147|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 73236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73236=edit
Bug 20111: Coding style: Fix indentation before doing actual change

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70938|0   |1
is obsolete||

--- Comment #74 from Katrin Fischer  ---
Created attachment 73231
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73231=edit
Bug 19522: Label creator: translate empty list message

The name of the element wasn't translated in the message.

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. ensure that the list is empty
4. then you should see "pas de Batches actuellement"
5. then you should see "créer un nouveau batch."
6. apply this patch
7. install the language
8. refresh the page
9. then you should see "pas de Lots actuellement"
10. then you should see "créer un nouveau lot ."

Signed-off-by: Simon Pouchol 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72415|0   |1
is obsolete||

--- Comment #78 from Katrin Fischer  ---
Created attachment 73235
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73235=edit
Bug 19522: i18n Label creator: wrap text with 

In a SWITCH CASE.
To avoid pollution and duplication in the .po files.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19522] Label creator - some strings are not translatable

2018-03-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19522

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #70940|0   |1
is obsolete||

--- Comment #76 from Katrin Fischer  ---
Created attachment 73233
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73233=edit
Bug 19522: Label creator: edit batch: make "Export label" translatable

Test plan:
1. install the fr_FR locale
2. go to /cgi-bin/koha/labels/label-manage.pl?label_element=batch
3. create a batch if there is none
4. edit that batch
5. Switch the language to French if you haven't done it yet
6. click on "Exporter le lot entier"
7. then you should see "Export labels"
8. apply this patch
9. install the language
10. replay steps 2 to 6
11. then you should see "Exporter des étiquettes"

Signed-off-by: Simon Pouchol 

Signed-off-by: Kyle M Hall 

Signed-off-by: Marcel de Rooy 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   >