[Koha-bugs] [Bug 20836] debian/control.in cleanup

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20836

--- Comment #1 from Mirko Tietgen  ---
These packages are not supposed to be installed together with koha-common. On
the contrary they are supposed to be installed if you do not want to install
koha-common, but the dependencies. I think the use case were git installations,
but since koha-gitify and kohadevbox are around I doubt they are used for that
a lot.
(does kohadevbox use them?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487

--- Comment #14 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #12)
> Should not we provide an update DB entry?

Yes, we could. Will add a few lines.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20487] AddReturn should clear items.onloan for unissued items

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20487

--- Comment #13 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #11)
> What about local use?

Can't imagine a working use in this scenario (without making much more
changes). Does not seem something we should be dealing with here.
If you have something in mind, please be more specific.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19633] Use alphanumeric error codes in upload

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633

--- Comment #6 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #5)
> Ok but I would have written
> 
>   use constant UPLERR_ALREADY_EXISTS => 'UPLERR_ALREADY_EXISTS';
> instead of
>   use constant ERRCODE_1=> 'UPLERR_ALREADY_EXISTS';
> 
> or even get rid of the constant if only used once.
> 
> The goal is to make the code more readable, but when you see ERRCODE_X in
> the perl script you still do not know what it means :)

We still can do that later. This was kind of a safety step in between. Still
knowing the old error number..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

--- Comment #5 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #4)
> Why did you put it at the bottom of the page?
> 
> IMO it seems better to place it on top of the table (inside the tab).

IMO it apparently did not ;) Belongs somehow to the actions on selected rows
too.
No blocker for QA, i guess?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20836] debian/control.in cleanup

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20836

Mirko Tietgen  changed:

   What|Removed |Added

Summary|debian/contron.in cleanup   |debian/control.in cleanup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20670] Add markup and standard classes for sidebars and main content areas

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20670

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20543] Use multi-core compression to speed up Koha backups

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20543

--- Comment #6 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #5)
> One more deps, one more deps! :)
> 
> Maybe we should use it only if installed (and not require it?)

It's not installed by default. I think adding the dependency is a good idea, as
we want faster out of the box, not requiring knowing the magical incantation to
get it to work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385

M. Tompsett  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #164 from M. Tompsett  ---
This is too huge, my mental energy keeps being too low, and I need this in
sooner rather than later. Follow the test plan in comment #112.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15273] Fines Payment receipt should include all account lines selected for this pay

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15273

--- Comment #11 from Claudio  ---
Now that the account_offsets table is ready, is there a chance to go on with
this ticket?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14934] Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab.

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934

Claudio  changed:

   What|Removed |Added

 Status|NEW |BLOCKED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20843] New: For fixed fields requiring computer generated data, default value or plugin?

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20843

Bug ID: 20843
   Summary: For fixed fields requiring computer generated data,
default value or plugin?
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: PC
OS: Windows
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: emj...@pa.net
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

As of 2018, the Koha Frameworks that were on our system (set up in late 2011)
were designed for different types of records but the MARC fixed fields 000,
007, and 008 did not accurately code for those materials. I am making unique
Frameworks that I hope will accurately code for specific materials. I have put
a default value in the 000 (despite the need for a computer generated record
length in the 00-04 character position) and the 007, and as of now have left
the 008 blank.

I can not use a default value in the 008 because position 00-05 requires the
date entered on file. I would, however, like to change the data currently in
the 008 plugin. I simply do not find it helpful to have the default of position
06 be "b" (no dates given, B.C. date involved.) It is absolutely ridiculous for
video recordings, yet not all my co-workers understand to edit this field. Is
there a way to edit the plugin? Support told me that there can be only one
plugin per field, but I was not sure based upon Bug 3013, Bug 14815, and Bug
19473.

Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20842] New: Change the default Framework from Koha's default to another saved framework

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20842

Bug ID: 20842
   Summary: Change the default Framework from Koha's default to
another saved framework
 Change sponsored?: ---
   Product: Koha
   Version: 17.05
  Hardware: PC
OS: Windows
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: emj...@pa.net
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Rather than have our system set to use the Koha Default framework as our
default, we would like to use a framework we have created as our default
framework for both created and imported records. I'm unaware of where/if this
can be altered; Support mentioned that it was a nearly-resolved bug, but I
could find no report on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8685] Inventory tool fails in timeout with large CB files

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8685

emj...@pa.net changed:

   What|Removed |Added

 CC||emj...@pa.net

--- Comment #15 from emj...@pa.net ---
This is a huge issue for our libraries. Currently the only way to limit
inventory is by library and shelving location. At some of our libraries, we can
not limit by call number because some collections do not have call numbers. By
not providing any other ways to limit an inventory, we have no choice but to
process collections of over 1000 items. I have had to delay our inventories
because of this, and the scanning that I did do was a wasted few days because
the data could not be processed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12477] We need better ways to manage MARC Frameworks

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12477

emj...@pa.net changed:

   What|Removed |Added

 CC||emj...@pa.net

--- Comment #17 from emj...@pa.net ---
Re: David Cook: "I'm thinking that there should be some mechanism for updating
an existing framework."

Koha requires that the "Default" Framework must remain, unedited and available,
in Koha. This is the area to do all MARC21 updates, hopefully with each update
of Koha. 

As David Cook noted, a library may set up a unique Framework that does not have
all of the MARC fields and subfields when such a library is specifically
attempting to keep things simplified and efficient. 

I am the only cataloger among seven people who add bibliographic records to our
system. I ran reports to see which MARC fields were used, checked the ones that
were used only a handful of times (to see if they were used correctly), and
changed all of our records back to the Koha Default Framework. I deleted all
the other frameworks (as none of their fixed fields were coded correctly) and
painstakingly created a "new" default framework, deleting fields and subfields
that are obsolete or not relevant to the work that we do. 

The most important thing to me, regarding MARC updates, is that I do not have
to start from scratch using the Koha Default Framework. As long as the
information is added to the Koha Default Framework, I can manually look it up
and manually add it (correctly) to any of my unique Frameworks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20841] New: Barcode and description are needed in payment details

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20841

Bug ID: 20841
   Summary: Barcode and description are needed in payment details
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cost...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 75693
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75693&action=edit
Barcode and description are needed in payment details

Barcode and description are needed in payment details. See file attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Claudio  changed:

   What|Removed |Added

   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20840] New: Internal Server Error when clicking on "Details" button

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840

Bug ID: 20840
   Summary: Internal Server Error when clicking on "Details"
button
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Fines and fees
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: cost...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 75692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75692&action=edit
Internal server error

Internal Server Error when clicking on "Details" button. See file attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736

David Roberts  changed:

   What|Removed |Added

 CC||david.roberts@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #16 from Jonathan Druart  
---
Can you refresh this script a bit please?

At first glance, at least:
1. Indentation
2. More readable options
3. More readable parameters
4. I do not think update_category should be a Koha::Patrons method, to me it
belongs to Koha::Patron
5. Why?
+my $remove_guarantor = ( $to_cat->category_type ne 'C' ||
$to_cat->category_type ne 'P' ) ? 1 : 0;
6. Date handling is not the way to do

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20838] Search by group of libraries is broken

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Ata ur Rehman  changed:

   What|Removed |Added

 CC||ata.reh...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20543] Use multi-core compression to speed up Koha backups

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20543

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
One more deps, one more deps! :)

Maybe we should use it only if installed (and not require it?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20468] Multiselect on staff article requests form

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||oleon...@myacpl.org

--- Comment #4 from Jonathan Druart  
---
Why did you put it at the bottom of the page?

IMO it seems better to place it on top of the table (inside the tab).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19633] Use alphanumeric error codes in upload

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19633

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #5 from Jonathan Druart  
---
Ok but I would have written

  use constant UPLERR_ALREADY_EXISTS => 'UPLERR_ALREADY_EXISTS';
instead of
  use constant ERRCODE_1=> 'UPLERR_ALREADY_EXISTS';

or even get rid of the constant if only used once.

The goal is to make the code more readable, but when you see ERRCODE_X in the
perl script you still do not know what it means :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9921] Make it possible to force 001 = biblionumber

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9921

emj...@pa.net changed:

   What|Removed |Added

 CC||emj...@pa.net

--- Comment #57 from emj...@pa.net ---
Like the 2013 thread starter and initial commentator, I believe MARC designates
the 001 field (Control Number) for use to uniquely identify a bibliographic
record. IME the ILS does this automatically with both created and imported
records. (Imported records with data in the 001 field would have that data
automatically transferred into a newly created 035 field.) These unique,
sequential Control Numbers were automatically generated system-wide despite
multiple locations and input from multiple users.
Koha appears to be able to create a unique, auto-generated, sequential
identifier for each bibliographic record despite input from multiple users
through the Koha field 'biblio.biblionumber;' however, it is mapped to the MARC
field 999 subfield 'c.'
It would be preferable to have this unique identifier in the MARC 001 field.
Does the sequence number engine need to be fixed when the biblio.biblionumber
auto-generates a unique sequential identifier already? Is it a matter of
setting up the two fields alike (created upon the record being saved, and being
visible after saving and during editing) so that a unique identifier could
safely be generated in that field? With all the sequential auto-generated
fields used currently by Koha (999$c, 999$d, 952$p), surely there is a way to
auto populate the 001 field. 
If Koha requires that the 999$c field contain a unique identifier, I would find
it preferable if the same identifier be used in the 001 rather than multiple
unique identifiers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75474|0   |1
is obsolete||
  Attachment #75617|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 75690
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75690&action=edit
Bug 20793: Don't show a holds link in staff for users without permission

On the results list in staff the 'Holds (x)' link always shows
independent of the permissions of the staff user.

This patch tightens the permission checks on the result page
to explicitly check for the place_holds permission.

To test:
- Create a staff user with place_holds permission
- Check the result list, you should see 2 links to the
  holds page:
  - 'Place holds' on top of the results list
  - 'Holds (x)' at the bottom of each entry in the results
 list
  - Verify both links work
- Create a staff user without place_holds_permission
  - Without the patch you'll see the second link,
but it will lead to a permission error
  - With the patch you'll still see the 'Holds (x)', but
it will no longer be a link.
- Go to the detail page of a record with an existing hold.
  - Repeat test with both staff users.
  - One time the Hold information in the bibliographic information
should show as a link, the other time as a simple text.

Displaying the information about existing holds still make sense
as this is the current beheviour.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793

--- Comment #7 from Jonathan Druart  
---
Created attachment 75691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75691&action=edit
Bug 20793: (follow-up) Add style to the non-link hold count on detail page

This small follow-up changes the style on the bibliographic detail page
of the hold count so that it looks similar whether it's a link to holds
or not.

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20793] Don't show holds link in result list when staff user doesn't have place_holds permission

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20793

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11911] Purchase suggestions can be accessed by all staff members / no specific permission

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11911

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #15 from Jonathan Druart  
---
I am not sure it's a big deal but since bug 18403 the "borrowers" permissions
has  subpermissions and so the SQL query should be adjusted a bit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from Jonathan Druart  
---
>From koha-tmpl/intranet-tmpl/prog/en/includes/budgets-active-currency.inc:

  8 [% IF CAN_user_parameters_parameters_remaining_permissions %]
  9 Please specify an
active currency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15869] Change framework on overlay

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15869

emj...@pa.net changed:

   What|Removed |Added

 CC||emj...@pa.net

--- Comment #6 from emj...@pa.net ---
This is an issue with overlaying any record, not just staged records. 

I should be able to select that all Imported records are imported in a specific
Framework, whether imported singularly or as a batch, and whether overlaid onto
a brief order record or as the first bibliographic content. 

Indeed, libraries should be able to select any of their Frameworks as THEIR
default Framework, instead of having to use the Koha Default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8169] No LCCN field on Z39.50 search

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8169

emj...@pa.net changed:

   What|Removed |Added

 CC||emj...@pa.net

--- Comment #6 from emj...@pa.net ---
I would find this a very useful search field, as my attempts in control number
and keyword searches have not resulted in successful searches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
Turn off intranetreadinghistory
=> boom!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #10 from Jonathan Druart  
---
If "Biblio ID" is not filled, the column contains "0" with a link to
/catalogue/detail.pl?biblionumber=0

Also, Andrew, I do not know your workflow when you submit a new patch, but you
removed the signed-off-by line and the commit message.
You should prefer a follow-up patch (which will be squashed if needed by QAer
or RM). It also eases the review.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10470] way to add multiple subfields to frameworks

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10470

emj...@pa.net changed:

   What|Removed |Added

 CC||emj...@pa.net

--- Comment #1 from emj...@pa.net ---
I agree that it is unnecessarily time consuming to have to save each subfield
individually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20651] Improve display of "Toggle full supplier metadata"

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20651

--- Comment #8 from Jonathan Druart  
---
If Owen agrees, it's ok for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
1.
Do not use loop variable $_

+foreach(@req_list) {
+foreach my $field(@format_dates) {
+if (defined $_->{$field}) {
+$_->{$field . "_formatted"} = format_sqldatetime(

2. Why do not you use the datepicker plugin as we use it elsewhere? :)

3. For dates in datatables we usually do not use it that way, search for
"title-string" in the *.tt files

I am not sure you need the 2 *_formatted variables.

4. Is it really useful to provide only a specific dates and not a date range?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20839] New: Edit as new (duplicate) doesn't work with advanced editor

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20839

Bug ID: 20839
   Summary: Edit as new (duplicate) doesn't work with advanced
editor
 Change sponsored?: ---
   Product: Koha
   Version: 17.11
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Cataloging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: and...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Clicking "Edit as new (duplicate)" on a record in a browser that defaults to
the advanced cataloging editor pushes one to the original record and just makes
edits there rather than creating a new record.

To test:
1. Confirm your browser is defaulting to the advanced editor when editing
records
2. Pull up any bib record
3. Click Edit - Edit as new (duplicate)
4. Make edits to the record
5. Save 
6. Confirm that edits have been made to the new record and no new record has
been created

This may be related to bug 16232, but shows different behavior.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

--- Comment #5 from Jonathan Druart  
---
Created attachment 75689
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75689&action=edit
Bug 19945: (follow-up) optimization and test correction

The double call to CanItemBeReserved was pointless in
the C4/Reserves.pm HoldItem, as CanBookBeReserved calls
CanItemBeReserved and even returns that code.

Additionally, the tests failed, because there were 5
tests not 4.

TEST PLAN
--
prove t/db_dependent/ILSDI_Services.t
run koha qa test tools

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 19945] ILSDI - Return the reason a reserve is impossible

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19945

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #73351|0   |1
is obsolete||
  Attachment #73352|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 75688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75688&action=edit
Bug 19945: ILSDI - Return the reason a reserve is impossible

Currently, the ILDSI services HoldTitle and HoldItem always return a
"NotHoldable" code is the reserve is impossible. We need to know why

Test plan:

 - Apply this patch
 - Place a hold on a non reservable title using ILS-DI web service
  
(http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=1&bib_id=1&request_location=)
 - you should get the reason instead of NotHoldable,
 - Place a hold on a non reservable item using ILS-DI web service
  
(http://koha-opac.example.org/cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=1&bib_id=1&item_id=1)
 - you should get the reason instead of NotHoldable,

Signed-off-by: Mark Tompsett 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20838] Search by group of libraries is broken

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

--- Comment #2 from Jonathan Druart  
---
Created attachment 75687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75687&action=edit
Bug 20838: Make Koha::Library::Group->all_libraries return a list of
Koha::Libraries

Instead of a list of Koha::Library::Group
Ideally it should be a Koh::Libraries iterator

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20838] Search by group of libraries is broken

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20838] Search by group of libraries is broken

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

--- Comment #1 from Jonathan Druart  
---
Created attachment 75686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75686&action=edit
Bug 20838: (bug 16735 follow-up) Fix search by group of libraries

In the last patches of bug 16735, we completely broke the feature!

The limit is using library_groups.id instead of branches.branchcode.

Test plan:
Create a group of library with the search feature
Search (OPAC and staff interfaces) using this limit

=> Without this patch you will see that the generated search query does
not contain branchcodes
=> With this patch applied you will see the branchcodes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20838] Search by group of libraries is broken

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Jonathan Druart  changed:

   What|Removed |Added

Summary|Search by group of  |Search by group of
   |libraries   |libraries is broken

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20838] New: Search by group of libraries

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838

Bug ID: 20838
   Summary: Search by group of libraries
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: major
  Priority: P5 - low
 Component: Searching
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 16735

In the last patches of bug 16735, we completely broke the feature!

The limit is using library_groups.id instead of branches.branchcode.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735
[Bug 16735] Replace existing library search groups functionality with the new
hierarchical groups system
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16735] Replace existing library search groups functionality with the new hierarchical groups system

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16735

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20838


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20838
[Bug 20838] Search by group of libraries
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

Nick Clemens  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org,
   ||jsa...@plumcreeklibrary.net
   ||, katrin.fisc...@bsz-bw.de,
   ||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

Nick Clemens  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

--- Comment #2 from Nick Clemens  ---
Created attachment 75685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75685&action=edit
Bug 20837: Use ReservesControlBranch to determine holdability of items

To test:
 1 - Set a default holds plicy for an item type as 'from home library'
 2 - Set CircControl to 'logged in library'
 3 - Log in as staff from a library without the rule set
 4 - Note you can set holds for patrons of any library on items of type
above
 5 - Toggle ReservesControlBranch and note that nothing changes
 6 - Toggle CircControl and note some combinations don't allow holds
 7 - Apply patch
 8 - Toggle ReservesControlBranch and note that holdability is affected
 9 - Toggle CircControl and note holdability does not change
10 - Read the note on admin/smartrules.pl and confirm it makes sense

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

--- Comment #1 from Nick Clemens  ---
Created attachment 75684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75684&action=edit
Bug 20837: Unit tests

To test:
prove -v t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9792] Layout problem with patron entry form when using Internet Explorer 11

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9792

Owen Leonard  changed:

   What|Removed |Added

Summary|Layout problem with patron  |Layout problem with patron
   |entry form when using   |entry form when using
   |Internet Explorer 9 |Internet Explorer 11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20837] New: CanItemBeReserved should follow ReservesControlBranch and not CircControl

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837

Bug ID: 20837
   Summary: CanItemBeReserved should follow ReservesControlBranch
and not CircControl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

According to the pref descriptions CircControl shouldn't affect reserves, we
should check the other pref.

Also, the important note 'Default holds policy by item type'
admin/smart-rules.pl is misleading:
"Important: The policies are based on the patron's home library, not the
library where the hold is being placed."

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258
Bug 17258 depends on bug 16583, which changed state.

Bug 16583 Summary: Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #10 from Jonathan Druart  
---
We can consider it has been fixed by bug 20229

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 16583] Strangeness in the staff client on ubuntu 16.04 and MySQL 5.7

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16583

--- Comment #9 from Owen Leonard  ---
Is this bug still valid?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17273] Batch MARC Modification - improve options to define which records to modify

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17273

--- Comment #17 from Jonathan Druart  
---
This sounds like a duplicate of bug 12759.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #24 from Jonathan Druart  
---
Comment 10 and comment 13 are still valid...


Moreover, prefer to pass an iterator to the template:
-my @lists = Koha::Virtualshelves->search({});
-$template->param( lists => \@lists );
+$template->param( virtual_shelves => scalar Koha::Virtualshelves->search );


You will need to adapt the template accordingly ([% IF virtual_shelves.count
%], etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9399] Accessibility - Search box options aren't buttons

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9399

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart.

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6973] Allow reply-to on cart emails to go to the sender of the cart.

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6973

Owen Leonard  changed:

   What|Removed |Added

   Assignee|ro...@catalyst.net.nz   |koha-b...@lists.koha-commun
   ||ity.org
   Priority|PATCH-Sent (DO NOT USE) |P5 - low
 Status|Failed QA   |ASSIGNED

--- Comment #21 from Owen Leonard  ---
This enhancement has been dead so long I'm going to reset it to NEW.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8962] Restore Any index behavior and add Anywhere index

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #68 from Jonathan Druart  
---
Is this only for GRS-1?

Bug 14302 - Remove GRS1 indexing related code

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

--- Comment #27 from Owen Leonard  ---
I rebased(In reply to Viktor Sarge from comment #21)
> We´re not currently working on this.

I have attached rebased patches in case someone wants to pick this up. It
certainly looks like it's close.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 18889] Add barcode to 'Pay Fines' tab in patrons payment page

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Jonathan Druart  changed:

   What|Removed |Added

Version|17.05   |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18889] Add barcode to 'Pay Fines' tab in patrons payment page

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #16 from Jonathan Druart  
---
1. Please adjust commit title and body
2. Table footer is broken -
https://screenshots.firefox.com/26EsdTn15j1x9k4R/pro.kohadev.org
3. Why a new column? Maybe it would make more sense to have it in the first
column, close to the biblio's title?

Failing QA for 1 and 2, Discussion for 3.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

--- Comment #26 from Owen Leonard  ---
Created attachment 75683
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75683&action=edit
Bug 14670: fix ControlStructures::ProhibitMutatingListFunctions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

--- Comment #24 from Owen Leonard  ---
Created attachment 75681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75681&action=edit
Bug 14670: add test for C4::Record::marc2cites

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

--- Comment #25 from Owen Leonard  ---
Created attachment 75682
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75682&action=edit
Bug 14670: Fix earlier declaration in same scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

--- Comment #23 from Owen Leonard  ---
Created attachment 75680
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75680&action=edit
Bug 14670: add related css changes to opac.less

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

Owen Leonard  changed:

   What|Removed |Added

  Attachment #43919|0   |1
is obsolete||
  Attachment #43920|0   |1
is obsolete||
  Attachment #43921|0   |1
is obsolete||
  Attachment #43922|0   |1
is obsolete||
  Attachment #43923|0   |1
is obsolete||
  Attachment #43924|0   |1
is obsolete||

--- Comment #22 from Owen Leonard  ---
Created attachment 75679
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75679&action=edit
Bug 14670: Add Cite-option to detail page in OPAC

Adds a "cite" option in the tools menu in OPAC detail page for easy citations.

Test plan:
1. Apply this patch
2. Got to OPAC detail page
3. In the tools menu to the right, click the new "Cite" link
4. A modal should appear with four different citation styles (APA, Chicago,
   Harvard, MLA)

Sponsored-by: Regionbibliotek Halland / County library of Halland

Signed-off-by: Nicole Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20197] Missing rfc3339 in systempreference choices for dateformat

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20197

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |In Discussion

--- Comment #3 from Jonathan Druart  
---
I still do not see the point of adding it.

http://irc.koha-community.org/koha/2018-02-14#i_2011298

17:30   mtompsetBTW, easy sign off: bug 20197
17:30   huginn` Bug http://bugs.koha-community.org[…]_bug.cgi?id=20197
trivial, P5 - low, ---, mtompset, Needs Signoff , Missing rfc3339 in
systempreference choices for dateformat
17:31   Joubu   It's not missing
17:32   we do not want it
17:32   do you want it?
17:34   mtompsetWhy don't we want?
17:35   DonnaB joined #koha
17:35   mtompsetNo, I don't believe I would use it, but if the API uses
it, why not let the user set things to see what the API sees?
17:37   andrewfh joined #koha
17:38   Joubu   because it's only used by the api to format date for JSON
17:39   tcohen  mtompset: if you are curious about it, better look at the RFC
:-P
17:40   Joubu   mtompset: you should also keep in mind that we do not want to
add stuffs that nobody asked for :)
17:41   it will adds code to maintain for nothing
17:42   paxed   mtompset: also see date-format.inc
17:43   although it doesn't explicitly need change, ...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561

--- Comment #27 from Jonathan Druart  
---
Created attachment 75677
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75677&action=edit
Bug 17561: (QA follow-up) Update existing unit tests

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561

--- Comment #28 from Jonathan Druart  
---
Created attachment 75678
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75678&action=edit
Bug 17561: (follow-up) Pass itemnumber on returns and correct itemnumber param
in circulation

To test:
1 - Place two holds on a bib for a single patron
2 - Check in both items, confirm the screen message and slip are correct
3 - Checkout both items to another patron, confirm the screen message
and slip are correct

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75424|0   |1
is obsolete||
  Attachment #75425|0   |1
is obsolete||
  Attachment #75426|0   |1
is obsolete||
  Attachment #75659|0   |1
is obsolete||

--- Comment #25 from Jonathan Druart  
---
Created attachment 75675
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75675&action=edit
Bug 17561: ReserveSlip needs itemnumber for item level holds on same biblio

This patch fixes a regression after bug 14695.
This patch adds itemnumber and barcode as optional params in ReserveSlip used
by hold-transfer-slip.pl to generate HOLD_SLIP. This is for ReserveSlip to be
able to generate correct slips when items in multi-item holds are checked in.

Test plan:

1) activate a circulation rule with multi-item holds
2) Place two holds on same biblio for patron
3) for debugging, either use browser console to observe POST request and
responses
   or use info from reserves, e.g. reserve_id in the HOLD_SLIP
4) checkin two items from same biblio on pickup branch
5) note that both holds are effectuated, but reserve_id is the same on both
slips
6) also note that there is no itemnumber or barcode in the requests from
returns.pl
7) Apply this patch
8) repeat 2-4
9) note that reserve_id is now different on the two slips

and/or:
Run tests:
  t/db_dependent/Reserves/ReserveSlip.t

Signed-off-by: Brendan Gallagher 
Signed-off-by: Maksim Sen 

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561

--- Comment #26 from Jonathan Druart  
---
Created attachment 75676
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75676&action=edit
Bug 17561: (QA follow-up) Simplify new ReserveSlip code

Signed-off-by: Kyle M Hall 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15520] Add more granular permission for only editing own library's circ rules

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15520

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #17 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #15)
> Yes, that would work, but it smells a bit :)
> 
> For instance a superlibrarian user will have
> CAN_manage_circ_rules_restricted set in templates.
> 
> Why not simply do the reverse, like view_borrower_infos_from_any_libraries,
> and name it manage_circ_rules_from_any_libraries (will need to be set on
> update for patrons with manage_circ_rules).
> It would remove the new parameter and avoid a permission to restrict, which
> could add side-effects (maybe not now, but certainly later).

I agree with Jonathan's proposal. We can remove this later once the permissions
system is based on the library hierarchies :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849

--- Comment #19 from Jonathan Druart  
---
Created attachment 75674
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75674&action=edit
Bug 3849: (follow-up) Add database update to change descriptions

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75473|0   |1
is obsolete||
  Attachment #75618|0   |1
is obsolete||

--- Comment #18 from Jonathan Druart  
---
Created attachment 75673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75673&action=edit
Bug 3849: Improve descriptions of granular acquisition permissions

The permissions for acquisitions were not very clearly described.
This patch changes the descriptions in the include file (GUI) and
in the default SQL.

To test:
- Go to any patron account in staff
- Go to more > permissions
- Verify that the meaning of each acquisition permission is clear
  from the description

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3849] Descriptions of acquisition permissions are unclear

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3849

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20312] Add a link towards the last consulted patron

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20312

--- Comment #5 from Owen Leonard  ---
Created attachment 75672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75672&action=edit
Screenshot of interface idea

Something like this might work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #71 from Josef Moravec  ---
Sent by accident before finished ;)

ad 2)
koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt
230Tab:[% subfield.tab %] | $[%
subfield.tagsubfield %]

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
791*

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643

--- Comment #70 from Josef Moravec  ---
Just started QA and found some issues:

1) qa test tools report:
FAILadmin/marctagstructure.pl
   FAIL   forbidden patterns
forbidden pattern: tab char (line 125)

2) Sometimes you use attribute "style" for css - should be done using class

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
588*

koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt
348[% ELSIF ( ite.important ) %] http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5670] Housebound Readers Module

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20828


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828
[Bug 20828] Step 4 of moremember is used for Housebound and additional
attributes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20828] Step 4 of moremember is used for Housebound and additional attributes

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||5670

--- Comment #1 from Jonathan Druart  
---
Not a bug?

  commit 20c2ea7d3a6e24dd13cf3e6dd47108984852607d
  Bug 5670: [Followup] Add 'step 4' edit button.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670
[Bug 5670] Housebound Readers Module
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20829] 'Link to host item' gives internal server error

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20829

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

--- Comment #5 from Jonathan Druart  
---
Maybe the patch does not fix the original problem, but I do not recreate it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20829] 'Link to host item' gives internal server error

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20829

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20829] 'Link to host item' gives internal server error

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20829

--- Comment #4 from Jonathan Druart  
---
Created attachment 75671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75671&action=edit
Bug 20829: Handle non-existent barcode when linking to host item

Since commit 2c9aeb9b0f4449d1a25274b8fbf8dae4ec11d3bf
  Bug 18277: Remove GetBiblionumberFromItemnumber - linkitem

$item is not defined if the barcode is invalid, we should not call
method on it in that case.

Test plan:
- Turn on EasyAnalyticalRecords
- Go to a detail page
- Edit > Link to host item
- Enter an invalid barcode
=> With the patch you get a friendly error message
=> Without this patch it explodes with
Can't call method "itemnumber" on an undefined value at
/home/vagrant/kohaclone/cataloguing/linkitem.pl line 86.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20829] 'Link to host item' gives internal server error

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20829

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
I get a different one:

Can't call method "itemnumber" on an undefined value at
/home/vagrant/kohaclone/cataloguing/linkitem.pl line 86.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

Marcel de Rooy  changed:

   What|Removed |Added

Summary|Replace usage of|Replace usage of
   |File::Spec->tmpdir with |File::Spec->tmpdir with
   |Koha::UploadedFile->tempora |C4::Context->temporary_dire
   |ry_directory|ctory

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with Koha::UploadedFile->temporary_directory

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

--- Comment #12 from Marcel de Rooy  ---
Created attachment 75670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75670&action=edit
Bug 20727: (QA follow-up) Remove a few use statements again

We do no longer need "use Koha::UploadedFile" in a few places.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with Koha::UploadedFile->temporary_directory

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

--- Comment #11 from Marcel de Rooy  ---
Created attachment 75669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75669&action=edit
Bug 20727: (QA follow-up) Fix Upload.t and Plugins.t

Trivial changes.
Adding C4::Context->temporary_directory to subsequent tmpdir call in Plugins.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with Koha::UploadedFile->temporary_directory

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75626|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 75668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75668&action=edit
Bug 20727: Move temporary_directory() to C4::Context

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with Koha::UploadedFile->temporary_directory

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #75200|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 75667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75667&action=edit
Bug 20727: Replace usage of File::Spec->tmpdir with
Koha::UploadedFile->temporary_directory

As explained in bug 20428 use tmpdir can cause issues and it just makes sense
to standardize our temp directory in a universal way.

Test Plan:
1) Apply this patch
2) Verify you can still log in and use Koha
3) Verify the web installer still works
4) Verify EDI module can still download files via FTP
5) Verify fines.pl still runs with -o option
6) prove t/db_dependent/Plugins.t
7) prove t/db_dependent/Sitemapper.t
8) prove t/db_dependent/Templates.t

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with Koha::UploadedFile->temporary_directory

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Signed Off
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20826] Error during initial setup

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826

Jonathan Druart  changed:

   What|Removed |Added

   Severity|blocker |major
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Lowering severity as it's not confirmed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 20836] debian/contron.in cleanup

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20836

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |mi...@abunchofthings.net
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 20836] New: debian/contron.in cleanup

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20836

Bug ID: 20836
   Summary: debian/contron.in cleanup
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: mi...@abunchofthings.net

There seems to be some cleanup needed on the control.in file (at least for
master).

I would expect koha-common to depend on koha-perldeps and koha-deps, but
instead koha-common doesn't depend on it, and they diverted in the list of
things Koha requires (memcached is added to koha-common but not koha-deps).

Maybe we just need to get rid of koha-deps altogether, just my two cents.

libwww-youtube-download-perl needs to be removed from suggests too, as it is
present in the generated koha-perldeps.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 18316] Add weighting/relevancy options to ElasticSearch

2018-05-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18316

--- Comment #74 from David Gustafsson  ---
Hmm, thought I had fixed the merge conflicts, but perhaps I was using a non up
to date or something has changed since last time. Can have a look at it
tomorrow if no one else does before then.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >