[Koha-bugs] [Bug 20543] Use multi-core compression to speed up Koha backups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20543 --- Comment #10 from Mason James --- (In reply to Jonathan Druart from comment #5) > One more deps, one more deps! :) > > Maybe we should use it only if installed (and not require it?) hi Jonathan a single 56k dependency, for a 3x speedup in backup time (i7-2600 cpu) why would anyone *not* want this enabled, by default? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15766] Give label and patron card batches a description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #39 from Aleisha Amohia --- Created attachment 75843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75843=edit Bug 15766: [FOLLOW-UP] Fixing layout of description button This patch moves the 'Save' button to the toolbar as suggested. The description textbox and 'Save' button are hidden if the batch is new and appears when items are added. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #56 from Aleisha Amohia --- Created attachment 75842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75842=edit Bug 17698: [FOLLOW-UP] Rebase and schema update Setting to signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What|Removed |Added Attachment #73841|0 |1 is obsolete|| --- Comment #53 from Aleisha Amohia --- Created attachment 75839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75839=edit Bug 17698: [FOLLOW-UP] Koha Objects, access borrower through patron sub See Comment 27 This is ready to be tested. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What|Removed |Added Attachment #73839|0 |1 is obsolete|| --- Comment #51 from Aleisha Amohia --- Created attachment 75837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75837=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowCheckoutNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave a checkout note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage checkout notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage checkout notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an checkout note as seen. This should update the status of the checkout note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec Followed test plan, works as expected Signed-off-by: Marc Véron Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What|Removed |Added Attachment #74044|0 |1 is obsolete|| --- Comment #54 from Aleisha Amohia --- Created attachment 75840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75840=edit Bug 17698: [FOLLOW-UP] Fixing some small issues Fixing the comments in Comment 42 Ready to test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Aleisha Amohia changed: What|Removed |Added Attachment #74193|0 |1 is obsolete|| --- Comment #55 from Aleisha Amohia --- Created attachment 75841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75841=edit Bug 17698: (QA follow-up) Changes to use Asset TT plugin (bug 20538) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698
Aleisha Amohia changed:
What|Removed |Added
Attachment #73840|0 |1
is obsolete||
--- Comment #52 from Aleisha Amohia ---
Created attachment 75838
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75838=edit
Bug 17698: [FOLLOW-UP] Changing to Koha Objects style, adding circ sidebar
Marcel, can you please have a look at this patch. I tried to implement
the change
my @notes = $schema->resultset('Issue')->search({ 'me.note' => { '!=', undef }
}, { prefetch => [ 'borrower', { item => 'biblionumber' } ] });
to
my @notes = Koha::Checkouts->search({ 'me.note' => { '!=', undef } }, {
prefetch => [ 'borrower', { item => 'biblionumber' } ] });
but am having problems on the template side. I can access the item and
biblio information about the issue, but not the borrower information,
even though the query is definitely pulling it correctly. Any
suggestions or ideas as to why this breaks?
This patch also adds the implementation of the circSidebar.
Signed-off-by: Brendan Gallagher
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after upgrade to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879 --- Comment #8 from ck...@uttyler.edu --- I must have copied the wrong log entries from the wrong timeframe. Upon further testing, the value is actually present. Could LDAP being enabled throw off the auth process for Shibboleth? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20884] Stale data remaining in cache after koha-remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884 --- Comment #2 from Jerome Charaoui --- Using a function like flush_cache() would indeed be better than restarting the service. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20884] Stale data remaining in cache after koha-remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884 Jerome Charaoui changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20884] Stale data remaining in cache after koha-remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- Note for later, see also: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75384 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20884] Stale data remaining in cache after koha-remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884 Jonathan Druart changed: What|Removed |Added Severity|minor |normal Assignee|koha-b...@lists.koha-commun |jchara...@cmaisonneuve.qc.c |ity.org |a Version|18.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20884] New: Stale data remaining in cache after koha-remove
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20884 Bug ID: 20884 Summary: Stale data remaining in cache after koha-remove Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: jchara...@cmaisonneuve.qc.ca QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net Created attachment 75836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75836=edit 0001-Restart-memcached-after-koha-remove-if-needed.patch After running koha-remove, stale data remains in within the memcached server. Say if an instance is deleted then recreated immediately, changed data such as database credentials isn't loaded into the cache, resulting in strange, difficult to troubleshoot problems. The solution would be to flush memcached cache at the end of koha-remove. The most straightforward method to do this is simply restart the service. See attached patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #16 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #14) > What about other languages? Not all languages that have translated sql files (marc21 project on translation server) have custom install dirs, so is up to each language maintainer what to do with those sql files. It would be better if we could 'translate' sql files using the normal way, but it's no easy task. I tried a while ago using XML files... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20307] Language overlay for authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |koha-b...@lists.koha-commun |ommunity.org|ity.org Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #15 from Katrin Fischer --- I think some have translated manually, so might not be so easy to switch them to the generated files? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 Kyle M Hall changed: What|Removed |Added Attachment #75834|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall --- Created attachment 75835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75835=edit Bug 20727: Add use line for File::Spec in C4::Context, sort used modules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #15 from Kyle M Hall --- Created attachment 75834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75834=edit Bug 20727: Add use line for File::Spec in C4::Context, sort used modules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #14 from Kyle M Hall --- Created attachment 75833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75833=edit Bug 20727: Replace use of tmpdir in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #14 from Jonathan Druart --- What about other languages? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 --- Comment #13 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #12) > About the changes to > installer/data/mysql/de-DE/marcflavour/marc21/mandatory/ > authorities_normal_marc21.sql, should not we added them on bug 19835? > > We are going to have these files differ, again. Hi Jonathan On master+19835+20710 en/marcflavour/marc21/mandatory/authorities_normal_marc21.sql will have 2385 lines On master+20709 de-DE/marcflavour/marc21/mandatory/authorities_normal_marc21.sql will have 2385 lines too They will differ in that one is the translation of the other, but they are basically the same file. The only thing is that translations are made using master+19835+20710, so they will differ (a little) until 19835 & 20710 are pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20501] Unhighlight in search results when the search terms contain the same word twice removes the word
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 --- Comment #2 from Owen Leonard --- I cannot reproduce this problem in master. Can anyone confirm? If so please cite another example. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641 Owen Leonard changed: What|Removed |Added Attachment #75300|0 |1 is obsolete|| --- Comment #4 from Owen Leonard --- Created attachment 75832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75832=edit Bug 20641: Switch single-column templates to Bootstrap grid: Various, part 2 This patch updates various unrelated templates to use the Bootstrap grid. In each case, confirm that the indicated page looks correct. - Acquisitions -> Vendor -> Add to basket -> From a staged file. - Logged-in user menu (in the upper right) -> Search history. - With plugins disabled in koha-conf.xml, go to Tools -> Tools plugins. - With the EasyAnalyticalRecords system preference set to 'Display,' view a bibliographic record. - Choose Edit -> Link to host item. - Submit a barcode to be linked. - Configure a MARC subfield (e.g. 100$a) to use the unimarc_field_225a_bis plugin. From the MARC edit page, trigger the plugin and confirm that the page in the popup window looks correct. Confirm that changes made in the popup window are saved to the corresponding field in the editor. - Administration -> Funds -> Edit a fund. - Click 'Select owner.' - Search for a patron. Signed-off-by: Claire Gravely Rebased on top of Bug 19709 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19893] Alternative optimized indexing for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19893 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #67 from Katrin Fischer --- Have we come to a conclusion here? What would be the next step? Should we add it to the agenda for next dev's meeting? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #46 from Kyle M Hall --- Created attachment 75831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75831=edit Bug 20073: Move Elasticsearch yaml files back to admin directory Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 --- Comment #45 from Kyle M Hall --- Created attachment 75830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75830=edit Bug 20073: Remove perlcritic error "return" statement with explicit "undef" at line 245, column 5. See page 199 of PBP. (Severity: 5) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Kyle M Hall changed: What|Removed |Added Attachment #74421|0 |1 is obsolete|| Attachment #74759|0 |1 is obsolete|| Attachment #75453|0 |1 is obsolete|| --- Comment #44 from Kyle M Hall --- Created attachment 75829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75829=edit Bug 20073 - Move Elasticsearch configs to yaml files and improve the default settings. Improvements: 1) Index settings moved from code to etc/searchengine/elasticsearch/index_config.yaml. An alternative can be specified in koha-conf.xml. 2) Field settings moved from code to etc/searchengine/elasticsearch/field_config.yaml. An alternative can be specified in koha-conf.xml. 3) mappings.yaml has been moved from admin/searchengine/elasticsearch to etc/searchengine/elasticsearch. An alternative can be specified in koha-conf.xml. 4) Default settings have been improved to remove punctuation from phrases used for sorting etc. 5) State variables are used for storing configuration to avoid parsing it multiple times. 6) A possibility to reset the fields too has been added to the reset operation of mappings administration. 7) mappings.yaml has been moved from admin/searchengine/elasticsearch to etc/searchengine/elasticsearch. 8) An stdno field type has been added for standard identifiers. To test: 1) Run tests in t/Koha/SearchEngine/Elasticsearch.t 2) Clear tables search_fields and search_marc_map 3) Go to admin/searchengine/elasticsearch/mappings.pl?op=reset_know_what_i_am_doing=1 4) Verify that admin/searchengine/elasticsearch/mappings.pl displays the mappings properly, including ISBN and other standard number fields. 5) Index some records using the -d parameter with misc/search_tools/rebuild_elastic_search.pl to recreate the index 6) Verify that you can find the records 7) Put non_existent to koha-conf.xml 8) Verify that admin/searchengine/elasticsearch/mappings.pl?op=reset_know_what_i_am_doing=1 fails because it can't find non_existent. 9) Copy etc/searchengine/elasticsearch/mappings.yaml to a new location and make elasticsearch_index_mappings setting in koha-conf.xml point to it. 10) Make a change in the new mappings.yaml. 11) Clear table search_fields (mappings reset doesn't do it yet, see bug 20248) 12) Go to admin/searchengine/elasticsearch/mappings.pl?op=reset_know_what_i_am_doing=1 13) Verify that the changes you made are now visible in the mappings UI Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19709] Move template JavaScript to the footer: Labels
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 Owen Leonard changed: What|Removed |Added Blocks||20641 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641 [Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20641] Switch single-column templates to Bootstrap grid: Various, part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20641 Owen Leonard changed: What|Removed |Added Depends on||19709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 [Bug 19709] Move template JavaScript to the footer: Labels -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19719] Add a new column for collection in the patron checkouts data table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #15 from Owen Leonard --- Update the table's column configuration to initially hide the column? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19719] Add a new column for collection in the patron checkouts data table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #14 from Katrin Fischer --- We could display for new installations and hide on update? Not sure about the db structure there, have to take a closer look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19719] Add a new column for collection in the patron checkouts data table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #13 from Jonathan Druart --- Do we really want to display this column for all installations? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 --- Comment #19 from Jonathan Druart --- Created attachment 75828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75828=edit Bug 7651: put TT directive on a single line to help translation Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 --- Comment #18 from Jonathan Druart --- Created attachment 75827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75827=edit Bug 7651: (QA follow-up) Fix warning about undefined active currency If no active currency is defined we show a warning. This fixes the link shown below to check the correct permission. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 --- Comment #17 from Jonathan Druart --- Created attachment 75826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75826=edit Bug 7651: (follow-up) Correct visibility on admin sidebar This patch corrects visibility of links to the different acquisition pages from the admin sidebar. It also makes a correction to the links on the acq start page: - Budgets = period_manage - Funds = budget_manage To test: - Follow the test plan of the first patch Signed-off-by: Charles Farmer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7651] Add separate permission for managing currencies and exchange rates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 Jonathan Druart changed: What|Removed |Added Attachment #75573|0 |1 is obsolete|| Attachment #75574|0 |1 is obsolete|| Attachment #75788|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 75825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75825=edit Bug 7651: Add a new permission for managing currencies and exchange rates At the moment staff users need parameters or parameters_remaining_permissions in order to be able to change exchange rates for acquisition orders. This patch adds a new separate permission currencies_manage and updates staff users currently having those permissions to get the new permission as well. To test: - Create some staff users with different permission sets 1) superlibrarian 2) parameters 3) parameters_remaining_permissions 4) manage_circ_rules, but not parmeters_remaining_permissions 5) all acquisition permissions - Apply patch and run database update - Verify new permission has been added and staff users updated 1) remains the same 2) + 3) will have currencies_manage 4) remains unchanged, doesn't have new permission 5) remains the same, will have access now because of having the top level acquisition permission - Verify the changed pages work correctly: - navigation on admin home page NOTE: the acquisition parameters section will now honor all different related permissions (edi_manage, budget_manage,...) - navigation on acquisition home page - try to access currencies page directly Signed-off-by: Charles Farmer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20880] Upgraded 17.11 to 18.05: Malformed Bootstrap Theme Filenames
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- (In reply to Christian McDonald from comment #4) > What's confusing to me is that my installation IS a packaged installation > (Debian using the stable repository). When you upgraded, did apt ask you something about this file? If you manually edited the file before the upgrade, apt asks you what you want to do with the file: pick the one from the maintainer, keep yours, etc. If you selected something else than picking the file provided by the package it is expected that these lines are missing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20880] Upgraded 17.11 to 18.05: Malformed Bootstrap Theme Filenames
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880 --- Comment #5 from Katrin Fischer --- Ok, out of my depth then. Should we reopen? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20867] Ability to show membership renewal date on moremember.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867 Amit Gupta changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20867] Ability to show membership renewal date on moremember.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867 Amit Gupta changed: What|Removed |Added Attachment #75774|0 |1 is obsolete|| --- Comment #4 from Amit Gupta --- Created attachment 75824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75824=edit Bug 20867 - Ability to show membership renewal date on moremember.pl page Test case: 1. Create the patron. 2. Search the patron whose date of membership is about to expire or expired. 3. Click on More->Renew patron. 4. Now membership is renewed. 5. Apply the patch. 6. Reload the page now you will able to see the Membership renewal date. Fix QA comments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19835] Update MARC frameworks to Updates 23+24+25 (Nov 2016, May and Dec 2017)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19835 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #19 from Jonathan Druart --- RM: wait for the answer on bug 20709 comment 12 please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20709] Update GERMAN MARC frameworks to Updates 23-26 (Nov 2016, May and Apr 2018)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20709 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #12 from Jonathan Druart --- About the changes to installer/data/mysql/de-DE/marcflavour/marc21/mandatory/authorities_normal_marc21.sql, should not we added them on bug 19835? We are going to have these files differ, again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20468] Multiselect on staff article requests form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20468 --- Comment #15 from Jonathan Druart --- There are several "Reason for cancellation:" pop-ups, it that expected? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after upgrade to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879
--- Comment #7 from Martin Renvoize ---
Well the fact that $ENV{$matchAttribute} is undefined is the root cause of the
problem. I've never seen that happen outside of the plack context though so I'm
not really sure what to advise.
Are you sure your SP is running and passing attributes through to the vhost in
apache?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20668] Update two-column templates with Bootstrap grid: Acquisitions part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 Jonathan Druart changed: What|Removed |Added Attachment #75196|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 75823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75823=edit Bug 20668: Update two-column templates with Bootstrap grid: Acquisitions part 2 This patch modifies several acquisitions templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from
[Koha-bugs] [Bug 20668] Update two-column templates with Bootstrap grid: Acquisitions part 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20668 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20779] Style refresh for patron detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20779 Owen Leonard changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20880] Upgraded 17.11 to 18.05: Malformed Bootstrap Theme Filenames
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20880 --- Comment #4 from Christian McDonald --- What's confusing to me is that my installation IS a packaged installation (Debian using the stable repository). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20767] "The method is not covered by tests!" should give more information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20767 Jonathan Druart changed: What|Removed |Added Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20840] Internal Server Error when clicking on "Details" button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20840 Jonathan Druart changed: What|Removed |Added Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #13 from Jonathan Druart --- Do not we need to update the occurrence in updatedatabase.pl as well? installer/data/mysql/updatedatabase.pl:my $tmp= File::Spec->tmpdir.'/koha_upload'; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20867] Ability to show membership renewal date on moremember.pl page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20867 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- The change to the controller is not needed, you just need: +[% patron.date_renewed %] +Renewal date: [% patron.date_renewed | $KohaDates %] +[% END %] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after upgrade to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879
--- Comment #6 from ck...@uttyler.edu ---
(In reply to Jonathan Druart from comment #5)
> (In reply to cking from comment #3)
> > I get the following in the opac-error log now with $debug=1.
> > The uninitialized value on line 86 appears to relate to this line in
> > get_login_shib:
> > $debug and warn $matchAttribute . " value: " . $ENV{$matchAttribute};
> >
> > I don't believe we are using Plack, but I'm not familiar with it either.
>
> I read to fast.
> To know if you are using plack, go to the about page, tab "Server
> information", line "PSGI".
Ah, thanks. No mention of PSGI in the About screen.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after upgrade to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879
--- Comment #5 from Jonathan Druart
---
(In reply to cking from comment #3)
> I get the following in the opac-error log now with $debug=1.
> The uninitialized value on line 86 appears to relate to this line in
> get_login_shib:
> $debug and warn $matchAttribute . " value: " . $ENV{$matchAttribute};
>
> I don't believe we are using Plack, but I'm not familiar with it either.
I read to fast.
To know if you are using plack, go to the about page, tab "Server information",
line "PSGI".
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after upgrade to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879
Jonathan Druart changed:
What|Removed |Added
See Also||https://bugs.koha-community
||.org/bugzilla3/show_bug.cgi
||?id=17776
--- Comment #4 from Jonathan Druart
---
I guess it comes from:
Auth.pm: employeeNumber value: at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 86
85 $debug and warn $matchAttribute . " value: " . $ENV{$matchAttribute};
See bug 17776.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17776] Shibboleth Authentication is broken in plack
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17776 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20879 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after upgrade to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879
--- Comment #3 from ck...@uttyler.edu ---
I get the following in the opac-error log now with $debug=1.
The uninitialized value on line 86 appears to relate to this line in
get_login_shib:
$debug and warn $matchAttribute . " value: " . $ENV{$matchAttribute};
I don't believe we are using Plack, but I'm not familiar with it either.
[Tue Jun 05 09:44:25.029248 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun 5 09:44:25 2018] Auth.pm: koha
borrower field to match: cardnumber at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 166, line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.029403 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun 5 09:44:25 2018] Auth.pm: shibboleth
attribute to match: employeeNumber at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 168, line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.029520 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun 5 09:44:25 2018] Auth.pm: koha
borrower field to match: cardnumber at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 166, line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.029638 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun 5 09:44:25 2018] Auth.pm: shibboleth
attribute to match: employeeNumber at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 168, line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.029764 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun 5 09:44:25 2018] Auth.pm: Use of
uninitialized value in concatenation (.) or string at
/usr/share/koha/lib/C4/Auth_with_shibboleth.pm line 86, line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.029866 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun 5 09:44:25 2018] Auth.pm:
employeeNumber value: at /usr/share/koha/lib/C4/Auth_with_shibboleth.pm line
86, line 755.: /usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.092226 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: C4::Tags external dictionary = none:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
[Tue Jun 05 09:44:25.215447 2018] [cgi:error] [pid 189874] [client
129.114.255.234:51435] AH01215: [Tue Jun 5 09:44:25 2018] opac-search.pl: Use
of uninitialized value in concatenation (.) or string at
/usr/share/koha/lib/C4/Auth.pm line 550, line 755.:
/usr/share/koha/opac/cgi-bin/opac/opac-search.pl
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18880] Regression breaks local authentication fallback for all external authentications
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18880 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20879 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after upgrade to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18880 CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #20 from Jonathan Druart --- IMO we should push this one along with bug 20443 (which does not have patches yet). Otherwise we are going to have 2 different ways to fetch patron's attributes. Before we only had GetBorrowerAttributes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #19 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #18) > FAIL Koha/Patron/Attribute.pm > forbidden pattern: Warning: The 'sub type' may be wrong is declared in a > Koha::* package (see bug 15446) (line 127) > > Josef: > This is a more nasty one. > Could you consider renaming this method? > The Koha objects also use _type and it might be confusing. > What do you think? It already exists. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #18 from Marcel de Rooy --- FAIL Koha/Patron/Attribute.pm forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 127) Josef: This is a more nasty one. Could you consider renaming this method? The Koha objects also use _type and it might be confusing. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #17 from Marcel de Rooy --- Created attachment 75822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75822=edit Bug 12159: (QA follow-up) Silencing POD warn from qa tools *** ERROR: Spurious text after =cut at line 954 in file Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15836] Labels: Offer configuration option for splitting call number in layout definition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15836 Christian Stelzenmüller changed: What|Removed |Added CC||christian.stelzenmueller@bs ||z-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20600] Provide the ability for users to filter ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20600 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard --- (In reply to Katrin Fischer from comment #16) > I had not time to test, but wondering if this will work with our various > dateformat settings? Filtering by date didn't work for me when the dateformat preference was set to dmydot or metric. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20797] If an Ill request has an associated bib record, the detail view should contain a link to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #14 from Jonathan Druart --- (In reply to Andrew Isherwood from comment #13) > Further to this, I think this is the problem: > > https://github.com/PTFS-Europe/koha/blob/master/Koha/Object.pm#L249 > > If it's a numeric column, the value is being cast into an integer regardless > of whether it's populated or not. > > Do you agree this is the bug? That sounds like a bug yes, can you report it and CC Tomas please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20883] Patron userid should be exposed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 --- Comment #2 from Andrew Isherwood --- Created attachment 75821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75821=edit Bug 20883: (follow-up) Fix column indexes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 --- Comment #5 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #4) > I would prefer a patron consent field as a datetime somewhere. This helps us > to comply to the need to prove that a patron gave consent. It should be > added to self registration too. Please have a look at bug 20819 now for the above. It adds a 'your consents' tab in the OPAC account menu. And includes a consent during self-registration. (No staff changes there.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #7 from Marcel de Rooy --- Created attachment 75820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75820=edit Bug 20819: Add consent to self-registration process We add a section for the GDPR consent in opac-memberentry (only for the self-registration). Not when editing personal details. Test plan: [1] Enable selfregistration (with confirm) and GDPR policy. [2] Register a new account in OPAC. Verify that the GDPR checkbox is required. [3] After you submit, you should see a date in borrower_modifications field gdpr_proc_consent. [4] When you confirm, verify that the consent is visible on your consents. [5] Enable selfregistration without confirmation mail. Register again. [6] Check your consents tab again. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #5 from Marcel de Rooy --- Created attachment 75818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75818=edit Bug 20819: Add your consents tab to opac-user This patch adds a consents tab to the OPAC user account menu. We now add a GDPR section here, but it is open for future extensions. Think of a newsletter checkbox for instance. Script opac-patron-consent handles the tab. And now only includes some GDPR code but is also written for more general use too. Test plan: [1] Set GDPR_Policy pref to Disabled. Verify that OPAC operates as usual. [2] Set pref to Permissive. Try to save a consent or a refusal. Note that you are not logged out when saving a refusal. [3] Set pref to Enforced. Save a refusal. You should be logged out. Log in again and verify that the consents tab shows a No. Note: a follow-up patch will add further enforcements. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 --- Comment #6 from Marcel de Rooy --- Created attachment 75819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75819=edit Bug 20819: Add check in get_template_and_user to enforce GDPR If you choose to enforce GDPR policy, a user needs to give consent for data processing before he does something else in the OPAC while being logged in. Test plan: [1] Set GDPR_Policy to Disabled or Permissive. Usual behavior. [2] Set to Enforced. Save a refusal on your consents. Notice that you are logged out when saving. When you login again, all OPAC requests are redirected to your consents tab. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20883] Patron userid should be exposed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20883] Patron userid should be exposed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 --- Comment #1 from Andrew Isherwood --- Created attachment 75817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75817=edit Bug 20883: Add patron userid to display This patch adds the display of patron userid to both the "illlist" and "illview" pages. Test plan (see bug 7317 for ILL deployment details): 1) Ensure you have at least one ILL request 2) Go to the main "List requests" page by clicking "ILL requests" from the main staff interface TEST => Observe that you see a "Patron username" column the the table, containing the patron's correct userid 3) Click "Manage request" on a request TEST => Observe that, in the "Patron" row, you see the patron's correct userid in brackets (along with their name and barcode) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20883] Patron userid should be exposed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 Andrew Isherwood changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20883] New: Patron userid should be exposed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20883 Bug ID: 20883 Summary: Patron userid should be exposed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherw...@ptfs-europe.com Currently, when displaying a list of ILL requests, or viewing a single request, the requester's userid is not displayed. This should be visible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19502] Result sets limited to 10000
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Julian Maurice changed: What|Removed |Added QA Contact|julian.maur...@biblibre.com | --- Comment #7 from Julian Maurice --- Nick, can you take a look at the last patch please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19502] Result sets limited to 10000
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502
--- Comment #6 from Julian Maurice ---
Created attachment 75816
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75816=edit
Bug 19502: Retrieve index.max_result_window from ES
This avoid hardcoding '1' in two different places and allow users to
adjust this setting.
Also, this patch fixes a bug when the search return less than 1
results
Test plan:
1. Do a search that returns 1+ records.
2. Note the warning above the pagination buttons
3. Go to the last page, no error
4. Change the ES setting:
curl -XPUT http://elasticsearch/koha_master_biblios/_settings -d \
'{"index": {"max_result_window": 2}}'
5. Do another search that returns more than 1 but less than 2
6. Note that the warning does not show up
7. Go to the last page, still no error
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19502] Result sets limited to 10000
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 --- Comment #5 from Julian Maurice --- I think we can do better than hardcoding the ES default value for max_result_window. We can retrieve the actual setting from ES, so that anyone can adjust this setting depending on their needs. I'm currently preparing a patch that will do that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20059] Option to allow checkin of non-issued items without setting SIP-alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20059 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #2 from Magnus Enger --- Could you provide a test-plan and set the status to "Needs signoff", please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after upgrade to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879 --- Comment #2 from Martin Renvoize --- It may also be worth enabling debugging (SetEnv DEBUG=1) and see what pops out in the logs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20879] Shibboleth matchpoint no longer works after upgrade to 17.11
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20879 --- Comment #1 from Martin Renvoize --- I'm currently unable to replicate this.. could you let me know if you're using Plack or not to help narrow it down a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876 Marcel de Rooy changed: What|Removed |Added Attachment #75789|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy --- Created attachment 75815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75815=edit Bug 20876: The form_serialized_itype cookie is not used and should be removed This patch removes references to a form_serialized_itype cookie which appears in the code as part of the process of storing information used in the generation of the "Return to the last advanced search" link. To test, apply the patch and perform an advanced search in the OPAC using several search options including a limit by item type. From the search results page, follow the "Return to the last advanced search" link. The advanced search form should appear with all the search options you submitted before. Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19502] Result sets limited to 10000
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19502 Julian Maurice changed: What|Removed |Added QA Contact||julian.maur...@biblibre.com CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20876] The form_serialized_itype cookie is not used and should be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20876 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866 Marcel de Rooy changed: What|Removed |Added Attachment #75791|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy --- Created attachment 75813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75813=edit Bug 20866: Make ArticleRequests.t pass even if table is not empty Previous patch from Marcel removed the data from article_requests, I do not think it is a good idea to remove existing data, it could hide bugs. This patch moves the count inside the subtest block in order to have the correct value when these tests are executed. Previous code was broken: Koha::Patron->store does not generate a userid, and ->search_limited did not work correctly (Koha::Patron->has_permission returned early because of the non-existing userid, 'return unless $self->userid;'); Test plan: [1] Create an article request. [2] Run t/db_dependent/ArticleRequests.t Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866 --- Comment #7 from Marcel de Rooy --- Created attachment 75814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75814=edit Bug 20866: (QA follow-up) Use build_object and remove two tests The unique constraint on userid is handled in TestBuilder. So let's use it. The two tests if count==$count do not make much sense anymore when we call ->count a few lines before. The check with search_limited is enough. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17561] ReserveSlip needs itemnumber for item level holds on same biblio
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17561 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Pushed to Master|Pushed to Stable --- Comment #30 from Martin Renvoize --- This patch has been pushed to 18.05.x and will be in 18.05.01 Nice to see this bug squashed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #16 from Josef Moravec --- Created attachment 75812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75812=edit Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec changed: What|Removed |Added Attachment #74791|0 |1 is obsolete|| Attachment #74792|0 |1 is obsolete|| --- Comment #15 from Josef Moravec --- Created attachment 75811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75811=edit Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 --- Comment #11 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #10) > Thanks, Owen, for the sign-off and retesting. > Article slips still work for me. Thx Katrin for QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
