[Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653 Pierre-Luc Lapointe changed: What|Removed |Added CC||pierre-luc.lapointe@inLibro ||.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16653] reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16653 Pierre-Luc Lapointe changed: What|Removed |Added Attachment #75886|0 |1 is obsolete|| --- Comment #3 from Pierre-Luc Lapointe --- Created attachment 75937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75937=edit Bug 16653: Display number of checkouts when exporting 'Most-circulated items' as CSV reports/cat_issues_top.pl does not export "Count of checkouts" column as CSV To replicate: 1/ Make sure that test instance has circulation in a given date range 2/ Go to Home › Reports › Most-circulated items 3/ Select a date range 4/ Select 'To screen into the browser' radio button, click submit. 5/ Note that Columns 'Rank/Biblioitemnumbers', 'Global' and 'Count of checkouts' appear in screen output. 6/ Click the browser's back button 7/ Change output to 'To a file', click submit. Without this patch: the columns "100/", "Global" and "Total" are exported to the CSV file. "100/" contains the rank, "Global" is still global, and the "Total" column is empty. With this patch patch applied, the last column is filled and the "Total" line is removed (This script is really dirty) Signed-off-by: Pierre-Luc Lapointe -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost item fee first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285 Maryse Simard changed: What|Removed |Added Attachment #72123|0 |1 is obsolete|| --- Comment #3 from Maryse Simard --- Created attachment 75936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75936=edit Bug 20285: Lost item refund won't always pay down lost item fee first Due to a simple typo, the accountline passed to Koha::Account::pay from _FixAccountForLostAndReturned is not used. That means that the credit for the lost item fee may be applied to other fees before it is used on the lost fee itself. Test Plan: 1) Find a patron with existing fines 2) Ensure your settings will charge patrons for lost items 3) Check out an item to a patron with existing fees that need paid 4) Mark the item lost, charging the lost item fee 5) Return the item 6) Note the fee was refunded, but it paid down earlier fines first, and not the lost item fee first 7) Apply this patch set 8) Repeat steps 1 - 5 9) Note the lost item fee is the first fee to be paid off by the lost item fee refund Signed-off-by: Maryse Simard Followed the test plan and it works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost item fee first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19970] Revise change of bug 19413 to work better for translations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19970 Maryse Simard changed: What|Removed |Added Attachment #75707|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 75935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75935=edit Bug 19970: Revise change of bug 19413 to work better for translations This patch changes how the submit and cancel buttons appear in the MARC 008 plugin window. The controls are now displayed as buttons in a floating toolbar. To test you must have MARC tag 008 configured to use the marc21_field_008.pl plugin. - Apply the patch and open an existing or blank record in cataloging. - Click the plugin link next to tag 008 to trigger the popup window. - Confirm that "Save" and "Cancel" appear correctly in a toolbar. - Scroll down the page to confirm that the toolbar "sticks" to the top of the window. - Confirm that the "Save" and "Cancel" buttons work correctly. Signed-off-by: Maryse Simard Followed the test plan and the patch works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7136] Correct description of Grace period for subscriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7136 Maryse Simard changed: What|Removed |Added Attachment #75352|0 |1 is obsolete|| --- Comment #7 from Maryse Simard --- Created attachment 75934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75934=edit Bug 7136: Correct description of Grace period for subscriptions The grace period is used with the serialsUpdate.pl cronjob. It will generate the next issue and set the one before to 'Late' with an optional note. There is on trace of a 'waiting' status for serials. To test: - check help file on the subscription edit form for the description of the 'Grace period'. Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17153] Logging in during a search navigates to account page instead of back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Maryse Simard changed: What|Removed |Added Attachment #75714|0 |1 is obsolete|| --- Comment #18 from Maryse Simard --- Created attachment 75933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75933=edit Bug 17153: Login during search rebase and fix This patch is a fresh attempt at redirecting back to search results after logging in on opac-search.pl To test: - Perform an OPAC search - Login on opac-search.pl with the search results displayed - The page is redirected to opac-user.pl - Log out - Apply the patch - Perform a new OPAC search - Note the URL query string - Login on opac-search.pl with the search results displayed - The opac-search.pl page should be displayed with the correct query string and the page should indicate a logged in status Signed-off-by: Maryse Simard Followed the test plan and the patch works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17153] Logging in during a search navigates to account page instead of back to search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17153 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20598] Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598 Maryse Simard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20598] Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20598 Maryse Simard changed: What|Removed |Added Attachment #74377|0 |1 is obsolete|| --- Comment #2 from Maryse Simard --- Created attachment 75932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75932=edit Bug 20598: Accruing fines not closed out by longoverdue.pl if WhenLostForgiveFine is not enabled Test Plan: 1) Ensure WhenLostForgiveFine is disabled 2) Create an overdue with a fine 3) Mark it lost with longoverdue.pl 4) Note it is still marked as an accruing fine 5) Apply this patch 6) Repeat steps 1-3 7) Note it is no longer an accruing fine! Signed-off-by: Maryse Simard Followed the test plan and it works. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13897] Use XML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 75931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75931=edit Bug 13897: Split auth framework into xml and sql files Bug 13897: Split auth framework into xml and sql files This patch split authorities_normal_marc21.sql contents between three XML files and a remanent SQL file GZIP file of patch, it's too large -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13897] Use XML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 75930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75930=edit Bug 13897: C4/Installer.pm - process XML files This patch modifies C4/Installer.pm to add support for processing of XML files into database. For MySQL only -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13897] Use XML files for installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #37165|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 --- Comment #7 from Jonathan Druart --- Created attachment 75929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75929=edit Bug 20906: Fix translatable-templates.t >From Jenkins: koha_1 | # Failed test 'staff_prog templates are translatable' koha_1 | # at xt/author/translatable-templates.t line 87. koha_1 | # Can't locate TmplTokenizer.pm in @INC (you may need to install the TmplTokenizer module) (@INC contains: /kohadevbox/koha /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at ./tmpl_process3.pl line 20. On Stretch, '.' is not longer added to @INC, see bug 17717 for more info -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20907] New: Improve sorting for suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20907
Bug ID: 20907
Summary: Improve sorting for suggestions
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs@lists.koha-community.org
Reporter: christian.stelzenmuel...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
The suggestions from the suggestion list can currently only be sorted by "by"
in the columns "Managed by/on" and "Suggested by/on".
It should also be sorted by date ("on").
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #19 from Jonathan Druart --- Created attachment 75925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75925=edit Bug 20727: (QA follow-up) Fix Upload.t and Plugins.t Trivial changes. Adding C4::Context->temporary_directory to subsequent tmpdir call in Plugins. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #18 from Jonathan Druart --- Created attachment 75924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75924=edit Bug 20727: Move temporary_directory() to C4::Context Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #22 from Jonathan Druart --- Created attachment 75928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75928=edit Bug 20727: Add use line for File::Spec in C4::Context, sort used modules Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 Jonathan Druart changed: What|Removed |Added Attachment #75667|0 |1 is obsolete|| Attachment #75668|0 |1 is obsolete|| Attachment #75669|0 |1 is obsolete|| Attachment #75670|0 |1 is obsolete|| Attachment #75833|0 |1 is obsolete|| Attachment #75835|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart --- Created attachment 75923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75923=edit Bug 20727: Replace usage of File::Spec->tmpdir with Koha::UploadedFile->temporary_directory As explained in bug 20428 use tmpdir can cause issues and it just makes sense to standardize our temp directory in a universal way. Test Plan: 1) Apply this patch 2) Verify you can still log in and use Koha 3) Verify the web installer still works 4) Verify EDI module can still download files via FTP 5) Verify fines.pl still runs with -o option 6) prove t/db_dependent/Plugins.t 7) prove t/db_dependent/Sitemapper.t 8) prove t/db_dependent/Templates.t Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #21 from Jonathan Druart --- Created attachment 75927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75927=edit Bug 20727: Replace use of tmpdir in updatedatabase.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20727] Replace usage of File::Spec->tmpdir with C4::Context->temporary_directory
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20727 --- Comment #20 from Jonathan Druart --- Created attachment 75926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75926=edit Bug 20727: (QA follow-up) Remove a few use statements again We do no longer need "use Koha::UploadedFile" in a few places. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 Jonathan Druart changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #6 from Jonathan Druart --- Good catch Nick. From trivial it is becoming a complex one now. Last patch for discussion and review before a full rewrite of the TT plugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891 --- Comment #5 from Jonathan Druart --- Created attachment 75922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75922=edit Bug 20891: Escape html then JSON To my understanding we need to escape first html chars then to JSON. If this patch works we will need to rethink the 'To' TT plugin. It was originally designed to have several escape methods, but with these changes it will not make sense to name it 'To' if used only to escape JSON IIRC we should keep the 2 different ways to use it: * [% To.json( string ) %] * [% string | $To %] otherwise it will be hard to use it when called in argument of patron-title.inc (`git grep To.json`) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Martin Renvoize changed: What|Removed |Added Keywords|rel_18_05_candidate | Status|Pushed to Master|Pushed to Stable CC||martin.renvoize@ptfs-europe ||.com --- Comment #13 from Martin Renvoize --- This patch has been pushed to 18.05.x and will be in 18.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately casting to integer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #10 from Martin Renvoize --- This patch has been pushed to 18.05.x and will be in 18.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 --- Comment #6 from Martin Renvoize --- Test plan.. run the affected tests against both D8 and D9 and see that they now pass ;) Beware, running 00_strict requires WebService::ILS::OverDrive is installed.. KohaDevBox is missing it in my experience. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 --- Comment #5 from Martin Renvoize --- I'm not proud of that last one.. it fixes the tests but I'd rather convert the float for discount in the database to a decimal to match the decimal that's used for tax_rate (which is also a percentage measured to the same accuracy.. seems odd to have them stored differently).. but that seemed over the top here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 --- Comment #4 from Martin Renvoize --- Created attachment 75921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75921=edit Bug 20906: Prevent test failures due to precision changes (2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 --- Comment #3 from Jonathan Druart --- It seems that t/db_dependent/Labels/t_Batch.t is failing as well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18821] TrackLastPatronActivity is a performance killer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18821 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #47 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20889] Items marked as not for loan can be checked out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20889 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20875] OpacAddMastheadLibraryPulldown displays an empty list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20875 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount owed for a fee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #34 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2426] Management permissions is deprecated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20053] Drop type attribute "text/javascript" for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20053 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20829] 'Link to host item' gives internal server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20829 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20778] Unable to delete a subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20778 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20866] ArticleRequests.t fails on existing requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20866 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20886] Koha::Object::TO_JSON indiscriminately casting to integer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20700] Update MARC21 leader/007/008 codes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20700 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20851] Missing module in circ/article-request-slip.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20851 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||n...@bywatersolutions.com --- Comment #12 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20756] OPAC "Share list" button should be styled with an icon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20756 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Pushed to master for 18.11, awesome work all! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 Charles Quain changed: What|Removed |Added CC||c...@interleaf.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 --- Comment #2 from Martin Renvoize --- On upgrade from Debian 8 to Debian 9 the resultant Perl update means perl strict is 'more strict' ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Fix Debian 9 Test Failures
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 Martin Renvoize changed: What|Removed |Added Summary|Prevent the tests to fail |Fix Debian 9 Test Failures |if precision changes| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20891] Lists in staff don't load when \ was used in the description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20891
Nick Clemens changed:
What|Removed |Added
Status|Passed QA |Failed QA
CC||n...@bywatersolutions.com
--- Comment #4 from Nick Clemens ---
I took your test plant too literally, if your list name is surrounded by
quotes:
"alert('hola');"
it works before this patch, but not after. I think the JSON conversion doesn't
like the quotes
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898 --- Comment #3 from Owen Leonard --- Created attachment 75919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75919=edit Bug 20898 - Replace OPAC detail's results browser with non-JavaScript version This patch moves generation of the OPAC detail page's results browser from JavaScript to the template. This makes the template easier to understand and easier to debug. It also makes it possible for the widget to be completely non-dependent on JavaScript. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files). - Enable the OpacBrowseResults system preference and perform a search in the OPAC which will return multiple results. - Click on any title in the first page of search results. - On the bibliographic detail page there should be a "Browse results" link in the right-hand sidebar just as before. - Test that the "Previous," "Back to results," and "Next" links work correctly. - Click the "Browse results" link. A list of the first 20 search results should appear. An arrow should indicate the title you're viewing. - Click any title in the results browser. The page should correctly load that record. - Clicking the numbered links at the top of the results browser should do the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898 Owen Leonard changed: What|Removed |Added Attachment #75918|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898 --- Comment #2 from Owen Leonard --- Created attachment 75918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75918=edit Bug 20898 - Replace OPAC detail's results browser with non-JavaScript version This patch moves generation of the OPAC detail page's results browser from JavaScript to the template. This makes the template easier to understand and easier to debug. It also makes it possible for the widget to be completely non-dependent on JavaScript. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files). - Enable the OpacBrowseResults system preference and perform a search in the OPAC which will return multiple results. - Click on any title in the first page of search results. - On the bibliographic detail page there should be a "Browse results" link in the right-hand sidebar just as before. - Test that the "Previous," "Back to results," and "Next" links work correctly. - Click the "Browse results" link. A list of the first 20 search results should appear. An arrow should indicate the title you're viewing. - Click any title in the results browser. The page should correctly load that record. - Clicking the numbered links at the top of the results browser should do the same. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20898] Replace OPAC detail's results browser with non-JavaScript version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20898 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20120] Prevent writeoffs of more than the amount owed for a fee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20120 --- Comment #33 from Nick Clemens --- Created attachment 75917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75917=edit Bug 20120: (QA follow-up) display correct amount in redirect -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 Owen Leonard changed: What|Removed |Added Summary|Print payment receipt on|Print payment receipt on |child patron could end with |child patron could end with |ISE |server error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Prevent the tests to fail if precision changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 --- Comment #1 from Martin Renvoize --- Created attachment 75916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75916=edit Bug 20906: Prevent test failures due to precision changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] New: Prevent the tests to fail if precision changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 Bug ID: 20906 Summary: Prevent the tests to fail if precision changes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org On upgrade from Debian 8 to Debian 9 the resultant DBI driver update alters the returned precision for numeric values. This causes some of the test suit to start failing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20906] Prevent the tests to fail if precision changes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20906 Martin Renvoize changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 Joe McGlynn changed: What|Removed |Added CC||joe.mcgl...@educampus.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #100 from Marcel de Rooy --- Asked QA team for additional feedback; cant finish this one now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20905] New: Warn from Search.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20905 Bug ID: 20905 Summary: Warn from Search.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org Test passes but look at this warn from getRecords: ok 67 - presence of a transit does not block hold request action (bug 10741) ERROR DECODING RECORD - Tag "50%" is not a valid tag. at /usr/share/perl5/MARC /File/USMARC.pm line 223. : 00295nam a22001217a 4530004000500174008004100021118000622450 0570008050%001100137942001200148999001300160OSt20111207151138.0111207t xxu| 00| 0 eng d aGanser, Helen aA record containing a punctuation character as a tag aa note 2ddccBK c214d214 at /usr/share/koha/devclone/C4/ Search.pm line 683. ok 68 - search for ti:punctuation returned expected number of records A few lines later in the test, a warning_like also looks for this error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20904] New: Warns from Circulation/Chargelostitem.t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20904 Bug ID: 20904 Summary: Warns from Circulation/Chargelostitem.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org Test passes, but warns need attention DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/koha/devclone/Koha/Objects.pm line 191 DBIx::Class::Storage::DBI::select_single(): Query returned more than one row. SQL that returns multiple rows is DEPRECATED for ->find and ->single at /usr/share/koha/devclone/Koha/Objects.pm line 191 t/db_dependent/Circulation/Chargelostitem.t . ok -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with ISE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 Josef Moravec changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with ISE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 --- Comment #1 from Josef Moravec --- Created attachment 75915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75915=edit Bug 20903: Remove unnecessary category code parameters Test plan: 0) Do no apply the patch 1) Have only one adults patrons category defined 2) Add a fine to child patron and pay it 3) Try to print the payment receipt (file printfeercpt.pl) 4) You see only ISE 5) Apply the patch 6) Try the printing again 7) Now you should see right receipt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12586] Record matching rules - Required match checks doesn't work with MARCXML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12586 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20901] Koha/Patrons/Import.t fails on fresh database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20901 Marcel de Rooy changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20902] Labels/t_Batch.t fails on fresh database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20902 --- Comment #1 from Marcel de Rooy --- Fresh install, no optional data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20902] Labels/t_Batch.t fails on fresh database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20902 Marcel de Rooy changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with ISE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 Josef Moravec changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20903] New: Print payment receipt on child patron could end with ISE
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 Bug ID: 20903 Summary: Print payment receipt on child patron could end with ISE Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When you wan't to print a payment receipt for child patron and have only one adult patron category defined, it ends up with internal server error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20902] New: Labels/t_Batch.t fails on fresh database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20902 Bug ID: 20902 Summary: Labels/t_Batch.t fails on fresh database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org t/db_dependent/Labels/t_Batch.t # Looks like you planned 24 tests but ran 14. # Looks like you failed 2 tests of 14 run. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20901] New: Koha/Patrons/Import.t fails on fresh database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20901 Bug ID: 20901 Summary: Koha/Patrons/Import.t fails on fresh database Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org t/db_dependent/Koha/Patrons/Import.t # Looks like you failed 58 tests of 124. Fresh install, no optional stuff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #99 from Marcel de Rooy --- t/db_dependent/Search.t not ok 44 - All records have at least one item available # Failed test 'All records have at least one item available' # at t/db_dependent/Search.t line 508. # got: 'false' # expected: 'true' Pass on fresh db, so needs some digging.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #31 from Julian Maurice --- (In reply to Katrin Fischer from comment #27) > 1) Releatives tab doesn't open. JavaScript error: > Error: Syntax error, unrecognized expression: ##relatives-issues-table Fixed in the last patch > 2) I think most libraries will have a mix of large accounts and smaller > ones. Could it make sense to use the server side processing when the patron > has a certain number of checkouts (configurable)? It makes sense, but I think than can go in a separate bug. Do you agree ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12027] Shibboleth authentication for staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12027 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 Marcel de Rooy changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Marcel de Rooy --- For the fast QA lane, Joubu ? Comes from testing 20271 btw. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 --- Comment #1 from Marcel de Rooy --- Created attachment 75914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75914=edit Bug 20900: Add CPL test branch in rollingloans.t Trivial fix. Test plan: Without this patch and a CPL library, run rollingsloans.t. See warns. With this patch, no warns. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 Marcel de Rooy changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20900] Yet another test assumes that CPL is present
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 Marcel de Rooy changed: What|Removed |Added Severity|enhancement |minor Assignee|ch...@bigballofwax.co.nz|m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219
Julian Maurice changed:
What|Removed |Added
Attachment #74225|0 |1
is obsolete||
--- Comment #29 from Julian Maurice ---
Created attachment 75912
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75912=edit
Bug 15219: Fix date sorting when server-side processing is disabled
Use DataTables 'columns' option instead of 'aoColumns'
This allow more control on what data is used for display, sorting,
filtering, ...
A large part of this patch is about rewording things to better match the
DataTables documentation.
The real change is that
"mRender": renderingFunc
becomes
"render": {
"display": renderingFunc
}
So the return value of renderingFunc is now only used for display (not
for filtering, sorting, ...)
Signed-off-by: Eric Gosselin
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 Julian Maurice changed: What|Removed |Added Attachment #74224|0 |1 is obsolete|| --- Comment #28 from Julian Maurice --- Created attachment 75911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75911=edit Bug 15219: Server-side processing and pagination on checkouts tables Some libraries have patrons with more than 1000 checkouts. Loading all of them at once can be very long, and sometimes can cause timeout errors. This patch prevent that by enabling server-side processing and pagination on checkouts tables. This affects patron's checkouts and patron's relatives' checkouts tables on pages circ/circulation.pl and members/moremember.pl. As server-side processing can be useless and cumbersome with small sets of data, a new system preference is introduced to control this behaviour (server-side processing is disabled by default). Additionally, this patch: - adds a switch to turn off and on row grouping (today's checkouts vs previous checkouts) (on by default) - adds "column settings" for relatives' checkouts tables - factorize some code that was duplicated across the two DataTables configurations (mDataProp) Test plan: 1. Find (or create) a patron that have at least 10 checkouts and where the relatives checkouts table contain at least 10 checkouts. 2. Go to the patron's detail page and check everything works fine in both tables (sorting, pagination, the data itself, ...) 3. Do the same on circulation page (circulation.pl) 4. Enable system preference ServerSideCheckoutsTable 5. Repeat steps 2 and 3 Signed-off-by: Eric Gosselin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20900] New: Yet another test assumes that CPL is present
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20900 Bug ID: 20900 Summary: Yet another test assumes that CPL is present Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: ch...@bigballofwax.co.nz Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org t/db_dependent/rollingloans.t DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_dev`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) [for Statement "UPDATE items SET itemlost_on=?,itemlost=?,onloan=?,datelastborrowed=?,holdingbranch=?,issues=? WHERE itemnumber=?" with ParamValues: 0=undef, 1=0, 2='2011-05-30', 3='2018-06-08', 4="CPL", 5='31254', 6='862'] at /usr/share/koha/devclone/C4/Items.pm line 2038. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15219] Server-side processing and pagination on checkouts tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15219 --- Comment #30 from Julian Maurice --- Created attachment 75913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75913=edit Bug 15219: Fix relatives issues table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 --- Comment #98 from Marcel de Rooy --- Created attachment 75910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75910=edit Bug 20271: (QA follow-up) Remove last occurrences of deleted_at Trivial replace of deleted_at by deleted_on. Test plan: Run t/db_dependent/Koha/ItemTypes.t Run t/db_dependent/Items_DelItemCheck.t git grep -E "deleted_at\W" Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #244 from Julian Maurice --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Attachment #75004|0 |1 is obsolete|| --- Comment #243 from Julian Maurice --- Created attachment 75909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75909=edit Bug 11708: New page for basket groups This patch moves the code responsible for displaying a list of basket groups into its own Perl script (acqui/basketgroups.pl), making the code in basketgroup.pl and basketgroup.tt a little bit easier to read. basketgroups.pl displays all basket groups in a single table (as bug 13371 for vendors) where rows are grouped by bookseller. This patch also adds 3 columns: - No. of ordered titles - No. of received titles - Date closed It also adds a wrapper around the new DataTable() constructor to be able to use it with the same defaults than the previous dataTable() constructor Test plan: 0. Create a bunch of booksellers and basketgroups 1. Go back to acquisitions home page and click on "Basket groups" link on the left 2. Play with the table (sort, filter) and try every possible actions (Edit, Close and export as PDF, View, Reopen, Export as CSV) 3. Go to a specific vendor page and click on "Basket groups" tab 4. Check that only the vendor's basket groups are displayed Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Julian Maurice changed: What|Removed |Added Attachment #75003|0 |1 is obsolete|| --- Comment #242 from Julian Maurice --- Created attachment 75908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75908=edit Bug 11708: Change aqbasketgroups.closed to closeddate Signed-off-by: juliette levast Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #123 from Julian Maurice --- (In reply to Jonathan Druart from comment #114) > 2. Why not a foreign key on aqorders.created_by (with on delete set null)? > > 3. orderreceive.tt and showorder.tt must use patron-title.inc Fixed in the last patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 --- Comment #122 from Julian Maurice --- Created attachment 75907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75907=edit Bug 12395: Add FK constraint and use patron-title.inc Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Attachment #74281|0 |1 is obsolete|| --- Comment #120 from Julian Maurice --- Created attachment 75905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75905=edit Bug 12395: Use standard + markup for showorder.tt Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Attachment #74280|0 |1 is obsolete|| --- Comment #119 from Julian Maurice --- Created attachment 75904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75904=edit Bug 12395: QA follow-up - Add class/id to body tag Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Attachment #74279|0 |1 is obsolete|| --- Comment #118 from Julian Maurice --- Created attachment 75903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75903=edit Bug 12395: Make received orders table consistent with pending orders table (links of More column) Also change "Created by" with "Ordered by" in receive page. Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Attachment #74278|0 |1 is obsolete|| --- Comment #117 from Julian Maurice --- Created attachment 75902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75902=edit Bug 12395: Display created_by even if firstname is missing on receiving On receiving orders, "no name" was displayed if the firstname of creator was not filled. The surname should be displayed. Signed-off-by: Paola Rossi Signed-off-by: Séverine QUEUNE Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Julian Maurice changed: What|Removed |Added Attachment #74282|0 |1 is obsolete|| --- Comment #121 from Julian Maurice --- Created attachment 75906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75906=edit Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI; Signed-off-by: Julian Maurice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
