[Koha-bugs] [Bug 20939] New: Add Authorized Values for the 008 Marc Fields within Rancor / Advanced Editor
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20939 Bug ID: 20939 Summary: Add Authorized Values for the 008 Marc Fields within Rancor / Advanced Editor Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl It would be nice to have authorized values for the 008/15-17 Place of publication, reproduction or execution(MARC Code List for Countries) loaded into the MARC bib editor? In addition, authorized values for 008/35-37 Language (MARC Code List for Languages) . It also would be nice to link those to the system preference of which languages the library currently has, as to not have them all listed. There are other drop down lists for other authorized values, but not for place of publication and language of the item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20938] New: Resetting patrons password would resend patron patron detail email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20938 Bug ID: 20938 Summary: Resetting patrons password would resend patron patron detail email Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Currently, staff can reset a patron's password in Koha. However, it would be nice to have Koha send an email with this password/patron details (as it does when registering a new patron) to the patron instead of having the staff write down and/or tell the patron the password. Due to security it would be nice if this was done without staff interaction with the actual password. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20924] News content textarea not showing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20924 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- I do not recreate the issue, works for me on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18081] [omnibus] GDPR (General Data Protection Regulation)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20605] Make possible to set patron's privacy from staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20605 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20937] PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937 --- Comment #1 from Nick Clemens --- Created attachment 76044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76044=edit Bug 20937: Truncate items for print notices when user has an email To test: 1 - Set PrintNotciesMaxLines to 1 2 - Checkout 2 (or more) items to a patron and make them overdue to trigger a notice 3 - Make sure the patron has an email 4 - Make sure the notice you are sending is set to 'print' as the type 5 - Run overdue_notices.pl without the 'nomail' option 6 - Find the message and note all items have been added 7 - Apply patch 8 - Clear the message queue 9 - Re-run overdue_notices.pl 10 - Confirm the message now has only 1 item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20937] New: PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20937 Bug ID: 20937 Summary: PrintNoticesMaxLines is not effective for overdue notices with a print type specified where a patron has an email Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org The logic in the script is: if ( ( scalar(@emails_to_use) == 0 || $nomail ) && $PrintNoticesMaxLines && $j >= $PrintNoticesMaxLines ) So if we don't pass 'nomail' and the patron has an email, the items don't get kicked out. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19793] Add a field for email in batch patron modification
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9181] Add patron messaging preference to Batch Patrons Modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20847] Add the fields to the Batch Patron Modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20847 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 --- Comment #5 from Owen Leonard --- (In reply to Mason James from comment #4) > Hi Owen, this one looks quite good... > http://antenna.io/demo/jquery-bar-rating/examples/ I'm working on a solution now that uses this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10659] Upgrade jQuery star ratings plugin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10659 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20127] Label Making Solution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20127 Kyle M Hall changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Kyle M Hall --- (In reply to Katrin Fischer from comment #1) > This sounds like extensive functionality planned. Why a plugin and not a > solution within Koha? Because it wouldn't fit besides the existing label > editor? Maybe it could use a part of it like the batch process? We also have > the quick label printing where a little of that is possible, but not quite. > But they are formatted to be changed by CSS easily. That is correct. The solution we've come up with needs to handle label sheets with multiple sizes of labels. We've created a plugin that generates labels using HTML and CSS, rather than generating PDFs. I decided to go the plugin route do to the radical difference in functionality and the ability to react to the need for changes. Once the plugin can be considered 'stable' I would like to get community consideration on integrating the plugin functionality into Koha proper. I think the biggest consideration is that all the power this label printer plugin comes with is at the cost of simplicity. I think we'd need to keep the existing label maker as well. I don't think there would be an easy upgrade path. https://github.com/bywatersolutions/koha-plugin-label-maker -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20936] New: Holds History for patrons in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Bug ID: 20936 Summary: Holds History for patrons in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: ev...@mckinneytexas.org QA Contact: testo...@bugs.koha-community.org I think it would be very nice to add the "Hold History" for the patrons to access in the OPAC. I don't know if the bug to add it to the staff site would be useful or not but here it is. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14919 Ed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 --- Comment #1 from Jonathan Druart --- Created attachment 76043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76043=edit Bug 20934: Fix display of old checkouts in the checkout history page Again a regression caused by commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] GetBiblioIssues does a union all with issues and old_issues, so we should old_issues as well. To make the join on the items table we need to define the item and patron methods. For consistency the relationships have been redefined (item instead of itemnumber, borrower instead of borrowernumber) in the DBIx::Class definition. This is not perfect but I think the best way to provide an easy to backport patch. It highlights that we need improvements in this area. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 --- Comment #7 from Jonathan Druart --- Patch amended, td tag was not closed! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 Jonathan Druart changed: What|Removed |Added Attachment #76027|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 76042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76042=edit Bug 20899: Fix patron's name display This is a follow-up for commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] We should use patron-title.inc to display (or hide) patron's info on the checkout history view Test plan: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is showing. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #2 from Owen Leonard --- Created attachment 76041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76041=edit Screenshot showing system preferences search results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #1 from Owen Leonard --- Created attachment 76040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76040=edit Screenshot showing system preferences filtered using in-page filter -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] New: Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Bug ID: 20935 Summary: Redesign system preferences interface Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Created attachment 76039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76039=edit Screenshot showing system preferences standard view I think the system preferences page could use some work to make it more readable. My proposal does this: - Restructure the preferences list as a , with the preference name as the and the description as the . - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18623] Send notification on creation of manual invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18623 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 Jonathan Druart changed: What|Removed |Added Blocks||20934 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 [Bug 20934] Biblio checkout history shows only current checkout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Jonathan Druart changed: What|Removed |Added Depends on||20899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 [Bug 20899] Patron name not showing on issuehistory.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9302] Add ability to merge patron records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9302 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10047] Cataloguing search maybe useless?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 Barbara Johnson changed: What|Removed |Added CC||barbara.johnson@bedfordtx.g ||ov --- Comment #14 from Barbara Johnson --- Our catalogers use the cataloguing search (/cataloguing/addbooks.pl) on a daily basis. We're able to easily find our records at the top of the list. We don't really pay any attention to the records in the reservoir. For me, the display at cataloguing search (/cataloguing/addbooks.pl is cleaner. It displays less information making it easier for me to detect the records I want to work with. Also, I do much less scrolling since I don't have to look at a longer display for each record that includes the items. Personally, I don't want it to go away. Maybe it could be a system preference to turn on/off. Or maybe libraries that don't want to see it could hide the buttons and links with some css/jquery. Just my two cents. Barbara Johnson -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Keywords||rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Jonathan Druart changed: What|Removed |Added Keywords|Academy |release-notes-needed --- Comment #70 from Jonathan Druart --- Thanks Aleisha for your quick follow-up, very appreciated. Take a look at the 2 last follow-ups I have attached, they fixed few more things and remove duplication of code. You should also make sure your commit messages fit the coding guidelines (https://wiki.koha-community.org/wiki/Commit_messages#Examples), maybe you should update your qa-test-tools repo, there are new checks to catch that. This new enhancement is well polished and the code is easy to read. Congrats! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17656] Irregularities in serial prediction pattern are planned only for current subscription
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17656 --- Comment #77 from Koha Team Lyon 3 --- Hello Alex I tested again but I don't see any change about what Joseph Moravec told about nor about jumping checkboxes. Am I missing something ? Olivier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20918] left-side navigation broken on the checkout history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918 Josef Moravec changed: What|Removed |Added Attachment #75999|0 |1 is obsolete|| --- Comment #4 from Josef Moravec --- Created attachment 76038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76038=edit Bug 20918: Fix left-side navigation on the checkout history page commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] Removed: -biblionumber => $biblionumber, # required for left-side navigation But did not deal with the side-effects. Test plan: When you are on the "Checkout history" page (/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=42), the left-side navigation is broken if this patch is not applied, the biblionumber is not set. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20918] left-side navigation broken on the checkout history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #69 from Jonathan Druart --- Created attachment 76037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76037=edit Bug 17698: Do not send pending_checkout_notes from all circ scripts It's safer to send what we need from C4::Auth it's needed from a whole module. The SELECT COUNT(*) query will only be done when needed (so not made from scripts outside of circ) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698
--- Comment #67 from Jonathan Druart
---
Created attachment 76035
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76035=edit
Bug 17698: (follow-up) Fixing things in Comment 57
3. In the JS console: "ReferenceError: $ is not defined", I did not
investigate it.
Where do you see this in the console? I cannot recreate on opac-user.pl
or on circ/checkout-notes.pl.
5. The alert id=error is displayed then hide in JS, but it's then
displayed half a second. We should hide it by default (css)
Fixed in this patch
6. I would move the "mark seen" and "mark not seen" buttons at the
top of the table
Fixed in this patch
8. Cursor on "Select all" and "Clear all" links must be adjusted
Fixed in this patch
9. $(".btn-xs").click(function(event){
The selector should be $("button.seen, button.notseen"), you
do not want to apply this function to all other btn-xs on
the page (maybe there are only two for now, but who knows
later?)
Fixed in this patch
12. Important: When a note is updated, it's still marked as
seen. Is it the expected behavior?
I don't see this behaviour. When a note is updated it is
marked as not seen.
opav/svc/checkout_notes:79: $issue->set({ notedate =>
dt_from_string(), note => $clean_note, noteseen => 0
})->store;
13. What will happen when hundred of notes will be on this
table? Not blocker but we will need a "hide seen" buttons to
filters the already seen notes.
Added in this patch
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #68 from Jonathan Druart --- Created attachment 76036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76036=edit Bug 17698: (QA follow-up) few more things 1. body tag was missing 2. make "Date" column sortable correctly 3. remove CDATA and type="text/javascript" 4. Handle server-side errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #66 from Jonathan Druart --- Created attachment 76034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76034=edit Bug 17698: (QA follow-up) Fix minors design issues This patch includes some changes required on comment 57: 1. Bad resolution conflict, permission self_checkout is re-add 2. The IGNORE modifier is missing in the INSERT statement 4. When I hit /circ/checkout-notes.pl from the side bar, the page displays "Checkout notes", nothing else. We should add "There is no checkout notes". 7. I would display the table on the confirmation screen as well 10. html filters are missing 11. span element should surround translatable string, to help translators 14. patron-title.inc must be used to display patron's info Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #65 from Jonathan Druart --- Created attachment 76033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76033=edit Bug 17698: (follow-up) Rebase and schema update Setting to signed off. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #64 from Jonathan Druart --- Created attachment 76032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76032=edit Bug 17698: (QA follow-up) Changes to use Asset TT plugin (bug 20538) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #63 from Jonathan Druart --- Created attachment 76031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76031=edit Bug 17698: (follow-up) Fixing some small issues Fixing the comments in Comment 42 Ready to test Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 --- Comment #62 from Jonathan Druart --- Created attachment 76030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76030=edit Bug 17698: (follow-up) Koha Objects, access borrower through patron sub See Comment 27 This is ready to be tested. Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698
--- Comment #61 from Jonathan Druart
---
Created attachment 76029
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76029=edit
Bug 17698: (follow-up) Changing to Koha Objects style, adding circ sidebar
Marcel, can you please have a look at this patch. I tried to implement
the change
my @notes = $schema->resultset('Issue')->search({ 'me.note' => { '!=', undef }
}, { prefetch => [ 'borrower', { item => 'biblionumber' } ] });
to
my @notes = Koha::Checkouts->search({ 'me.note' => { '!=', undef } }, {
prefetch => [ 'borrower', { item => 'biblionumber' } ] });
but am having problems on the template side. I can access the item and
biblio information about the issue, but not the borrower information,
even though the query is definitely pulling it correctly. Any
suggestions or ideas as to why this breaks?
This patch also adds the implementation of the circSidebar.
Signed-off-by: Brendan Gallagher
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Jonathan Druart changed: What|Removed |Added Attachment #75837|0 |1 is obsolete|| Attachment #75838|0 |1 is obsolete|| Attachment #75839|0 |1 is obsolete|| Attachment #75840|0 |1 is obsolete|| Attachment #75841|0 |1 is obsolete|| Attachment #75842|0 |1 is obsolete|| Attachment #76011|0 |1 is obsolete|| Attachment #76012|0 |1 is obsolete|| --- Comment #60 from Jonathan Druart --- Created attachment 76028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76028=edit Bug 17698: Make patron notes show up on staff dashboard This patch adds a user permission for managing issue notes, and a 'noteseen' column to the issues table. To test: 1) Apply Bug 14224 first 2) Apply this patch, update database, rebuild schema. 3) Restart koha-common and memcached 4) Turn on AllowCheckoutNotes syspref if haven't already 5) Issue two items to two different users (one item each) 6) Log into the OPAC as one of the users and add an issue note to their issue 7) Log out and log back into the OPAC as the other user 8) Disable Javascript 9) Refresh opac-user.pl 10) Leave a checkout note on their issue 11) Enable javascript and log into the Staff Client as a superlibrarian user 12) Go to your user's account and edit their permissions to have everything ticked EXCEPT circulate->manage checkout notes. 13) Go to main intranet page. There should be no message saying 'checkout notes pending'. 14) Go to circulation home page. There should be no link to Checkout notes. 15) Go back to user's permissions and tick circulate->manage checkout notes. 16) Go back to main intranet page. There should now be a message at the bottom saying 'Checkout notes pending: 2' 17) Go to circulation home page. There should be a link to Checkout notes with a 2 next to it. Click this link 18) Attempt to mark an checkout note as seen. This should update the status of the checkout note to 'seen' and disable to 'mark as seen' button while enabling the 'mark as not seen' button. 19) Test both buttons with both issues. 20) Test select all and clear all buttons 21) Confirm that buttons at the bottom are only enabled if a checkbox is checked 22) Try selecting both issues and using the buttons at the bottom to mark multiple issue notes at once. 23) Confirm the barcode link to the item works as expected. 24) Confirm the cardnumber link to the user works as expected. 25) Confirm all table details show correctly. Sponsored-by: Catalyst IT Signed-off-by: Josef Moravec Followed test plan, works as expected Signed-off-by: Marc Véron Signed-off-by: Brendan Gallagher Signed-off-by: Jonathan Druart Amended patch: Remove self-checkout permissions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20918] left-side navigation broken on the checkout history page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20918 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20934] Biblio checkout history shows only current checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Josef Moravec changed: What|Removed |Added Depends on||18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Josef Moravec changed: What|Removed |Added Blocks||20934 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 [Bug 20934] Biblio checkout history shows only current checkout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20934] New: Biblio checkout history shows only current checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Bug ID: 20934 Summary: Biblio checkout history shows only current checkout Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To reproduce: 1) Checkout an item to a patron 2) Go to the biblio record for this item and show checkouts history - you see the current checkout 3) Check in the item back 4) Repeat 2), you will see there is not any checkout in checkouts history for this biblio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 Josef Moravec changed: What|Removed |Added Attachment #75998|0 |1 is obsolete|| --- Comment #5 from Josef Moravec --- Created attachment 76027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76027=edit Bug 20899: Fix patron's name display This is a follow-up for commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] We should use patron-title.inc to display (or hide) patron's info on the checkout history view Test plan: Issue an item, go to the biblio, click the circulation history for this tab. Note that the patron's name is showing. Signed-off-by: Martin Renvoize Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 Josef Moravec changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20899] Patron name not showing on issuehistory.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20933] New: Modifying the Advanced Prediction Pattern in Serials
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20933 Bug ID: 20933 Summary: Modifying the Advanced Prediction Pattern in Serials Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Within the Serials Module, when modifying the Advanced prediction pattern- the user has to click modify pattern before making changes. When this modification is made, then the pattern must be saved. Couldn't the change be made without having to click modify? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20932] New: Add multiple items should have a maximum number to be able to add at a time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20932 Bug ID: 20932 Summary: Add multiple items should have a maximum number to be able to add at a time Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: n...@bywatersolutions.com Reporter: ke...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: ro...@catalyst.net.nz Currently, when adding items to an existing record- the option is to add item, duplicate or add multiple items. When the option is chosen for adding multiple items, there is a box displayed that a quantity can be entered. If the number is large (above 100) there is a pop-up message confirming this many. In addition to the pop-up, it would be helpful for a system preference to set a maximum number for this feature -as it is with Batch Item Modification / Batch Item Deletion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20285] Lost item refund won't always pay down lost item fee first
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20285 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20262] Add ability to refund lost item fees without creating credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20262 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2454] Improve display of credits on pay fines tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2454 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20703] Add ability to void any credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20703 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Nick Clemens changed: What|Removed |Added Summary|Merge deleted* tables with |Merge deleted biblio, |their "alive" cousins |biblioitems, ||biblio_metadata, and items ||tables with their "alive" ||cousins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9525] group floating rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 BASE Library Consortium changed: What|Removed |Added CC||baselibrary.consortium@nhs. ||net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 BASE Library Consortium changed: What|Removed |Added CC||baselibrary.consortium@nhs. ||net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76021|0 |1 is obsolete|| --- Comment #34 from Tomás Cohen Arazi --- Created attachment 76026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76026=edit Bug 18322: (follow-up) Use authorized value labels Rather than using the raw ccode's use the labels as defined in the authorized values. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76009|0 |1 is obsolete|| --- Comment #33 from Tomás Cohen Arazi --- Created attachment 76025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76025=edit Bug 18322: Update xslt for NORMARC and UNIMARC Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76008|0 |1 is obsolete|| --- Comment #32 from Tomás Cohen Arazi --- Created attachment 76024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76024=edit Bug 18322: (follow-up) Add generated xsl Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76007|0 |1 is obsolete|| --- Comment #31 from Tomás Cohen Arazi --- Created attachment 76023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76023=edit Bug 18322: Add a facet for ccode fields to Zebra This patch adds the index definitions for zebra faceting of ccode in koha for marc21, normarc and unimarc. We also add lines to the templates to expose the new facet and enable non-zebra faceting for ccode too. Signed-off-by: David Cook Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16530] Add a circ sidebar navigation menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 Jonathan Druart changed: What|Removed |Added Blocks||20931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931 [Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is turned on -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20931] New: JS error "ReferenceError: $ is not defined" when CircSidebar is turned on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931 Bug ID: 20931 Summary: JS error "ReferenceError: $ is not defined" when CircSidebar is turned on Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org Depends on: 16530, 19700 If CircSidebar is set and you hit /cgi-bin/koha/circ/returns.pl, you will get "ReferenceError: $ is not defined" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16530 [Bug 16530] Add a circ sidebar navigation menu https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700 [Bug 19700] Move template JavaScript to the footer: Some circulation pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19700] Move template JavaScript to the footer: Some circulation pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700 Jonathan Druart changed: What|Removed |Added Blocks||20931 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20931 [Bug 20931] JS error "ReferenceError: $ is not defined" when CircSidebar is turned on -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17698] Make patron notes show up on staff dashboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17698 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20760] Advanced Cataloging Editor - Rancor - AuthorisedValues are incorrectly fetched
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20760 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Makes total sense and works as prescribed.. a simple patch really, passing qa. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is debarred
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247 --- Comment #14 from Victor Grousset/tuxayo --- (In reply to Jonathan Druart from comment #13) > before: > https://screenshots.firefox.com/vYnI1v89SSv9DA8M/pro.kohadev.org > after: > https://screenshots.firefox.com/CLXPhG1xjMNn4yUS/pro.kohadev.org The screenshots expired (default 14 days) but you can set a expiration to no limit. Or store them in bugzilla. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20922] Koha::Number::Price must not be used in updatedatabase.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20922 Martin Renvoize changed: What|Removed |Added Attachment #76010|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 76022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76022=edit Bug 20922: Remove use of Koha::Number::Price in updatedatabase.pl Koha::Number::Format->round use Number::Format->round with a precision=2 We should use it directly instead of Koha::* modules. It will avoid the DB entry to fail because schema changes. >From the koha-devel list: http://lists.koha-community.org/pipermail/koha-devel/2018-June/044608.html 16.06.00.042 Upgrade to 16.06.00.041 done (Bug 14629 - Add aggressive ISSN matching feature equivalent to the aggressive ISBN matcher) DBD::mysql::st execute failed: Unknown column 'me.p_sep_by_space' in 'field list' [for Statement "SELECT `me`.`currency`, `me`.`symbol`, `me`.`isocode`, `me`.`timestamp`, `me`.`rate`, `me`.`active`, `me`.`archived`, `me`.`p_sep_by_space` FROM `currency` `me` WHERE ( `active` = ? )" with ParamValues: 0=1] at /usr/local/share/perl/5.24.1/DBIx/Class/Storage/DBI.pm line 1836. DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'me.p_sep_by_space' in 'field list' at /inlibro/git/koha-csf-prod-inlibro/Koha/Objects.pm line 209 Basically, the update code uses Koha::Number::Price, which in full modern object mode goes for its newly added *p_sep_by_space* _in the 18.05 code_. But the DB doesn't have it yet (it comes with 17.12.00.022). Signed-off-by: Blou Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 --- Comment #1 from Martin Renvoize --- I intend to work on this but won't do so until after 20271 is in as it will drastically affect the code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11983] code to select patrons to purge needs to be centralized
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Martin Renvoize changed: What|Removed |Added Depends on||20271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 [Bug 20271] Merge deleted* tables with their "alive" cousins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20271] Merge deleted* tables with their "alive" cousins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize changed: What|Removed |Added Blocks||11983 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 [Bug 11983] code to select patrons to purge needs to be centralized -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20928] Checkout status not showing patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20928 David Gustafsson changed: What|Removed |Added CC||glask...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20930] Handle YAML type system preferences as parsed references
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Ere Maijala changed: What|Removed |Added CC||ere.maij...@helsinki.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20930] Handle YAML type system preferences as parsed references
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 Lari Taskula changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20664 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Lari Taskula changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20930 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20930] New: Handle YAML type system preferences as parsed references
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930
Bug ID: 20930
Summary: Handle YAML type system preferences as parsed
references
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs@lists.koha-community.org
Reporter: lari.task...@jns.fi
QA Contact: testo...@bugs.koha-community.org
Currently, C4::Context->preference('YAMLpref') returns a string that needs to
be parsed by any code using the preference.
My suggestion is to return a parsed version instead (a hash/array ref or a
string) and using the syspref cache with the parsed value. Like this, we could:
- centralize parsing of YAML system preferences
- optimize use of system preference cache by caching the parsed version
instead. Parse once and store in cache; no need to re-parse on each call!
We could centralize this functionality into Koha::Config::SysPref->value()
(used by C4::Context->preference). Use database column systempreferences.type
with value of "yaml" to trigger this functionality in "value()"-method.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Victor Grousset/tuxayo changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17247 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17247] ILS-DI HoldTitle and HoldItem should check if patron is debarred
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17247 Victor Grousset/tuxayo changed: What|Removed |Added CC||victor.grous...@biblibre.co ||m See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=17229 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Victor Grousset/tuxayo changed: What|Removed |Added Severity|minor |normal CC||victor.grous...@biblibre.co ||m --- Comment #16 from Victor Grousset/tuxayo --- Changed from minor to normal as bypassing expiration check (important circulation rule) is bad -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #20 from Martin Renvoize --- Ignore the first comment in that review.. you've already changed it in the followup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385
--- Comment #19 from Martin Renvoize ---
Comment on attachment 74660
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74660
Bug 17385: Add custom export XSLT
Review of attachment 74660:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=17385=74660)
-
Generally looks good with a few minor code comments added for review.
::: C4/XSLT.pm
@@ +197,5 @@
> $xslfilename ||= C4::Context->preference($xslsyspref);
> $lang ||= C4::Languages::getlanguage();
>
> +if ($xslsyspref eq "XSLTCustomExport") {
> +my $dir;
The code used to defined $dir in CustomXSLTExportList which does the same thing
is cleaner.. why not use that here too... or even factor it out and use the
same factored out routine for both to keep it DRY?
@@ +370,5 @@
> }
>
> +=head2 CustomXSLTExportList
> +
> + Returns list of file for custom xslt conversion
Please add accepted parameters (i.e. $opac) to the POD section and note their
required status and what they accept (string, int, etc)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #8 from Ere Maijala --- Thanks for the feedback. I think I'll spin that off as a separate bug and remove the caching thing here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #30 from Martin Renvoize --- Good spot, thanks Tomás! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18322] Add facets for ccode to zebra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18322 --- Comment #29 from Martin Renvoize --- Created attachment 76021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76021=edit Bug 18322: (followup) Use authorized value labels Rather than using the raw ccode's use the labels as defined in the authorized values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #7 from Lari Taskula --- (In reply to Lari Taskula from comment #6) > Fails t/db_dependent/Items.t This is due to caching parsed YAML from OpacHiddenItems. Cache does not cleared between tests when OpacHiddenItems changes. Instead of additionally caching parsed YAML of this system preference, would it be better for Koha to handle YAML system preferences as parsed by default? This would require some changes to Koha core but I guess it would benefit all features using system preferences represented in YAML. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17989] Stricter control on source directory for html templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17989 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20917] Improve email functionality relating to ILL requests
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917 Andrew Isherwood changed: What|Removed |Added Blocks||20923 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923 [Bug 20923] Merging backend status graph into main status graph incorrect use of grep -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20923] Merging backend status graph into main status graph incorrect use of grep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923 --- Comment #1 from Andrew Isherwood --- Created attachment 76020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76020=edit Bug 20923: Fix usage of grep This patch implements the fix described in the bug description. It is impossible to test without the work that will be added to bug 20917. Therefore a dependency will be added for that bug and a test plan will be added here when that work is done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20923] Merging backend status graph into main status graph incorrect use of grep
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20923 Andrew Isherwood changed: What|Removed |Added Depends on||20917 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20917 [Bug 20917] Improve email functionality relating to ILL requests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Lari Taskula changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Lari Taskula --- Fails t/db_dependent/Items.t # Failed test 'For OPAC, the pref OpacHiddenItems should have been take into account. Only items with homebranch ne CPL should have been embedded' # at t/db_dependent/Items.t line 631. # got: '8' # expected: '2' # Failed test 'For OPAC, If all items are hidden, no item should have been embedded' # at t/db_dependent/Items.t line 642. # got: '8' # expected: '0' # Looks like you failed 2 tests of 7. # Failed test 'C4::Biblio::EmbedItemsInMarcBiblio' # at t/db_dependent/Items.t line 649. Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm line 1729. Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm line 1729. Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm line 1729. Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm line 1729. Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm line 1729. Use of uninitialized value in string ne at /home/koha/kohaclone/C4/Items.pm line 1729. # Failed test 'items.barcode is not mapped anymore, so the DB column has not been updated' # at t/db_dependent/Items.t line 726. # got: undef # expected: 'a barcode' # Looks like you failed 1 test of 4. t/db_dependent/Items.t .. 11/14 # Failed test 'C4::Items::_build_default_values_for_mod_marc' # at t/db_dependent/Items.t line 731. # Looks like you failed 2 tests of 14. t/db_dependent/Items.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/14 subtests Test Summary Report --- t/db_dependent/Items.t (Wstat: 512 Tests: 14 Failed: 2) Failed tests: 10-11 Non-zero exit status: 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20929] koha-dump should not pass a --password argument to mysqldump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20929 solaris.sm...@gmail.com changed: What|Removed |Added Attachment #76018|0 |1 is obsolete|| --- Comment #2 from solaris.sm...@gmail.com --- Created attachment 76019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76019=edit Use env variable instead of --password argument for mysqldump -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20929] koha-dump should not pass a --password argument to mysqldump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20929 solaris.sm...@gmail.com changed: What|Removed |Added Attachment #76017|0 |1 is obsolete|| --- Comment #1 from solaris.sm...@gmail.com --- Created attachment 76018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76018=edit Use env variable instead of --password argument for mysqldump (without spurious white space changes) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20929] New: koha-dump should not pass a --password argument to mysqldump
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20929 Bug ID: 20929 Summary: koha-dump should not pass a --password argument to mysqldump Change sponsored?: --- Product: Koha Version: master Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: solaris.sm...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net Created attachment 76017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76017=edit Use env variable instead of --password argument for mysqldump koha-dump currently passes a password as a CLI argument to mysqldump, which results in the following warning: mysqldump: [Warning] Using a password on the command line interface can be insecure. Depending on how a server is configured, this results in emails being sent to the administrator every time the cron job runs. It's trivial to change this to pass an environment variable instead, so as not to trigger the warning. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
