[Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Nick Clemens changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||k...@bywatersolutions.com, ||m.de.r...@rijksmuseum.nl, ||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 --- Comment #1 from Nick Clemens --- Created attachment 76475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76475=edit Bug 21006: Add GetMarcItems method and refactor GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21006] GetMarcBiblio is slow for records with many bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21006] New: GetMarcBiblio is slow for records with many bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Bug ID: 21006 Summary: GetMarcBiblio is slow for records with many bibs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: n...@bywatersolutions.com Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Some libraries have serials that have large numbers of items attached to the record, this can create problems when exporting/harvesting the records. One of the problems seems to be GetMarcBiblio which makes several db requests per item, many of these can be removed by adding a GetMarcItems routine to fetch several items rather than iterating over each biblionumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21005] New: Report wizards fatal errors if no radio buttons selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21005 Bug ID: 21005 Summary: Report wizards fatal errors if no radio buttons selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: dc...@prosentient.com.au QA Contact: testo...@bugs.koha-community.org Some report wizards have radio buttons selected by default and some do not. If someone tries to run a report wizard that has no radio buttons selected, fatal errors are generated. This can be fixed just be pre-selecting radio buttons on those reports without them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20467] Add ability to batch add items to a course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19915] Inventory tool doesn't use cn_sort for callnumber ranges
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19915 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Tomás Cohen Arazi changed: What|Removed |Added Depends on||21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Tomás Cohen Arazi changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21004 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21004] Use modal to add and edit notes on receiving orders/shipments page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20969 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21004] New: Use modal to add and edit notes on receiving orders/shipments page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21004 Bug ID: 21004 Summary: Use modal to add and edit notes on receiving orders/shipments page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org See bug 20969, but for parcel.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 --- Comment #6 from Katrin Fischer --- Thx, Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20969] Use modal to add and edit notes from basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20969 Katrin Fischer changed: What|Removed |Added Attachment #76438|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 76474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76474=edit Bug 20969: (follow-up) Move focus to textarea whe modal is shown This follow-up adds code to move the mouse cursor to the modal window's textarea when the modal is displayed. To test, apply the patch and test the process of adding/editing notes on an order. Confirm that the focus moves to the textarea when the note editor modal window is shown. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20991] Error will reset category when editing a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991 Katrin Fischer changed: What|Removed |Added Attachment #76457|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 76473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76473=edit Bug 20991: Do not lost patron's category when editing a patron If there is an error in the edit patron form the patron's category is lost. This seems to be a long standing bug. Test plan: - Edit an existing patron - Change the patron category to a category that triggers the error that the user is not in the right age range for that new category - Save, error is triggered => Without this patch the patron category has been reset You should also test different ways to edit/add a patron (quick add, step 1) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20991] Error will reset category when editing a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20467] Add ability to batch add items to a course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 --- Comment #30 from Katrin Fischer --- Created attachment 76472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76472=edit Bug 20467: (QA follow-up) Display error if no or invalid course id is passed Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20467] Add ability to batch add items to a course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Katrin Fischer changed: What|Removed |Added Attachment #73705|0 |1 is obsolete|| --- Comment #29 from Katrin Fischer --- Created attachment 76471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76471=edit Bug 20467: Remove useless use statements Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20467] Add ability to batch add items to a course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 --- Comment #28 from Katrin Fischer --- Created attachment 76470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76470=edit Bug 20467: (QA follow-up) Filter barcodes, remove selector code, use template plugins Removes selector code as batch changes cannot have a previous selection. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20467] Add ability to batch add items to a course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 --- Comment #27 from Katrin Fischer --- Created attachment 76469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76469=edit Bug 20467: (QA follow-up) Add Branches plugin to template Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20467] Add ability to batch add items to a course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Katrin Fischer changed: What|Removed |Added Attachment #73239|0 |1 is obsolete|| --- Comment #26 from Katrin Fischer --- Created attachment 76468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76468=edit Bug 20467: Add ability to batch add items to a course Some librarians have requested the ability to batch add items to a course using the same settings for all items. Test Plan: 1) Apply this patch 2) Create a new course 3) Click the new 'Batch add reserves' button 4) Enter some valid and invalid barcodes in the text box, add some settings 5) Submit the batch, note the results list added items and invalid barcodes 6) Note the valid items were added to the course Signed-off-by: Séverine QUEUNE Signed-off-by: Maksim Sen Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20467] Add ability to batch add items to a course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 --- Comment #25 from Katrin Fischer --- I've filed bug 21003 for the superfluous message about the existing item. It makes no sense when editing a reserve item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20467] Add ability to batch add items to a course
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20467 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=21003 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21003] New: Don't show warning when editing a reserve item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Bug ID: 21003 Summary: Don't show warning when editing a reserve item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Course reserves Assignee: k...@bywatersolutions.com Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org When editing an item in a course reserve, the following message always displays: This course already has this item on reserve. This appears out of place and should not display on edting. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10675] Remove spinelabel.css?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10675 Katrin Fischer changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer --- Agreed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Owen Leonard changed: What|Removed |Added Attachment #76455|0 |1 is obsolete|| Attachment #76456|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 76466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76466=edit Bug 20998: Only perform quicksearch if patron found with cardnumber This patch makes sure we have a patron before we try to access their branchcode and allows search to work To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error 6 - Apply patch 7 - Try the search again 8 - Success! Signed-off-by: Jonathan Druart Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 --- Comment #6 from Owen Leonard --- Created attachment 76467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76467=edit Bug 20998: Simplify the conditional statement Signed-off-by: Jonathan Druart Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #9 from Kyle M Hall --- Created attachment 76465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76465=edit Bug 20997: (follow-up) Add Koha::Account::Line->is_debit method Test plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Lines.t => Test should pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Kyle M Hall changed: What|Removed |Added Attachment #76459|0 |1 is obsolete|| Attachment #76460|0 |1 is obsolete|| Attachment #76462|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 76463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76463=edit Bug 20997: Add unit tests for Koha::Account::Line::apply This patch adds unit tests for the mentioned method. To test: - Apply this patch - Run: $ khell k$ prove t/db_dependent/Koha/Account/Lines.t => FAIL: The method is not already implemented! Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #8 from Kyle M Hall --- Created attachment 76464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76464=edit Bug 20997: Add Koha::Account::Line::apply method This patch implements the ->apply() method for account lines. It will only work on credit lines, and raise an exception otherwise. It implements ->is_credit() as well. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Lines.t => SUCCESS: Tests pass! - Check all use cases are covered by the tests - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Tomás Cohen Arazi changed: What|Removed |Added Blocks||21002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 [Bug 21002] Add Koha::Account::add_debit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Tomás Cohen Arazi changed: What|Removed |Added Depends on||20978 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 [Bug 20978] Add Koha::Account::add_credit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21000] debian/build-git-snapshot script ignores --distribution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21002] New: Add Koha::Account::add_debit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21002 Bug ID: 21002 Summary: Add Koha::Account::add_debit Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org There should be a high-level method for creating new debits, similar to Koha::Account::add_credit. It will handle creating the line, and the offset. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added Attachment #76461|0 |1 is obsolete|| --- Comment #6 from Tomás Cohen Arazi --- Created attachment 76462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76462=edit Bug 20997: (follow-up) Add Koha::Account::Line->is_debit method Test plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Lines.t => Test should pass Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #5 from Josef Moravec --- Created attachment 76461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76461=edit Bug 20997: (follow-up) Add Koha::Account::Line->is_debit method Test plan: 1) Apply this patch 2) prove t/db_dependent/Koha/Account/Lines.t => Test should pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #4 from Josef Moravec --- Created attachment 76460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76460=edit Bug 20997: Add Koha::Account::Line::apply method This patch implements the ->apply() method for account lines. It will only work on credit lines, and raise an exception otherwise. It implements ->is_credit() as well. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Lines.t => SUCCESS: Tests pass! - Check all use cases are covered by the tests - Sign off :-D Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Josef Moravec changed: What|Removed |Added Attachment #76451|0 |1 is obsolete|| Attachment #76452|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 76459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76459=edit Bug 20997: Add unit tests for Koha::Account::Line::apply This patch adds unit tests for the mentioned method. To test: - Apply this patch - Run: $ khell k$ prove t/db_dependent/Koha/Account/Lines.t => FAIL: The method is not already implemented! Signed-off-by: Josef Moravec -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Josef Moravec changed: What|Removed |Added Depends on||20978 CC||josef.mora...@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 [Bug 20978] Add Koha::Account::add_credit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Josef Moravec changed: What|Removed |Added Blocks||20997 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 [Bug 20997] Add Koha::Account::Line::apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21001] New: OpenLibrary book covers broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21001 Bug ID: 21001 Summary: OpenLibrary book covers broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org OpenLibrary book covers don't appear on the search results or detail page in the OPAC. The console shows an error, "SyntaxError: missing ) after argument list books:1:16246" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999 --- Comment #1 from Owen Leonard --- Created attachment 76458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76458=edit Bug 20999: Remove invalid 'style="block"' from OPAC templates This patch removes an invalid attribute from OPAC template markup. There should be no visible change to the OPAC. To test, apply the patch and confirm that the following pages still look correct when using various cover image sources: Coce, Amazon, Google: - Bibliographic detail page (opac-detail.pl) - The shelf browser - Catalog search results - Recent comments -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20999] Remove invalid 'style="block"' from OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19297 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19297] Standardize "can place hold" calculations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19297 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=20985 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20991] Error will reset category when editing a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20991] Error will reset category when editing a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20991] Error will reset category when editing a patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20991 --- Comment #1 from Jonathan Druart --- Created attachment 76457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76457=edit Bug 20991: Do not lost patron's category when editing a patron If there is an error in the edit patron form the patron's category is lost. This seems to be a long standing bug. Test plan: - Edit an existing patron - Change the patron category to a category that triggers the error that the user is not in the right age range for that new category - Save, error is triggered => Without this patch the patron category has been reset You should also test different ways to edit/add a patron (quick add, step 1) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #87 from David Gustafsson --- Thanks. Since this is a rather big change there probably are some minor undiscovered issues with the current patch and we are still running with the prior version in production. The tests are pretty exhaustive though, so I would be surprised if there are any major undiscovered problems. Usability and documentation is probably where there is still most room for improvement and some feedback would be useful to improve on those. But should more or less be ready for sign-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Jonathan Druart changed: What|Removed |Added Depends on||17829 --- Comment #4 from Jonathan Druart --- Upping severity, that's clearly critical for installations with IndependentBranches. I have added a follow-up to simplify the conditional statement. Caused by commit 2b90ea2cb0e5e976de7ddef0151ae83d8ac578e6 Bug 17829: Move GetMember to Koha::Patron Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 17829] Move GetMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 Jonathan Druart changed: What|Removed |Added Blocks||20998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Jonathan Druart changed: What|Removed |Added Attachment #76453|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 76455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76455=edit Bug 20998: Only perform quicksearch if patron found with cardnumber This patch makes sure we have a patron before we try to access their branchcode and allows search to work To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error 6 - Apply patch 7 - Try the search again 8 - Success! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Jonathan Druart changed: What|Removed |Added Severity|major |critical CC||jonathan.dru...@bugs.koha-c ||ommunity.org Keywords||rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 --- Comment #3 from Jonathan Druart --- Created attachment 76456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76456=edit Bug 20998: Simplify the conditional statement Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21000] New: debian/build-git-snapshot script ignores --distribution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21000 Bug ID: 21000 Summary: debian/build-git-snapshot script ignores --distribution Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: jchara...@cmaisonneuve.qc.ca QA Contact: testo...@bugs.koha-community.org CC: mi...@abunchofthings.net Calling debian/build-git-snapshot with the --distribution switch has no effect. It seems that the variable isn't passed to the adjust_debian_changelog() function. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Jonathan Druart changed: What|Removed |Added Blocks||20903 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 [Bug 20903] Print payment receipt on child patron could end with server error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 Jonathan Druart changed: What|Removed |Added Depends on||19921 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- Caused by commit 585453fe20417779be84258b60d3d652d8e170e1 Bug 19921: Fix update child when only one adult patron category exist Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 [Bug 19921] Error when updating child to adult patron on system with only one adult patron category -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 Jonathan Druart changed: What|Removed |Added Attachment #76424|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 76454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76454=edit Bug 20903: Remove unnecessary category code parameters Test plan: 0) Do no apply the patch 1) Have only one adults patrons category defined 2) Add a fine to child patron and pay it 3) Try to print the payment receipt (file printfeercpt.pl) 4) You see only ISE 5) Apply the patch 6) Try the printing again 7) Now you should see right receipt Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20903] Print payment receipt on child patron could end with server error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20903 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20999] New: Remove invalid 'style="block"' from OPAC templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20999 Bug ID: 20999 Summary: Remove invalid 'style="block"' from OPAC templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org There are a few instances of the invalid 'style="block"' attribute in the OPAC templates. They should be removed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||bar...@bywatersolutions.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10675] Remove spinelabel.css?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10675 --- Comment #2 from Owen Leonard --- I think it's good to have default styling always in place. intranetusercss can be used to override whatever is in spinelabel.css. In my opinion this bug would be WONTFIX. On the other hand, we could add a new system preference which was specifically for spine label CSS. If that's what is wanted the title of the bug should be revised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 --- Comment #1 from Nick Clemens --- Created attachment 76453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76453=edit Bug 20998: Only perform quicksearch if patron found with cardnumber This patch makes sure we have a patron before we try to access their branchcode and allows search to work To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error 6 - Apply patch 7 - Try the search again 8 - Success! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20998] New: Non superlibrarians cannot search for patrons using the quicksearch at the top
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20998 Bug ID: 20998 Summary: Non superlibrarians cannot search for patrons using the quicksearch at the top Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: n...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com To recreate: 1 - Enable 'IndependentBranches' 2 - Setup a patron with all permissions, but not a superlibrarian 3 - Login to staff client as that patron 4 - Click 'Patrons' in the toolbar and try a search 5 - Internal server error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 76452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76452=edit Bug 20997: Add Koha::Account::Line::apply method This patch implements the ->apply() method for account lines. It will only work on credit lines, and raise an exception otherwise. It implements ->is_credit() as well. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account/Lines.t => SUCCESS: Tests pass! - Check all use cases are covered by the tests - Sign off :-D -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 76451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76451=edit Bug 20997: Add unit tests for Koha::Account::Line::apply This patch adds unit tests for the mentioned method. To test: - Apply this patch - Run: $ khell k$ prove t/db_dependent/Koha/Account/Lines.t => FAIL: The method is not already implemented! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Tomás Cohen Arazi changed: What|Removed |Added Blocks||20944 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 [Bug 20944] Add routes to add credits and debits to a patron's account -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20944] Add routes to add credits and debits to a patron's account
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20944 Tomás Cohen Arazi changed: What|Removed |Added Depends on||20997 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 [Bug 20997] Add Koha::Account::Line::apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20997] New: Add Koha::Account::Line::apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20997 Bug ID: 20997 Summary: Add Koha::Account::Line::apply Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org There should be a method to apply a credit to a debit. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19617] Allow 'writeoff of selected'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19617] Allow 'writeoff of selected'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19617 Kyle M Hall changed: What|Removed |Added Attachment #75702|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 76450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76450=edit Bug 19617: Allow 'writeoff of selected' This patch adds a writeoff equivilent to 'Pay selected' Test Plan: 1) Apply this patch 2) Find a patron with fines 3) On the "Pay fines" tab, select one or more fines and use the "Write off selected" button. 4) Note the fine amount you used was written off for those fines. Signed-off-by: Kyle M Hall Signed-off-by: Martha Fuerst -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 Kyle M Hall changed: What|Removed |Added Attachment #76405|0 |1 is obsolete|| Attachment #76406|0 |1 is obsolete|| Attachment #76407|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 76446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76446=edit Bug 20990: Unit tests for Koha::Account->outstanding_credits Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 --- Comment #9 from Kyle M Hall --- Created attachment 76449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76449=edit Bug 20990: Make same changes that were made to outstanding_debits Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 --- Comment #8 from Kyle M Hall --- Created attachment 76448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76448=edit Bug 20990: (follow-up) Fix test description Test plan: prove -v t/db_dependent/Koha/Account.t --> Test message of first test of subtest outtanding_credits correctly says "Outstanding credits total..." Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20990] Add Koha::Account::outstanding_credits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20990 --- Comment #7 from Kyle M Hall --- Created attachment 76447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76447=edit Bug 20990: Add Koha::Account->outstanding_credits This patch adds a method that retrieves (for a patron's account) the outstanding credits (i.e. those that haven't been applied to any debit. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the ILL requests button is wrong.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 --- Comment #4 from Martin Renvoize --- Looks much nicer than my fix . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 --- Comment #16 from Kyle M Hall --- Created attachment 76444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76444=edit Bug 20980: (follow-up) Only use UpdateStats for 'payment' and 'writeoff' This patch makes Koha::Account::add_credit record statistics logs (through C4::Stats::UpdateStats) only for the 'payment' and 'writeoff' credit types. Both credit types are whitelisted in UpdateStats, so we keep the current behaviour. Another option would've been to add new account types to the white list, but with the account offsets it seems that using the statistics table for account changes won't be useful for too long, as offsets contain the same (and more) information. To test: - Apply the patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 --- Comment #15 from Kyle M Hall --- Created attachment 76443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76443=edit Bug 20980: Make mancredit.pl use Koha::Account::add_credit This patch makes creating a manual credit from the UI record the account offset as 'Manual Credit', and properly set account_offsets.credit_id instead of account_offsets.debit_id. To test: - Create a manual credit (of 'Credit' type) for a known patron (acevedo?) - Run: $ sudo koha-mysql kohadev > SELECT * FROM account_offsets; => FAIL: The account offset for the manual credit has type=Manual Debit, credit_id=NULL and debit_id=accountlines_id - Run the atomic update: $ updatedatabase - Run: $ sudo koha-mysql kohadev > SELECT * FROM account_offsets; => SUCCESS: The account offset has been corrected and now has type=Manual Credit, credit_id=accountlines_id and debit_id=NULL - Create a new manual credit (of 'Forgiven' type) for a known patron - Run: $ sudo koha-mysql kohadev > SELECT * FROM account_offsets; => SUCCESS: The account offset has been stored correctly as a credit! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 --- Comment #17 from Kyle M Hall --- Created attachment 76445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76445=edit Bug 20980: (follow-up) Offset name consistency This patch makes 'credit' account types generate 'Manual Credit' offset. The original patch used 'Payment' but I think the code wants to distinguish between payments and manually added credits (otherwise they would've picked the same accounttype value, and they don't. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Kyle M Hall changed: What|Removed |Added Attachment #76401|0 |1 is obsolete|| Attachment #76402|0 |1 is obsolete|| Attachment #76403|0 |1 is obsolete|| Attachment #76404|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 76442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76442=edit Bug 20980: Add 'Manual Credit' and fix existing offsets This patch adds a new offset type 'Manual Credit'. And adds an atomic update for fixing existing offsets. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20980] Manual credit offsets are stored as debits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20980 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 18412] Show list price in foreign currency in acquisitions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18412 imelda.ben...@educampus.ie changed: What|Removed |Added CC||imelda.ben...@educampus.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #19 from Kyle M Hall --- Created attachment 76441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76441=edit Bug 20978: (follow-up) Another use case from C4::Circulation Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 --- Comment #18 from Kyle M Hall --- Created attachment 76440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76440=edit Bug 20978: Add Koha::Account::add_credit This patch adds: - Koha::Account::add_credit - A single source of truth for accounttype and offset_type values To test: - Apply the first patch - Run: $ kshell k$ prove t/db_dependent/Koha/Account.t => FAIL: Tests fail! - Apply this patch - Run: k$ prove t/db_dependent/Koha/Account.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Kyle M Hall changed: What|Removed |Added Attachment #76396|0 |1 is obsolete|| Attachment #76397|0 |1 is obsolete|| Attachment #76398|0 |1 is obsolete|| --- Comment #17 from Kyle M Hall --- Created attachment 76439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76439=edit Bug 20978: Unit tests This patch adds unit tests for Koha::Account::add_credit. Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20978] Add Koha::Account::add_credit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20978 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20962] Overhaul to notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20962 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org --- Comment #7 from George Williams (NEKLS) --- # Step 3 - option to process all print notices together: We operate a library consortium that has 44 libraries and 51 library branches. 1 of those libraries is a district with 4 branches and they would like to be able to process all print notices at their headquarters branch. Another of those libraries is a school distict with 5 branches and they would like to process all print notices at each separate branch. Work on #3 that can offer the flexibility to accommodate that scenario would be welcomed and it would probably solve Lisette's situation as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 16575] Irregular behaviour using window.print() followed by window.location.href=
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16575 Owen Leonard changed: What|Removed |Added Assignee|dc...@prosentient.com.au|oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20647] When ILL is enabled the hover effect on the ILL requests button is wrong.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20647 Owen Leonard changed: What|Removed |Added Assignee|martin.renvoize@ptfs-europe |oleon...@myacpl.org |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20970] Reformat basket information on acquisitions basket page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20970 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20935] Redesign system preferences interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
