[Koha-bugs] [Bug 18947] Unexpected Active Directory LDAP authentication failure mode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18947 --- Comment #6 from Liz Rea --- I just had to add the extra configs because of this last night lol. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20549] Avoid indexer race condition when moving item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20549 Alex Buckley changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Alex Buckley --- The bug that I wrote this patch for turned out to be a cataloging issue rather than a race condition in the execution of a reindex. The cataloging issue was causing Zebra to return two biblios when searching for the barcode of an item moved from one biblio to another. Therefore I am going to set this bug report to 'Resolved Fixed'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart --- I am currently working on moving this code the Koha namespace and I do not understand what is needed exactly here. So far we have: xxx 1 Damaged pouet peout 0 Maybe we just need a couple variable=value, right? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11405] Inventory tool enhancements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11405 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13498] 'email' templates used for printing slips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13498 Cab Vinton changed: What|Removed |Added CC||bibli...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21070] New: request.pl details links to biblio instead of moredetail.pl for that item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Bug ID: 21070 Summary: request.pl details links to biblio instead of moredetail.pl for that item Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: lisettesla...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Created attachment 76928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76928=edit detailscolumnview If someone needs to modify an item that is placed on an item level hold for someone, it seems like it would make sense for the "Details column (see detachment) barcode link to go to moredetail.pl for that item number than for it to go to the biblio page. The behavior would be more like clicking on a barcode from either the biblio page or the check-in screen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Jason Etheridge changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #38 from Jonathan Druart --- Created attachment 76927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76927=edit Bug 20287: (follow-up) Test exception DuplicateID for Koha::Patron->store -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 Jason Etheridge changed: What|Removed |Added CC||ja...@esilibrary.com Assignee|vfernan...@keep.pt |ja...@esilibrary.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14493] export_borrowers.pl - Export patron attributes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14493 --- Comment #9 from Jason Etheridge --- Created attachment 76926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76926=edit Bug 14493: export_borrowers.pl - Export patron attributes Tweaked Vitor's original patch to accomodate changes to the file. --- export_borrowers.pl changed to support patron attributes Test plan: - Use export_borrowers.pl to export all patron and all fields - The patrons extended attributes are not exported - Apply the patch - Use export_borrowers.pl with the no fields specified or with the field patron_attributes - The patrons extended attributes will be exported in one column Create by: Vitor Fernandes Sponsored by: KEEP SOLUTIONS Signed-off-by: Jason Etheridge -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #10 from Lisette Scheer --- Created attachment 76925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76925=edit Multiple Status Unknown tabs This was on BibLibre sandbox 06 both on master and with your patch applied. I created 3 suggest_status AV, made 3 purchase suggestions and assigned one to 2 of the statuses and left one pending. Each time it added a new tab, but left the status unknown tabs visible. There were the same number of status unknown tabs when I had 1 AV as when I had 3. I tried on BibLibre sandbox 07 on master and before I even added any suggest_status AV I put in a purchase suggestion and it did this again. Perhaps it is an issue with the BibLibre sandboxes? I'd try on another but those are the only ones I've been able to get to work today. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19524] Share patron lists between staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19524 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #11 from Jonathan Druart --- +logged_in_user => $loggedinuser, You should not do that, a Koha::Patron object is already passed using this variable name in C4::Auth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #37 from Jonathan Druart --- Created attachment 76924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76924=edit Bug 20287: (QA follow-up) Fix warning on undefined Signed-off-by: Tomas Cohen Arazi Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #33 from Jonathan Druart --- Created attachment 76920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76920=edit Bug 20287: Replace occurrences of ModMember in REST API Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #32 from Jonathan Druart --- Created attachment 76919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76919=edit Bug 20287: Replace occurrences of AddMember in REST API Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #34 from Jonathan Druart --- Created attachment 76921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76921=edit Bug 20287: Fix tests expecting a warning The new Koha::Patron-based implementation encapsulates some error conditions that raised warnings and the tests expected that warning. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #35 from Jonathan Druart --- Created attachment 76922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76922=edit Bug 20287: Use more simple object for Object.t We initially use Koha::Patron to test Object.t, but now it overwrites ->store and so it is better to use a more simple object. ApiKey has foreign keys and unique key. We lost one test: there is only one unique key whereas we had 2 on borrowers (I did not find a better option) Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #36 from Jonathan Druart --- Created attachment 76923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76923=edit Bug 20287: Test exception DuplicateID for Koha::Patron->store Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #31 from Jonathan Druart --- Created attachment 76918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76918=edit Bug 20287: generate_userid now set the userid Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #25 from Jonathan Druart --- Created attachment 76912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76912=edit Bug 20287: Move ModMember to Koha::Patron Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #29 from Jonathan Druart --- Created attachment 76916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76916=edit Bug 20287: Replace ModMember in patrons import Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #30 from Jonathan Druart --- Created attachment 76917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76917=edit Bug 20287: Fix update of patrons, clean the data before ->store Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #26 from Jonathan Druart --- Created attachment 76913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76913=edit Bug 20287: ->store new deal with enrolment fee Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #27 from Jonathan Druart --- Created attachment 76914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76914=edit Bug 20287: Fix test t/db_dependent/Members.t and prevent regressions Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #28 from Jonathan Druart --- Created attachment 76915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76915=edit Bug 20287: There is a warning, we just want to unset the value here Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #19 from Jonathan Druart --- Created attachment 76906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76906=edit Bug 20287: Fix export issues in tests t/db_dependent/Holds/RevertWaitingStatus.t .. Undefined subroutine ::Circulation::MoveReserve called at /home/vagrant/kohaclone/C4/Circulation.pm line 1316. Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #20 from Jonathan Druart --- Created attachment 76907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76907=edit Bug 20287: Remove warning If there are no patrons in DB: Use of uninitialized value in addition (+) Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #21 from Jonathan Druart --- Created attachment 76908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76908=edit Bug 20287: New warning in t/db_dependent/Koha/Object.t (?) Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #24 from Jonathan Druart --- Created attachment 76911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76911=edit Bug 20287: Add plain_text_password (& Remove AddMember_Opac) But actually we could remove it if it does not make sense for other use. Callers could deal with it since the password is not generated here Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #22 from Jonathan Druart --- Created attachment 76909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76909=edit Bug 20287: Use DBIC transaction instead of AutoCommit=0 Remove error "Already in a transaction" Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #23 from Jonathan Druart --- Created attachment 76910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76910=edit Bug 20287: Remove AddMember_Auto I am not sure I understood the point of this subroutine. Did I miss something here? Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #18 from Jonathan Druart --- Created attachment 76905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76905=edit Bug 20287: Replace occurrences of AddMember with Koha::Patron->new->store->borrowernumber Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #16 from Jonathan Druart --- Created attachment 76903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76903=edit Bug 20287: Koha::Object->get_from_storage May be part of a separate bug report if needed TODO - add POD + tests Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #17 from Jonathan Druart --- Created attachment 76904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76904=edit Bug 20287: Move AddMember to Koha::Patron->store Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #15 from Jonathan Druart --- Created attachment 76902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76902=edit Bug 20287: Move trim values to a method Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 --- Comment #14 from Jonathan Druart --- Created attachment 76901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76901=edit Bug 20287: Move fixup_cardnumber Signed-off-by: Josef Moravec Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #9 from Jonathan Druart --- (In reply to Lisette Scheer from comment #6) > We are on 17.11.07.000. > On master on Sandbox It shows a bunch of tabs labeled "Status unknown (0)' > and a tab for whichever ones have at least 1 purchase suggestion with that > value. How did you do that? :) I have created a new suggestion on another sandbox (5) and there is only one tab! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 sandbo...@biblibre.com changed: What|Removed |Added Attachment #76872|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #8 from sandbo...@biblibre.com --- Created attachment 76900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76900=edit Bug 21048: Fix display of suggestion's status (SUGGEST_STATUS) When a suggestion's status is set to a customized value (AV SUGGEST_STATUS), the description is not always displayed correctly. Test plan: - Create different values for the AV SUGGEST_STATUS - Create several suggestions - Change the status using the SUGGEST_STATUS values - Edit the suggestion and change again the status - View the suggestions for a given patron (members/purchase-suggestions.pl?borrowernumber=XX), the statuses must displayed correctly Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com Status|Needs Signoff |Signed Off --- Comment #7 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Lisette Scheer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21048] suggest_status not behaving properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21048 --- Comment #6 from Lisette Scheer --- We are on 17.11.07.000. On master on Sandbox It shows a bunch of tabs labeled "Status unknown (0)' and a tab for whichever ones have at least 1 purchase suggestion with that value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 --- Comment #11 from Jonathan Druart --- Created attachment 76899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76899=edit Bug 21008: Use Koha::Patron->is_child Signed-off-by: Tomas Cohen Arazi Edit: I removed the category parameter as it is not really used. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21008] pay.pl and paycollect.pl raise warning
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21008 Jonathan Druart changed: What|Removed |Added Attachment #76766|0 |1 is obsolete|| Attachment #76767|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 76898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76898=edit Bug 21008: Use patron object to get category_type This patch makes borrower_add_additional_fields() in both pay.pl and paycollect.pl use the right object to pick the category_type. It also populates the extendedattributes template variable in pay.pl which was missed by a change. Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Jonathan Druart changed: What|Removed |Added Attachment #76761|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 76897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76897=edit Bug 21025: Add GetPreparedLetter to Koha::Patron::Discharge Test plan (shamelessly ripped from Bug20953): 1) Set system preference 'useDischarge' to 'Allow' 2) Choose a patron without checkouts nor fines nor restrictions 3) Log at OPAC and go to patron page /cgi-bin/koha/opac-user.pl 4) Click on 'ask for a discharge' tab => You see /cgi-bin/koha/opac-discharge.pl with text 'What is a discharge? ...' 5) Click on 'Ask for a discharge' link => You see /cgi-bin/koha/opac-discharge.pl?op=request with text 'Your discharge request has been sent ...' 6) In a new browser tab/page, go to intranet on /cgi-bin/koha/members/discharges.pl => You see one discharge requets for the patron => Click on 'allow' on patron discharge request 7) Come back to OPAC and refresh /cgi-bin/koha/opac-discharge.pl => You see link 'Get your discharge' 8) Click on the link to get your generated PDF => An error message should appear informing you to contact your website's admin 9) Apply this patch 10) Click again on the link to get your generated PDF => This time, a download prompt should appear Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21025] Koha::Patron::Discharge is missing use C4::Letters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21025 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Attachment #76588|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #75959|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12310] Decimal separators issues in patrons payments/fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 --- Comment #115 from Victor Grousset/tuxayo --- Created attachment 76896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76896=edit Bug 12310: (QA follow-up) Simplify DecimalSeparators syspref description Thanks Marcel for the new version :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 2696] Fine payments should show what was paid for
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Charles Quain changed: What|Removed |Added CC||c...@interleaf.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 19166] Add the ability to add adjustments to an invoice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19166 Charles Quain changed: What|Removed |Added CC||c...@interleaf.ie -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20564] Error 500 displays when uploading patron images with a zipped file
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20564 --- Comment #13 from Lucy Vaux-Harvey --- I've tried testing this patch on one of the sandboxes but can't access the Upload patron images tool at http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/tools/picture-upload.pl Software error is: Global symbol "$filename" requires explicit package name (did you forget to declare "my $filename"?) at /home/koha/src/tools/picture-upload.pl line 118. Execution of /home/koha/src/tools/picture-upload.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14446] Resolve "Use of uninitialized value in goto" in admin/preferences.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14446 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Attachment #76712|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21069] Koha::Patron->generate_userid use encourages a race condition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21069 Martin Renvoize changed: What|Removed |Added Depends on||20287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 [Bug 20287] Move AddMember and ModMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Blocks||21069 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21069 [Bug 21069] Koha::Patron->generate_userid use encourages a race condition -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21069] New: Koha::Patron->generate_userid use encourages a race condition
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21069 Bug ID: 21069 Summary: Koha::Patron->generate_userid use encourages a race condition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com We're using ->generate_userid followed later down a script by ->store in a number of places. This is a race condition whereby we could inadvertantly end up with duplicate userid's on the system. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |mag...@libriotech.no |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Blocks||21068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21068] NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 Martin Renvoize changed: What|Removed |Added Depends on||20287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 [Bug 20287] Move AddMember and ModMember to Koha::Patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21068] New: NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21068 Bug ID: 21068 Summary: NorwegianPatronDBEnable - Check for prior ModMember calls that passed 'sync' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When QAing Bug 20287 the one thing I wasn't 100% sure about was line 289 which we have marked with a FIXME. I could not find anywhere in koha that passed in a sync key to ModMember and as such we believe it was safe to remove it. This bug serves as a note to get Magnus to double check our assumptions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21047] Wrong koha to marc mapping on bibliosubtitle in SQL files
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21047 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA CC||n...@bywatersolutions.com --- Comment #5 from Nick Clemens --- I agree with Cait, we need an update here - frameworks with the wrong code cannot be edited (the koha field cannot anyways) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 --- Comment #10 from Jonathan Druart --- Created attachment 76895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76895=edit Bug 21022: (follow-up) Move overloaded full_message method to subclass We shouldn't have it overloaded on the base class, as it could get huge and difficult to find things, and read. This patch moves things to Koha::Exceptions::Object. We should overload the full_message method on each exceptions class, as needed. To test: - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Jonathan Druart changed: What|Removed |Added Attachment #76889|0 |1 is obsolete|| Attachment #76890|0 |1 is obsolete|| Attachment #76891|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 76893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76893=edit Bug 21022: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 --- Comment #9 from Jonathan Druart --- Created attachment 76894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76894=edit Bug 21022: Use passed message if present This patch makes 'full_message' use the passed exception message instead of trying to build it from the parameters. This is particularly useful for some situations in which we don't have all the information but would like to keep using the same exception. To test: - Apply this patchset - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20079] Display stack trace for development installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20079] Display stack trace for development installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Martin Renvoize changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20079] Display stack trace for development installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize --- A trivial patch that just serves to improves developers lives when working with plack :) I bet half of us are effectively running this way anyway.. going to go straight to Passed QA for this one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20079] Display stack trace for development installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21067] New: Under plack, 500 errors only show as "Internal Server Error"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21067 Bug ID: 21067 Summary: Under plack, 500 errors only show as "Internal Server Error" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When plack is not running, 500 errors will show the error message of the perl file where the error occurred, as well as a contact email address, something like this: 500 Internal Server Error Use of uninitialized value within @itemnumber in string ne at /usr/share/koha/intranet/cgi-bin/reserve/modrequest.pl line 70. To report a broken link or any other issue, please contact the Koha Administrator. (I think the text is actually from koha-tmpl/intranet-tmpl/prog/en/modules/errors/errorpage.tt) Under plack, all we see is Internal Server Error This means that a) Errors are less likely to be reported to the server administrator because there's no mailto. b) We can't immediately see the error message when the error is reported. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20079] Display stack trace for development installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20079 Martin Renvoize changed: What|Removed |Added Attachment #72341|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 76892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76892=edit Bug 20079: Display stack trace for development installations """The default value is development, which causes plackup to load the middleware components: AccessLog, StackTrace, and Lint unless --no-default-middleware is set.""" Test plan: Confirm that the stack trace is displayed when something is wrong (die somewhere to test) for dev installations (inside a devbox) The -E flag must remain deployment for non-dev installs Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #13 from Martin Renvoize --- This has now had at least two QA runs (Tomas and Myself) and I believe all outstanding QA failing issues are resolved. I'm going to Pass QA and suggest we catch any fallout between now and release and even with all of our eyes on it there's bound to have been something creep through. Jonathan has done a great job, thankyou very much. As a side note.. after having discussed a few issues with him I have a few followup bugs to create that relate to this but should not hold up it's continuance. One being a case where none of us was entirely 100% sure about where a 'sync' key was passed into ModBiblio in the pate for the NL syncing code (which I was going to asign to Magnus) and a second where a few pre-existing race conditions are made much more obvious by this work. Passing QA :) Jonathan, can you add Signoff lines for Josef, Tomas and Me :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #4) > Thx, Tomas! > > https://rt.cpan.org/Ticket/Display.html?id=125833 I still think we should have a 'CASVersion' syspref that controls this behaviour, until there's a response from the library maintainer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 --- Comment #4 from Katrin Fischer --- Thx, Tomas! https://rt.cpan.org/Ticket/Display.html?id=125833 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20769] Duplicate fine generated when lost item is returned with BlockReturnOfLostItems activated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20769 --- Comment #2 from Lucy Vaux-Harvey --- Hi Andrew, WhenLostForgiveFine is set to Don't forgive so a full duplicate fine is being charged. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21066] New: Use opac_news.timestamp as a real timestamp or add opac_news.updated_on ?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21066 Bug ID: 21066 Summary: Use opac_news.timestamp as a real timestamp or add opac_news.updated_on ? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org I would propose to use the opac_news.timestamp field readonly and fill/update it automatically via SQL. Or do we still need the original publish date and add a modified/updated_on timestamp? What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 --- Comment #3 from Tomás Cohen Arazi --- (In reply to Katrin Fischer from comment #2) > It could work - if people are ok with that. Cleaner would be fixing the > external module, but much harder to do :( Is there a bug filed for the Authen::CAS::Client library? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20265] Add syspref to hide news published date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20265
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Comment #10 from Marcel de Rooy ---
Dilan:
I have the impression that something like
.newsitem .newsfooter { display:none; }
does not really need a syspref.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 --- Comment #2 from Katrin Fischer --- It could work - if people are ok with that. Cleaner would be fixing the external module, but much harder to do :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11889] Disown a list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11889 --- Comment #37 from Marcel de Rooy --- Anyone having an idea how we can get this running again ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Seems sane, code is reasonable and well structured, signing off :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Martin Renvoize changed: What|Removed |Added Attachment #76572|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 76890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76890=edit Bug 21022: Use passed message if present This patch makes 'full_message' use the passed exception message instead of trying to build it from the parameters. This is particularly useful for some situations in which we don't have all the information but would like to keep using the same exception. To test: - Apply this patchset - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests pass! - Sign off Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Martin Renvoize changed: What|Removed |Added Attachment #76571|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 76889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76889=edit Bug 21022: Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21022] Exceptions should skip stringifying if message manually passed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21022 Martin Renvoize changed: What|Removed |Added Attachment #76573|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 76891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76891=edit Bug 21022: (follow-up) Move overloaded full_message method to subclass We shouldn't have it overloaded on the base class, as it could get huge and difficult to find things, and read. This patch moves things to Koha::Exceptions::Object. We should overload the full_message method on each exceptions class, as needed. To test: - Run: $ kshell k$ prove t/Koha/Exceptions.t => SUCCESS: Tests still pass! - Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #14 from Martin Renvoize --- Works as expected.. the $id and $originalid may both be populated if $match is used.. some of the logging in there is rather odd but that shouldn't require any fixes in this bug. Signing Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Martin Renvoize changed: What|Removed |Added Attachment #76885|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 76887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76887=edit Bug 20811: Fix wrong usage of ModBiblio Since commit cefa7c21e28b88351ee8ae0dfefb80a515323df9 Bug 5635: bulkmarcimport new parameters & features AddBiblio call has been replaced with ModBiblio, but the return values are different. We should not replace the value of $biblionumber with what returns this subroutine. Test plan: If you are familiar with bulkmarcimport.pl you should know what to test, I am not. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Martin Renvoize changed: What|Removed |Added Attachment #76886|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 76888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76888=edit Bug 20811: Fix update flag in bulkmarcimport I have no idea why we have these two variables $id and $originalid, it seems that they should not cohabit. It feels like Users and original authors of this script should provide an update and refresh it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Martin Renvoize changed: What|Removed |Added Attachment #76861|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 76886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76886=edit Bug 20811: Fix update flag in bulkmarcimport I have no idea why we have these two variables $id and $originalid, it seems that they should not cohabit. It feels like Users and original authors of this script should provide an update and refresh it. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20811] Fix wrong usage of ModBiblio in bulkmarcimport.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20811 Martin Renvoize changed: What|Removed |Added Attachment #75599|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 76885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76885=edit Bug 20811: Fix wrong usage of ModBiblio Since commit cefa7c21e28b88351ee8ae0dfefb80a515323df9 Bug 5635: bulkmarcimport new parameters & features AddBiblio call has been replaced with ModBiblio, but the return values are different. We should not replace the value of $biblionumber with what returns this subroutine. Test plan: If you are familiar with bulkmarcimport.pl you should know what to test, I am not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20854] Redirect after logout with CAS 3.0 broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20854 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #1 from Tomás Cohen Arazi --- Can we add a syspref to specify the CAS protocol version and have the behaviour adjust as required on each case? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21065] New: Data in accountoffsets and accountlines is deleted with the patron leaving gaps in financial reports
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21065 Bug ID: 21065 Summary: Data in accountoffsets and accountlines is deleted with the patron leaving gaps in financial reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The tables accountoffsets and accountlines are both "cleaned up" when a patron is deleted by using FK constraints. This is a problem because 1) The patrons have a "right to be forgotten" with GDPR and you can't refuse to delete them if their fines are paid etc. 2) Especially for partial payments and in other cases the data in accountlines and accountoffsets is neded to create reliable reports for statistics, but also for financial reports. It's not possible to determine from other tables like statistics and action_logs what fines are linked to which payment which doesn't allow to create reports by fine/fee type and similar. Instead of deleting the info, we should really just anonymize it. -- CREATE TABLE `accountoffsets` ( `borrowernumber` int(11) NOT NULL DEFAULT '0', `accountno` smallint(6) NOT NULL DEFAULT '0', `offsetaccount` smallint(6) NOT NULL DEFAULT '0', `offsetamount` decimal(28,6) DEFAULT NULL, `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, KEY `accountoffsets_ibfk_1` (`borrowernumber`), CONSTRAINT `accountoffsets_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; CREATE TABLE `accountlines` ( `accountlines_id` int(11) NOT NULL AUTO_INCREMENT, `issue_id` int(11) DEFAULT NULL, `borrowernumber` int(11) NOT NULL DEFAULT '0', `accountno` smallint(6) NOT NULL DEFAULT '0', `itemnumber` int(11) DEFAULT NULL, `date` date DEFAULT NULL, `amount` decimal(28,6) DEFAULT NULL, `description` mediumtext COLLATE utf8_unicode_ci, `dispute` mediumtext COLLATE utf8_unicode_ci, `accounttype` varchar(5) COLLATE utf8_unicode_ci DEFAULT NULL, `amountoutstanding` decimal(28,6) DEFAULT NULL, `lastincrement` decimal(28,6) DEFAULT NULL, `timestamp` timestamp NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP, `notify_id` int(11) NOT NULL DEFAULT '0', `notify_level` int(2) NOT NULL DEFAULT '0', `note` text COLLATE utf8_unicode_ci, `manager_id` int(11) DEFAULT NULL, PRIMARY KEY (`accountlines_id`), KEY `acctsborridx` (`borrowernumber`), KEY `timeidx` (`timestamp`), KEY `itemnumber` (`itemnumber`), CONSTRAINT `accountlines_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE, CONSTRAINT `accountlines_ibfk_2` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE SET NULL ON UPDATE SET NULL ) ENGINE=InnoDB AUTO_INCREMENT=4666 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21056] Changing the logged in library can fail sporadically
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21056 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #3 from Kyle M Hall --- (In reply to Jonathan Druart from comment #2) > What is the value of SessionStorage? > > From CGI::Session: > """ > Always explicitly calling flush() on the session before the program exits is > recommended. For extra safety, call it immediately after every important > session update. > """ > > Maybe we should add this line below (there is another ->param call later). > > It sounds like we should put some flush call to C4::Auth as well. I certainly wouldn't hurt! Do you want to just add that as a followup here, or do you want to file a separate bug? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Katrin Fischer changed: What|Removed |Added Severity|normal |major --- Comment #2 from Katrin Fischer --- Upping severity a bit - keeping potential sensitive data about patrons with no way to delete them aside from SQL is not good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13518] Table borrower_modifications is missing FK and not deleted with the patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13518 Katrin Fischer changed: What|Removed |Added Severity|normal |major --- Comment #1 from Katrin Fischer --- Upping severity a bit - storing patron information that is/can never be deleted outside of SQL is not nice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21032] Refining a search made on a specific index fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 --- Comment #5 from Séverine Queune --- Tested in our 2 different instances (dev and test) and both work ! The problem I mentioned on comment 2 seems to be specific to the sandbox. Thank you Alex ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21032] Refining a search made on a specific index fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Séverine Queune changed: What|Removed |Added Attachment #76653|0 |1 is obsolete|| --- Comment #4 from Séverine Queune --- Created attachment 76884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76884=edit Bug 21032 - fix using facet for searches made on specific index Test plan: - Try a simple search (OPAC or staff) like "title:foo", - click on a facet: badaboum! - apply this patch, - retry Signed-off-by: Séverine QUEUNE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 21032] Refining a search made on a specific index fail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21032 Séverine Queune changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 20084] Patron card creator: layouts Industrial2of5 and COOP2of5 broken with error "Invalid Characters"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20084 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #11 from Martin Renvoize --- Fairly trivial fix, I can't find any regressions and the QA scripts pass.. i'd love to see accompanying tests, but that can wait as we're in C4. Passing QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
